Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 20:31:03 +0100, Michal Privoznik wrote: > On 11/18/20 11:24 AM, Peter Krempa wrote: > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: [...] > Would it make sense to relax the current limitation in libvirt and allow > (which is meant for cases where the

Re: [PATCH 1/2] hyperv: XML parsing of storage volumes

2020-11-18 Thread Matt Coleman
> On Nov 18, 2020, at 1:48 PM, Matt Coleman wrote: > > +if (!(disk = virDomainDiskDefNew(priv->xmlopt))) { > > +if (!(disk = virDomainDiskDefNew(priv->xmlopt))) { I forgot to include changes to hyperv_private.h in this commit. Please squash the following additional change with this

[PATCH] NEWS: support phytium processor

2020-11-18 Thread yangshaojun19
From: Shaojun Yang FT-2000+ and Tengyun-S2500 are two chips by produced by Phytium Technology Co., Ltd., which based on ARMv8 architecture. Shaojun Yang (1): add phytium FT-2000+ and Tengyun-S2500 support on arm architecture. src/cpu_map/arm_FT-2000plus.xml | 6 ++

[PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-18 Thread yangshaojun19
From: Shaojun Yang Signed-off-by: Shaojun Yang --- src/cpu_map/arm_FT-2000plus.xml | 6 ++ src/cpu_map/arm_Tengyun-S2500.xml | 6 ++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 4 src/cpu_map/meson.build | 2 ++ 5 files changed, 19

[PATCH] virsh: Added attach-disk support for network disk

2020-11-18 Thread Ryan Gahagan
Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by: Ryan Gahagan ---

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-18 Thread Jamie Strandboge
On Tue, 17 Nov 2020, Neal Gompa wrote: > On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt > wrote: > > > > On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik > > wrote: > > > > > > On 11/16/20 1:26 PM, Christian Ehrhardt wrote: > > > > 'kvm-spice' is a binary name used to call 'kvm' which

[PATCH 2/2] schema: add support for Windows file paths and device names

2020-11-18 Thread Matt Coleman
Signed-off-by: Matt Coleman --- docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 5 +++- .../disk-hyperv-physical.xml | 17 ++ .../disk-hyperv-virtual.xml | 17 ++

[PATCH 0/2] hyperv: storage volume XML changes

2020-11-18 Thread Matt Coleman
Here's a GitLab MR if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits Matt Coleman (2): hyperv: XML parsing of storage volumes schema: add support for Windows file paths and device names docs/schemas/basictypes.rng |

[PATCH 1/2] hyperv: XML parsing of storage volumes

2020-11-18 Thread Matt Coleman
dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 408 +-

[PATCH] util: convert char pointers to use g_autofree

2020-11-18 Thread Ryan Gahagan
From: Barrett Schonefeld additional conversions to the GLib API in src/util per issue #11. Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11 Signed-off-by: Barrett Schonefeld --- src/util/vircgroupv1.c | 3 +- src/util/virdnsmasq.c| 43 -

Re: [PATCH 00/23] hyperv: storage volume XML changes

2020-11-18 Thread Matt Coleman
Completely botched this submission. Disregard this thread... :shame-emoji: -- Matt

[PATCH 01/23] hyperv: XML parsing of storage volumes

2020-11-18 Thread Matt Coleman
dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 408 +-

[PATCH 00/23] hyperv: storage volume XML changes

2020-11-18 Thread Matt Coleman
Here's a GitLab MR if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits Matt Coleman (23): hyperv: XML parsing of storage volumes schema: add support for Windows file paths and device names hyperv: ambiguous VM names will throw an error

Re: [PATCH] util: convert char pointers to use g_autofree

2020-11-18 Thread Barrett J Schonefeld
I spent a significant chunk of time trying to get `git send-email` working but struggled to get the tool to work on my computer. I instead used the `Email Patch` feature in GitLab to format the patch as an email. Since the formatting is wrong, I may have someone submit the patch on my behalf.

[libvirt PATCH 0/2] Add more documentation for migrations over UNIX sockets

2020-11-18 Thread Martin Kletzander
Few words about SELinux that might not be very clear to some. Martin Kletzander (2): qemu: Disable NBD TLS migration over UNIX socket docs: Document SELinux caveats when migrating over UNIX sockets docs/manpages/virsh.rst | 9 - docs/migration.html.in| 9 +

[libvirt PATCH 1/2] qemu: Disable NBD TLS migration over UNIX socket

2020-11-18 Thread Martin Kletzander
Even though it is technically possible, when running the migrations QEMU's nbd-server-start errors out with: "TLS is only supported with IPv4/IPv6" We can always enable it when QEMU adds this feature, but for now it is safer to show our error message rather than rely on QEMU to error out

[libvirt PATCH 2/2] docs: Document SELinux caveats when migrating over UNIX sockets

2020-11-18 Thread Martin Kletzander
The information about sockets having different label than the one on the file and the way it needs to be set is very difficult to find for those who did not come across it before. Let's describe what needs to happen in order for the migration to go through rather than rely on general knowledge of

[PATCH v2 6/6] qemu_domain.c: align all pSeries mem modules when PARSE_ABI_UPDATE

2020-11-18 Thread Daniel Henrique Barboza
qemuDomainAlignMemorySizes() has an operation order problem. We are calculating 'initialmem' without aligning the memory modules first. Since we're aligning the dimms afterwards this can create inconsistencies in the end result. x86 has alignment of 1-2MiB and it's not severely impacted by it, but

[PATCH v2 4/6] qemuxml2xmltest.c: honor ARG_PARSEFLAGS

2020-11-18 Thread Daniel Henrique Barboza
At this moment, it is not possible to create a test specifying ARG_PARSEFLAGS because info->parseFlags is not being forwarded to testCompareDomXML2XMLFiles(). Let's fix it now so next patch can make use of it. Signed-off-by: Daniel Henrique Barboza --- tests/qemuxml2xmltest.c | 6 -- 1

[PATCH v2 2/6] qemu: move memory size align to qemuProcessPrepareDomain()

2020-11-18 Thread Daniel Henrique Barboza
qemuBuildCommandLine() is calling qemuDomainAlignMemorySizes(), which is an operation that changes live XML and domain and has little to do with the command line build process. Move it to qemuProcessPrepareDomain() where we're supposed to make live XML and domain changes before launch.

[PATCH v2 5/6] qemu_domain.c: post parse pSeries NVDIMM align with PARSE_ABI_UPDATE

2020-11-18 Thread Daniel Henrique Barboza
A previous patch removed the pSeries NVDIMM align that wasn't being done properly. This patch reintroduces it in the right fashion, making it reliant on VIR_DOMAIN_DEF_PARSE_ABI_UPDATE. This makes it complying with the intended design defined by commit c7d7ba85a624. Since the PARSE_ABI_FLAG is

[PATCH v2 1/6] qemu_process.c: check migrateURI when setting VIR_QEMU_PROCESS_START_NEW

2020-11-18 Thread Daniel Henrique Barboza
qemuProcessCreatePretendCmdPrepare() is setting the VIR_QEMU_PROCESS_START_NEW regardless of whether this is a migration case or not. This behavior differs from what we're doing in qemuProcessStart(), where the flag is set only if !migrate && !snapshot. Fix it by making the flag setting

[PATCH v2 3/6] Revert "domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefPostParse()"

2020-11-18 Thread Daniel Henrique Barboza
The code to align ppc64 NVDIMMs on post parse was introduced in commit d3f3c2c97f9b. That commit failed to realize that we can't align memory unconditionally. As of commit c7d7ba85a624 ("qemu: command: Align memory sizes only on fresh starts"), all memory alignment should be executed only when

[PATCH v2 0/6] add post parse pSeries mem align, when ABI_UPDATE

2020-11-18 Thread Daniel Henrique Barboza
Hi, This is a follow up of [1] after really comprehending what I was messing with and what I couldn't do. This version has a shorter scope, only pSeries guests are being taken care of. I can send a follow up to handle x86 as well depending on the popularity of this work. Patches 1 and 2 moves

Re: Libvirt NVME support

2020-11-18 Thread Michal Privoznik
On 11/18/20 11:24 AM, Peter Krempa wrote: On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: As a separate question, is there any performance benefit of emulating a NVMe controller compared to e.g. virtio-scsi? We haven't measured that yet; I would expect it to be slight faster

Re: [PATCH] util: convert char pointers to use g_autofree

2020-11-18 Thread Michal Privoznik
On 11/17/20 9:45 PM, Barrett J Schonefeld wrote: From 82f992c7ff4ef59682f42c863fca242dd84208f9 Mon Sep 17 00:00:00 2001 From: Barrett Schonefeld Date: Mon, 9 Nov 2020 16:07:25 -0600 Subject: [PATCH] util: convert char pointers to use g_autofree additional conversions to the GLib API in

[libvirt PATCH 10/10] tests: add minimal XML example for sparc VM

2020-11-18 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/qemuxml2argvdata/sparc-minimal.args | 34 +++ tests/qemuxml2argvdata/sparc-minimal.xml | 21 ++ tests/qemuxml2argvtest.c | 3 ++ 3 files changed, 58 insertions(+) create mode 100644

[libvirt PATCH 09/10] tests: define QEMU driver capabilities for sparc architecture

2020-11-18 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/testutilsqemu.c | 62 ++- 1 file changed, 37 insertions(+), 25 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 23a9777fd8..906fdf5c1a 100644 --- a/tests/testutilsqemu.c +++

[libvirt PATCH 07/10] tests: add fake host CPU for sparc architecture

2020-11-18 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- tests/testutilshostcpus.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/testutilshostcpus.h b/tests/testutilshostcpus.h index a54b181c09..91d9c153d9 100644 --- a/tests/testutilshostcpus.h +++ b/tests/testutilshostcpus.h @@ -130,6

[libvirt PATCH 06/10] qemu: enable support for ESP SCSI controller family

2020-11-18 Thread Daniel P . Berrangé
The NCR53C90 is the built-in SCSI controller on all sparc machine types, but not sparc64. Note that it has the fixed alias "scsi", which differs from our normal naming convention of "scsi0". The DC390 and AM53C974 are PCI SCSI controllers that can be added to any PCI machine. Signed-off-by:

[libvirt PATCH 05/10] qemu: add capabilities for the three ESP family SCSI controllers

2020-11-18 Thread Daniel P . Berrangé
Probing for the NCR53C90 controller is a little unusual. The qom-list-types QMP command returns a list of all types known to the QEMU binary. It does not distinguish devices which are user creatable from those which are built-in. Any QEMU target that supports PCI will have the DC390 / AM53C974

[libvirt PATCH 04/10] conf: add support for ESP SCSI controller family

2020-11-18 Thread Daniel P . Berrangé
The NCR53C90 is the built-in SCSI controller on all sparc machine types, and some mips and m68k machine types. The DC390 and AM53C974 are PCI SCSI controllers that can be added to any PCI machine. These are only interesting for emulating obsolete hardware platforms. Signed-off-by: Daniel P.

[libvirt PATCH 03/10] qemu: add helper method for checking if ESP SCSI is builtin

2020-11-18 Thread Daniel P . Berrangé
The NCR53C90 ESP SCSI controller is only usable when built-in to the machine type. This method will facilitate checking that restriction across many places. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_domain.c | 17 + src/qemu/qemu_domain.h | 1 + 2 files changed, 18

[libvirt PATCH 00/10] add support for ESP SCSI controller family

2020-11-18 Thread Daniel P . Berrangé
The sparc machines types all have an NCR53C90 SCSI Controller builtin. This is from the ESP family of SCSI controllers which includs two PCI variants. Wire up support for all these SCSI controllers, so we can at least launch a sparc VM with disks attached. There are likely other gaps in CLI

[libvirt PATCH 02/10] qemu: fix default devices on sparc machines

2020-11-18 Thread Daniel P . Berrangé
The sparc machines have little in common with sparc64 machines. No sparc machine type includes a PCI bus, so we should not be adding one to the XML. This further means that we should not be adding a memory balloon device, nor USB controller as these are both PCI based. Signed-off-by: Daniel P.

[libvirt PATCH 01/10] util: add ARCH_IS_MIPS64 helper macro

2020-11-18 Thread Daniel P . Berrangé
In most cases logic for MIPS64 and MIPS64EL will be identical. Signed-off-by: Daniel P. Berrangé --- src/util/virarch.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/virarch.h b/src/util/virarch.h index 46b4609dd5..528f84f8a5 100644 --- a/src/util/virarch.h +++

Re: [libvirt PATCH] virt-host-validate: fix detection with cgroups v2

2020-11-18 Thread Michal Privoznik
On 11/18/20 1:48 PM, Pavel Hrdina wrote: Using virtCgroupNewSelf() is not correct with cgroups v2 because the the virt-host-validate process is executed from from the same cgroup context as the terminal and usually not all controllers are enabled by default. To do a proper check we need to use

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

2020-11-18 Thread Michal Privoznik
On 11/18/20 2:52 PM, Erik Skultety wrote: On Wed, Nov 18, 2020 at 01:06:07PM +0100, Michal Privoznik wrote: The way our domain capabilities work currently, is that we have virDomainCapsEnum struct which contains 'unsigned int values' member which serves as a bitmask. More complicated structs

[PATCH libvirt v1] tests: add capabilities for QEMU 5.1.0 on s390x

2020-11-18 Thread Shalini Chellathurai Saroja
Signed-off-by: Shalini Chellathurai Saroja --- The replies file is removed from this patch and is available in https://gitlab.com/shalinichellathurai/libvirt/-/commit/1c34c07c434560d7f44212ce0bbbc8bf92490622 tests/domaincapsdata/qemu_5.1.0.s390x.xml | 230 + .../caps_5.1.0.s390x.replies

[libvirt PATCH] NEWS: restore backtick balance

2020-11-18 Thread Ján Tomko
Signed-off-by: Ján Tomko Reported-by: Michal Prívozník Fixes: db98d17709eeb13603730352a70f3817becd7372 --- Pushed. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 807f52..aa8a217eb6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,7 +33,7

Re: [PATCH v3 6/6] news: Document recent OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
On 11/18/20 3:31 PM, Peter Krempa wrote: On Wed, Nov 18, 2020 at 14:34:24 +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Peter Krempa I've pushed these. Thank you for all three rounds of review!

[libvirt PATCH v2 9/9] cpu_map: Add missing feature fsrm

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1 + 3 files changed, 5 insertions(+) diff --git

[libvirt PATCH v2 8/9] cpu_map: sync_qemu_cpu_i386: Detect features missing in libvirt

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 17 + 1 file changed, 17 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 69114c5bb6..4743161b0c 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v2 7/9] cpu_map: sync_qemu_cpu_i386: Add missing features

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index b27e5793ff..69114c5bb6 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@ -32,6

[libvirt PATCH v2 4/9] cpu_map: sync_qemu_cpu_i386: Do not ignore CPUID_EXT_MONITOR

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 6a5a02dbd1..21981c58f1 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v2 2/9] cpu_map: sync_qemu_cpu_i386: Factor out translation of vendors

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 82413d831e..fe95f26511 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v2 6/9] cpu_map: sync_qemu_cpu_i386: Translate qemu feature pretty names

2020-11-18 Thread Tim Wiederhake
If a feature is added (or removed) in a QEMU CPU model version, we get to see the QEMU pretty name for the feature, not the name of the macro. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py

[libvirt PATCH v2 5/9] cpu_map: sync_qemu_cpu_i386: Simplify ignore features

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 21981c58f1..2219e67454 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v2 3/9] cpu_map: sync_qemu_cpu_i386: Factor out translation of features

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 291 +- 1 file changed, 149 insertions(+), 142 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index fe95f26511..6a5a02dbd1 100755 ---

[libvirt PATCH v2 0/9] Add missing feature detection to sync tool in cpu_map

2020-11-18 Thread Tim Wiederhake
sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu with libvirt. It currently has no provisions for detecting new features that are not implemented in libvirt yet. This series changes that. Currently missing x86 CPU models: * "Denverton" * "KnightsMill" * "Snowridge"

[libvirt PATCH v2 1/9] cpu_map: sync_qemu_cpu_i386: Translate features in model versions

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 8deda869df..82413d831e 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@

Re: [PATCH v3 6/6] news: Document recent OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 14:34:24 +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Peter Krempa

Re: [PATCH v3 3/6] virsh: Expose OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 14:34:21 +0100, Michal Privoznik wrote: > The new virsh commands are: > > get-user-sshkeys > set-user-sshkeys > > Signed-off-by: Michal Privoznik > --- > docs/manpages/virsh.rst | 38 ++ > tools/virsh-domain.c| 164

[libvirt PATCH] qemu_conf: fix a typo in comment

2020-11-18 Thread Ján Tomko
Ceci n'est pas un objet. Signed-off-by: Ján Tomko Fixes: 7db61843b05a6e4295b1d2e27a3d86f162ef04a0 --- Pushed under the surreal rule. src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 80ff18204e..83de26ab56

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

2020-11-18 Thread Erik Skultety
On Wed, Nov 18, 2020 at 01:06:07PM +0100, Michal Privoznik wrote: > The way our domain capabilities work currently, is that we have > virDomainCapsEnum struct which contains 'unsigned int values' > member which serves as a bitmask. More complicated structs are > composed from this struct, giving

[PATCH v3 4/6] qemu_agent: add qemuAgentSSH{Add, Remove, Get}AuthorizedKeys

2020-11-18 Thread Michal Privoznik
From: Marc-André Lureau In QEMU 5.2, the guest agent learned to manipulate a user ~/.ssh/authorized_keys. Bind the JSON API to libvirt. https://wiki.qemu.org/ChangeLog/5.2#Guest_agent Signed-off-by: Marc-André Lureau Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa ---

[PATCH v3 6/6] news: Document recent OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 16e75c5c3f..807f52 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -24,6 +24,13 @@ v6.10.0 (unreleased) * **New features** + * qemu: Implement OpenSSH authorized

[PATCH v3 5/6] qemu: Implement OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1888537 Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 81 ++ 1 file changed, 81 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[PATCH v3 3/6] virsh: Expose OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
The new virsh commands are: get-user-sshkeys set-user-sshkeys Signed-off-by: Michal Privoznik --- docs/manpages/virsh.rst | 38 ++ tools/virsh-domain.c| 164 2 files changed, 202 insertions(+) diff --git a/docs/manpages/virsh.rst

[PATCH v3 2/6] remote: Implement OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
Since both APIs accept/return an array of strings we can't have client/server dispatch code generated. But implementation is fairly trivial, although verbose. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/remote/remote_daemon_dispatch.c | 82 +++

[PATCH v3 0/6] Introduce OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
v3 of: https://www.redhat.com/archives/libvir-list/2020-November/msg00821.html diff to v2: - some patches are reviewed already, I'm sending them for completeness. - worked in Peter's review of v2: virsh set-user-sshkeys semantics change (append behaviour is the default), allocate N+1 keys to

[PATCH v3 1/6] Introduce OpenSSH authorized key file mgmt APIs

2020-11-18 Thread Michal Privoznik
When setting up a new guest or when a management software wants to allow access to an existing guest the virDomainSetUserPassword() API can be used, but that might be not good enough if user want to ssh into the guest. Not only sshd has to be configured to accept password authentication (which is

[libvirt PATCH] virt-host-validate: fix detection with cgroups v2

2020-11-18 Thread Pavel Hrdina
Using virtCgroupNewSelf() is not correct with cgroups v2 because the the virt-host-validate process is executed from from the same cgroup context as the terminal and usually not all controllers are enabled by default. To do a proper check we need to use the root cgroup to see what controllers are

Re: [PATCH] news: Mention Cooperlake cpu model in v6.4.0

2020-11-18 Thread Martin Kletzander
On Fri, Nov 06, 2020 at 03:25:17PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-06 at 15:10 +0100, Martin Kletzander wrote: On Wed, Oct 28, 2020 at 03:51:48PM +0800, Han Han wrote: > Signed-off-by: Han Han > --- > NEWS.rst | 2 ++ > 1 file changed, 2 insertions(+) So yes, this was added in

Re: [libvirt PATCH 0/3] Add missing feature detection to sync tool in cpu_map

2020-11-18 Thread Tim Wiederhake
On Wed, 2020-11-18 at 12:19 +0100, Tim Wiederhake wrote: > sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from > qemu > with libvirt. It currently has no provisions for detecting new > features > that are not implemented in libvirt yet. This series changes that. > > See also >

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

2020-11-18 Thread Martin Kletzander
On Wed, Nov 18, 2020 at 05:40:04PM +0800, Zhong, Luyao wrote: On 11/12/2020 5:27 PM, Martin Kletzander wrote: On Thu, Nov 12, 2020 at 02:19:06PM +0800, Zhong, Luyao wrote: On 11/9/2020 7:21 PM, Martin Kletzander wrote: On Sat, Nov 07, 2020 at 10:41:52AM +0800, Zhong, Luyao wrote: On

[PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

2020-11-18 Thread Michal Privoznik
The way our domain capabilities work currently, is that we have virDomainCapsEnum struct which contains 'unsigned int values' member which serves as a bitmask. More complicated structs are composed from this struct, giving us whole virDomainCaps eventually. Whenever we want to report that a

Re: [PATCH v1 02/10] qemu_domain.c: align memory modules before calculating 'initialmem'

2020-11-18 Thread Daniel Henrique Barboza
On 11/18/20 4:44 AM, Peter Krempa wrote: On Mon, Nov 16, 2020 at 20:43:09 +0100, Andrea Bolognani wrote: On Fri, 2020-11-13 at 16:23 -0300, Daniel Henrique Barboza wrote: On 11/13/20 10:51 AM, Andrea Bolognani wrote: I only skimmed the remaining patches and didn't dig into the code as

[libvirt PATCH 3/3] cpu_map: sync_qemu_i386: Detect features missing in libvirt

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 684fc96dc0..8844aa00cd 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH 2/3] cpu_map: sync_qemu_i386: Add features missing in translation table

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 8 1 file changed, 8 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index fb4eea101b..684fc96dc0 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@

[libvirt PATCH 0/3] Add missing feature detection to sync tool in cpu_map

2020-11-18 Thread Tim Wiederhake
sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu with libvirt. It currently has no provisions for detecting new features that are not implemented in libvirt yet. This series changes that. See also https://www.redhat.com/archives/libvir-list/2020-November/msg00271.html.

[libvirt PATCH 1/3] cpu_map: sync_qemu_i386: Detect features missing in translation table

2020-11-18 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 8deda869df..fb4eea101b 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

Re: [PATCH v1 02/10] qemu_domain.c: align memory modules before calculating 'initialmem'

2020-11-18 Thread Daniel Henrique Barboza
On 11/16/20 4:43 PM, Andrea Bolognani wrote: On Fri, 2020-11-13 at 16:23 -0300, Daniel Henrique Barboza wrote: On 11/13/20 10:51 AM, Andrea Bolognani wrote: I only skimmed the remaining patches and didn't dig into the code as much, or as recently, as you have, but from a high-level

Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > As a separate question, is there any performance benefit of emulating a > > NVMe controller compared to e.g. virtio-scsi? > > We haven't measured that yet; I would expect it to be slight faster and/or > more > CPU efficient but

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-18 Thread Christian Ehrhardt
On Wed, Nov 18, 2020 at 10:38 AM Daniel P. Berrangé wrote: > > On Tue, Nov 17, 2020 at 09:11:48PM -0500, Neal Gompa wrote: > > On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt > > wrote: > > > > > > On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik > > > wrote: > > > > > > > > On 11/16/20

RE: Libvirt NVME support

2020-11-18 Thread Thanos Makatos
> As a separate question, is there any performance benefit of emulating a > NVMe controller compared to e.g. virtio-scsi? We haven't measured that yet; I would expect it to be slight faster and/or more CPU efficient but wouldn't be surprised if it isn't. The main benefit of using NVMe is that we

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-18 Thread Michal Privoznik
On 11/18/20 3:11 AM, Neal Gompa wrote: On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt wrote: On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik wrote: On 11/16/20 1:26 PM, Christian Ehrhardt wrote: 'kvm-spice' is a binary name used to call 'kvm' which actually is a wrapper around

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

2020-11-18 Thread Zhong, Luyao
On 11/12/2020 5:27 PM, Martin Kletzander wrote: On Thu, Nov 12, 2020 at 02:19:06PM +0800, Zhong, Luyao wrote: On 11/9/2020 7:21 PM, Martin Kletzander wrote: On Sat, Nov 07, 2020 at 10:41:52AM +0800, Zhong, Luyao wrote: On 11/4/2020 9:02 PM, Martin Kletzander wrote: On Fri, Oct 16,

[PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-18 Thread Stefan Weil
Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil --- docs/can.txt | 8 docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +- docs/system/deprecated.rst| 4 ++--

Re: [libvirt PATCH 05/16] docs: add manpage for virtbhyved

2020-11-18 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 03:01:56PM -0500, Ryan Moeller wrote: > On Tue, Nov 17, 2020 at 12:03 PM Daniel P. Berrangé > wrote: > > > > This is an adaptation of the libvirtd manpage. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/manpages/index.rst | 7 ++ > >

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

2020-11-18 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 09:11:48PM -0500, Neal Gompa wrote: > On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt > wrote: > > > > On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik > > wrote: > > > > > > On 11/16/20 1:26 PM, Christian Ehrhardt wrote: > > > > 'kvm-spice' is a binary name used to

Re: [PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

2020-11-18 Thread Andrea Bolognani
On Wed, 2020-11-18 at 09:06 +0800, yangshaoju...@163.com wrote: > From: Shaojun Yang > > Signed-off-by: Shaojun Yang > --- > src/cpu_map/arm_Phytium.xml | 10 ++ > src/cpu_map/arm_vendors.xml | 1 + > src/cpu_map/index.xml | 3 +++ > 3 files changed, 14 insertions(+) > create

Re: [PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 09:41:44 +0100, Michal Privoznik wrote: > On 11/18/20 9:32 AM, Peter Krempa wrote: > > On Wed, Nov 18, 2020 at 09:12:26 +0100, Michal Privoznik wrote: > > > On 11/18/20 8:59 AM, Peter Krempa wrote: > > > > On Tue, Nov 17, 2020 at 12:28:27 +0100, Michal Privoznik wrote: > >

Re: [PATCH] virsh: Added attach-disk support for network disk

2020-11-18 Thread Peter Krempa
On Mon, Nov 16, 2020 at 18:03:24 -0600, Ryan Gahagan wrote: I'd like to reiterate that you should avoid top-posts on technical lists. Even if you copy the context into the top post. Please always respond inline. > > > + > > > /* Make XML of disk */ > > > virBufferAsprintf(, " > >

Re: [PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-18 Thread Michal Privoznik
On 11/18/20 9:32 AM, Peter Krempa wrote: On Wed, Nov 18, 2020 at 09:12:26 +0100, Michal Privoznik wrote: On 11/18/20 8:59 AM, Peter Krempa wrote: On Tue, Nov 17, 2020 at 12:28:27 +0100, Michal Privoznik wrote: Similarly to previous commits, we can utilize domCaps to check if graphics type is

Re: [PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-18 Thread Peter Krempa
On Wed, Nov 18, 2020 at 09:12:26 +0100, Michal Privoznik wrote: > On 11/18/20 8:59 AM, Peter Krempa wrote: > > On Tue, Nov 17, 2020 at 12:28:27 +0100, Michal Privoznik wrote: > > > Similarly to previous commits, we can utilize domCaps to check if > > > graphics type is supported. > > > > > >

Re: [PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-18 Thread Paolo Bonzini
On 17/11/20 20:34, Stefan Weil wrote: Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil --- docs/can.txt | 8 docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +-

Re: Libvirt NVME support

2020-11-18 Thread Peter Krempa
On Mon, Nov 16, 2020 at 23:01:00 +, Suraj Kasi wrote: > Hi Peter, > > Just wanted to follow up. As Thanos mentioned that we want a virtual NVMe > controller in the guest for which the support doesn't yet exist in libvirt. > Is it something that would be accepted if we were to implement it?

Re: [PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-18 Thread Michal Privoznik
On 11/18/20 8:59 AM, Peter Krempa wrote: On Tue, Nov 17, 2020 at 12:28:27 +0100, Michal Privoznik wrote: Similarly to previous commits, we can utilize domCaps to check if graphics type is supported. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +-

Re: [PATCH 5/5] qemu_validate: Deduplicate code for graphics type check

2020-11-18 Thread Peter Krempa
On Tue, Nov 17, 2020 at 12:28:27 +0100, Michal Privoznik wrote: > Similarly to previous commits, we can utilize domCaps to check if > graphics type is supported. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_capabilities.c | 2 +- > src/qemu/qemu_capabilities.h | 3 +++ >