Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

On 11/19/20 3:54 PM, Jin Yan wrote: On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on       libvirt version: 6.2.0       SELinux mode: permissive Steps: 1. start a vm configured with

Re: [PATCH 4/4] ci: Run test suite on macOS

On 11/13/20 8:08 PM, Andrea Bolognani wrote: On Fri, 2020-11-13 at 16:58 +0100, Michal Privoznik wrote: On 11/8/20 10:24 PM, Roman Bolshakov wrote: -- if test "$(uname)" = "FreeBSD"; then ninja -C build dist; fi -- if test "$(uname)" = "Darwin"; then ninja -C build && ninja -C build

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

On 11/18/2020 8:42 PM, Martin Kletzander wrote: On Wed, Nov 18, 2020 at 05:40:04PM +0800, Zhong, Luyao wrote: On 11/12/2020 5:27 PM, Martin Kletzander wrote: On Thu, Nov 12, 2020 at 02:19:06PM +0800, Zhong, Luyao wrote: On 11/9/2020 7:21 PM, Martin Kletzander wrote: On Sat, Nov 07,

[PATCH v2 0/2] hyperv: storage volume XML changes

Changes since V1: * fixed a leaky loop * uses both channels of a single IDE controller Here's a GitLab MR if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits Matt Coleman (2): hyperv: XML parsing of storage volumes schema: add support for

[PATCH v2 1/2] hyperv: XML parsing of storage volumes

dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 419 +-

[PATCH v2 2/2] schema: add support for Windows file paths and device names

Signed-off-by: Matt Coleman --- docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 5 +++- .../disk-hyperv-physical.xml | 17 ++ .../disk-hyperv-virtual.xml | 17 ++

Re: [PATCH RESEND v1] xen: recognize device_model_override

On 11/19/20 12:58 PM, Olaf Hering wrote: Am Mon, 16 Nov 2020 19:48:28 -0700 schrieb Jim Fehlig : Adjust the code to parse this as . You also have to adjust all the failing {xl,xm}configtests. It seems one has to run 'ninja test'. Yes. See https://libvirt.org/hacking.html Can this be

Re: [PATCH] apparmor: allow kvm-spice compat wrapper

On 11/17/20 7:11 PM, Neal Gompa wrote: On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt wrote: On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik wrote: On 11/16/20 1:26 PM, Christian Ehrhardt wrote: 'kvm-spice' is a binary name used to call 'kvm' which actually is a wrapper around

Re: regression in meson build, AC_PATH_PROG lost

On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: > > Am Thu, 19 Nov 2020 22:15:27 +0100 > > schrieb Martin Kletzander : > > > > > Libvirt needs to be able to handle that missing binary at runtime anyway > > > > It

Re: regression in meson build, AC_PATH_PROG lost

On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: Am Thu, 19 Nov 2020 22:15:27 +0100 schrieb Martin Kletzander : Libvirt needs to be able to handle that missing binary at runtime anyway It also needs to handle an existing binary. Just how is it supposed to handle it? Um... run

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani wrote: > > On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote: > > On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > > > Since meson does not support environment variables it seems the > > > only way to address this is to introduce

Issue 90 Further Clarifications

[image: Dustan Helm] Dustan Helm @dustan.helm · just now Before we start making

Re: [PATCH 1/2] hyperv: XML parsing of storage volumes

> On Nov 19, 2020, at 12:01 PM, Laine Stump wrote: > > On 11/19/20 8:38 AM, Daniel P. Berrangé wrote: >> On Wed, Nov 18, 2020 at 01:48:24PM -0500, Matt Coleman wrote: >>> +#define HYPERV_MAX_IDE_CONTROLLERS 2 >> Is it really possible to have 2 IDE controllers ? > > > I know nothing about

Re: [PATCH 1/2] hyperv: XML parsing of storage volumes

> On Nov 19, 2020, at 8:38 AM, Daniel P. Berrangé wrote: > > On Wed, Nov 18, 2020 at 01:48:24PM -0500, Matt Coleman wrote: >> >> +escapedDeviceId = g_strdup_printf("%s\"", entry->data->InstanceID); >> +escapedDeviceId = virStringReplace(escapedDeviceId, "\\", ""); > > This

Re: regression in meson build, AC_PATH_PROG lost

Am Thu, 19 Nov 2020 22:15:27 +0100 schrieb Martin Kletzander : > Libvirt needs to be able to handle that missing binary at runtime anyway It also needs to handle an existing binary. Just how is it supposed to handle it? Right now with meson it is either a full path, or just the name in case it

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 13, 2020 at 02:13:38PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote: On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote: > Since meson does not support environment variables it seems the > only way to address this is to introduce an

Re: [PATCH RESEND v1] xen: recognize device_model_override

Am Mon, 16 Nov 2020 19:48:28 -0700 schrieb Jim Fehlig : > > Adjust the code to parse this as . > You also have to adjust all the failing {xl,xm}configtests. It seems one has to run 'ninja test'. Can this be done via _multibuild in a libvirt-testsuite pkg in an isolated VM? > Correct. It is

Re: [PATCH 1/2] hyperv: XML parsing of storage volumes

On 11/19/20 8:38 AM, Daniel P. Berrangé wrote: On Wed, Nov 18, 2020 at 01:48:24PM -0500, Matt Coleman wrote: dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam

[PATCH 16/16] tests: virsh-checkpoint/snapshot: Mark as expensive

Signed-off-by: Peter Krempa --- tests/virsh-checkpoint | 2 ++ tests/virsh-snapshot | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/virsh-checkpoint b/tests/virsh-checkpoint index 92962d2205..2492d29f53 100755 --- a/tests/virsh-checkpoint +++ b/tests/virsh-checkpoint @@ -19,6

[PATCH 14/16] virsh: Added attach-disk support for network disk

From: Ryan Gahagan Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 Added in support for the following parameters in attach-disk: --source-protocol --source-host-name --source-host-socket --source-host-transport Added documentation to virsh.rst specifying usage. Signed-off-by:

[PATCH 13/16] virsh: cmdAttachDisk: Use virXMLFormatElement

Convert the code to the new XML formatting approach for simpler code and future additions. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 61 ++-- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/tools/virsh-domain.c

[PATCH 15/16] tests: virsh-output: Mark as expensive

The test takes more than a second on a beefy machine. While it's more useful than some expensive tests it's not worth running all the time. Signed-off-by: Peter Krempa --- tests/virsh-output | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/virsh-output b/tests/virsh-output index

[PATCH 12/16] virsh: cmdAttachDisk: Use enum for disk source type

For extendability and clarity add enum virshAttachDiskSourceType and use it to drive the XML formatting. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 68 +++- 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/tools/virsh-domain.c

[PATCH 11/16] virsh: virshAddress*: Move out of cmdAttachDisk block

The helper started as helper for cmdAttachDisk but is now used outside of it too. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 343 ++- 1 file changed, 172 insertions(+), 171 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c

[PATCH 10/16] virsh: Rename 'struct DiskAddress' and friends

Use 'virshAddress' prefix for all the related structs and enums. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 96 ++-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[PATCH 07/16] virsh: Extract address formatting from cmdAttachDiskFormatAddress

Introduce virshAddressFormat with code from cmdAttachDiskFormatAddress to format the address. Note that this patch fixes some whitespace inconsistencies in the formatted addresses. Signed-off-by: Peter Krempa --- tests/virsh-output.out | 42 +++--- tools/virsh-domain.c | 122

[PATCH 06/16] virsh: cmdAttachDisk: Split out formatting of disk address

First step is to remove all of the address handling code to a new function called 'cmdAttachDiskFormatAddress'. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 142 --- 1 file changed, 79 insertions(+), 63 deletions(-) diff --git

[PATCH 09/16] virsh: Refactor str2DiskAddress

Rewrite and rename the address parser. As a fallout the use of the removed 'str2PCIAddress' is replaced by virshAddressParse and virshAddressFormat. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 207 ++- 1 file changed, 67 insertions(+), 140

[PATCH 08/16] virsh: Unify code for

DISK_ADDR_TYPE_SATA, DISK_ADDR_TYPE_IDE and DISK_ADDR_TYPE_SCSI are driven by basically identical data types. Unify them. Note that changes to 'str2DiskAddress' are deliberately lazy as it will be refactored later. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 100

[PATCH 05/16] virsh: cmdAttachDisk: Don't assume type='block' if file can't be examined

'virsh attach-disk' uses stat() to determine if the 'source' is a regular file. If stat fails though it assumes that the file is block. Since it's way more common to have regular files and the detection does not work at all when accessing a remote host, modify the default to assume type='file' by

[PATCH 03/16] virsh: cmdAttachDisk: Use automatic memory clearing for 'xml' and 'dom'

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e27b779533..42a255cd6d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -561,7 +561,7 @@ static int

[PATCH 04/16] virsh: cmdAttachDisk: Refactor control flow

Remove the unnecessary 'cleanup:' label since we can directly return as the memory clearing is now automated. We can also remove the 'functionReturn' variable and use the usual pattern of returning success. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 33

[PATCH 02/16] virsh: cmdAttachDisk: Declare one variable per line

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c999458d72..e27b779533 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -562,13

[PATCH 00/16] virsh: Add support for network disks to --attach-disk

This version refactors cmdAttachDisk first so that we can use a much simpler logic to format the XML. With the simpler logic and tests the code now doesn't misformat the XML in certain situations as it was with the previous posting: virsh attach-disk --print-xml --domain ble --source

[PATCH 01/16] tests: virsh: Add simple testsuite for using --print-xml of various commands

The test uses a script and compares the output against a template file VIR_TEST_REGENREATE_OUTPUT can be used on test failures. This test will be marked as expensive once the refactors it guards are done. Signed-off-by: Peter Krempa --- tests/meson.build | 1 + tests/virsh-output

Re: [libvirt PATCH] sockettest: testMaskNetwork: use g_auto

On 11/19/20 1:01 PM, Ján Tomko wrote: This has the added benefit of 'gotnet' only being freed after it was possibly used in the output string. ../src/internal.h:519:27: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 519 | # define fprintf(fh, ...) g_fprintf(fh,

Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

On 11/19/20 10:36 AM, Andrea Bolognani wrote: Changes from [v1]: * ensure the updated network configuration is written back to disk whenever a UUID has been generated. [v1] https://www.redhat.com/archives/libvir-list/2020-November/msg00785.html Andrea Bolognani (3): conf: Write

[libvirt PATCH] sockettest: testMaskNetwork: use g_auto

This has the added benefit of 'gotnet' only being freed after it was possibly used in the output string. ../src/internal.h:519:27: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 519 | # define fprintf(fh, ...) g_fprintf(fh, __VA_ARGS__) |

Re: [PATCH] util: convert char pointers to use g_autofree

On 11/19/20 6:46 AM, Tim Wiederhake wrote: On Wed, 2020-11-18 at 16:47 -0600, Ryan Gahagan wrote: From: Barrett Schonefeld additional conversions to the GLib API in src/util per issue #11. [...] return ret; } I believe you can remove "cleanup" and "ret" as well. More instances

Re: [PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

On 11/19/20 12:53 PM, Erik Skultety wrote: On Tue, Nov 17, 2020 at 01:10:54PM +0100, Shalini Chellathurai Saroja wrote: Add support for AP card devices, AP queues and AP matrix devices in libvirt node device driver. Is there any public blueprint document or something that I can use to

[libvirt PATCH v2 1/3] conf: Write network config to disk after generating UUID

While we generally expect libvirt objects to be defined using the appropriate APIs, there are cases where it's reasonable for an external entity, usually a package manager, to drop a valid configuration file under /etc/libvirt and have libvirt take over from there: notably, this is exactly how the

[libvirt PATCH v2 3/3] spec: Drop UUID handling for default network

We're no longer generating a UUID during installation, so we clearly don't need to strip it afterwards; and since the network driver is perfectly capable of generating a UUID if necessary, we don't need to do that at %post time either. Signed-off-by: Andrea Bolognani Reviewed-by: Neal Gompa ---

[libvirt PATCH v2 0/3] network: Drop UUID handling for default network

Changes from [v1]: * ensure the updated network configuration is written back to disk whenever a UUID has been generated. [v1] https://www.redhat.com/archives/libvir-list/2020-November/msg00785.html Andrea Bolognani (3): conf: Write network config to disk after generating UUID

[libvirt PATCH v2 2/3] network: Drop UUID handling for default network

We are generating a fresh UUID and storing it in the XML for the default network, but this is unnecessary because the network driver will automatically generate one if it's missing from the XML; the fact that we only do this if the uuidgen command happens to be available on the build machine is

Re: [PATCH] util: convert char pointers to use g_autofree

On 11/18/20 9:40 PM, Barrett J Schonefeld wrote: I spent a significant chunk of time trying to get `git send-email` working but struggled to get the tool to work on my computer. Is there an error message you're seeing? Is your SMTP server blocking connection? Some use gmail to work around too

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on     libvirt version: 6.2.0     SELinux mode: permissive Steps: 1. start a vm configured with pipe-type serial port.      

Re: [PATCH 2/2] schema: add support for Windows file paths and device names

On Wed, Nov 18, 2020 at 01:48:25PM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman > --- > docs/schemas/basictypes.rng | 2 +- > docs/schemas/domaincommon.rng | 5 +++- > .../disk-hyperv-physical.xml | 17 ++ >

Re: [PATCH 1/2] hyperv: XML parsing of storage volumes

On Wed, Nov 18, 2020 at 01:48:24PM -0500, Matt Coleman wrote: > dumpxml can now serialize: > * floppy drives > * file-backed and device-backed disk drives > * images mounted to virtual CD/DVD drives > * IDE and SCSI controllers > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman >

Re: [libvirt PATCH 2/2] gitlab-ci: add coverity job

On Mon, Nov 16, 2020 at 04:36:06PM +0100, Pavel Hrdina wrote: > Introduce new job to make a coverity build and upload coverity data to > scan.coverity.com where the analysis is then executed. > > Signed-off-by: Pavel Hrdina > --- > .gitlab-ci.yml | 20 >

Re: [libvirt PATCH 1/2] src: rework static analysis detection

On Mon, Nov 16, 2020 at 04:36:05PM +0100, Pavel Hrdina wrote: > Inspired by QEMU code. > > Signed-off-by: Pavel Hrdina > --- > meson.build| 14 -- > src/internal.h | 4 > 2 files changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel

Re: [libvirt PATCH 0/3] openvz: fix NULL hostname usage

On Thu, Nov 19, 2020 at 11:33:26AM +0100, Ján Tomko wrote: > GCC on RHEL 8 emits a warning. See the first patch. > > Ján Tomko (3): > openvzDomainMigratePrepare3Params: correctly use hostname > openvzDomainMigratePrepare3Params: remove else after goto > openvzDomainMigratePrepare3Params:

Re: [libvirt PATCH 00/10] add support for ESP SCSI controller family

On 11/18/20 2:39 PM, Daniel P. Berrangé wrote: The sparc machines types all have an NCR53C90 SCSI Controller builtin. This is from the ESP family of SCSI controllers which includs two PCI variants. Wire up support for all these SCSI controllers, so we can at least launch a sparc VM with disks

Re: [libvirt PATCH 05/10] qemu: add capabilities for the three ESP family SCSI controllers

On 11/18/20 2:39 PM, Daniel P. Berrangé wrote: Probing for the NCR53C90 controller is a little unusual. The qom-list-types QMP command returns a list of all types known to the QEMU binary. It does not distinguish devices which are user creatable from those which are built-in. Any QEMU target

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

On 11/19/20 12:47 PM, Erik Skultety wrote: On Thu, Nov 19, 2020 at 12:22:07PM +0100, Michal Privoznik wrote: On 11/19/20 9:48 AM, Erik Skultety wrote: where VIR_DECLARE_MEMBER() would assert() that 1 << VIR_DOMAIN_VIDEO_TYPE_LAST fits into 'unsigned int' (or whatever type we will use), and

Re: [PATCH libvirt v3 00/11] Support AP card, AP queues and AP matrix

On Tue, Nov 17, 2020 at 01:10:54PM +0100, Shalini Chellathurai Saroja wrote: > Add support for AP card devices, AP queues and AP matrix devices in > libvirt node device driver. Is there any public blueprint document or something that I can use to cross-reference this design & implementation to?

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

On Thu, Nov 19, 2020 at 12:22:07PM +0100, Michal Privoznik wrote: > On 11/19/20 9:48 AM, Erik Skultety wrote: > > > > where VIR_DECLARE_MEMBER() would assert() that 1 << > > > VIR_DOMAIN_VIDEO_TYPE_LAST fits into 'unsigned int' (or whatever type we > > > will use), and also declare 'modelType'

Re: [PATCH] util: convert char pointers to use g_autofree

On Wed, 2020-11-18 at 16:47 -0600, Ryan Gahagan wrote: > From: Barrett Schonefeld > > additional conversions to the GLib API in src/util per issue #11. > > Related issue: https://gitlab.com/libvirt/libvirt/-/issues/11 > > Signed-off-by: Barrett Schonefeld > --- > src/util/vircgroupv1.c

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

On 11/19/20 9:48 AM, Erik Skultety wrote: where VIR_DECLARE_MEMBER() would assert() that 1 << VIR_DOMAIN_VIDEO_TYPE_LAST fits into 'unsigned int' (or whatever type we will use), and also declare 'modelType' member for the struct. I'm not sure a tags generator would be capable of seeing that.

Re: [PATCH] add phytium FT-2000+ and Tengyun-S2500 support on arm architecture.

On Thu, 2020-11-19 at 08:26 +0800, yangshaoju...@163.com wrote: > +++ b/src/cpu_map/meson.build > @@ -5,6 +5,8 @@ cpumap_data = [ >'arm_Falkor.xml', >'arm_features.xml', >'arm_Kunpeng-920.xml', > + 'arm_FT-2000plus.xml', > + 'arm_Tengyun-S2500.xml', >'arm_ThunderX299xx.xml', >

[libvirt PATCH 1/3] openvzDomainMigratePrepare3Params: correctly use hostname

In case no uri_in was supplied, we forgot to set the hostname to the current hostname and formatted a useless uri_out. src/util/glibcompat.h:57:26: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 57 | # define g_strdup_printf vir_g_strdup_printf

[libvirt PATCH 2/3] openvzDomainMigratePrepare3Params: remove else after goto

We jump to the error label if the 'if' condition is true. Remove the explicit else to make it more obvious that 'hostname' is filled on both branches of 'if (!uri_in)'. Signed-off-by: Ján Tomko --- src/openvz/openvz_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt PATCH 0/3] openvz: fix NULL hostname usage

GCC on RHEL 8 emits a warning. See the first patch. Ján Tomko (3): openvzDomainMigratePrepare3Params: correctly use hostname openvzDomainMigratePrepare3Params: remove else after goto openvzDomainMigratePrepare3Params: use g_auto src/openvz/openvz_driver.c | 12 ++-- 1 file

[libvirt PATCH 3/3] openvzDomainMigratePrepare3Params: use g_auto

Signed-off-by: Ján Tomko --- src/openvz/openvz_driver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index c6b7e21e7a..96535a8216 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@

[libvirt PATCH] cgroup: add stub for virCgroupNew

The previous commit exported the function but forgot to add a non-Linux stub. Signed-off-by: Ján Tomko Fixes: 126cb34a206a44f04e364700b46426dff9f387d5 --- Pushed. src/util/vircgroup.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c

Re: Libvirt NVME support

On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > And then add the storage into it as: > > > > > > > > > > 'target dev' is how the device appears in the guest, right? It

RE: Libvirt NVME support

> As a starting point a trivial way to model this in the XML will be: > > > > And then add the storage into it as: > > > > 'target dev' is how the device appears in the guest, right? It should be something like 'nvme0n1'. I'm not sure though this is something that we

Re: [libvirt PATCH] virt-host-validate: fix detection with cgroups v2

On Wed, Nov 18, 2020 at 01:48:56PM +0100, Pavel Hrdina wrote: > Using virtCgroupNewSelf() is not correct with cgroups v2 because the > the virt-host-validate process is executed from from the same cgroup > context as the terminal and usually not all controllers are enabled > by default. > > To do

Re: [PATCH] virsh: Added attach-disk support for network disk

On Wed, Nov 18, 2020 at 17:48:13 -0600, Ryan Gahagan wrote: > Related issue: https://gitlab.com/libvirt/libvirt/-/issues/16 > Added in support for the following parameters in attach-disk: > --source-protocol > --source-host-name > --source-host-socket > --source-host-transport > > Added

Re: [PATCH] domain_capabilities: Assert enums fit into unsigned int bitmask

On Wed, Nov 18, 2020 at 06:31:33PM +0100, Michal Privoznik wrote: > On 11/18/20 2:52 PM, Erik Skultety wrote: > > On Wed, Nov 18, 2020 at 01:06:07PM +0100, Michal Privoznik wrote: > > > The way our domain capabilities work currently, is that we have > > > virDomainCapsEnum struct which contains