On Fri, Dec 11, 2020 at 4:00 AM Ryan Gahagan wrote:
> Signed-off-by: Ryan Gahagan
> ---
> docs/formatdomain.rst | 1 +
> docs/schemas/domaincommon.rng | 38 +++
> 2 files changed, 39 insertions(+)
>
> diff --git a/docs/formatdomain.rst
On Fri, Dec 11, 2020 at 4:01 AM Ryan Gahagan wrote:
> Signed-off-by: Ryan Gahagan
> ---
> src/util/virstoragefile.c | 8
> src/util/virstoragefile.h | 5 +
> 2 files changed, 13 insertions(+)
>
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index
On Fri, Dec 11, 2020 at 4:00 AM Ryan Gahagan wrote:
> This is a request for comments on our patch for Issue 90. We didn't add
> in the test yet because we've had a ton of trouble getting the testing
> suite to work with our new test files, so they've omitted for now. We
> also did not add any
On Fri, Dec 11, 2020 at 4:01 AM Ryan Gahagan wrote:
> Signed-off-by: Ryan Gahagan
> ---
>
The patch for compatibilities usually is on src/qemu/qemu_capabilities* and
tests/qemucapabilitiesdata/caps_*.
Because nfs disk is supported since qemu v2.9(
Signed-off-by: Ryan Gahagan
---
src/conf/domain_conf.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 23415b323c..265c7584a2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -7844,6
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 42 +++
1 file changed, 42 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index cff6dabd9e..098ec80542 100644
--- a/src/util/virstoragefile.c
+++
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 8
src/util/virstoragefile.h | 5 +
2 files changed, 13 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 5a57e5d12d..cff6dabd9e 100644
--- a/src/util/virstoragefile.c
+++
Signed-off-by: Ryan Gahagan
---
src/qemu/qemu_block.c | 42 +-
src/qemu/qemu_domain.c | 42 ++
2 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index
Signed-off-by: Ryan Gahagan
---
src/libxl/libxl_conf.c| 1 +
src/libxl/xen_xl.c| 1 +
src/qemu/qemu_block.c | 3 +++
src/qemu/qemu_command.c | 1 +
src/qemu/qemu_domain.c| 2 ++
src/qemu/qemu_snapshot.c | 3 +++
src/util/virstoragefile.c | 6 ++
Signed-off-by: Ryan Gahagan
---
docs/formatdomain.rst | 1 +
docs/schemas/domaincommon.rng | 38 +++
2 files changed, 39 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 512939679b..40a1a3c1e2 100644
---
This is a request for comments on our patch for Issue 90. We didn't add
in the test yet because we've had a ton of trouble getting the testing
suite to work with our new test files, so they've omitted for now. We
also did not add any logic to the attach-disk method yet because we
wanted to focus
Hi all!
I have an idea, that not storing backing filename in qcow2 image at all may be
a good thing. I'll give some reasons and want to know what do you think about
it.
1. Libvirt has to manage and keep in mind backing chains anyway.
This means, that storing this information in qcow2 header
On 12/10/20 1:01 PM, John Ferlan wrote:
Coverity got pretty grumpy this morning with RESOURCE_LEAKS due to
override of @addr as changing from a break; inside a switch/case
statement sent us back to the for statement rather than outside the loop
which would occur on the break; inside the if {}
With commit 09364608b4 node_device: refactor address retrieval of node device
"if-else if" was replaced by "switch".
The contained break statement now is no longer in context of the for loop
but instead of the switch causing the legitimate grumpiness of coverity.
Signed-off-by: Boris Fiuczynski
The '-tb-size' option (replaced by '-accel tcg,tb-size') is
deprecated since 5.0 (commit fe174132478). Remove it.
Reviewed-by: Thomas Huth
Reviewed-by: Ján Tomko
Signed-off-by: Philippe Mathieu-Daudé
---
v2: fixed "Title underline too short." (Thomas)
---
docs/system/deprecated.rst | 12
>-Original Message-
>From: Dmytro Linkin
>Sent: Tuesday, October 27, 2020 10:58 AM
>To: libvir-list@redhat.com
>Cc: Laine Stump ; Adrian Chiris ;
>Moshe Levi
>Subject: Re: [PATCH] util: Add phys_port_name support on
>virPCIGetNetName
>
>On Mon, Sep 28, 2020 at 12:56:12PM +0300, Dmytro
On 10/12/20 16:58, Thomas Huth wrote:
Remove some simple CLI parameters that have been deprecated since
at least two releass already.
Philippe Mathieu-Daudé (1):
accel/tcg: Remove deprecated '-tb-size' option
Thomas Huth (3):
docs/system: Move the list of removed features to a separate
On 10/12/2020 16.58, Thomas Huth wrote:
> From: Philippe Mathieu-Daudé
>
> The '-tb-size' option (replaced by '-accel tcg,tb-size') is
> deprecated since 5.0 (commit fe174132478). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Message-Id: <20201202112714.1223783-1-phi...@redhat.com>
I
On 02/12/2020 12.27, Philippe Mathieu-Daudé wrote:
> The '-tb-size' option (replaced by '-accel tcg,tb-size') is
> deprecated since 5.0 (commit fe174132478). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> docs/system/deprecated.rst | 12 +---
> accel/tcg/translate-all.c |
It has been marked as deprecated since QEMU v5.0, replaced by the
corresponding parameter of the -display option.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
qemu-options.hx | 7 ---
softmmu/vl.c
Otherwise there is a chance that new deprecated features get added
to the list of removed features at the end of the file by accident.
It's way less confusing if the removed features reside in a separate
file.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 232
It has been marked as deprecated since QEMU v4.2, replaced by
the -overcommit option. Time to remove it now.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst| 6 ++
qemu-options.hx | 14 +-
From: Philippe Mathieu-Daudé
The '-tb-size' option (replaced by '-accel tcg,tb-size') is
deprecated since 5.0 (commit fe174132478). Remove it.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20201202112714.1223783-1-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
Remove some simple CLI parameters that have been deprecated since
at least two releass already.
Philippe Mathieu-Daudé (1):
accel/tcg: Remove deprecated '-tb-size' option
Thomas Huth (3):
docs/system: Move the list of removed features to a separate file
Remove the deprecated -realtime
On Thu, 2020-12-10 at 16:07 +0100, Andrea Bolognani wrote:
> As usual, this is an abridged version of the changes.
>
> For the full version, run
>
> $ git fetch https://gitlab.com/abologna/libvirt.git caps-5.2
>
> or browse
>
> https://gitlab.com/abologna/libvirt/-/commits/caps-5.2
>
>
Signed-off-by: Andrea Bolognani
---
.../caps_5.2.0.riscv64.replies| 21075
.../caps_5.2.0.riscv64.xml| 214 +
2 files changed, 21289 insertions(+)
create mode 100644 tests/qemucapabilitiesdata/caps_5.2.0.riscv64.replies
create mode 100644
Signed-off-by: Andrea Bolognani
---
tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 120 +
.../caps_5.2.0.ppc64.replies | 28789
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1169 +
...default-video-type-ppc64.ppc64-latest.args | 4 +-
Signed-off-by: Andrea Bolognani
---
.../qemu_5.2.0-virt.aarch64.xml | 161 +
tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 155 +
.../caps_5.2.0.aarch64.replies| 25361
.../caps_5.2.0.aarch64.xml| 509 +
As usual, this is an abridged version of the changes.
For the full version, run
$ git fetch https://gitlab.com/abologna/libvirt.git caps-5.2
or browse
https://gitlab.com/abologna/libvirt/-/commits/caps-5.2
Andrea Bolognani (3):
tests: Add capabilities for QEMU 5.2 on aarch64
tests:
On Thu, 2020-12-10 at 09:39 +0300, Nikolay Shirokovskiy wrote:
> Nwfilter can be edited by the user and we don't want to overwrite the
> editings.
> Also the filters in %{datadir} does not have UUIDs and these are generated on
> libvirtd start. Thus this patch also fixes regeneration of UUIDs on
On a Thursday in 2020, Tim Wiederhake wrote:
On Thu, 2020-12-10 at 10:41 +0100, Ján Tomko wrote:
Although the function currently only returns errors for PCI
addresses,
check it here too, in case that chamges in the future.
typo ^ changes
Thamks, fixed.
Jano
On 12/3/20 12:59 PM, Shalini Chellathurai Saroja wrote:
> Use switch statements instead of if-else condition in the method
> nodeDeviceFindAddressByName to retrieve address of a node device.
>
> Signed-off-by: Shalini Chellathurai Saroja
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris
On 12/10/20 10:41 AM, Ján Tomko wrote:
Ján Tomko (3):
virsh: virshAddressParse: check for malformed address
qemuBuildMemoryDeviceStr: check return of qemuBuildDeviceAddressStr
hyperv: remove duplicit addr check
src/hyperv/hyperv_driver.c | 3 ---
src/qemu/qemu_command.c| 3 ++-
On 11/25/20 12:06 PM, Thomas Huth wrote:
On s390x, devices are attached to the channel IO subsytem by default,
so we need to look up scsi controllers via their CCW address there
instead of using PCI.
This fixes "virsh domfsinfo" on s390x for virtio-scsi devices (the first
attempt from commit
On 11/25/20 12:06 PM, Thomas Huth wrote:
On s390x, devices are attached to the channel IO subsytem by default,
so we need to look up the devices via their CCW address there instead
of using PCI.
This fixes "virsh domfsinfo" on s390x for virtio-block devices (the first
attempt from commit
On 11/25/20 12:06 PM, Thomas Huth wrote:
My previous attempts to fix "virsh domfsinfo" on s390x were unfortunately
wrong due to some misunderstandings on my side.
To correctly list the "Target" device in the output of "virsh domfsinfo",
we need to search through the available devices using
On 11/25/20 12:06 PM, Thomas Huth wrote:
Newer versions of the QEMU guest agent will provide the CCW address
of devices on s390x. Store this information in the qemuAgentDiskInfo
so that we can use this later.
We also map the CSSID 0 from the guest to the value 0xfe on the host,
see
Nwfilter can be edited by the user and we don't want to overwrite the editings.
Also the filters in %{datadir} does not have UUIDs and these are generated on
libvirtd start. Thus this patch also fixes regeneration of UUIDs on libvirtd
update.
Signed-off-by: Nikolay Shirokovskiy
Reviewed-by:
On Thu, 2020-12-10 at 10:41 +0100, Ján Tomko wrote:
> Although the function currently only returns errors for PCI
> addresses,
> check it here too, in case that chamges in the future.
typo ^ changes
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 3
We already check addr is not negative right after filling
its value. There's no need to check it before using it too.
Signed-off-by: Ján Tomko
Fixes: a7a1d1f59e8ba2d8a3ed920ef595ccdfb0d8feb6
---
src/hyperv/hyperv_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
Although the function currently only returns errors for PCI addresses,
check it here too, in case that chamges in the future.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c
Ján Tomko (3):
virsh: virshAddressParse: check for malformed address
qemuBuildMemoryDeviceStr: check return of qemuBuildDeviceAddressStr
hyperv: remove duplicit addr check
src/hyperv/hyperv_driver.c | 3 ---
src/qemu/qemu_command.c| 3 ++-
tools/virsh-domain.c | 2 +-
3 files
The refactor left in the 'if (addr)' check,
but before 'addr' was the return value of strchr
and now it's the return value of virshAddressParse.
Check 'a' instead since that's the return of strchr now.
Signed-off-by: Ján Tomko
Fixes: 67bf91e1c38b6569357c22b1c83f7b090badba2b
---
43 matches
Mail list logo
