> -Original Message-
> From: Alistair Francis [mailto:alistai...@gmail.com]
> Sent: Wednesday, December 9, 2020 6:30 AM
> To: Jiangyifei
> Cc: qemu-de...@nongnu.org Developers ; open
> list:RISC-V ; Zhangxiaofeng (F)
> ; Sagar Karandikar
> ; open list:Overall ;
> libvir-list@redhat.com;
> -Original Message-
> From: Alistair Francis [mailto:alistai...@gmail.com]
> Sent: Wednesday, December 9, 2020 6:26 AM
> To: Jiangyifei
> Cc: qemu-de...@nongnu.org Developers ; open
> list:RISC-V ; Zhangxiaofeng (F)
> ; Sagar Karandikar
> ; open list:Overall ;
> libvir-list@redhat.com;
> -Original Message-
> From: Alistair Francis [mailto:alistai...@gmail.com]
> Sent: Wednesday, December 9, 2020 6:22 AM
> To: Jiangyifei
> Cc: qemu-de...@nongnu.org Developers ; open
> list:RISC-V ; Zhangxiaofeng (F)
> ; Sagar Karandikar
> ; open list:Overall ;
> libvir-list@redhat.com;
> -Original Message-
> From: Alistair Francis [mailto:alistai...@gmail.com]
> Sent: Wednesday, December 9, 2020 6:19 AM
> To: Jiangyifei
> Cc: qemu-de...@nongnu.org Developers ; open
> list:RISC-V ; Zhangxiaofeng (F)
> ; Sagar Karandikar
> ; open list:Overall ;
> libvir-list@redhat.com;
On Sat, Dec 12, 2020 at 11:57:15AM +0100, Peter Krempa wrote:
> On Fri, Dec 11, 2020 at 20:58:48 -0500, Masayoshi Mizuma wrote:
> > Hello,
> >
> > I would like to start multiple KVM guests from one qcow2 image, and
> > discard the changes which the KVM guests done.
> >
> > transient disk option
On 2020-12-15 at 11:09, Laine Stump wrote:
>On 12/13/20 8:50 PM, Shi Lei wrote:
>> Simplify virNetDevVethCreate by using common GenerateName/ReserveName
>> functions.
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/lxc/lxc_process.c | 3 +
>> src/util/virnetdevveth.c | 140
On 12/13/20 8:50 PM, Shi Lei wrote:
Simplify virNetDevVethCreate by using common GenerateName/ReserveName
functions.
Signed-off-by: Shi Lei
---
src/lxc/lxc_process.c| 3 +
src/util/virnetdevveth.c | 140 +--
2 files changed, 36 insertions(+), 107
On Fri, Dec 11, 2020 at 3:24 AM Peter Krempa wrote:
> On Thu, Dec 10, 2020 at 14:00:07 -0600, Ryan Gahagan wrote:
> > +virJSONValuePtr server = virJSONValueObjectGetObject(json,
> "server");
> > +int gotUID = virJSONValueObjectGetNumberInt(json, "user", (int
> *)(>nfs_uid));
>
> You
On Fri, Dec 11, 2020 at 3:30 AM Peter Krempa wrote:
> There's also virJSONValueObjectAdd, that might come in handy given my
> comment below.
>
> [...]
>
> The best bet is to actually avoid formatting the user/group members
> formatting towards qemu.
>
> Unfortunately 0 is a very valid uid, so
On Thu, Dec 10, 2020 at 10:37 PM Han Han wrote:
> On Fri, Dec 11, 2020 at 4:00 AM Ryan Gahagan
> wrote:
>
>> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>> index 512939679b..40a1a3c1e2 100644
>> --- a/docs/formatdomain.rst
>> +++ b/docs/formatdomain.rst
>> @@ -2601,6 +2601,7 @@
On Fri, Dec 11, 2020 at 3:35 AM Peter Krempa wrote:
> In subject/summary. We don't have anything which we'd prefix with
> 'compatibilities:'.
Just to confirm, does this mean that we should not implement the feedback
Han Han suggested about the NFS capability flags and instead leave the
commit
Commit 729a06c41 added code to the LXC driver (patterned after similar
code in the QEMU driver) that called
virNetDevMacVlanReserveName(net->ifname) for all type='direct'
interfaces during a libvirtd restart, to prevent other domains from
attempting to use a macvtap device name that was already in
Contains changes utilizing "nosync" and "eatmydata" for speedup as well
as fixes for CentOS-8 repoid regression.
ci-commit: b098ec6631a85880f818f2dd25c437d509e53680
Signed-off-by: Erik Skultety
---
Pipeline on my private fork:
https://gitlab.com/eskultety/libvirt/-/pipelines/229588144
If you
On 12/14/20 12:49 PM, Daniel Henrique Barboza wrote:
On 12/13/20 10:50 PM, Shi Lei wrote:
V2 here:
https://www.redhat.com/archives/libvir-list/2020-December/msg00563.html
Since V2:
* Fix libxl driver for missing changing
virNetDevMacVLanReserveName
V1 here:
On 12/13/20 10:50 PM, Shi Lei wrote:
V2 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00563.html
Since V2:
* Fix libxl driver for missing changing virNetDevMacVLanReserveName
V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00308.html
Since
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_migration.c | 2 +-
src/util/virfile.c| 12
src/util/virfile.h| 1 +
src/util/virstoragefile.c | 11 ---
src/util/virstoragefile.h | 1 -
6 files changed, 15 insertions(+), 14
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_block.c | 2 +-
src/qemu/qemu_snapshot.c | 2 +-
src/util/virfile.c| 13 +
src/util/virfile.h| 2 ++
src/util/virstoragefile.c | 15 +--
src/util/virstoragefile.h | 2
The code handles XML bits and internal definition and should be
in conf directory.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in |1 +
src/conf/backup_conf.c |2 +-
src/conf/checkpoint_conf.c |2 +-
src/conf/domain_conf.c
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 2 +-
src/util/virfile.c| 21 +
src/util/virfile.h| 1 +
src/util/virstoragefile.c | 26 +++---
src/util/virstoragefile.h | 1 -
5 files changed, 26 insertions(+), 25
Introduce a new storage_file directory where we will keep storage file
related code.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in| 4 +-
src/meson.build | 1 +
src/storage/meson.build | 30 +--
This will allow following patches to move virStorageSource into conf
directory and virStorageDriverData into a new storage_file directory.
Signed-off-by: Pavel Hrdina
---
src/storage/storage_file_fs.c | 21 +++--
src/storage/storage_file_gluster.c | 31 +---
src/util/virstoragefile.c
It is not used anywhere else.
Signed-off-by: Pavel Hrdina
---
src/conf/storage_conf.c | 23 ++-
src/util/virstoragefile.c | 24
src/util/virstoragefile.h | 2 --
3 files changed, 22 insertions(+), 27 deletions(-)
diff --git
Now that storage file code is separated from storage source definition
it makes sense to rename the functions to make it clear.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms| 18 +-
src/libxl/xen_xl.c | 2 +-
src/qemu/qemu_domain.c | 16
It's used only by storage file code so it doesn't make sense to have
it in util directory.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in| 2 +-
src/libvirt_private.syms | 8
src/storage_file/meson.build
The function doesn't take virStorageSource as argument and has nothing
in common with virStorageSource or storage file.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms| 1 -
src/locking/lock_driver_lockd.c | 66 -
src/util/virstoragefile.c
The code handles XML bits and internal definition and should be
in conf directory.
Signed-off-by: Pavel Hrdina
---
po/POTFILES.in | 2 +-
src/conf/domain_conf.h | 2 +-
src/conf/meson.build |
The last usage outside of tests was removed by commit
<780f8c94ca8b3dee7eb59c1bfbc32f672f965df8>.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/util/virstoragefile.c | 33 -
src/util/virstoragefile.h | 3 ---
tests/virstoragetest.c|
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 2 +-
src/storage/storage_util.c | 2 +-
src/util/virfile.c | 47 ++
src/util/virfile.h | 4
src/util/virstoragefile.c | 47 --
The last user was removed by commit
<40f0e0348dfc84f28a500e262c4953b0d3b44fa0>.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms| 1 -
src/util/virstorageencryption.c | 34 -
src/util/virstorageencryption.h | 2 --
3 files changed, 37
The only reason why virstoragefile.h needs to be included in virfile.h
is that virFileNBDDeviceAssociate() takes virStorageFileFormat argument.
The function doesn't need the enum value as it converts the value to
string and uses only that.
Change the argument to string which will allow us to
Function virQEMUBuildQemuImgKeySecretOpts is not used anywhere else
so there is no need to have it in util.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 1 -
src/storage/storage_util.c | 74 --
src/util/virqemu.c | 69
The series is a prerequisite for implementing vhost-user-blk-pci.
I wanted to use already existing code to parse and format
virDomainChrSourceDefPtr as the vhostuser source similarly
like we do for but it was not possible because
the virStorageSource definition was living in util directory
On Mon, 30 Nov 2020 11:14:20 +
Daniel P. Berrangé wrote:
> On Mon, Nov 30, 2020 at 11:48:28AM +0100, Michal Privoznik wrote:
> > On 11/30/20 11:16 AM, Daniel P. Berrangé wrote:
> > > On Mon, Nov 30, 2020 at 11:06:14AM +0100, Michal Privoznik wrote:
> > > > Currently, we configure QEMU to
On 12/14/20 7:18 AM, Michal Privoznik wrote:
On 12/11/20 7:05 PM, Daniel Henrique Barboza wrote:
Hi,
This is a continuation of what we started in [1]. The changes
are all trivial, but done in parts to make the review less
annoying.
domain_conf.c is still a huge beast, but here we're
On 12/14/20 7:18 AM, Michal Privoznik wrote:
On 12/11/20 7:05 PM, Daniel Henrique Barboza wrote:
virDomainDefValidateInternal() helpers can now be made static again
since they're all in the same file.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_validate.c | 22
On a Monday in 2020, Michal Privoznik wrote:
In v6.8.0-27-g88957116c9 and friends I've switched the way the
default RAM is specified for QEMU (from plain -m to
memory-backend-*). This means, that even if a guest doesn't have
any NUMA nodes configured we can use memory-backend-* attributes
to
In v6.8.0-27-g88957116c9 and friends I've switched the way the
default RAM is specified for QEMU (from plain -m to
memory-backend-*). This means, that even if a guest doesn't have
any NUMA nodes configured we can use memory-backend-* attributes
to translate user config requests. For instance, we
On 12/14/20 10:10 AM, Andrea Bolognani wrote:
On Wed, 2020-11-18 at 17:18 +0100, Shalini Chellathurai Saroja wrote:
Signed-off-by: Shalini Chellathurai Saroja
---
The replies file is removed from this patch and is available in
On 12/14/20 12:02 PM, Boris Fiuczynski wrote:
Michal,
since I do not have commit rights I am fine with you doing it.
Thanks.
Terribly sorry, for some reason I thought you have commit access.
Fixed and pushed.
Michal
On 12/11/20 3:55 PM, Michal Privoznik wrote:
On 12/11/20 3:46 PM, Boris Fiuczynski wrote:
On 12/11/20 3:33 PM, Michal Privoznik wrote:
On 12/10/20 6:32 PM, Boris Fiuczynski wrote:
With commit 09364608b4 node_device: refactor address retrieval of
node device
"if-else if" was replaced by
On 12/11/20 7:05 PM, Daniel Henrique Barboza wrote:
virDomainDefValidateInternal() helpers can now be made static again
since they're all in the same file.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_validate.c | 22 +++---
src/conf/domain_validate.h | 13
On 12/11/20 7:05 PM, Daniel Henrique Barboza wrote:
Hi,
This is a continuation of what we started in [1]. The changes
are all trivial, but done in parts to make the review less
annoying.
domain_conf.c is still a huge beast, but here we're putting it on
a diet, losing ~1k lines.
[1]
On Wed, 2020-11-18 at 17:18 +0100, Shalini Chellathurai Saroja wrote:
> Signed-off-by: Shalini Chellathurai Saroja
> ---
> The replies file is removed from this patch and is available in
> https://gitlab.com/shalinichellathurai/libvirt/-/commit/1c34c07c434560d7f44212ce0bbbc8bf92490622
>
>
43 matches
Mail list logo
