On Thu, Jan 21, 2021 at 20:34:25 +0100, Pavel Hrdina wrote:
> The code handles XML bits and internal definition and should be
> in conf directory.
>
> Signed-off-by: Pavel Hrdina
> ---
Reviewed-by: Peter Krempa
On Thu, Jan 21, 2021 at 20:34:24 +0100, Pavel Hrdina wrote:
> The code handles XML bits and internal definition and should be
> in conf directory.
>
> Signed-off-by: Pavel Hrdina
> ---
Reviewed-by: Peter Krempa
On Thu, Jan 21, 2021 at 20:34:23 +0100, Pavel Hrdina wrote:
> Same as virStorageFileBackend, it doesn't belong into util directory.
Arguably, after you remove the file access, it kinda becomes just an
utility function.
On the other hand, it's use is strictly limited to the storage source
code,
On Thu, Jan 21, 2021 at 20:34:22 +0100, Pavel Hrdina wrote:
> It's used only by storage file code so it doesn't make sense to have
> it in util directory.
>
> Signed-off-by: Pavel Hrdina
> ---
> po/POTFILES.in| 2 +-
> src/libvirt_private.syms
On 1/21/21 1:51 PM, Matt Coleman wrote:
Fixes a memory leak when hypervCreateInvokeParamsList() fails.
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_wmi.c | 43 -
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_wmi.c | 56 -
1 file changed, 21 insertions(+), 35 deletions(-)
diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index ed0091ba06..c1325b2ccc
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_wmi.c | 42 ++---
1 file changed, 14 insertions(+), 28 deletions(-)
diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index c1325b2ccc..b68b555a3b
The way this completer works is that it dumps XML of specified
domain and then tries to look for @name attribute of
element. However, the XPATH it uses is not correct which results
in no aliases returned by the completer.
Signed-off-by: Michal Privoznik
---
tools/virsh-completer-domain.c | 4
On Thu, Jan 21, 2021 at 20:34:21 +0100, Pavel Hrdina wrote:
> Up until now we had a runtime code and XML related code in the same
> source file inside util directory.
>
> This patch takes the runtime part and extracts it into the new
> storage_file directory.
>
> Signed-off-by: Pavel Hrdina
>
On Thu, Jan 21, 2021 at 20:34:18 +0100, Pavel Hrdina wrote:
> Introduce a new storage_file directory where we will keep storage file
> related code.
>
> Signed-off-by: Pavel Hrdina
> ---
> po/POTFILES.in| 4 +-
> src/meson.build |
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_wmi.c | 50 +++--
1 file changed, 18 insertions(+), 32 deletions(-)
diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index 459d207ee7..bd62174739
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_wmi.c | 68 -
1 file changed, 27 insertions(+), 41 deletions(-)
diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
index 0a9d4bf4fd..459d207ee7
On Thu, Jan 21, 2021 at 20:34:20 +0100, Pavel Hrdina wrote:
> This code is not directly relevant to virStorageSource so move it to
> separate file.
>
> Signed-off-by: Pavel Hrdina
> ---
> po/POTFILES.in| 1 +
> src/libvirt_private.syms | 6 +-
>
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index f056761338..0642e42b35 100644
On 1/21/21 1:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 7da4c216b1..2ec0415f62 100644
---
On 1/21/21 1:50 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 8b59dd05f7..6375f6b011 100644
---
On Thu, Jan 21, 2021 at 20:34:19 +0100, Pavel Hrdina wrote:
> It's only relevant for QEMU driver.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/libvirt_private.syms | 1 -
> src/qemu/qemu_domain.c| 38 --
> src/util/virstoragefile.c | 25
On Thu, Jan 21, 2021 at 20:34:16 +0100, Pavel Hrdina wrote:
> It was indirectly included by virstoragefilebackend.h.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/virstoragefile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Peter Krempa
On Thu, Jan 21, 2021 at 20:34:15 +0100, Pavel Hrdina wrote:
> These files are using functions from virstoragefile.h but are missing
> explicit include.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/locking/lock_driver_lockd.c| 1 +
> src/qemu/qemu_block.c | 1 +
>
Since libvirt.spec explicitly adds -Dnetcf=enabled to the meson
commandline, just setting the default in the meson.build file won't
have any effect for rpm builds. This patch changes the meson
commandline in the spec file to -Dnetcf=disabled and removes the
associated BuildRequires: and Requires:
Even after the previous patch, in order to build without netcf you
would need to add "-Dnetcf=disabled" to the meson commandline (or
uninstall netcf-devel). This patch makes -Dnetcf=disabled the
default. (Without this change, a lot of people would just blindly
continue building with netcf
This is a followup to my message in December suggesting that we
deprecate use of the netcf package:
https://www.redhat.com/archives/libvir-list/2020-December/msg00183.html
(or Message-Id: <4889202b-734c-4d0f-472c-d86894319...@redhat.com> for
those of you who keep a local archive)
Each of these
placing "-Dnetcf=disabled" on the meson commandline was ignored,
meaning that even with that option the build would get WITH_NETCF if
the netcf-devel package was found - the only way to disable it was to
uninstall netcf-devel.
This patch adds the small bit of logic to check the netcf meson
101 - 123 of 123 matches
Mail list logo
