On 2/16/21 8:16 AM, Daniel Henrique Barboza wrote:
Ping for reviews (patches 1-4 and 7-8 already pushed).
Yeah, sorry. It's been on my list ever since I left it half-finished,
but I keep getting distra... OOHH LOOK!!! SOMETHING SHINY!!
Okay, back to the subject - I promise
On Wed, 2021-02-10 at 18:24 +0100, Erik Skultety wrote:
> +def get_undesirables(registry_distros_d, hosts_l):
> +""" Returns a dictionary of 'id':'name' pairs of images that can be
> purged"""
Is the var_d and var_l a Python convention that I'm not aware of? I
don't think we're using it
On Wed, Feb 03, 2021 at 11:38:55AM -0600, Jonathon Jongsma wrote:
> mdevctl does not currently provide any events when the list of defined
> devices changes, so we will need to poll mdevctl for the list of defined
> devices periodically. When a mediated device no longer exists from one
> iteration
...
> +void
> +virNodeDeviceObjListForEachSafe(virNodeDeviceObjListPtr devs,
> +virNodeDeviceObjListIterator iter,
> +const void *opaque)
> +{
> +struct _virNodeDeviceObjListForEachData data = {
> +.iter = iter,
> +
On Tue, Feb 16, 2021 at 02:40:32PM +0100, Andrea Bolognani wrote:
> On Wed, 2021-02-10 at 18:24 +0100, Erik Skultety wrote:
> > +# skip the "ci-" prefix each of our container images' name has
> > +names = [i["name"][3:] for i in data]
>
> I would prefer something like
>
> PREFIX = "ci-"
>
On a Tuesday in 2021, Daniel P. Berrangé wrote:
The option instructs the
VNC server to enable an extension that lets the client perform a
graceful shutdown, reboot and hard reset.
This is enabled by default since it cannot be assumed that the VNC
client user has administrator rights over the
On Tue, Feb 16, 2021 at 14:08:52 +, Daniel Berrange wrote:
> This allows the VNC client user to perform a shutdown, reboot and reset
> of the VM from the host side.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_command.c | 9 +
>
On Tue, Feb 16, 2021 at 14:08:51 +, Daniel Berrange wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
> tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 +
> 3 files
On Tue, Feb 16, 2021 at 14:08:50 +, Daniel Berrange wrote:
> The option instructs the
> VNC server to enable an extension that lets the client perform a
> graceful shutdown, reboot and hard reset.
>
> This is enabled by default since it cannot be assumed that the VNC
> client user has
Fixes: e88bdaf789b6f1cc5347b217240f15afd86a94c1
Signed-off-by: Ján Tomko
---
Pushed as trivial.
docs/formatdomain.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index eafd6b3396..2587106191 100644
--- a/docs/formatdomain.rst
This allows the VNC client user to perform a shutdown, reboot and reset
of the VM from the host side.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_command.c | 9 +
tests/qemuxml2argvdata/graphics-vnc-policy.args | 2 +-
Daniel P. Berrangé (3):
conf: add support for VNC power control setting
qemu: probe for -vnc power-control option support
qemu: wire up support for VNC power control options
docs/formatdomain.rst| 5 +
docs/schemas/domaincommon.rng|
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 +
3 files changed, 4 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c
The option instructs the
VNC server to enable an extension that lets the client perform a
graceful shutdown, reboot and hard reset.
This is enabled by default since it cannot be assumed that the VNC
client user has administrator rights over the guest OS. In the case
where the VNC user is a guest
On Wed, 2021-02-10 at 18:24 +0100, Erik Skultety wrote:
> +++ b/ci/list-images.py
> @@ -1,29 +1,32 @@
> #!/usr/bin/env python3
>
> -import json
> -import urllib.request as urllib
> +import containers.util as util
As we add more Python code here, I think it makes sense to have a
single util
On Wed, 2021-02-10 at 18:24 +0100, Erik Skultety wrote:
> +# skip the "ci-" prefix each of our container images' name has
> +names = [i["name"][3:] for i in data]
I would prefer something like
PREFIX = "ci-"
names = [i["name"][len(PREFIX):] for i in data]
here, rather than hardcoding the
On a Tuesday in 2021, Daniel P. Berrangé wrote:
The preferred syntax for boolean options is to set the value "on" or
"off". QEMU 7.1.0 will deprecate the short format we currently use.
The long format has been supported with -vnc since the change to use
QemuOpts in 2.2.0, so we check based on
On a Tuesday in 2021, Daniel P. Berrangé wrote:
This was introduced in QEMU 2.2.0, and is visible by -vnc appearing in
the "query-command-line-options" data.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h
On Tue, Feb 16, 2021 at 12:57:00 +, Daniel Berrange wrote:
> This completes the conversion to standarize on on|off for all boolean
> options in QEMU.
>
> Daniel P. Berrang=C3=A9 (5):
> qemu: probe for -vnc supporting use of QemuOpts syntax
> qemu: use on|off for -vnc boolean option values
On Wed, 2021-02-10 at 18:24 +0100, Erik Skultety wrote:
> It's quite pointless to have a 'ci-help' target in the Makefile when
> one needs to actually open the Makefile to go through the list of
> targets to know what functionality the Makefile actually provides. It's
> much more intuitive to run
On Tue, Feb 16, 2021 at 13:26:38 +, Daniel Berrange wrote:
> On Tue, Feb 16, 2021 at 02:21:56PM +0100, Peter Krempa wrote:
> > On Tue, Feb 16, 2021 at 12:57:03 +, Daniel Berrange wrote:
> > > QEMU has long accepted many different values for boolean properties, but
> > > set accepted has
On Tue, Feb 16, 2021 at 02:21:56PM +0100, Peter Krempa wrote:
> On Tue, Feb 16, 2021 at 12:57:03 +, Daniel Berrange wrote:
> > QEMU has long accepted many different values for boolean properties, but
> > set accepted has been different depending on which QEMU parser you hit.
> >
> > The
On Tue, Feb 16, 2021 at 12:57:03 +, Daniel Berrange wrote:
> QEMU has long accepted many different values for boolean properties, but
> set accepted has been different depending on which QEMU parser you hit.
>
> The on|off values were supported by all QEMU parsers. The yes|no, y|n,
>
Ping for reviews (patches 1-4 and 7-8 already pushed).
On 1/18/21 4:53 PM, Daniel Henrique Barboza wrote:
This is the rebased version of
https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html
with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
fixes.
On Mon, 2021-02-15 at 13:11 +0100, Erik Skultety wrote:
>
> Erik Skultety (2):
> ci: Drop the CI_PREPARE_SCRIPT variable
> ci: Makefile: Expose CI_IMAGE_PREFIX and CI_IMAGE_TAG in 'ci-help'
>
> ci/Makefile | 17 -
> 1 file changed, 8 insertions(+), 9 deletions(-)
All callers are now using the on|off syntax, so yes|no is a unreachable
code path.
Signed-off-by: Daniel P. Berrangé
---
src/util/virqemu.c | 50 +
src/util/virqemu.h | 10 +++-
tests/qemucommandutiltest.c | 10
3 files changed,
QEMU has long accepted many different values for boolean properties, but
set accepted has been different depending on which QEMU parser you hit.
The on|off values were supported by all QEMU parsers. The yes|no, y|n,
true|false values were only partially supported:
The preferred syntax for boolean options is to set the value "on" or
"off". QEMU 7.1.0 will deprecate the short format we currently use.
The long format has been supported with -vnc since the change to use
QemuOpts in 2.2.0, so we check based on the new capability flag.
Signed-off-by: Daniel P.
This completes the conversion to standarize on on|off for all boolean
options in QEMU.
Daniel P. Berrang=C3=A9 (5):
qemu: probe for -vnc supporting use of QemuOpts syntax
qemu: use on|off for -vnc boolean option values
qemu: use on|off instead of yes|no for -object boolean properties
QEMU has long accepted many different values for boolean properties, but
set accepted has been different depending on which QEMU parser you hit.
The on|off values were supported by all QEMU parsers. The yes|no, y|n,
true|false values were only partially supported:
This was introduced in QEMU 2.2.0, and is visible by -vnc appearing in
the "query-command-line-options" data.
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
On Wed, Feb 03, 2021 at 11:38:53AM -0600, Jonathon Jongsma wrote:
> At startup, query devices that are defined by 'mdevctl' and add them to
> the node device list.
>
> This adds a complication: we now have two potential sources of
> information for a node device:
> - udev for all devices and for
On a Tuesday in 2021, Daniel P. Berrangé wrote:
The preferred syntax for boolean options is to set the value "on" or
"off". QEMU 7.1.0 will deprecate the short format we currently use.
The long format has been supported with -spice since at least 1.5.3,
so we don't need to check for it.
On a Tuesday in 2021, Daniel P. Berrangé wrote:
The preferred syntax for boolean options is to set the value "on" or
"off". QEMU 7.1.0 will deprecate the short format we currently use.
The long format has been supported with -chardev since at least 1.5.3,
so we don't need to check for it.
On Wed, Feb 03, 2021 at 11:38:51AM -0600, Jonathon Jongsma wrote:
> Consistent with other objects (e.g. virDomainObj), add a field to
> indicate whether the node device is persistent or transient.
>
> Signed-off-by: Jonathon Jongsma
> ---
> src/conf/virnodedeviceobj.c | 14 ++
>
...
> struct _virNodeDeviceObjList {
> @@ -976,3 +977,16 @@ virNodeDeviceObjSetSkipUpdateCaps(virNodeDeviceObjPtr
> obj,
> {
> obj->skipUpdateCaps = skipUpdateCaps;
> }
2 blank lines in between the function definitions please.
> +
> +bool
> +virNodeDeviceObjIsActive(virNodeDeviceObjPtr
The preferred syntax for boolean options is to set the value "on" or
"off". QEMU 7.1.0 will deprecate the short format we currently use.
The long format has been supported with -spice since at least 1.5.3,
so we don't need to check for it.
Signed-off-by: Daniel P. Berrangé
---
On a Monday in 2021, Andrea Bolognani wrote:
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/256476242
Andrea Bolognani (2):
ci: Update package list on Cirrus CI
ci: Build on macOS 11 instead of macOS 10.15
.gitlab-ci.yml | 10 +++---
On a Monday in 2021, Michal Privoznik wrote:
On 2/15/21 6:00 PM, Ján Tomko wrote:
On a Monday in 2021, Michal Privoznik wrote:
When qemuDomainGetFSInfo() is called it calls
qemuDomainGetFSInfoAgent() which executes 'guest-get-fsinfo'
guest agent command, parses returned JSON and returns an
On Tue, Feb 16, 2021 at 09:46:42AM +0100, Peter Krempa wrote:
> On Mon, Feb 15, 2021 at 19:20:25 +0100, Pavel Hrdina wrote:
> > On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote:
> > > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
> > > doesn't necessarily mean that
On Mon, Feb 15, 2021 at 19:20:25 +0100, Pavel Hrdina wrote:
> On Mon, Feb 15, 2021 at 06:27:51PM +0100, Peter Krempa wrote:
> > The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
> > doesn't necessarily mean that the command was sent to the agent.
> >
> > Since callers don't care
41 matches
Mail list logo
