Re: [PATCH] qemuBlockDiskDetectNodes: just return when alias is null

2021-02-17 Thread Ján Tomko
On a Thursday in 2021, Yi Li wrote: Just return when alias is null and Remove the 'ret' variable. Signed-off-by: Yi Li --- src/qemu/qemu_block.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

[PATCH] qemuMonitorUnregister: Fix use-after-free of mon->watch

2021-02-17 Thread Peng Liang
qemuMonitorUnregister will be called in multiple threads (e.g. threads in rpc worker pool and the vm event thread). In some cases, it isn't protected by the monitor lock, which may lead to call g_source_unref more than one time and a use-after-free problem eventually. To avoid similar problem in

[PATCH] qemuBlockDiskDetectNodes: just return when alias is null

2021-02-17 Thread Yi Li
Just return when alias is null and Remove the 'ret' variable. Signed-off-by: Yi Li --- src/qemu/qemu_block.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 3d88e701b2..0af3e56c9a 100644 ---

Re: [libvirt PATCH v4 09/25] nodedev: add mdevctl devices to node device list

2021-02-17 Thread Jonathon Jongsma
On Tue, 16 Feb 2021 13:37:41 +0100 Erik Skultety wrote: > On Wed, Feb 03, 2021 at 11:38:53AM -0600, Jonathon Jongsma wrote: > > At startup, query devices that are defined by 'mdevctl' and add > > them to the node device list. > > > > This adds a complication: we now have two potential sources

Re: [PATCH v2 10/10] scripts/check-aclrules.py: check ACL for domain_driver.c ACL callers

2021-02-17 Thread Daniel Henrique Barboza
On 2/17/21 1:41 PM, Ján Tomko wrote: On a Tuesday in 2021, Daniel Henrique Barboza wrote: This script works under two specific conditions. For each opened file, search for all functions that has ACL calls and store them, and see if there is a vir*DriverPtr struct declared in it. For each

Re: [PATCH v3 0/1] rpc: avoid crash when system time jump back

2021-02-17 Thread Ján Tomko
On a Wednesday in 2021, BiaoxiangYe wrote: From: BiaoXiang Ye use G_USEC_PER_SEC instead of self-defining macro v2: - using monotonic timer instead of detecting a jump backwards BiaoXiang Ye (1): rpc: avoid crash when system time jump back src/rpc/virkeepalive.c | 15 --- 1 file

Re: [libvirt PATCH v4 14/25] api: add virNodeDeviceDefineXML()

2021-02-17 Thread Erik Skultety
On Wed, Feb 03, 2021 at 11:38:58AM -0600, Jonathon Jongsma wrote: > With mediated devices, we can now define persistent node devices that > can be started and stopped. In order to take advantage of this, we need > an API to define new node devices. > > Signed-off-by: Jonathon Jongsma > ---

Re: [libvirt PATCH v4 13/25] nodedev: add function to generate mdevctl define command

2021-02-17 Thread Erik Skultety
On Wed, Feb 03, 2021 at 11:38:57AM -0600, Jonathon Jongsma wrote: > Abstract out the function used to generate the commandline for 'mdevctl > start' since they take the same arguments. Add tests to ensure that > we're generating the command properly. > > Signed-off-by: Jonathon Jongsma > --- ...

Re: [libvirt PATCH] qemu_validate: Allow kvm hint-dedicated on non-passthrough VMs

2021-02-17 Thread Ján Tomko
On a Monday in 2021, Tim Wiederhake wrote: A VM defined similar to: ... ... is currently invalid, as hint-dedicated is only allowed if cpu mode is host-passthrough. This restriction is unnecessary, see https://bugzilla.redhat.com/show_bug.cgi?id=1857671. Please drop the period at the

Re: [PATCH] qemuBlockDiskDetectNodes: just return when alias is null

2021-02-17 Thread Ján Tomko
On a Thursday in 2021, Yi Li wrote: Just Return when alias is null and Remove the 'ret' variable. Signed-off-by: Yi Li --- src/qemu/qemu_block.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

Re: [PATCH v2 10/10] scripts/check-aclrules.py: check ACL for domain_driver.c ACL callers

2021-02-17 Thread Ján Tomko
On a Tuesday in 2021, Daniel Henrique Barboza wrote: This script works under two specific conditions. For each opened file, search for all functions that has ACL calls and store them, and see if there is a vir*DriverPtr struct declared in it. For each implementation found, check if there is an

Re: [libvirt PATCH v4 05/25] nodedev: add ability to parse mdevs from mdevctl

2021-02-17 Thread Jonathon Jongsma
On Tue, 16 Feb 2021 15:20:28 -0700 Alex Williamson wrote: > On Tue, 16 Feb 2021 16:00:40 -0600 > Jonathon Jongsma wrote: > > > On Mon, 15 Feb 2021 18:22:08 +0100 > > Erik Skultety wrote: > > > > > On Wed, Feb 03, 2021 at 11:38:49AM -0600, Jonathon Jongsma wrote: > > > > > > > diff