From: Daniel P. Berrangé
A long time ago the VNC server code had some memory corruption
fixes done in:
commit bea60dd7679364493a0d7f5b54316c767cf894ef
Author: Peter Lieven
Date: Mon Jun 30 10:57:51 2014 +0200
ui/vnc: fix potential memory corruption issues
One of the implications
From: Daniel P. Berrangé
We plan framebuffer update rects based on the VNC server surface. If the
client doesn't support desktop resize, then the client bounds may differ
from the server surface bounds. VNC clients may become upset if we then
send an update message outside the bounds of the
From: Daniel P. Berrangé
The WMVi message is supposed to provide the same width/height
information as the regular desktop resize and extended desktop
resize messages. There can be times where the client width and
height are different from the pixman surface dimensions.
Signed-off-by: Daniel P.
From: Daniel P. Berrangé
This adds trace points for desktop size and audio related messages.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Marc-André Lureau
Message-Id: <20210311182957.486939-2-berra...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c| 21 +++--
From: Daniel P. Berrangé
Currently when using SPICE the "password" option provides the password
in plain text on the command line. This is insecure as it is visible
to all processes on the host. As an alternative, the password can be
provided separately via the monitor.
This introduces a
From: Akihiko Odaki
Based-on: <20210310042348.21931-1-akihiko.od...@gmail.com>
Signed-off-by: Akihiko Odaki
Message-Id: <20210312133212.3131-1-akihiko.od...@gmail.com>
Signed-off-by: Gerd Hoffmann
---
ui/cocoa.m | 38 +-
1 file changed, 37 insertions(+), 1
From: Marc-André Lureau
A minor code simplification.
Signed-off-by: Marc-André Lureau
Message-Id: <20210312100108.2706195-2-marcandre.lur...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
ui/console.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git
From: Daniel P. Berrangé
With the new "password-secret" option, there is no reason to use the old
inecure "password" option with -spice, so it can be deprecated.
Signed-off-by: Daniel P. Berrangé
Message-Id: <2021034343.439820-4-berra...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
From: Akihiko Odaki
ui/cocoa used to call exit immediately after calling
qemu_system_shutdown_request, which prevents QEMU from actually
perfoming system shutdown. Just sleep forever, and wait QEMU to call
exit and kill the Cocoa thread.
Signed-off-by: Akihiko Odaki
Message-Id:
The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
request' into staging (2021-03-14 17:47:49 +)
are available in the Git repository at:
git://git.kraxel.org/qemu
From: Daniel P. Berrangé
Currently when using VNC the "password" flag turns on password based
authentication. The actual password has to be provided separately via
the monitor.
This introduces a "password-secret" option which lets the password be
provided up front.
$QEMU --object
From: Akihiko Odaki
OpenGL ES does not support conversion from the given data format
to the internal format with glTexImage2D.
Use the given data format as the internal format, and ignore
the given alpha channels with GL_TEXTURE_SWIZZLE_A in case the
format contains alpha channels.
On a Tuesday in 2021, Michal Privoznik wrote:
Let me take you ~8 years back. Back then, virNetworkUpdate() API
was introduced and the public implementation is nothing special -
it calls the networkUpdate() callback of the network driver.
Except, a small "typo" slipped through - while the public
On a Tuesday in 2021, Michal Privoznik wrote:
Somehow, command argument was not printed into debug logs. It is
imperative that all arguments are logged.
Signed-off-by: Michal Privoznik
---
src/libvirt-network.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
On a Monday in 2021, Michal Privoznik wrote:
When connecting to the monitor, a timeout is calculated that is
bigger the more memory guest has (because QEMU has to allocate
and possibly zero out the memory and what not, empirically
deducted). However, when computing the timeout the @total_memory
On a Monday in 2021, Michal Privoznik wrote:
We don't like virXXXPtr typedefs really and they are going away
shortly, possibly. Do not encourage new code to put in the
typedefs.
Signed-off-by: Michal Privoznik
---
docs/coding-style.rst | 9 +++--
1 file changed, 3 insertions(+), 6
We don't like virXXXPtr typedefs really and they are going away
shortly, possibly. Do not encourage new code to put in the
typedefs.
Signed-off-by: Michal Privoznik
---
docs/coding-style.rst | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/docs/coding-style.rst
On Mon, Mar 15, 2021 at 06:30:42PM +0100, Michal Privoznik wrote:
> In the past, we used to have this oomtrace.pl script that
> attempted to print the stack trace of where an OOM error
> occurred and it used addr2line for that. But since v5.8.0-rc1~189
> we don't really care about OOM anymore and
On 3/15/21 12:45 PM, Daniel P. Berrangé wrote:
> This has been hardcoded to "false" since 2.10.0, since secrets required
> to unlock block devices are now always provided upfront instead of using
up front
> interactive prompts.
>
> Reviewed-by: Thomas Huth
> Signed-off-by: Daniel P. Berrangé
On 3/15/21 12:45 PM, Daniel P. Berrangé wrote:
> The code comment suggests removing QAPIEvent_(str|lookup) symbols too,
> however, these are both auto-generated as standard for any enum in
> QAPI. As such it they'll exist whether we use them or not.
>
> Reviewed-by: Thomas Huth
> Signed-off-by:
Pure code motion, no functional change.
Signed-off-by: Gerd Hoffmann
Message-Id: <20210312090425.772900-4-kra...@redhat.com>
---
hw/usb/dev-storage-classic.c | 156 +++
hw/usb/dev-storage.c | 135 --
hw/usb/meson.build
From: Thomas Huth
There are some more -usbdevice options that have never been mentioned
in the documentation. Now that we removed -usbdevice from the list
of deprecated features again, we should document them properly.
While we're at it, also sort them alphabetically.
Signed-off-by: Thomas
Pure code motion, no functional change.
Signed-off-by: Gerd Hoffmann
Message-Id: <20210312090425.772900-3-kra...@redhat.com>
---
hw/usb/dev-storage-bot.c | 63
hw/usb/dev-storage.c | 42 ---
hw/usb/meson.build | 1 +
3
Add new kconfig symbols so usb-storage and usb-bot can
be enabled or disabled individually at build time.
Signed-off-by: Gerd Hoffmann
Message-Id: <20210312090425.772900-5-kra...@redhat.com>
---
hw/usb/Kconfig | 13 -
hw/usb/meson.build | 4 ++--
2 files changed, 14
In preparation for splitting the usb-storage.c file move
declarations to the new usb/msd.h header file.
Signed-off-by: Gerd Hoffmann
Message-Id: <20210312090425.772900-2-kra...@redhat.com>
---
include/hw/usb/msd.h | 54
hw/usb/dev-storage.c | 48
Stale data in csw (specifically residue) can confuse the state machine
and allows the guest trigger an assert(). So clear csw on reset to
avoid this happening in case the guest resets the device in the middle
of a request.
Buglink: https://bugs.launchpad.net/qemu/+bug/1523811
Signed-off-by: Gerd
From: Philippe Mathieu-Daudé
The VT82C686 south bridge provides a USB UHCI bus via a PCI function.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
Message-Id: <20210309190802.830969-2-f4...@amsat.org>
Signed-off-by: Gerd Hoffmann
---
hw/isa/Kconfig | 1 +
1 file changed, 1
From: Philippe Mathieu-Daudé
Extract generic UHCI prototypes into a new "hcd-uhci.h" local
header so we can reuse them in other units.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210309190802.830969-3-f4...@amsat.org>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.h | 93
From: Thomas Huth
When trying to remove the -usbdevice option, there were complaints that
"-usbdevice braille" is still a very useful shortcut for some people.
Thus we never remove this option. Since it's not such a big burden to
keep it around, and it's also convenient in the sense that you
From: Thomas Huth
This property was only required for the pc-1.0 and earlier machine
types. Since these have been removed now, we can delete the property
as well.
Signed-off-by: Thomas Huth
Message-Id: <20210302120152.118042-1-th...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
From: Paolo Bonzini
It never worked.
Signed-off-by: Paolo Bonzini
Cc: Gerd Hoffmann
Signed-off-by: Thomas Huth
Message-Id: <20210310173323.1422754-3-th...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/u2f.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/u2f.c
From: Philippe Mathieu-Daudé
Extract the VT82C686 PCI UHCI function into a new unit so
it is only build when the VT82C686 south bridge is selected.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20210309190802.830969-4-f4...@amsat.org>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.c
From: Paolo Bonzini
No device needs them anymore and in fact they're undocumented.
Remove the code. The only change in behavior is that "-usbdevice
braille:hello" now reports an error, which is a bugfix.
Signed-off-by: Paolo Bonzini
Cc: Gerd Hoffmann
Signed-off-by: Thomas Huth
Message-Id:
The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
request' into staging (2021-03-14 17:47:49 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/usb-20210315
On Mon, 2021-03-15 at 14:24 +0100, Erik Skultety wrote:
> On Fri, Mar 12, 2021 at 06:28:18PM +0100, Andrea Bolognani wrote:
> > +containerparser.add_argument(
> > +"target",
> > +help="build on target OS",
>
> With the 'shell' action, not sure if "build" is the
The 'host_device' and 'host_cdrom' drivers must be used instead.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/file-posix.c | 17 ++---
docs/system/deprecated.rst | 7 ---
docs/system/removed-features.rst | 7 +++
The same data is available in the 'BlockDeviceInfo' struct.
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Daniel P. Berrangé
---
block/qapi.c| 5 -
docs/system/deprecated.rst | 13 -
The same information is available via the 'recording' and 'busy' fields.
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Daniel P. Berrangé
---
block/dirty-bitmap.c | 38
docs/system/deprecated.rst | 7 -
docs/system/removed-features.rst | 7 +
This has been hardcoded to "false" since 2.10.0, since secrets required
to unlock block devices are now always provided upfront instead of using
interactive prompts.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
block/qapi.c | 1 -
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 9 -
docs/system/removed-features.rst | 6
hw/i386/pc.c | 1 -
hw/scsi/scsi-disk.c |
The 'ide-hd' and 'ide-cd' devices provide suitable alternatives.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/qdev-device-use.txt | 2 +-
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 8 +++
hw/i386/pc.c
This only makes sense conceptually when used with listener chardevs.
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
chardev/char-socket.c| 12
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
3 files
The generic 'migrate_set_parameters' command handle all types of param.
Only the QMP commands were documented in the deprecations page, but the
rationale for deprecating applies equally to HMP, and the replacements
exist. Furthermore the HMP commands are just shims to the QMP commands,
so
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 6 +
hw/core/machine-qmp-cmds.c | 41
qapi/machine.json| 22 -
4 files
The newer 'query-cpus-fast' command avoids side effects on the guest
execution. Note that some of the field names are different in the
'query-cpus-fast' command.
Reviewed-by: Wainer dos Santos Moschetta
Tested-by: Wainer dos Santos Moschetta
Signed-off-by: Daniel P. Berrangé
---
The code comment suggests removing QAPIEvent_(str|lookup) symbols too,
however, these are both auto-generated as standard for any enum in
QAPI. As such it they'll exist whether we use them or not.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst |
This is only semantically useful for QMP.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 7 ---
docs/system/removed-features.rst | 6 ++
monitor/monitor.c| 4 ++--
qemu-options.hx | 5 +++--
The VNC ACL concept has been replaced by the pluggable "authz" framework
which does not use monitor commands.
Reviewed-by: Thomas Huth
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 16 ---
docs/system/removed-features.rst | 13
This is an update to
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg07558.html
The following features have been deprecated for well over the 2
release cycle we promise
``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
``-vnc acl`` (since 4.0.0)
``-mon
Signed-off-by: Erik Skultety
---
docs/kbase/locking-sanlock.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/kbase/locking-sanlock.rst b/docs/kbase/locking-sanlock.rst
index bd85c2e36e..24895b42f4 100644
--- a/docs/kbase/locking-sanlock.rst
+++
The page isn't linked from anywhere and the contents is dated.
Images related to the page are also dropped.
Signed-off-by: Erik Skultety
---
docs/architecture.gif | Bin 5571 -> 0 bytes
docs/architecture.html.in | 82 -
docs/architecture.svg | 239
There was one external reference to this page's section which was fixed
manually.
Signed-off-by: Erik Skultety
---
docs/auth.html.in | 368 -
docs/auth.rst | 343 ++
docs/kbase/locking-sanlock.rst | 2 +-
since v1:
- fixed a broken heading reference from a kbase article caused by RST convers=
ion
- dropped architecture.html.in along with images
v1: https://listman.redhat.com/archives/libvir-list/2021-March/msg00584.html
Erik Skultety (3):
docs: html.in: Drop the architecture page
docs:
On 3/15/21 4:46 PM, Ján Tomko wrote:
two minor bug fixes
Ján Tomko (2):
cmdList: mark title as autofree
nss: findLease: do not leak path
tools/nss/libvirt_nss.c | 4 +++-
tools/virsh-domain-monitor.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by:
In the past, we used to have this oomtrace.pl script that
attempted to print the stack trace of where an OOM error
occurred and it used addr2line for that. But since v5.8.0-rc1~189
we don't really care about OOM anymore and the script is long
gone so there's no need to check for addr2line program
When connecting to the monitor, a timeout is calculated that is
bigger the more memory guest has (because QEMU has to allocate
and possibly zero out the memory and what not, empirically
deducted). However, when computing the timeout the @total_memory
mmember is accessed directly even though
On Fri, Mar 12, 2021 at 01:57:30PM +0100, Peter Krempa wrote:
> On Fri, Mar 12, 2021 at 12:43:03 +0100, Erik Skultety wrote:
> > '#itsfriday'
>
> For docs changes a good help for reviewers is to push to your private
> gitlab clone and provide a link to the artifacts of the 'webpage' job so
> that
On Mon, 2021-03-15 at 14:28 +0100, Michal Privoznik wrote:
> On 3/15/21 12:22 PM, Andrea Bolognani wrote:
> > if (virFileReadAllQuiet(procfile, 2048, ) < 0)
> > -return -1;
> > +goto error;
>
> virFileReadAllQuiet() sets errno, this would just overwrite it with
> something
Am 15.03.2021 um 16:26 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 13.03.2021 um 14:40 hat Markus Armbruster geschrieben:
> >> Markus Armbruster writes:
> >>
> >> > Paolo Bonzini writes:
> >> >
> >> >> On 11/03/21 15:08, Markus Armbruster wrote:
> >> I would rather
We still check for realloc's return value in the nss module.
Free the path in case it fails before jumping to cleanup.
Signed-off-by: Ján Tomko
---
tools/nss/libvirt_nss.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c
Fixes the (im)possible memory leak on vshTableRowAppend failure.
Signed-off-by: Ján Tomko
---
tools/virsh-domain-monitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 897339b6f9..fcbc2fe9f0 100644
---
two minor bug fixes
Ján Tomko (2):
cmdList: mark title as autofree
nss: findLease: do not leak path
tools/nss/libvirt_nss.c | 4 +++-
tools/virsh-domain-monitor.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
--
2.29.2
Kevin Wolf writes:
> Am 13.03.2021 um 14:40 hat Markus Armbruster geschrieben:
>> Markus Armbruster writes:
>>
>> > Paolo Bonzini writes:
>> >
>> >> On 11/03/21 15:08, Markus Armbruster wrote:
>> I would rather keep the OptsVisitor here. Do the same check for JSON
>> syntax that
Am 15.03.2021 um 15:15 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben:
> >> Paolo Bonzini writes:
> >>
> >> > On 13/03/21 08:40, Markus Armbruster wrote:
> >> >>> +if (!user_creatable_add_from_str(optarg,
Kevin Wolf writes:
> Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben:
>> Paolo Bonzini writes:
>>
>> > On 13/03/21 08:40, Markus Armbruster wrote:
>> >>> +if (!user_creatable_add_from_str(optarg, _err)) {
>> >>> +if (local_err) {
>> >>> +
On Mon, Mar 15, 2021 at 02:13:50PM +0100, Pavel Hrdina wrote:
> When switching to g_autoptr this was incorrectly changed from
> 'continue;' into 'return -1;' resulting into an error when user tries
> to set vcpu_quota of running VM:
>
> error: An error occurred, but the cause is unknown
>
>
On Fri, Mar 12, 2021 at 06:28:12PM +0100, Andrea Bolognani wrote:
> Changes from [v2]:
>
> * address review feedback;
>
> * wrap more Makefile functionality;
>
> * split into smaller, easier to review patches.
>
> Changes from [v1]:
>
> * implement (partial) support for running builds
On Fri, Mar 12, 2021 at 06:28:19PM +0100, Andrea Bolognani wrote:
> This simply calls the underlying Makefile target, but allows
> additional arguments to be specified in a more convenient and
> discoverable way.
>
> Signed-off-by: Andrea Bolognani
> ---
> ci/helper | 33
On 3/15/21 12:22 PM, Andrea Bolognani wrote:
On Mon, 2021-03-15 at 11:57 +0100, Andrea Bolognani wrote:
The changes you're suggesting are not trivial enough for me to feel
comfortable simply applying them locally and then pushing right away.
Would the diff below look reasonable squashed in?
On Fri, Mar 12, 2021 at 06:28:18PM +0100, Andrea Bolognani wrote:
> This simply calls the underlying Makefile target, but allows
> additional arguments to be specified in a more convenient and
> discoverable way.
>
> Signed-off-by: Andrea Bolognani
> ---
> ci/helper | 48
On Fri, Mar 12, 2021 at 06:28:16PM +0100, Andrea Bolognani wrote:
> This provides the same functionality as the two refresh scripts
> that are currently in the repository, with the following
> advantages:
>
> * all files are refreshed with a single command;
>
> * if lcitool is present in the
On Fri, Mar 12, 2021 at 06:28:15PM +0100, Andrea Bolognani wrote:
> This is intended to be perform a number of CI-related operations
> that are currently implemented in various different scripts
> written in various different programming languages.
>
> Eventually, all existing functionality will
On Fri, Mar 12, 2021 at 06:54:15PM +0100, Andrea Bolognani wrote:
> On Tue, 2021-02-23 at 16:17 +0100, Erik Skultety wrote:
> > On Wed, Feb 17, 2021 at 10:24:51AM +0100, Andrea Bolognani wrote:
> > > This is intended to be the perform a number of CI-related
> > > operations that currently are
When switching to g_autoptr this was incorrectly changed from
'continue;' into 'return -1;' resulting into an error when user tries
to set vcpu_quota of running VM:
error: An error occurred, but the cause is unknown
Fixes: e4a8bbfaf2b4cdd741bb441873bb730f9134b714
Signed-off-by: Pavel Hrdina
Ping for anyone willing to review this so I can get this in before freeze.
On Wed, Feb 24, 2021 at 01:11:35PM +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/system/deprecated.rst | 6 -
> docs/system/removed-features.rst | 6 +
>
* Kevin Wolf (kw...@redhat.com) wrote:
> Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben:
> > Paolo Bonzini writes:
> >
> > > On 13/03/21 14:28, Markus Armbruster wrote:
> > >> Kevin Wolf writes:
> > >>
> > >>> This switches the HMP command object_add from a QemuOpts-based parser to
>
On Sat, Feb 27, 2021 at 08:34:08AM +0400, Roman Bogorodskiy wrote:
> Implement "" support for bhyve driver.
> As there are not really lot of options, try to find
> "BHYVE_UEFI.fd" firmware which is installed by the
> sysutils/uefi-edk2-bhyve FreeBSD port.
>
> If not found, just use the first
On 24/02/2021 14.11, Daniel P. Berrangé wrote:
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives.
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 9 -
docs/system/removed-features.rst | 6
hw/i386/pc.c | 1 -
On 2/24/21 7:11 AM, Daniel P. Berrangé wrote:
> The 'host_device' and 'host_cdrom' drivers must be used instead.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> block/file-posix.c | 17 ++---
> docs/system/deprecated.rst | 7 ---
>
On 15/03/21 12:38, Dr. David Alan Gilbert wrote:
* Kevin Wolf (kw...@redhat.com) wrote:
Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben:
Paolo Bonzini writes:
On 13/03/21 14:28, Markus Armbruster wrote:
Kevin Wolf writes:
This switches the HMP command object_add from a
Ping for anyone, especially block maintainers, willing to review this
before soft freeze.
On Wed, Feb 24, 2021 at 01:11:42PM +, Daniel P. Berrangé wrote:
> The 'host_device' and 'host_cdrom' drivers must be used instead.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> block/file-posix.c
On 24/02/2021 14.11, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 6 +
hw/core/machine-qmp-cmds.c | 41
qapi/machine.json| 22
Am 13.03.2021 um 09:41 hat Markus Armbruster geschrieben:
> Observation, not objection:
>
> 1. QMP core parses JSON text into QObject, passes to generated
>marshaller.
>
> 2. Marshaller converts QObject to ObjectOptions with the QObject input
>visitor, passes to qmp_object_add().
>
> 3.
Am 13.03.2021 um 13:30 hat Markus Armbruster geschrieben:
> Paolo Bonzini writes:
>
> > On 13/03/21 08:40, Markus Armbruster wrote:
> >>> +if (!user_creatable_add_from_str(optarg, _err)) {
> >>> +if (local_err) {
> >>> +
Am 13.03.2021 um 14:40 hat Markus Armbruster geschrieben:
> Markus Armbruster writes:
>
> > Paolo Bonzini writes:
> >
> >> On 11/03/21 15:08, Markus Armbruster wrote:
> I would rather keep the OptsVisitor here. Do the same check for JSON
> syntax that you have in
On Mon, 2021-03-15 at 11:57 +0100, Andrea Bolognani wrote:
> The changes you're suggesting are not trivial enough for me to feel
> comfortable simply applying them locally and then pushing right away.
> Would the diff below look reasonable squashed in?
>
> diff --git a/src/util/virprocess.c
Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben:
> Paolo Bonzini writes:
>
> > On 13/03/21 14:28, Markus Armbruster wrote:
> >> Kevin Wolf writes:
> >>
> >>> This switches the HMP command object_add from a QemuOpts-based parser to
> >>> user_creatable_add_from_str() which uses a
Upstream kernel had removed both host[1] and guest[2] support.
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=45c7e8af4a5e3f0bea4ac209eea34118dd57ac64
[2]:
On Mon, 2021-03-15 at 10:21 +0100, Michal Privoznik wrote:
> On 3/9/21 2:47 PM, Andrea Bolognani wrote:
> > +static int
> > +virProcessGetLimitFromProc(pid_t pid,
> > + int resource,
> > + struct rlimit *limit)
> > +{
> > +g_autofree char
On Fri, Mar 12, 2021 at 12:43:12 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/compiling.html.in | 115 -
> docs/compiling.rst | 95 ++
> docs/meson.build | 2 +-
> 3 files changed, 96
On Fri, Mar 12, 2021 at 12:43:11 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/bindings.html.in | 101 --
> docs/bindings.rst | 62 ++
> docs/meson.build | 2 +-
> 3 files changed, 63
On Fri, Mar 12, 2021 at 12:43:09 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/auditlog.html.in | 375 --
> docs/auditlog.rst | 321
> docs/meson.build | 2 +-
> 3 files changed, 322
On Fri, Mar 12, 2021 at 13:56:06 +0100, Peter Krempa wrote:
> On Fri, Mar 12, 2021 at 12:43:08 +0100, Erik Skultety wrote:
> > Signed-off-by: Erik Skultety
> > ---
> > docs/architecture.html.in | 82 --
> > docs/architecture.rst | 83
On Fri, Mar 12, 2021 at 12:43:07 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/apps.html.in | 488 --
> docs/apps.rst | 348 +
> docs/meson.build | 2 +-
> 3 files changed, 349
On Fri, Mar 12, 2021 at 12:43:06 +0100, Erik Skultety wrote:
> There were a number of occurrences where we used nested inline markup
> (verbatim + refs) which is currently not possible with RST syntax [1].
> There is a possible workaround involving substitution definitions like
>
> ..
On Fri, Mar 12, 2021 at 12:43:05 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/api_extension.html.in | 376 -
> docs/api_extension.rst | 291
> docs/meson.build | 2 +-
> 3 files changed,
On Fri, Mar 12, 2021 at 12:43:04 +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> docs/aclpolkit.html.in | 523 -
> docs/aclpolkit.rst | 310
> docs/meson.build | 2 +-
> 3 files changed, 311
On 2/27/21 5:34 AM, Roman Bogorodskiy wrote:
Implement "" support for bhyve driver.
As there are not really lot of options, try to find
"BHYVE_UEFI.fd" firmware which is installed by the
sysutils/uefi-edk2-bhyve FreeBSD port.
If not found, just use the first found firmware
in the firmwares
Paolo Bonzini writes:
> On 13/03/21 14:28, Markus Armbruster wrote:
>> Kevin Wolf writes:
>>
>>> This switches the HMP command object_add from a QemuOpts-based parser to
>>> user_creatable_add_from_str() which uses a keyval parser and enforces
>>> the QAPI schema.
>>>
>>> Apart from being a
On 3/9/21 2:47 PM, Andrea Bolognani wrote:
Calling prlimit() requires elevated privileges, specifically
CAP_SYS_RESOURCE, and getrlimit() only works for the current
process which is too limiting for our needs; /proc/$pid/limits,
on the other hand, can be read by any process, so implement
parsing
1 - 100 of 102 matches
Mail list logo
