On 3/17/21 4:57 AM, Olaf Hering wrote:
Various changes to handle libxl API variants.
Thanks for taking this on! It is much simpler than the crap I've cooked up in
the past. I haven't taken another stab since we've moved to meson, and I'd like
to blame autotools, but...
We'll need to sort
On 3/17/21 4:57 AM, Olaf Hering wrote:
Upcoming changes will use different LIBXL_API_VERSION variants.
Prepare libxl_set_memory_target, which changed the storage size of
parameter "target_memkb" in Xen 4.8.
No functional change intended.
Signed-off-by: Olaf Hering
---
src/libxl/libxl_api.h
On 3/17/21 4:57 AM, Olaf Hering wrote:
Upcoming changes will use different LIBXL_API_VERSION variants.
Prepare libxl_get_free_memory, which changed storage size of parameter
"memkb" in Xen 4.8.
No functional change intended.
Signed-off-by: Olaf Hering
---
src/libxl/libxl_api.h| 19
On 3/17/21 4:57 AM, Olaf Hering wrote:
Upcoming changes will use different LIBXL_API_VERSION variants.
Prepare libxl_domain_create_restore, which got a new parameter
"send_back_fd" in Xen 4.7. libvirt does not use this parameter.
No functional change intended.
Signed-off-by: Olaf Hering
---
Am Thu, 18 Mar 2021 16:26:14 -0600
schrieb Jim Fehlig :
> Maybe libxlDomainCreateRestoreWrap?
> The 'Wrap' suffix compliments the libxl_api_wrap.h name suggestion.
"Naming conventions" does not cover API wrapping.
Some of the names are already taken, like
On Thu, 18 Mar 2021 at 09:30, Daniel P. Berrangé wrote:
>
> The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0:
>
> Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316'
> into staging (2021-03-17 21:02:37 +)
>
> are available in the Git
When testing locally built daemons on a systemd host there can be quite
a few systemd units that need temporarily stopping, and ideally
restarting after the test is complete. This becomes a massive burden
when modular daemons are running and you want to test libvirtd, as a
huge number of units
Running virtqemud, we just stop the virqemud daemon units
Temporarily stopping systemd units...
> virtqemud.socket
> virtqemud-ro.socket
> virtqemud-admin.socket
Running ./src/virtqemud...
^CRe-starting original systemd units...
> virtqemud-admin.socket
> virtqemud-ro.socket
>
This fits with the goal of eliminating non-Python scripting languages,
and makes forthcoming changes far easier.
Signed-off-by: Daniel P. Berrangé
---
run.in | 45 ++---
1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/run.in b/run.in
index
The qemu STOP event doesn't really report why the VM was stopped. In
certain cases we do expect this by storing the expectation in the
private data.
In cases we've encountered an unexpected STOP event we can offload to
the event thread a job to refresh the state using 'query-status'.
For all
In certain cases hypervisors on encountering an internal fault pause the
domain to allow gathering useful debugging information. Libvirt for now
would report 'VIR_DOMAIN_PAUSED_UNKNOWN' which isn't entirely helpful.
Add a new paused reason and the corresponding value for the suspended
event, so
Use g_autofree for the JSON values to remove cleanup label and ret
variable.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index
Peter Krempa (3):
qemuMonitorJSONGetStatus: Refactor cleanup
API: Add VIR_DOMAIN_PAUSED_HYPERVISOR_FAULT enum value
qemu: Update paused reason on unexpected 'STOP' event
examples/c/misc/event-test.c | 3 +++
include/libvirt/libvirt-domain.h | 2 ++
src/conf/domain_conf.c |
On Thu, Mar 18, 2021 at 06:10:45PM +0100, Pavel Hrdina wrote:
> On Thu, Mar 18, 2021 at 05:18:36PM +0100, Michal Privoznik wrote:
> > On 3/18/21 1:26 PM, Pavel Hrdina wrote:
> > > When the firmware auto-selection was introduced it always picked first
> > > usable firmware based on the JSON
On Thu, Mar 18, 2021 at 05:42:47PM +0100, Kashyap Chamarthy wrote:
> On Thu, Mar 18, 2021 at 01:26:38PM +0100, Pavel Hrdina wrote:
> > The original text was not explaining what this attribute actually
> > controls and could have been interpreted as a control switch for the
> > Secure boot feature
On Thu, Mar 18, 2021 at 05:18:38PM +0100, Michal Privoznik wrote:
> On 3/18/21 1:26 PM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/qemu/qemu_firmware.c | 40 +++
> > ...re-efi-no-enrolled-keys.x86_64-latest.args | 49 ++
On Thu, Mar 18, 2021 at 05:18:36PM +0100, Michal Privoznik wrote:
> On 3/18/21 1:26 PM, Pavel Hrdina wrote:
> > When the firmware auto-selection was introduced it always picked first
> > usable firmware based on the JSON descriptions on the host. It is
> > possible to add/remove/change the JSON
When the backup job is terminated normally the security label is
restored by the blockjob finishing handler.
If the VM dies or is destroyed that wouldn't happen as the blockjob
handler wouldn't be called.
Restore the security label on disk store where we remember that the job
was running at the
qemuBackupBegin can take a full backup of the disks (excluding any
operations with bitmaps) without the need to wait for the
blockdev-reopen support in qemu.
Add a check that no checkpoint creation is required and the disk backup
mode isn't VIR_DOMAIN_BACKUP_DISK_BACKUP_MODE_INCREMENTAL.
Call to
Signed-off-by: Peter Krempa
---
NEWS.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9d819a3cf2..c2013ecac9 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -24,6 +24,15 @@ v7.2.0 (unreleased)
The memory dirty rate stats can be obtained through ``virsh
Upcoming commit will enable full backup support (incremental part
requires blockdev-reopen, which won't happen in qemu for at least
another release).
Add a capability that the 'blockdev-backup' job is supported by qemu
capped, but limited to when qemu supports QEMU_CAPS_BLOCKDEV.
We can also use
Peter Krempa (3):
qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_BACKUP
qemu: backup: Enable full backup support
NEWS: Mention support for full backups via virDomainBackupBegin
NEWS.rst | 9 ++
src/qemu/qemu_backup.c| 28
On Thu, Mar 18, 2021 at 01:26:38PM +0100, Pavel Hrdina wrote:
> The original text was not explaining what this attribute actually
> controls and could have been interpreted as a control switch for the
> Secure boot feature in firmwares.
Yep, I've indeed seen people misread it as such.
>
On Thu, 2021-03-18 at 17:11 +0100, Erik Skultety wrote:
> +msg = textwrap.dedent(f"""
> +The following images are stale and can be purged from the
> registry:
> +
> +STALE_DETAILS
> +
> +You can delete the images listed above using
On 3/18/21 1:26 PM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_firmware.c | 40 +++
...re-efi-no-enrolled-keys.x86_64-latest.args | 49 ++
.../os-firmware-efi-no-enrolled-keys.xml | 25 ++
On 3/18/21 1:26 PM, Pavel Hrdina wrote:
When the firmware auto-selection was introduced it always picked first
usable firmware based on the JSON descriptions on the host. It is
possible to add/remove/change the JSON files but it will always be for
the whole host.
This patch introduces support
This function checks whether there are any stale Docker images in the
registry that can be purged. Since we're pulling available container
images from our GitLab registry with the 'list-images' action, it
could happen that we'd list old (already unsupported) images and make
them available for the
As documented at [1], the common practice with respect to private
attributes/methods naming is to prefix them with an underscore.
[1] https://docs.python.org/3/tutorial/classes.html#private-variables
Signed-off-by: Erik Skultety
---
ci/helper | 122
Offer an option to silence all output to stdout, e.g. when generating
dockerfiles/varsfiles.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/helper | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ci/helper b/ci/helper
index
The corresponding Bash script is dropped.
After this patch's rewrite, the Makefile's original image listing
target remains intact only to notify the user to use the Python helper
instead.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/Makefile | 12
With the gradual rewrite of the Makefile to the 'helper' script will
require helper functions that would better live in a separate util
module.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/util.py | 40
1 file changed, 40
since v3:
- more formatting changes as requested per review comments
- get_registry_stale_images was simplified according to the comments
- class attributes were also converted to private in [6/6]
v1: https://listman.redhat.com/archives/libvir-list/2021-February/msg00641.ht=
ml
v2:
This help formatter class reports the defaults we use for options
taking an argument.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/helper | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/helper b/ci/helper
index 73a3f729da..8f34f4b59d 100755
--- a/ci/helper
+++
On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote:
> On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote:
> > As documented at [1], the common practice wrt to private
>
> s/wrt to/with respect to/
>
> > def parse(self):
> > return self.parser.parse_args()
>
>
...
> > +def get_registry_stale_images(registry_uri: str,
> > + supported_distros: List[str]) -> Dict[str,
> > int]:
> > +"""
> > +Check the GitLab image registry for images that we no longer support
> > and
> > +which should be deleted.
> > +
> > +
New option -compat lets you configure what to do when deprecated
interfaces get used. This is intended for testing users of the
management interfaces. It is experimental.
-compat deprecated-input= configures what to do when
deprecated input is received. Available policies:
* accept: Accept
On Thu, Mar 18, 2021 at 09:00:41AM +0100, Tim Wiederhake wrote:
> Convenience function to return value of a yes / no attribute.
>
> Does not use virTristateBoolTypeFromString to disallow "default".
>
> Signed-off-by: Tim Wiederhake
> ---
> src/util/virxml.c | 37
On Thu, Mar 18, 2021 at 04:03:17PM +0100, Michal Privoznik wrote:
> On 3/18/21 9:00 AM, Tim Wiederhake wrote:
> > Convenience function to return value of a yes / no attribute.
> >
> > Does not use virTristateBoolTypeFromString to disallow "default".
> >
> > Signed-off-by: Tim Wiederhake
> > ---
On Thu, 2021-03-18 at 16:03 +0100, Michal Privoznik wrote:
> On 3/18/21 9:00 AM, Tim Wiederhake wrote:
> > (...)
> > 10 files changed, 314 insertions(+), 663 deletions(-)
> >
>
> Reviewed-by: Michal Privoznik
>
> Nice cleanup!
>
> And if you agree with my suggestions in 01-02/38 (suggestion
This series needs fixups to not break --disable-system --disable-tools
builds. It's not much (see appended diff), but enough to make me respin
it as v7. I'll respin the pull request, too.
diff --git a/include/qapi/compat-policy.h b/include/qapi/compat-policy.h
index b8c6638156..1083f95122
On 3/18/21 9:00 AM, Tim Wiederhake wrote:
Convenience function to return value of a yes / no attribute.
Does not use virTristateBoolTypeFromString to disallow "default".
Signed-off-by: Tim Wiederhake
---
src/util/virxml.c | 37 +
src/util/virxml.h | 4
On 3/18/21 9:00 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/storage_adapter_conf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/storage_adapter_conf.h b/src/conf/storage_adapter_conf.h
index 4c7da7c8d9..93879acb6e 100644
---
On 3/18/21 9:00 AM, Tim Wiederhake wrote:
This series replaces some recurring boilerplate code in src/conf/ regarding
the extraction of a virTristate(Switch|Bool) XML attribute.
The boilerplate code looks roughly like this,
g_autofree char *str = NULL;
if (str = virXMLPropString(node,
On 3/18/21 9:00 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
Had to rebase this, because meanwhile I pushed another patch that
touched this area.
diff --git
On 3/10/21 5:42 PM, Kristina Hanicova wrote:
Kristina Hanicova (2):
move virDomainCheckVirtioOptionsAreAbsent a few lines forward
XML validate that non-virtio video devices have none virtio options
src/conf/domain_validate.c | 60 --
1 file changed,
On 3/12/21 1:44 PM, Kristina Hanicova wrote:
Kristina Hanicova (2):
conf: Propagate xmlXPathContextPtr into virDomainDeviceInfoParseXML()
refactoring virDomainDeviceInfoParseXML to use XPath
src/conf/domain_conf.c | 116 +
1 file changed, 49
On 3/11/21 2:13 AM, Hogan Wang wrote:
From: Zhuang Shengen
When a vm is doing migration phase confirm, and then start it concurrently,
it will lead to the vm out of libvirtd control.
Cause Analysis:
1. thread1 migrate vm out.
2. thread2 start the migrating vm.
3. thread1 remove vm from domain
On 3/16/21 1:20 PM, Roman Bogorodskiy wrote:
Implement "" support for bhyve driver.
As there are not really lot of options, try to find
"BHYVE_UEFI.fd" firmware which is installed by the
sysutils/uefi-edk2-bhyve FreeBSD port.
If not found, just use the first found firmware
in the firmwares
The original code used a lot of conditions and was not that obvious
when each XML bits are parsed.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/src/conf/domain_conf.c
Extract the code to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 42 +++---
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 03985b6687..f6e8d5180a 100644
---
Extract the code to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 39 +++
1 file changed, 27 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4876fe61bb..03985b6687 100644
---
Extract the code to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 79 --
1 file changed, 45 insertions(+), 34 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f6e8d5180a..14a2c818d6 100644
---
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_firmware.c | 40 +++
...re-efi-no-enrolled-keys.x86_64-latest.args | 49 ++
.../os-firmware-efi-no-enrolled-keys.xml | 25 ++
tests/qemuxml2argvtest.c | 1 +
When the firmware auto-selection was introduced it always picked first
usable firmware based on the JSON descriptions on the host. It is
possible to add/remove/change the JSON files but it will always be for
the whole host.
This patch introduces support for configuring the auto-selection per VM
Extract the code to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 31b908d8fe..4876fe61bb 100644
--- a/src/conf/domain_conf.c
Extract the code to it's own function.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 109 +++--
1 file changed, 61 insertions(+), 48 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 47756ff0be..31b908d8fe 100644
---
Cleanup the parser code and implement firmware feature filtering support
to allow users to modify firmware auto-selection behavior per VM.
More details in PATCH 08.
Pavel Hrdina (9):
docs: improve description of secure attribute for loader element
conf: introduce
The original text was not explaining what this attribute actually
controls and could have been interpreted as a control switch for the
Secure boot feature in firmwares.
Signed-off-by: Pavel Hrdina
---
docs/formatdomain.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On 3/16/21 11:27 PM, Jonathon Jongsma wrote:
If libvirtd is terminated before the node driver finishes
initialization, it can crash with a backtrace similar to the following:
Stack trace of thread 1922933:
#0 0x7f8515178774 g_hash_table_find (libglib-2.0.so.0)
#1
On 3/17/21 6:01 PM, Kristina Hanicova wrote:
Previously, if xml node passed to the virXMLNodeContentString()
was not of type XML_ELEMENT_NODE, @ret could have caused a memory
leak because xmlNodeGetContent() works for other types of nodes
as well.
Signed-off-by: Kristina Hanicova
---
On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote:
> As documented at [1], the common practice wrt to private
s/wrt to/with respect to/
> def parse(self):
> return self.parser.parse_args()
Shouldn't this change be applied to Parser.parser...
> def run(self):
>
On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote:
> +def check_stale_images(self):
> +if self.args.check_stale != "yes" or self.args.quiet:
> +return
I would prefer it if this check were to be performed in the
action_refresh() method to decide whether or not
On 3/18/21 10:00 AM, Hao Wang wrote:
Signed-off-by: Hao Wang
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index bd40373a80..df35044ef0 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,17 @@ v7.2.0 (unreleased)
* **New features**
+
On Wed, 2021-03-17 at 18:40 +0100, Erik Skultety wrote:
> One more thing, what is the Python 3. acceptance policy for scripts? I
> mean we expect the scripts to work with 3.X as we declare on libvirt.org, but
> f-strings for example are 3.6+ and 3.9 essentially makes the typing module
> deprecated
The 'host_device' and 'host_cdrom' drivers must be used instead.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/file-posix.c | 17 ++---
docs/system/deprecated.rst | 7 ---
docs/system/removed-features.rst | 7 +++
The same data is available in the 'BlockDeviceInfo' struct.
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Daniel P. Berrangé
---
block/qapi.c| 5 -
docs/system/deprecated.rst | 13 -
The same information is available via the 'recording' and 'busy' fields.
Reviewed-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Daniel P. Berrangé
---
block/dirty-bitmap.c | 38
docs/system/deprecated.rst | 7 -
docs/system/removed-features.rst | 7 +
This has been hardcoded to "false" since 2.10.0, since secrets required
to unlock block devices are now always provided up front instead of using
interactive prompts.
Reviewed-by: Eric Blake
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
block/qapi.c | 1 -
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 9 -
docs/system/removed-features.rst | 6
hw/i386/pc.c | 1 -
hw/scsi/scsi-disk.c |
The 'ide-hd' and 'ide-cd' devices provide suitable alternatives.
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/qdev-device-use.txt | 2 +-
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 8 +++
hw/i386/pc.c
This only makes sense conceptually when used with listener chardevs.
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
chardev/char-socket.c| 12
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
3 files
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 6 +
hw/core/machine-qmp-cmds.c | 41
qapi/machine.json| 22 -
4 files
The newer 'query-cpus-fast' command avoids side effects on the guest
execution. Note that some of the field names are different in the
'query-cpus-fast' command.
Reviewed-by: Wainer dos Santos Moschetta
Tested-by: Wainer dos Santos Moschetta
Signed-off-by: Daniel P. Berrangé
---
The generic 'migrate_set_parameters' command handle all types of param.
Only the QMP commands were documented in the deprecations page, but the
rationale for deprecating applies equally to HMP, and the replacements
exist. Furthermore the HMP commands are just shims to the QMP commands,
so
This is only semantically useful for QMP.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 7 ---
docs/system/removed-features.rst | 6 ++
monitor/monitor.c| 4 ++--
qemu-options.hx | 5 +++--
The code comment suggests removing QAPIEvent_(str|lookup) symbols too,
however, these are both auto-generated as standard for any enum in
QAPI. As such it they'll exist whether we use them or not.
Reviewed-by: Eric Blake
Reviewed-by: Thomas Huth
Signed-off-by: Daniel P. Berrangé
---
The VNC ACL concept has been replaced by the pluggable "authz" framework
which does not use monitor commands.
Reviewed-by: Thomas Huth
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 16 ---
docs/system/removed-features.rst | 12
The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0:
Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316'
into staging (2021-03-17 21:02:37 +)
are available in the Git repository at:
https://gitlab.com/berrange/qemu
Signed-off-by: Hao Wang
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index bd40373a80..df35044ef0 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -13,6 +13,17 @@ v7.2.0 (unreleased)
* **New features**
+ * qemu: Implement domain memory dirty rate
Sure. I'll post NEWS.rst information soon, and really appreciate your help!
Best Regards,
Hao
On 2021/3/18 15:49, Michal Privoznik wrote:
> On 3/16/21 1:32 PM, Hao Wang wrote:
>> Hao Wang (7):
>> migration/dirtyrate: Introduce virDomainStartDirtyRateCalc API
>> migration/dirtyrate:
...
> Another thing I'm not a fan of is having the message start at column
> zero instead of being aligned along with the rest of the code...
> textwrap.dedent() could help here, although it'd be a little annoying
> to use because we want the image details to be indented and we can't
> know the
This help formatter class reports the defaults we use for options
taking an argument.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/helper | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/helper b/ci/helper
index 73a3f729da..8f34f4b59d 100755
--- a/ci/helper
+++
The corresponding Bash script is dropped.
After this patch's rewrite, the Makefile's original image listing
target remains intact only to notify the user to use the Python helper
instead.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/Makefile | 12
With the gradual rewrite of the Makefile to the 'helper' script will
require helper functions that would better live in a separate util
module.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/util.py | 40
1 file changed, 40
As documented at [1], the common practice wrt to private
attributes/methods naming is to prefix them with an underscore.
[1] https://docs.python.org/3/tutorial/classes.html#private-variables
Signed-off-by: Erik Skultety
---
ci/helper | 68 +++
since v2:
- dropped original patch 1 renaming ci-help to help in Makefile
- changed the --quiet cmdline option to be tied to the refresh cmd only
- urrlib imports fixed
- improved on Python type hinting
- improved util functions docstrings
- replaced all tabs in formatted
Offer an option to silence all output to stdout, e.g. when generating
dockerfiles/varsfiles.
Signed-off-by: Erik Skultety
Reviewed-by: Andrea Bolognani
---
ci/helper | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ci/helper b/ci/helper
index
This function checks whether there are any stale Docker images in the
registry that can be purged. Since we're pulling available container
images from our GitLab registry with the 'list-images' action, it
could happen that we'd list old (already unsupported) images and make
them available for the
Signed-off-by: Tim Wiederhake
---
src/conf/network_conf.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 4cf4aa4840..93972a544a 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@
Signed-off-by: Tim Wiederhake
---
src/conf/storage_adapter_conf.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c
index 77ecb8d5f2..96e6c733d0 100644
--- a/src/conf/storage_adapter_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/storage_conf.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 2e07c81f8a..7dc528b103 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0c4f7ab879..a1aefdf0bf 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14413,17
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 138 ++---
1 file changed, 48 insertions(+), 90 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 39f171ba74..4f020714bc 100644
--- a/src/conf/domain_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fe35a3960e..0c4f7ab879 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 64b93fd7d1..d16a44c955 100644
--- a/src/conf/numa_conf.c
+++ b/src/conf/numa_conf.c
@@ -1079,17 +1079,8 @@
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 55920e7a7d..e3e38ae30d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8428,7
Signed-off-by: Tim Wiederhake
---
src/conf/device_conf.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
index 714ac50762..ee248648bd 100644
--- a/src/conf/device_conf.c
+++ b/src/conf/device_conf.c
@@ -214,7 +214,7
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6559c3d2f8..fe35a3960e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14025,23
Signed-off-by: Tim Wiederhake
---
src/conf/backup_conf.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c
index 8560f3bf2e..3a1863d2c3 100644
--- a/src/conf/backup_conf.c
+++ b/src/conf/backup_conf.c
@@ -234,8
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a1aefdf0bf..c020bf9124 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -15496,7
1 - 100 of 129 matches
Mail list logo
