On Mon, 29 Mar 2021 15:46:53 +0100
"Dr. David Alan Gilbert" wrote:
> * Igor Mammedov (imamm...@redhat.com) wrote:
> > On Tue, 23 Mar 2021 17:40:36 +
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > > > Let me hijack this thread
On 3/29/21 6:52 AM, Ján Tomko wrote:
> On a Friday in 2021, Cole Robinson wrote:
>> Currently libvirt rejects attempts to use virtiofs with
>> qemu:///session. Indeed virtiofs does not have a chance of working
>> with typical session usage, because virtiofsd needs multiple linux
>> capabilities to
On Mon, Mar 29, 2021 at 08:20:32PM +0200, Pavel Hrdina wrote:
> On Mon, Mar 29, 2021 at 07:03:52PM +0100, Daniel P. Berrangé wrote:
> > The
> >
> >
> >
> >
> >
> >
> >
> > repeats the firmware attribute twice. This has no functional benefit, as
> > evidenced by fact that
On Mon, Mar 29, 2021 at 07:03:52PM +0100, Daniel P. Berrangé wrote:
> The
>
>
>
>
>
>
>
> repeats the firmware attribute twice. This has no functional benefit, as
> evidenced by fact that we use a single struct field to store both
> attributes, while needlessly introducing
The
repeats the firmware attribute twice. This has no functional benefit, as
evidenced by fact that we use a single struct field to store both
attributes, while needlessly introducing an error scenario. The XML can
just be simplified to:
which also
On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote:
> When the firmware auto-selection was introduced it always picked first
> usable firmware based on the JSON descriptions on the host. It is
> possible to add/remove/change the JSON files but it will always be for
> the whole host.
>
>
On Fri, Mar 26, 2021 at 11:48:06AM -0500, Jonathon Jongsma wrote:
> Since a mediated device can be persistently defined by the mdevctl
> backend, we need additional lifecycle events beyond CREATED/DELETED to
> indicate that e.g. the device has been stopped but the device definition
> still exists.
On Fri, Mar 26, 2021 at 11:48:05AM -0500, Jonathon Jongsma wrote:
> Consistent with other objects (e.g. virDomainObj), add a field to
> indicate whether the node device is persistent or transient.
>
> Signed-off-by: Jonathon Jongsma
> ---
Reviewed-by: Erik Skultety
On Fri, Mar 26, 2021 at 11:48:04AM -0500, Jonathon Jongsma wrote:
> This adds an internal API to query for persistent mediated devices
> that are defined by mdevctl. Upcoming commits will make use of this
> information.
>
> Signed-off-by: Jonathon Jongsma
> ---
>
On Mon, Mar 29, 2021 at 14:49:36 +0200, Michal Privoznik wrote:
> This API talks to QEMU and changes its internal state. Therefore,
> it should acquire QEMU_JOB_MODIFY instead of QEMU_JOB_QUERY.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1
On Fri, Mar 26, 2021 at 11:48:03AM -0500, Jonathon Jongsma wrote:
> This function will parse the list of mediated devices that are returned
> by mdevctl and convert it into our internal node device representation.
>
> Signed-off-by: Jonathon Jongsma
> ---
...
> @@ -265,13 +312,13 @@
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Tue, 23 Mar 2021 17:40:36 +
> Daniel P. Berrangé wrote:
>
> > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > > Let me hijack this thread for beyond this case scope.
> > >
> > > I agree that for this particular bug we've
On Fri, Mar 26, 2021 at 11:48:02AM -0500, Jonathon Jongsma wrote:
> Expose a helper function that can be used by udev and mdevctl to
> generate device names for node devices.
>
> Signed-off-by: Jonathon Jongsma
> Reviewed-by: Erik Skultety
> ---
> src/node_device/node_device_driver.c | 25
On Fri, Mar 26, 2021 at 11:48:01AM -0500, Jonathon Jongsma wrote:
> It doesn't make sense to list all of the flag values in the function
> documentation. This is unnecessary duplication, we already refer to the
> enum type. Also, remove reference to exclusive groups of flags, since
> that does
On Fri, Mar 26, 2021 at 11:48:00AM -0500, Jonathon Jongsma wrote:
> Add two flag values for virConnectListAllNodeDevices() so that we can
> list only node devices that are active or inactive.
>
> Signed-off-by: Jonathon Jongsma
> Reviewed-by: Erik Skultety
> ---
>
On Fri, Mar 26, 2021 at 11:47:57AM -0500, Jonathon Jongsma wrote:
> When an mdevctl command fails, there is not much information available
> to the user about why it failed. This is partly because we were not
> making use of the error message that mdevctl itself prints upon failure.
>
>
On 3/29/21 12:52 PM, Ján Tomko wrote:
On a Friday in 2021, Cole Robinson wrote:
Currently libvirt rejects attempts to use virtiofs with
qemu:///session. Indeed virtiofs does not have a chance of working
with typical session usage, because virtiofsd needs multiple linux
capabilities to perform
This API talks to QEMU and changes its internal state. Therefore,
it should acquire QEMU_JOB_MODIFY instead of QEMU_JOB_QUERY.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
On 3/29/21 12:59 PM, Ján Tomko wrote:
On a Monday in 2021, Daniel P. Berrangé wrote:
This API interacts with the hypervisor and makes changes to its
behaviour, so must be protected by the write permission.
Should qemuDomainStartDirtyRateCalc then take a different job than
QEMU_JOB_QUERY?
---
src/storage/storage_backend_sheepdog.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/storage/storage_backend_sheepdog.c
b/src/storage/storage_backend_sheepdog.c
index 8c37947308..010e86aa14 100644
--- a/src/storage/storage_backend_sheepdog.c
+++
On a Monday in 2021, Daniel P. Berrangé wrote:
This API interacts with the hypervisor and makes changes to its
behaviour, so must be protected by the write permission.
Should qemuDomainStartDirtyRateCalc then take a different job than
QEMU_JOB_QUERY?
Signed-off-by: Daniel P. Berrangé
---
On a Friday in 2021, Cole Robinson wrote:
Currently libvirt rejects attempts to use virtiofs with
qemu:///session. Indeed virtiofs does not have a chance of working
with typical session usage, because virtiofsd needs multiple linux
capabilities to perform its job. The only way to do this with
This API interacts with the hypervisor and makes changes to its
behaviour, so must be protected by the write permission.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_protocol.x | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_protocol.x
On Thu, Mar 25, 2021 at 05:54:07PM -0600, Jim Fehlig wrote:
> On 3/22/21 4:28 AM, Daniel P. Berrangé wrote:
> > On Thu, Mar 18, 2021 at 09:51:18PM -0600, Jim Fehlig wrote:
> > > On 3/18/21 5:00 PM, Olaf Hering wrote:
> > > > Am Thu, 18 Mar 2021 16:26:14 -0600
> > > > schrieb Jim Fehlig :
> > > >
On 3/27/21 3:54 AM, peili wrote:
---
src/storage/storage_backend_sheepdog.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/storage/storage_backend_sheepdog.c
b/src/storage/storage_backend_sheepdog.c
index 8c37947308..010e86aa14 100644
---
On Fri, 2021-03-26 at 18:55 +0100, Pavel Hrdina wrote:
> On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote:
> > Even though you didn't spell that out explicitly, I assume you're
> > okay with me pushing this series during the freeze?
>
> I know it's trivial and most likely will not
On Sat, Mar 27, 2021 at 10:54:39 +0800, peili wrote:
> ---
> src/storage/storage_backend_sheepdog.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/storage/storage_backend_sheepdog.c
> b/src/storage/storage_backend_sheepdog.c
> index 8c37947308..010e86aa14 100644
> ---
27 matches
Mail list logo
