Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 12:47:59PM +0200, Pavel Hrdina wrote: > Upstream sheepdog project doesn't have any active development for almost > 3 years as the last commit is from 28/06/2018 [1]. > > Looking into repology [2] the latest version 1.0.1 is included only in > Fedora (since Fedora 26).

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 12:47:59 +0200, Pavel Hrdina wrote: > Upstream sheepdog project doesn't have any active development for almost > 3 years as the last commit is from 28/06/2018 [1]. > > Looking into repology [2] the latest version 1.0.1 is included only in > Fedora (since Fedora 26). There

[libvirt PATCH 2/2] remove sheepdog support from libvirt

Upstream sheepdog project doesn't have any active development for almost 3 years as the last commit is from 28/06/2018 [1]. Looking into repology [2] the latest version 1.0.1 is included only in Fedora (since Fedora 26). There are only few other distributions having older sheepdog versions:

[libvirt PATCH 1/2] tests: use RBD instead of sheepdog

We will drop support for sheepdog in libvirt so we should not use it in tests. Signed-off-by: Pavel Hrdina --- tests/qemuxml2argvdata/boot-dev+order.xml | 2 +- tests/qemuxml2argvdata/boot-order.args| 2 +- tests/qemuxml2argvdata/boot-order.xml | 2 +-

[libvirt PATCH 0/2] remove sheepdog support

This patch series depends on [1] otherwise you will have conflicts when applying the second patch. [1] Pavel Hrdina (2): tests: use RBD instead of sheepdog remove sheepdog support from libvirt docs/formatdomain.rst

Re: [libvirt PATCH] qemu_block: fix copy typo in SSH protocol

On a Monday in 2021, Pavel Hrdina wrote: Fixes: caf71b64fe6989116316b966fda119cd3e47f485 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH] qemu_block: fix copy typo in SSH protocol

Fixes: caf71b64fe6989116316b966fda119cd3e47f485 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 6845e25176..a972e1e368 100644 --- a/src/qemu/qemu_block.c +++

Re: [libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

On Thu, Apr 15, 2021 at 02:52:28PM +0200, Andrea Bolognani wrote: > The former is ridiculously tiny and doesn't have any use on > its own, so it hardly warrants the overhead of an additional > package; the latter is also very small and, just like virsh, > is something that you likely want to have

Re: [libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

On 4/15/21 2:52 PM, Andrea Bolognani wrote: The former is ridiculously tiny and doesn't have any use on its own, so it hardly warrants the overhead of an additional package; The idea was, that if you'd install virt-admin only, you would have bash completion too, hence a separate package.

Re: [libvirt PATCH 0/2] introduce 'restrictive' mode in numatune

On 4/16/21 2:42 PM, Martin Kletzander wrote: Resent patches with some fixes v5: https://listman.redhat.com/archives/libvir-list/2021-April/msg00450.html Luyao Zhong (2): conf, docs, schema: Add support for 'restrictive' mode in numatune qemu: Add support for 'restrictive' mode in

Re: [PATCH] lxc: Format --handshakefd for controller cmd fully

On 4/19/21 11:01 AM, Peter Krempa wrote: On Mon, Apr 19, 2021 at 09:34:16 +0200, Michal Privoznik wrote: The command line argument is called --hanshakefd (check out lxc_controller.c:main()). But the command line builder puts only --handshake. This works, because there is no other argument

Re: [PATCH 00/25] conf: domain: Refactor virDomainDiskDefParseXML

On 4/16/21 5:34 PM, Peter Krempa wrote: Split out all default setting and validation code into appropriate functions and convert the XML parser to contemporary helpers. Peter Krempa (25): virXMLParseHelper: Add root XML node name validation capability util: xml: Introduce

Re: [PATCH] lxc: Format --handshakefd for controller cmd fully

On Mon, Apr 19, 2021 at 09:34:16 +0200, Michal Privoznik wrote: > The command line argument is called --hanshakefd (check out > lxc_controller.c:main()). But the command line builder puts only > --handshake. This works, because there is no other argument > sharing the prefix. That is an extremely

Re: [PATCH] lxc: Format --handshakefd for controller cmd fully

On Mon, Apr 19, 2021 at 09:34:16AM +0200, Michal Privoznik wrote: > The command line argument is called --hanshakefd (check out > lxc_controller.c:main()). But the command line builder puts only > --handshake. This works, because there is no other argument > sharing the prefix. > > Signed-off-by:

Re: [PATCH 0/3] vircgroup: Fix virCgroupKillRecursive() wrt nested controllers

On Mon, Apr 19, 2021 at 09:20:15AM +0200, Michal Privoznik wrote: > See 3/3 for explanation. > > Michal Prívozník (3): > vircgroup: Debug print all arguments of > virCgroupKillRecursiveInternal() > vircgroupbackend: Extend error messages in VIR_CGROUP_BACKEND_CALL() > vircgroup: Fix

Re: [PATCH] cmdDomBlkError: Fix crash when initial call to virDomainGetDiskErrors fails

On Mon, Apr 19, 2021 at 08:25:00AM +0200, Peter Krempa wrote: > virDomainGetDiskErrors uses the weird semantics where we make the > caller query for the number of elements and then pass pre-allocated > structure. > > The cleanup section errorneously used the 'count' variable to free the >

Plans for the next release

We are getting close to the next release of libvirt. To aim for the release on May 03 I suggest entering the freeze on Tuesday Apr 27 and tagging RC2 on Thursday Apr 29 in the afternoon. I hope this works for everyone. Jirka

[PATCH] lxc: Format --handshakefd for controller cmd fully

The command line argument is called --hanshakefd (check out lxc_controller.c:main()). But the command line builder puts only --handshake. This works, because there is no other argument sharing the prefix. Signed-off-by: Michal Privoznik --- src/lxc/lxc_process.c | 2 +- 1 file changed, 1

[PATCH 3/3] vircgroup: Fix virCgroupKillRecursive() wrt nested controllers

I've encountered the following bug, but only on Gentoo with systemd and CGroupsV2. I've started an LXC container successfully but destroying it reported the following error: error: Failed to destroy domain 'amd64' error: internal error: failed to get cgroup backend for 'pathOfController'

[PATCH 2/3] vircgroupbackend: Extend error messages in VIR_CGROUP_BACKEND_CALL()

The VIR_CGROUP_BACKEND_CALL() macro gets a backend for controller and calls corresponding callback in it. If either is NULL then an error message is printed out. However, the error message contains only the intended callback func and not controller or backend found. Signed-off-by: Michal

[PATCH 1/3] vircgroup: Debug print all arguments of virCgroupKillRecursiveInternal()

Currently, only a subset of virCgroupKillRecursiveInternal() arguments is printed into debug logs. Print all of them. Signed-off-by: Michal Privoznik --- src/util/vircgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c

[PATCH 0/3] vircgroup: Fix virCgroupKillRecursive() wrt nested controllers

See 3/3 for explanation. Michal Prívozník (3): vircgroup: Debug print all arguments of virCgroupKillRecursiveInternal() vircgroupbackend: Extend error messages in VIR_CGROUP_BACKEND_CALL() vircgroup: Fix virCgroupKillRecursive() wrt nested controllers src/util/vircgroup.c| 29

[PATCH] cmdDomBlkError: Fix crash when initial call to virDomainGetDiskErrors fails

virDomainGetDiskErrors uses the weird semantics where we make the caller query for the number of elements and then pass pre-allocated structure. The cleanup section errorneously used the 'count' variable to free the allocated elements for the API but 'count' can be '-1' in cases when the API

<    1   2