On Tue, Apr 20, 2021 at 1:13 PM Andrea Bolognani wrote:
>
> Changes from [v3]:
>
> * generate per-command bash completion scripts using Meson instead
> of tweaking the contents after the fact for RPM build;
>
> * update documentation as files are moved around and packages are
>
It's useful to have virt-admin around when debugging issues
with libvirtd, and since it's a tiny binary we can simply
include it in the -daemon package to ensure it's always going
to be available when needed.
Signed-off-by: Andrea Bolognani
---
docs/kbase/rpm-deployment.rst | 12 +---
It's now empty, so no point in keeping it around.
Signed-off-by: Andrea Bolognani
---
docs/kbase/rpm-deployment.rst | 6 --
libvirt.spec.in | 14 --
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/docs/kbase/rpm-deployment.rst
The -client package's purpose is enabling remote machines to
connect to a virtualization host, but the virt-host-validate
and libvirt-guests tools are designed to be run directly on
the virtualization host and as such are a better fit for the
-daemon package.
With this change, installing and
The current setup uses a single script that is symlinked twice
and that tries to configure bash completion for both virsh and
virt-admin, even if only one of them is installed. This also
forces us to have a -bash-completion RPM package that only
contains the tiny shared file.
Rework bash
It doesn't only contain the libvirtd binary.
Signed-off-by: Andrea Bolognani
---
docs/kbase/rpm-deployment.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst
index c580c52e79..2563142a50 100644
---
Any application that uses the libraries can take advantage of
the systemtap probes, so they should be shipped in the -libs
package rather than in -client.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Changes from [v3]:
* generate per-command bash completion scripts using Meson instead
of tweaking the contents after the fact for RPM build;
* update documentation as files are moved around and packages are
dropped.
Changes from [v2]:
* move virt-admin to -daemon rather than
Signed-off-by: Andrea Bolognani
---
docs/kbase/rpm-deployment.rst | 35 +--
1 file changed, 1 insertion(+), 34 deletions(-)
diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst
index 568cf5b3eb..c580c52e79 100644
---
On Tue, 2021-04-20 at 16:10 +0200, Michal Privoznik wrote:
> On 4/20/21 2:30 PM, Andrea Bolognani wrote:
> > %{_unitdir}/virtlockd.service
> > %{_unitdir}/virtlockd.socket
> > %{_unitdir}/virtlockd-admin.socket
> > +%{_unitdir}/libvirt-guests.service
> > %config(noreplace)
On Tue, 2021-04-20 at 15:18 +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 20, 2021 at 02:30:33PM +0200, Andrea Bolognani wrote:
> > +# Turning these symlinks into regular files allows us to make the
> > +# -client and -daemon packages, both of which need bash-completion
> > +# support, completely
On Tue, 2021-04-20 at 16:10 +0200, Michal Privoznik wrote:
> On 4/20/21 2:30 PM, Andrea Bolognani wrote:
> > It's useful to have virt-admin around when debugging issues
> > with libvirtd, and since it's a tiny binary we can simply
> > include it in the -daemon package to ensure it's always going
>
Coverity complained that the 'default' case of the switch in
nodeDeviceGetMdevctlCommand() was falling through without initializing
'cmd'. Return NULL in this case even though it should never happen.
Also, make sure calling functions handle the NULL return consistently.
Some callers already
When returning early due to errors, cmd will be leaked. Use an autoptr
to handle these early returns without leaking memory.
Signed-off-by: Jonathon Jongsma
---
src/node_device/node_device_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, Apr 20, 2021 at 02:30:33PM +0200, Andrea Bolognani wrote:
> The completion script is so tiny that it makes more sense to
> potentially have two copies of it on disk than for it to have
> its own package.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 28
Currently, there is only a single pipe passed to lxc_controller
and it is used by lxc_controller to signal to the LXC driver that
the container is set up and ready to run. However, in the next
commit we will need to signal that the LXC driver has done its
part of startup process and thus the
This is the bug I'm facing. I deliberately configured a container
so that the source of a to passthrough doesn't
exist. The start fails with:
lxcContainerPivotRoot:669 : Failed to create /non-existent/path/.oldroot:
Permission denied
which is expected. But what is NOT expected is that CGroup
Future commits will want to reuse the handshakeFd and thus it
mustn't be closed in virLXCControllerDaemonHandshake(). Do the
closing explicitly afterwards.
Signed-off-by: Michal Privoznik
---
src/lxc/lxc_controller.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
The lxc_controller has a structure that's keeping its internal
state, including so called handshakeFd which is the write end of
a pipe that's used to signal to the LXC driver that the container
is set up and ready to run. However, the struct member is not
initialized to -1, so if anything fails
See 4/4 for explanation.
Michal Prívozník (4):
lxc_controller: Initialize ctrl->handshakeFd properly
lxc_controller: Move closing of handshakeFd out of
virLXCControllerDaemonHandshake()
lxc: Pass another pipe to lxc_controller
lxc: Let the driver detect CGroups earlier
On 4/20/21 2:30 PM, Andrea Bolognani wrote:
The completion script is so tiny that it makes more sense to
potentially have two copies of it on disk than for it to have
its own package.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 28 +++-
1 file changed, 15
On 4/20/21 2:30 PM, Andrea Bolognani wrote:
It's useful to have virt-admin around when debugging issues
with libvirtd, and since it's a tiny binary we can simply
include it in the -daemon package to ensure it's always going
to be available when needed.
if it's useful then what's stopping mgmt
On 4/20/21 2:30 PM, Andrea Bolognani wrote:
The -client package's purpose is enabling remote machines to
connect to a virtualization host, but the virt-host-validate
and libvirt-guests tools are designed to be run directly on
the virtualization host and as such are a better fit for the
-daemon
On 4/20/21 2:30 PM, Andrea Bolognani wrote:
Upgrading to packages built with these patches applied results in
$ sudo dnf update ./*.rpm
Dependencies resolved.
===
Package
On Tue, Apr 20, 2021 at 03:36:55PM +0200, Andrea Bolognani wrote:
> On Tue, 2021-04-20 at 15:20 +0200, Pavel Hrdina wrote:
> > On Tue, Apr 20, 2021 at 02:14:59PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Apr 20, 2021 at 03:05:26PM +0200, Andrea Bolognani wrote:
> > > > The only concern I
On Mon, Apr 19, 2021 at 07:14:16PM +0200, Pavel Hrdina wrote:
> Future patch will remove MKFS define as we will no longer check it
> during compilation.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/storage/storage_backend_fs.c | 24 +---
> 1 file changed, 9 insertions(+), 15
On Mon, Apr 19, 2021 at 07:14:11PM +0200, Pavel Hrdina wrote:
> Instead of checking for specific error that the binaries are not
> available mock the virFindFileInPath function. This way we don't have
> to skip these tests on host where the binaries are missing.
>
> Signed-off-by: Pavel Hrdina
>
On Mon, Apr 19, 2021 at 07:14:10PM +0200, Pavel Hrdina wrote:
> This will allow us to run tests using firewall on hosts where the mocked
> binaries are not available/installed instead of skipping these tests.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/virfile.h | 3 ++-
>
On Mon, Apr 19, 2021 at 07:14:09PM +0200, Pavel Hrdina wrote:
> Following patches will make this change necessary as we will stop
> detecting the full path during compile time.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/virfirewall.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
On Tue, 2021-04-20 at 15:20 +0200, Pavel Hrdina wrote:
> On Tue, Apr 20, 2021 at 02:14:59PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Apr 20, 2021 at 03:05:26PM +0200, Andrea Bolognani wrote:
> > > The only concern I have, which is one I have expressed already in the
> > > past, is that it will
Our vsh bash completion string is merely just a wrapper over
virsh/virt-admin complete (cmdComplete) - a hidden command that
uses internal readline completion to generate list of candidates.
But this means that we have to pass some additional arguments to
the helper process: e.g. connection URI
On Tue, Apr 20, 2021 at 02:14:59PM +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 20, 2021 at 03:05:26PM +0200, Andrea Bolognani wrote:
> > On Mon, 2021-04-19 at 19:14 +0200, Pavel Hrdina wrote:
> > > Recent attempt to add a lot of meson options to specify different
> > > runtime paths motivated
On Tue, Apr 20, 2021 at 03:05:26PM +0200, Andrea Bolognani wrote:
> On Mon, 2021-04-19 at 19:14 +0200, Pavel Hrdina wrote:
> > Recent attempt to add a lot of meson options to specify different
> > runtime paths motivated me enough to cleanup this from meson.
> >
> > Changes in v2:
> > - split
On Mon, 2021-04-19 at 19:14 +0200, Pavel Hrdina wrote:
> Recent attempt to add a lot of meson options to specify different
> runtime paths motivated me enough to cleanup this from meson.
>
> Changes in v2:
> - split and rework patch 16/17 to address review comments
> - added a new patch
Any application that uses the libraries can take advantage of
the systemtap probes, so they should be shipped in the -libs
package rather than in -client.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The completion script is so tiny that it makes more sense to
potentially have two copies of it on disk than for it to have
its own package.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git
Upgrading to packages built with these patches applied results in
$ sudo dnf update ./*.rpm
Dependencies resolved.
===
Package Version
The -client package's purpose is enabling remote machines to
connect to a virtualization host, but the virt-host-validate
and libvirt-guests tools are designed to be run directly on
the virtualization host and as such are a better fit for the
-daemon package.
Signed-off-by: Andrea Bolognani
---
It's useful to have virt-admin around when debugging issues
with libvirtd, and since it's a tiny binary we can simply
include it in the -daemon package to ensure it's always going
to be available when needed.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 24 +++-
1
On Tue, Apr 20, 2021 at 2:45 PM Peter Krempa wrote:
>
> In certain rare occasions qemu can transition a block job which was
> already 'ready' into 'standby' and then back. If this happens in the
> following order libvirt will get confused about the actual job state:
>
> 1) the block copy job is
In certain rare occasions qemu can transition a block job which was
already 'ready' into 'standby' and then back. If this happens in the
following order libvirt will get confused about the actual job state:
1) the block copy job is 'ready' (job->state == QEMU_BLOCKJOB_STATE_READY)
2) user calls
On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
From: Erik Skultety
Currently there are dedicated wrappers to construct mdevctl command.
These are mostly fine except for the one that translates both "start"
and "define" commands, only because mdevctl takes the same set of
arguments. Instead,
Patch #1 is a resend of
https://listman.redhat.com/archives/libvir-list/2021-April/msg00600.html
Patch #2 is a fix for a mistake in
https://listman.redhat.com/archives/libvir-list/2021-April/msg00782.html
Patches #3 and #4 are the replacement for
Fixes: 4eb7c621985dad4de911ec394ac628bd1a5b29ab
Signed-off-by: Tim Wiederhake
---
src/libxl/xen_common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c
index 6fa69fbdf0..aeb94e12ad 100644
--- a/src/libxl/xen_common.c
+++
Function will be used by next patch.
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_capabilities.c | 9 +
src/qemu/qemu_capspriv.h | 4
2 files changed, 13 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 030779902d..7971a9c557
testUpdateQEMUCaps is called multiple times. Use virQEMUCapsUpdateHostCPUModel
instead of virQEMUCapsInitHostCPUModel to not overwrite (and leak) the
pointers in qemuCaps->kvm.hostCPU and qemuCaps->tcg.hostCPU.
Signed-off-by: Tim Wiederhake
---
tests/qemuxml2argvtest.c | 8
1 file
xmlDocSetRootElement removes the node from its previous document tree,
effectively removing the "" node from "" in virCPUDefParseXML.
Signed-off-by: Tim Wiederhake
---
src/conf/cpu_conf.c | 3 +--
src/util/virxml.c | 13 ++---
src/util/virxml.h | 1 -
3 files changed, 7
On Tue, Apr 20, 2021 at 11:11:54AM +0100, Daniel P. Berrangé wrote:
> On Mon, Apr 19, 2021 at 07:14:13PM +0200, Pavel Hrdina wrote:
> > Having the function on mock library reflect more closely what we usually
> > do in tests.
>
> Yes & no - having it in testutilsqemu.c would make it available to
On Tue, Apr 20, 2021 at 12:50:51PM +0200, Pavel Hrdina wrote:
> On Tue, Apr 20, 2021 at 05:30:09AM -0400, Neal Gompa wrote:
> > On Mon, Apr 19, 2021 at 1:14 PM Pavel Hrdina wrote:
> > >
> > > Recent attempt to add a lot of meson options to specify different
> > > runtime paths motivated me enough
On Tue, Apr 20, 2021 at 05:30:09AM -0400, Neal Gompa wrote:
> On Mon, Apr 19, 2021 at 1:14 PM Pavel Hrdina wrote:
> >
> > Recent attempt to add a lot of meson options to specify different
> > runtime paths motivated me enough to cleanup this from meson.
> >
> > Changes in v2:
> > - split and
On Mon, Apr 19, 2021 at 07:14:15PM +0200, Pavel Hrdina wrote:
> Currently the tests would fail if the bhyve commands are installed in
> different path then /usr/bin. Strip the command path to not depend on
> the host environment.
>
> Signed-off-by: Pavel Hrdina
> ---
>
On Mon, Apr 19, 2021 at 07:14:14PM +0200, Pavel Hrdina wrote:
> Upstream sheepdog changed collie to dog back in 2013 in version 0.7.0.
> Looking into repology that version is no longer used by any distribution
> supported by libvirt.
>
> Signed-off-by: Pavel Hrdina
> ---
> meson.build | 2 +-
>
On Mon, Apr 19, 2021 at 07:14:13PM +0200, Pavel Hrdina wrote:
> Having the function on mock library reflect more closely what we usually
> do in tests.
Yes & no - having it in testutilsqemu.c would make it available to all
QEMU tests, while domaincapsmock.c only makes it available from those
On Mon, Apr 19, 2021 at 07:14:12PM +0200, Pavel Hrdina wrote:
> The function in question uses "tc" binary so virnetdevbandwidth feels
> like better place for it.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/libvirt_private.syms | 2 +-
> src/qemu/qemu_domain.c| 3 ++-
>
On Mon, Apr 19, 2021 at 07:14:08PM +0200, Pavel Hrdina wrote:
> We always pass DNSMASQ so there is no need for the argument at all.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/network/bridge_driver.c | 4 ++--
> src/util/virdnsmasq.c | 4 ++--
> src/util/virdnsmasq.h | 2 +-
> 3
On Mon, Apr 19, 2021 at 07:14:07PM +0200, Pavel Hrdina wrote:
> We always pass DNSMASQ so there is no need for the argument at all.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/virdnsmasq.c | 4 ++--
> src/util/virdnsmasq.h | 3 +--
> tests/networkxml2conftest.c | 6 +++---
> 3
On Mon, Apr 19, 2021 at 07:14:04PM +0200, Pavel Hrdina wrote:
> We will never call dnsmasqCapsRefresh() so reflect what actually
> happens.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/network/bridge_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P.
On Mon, Apr 19, 2021 at 07:14:06PM +0200, Pavel Hrdina wrote:
> Instead of removing binaryPath let's drop the function completely as
> it is not used anywhere.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/libvirt_private.syms | 1 -
> src/util/virdnsmasq.c| 17 -
>
On Mon, Apr 19, 2021 at 07:14:05PM +0200, Pavel Hrdina wrote:
> Instead of removing binaryPath let's drop the function completely as
> it is not used anywhere.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/libvirt_private.syms | 1 -
> src/util/virdnsmasq.c| 30 --
On Mon, Apr 19, 2021 at 1:14 PM Pavel Hrdina wrote:
>
> Recent attempt to add a lot of meson options to specify different
> runtime paths motivated me enough to cleanup this from meson.
>
> Changes in v2:
> - split and rework patch 16/17 to address review comments
> - added a new patch to
60 matches
Mail list logo
