[libvirt] [PATCH 1/2] virsh: Add mountpoint completion to domfsfreeze/domfsthaw command

Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 43 ++ tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 2 ++ 3 files changed, 49 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c

[libvirt] [PATCH 2/2] virsh: Fix completion logic to guestvcpus command

In case of non-continuous vCPU topology, We can't infer the bitmap size from the combination of onlineVcpuStr and nvcpus. We should use virBitmapParseUnlimited here instead of virBitmapParse due to the bitmap size is unknown. e.g.: # virsh

[libvirt] [PATCH 0/2] virsh completer fixes

Lin Ma (2): virsh: Add mountpoint completion to domfsfreeze/domfsthaw command virsh: Fix completion logic to guestvcpus command tools/virsh-completer-domain.c | 104 +++-- tools/virsh-completer-domain.h | 4 ++ tools/virsh-domain.c | 2 + 3 files

Re: [PATCH] rpc: libssh2: Enable EC host keys

On 3/28/21 11:49 PM, Neal Gompa wrote: On Sun, Mar 28, 2021 at 5:10 PM Bastian Germann wrote: libssh2 has ECDSA and ED25519 support beginning with v1.9.0. libvirt cannot make use of those because it will handle them as unknown key types. Add support for those host key types. Signed-off-by:

Re: [libvirt PATCH 2/3] docs: virtiofs: add section about externally-launched virtiofsd

On Thu, 22 Apr 2021 13:40:53 +0200 Ján Tomko wrote: > Provide an exmple in a place more visible than formatdomain.html. > > Signed-off-by: Ján Tomko > --- > docs/kbase/virtiofs.rst | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/docs/kbase/virtiofs.rst

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

On 4/22/21 12:32 PM, Tim Wiederhake wrote: For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainDiskDef: Change type of cachemode to virDomainDiskCache virDomainDiskDef: Change type of error_policy to

Re: [libvirt PATCH] vahDeinit: Fix memory leak

On a Thursday in 2021, Tim Wiederhake wrote: Calling VIR_FREE on a virDomainDef* does not free its various contained pointers. Signed-off-by: Tim Wiederhake --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc

[libvirt PATCH] vahDeinit: Fix memory leak

Calling VIR_FREE on a virDomainDef* does not free its various contained pointers. Signed-off-by: Tim Wiederhake --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index

Re: [libvirt] [PATCH 1/2] virsh: Add mountpoint completion to domfsfreeze/domfsthaw command

On 4/22/21 12:38 PM, Lin Ma wrote: Signed-off-by: Lin Ma --- tools/virsh-completer-domain.c | 43 ++ tools/virsh-completer-domain.h | 4 tools/virsh-domain.c | 2 ++ 3 files changed, 49 insertions(+) diff --git

Re: [libvirt] [PATCH 0/2] virsh completer fixes

On 4/22/21 12:38 PM, Lin Ma wrote: Lin Ma (2): virsh: Add mountpoint completion to domfsfreeze/domfsthaw command virsh: Fix completion logic to guestvcpus command tools/virsh-completer-domain.c | 104 +++-- tools/virsh-completer-domain.h | 4 ++

[libvirt PATCH 3/3] NEWS: qemu: add socket for virtiofs filesystems

Signed-off-by: Ján Tomko --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f8b0ae02d..7b55dd056f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -18,6 +18,12 @@ v7.3.0 (unreleased) The xen driver now supports domains with more than 4TB of memory with

[libvirt PATCH 1/3] docs: document new socket attribute for virtiofs

Describe the attribute and add an example. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 1b9b221611..282176c4f4 100644 --- a/docs/formatdomain.rst +++

[libvirt PATCH 2/3] docs: virtiofs: add section about externally-launched virtiofsd

Provide an exmple in a place more visible than formatdomain.html. Signed-off-by: Ján Tomko --- docs/kbase/virtiofs.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index c0bc07a68d..09674a4a76 100644 ---

[libvirt PATCH 0/3] docs: qemu: add socket for virtiofs filesystems

Add documentation for the new attribute. Ján Tomko (3): docs: document new socket attribute for virtiofs docs: virtiofs: add section about externally-launched virtiofsd NEWS: qemu: add socket for virtiofs filesystems NEWS.rst| 6 ++ docs/formatdomain.rst | 10

Re: [PATCH 4/4] lxc: Let the driver detect CGroups earlier

On Tue, Apr 20, 2021 at 04:15:18PM +0200, Michal Privoznik wrote: This is the bug I'm facing. I deliberately configured a container so that the source of a to passthrough doesn't exist. The start fails with: lxcContainerPivotRoot:669 : Failed to create /non-existent/path/.oldroot: Permission

Re: [PATCH 3/4] lxc: Pass another pipe to lxc_controller

On Tue, Apr 20, 2021 at 04:15:17PM +0200, Michal Privoznik wrote: Currently, there is only a single pipe passed to lxc_controller and it is used by lxc_controller to signal to the LXC driver that the container is set up and ready to run. However, in the next commit we will need to signal that

Re: [PATCH 2/4] lxc_controller: Move closing of handshakeFd out of virLXCControllerDaemonHandshake()

On Tue, Apr 20, 2021 at 04:15:16PM +0200, Michal Privoznik wrote: Future commits will want to reuse the handshakeFd and thus it mustn't be closed in virLXCControllerDaemonHandshake(). Do the closing explicitly afterwards. Signed-off-by: Michal Privoznik --- src/lxc/lxc_controller.c | 4 +++- 1

Re: [PATCH 1/4] lxc_controller: Initialize ctrl->handshakeFd properly

On Tue, Apr 20, 2021 at 04:15:15PM +0200, Michal Privoznik wrote: The lxc_controller has a structure that's keeping its internal state, including so called handshakeFd which is the write end of a pipe that's used to signal to the LXC driver that the container is set up and ready to run. However,

[libvirt PATCH 04/10] virDomainDiskDef: Change type of iomode to virDomainDiskInfo

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b12ec61f9..72664bd72b 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 06/10] virDomainDiskDef: Change type of detect_zeroes to virDomainDiskDetectZeroes

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9a4252099e..60f961c2b9 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 08/10] domain_conf: Introduce function virDomainChrSouceModeTypeFromString

Preparatory step to remove virDomainChrSourceDefParseMode. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1bbf907596..cdc32e52dd

[libvirt PATCH 01/10] virDomainDiskDef: Change type of cachemode to virDomainDiskCache

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 720d56cf69..33c6412642 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 10/10] virDomainChrSourceDefParseTCP: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 447fc7dfcb..24c0943d62 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH 09/10] domain_conf: Remove function virDomainChrSourceDefParseMode

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 40 +--- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cdc32e52dd..447fc7dfcb 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 07/10] virDomainDiskDefDriverParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 150 +++-- 1 file changed, 39 insertions(+), 111 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 60f961c2b9..1bbf907596 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 05/10] virDomainDiskDef: Change type of discard to virDomainDiskDiscard

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 72664bd72b..9a4252099e 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IV

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainDiskDef: Change type of cachemode to virDomainDiskCache virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy virDomainDiskDef: Change type of

[libvirt PATCH 03/10] virDomainDiskDef: Change type of rerror_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- src/conf/domain_conf.h | 2 +- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4a0358831b..0b12ec61f9 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 02/10] virDomainDiskDef: Change type of error_policy to virDomainDiskErrorPolicy

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 33c6412642..4a0358831b 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part III

On 4/21/21 5:51 PM, Tim Wiederhake wrote: For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainKeyWrapCipherDefParseXML: Use virXMLProp* virDomainKeyWrapDef: Make members virTristateSwitch

Re: [PATCH] formatdomain.rst: update slice xml in "Hard drives" part

On Thu, Apr 22, 2021 at 4:50 PM “Meina wrote: > Update slice xml from block lun disk because it doesn't support storage > slice > > Signed-off-by: Meina Li > --- > docs/formatdomain.rst | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/docs/formatdomain.rst

Re: [PATCH] formatdomain.rst: update slice xml in "Hard drives" part

On Thu, Apr 22, 2021 at 4:50 PM “Meina wrote: > Update slice xml from block lun disk because it doesn't support storage > slice > > Better if mentioning the bug or the commit of forbidding slice element with lun device https://bugzilla.redhat.com/show_bug.cgi?id=1820040 5d72c3ce28 qemu: domain:

[PATCH] formatdomain.rst: update slice xml in "Hard drives" part

Update slice xml from block lun disk because it doesn't support storage slice Signed-off-by: Meina Li --- docs/formatdomain.rst | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 1b9b221611..44aee9fa77 100644 ---

Re: [PATCH] bash-completion: Fix argument passing to $1

On Tue, Apr 20, 2021 at 03:34:53PM +0200, Michal Privoznik wrote: > Our vsh bash completion string is merely just a wrapper over > virsh/virt-admin complete (cmdComplete) - a hidden command that > uses internal readline completion to generate list of candidates. > But this means that we have to

[RFCv3 14/25] conf: Extract error-checking code from virNetworkDNSSrvDefParseXML

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 107 +++- 1 file changed, 83 insertions(+), 24 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index bb976a78..20128af0 100644 --- a/src/conf/network_conf.c +++

[RFCv3 15/25] conf: Replace virNetworkDNSSrvDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 83 +++-- src/conf/network_conf.h | 17 + 2 files changed, 15 insertions(+), 85 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 20128af0..cb2f3163 100644 ---

[RFCv3 17/25] conf: Extract error-checking code from virNetworkDNSHostDefParseXML

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 63 + 1 file changed, 45 insertions(+), 18 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 146c4977..b326ef5f 100644 --- a/src/conf/network_conf.c +++

[RFCv3 11/25] conf: Extract error-checking code from virNetworkDNSTxtDefParseXML

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 49 - 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index d6eafa3f..87157591 100644 --- a/src/conf/network_conf.c +++

[RFCv3 07/25] util: Add some xml-helper-functions to cooperate with xmlgen

1) virXMLChildNode and virXMLChildNodeSet Parse xml based on 'node' rather than 'ctxt'. 2) virXMLChildPropString Support to parse child node's property value by path, which is as "child_node_name/prop_name". 3) virXMLChildNodeContent Support to parse child

[RFCv3 21/25] conf: Replace virNetworkDNSForwarderParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 36 +--- src/conf/network_conf.h | 7 --- 2 files changed, 5 insertions(+), 38 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index cf9e77d3..ef28bb4d 100644 ---

[RFCv3 00/25] RFC: Generate parsexml/formatbuf functions based on directives

V2 here: [https://listman.redhat.com/archives/libvir-list/2020-September/msg00204.html] Differ from V2: * Add tests for xmlgen to illustrate all the different features we can use and make sure its proper functions in the future. * Add docs/xmlgen.rst to explain the usage of all

[RFCv3 22/25] conf: Generate virNetworkDNSForwarderFormatBuf

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 18 +++--- src/conf/network_conf.h | 4 ++-- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index ef28bb4d..be639500 100644 --- a/src/conf/network_conf.c +++

[RFCv3 10/25] util: Add virUUID type and parse/format functions

Signed-off-by: Shi Lei --- src/util/viruuid.c | 31 +++ src/util/viruuid.h | 18 ++ 2 files changed, 49 insertions(+) diff --git a/src/util/viruuid.c b/src/util/viruuid.c index 558fbb9c..c6e6272f 100644 --- a/src/util/viruuid.c +++

[RFCv3 09/25] util: Add parsexml/formatbuf helper functions for virSocketAddr

Implement the parsexml/formatbuf functions for virSocketAddr. Signed-off-by: Shi Lei --- src/libvirt_private.syms | 2 ++ src/util/virsocketaddr.c | 42 src/util/virsocketaddr.h | 23 -- 3 files changed, 65 insertions(+), 2

[RFCv3 06/25] tests: Add tests for xmlgen

Add some tests to make sure xmlgen's validity. Signed-off-by: Shi Lei --- tests/meson.build| 1 + tests/xmlgenin/conf/array.h | 17 + tests/xmlgenin/conf/empty.h | 7 + tests/xmlgenin/conf/enum-first-item.h| 12 +

[RFCv3 20/25] conf: Extract virNetworkDNSForwarderParseXML from virNetworkDNSParseXML

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 68 +++-- 1 file changed, 52 insertions(+), 16 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index ba67eab1..cf9e77d3 100644 --- a/src/conf/network_conf.c +++

[RFCv3 25/25] conf: Generate virNetworkDNSDefFormatBuf

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 73 + src/conf/network_conf.h | 2 +- 2 files changed, 2 insertions(+), 73 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 364c10e2..a652110c 100644 ---

[RFCv3 05/25] build-aux: Only check *.[ch] for sc_prohibit_useless_translation

Signed-off-by: Shi Lei --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 552d6391..614f21bc 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -735,7 +735,7 @@

[RFCv3 23/25] conf: Extract error-checking code from virNetworkDNSDefParseXML

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index be639500..19408987 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c

[RFCv3 12/25] conf: Replace virNetworkDNSTxtDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- po/POTFILES.in | 1 + src/conf/meson.build| 1 + src/conf/network_conf.c | 45 ++--- src/conf/network_conf.h | 9 ++--- 4 files changed, 14 insertions(+), 42 deletions(-) diff --git a/po/POTFILES.in

[RFCv3 16/25] conf: Generate virNetworkDNSSrvDefFormatBuf

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 18 ++ src/conf/network_conf.h | 2 +- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index cb2f3163..146c4977 100644 --- a/src/conf/network_conf.c +++

[RFCv3 03/25] maint: Call xmlgen automatically when c-head-files change

Monitor changes of header-files in src/util and src/conf. Whenever that happens, the tool xmlgen will generate parse/format functions based on these files automatically. Signed-off-by: Shi Lei --- scripts/meson.build | 8 src/conf/meson.build | 36

[RFCv3 01/25] scripts: Add a tool to generate xml parse/format functions

This tool is used to generate parsexml/formatbuf/clear functions. It is based on libclang and its python-binding. Some directives (such as genparse, xmlattr, etc.) need to be added on the declarations of structs to direct the tool. Signed-off-by: Shi Lei --- po/POTFILES.in |1 +

[RFCv3 04/25] docs: Add xmlgen.rst to explain how to use it

Signed-off-by: Shi Lei --- docs/meson.build | 1 + docs/xmlgen.rst | 684 +++ 2 files changed, 685 insertions(+) create mode 100644 docs/xmlgen.rst diff --git a/docs/meson.build b/docs/meson.build index f550629d..a8a58815 100644 ---

[RFCv3 13/25] conf: Generate virNetworkDNSTxtDefFormatBuf

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 4 ++-- src/conf/network_conf.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index a6c2f11a..bb976a78 100644 --- a/src/conf/network_conf.c +++

[RFCv3 02/25] maint: Check python3-clang and libclang

Make sure 'python3-clang' and 'libclang' have been installed and can work. Also, add 'python3-clang' into libvirt.spec.in and mingw-libvirt.spec.in. Signed-off-by: Shi Lei --- libvirt.spec.in | 1 + meson.build | 10 ++ mingw-libvirt.spec.in | 1 + 3 files changed, 12

[RFCv3 18/25] conf: Replace virNetworkDNSHostDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 71 - src/conf/network_conf.h | 7 ++-- 2 files changed, 10 insertions(+), 68 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index b326ef5f..90b1e0ee 100644 ---

[RFCv3 24/25] conf: Replace virNetworkDNSDefParseXML(hardcoded) with namesake(generated)

Reorder the members of virNetworkDNSDef according to their orders in format function. Signed-off-by: Shi Lei --- src/conf/network_conf.c | 160 +--- src/conf/network_conf.h | 19 ++--- 2 files changed, 12 insertions(+), 167 deletions(-) diff --git

[RFCv3 19/25] conf: Generate virNetworkDNSHostDefFormatBuf

Signed-off-by: Shi Lei --- src/conf/network_conf.c | 14 +++--- src/conf/network_conf.h | 2 +- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 90b1e0ee..ba67eab1 100644 --- a/src/conf/network_conf.c +++

[RFCv3 08/25] util: Add helper aliases and functions for 'bool' and 'time_t' to cooperate with xmlgen

Add three aliases virBoolYesNo, virBoolOnOff and virBoolTrueFalse for type 'bool'. The tool xmlgen depends on them to determine their ture values in XML. Also, add corresponding functions to parse them. Add virStrToTime and virTimeFormatBuf to convert 'time_t' and 'string'. Add virStrToLong_u8p