Re: [PATCH v1 4/4] libxl: set vcpu affinity during domain creation

On 5/4/21 7:10 PM, Olaf Hering wrote: Am Tue, 4 May 2021 16:34:05 -0600 schrieb Jim Fehlig : +static int +libxlDomainSetVcpuAffinities(virDomainDef *def, + libxl_ctx *ctx, + libxl_domain_build_info *b_info) We should tweak the name of

Re: [PATCH v1 4/4] libxl: set vcpu affinity during domain creation

Am Tue, 4 May 2021 16:34:05 -0600 schrieb Jim Fehlig : > > +/* Will be released by libxl_domain_config_dispose */ > > +b_info->vcpu_hard_affinity = calloc(vcpu_idx, sizeof(libxl_bitmap)); > Fails syntax-check. You'll need to use g_new0. There are other areas where libxl expects the

Re: [PATCH v2] docs: cputune is also supported by the xen driver

On 5/4/21 2:22 PM, Olaf Hering wrote: Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles a domain/cputune/vcpupin element in domU.xml. Signed-off-by: Olaf Hering --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jim

Re: [PATCH v1 4/4] libxl: set vcpu affinity during domain creation

On 5/3/21 4:56 AM, Olaf Hering wrote: Since Xen 4.5 libxl allows to set affinities during domain creation. This enables Xen to allocate the domain memory on NUMA systems close to the specified pcpus. Libvirt can now handle in domU.xml correctly. Without this change, Xen will create the domU

Re: [PATCH v1 2/4] libxl: remove obsolete check for result of xc_get_max_cpus

On 5/3/21 4:56 AM, Olaf Hering wrote: xc_get_max_cpus from Xen version 4.3 may return 0 in case xc_physinfo fails. This has been fixed in Xen 4.4. Remove the obsolete result check from libvirt. Just convert libxl error codes to plain -1. Signed-off-by: Olaf Hering ---

Re: [PATCH v1 1/4] libxl: remove obsolete VIR_LIBXL_EVENT_CONST

On 5/3/21 4:56 AM, Olaf Hering wrote: In Xen 4.2 struct libxl_event_hooks had a member which was erroneously declared const. Since libvirt requires at least Xen 4.6, remove the dead code. Signed-off-by: Olaf Hering --- src/libxl/libxl_domain.c | 2 +- src/libxl/libxl_domain.h | 14

Re: [PATCH v1 4/4] libxl: set vcpu affinity during domain creation

Am Tue, 4 May 2021 16:34:05 -0600 schrieb Jim Fehlig : > > +static int > > +libxlDomainSetVcpuAffinities(virDomainDef *def, > > + libxl_ctx *ctx, > > + libxl_domain_build_info *b_info) > > We should tweak the name of this function after

Re: [PATCH v1] docs: cputune is also supported by the xen driver

On 5/3/21 5:33 AM, Olaf Hering wrote: Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles a domain/cputune/vcpupin element in domU.xml. git describe --contains 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 v0.9.1~83 Signed-off-by: Olaf Hering --- docs/formatdomain.rst | 4

[PATCH v2] docs: cputune is also supported by the xen driver

Since commit 68c5b6fb2b5fdabce775e9f8fc761a400e16a9d3 libxl also handles a domain/cputune/vcpupin element in domU.xml. Signed-off-by: Olaf Hering --- docs/formatdomain.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[libvirt PATCH 7/9] src: add API to determine if current identity is a system identity

This is essentially a way to determine if the current identity is that of another libvirt daemon. Signed-off-by: Daniel P. Berrangé --- src/libvirt_private.syms | 1 + src/util/viridentity.c | 28 src/util/viridentity.h | 1 + 3 files changed, 30 insertions(+)

[libvirt PATCH 4/9] src: set system token for system identity

Signed-off-by: Daniel P. Berrangé --- src/util/viridentity.c | 4 1 file changed, 4 insertions(+) diff --git a/src/util/viridentity.c b/src/util/viridentity.c index 065db06e49..83044a3de1 100644 --- a/src/util/viridentity.c +++ b/src/util/viridentity.c @@ -268,6 +268,7 @@ virIdentity

[libvirt PATCH 3/9] util: generate a persistent system token

When creating the system identity set the system token. The system token is currently stored in a local path /var/run/libvirt/common/system.token Obviously with only traditional UNIX DAC in effect, this is largely security through obscurity, if the client is running at the same privilege

[libvirt PATCH 2/9] util: introduce concept of a system token into identities

We want a way to distinguish between calls from a libvirt daemon, and a regular client application when both are running as the same user account. This is not possible with the current set of attributes recorded against an identity, as there is nothing that is common to all of the modular libvirt

[libvirt PATCH 8/9] secret: rework handling of private secrets

A secret can be marked with the "private" attribute. The intent was that it is not possible for any libvirt client to be able to read the secret value, it would only be accesible from within libvirtd. eg the QEMU driver can read the value to launch a guest. With the modular daemons, the QEMU,

[libvirt PATCH 9/9] src: set identity when opening secondary drivers

The drivers can all call virGetConnectXXX to open a connection to a secondary driver. For example, when creating a encrypted storage volume, the storage driver has to open a secret driver connection, or when starting a guest, the QEMU driver has to open the network driver to lookup a virtual

[libvirt PATCH 1/9] util: add virRandomToken API

A random token is simply a string of random bytes formatted in hexidecimal. Signed-off-by: Daniel P. Berrangé --- src/libvirt_private.syms | 1 + src/util/virrandom.c | 18 ++ src/util/virrandom.h | 1 + 3 files changed, 20 insertions(+) diff --git

[libvirt PATCH 6/9] util: add method for getting the current identity with system token

The current identity object represents the identity of the application which initiated the currently executing public API operation. Normally this is the libvirt client application identity. There are times when the libvirt daemon has to make extra public API calls on behalf of the client

[libvirt PATCH 5/9] util: add API for copying identity objects

Signed-off-by: Daniel P. Berrangé --- src/libvirt_private.syms | 1 + src/util/viridentity.c | 21 + src/util/viridentity.h | 1 + 3 files changed, 23 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index c5f6c90365..90ca52c95c 100644 ---

[libvirt PATCH 0/9] make internal only secrets work with split daemons

If you define a secret with private="yes", then libvirt won't let any client query the secret value after it is set. Only other libvirt drivers inside the daemon can query it by passing a special internal only flag to the virSecretGetValue API. The remote driver/daemon refuses to let this internal

[libvirt PATCH 2/2] docs: kbase: Add a doc on merging disk image chains

This is a rewrite of: https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-including-current-active-disk Once this commit merges, the above wiki should point to this kbase document. Signed-off-by: Kashyap Chamarthy --- docs/kbase/index.rst | 3 +

[libvirt PATCH 0/2] rST-ify and rewrite a couple of block layer-related docs

I've cleaned up these two wiki articles that I wrote a while ago and turned them into rST. https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-including-current-active-disk Once this series merges,

[libvirt PATCH 1/2] docs: kbase: Add a doc on live full disk backup

This is a rewrite of: https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit Once this commit merges, the above wiki should point to this kbase document. Signed-off-by: Kashyap Chamarthy --- docs/kbase/index.rst | 3 + docs/kbase/live_full_disk_backup.rst

Re: [libvirt PATCH 10/10] virDomainRedirFilterUSBDevDefParseXML: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 66 +++--- 1 file changed, 17 insertions(+), 49 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Tue, May 04, 2021 at 03:32:55PM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 29, 2021 at 02:03:52PM -0400, Eduardo Habkost wrote: > > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > > Live migrating old guests from an old QEMU with the SCSI feature bit > > > enabled will

Re: [libvirt PATCH 09/10] virDomainShmemDef: Use g_auto*

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 08/10] conf: domain: Register autoptr cleanup function for virDomainDeviceDef

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 1 + 1 file changed, 1 insertion(+) With the commit summary fixed: Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 07/10] virDomainShmemDefParseXML: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 52 ++ 1 file changed, 12 insertions(+), 40 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 06/10] virDomainShmemDef: Change type of role to virDomainShmemRole

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

Re: [libvirt PATCH 05/10] virDomainShmemDef: Change type of model to virDomainShmemModel

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h| 2 +- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_hotplug.c | 4 ++-- src/qemu/qemu_validate.c | 5 +

Re: [libvirt PATCH 04/10] virDomainMemballoonDefParseXML: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 57 +- 1 file changed, 17 insertions(+), 40 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 03/10] virDomainMemballoonDef: Change type of model to virDomainMemballoonModel

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 +- src/libxl/libxl_conf.c | 8 +++- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_monitor.c| 2 +- 5 files changed, 9

Re: [libvirt PATCH 02/10] virDomainAudioCommonParse: Use virXMLProp*

On a Tuesday in 2021, Tim Wiederhake wrote: This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attributes `voices` (typically 1), `bufferLength` (measured in milliseconds), `frequency` (in Hz, typically 44100), and `channels` (typically 2 for

Re: [libvirt PATCH 01/10] virDomainAudioIOCommon: Change type of format to virDomainAudioFormat

On a Tuesday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 - src/conf/domain_conf.h | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Thu, Apr 29, 2021 at 02:03:52PM -0400, Eduardo Habkost wrote: > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > Live migrating old guests from an old QEMU with the SCSI feature bit > > enabled will fail with "Features 0x... unsupported. Allowed features: > > 0x...". We've

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Thu, Apr 29, 2021 at 06:16:28PM +0200, Peter Krempa wrote: > On Thu, Apr 29, 2021 at 16:52:21 +0100, Stefan Hajnoczi wrote: > > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > > completely at this point. > > > > Drop the scsi=on|off option. It was only available on

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

On Thu, Apr 29, 2021 at 02:03:52PM -0400, Eduardo Habkost wrote: > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > > completely at this point. > > > > Drop the scsi=on|off option. It was only available

[libvirt PATCH 07/10] virDomainDef: Change type of placement_mode to virDomainCpuPlacementMode

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8f4fd0e3bc..20cf987176 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 05/10] virDomainIOThreadPinDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e95be17989..d7cef00246 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH 10/10] virDomainResctrlMonDefParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 483df91880..b3ef2db3fa 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH 09/10] virDomainCachetuneDefParseCache: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 43 +- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 52d12bfb43..483df91880 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 08/10] virDomainVcpuParse: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 84 ++ 1 file changed, 20 insertions(+), 64 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 20cf987176..52d12bfb43 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 03/10] virDomainMemoryDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 - 1 file changed, 8 insertions(+), 33 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8930dc33ce..b8ac399f5c 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 04/10] virDomainVcpuPinDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b8ac399f5c..e95be17989 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17273,17

[libvirt PATCH 06/10] virDomainSchedulerParseCommonAttrs: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d7cef00246..8f4fd0e3bc 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 02/10] virDomainPerfEventDefParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5822f3d85a..8930dc33ce 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 01/10] virDomainRedirFilterUSBDevDefParseXML: Use g_auto*

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0050b952f3..5822f3d85a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part VIII

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Note that patch #1 depends on https://listman.redhat.com/archives/libvir-list/2021-April/msg01260.html from part VII. Tim Wiederhake (10): virDomainRedirFilterUSBDevDefParseXML: Use g_auto*

Re: [libvirt PATCH 0/3] cpu-data.py: Add support for kcpuid

ping On Tue, 2021-04-27 at 10:25 +0200, Tim Wiederhake wrote: > Linux 5.13 introduces "kcpuid", a tool similar to cpuid, which we > depend > on for cpu-data collection with tests/cputestdata/cpu-data.py. > > This series adds support for kcpuid to cpu-data.py. > > See also >

Re: Let's remove some deprecated stuff

On Mon, May 03, 2021 at 13:21:47 -0500, Eric Blake wrote: > On 4/29/21 4:59 AM, Markus Armbruster wrote: [...] > > qemu-img backing file without format (since 5.1) > > > > > > The use of ``qemu-img create``, ``qemu-img rebase``, or

Re: [PATCH 2/2] qemu-img: Require -F with -b backing image

On 5/3/21 4:45 PM, Eric Blake wrote: > On 5/3/21 4:36 PM, Eric Blake wrote: >> Back in commit d9f059aa6c (qemu-img: Deprecate use of -b without -F), >> we deprecated the ability to create a file with a backing image that >> requires qemu to perform format probing. Qemu can still probe older >>

[PATCH v2 08/19] Refactoring virDomainLeaseDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 189 ++--- 1 file changed, 82 insertions(+), 107 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1142b1214a..365879ea98 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 16/19] Refactoring virDomainGraphicsDefParseXMLSpice() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 303 - 1 file changed, 114 insertions(+), 189 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2511778b15..206816d76f 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 06/19] Refactoring virDomainHostdevSubsysPCIDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3ca5211a35..c5d4469b72 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 19/19] Refactoring virDomainVideoDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 88 -- 1 file changed, 33 insertions(+), 55 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f90f720b44..990c6be309 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 18/19] Refactoring virDomainVideoDriverDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97cf940dad..f90f720b44 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[PATCH v2 17/19] conf: Propagate xmlXPathContextPtr into virDomainVideoDriverDefParseXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 206816d76f..97cf940dad 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14348,7 +14348,8

[PATCH v2 15/19] Refactoring virDomainSmartcardDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 59 ++ 1 file changed, 25 insertions(+), 34 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5d7fd6794f..2511778b15 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 05/19] conf: Propagate xmlXPathContextPtr into virDomainHostdevSubsysPCIDefParseXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f658cf49e7..3ca5211a35 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6841,6 +6841,7 @@

[PATCH v2 13/19] Refactoring virDomainChrSourceDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 190 - 1 file changed, 94 insertions(+), 96 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5ac15fe9e8..c5b13783f3 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 12/19] Refactoring virDomainChrDefParseTargetXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index df7079c7e6..5ac15fe9e8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[PATCH v2 14/19] Refactoring virDomainChrDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c5b13783f3..5d7fd6794f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[PATCH v2 11/19] conf: Propagate xmlXPathContextPtr into virDomainChrDefParseTargetXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dc72a91d8d..df7079c7e6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11063,6 +11063,7 @@

[PATCH v2 09/19] Refactoring virDomainFSDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 110 ++--- 1 file changed, 49 insertions(+), 61 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 365879ea98..d7bee155e7 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 02/19] Refactoring virDomainHostdevSubsysUSBDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 130 +++-- 1 file changed, 60 insertions(+), 70 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e073644810..5c5b4ad6d7 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 10/19] Refactoring virDomainNetDefParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 340 +++-- 1 file changed, 157 insertions(+), 183 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d7bee155e7..dc72a91d8d 100644 --- a/src/conf/domain_conf.c +++

[PATCH v2 07/19] conf: Propagate xmlXPathContextPtr into virDomainLeaseDefParseXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c5d4469b72..1142b1214a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8084,7 +8084,8

[PATCH v2 01/19] conf: Propagate xmlXPathContextPtr into virDomainHostdevSubsysUSBDefParseXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cb668d3d5e..e073644810 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6709,6 +6709,7 @@

[PATCH v2 03/19] conf: Propagate xmlXPathContextPtr into virDomainBlkioDeviceParseXML()

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c5b4ad6d7..b369c49b05 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1666,6 +1666,7 @@

[PATCH v2 00/19] Refactoring conf to use XPath

This is v2 from https://listman.redhat.com/archives/libvir-list/2021-April/msg00617.html Changes since v1: - rebase to the lastest git master This series reworks the outdated way of parsing XML to parsing by XPath, which is more obvious and saves a few lines of code. Kristina Hanicova (19):

[PATCH v2 04/19] Refactoring virDomainBlkioDeviceParseXML() to use XPath

Signed-off-by: Kristina Hanicova --- src/conf/domain_conf.c | 116 + 1 file changed, 48 insertions(+), 68 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b369c49b05..f658cf49e7 100644 --- a/src/conf/domain_conf.c +++

Re: [libvirt PATCH 6/6] ci: Enable address and undefined behavior sanitizers

On Tue, May 04, 2021 at 12:50:09PM +0200, Tim Wiederhake wrote: > On Mon, 2021-05-03 at 14:16 +0200, Pavel Hrdina wrote: > > On Mon, May 03, 2021 at 12:01:46PM +0200, Tim Wiederhake wrote: > > > meson supports the following sanitizers: "address" (e.g. out-of- > > > bounds > > > memory access,

Re: [libvirt PATCH 6/6] ci: Enable address and undefined behavior sanitizers

On Mon, 2021-05-03 at 14:16 +0200, Pavel Hrdina wrote: > On Mon, May 03, 2021 at 12:01:46PM +0200, Tim Wiederhake wrote: > > meson supports the following sanitizers: "address" (e.g. out-of- > > bounds > > memory access, use-after-free, etc.), "thread" (data races), > > "undefined" > > (e.g. signed

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

* Peter Krempa (pkre...@redhat.com) wrote: > On Fri, Apr 30, 2021 at 09:42:05 +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > >> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > >

Re: [PATCH] Add page_per_vq flag to the 'driver' element of virtio devices

On 4/29/21 5:43 PM, Jonathon Jongsma wrote: > On Thu, 2021-04-29 at 14:12 +0300, Gavi Teitz wrote: >>

[libvirt PATCH 8/8] ci: Drop CentOS 7

Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml| 16 ci/containers/centos-7.Dockerfile | 138 -- 2 files changed, 154 deletions(-) delete mode 100644 ci/containers/centos-7.Dockerfile diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[libvirt PATCH 3/8] ci: Refresh contents

Notable changes: * the CentOS Stream 8 container is now using a proper base image instead of starting from a CentOS 8 image and then adding the CentOS Stream 8 repositories on top; * distributions that have a perl-base package are now using that one instead of the regular perl

[libvirt PATCH 2/8] ci: Rename CentOS Stream 8 and openSUSE Leap 15.2 containers

The names have been recently changed in libvirt-ci to be more accurate, so we should follow along. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml| 24 +-- Dockerfile => centos-stream-8.Dockerfile} | 0 ...ockerfile =>

[libvirt PATCH 7/8] ci: Drop Fedora 32

Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 13 ci/containers/fedora-32.Dockerfile | 115 - 2 files changed, 128 deletions(-) delete mode 100644 ci/containers/fedora-32.Dockerfile diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[libvirt PATCH 6/8] ci: Add Fedora 34

Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 12 +++ ci/containers/fedora-34.Dockerfile | 115 + 2 files changed, 127 insertions(+) create mode 100644 ci/containers/fedora-34.Dockerfile diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[libvirt PATCH 1/8] ci: Remove Fedora Rawhide dwarf4 hack

It's no longer needed. Reverts: e603efb6ec5d1a2295adfda934e79f022bb7bb0e Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 4 1 file changed, 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8b7df68f47..d2f541efbc 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@

[libvirt PATCH 5/8] ci: Add FreeBSD 13

Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml| 10 ++ ci/cirrus/freebsd-13.vars | 13 + 2 files changed, 23 insertions(+) create mode 100644 ci/cirrus/freebsd-13.vars diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 84032ab412..6fd147ae81 100644 ---

[libvirt PATCH 4/8] ci: Add openSUSE Tumbleweed

Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml | 13 +++ ci/containers/opensuse-tumbleweed.Dockerfile | 101 +++ 2 files changed, 114 insertions(+) create mode 100644 ci/containers/opensuse-tumbleweed.Dockerfile diff --git a/.gitlab-ci.yml

[libvirt PATCH 0/8] ci: Refresh contents, update list of targets

This brings our pipeline in sync with the current status of the libvirt-ci repository. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/296773363 Andrea Bolognani (8): ci: Remove Fedora Rawhide dwarf4 hack ci: Rename CentOS Stream 8 and openSUSE Leap 15.2 containers ci:

[PATCH] virthread: Make sure virOnce() returns -1 on error

Since its introduction in v0.9.1~65 the virOnce() was expected to follow the usual retval logic (0 for success, a negative number for failure). However, that was never the case. On the other hand, looking into glibc and musl the pthread_once() never returns anything other than zero (uclibc-ng

Re: [PATCH v3 01/14] virhostmem: Introduce virHostMemGetTHPSize()

On 5/3/21 1:07 PM, Peter Krempa wrote: > On Fri, Apr 23, 2021 at 15:24:23 +0200, Michal Privoznik wrote: >> New virHostMemGetTHPSize() is introduced which allows caller to >> obtain THP PMD (Page Middle Directory) size, which is equal to >> the minimal size that THP can use, taken from kernel doc

Re: [PATCH] Add page_per_vq flag to the 'driver' element of virtio devices

On 4/29/21 2:51 PM, Peter Krempa wrote: On Thu, Apr 29, 2021 at 14:12:44 +0300, Gavi Teitz wrote: