On Mon, Jan 11, 2021 at 10:52 AM Andrea Bolognani wrote:
>
> On Thu, 2021-01-07 at 13:48 -0500, Neal Gompa wrote:
> > On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark wrote:
> > > On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> > > > +++ b/libvirt.spec.in
> > > > @@ -614,7 +614,6 @@
The libvirt-daemon package now provides the 'libvirt-admin' virtual
name, but the Provides stanza doesn't declare version information,
which breaks things depending on that package using a versioned
dependency. Fix this by setting the version-release of libvirt to
that name to mimic the previous
On Tue, May 11, 2021 at 11:21 AM Andrea Bolognani wrote:
>
>
>
> Andrea Bolognani (3):
> spec: Reintroduce supported_platform variable
> spec: Move definition of supported_platform variable
> spec: Simplify platform check
>
> libvirt.spec.in | 12 +---
> mingw-libvirt.spec.in
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_conf.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_conf.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
Reviewed-by: Laine Stump
---
src/conf/storage_adapter_conf.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
}
VIR_FREE(nodes);
if ((n = virXPathNodeSet("./cpu/numa[1]/interconnects[1]/latency|"
"./cpu/numa[1]/interconnects[1]/bandwidth", ctxt,
)) <
Again, the VIR_FREE(nodes) points out that you're
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 42 --
1 file changed, 4 insertions(+), 38 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 531bdc6eba..e631bfa341 100644
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index bae59ac7b8..531bdc6eba 100644
---
On 5/11/21 11:01 AM, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/conf/node_device_conf.c | 34 +-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index
No need to check whether we're on Fedora, because checking
whether the version of Fedora is recent enough implictly does
that already.
Signed-off-by: Andrea Bolognani
---
mingw-libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mingw-libvirt.spec.in
The rewritten checks, which made it possible to drop the
variable, are in fact not equivalent to the original ones,
and rewriting them once again so that they are would make
them unwieldy. Let's go back to how things were.
Reverts: 69c8d5954ec4c5be22c2ebe313dbdc6c3f98c7b5
Signed-off-by: Andrea
Andrea Bolognani (3):
spec: Reintroduce supported_platform variable
spec: Move definition of supported_platform variable
spec: Simplify platform check
libvirt.spec.in | 12 +---
mingw-libvirt.spec.in | 12 +---
2 files changed, 18 insertions(+), 6 deletions(-)
--
It's only used in one place, and it's nicer to keep the error
message close to the check that causes it to be emitted.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 12 ++--
mingw-libvirt.spec.in | 12 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
diff
On Tue, May 11, 2021 at 03:36:46PM +0100, Daniel P. Berrangé wrote:
> On Tue, May 11, 2021 at 07:22:26AM -0700, Andrea Bolognani wrote:
> > On Tue, May 11, 2021 at 09:12:41AM -0400, Neal Gompa wrote:
> > > On Wed, May 5, 2021 at 4:12 PM Andrea Bolognani
> > > wrote:
> > > > -%if 0%{?fedora} >=
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index bae59ac7b8..531bdc6eba 100644
--- a/src/conf/numa_conf.c
+++ b/src/conf/numa_conf.c
@@
Signed-off-by: Tim Wiederhake
---
src/conf/node_device_conf.c | 34 +-
1 file changed, 13 insertions(+), 21 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 4477a8d9d2..5ac046f768 100644
--- a/src/conf/node_device_conf.c
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 45 +---
1 file changed, 13 insertions(+), 32 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 932af4a185..bae59ac7b8 100644
--- a/src/conf/numa_conf.c
+++
For background, see
https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
Tim Wiederhake (10):
virNodeDeviceDefParseXML: Use g_auto*
virDomainNumatuneNodeParseXML: Use virXMLProp*
virDomainNumatuneNodeParseXML: Use g_autofree
virDomainNumaDefNodeDistanceParseXML: Use
Signed-off-by: Tim Wiederhake
---
src/conf/storage_adapter_conf.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c
index 142489f6cd..6b5a58e1e7 100644
--- a/src/conf/storage_adapter_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/storage_conf.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 328650bd6a..435a029b4e 100644
--- a/src/conf/storage_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 49 +++-
1 file changed, 21 insertions(+), 28 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 27aac87a8d..abb39a36ac 100644
--- a/src/conf/numa_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/storage_conf.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 10b46ac368..e481cac75c 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 42 --
1 file changed, 4 insertions(+), 38 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 531bdc6eba..e631bfa341 100644
--- a/src/conf/numa_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/storage_conf.c | 41 ++---
1 file changed, 18 insertions(+), 23 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 435a029b4e..10b46ac368 100644
--- a/src/conf/storage_conf.c
+++
Signed-off-by: Tim Wiederhake
---
src/conf/numa_conf.c | 128 +-
.../hugepages-memaccess-invalid.err | 2 +-
2 files changed, 35 insertions(+), 95 deletions(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index
On Tue, May 11, 2021 at 07:22:26AM -0700, Andrea Bolognani wrote:
> On Tue, May 11, 2021 at 09:12:41AM -0400, Neal Gompa wrote:
> > On Wed, May 5, 2021 at 4:12 PM Andrea Bolognani wrote:
> > > -%if 0%{?fedora} >= %{min_fedora} || 0%{?rhel} >= %{min_rhel}
> > > -%define supported_platform 1
>
On Tue, May 11, 2021 at 09:12:41AM -0400, Neal Gompa wrote:
> On Wed, May 5, 2021 at 4:12 PM Andrea Bolognani wrote:
> > -%if 0%{?fedora} >= %{min_fedora} || 0%{?rhel} >= %{min_rhel}
> > -%define supported_platform 1
> > -%else
> > -%define supported_platform 0
> > -%endif
> >
> > -%if !
The new virDomainReloadTlsCertificates API is used to notify domain reload
its certificates without restart, and avoid service interruption.
And add remote qemu driver impl for virDrvDomainReloadTlsCertificates.
Currently, only QEMU VNC TLS certificates are supported, but parameters and
flags
The 'display-reload' QMP command was introduced in QEMU 6.0.0, so we
add a compatible capability to check if target QEMU binary supports it.
{"execute":"display-reload", "arguments":{"type": "vnc", "tls-certs": true}}
The new QMP refer to:
Introduce domreload-certs virsh sub-command to notify domain reload
its specified certificates:
#virsh domreload-certs --type [--flags ]
Signed-off-by: Zheng Yan
---
docs/manpages/virsh.rst | 15 ++
tools/virsh-domain.c| 61 +
2 files
The 'display-reload' QMP command had been introduced from QEMU 6.0.0:
https://gitlab.com/qemu-project/qemu/-/commit/9cc07651655ee86eca41059f5ead8c4e5607c734
TO support the new QMP command, we added a new internal API
'virDrvDomainReloadTlsCertificates' to virHypervisorDriver, and
implemented the
The new virDomainReloadTlsCertificates API is used to notify domain reload
its certificates without restart, and avoid service interruption.
Currently, only QEMU VNC TLS certificates are supported, but parameters and
flags are also reserved for subsequent scenarios.
Take reload QEMU VNC TLS
On Wed, May 5, 2021 at 4:12 PM Andrea Bolognani wrote:
>
> It's only used in one place, and it's nicer to keep the error
> message close to the check that causes it to be emitted.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 12 +++-
> mingw-libvirt.spec.in | 12
On 5/10/21 9:07 PM, Daniel P. Berrangé wrote:
> In several of the jobs we are running the libvirt build twice.
>
> We also uncessarily run the syntax-check job multiple times
> which causes more work for contributors looking at failed
> jobs.
>
> Daniel P. Berrangé (4):
> gitlab: only print
On 5/10/21 2:48 PM, Tim Wiederhake wrote:
> For background, see
> https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html
>
> Tim Wiederhake (10):
> virDomainObjParseXML: Use virXMLProp*
> virDomainObjParseXML: Use g_autoptr
> virNetworkDHCPLeaseTimeDef: Make expiry
On 5/11/21 12:37 PM, John Ferlan wrote:
>
>
> On 5/5/21 4:02 AM, Michal Privoznik wrote:
>> The @cpus variable is an array of structs in which each item
>> contains a virBitmap member. As such it is not enough to just
>> VIR_FREE() the array - each bitmap has to be freed too.
>>
>>
On 5/5/21 4:02 AM, Michal Privoznik wrote:
The @cpus variable is an array of structs in which each item
contains a virBitmap member. As such it is not enough to just
VIR_FREE() the array - each bitmap has to be freed too.
Signed-off-by: Michal Privoznik
---
src/conf/capabilities.c | 1 +
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/142
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_command.c | 32 -
.../input-linux.x86_64-latest.args| 34 +++
tests/qemuxml2argvtest.c | 2 ++
3
Signed-off-by: Kristina Hanicova
---
docs/formatdomain.rst| 37 -
docs/schemas/domaincommon.rng| 20 +++
src/conf/domain_audit.c | 1 +
src/conf/domain_conf.c | 66
src/conf/domain_conf.h
This is v2 from:
https://listman.redhat.com/archives/libvir-list/2021-April/msg01307.html
Changes since v1:
- formats command line for -object 'input-linux' in JSON representation
- change of xml representation from 'input-linux' to 'evdev' as
suggested by Daniel for future compatibility
- fix of
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 +
On 5/11/21 10:29 AM, Kashyap Chamarthy wrote:
> On Tue, May 11, 2021 at 09:54:28AM +0200, Michal Prívozník wrote:
>> On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
>>> I don't think the Debian "sid" failure is related to my patch:
>>>
>>>
On Tue, Apr 27, 2021 at 02:39:46PM -0700, William Douglas wrote:
> Cloud-Hypervisor is a KVM virtualization using hypervisor. It
> functions similarly to qemu and the libvirt Cloud-Hypervisor driver
> uses a very similar structure to the libvirt driver.
>
> The biggest difference from the libvirt
On Tue, May 11, 2021 at 09:54:28AM +0200, Michal Prívozník wrote:
> On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
> > I don't think the Debian "sid" failure is related to my patch:
> >
> > https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
> >
> > Changes in v2:
> >
> > -
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
> This is a rewrite of:
>
> https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit
>
> Once this commit merges, the above wiki should point to this kbase
> document.
>
> NB: I've intentionally left out the example for pull-based
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
> This is a rewrite of:
>
>
> https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-including-current-active-disk
>
> Once this commit merges, the above wiki should point to this kbase
> document.
>
> Signed-off-by: Kashyap
On 5/10/21 6:39 PM, Kashyap Chamarthy wrote:
> I don't think the Debian "sid" failure is related to my patch:
>
> https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures
>
> Changes in v2:
>
> - Mention backupBegin() [Peter]
> - Add examples of push-mode backup using
49 matches
Mail list logo