Re: [PATCH v2 3/3] qapi: deprecate drive-backup

09.06.2021 13:49, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 08.06.2021 14:12, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated'

Re: [libvirt PATCH 04/10] qemuMonitorGetAllBlockStatsInfo: Use automatic memory management

On Mon, Jul 05, 2021 at 05:36:43PM +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/qemu/qemu_monitor.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c > index 86aabc98c3..f08b43bbfb

Re: [libvirt PATCH 03/10] qemuMonitorGetAllBlockStatsInfo: Assign hash table only on success

On Mon, Jul 05, 2021 at 05:36:42PM +0200, Tim Wiederhake wrote: > `virHashNew` cannot return NULL, the check is not needed. > > Signed-off-by: Tim Wiederhake > --- > src/qemu/qemu_monitor.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

[libvirt PATCH 09/10] qemuMonitorGetChardevInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f03d6106f9..2c43cc0788 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@

[libvirt PATCH 10/10] qemuMonitorGetChardevInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 2c43cc0788..a63056f0a0 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2885,16 +2885,13

[libvirt PATCH 06/10] qemuMonitorGetBlockInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index de0f6ccf7d..9f0b20db09 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,7 +2103,7

[libvirt PATCH 07/10] qemuMonitorGetBlockInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 9f0b20db09..dba2fb1982 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,13 +2103,10

[libvirt PATCH 05/10] qemuMonitorGetBlockInfo: Remove superfluous variable "ret"

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f08b43bbfb..de0f6ccf7d 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2103,7 +2103,6

[libvirt PATCH 08/10] qemuMonitorGetChardevInfo: Remove superfluous variable "ret"

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dba2fb1982..f03d6106f9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2885,7 +2885,6

[libvirt PATCH 04/10] qemuMonitorGetAllBlockStatsInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 86aabc98c3..f08b43bbfb 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2155,7

[libvirt PATCH 01/10] qemuMonitorGetAllBlockStatsInfo: Clean up line break

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 8f35b4240f..df1e41f68f 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2162,8 +2162,7 @@

[libvirt PATCH 02/10] qemuMonitorGetAllBlockStatsInfo: Remove superfluous variable initialization

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index df1e41f68f..19fcc5658b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2154,7 +2154,7 @@

[libvirt PATCH 03/10] qemuMonitorGetAllBlockStatsInfo: Assign hash table only on success

`virHashNew` cannot return NULL, the check is not needed. Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 19fcc5658b..86aabc98c3 100644 ---

[libvirt PATCH 00/10] virHashNew refactorings

"virHashNew" cannot return NULL, yet we check for NULL in various places. This series is the first of several that remove these checks. Where applicable, the functions are refactored to use automatic memory management by means of g_autoptr etc. as well. Tim Wiederhake (10):

Re: [libvirt][PATCH v4 4/4] Support to query SGX capability

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > 1.Add SGX feature in domain capabilities > 2.Get sgx capabilities by query-sgx-capabilities > 3.Transfer the B to KB for epc_size > 4.Delete sgx1 and sgx2 > 5.add unit test for get capabilities > > Signed-off-by: Haibin Huang > --- >  

Re: [libvirt][PATCH v4 2/4] qemu: Add command-line to generate SGX EPC memory backend

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > From: Lin Yang > > According to the result parsing from xml, add the argument of > SGX EPC memory backend into QEMU command line: > >     -object memory-backend-epc,id=mem1,size=K,prealloc \ >     -sgx-epc id=epc1,memdev=mem1 > --- >  

Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > From: Lin Yang > > If SGX is defined in domain, add the argument to enable > SGX in -cpu : > >     -cpu ,+sgx,+sgx-debug,+sgx1,+sgx-encls-c, >     +sgx-enclv,+sgx-exinfo,+sgx-kss,+sgx-mode64, >    

Re: [libvirt][PATCH v4 1/4] conf: Introduce SGX related element into domain xml

On Thu, 2021-07-01 at 20:10 +0800, Haibin Huang wrote: > From: Lin Yang > >   >     1024 >   Please also update "docs/schemas/domaincommon.rng". > --- >  src/conf/domain_conf.c  | 106 +- > -- >  src/conf/domain_conf.h  |  10 >  src/conf/virconftypes.h

Re: crash in virQEMUCapsProbeQMPTPM

On Mon, Jul 05, 2021 at 00:15:56 +0200, Olaf Hering wrote: > I got a couple of "g_strv_contains: assertion 'strv != NULL' failed" in the > past days. > > It seems qemuMonitorGetTPMModels can write NULL into "models" in > "virQEMUCapsProbeQMPTPM()". > As a result g_strv_contains will crash with

[libvirt PATCH 6/6] virDomainSEVDefParseXML: Remove superfluous variable initialization

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index db8ec23d70..2d8ae7e860 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14721,7 +14721,7 @@

[libvirt PATCH 3/6] virDomainSEVDefParseXML: Use virXMLPropEnum

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68ab18f3ab..dda615a8ba 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH 2/6] conf: virDomainSEVDef: Change type of "sectype" to virDomainLaunchSecurity

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 6 -- src/conf/domain_conf.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c1438d85f4..68ab18f3ab 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 5/6] virDomainSEVDefParseXML: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dd803e6df5..db8ec23d70 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14730,12

[libvirt PATCH 1/6] conf: Add AUTOPTR_CLEANUP_FUNC for virDomainSEVDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 04c10df0a9..c1438d85f4 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 0/6] More XML parsing boiler code refactoring

In the spirit of https://listman.redhat.com/archives/libvir-list/2021-May/msg00550.html. Tim Wiederhake (6): conf: Add AUTOPTR_CLEANUP_FUNC for virDomainSEVDef conf: virDomainSEVDef: Change type of "sectype" to virDomainLaunchSecurity virDomainSEVDefParseXML: Use virXMLPropEnum

[libvirt PATCH 4/6] virDomainSEVDefParseXML: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dda615a8ba..dd803e6df5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14719,7 +14719,7 @@