"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> New option parameters unstable-input and unstable-output set policy
>> for unstable interfaces just like deprecated-input and
>> deprecated-output set policy for deprecated interfaces (see commit
>> 6dd75472d5
John Snow writes:
> On Tue, Oct 26, 2021 at 3:56 AM Markus Armbruster wrote:
>
>> John Snow writes:
>>
>> > On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster
>> wrote:
>> >
>> >> Add special feature 'unstable' everywhere the name starts with 'x-',
>> >> except for InputBarrierProperties
Daniel P. Berrangé writes:
> On Tue, Oct 26, 2021 at 05:15:10PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Tue, Oct 26, 2021 at 11:37:19AM +0200, Markus Armbruster wrote:
[...]
>> >> Management applications are better off with a feature flag than with a
>> >>
John Snow writes:
> On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster
> wrote:
>
>> Several moons ago, Vladimir posted
>>
>> Subject: [PATCH v2 3/3] qapi: deprecate drive-backup
>> Date: Wed, 5 May 2021 16:58:03 +0300
>> Message-Id:
As of this commit, the nanoMIPS toolchains haven't been merged
in mainstream projects. However MediaTek provides a toolchain:
https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01
QEMU deprecation policy schedules code for removal. If we don't
need / want to
The architecture is covered in TCG (frontend and backend)
and hardware models. Add a generic section matching the
'mips' word in patch subjects.
Reviewed-by: Jiaxun Yang
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20211004092515.3819836-2-f4...@amsat.org>
---
MAINTAINERS | 7 ++-
1
MIPS CPS and GIC models are unrelated to the TCG frontend.
Move them as new sections under the 'Devices' group.
Cc: Paul Burton
Reviewed-by: Jiaxun Yang
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff
Move various files unrelated to MIPS TCG frontend into
new sections.
Since v1:
- Do not add Paul without his consent
- un-deprecate nanoMIPS
Philippe Mathieu-Daudé (4):
MAINTAINERS: Add MIPS general architecture support entry
MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware
Hardware emulated models don't belong to the TCG MAINTAINERS
section. Move them to a new 'Overall MIPS Machines' section
in the 'MIPS Machines' group.
Reviewed-by: Jiaxun Yang
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20211004092515.3819836-4-f4...@amsat.org>
---
MAINTAINERS | 10
On 5/6/21 04:22, Michal Prívozník wrote:
Dear list,
Hi Michal,
This thread has been quiet for a long time, but I wanted to check if any work
has been done to provide an sev-inject-launch-secret equivalent for libvirt.
AFAICT, there was agreement this missing piece is needed to solve the
On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster
wrote:
> Several moons ago, Vladimir posted
>
> Subject: [PATCH v2 3/3] qapi: deprecate drive-backup
> Date: Wed, 5 May 2021 16:58:03 +0300
> Message-Id: <20210505135803.67896-4-vsement...@virtuozzo.com>
>
On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster
wrote:
> The next commit needs to access compat policy from the generic visitor
> core. Move it there from qobject input and output visitor.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
>
"LGTM".
On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster
wrote:
> This is quite similar to commit 84ab008687 "qapi: Add feature flags to
> struct members", only for enums instead of structs.
>
> Special feature flag 'deprecated' is silently ignored there. This is
> okay only because it will be
On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster
wrote:
> The next commit will add feature flags to enum members. There's a
> problem, though: query-qmp-schema shows an enum type's members as an
> array of member names (SchemaInfoEnum member @values). If it showed
> an array of objects with
* Markus Armbruster (arm...@redhat.com) wrote:
> New option parameters unstable-input and unstable-output set policy
> for unstable interfaces just like deprecated-input and
> deprecated-output set policy for deprecated interfaces (see commit
> 6dd75472d5 "qemu-options: New -compat to set policy
Hi Daniel,
> Something is still not right with the logic here as this error report
is triggering on my machines. If I comment out this check, then I can
get data reported by libvirt
The VPD example you shared previously has multiple violations of the VPD format:
* Invalid field values ("N/A" in
On Fri, Oct 22, 2021 at 03:45:42PM +0300, Dmitrii Shcherbakov wrote:
> * RV and RW fields must be at the last position in their respective
> section (per the conditions in the spec). Therefore, the parser now
> stops iterating over fields as soon as it encounters one of those
> fields and
On Tue, Oct 26, 2021 at 3:56 AM Markus Armbruster wrote:
> John Snow writes:
>
> > On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster
> wrote:
> >
> >> Add special feature 'unstable' everywhere the name starts with 'x-',
> >> except for InputBarrierProperties member x-origin and
> >>
On Fri, Oct 22, 2021 at 03:45:44PM +0300, Dmitrii Shcherbakov wrote:
> While invalid values need to be ignored when presenting VPD data to the
> user, it would be good to attempt to parse a valid portion of the VPD
> instead of marking it invalid as a whole.
>
> The particular example encountered
On Tue, Oct 26, 2021 at 5:43 AM Markus Armbruster wrote:
> John Snow writes:
>
> > On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster
> wrote:
> >
> >> The code to check enumeration value policy can see special feature
> >> flag 'deprecated' in QEnumLookup member flags[value]. I want to make
>
On 10/25/21 07:25, Markus Armbruster wrote:
> The generated visitor functions call visit_deprecated_accept() and
> visit_deprecated() when visiting a struct member with special feature
> flag 'deprecated'. This makes the feature flag visible to the actual
> visitors. I want to make feature flag
On Tue, Oct 26, 2021 at 05:15:10PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Oct 26, 2021 at 11:37:19AM +0200, Markus Armbruster wrote:
> >> Kevin Wolf writes:
> >>
> >> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> >> >> By convention, names
This is v2 of:
https://listman.redhat.com/archives/libvir-list/2021-October/msg01035.html
Diff to v1:
* negation of 'if' with switched body (proposed by Peter)
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_block.c | 33 +
1 file changed, 13 insertions(+),
Daniel P. Berrangé writes:
> On Tue, Oct 26, 2021 at 11:37:19AM +0200, Markus Armbruster wrote:
>> Kevin Wolf writes:
>>
>> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
>> >> By convention, names starting with "x-" are experimental. The parts
>> >> of external interfaces so
On Tue, Oct 26, 2021 at 16:58:22 +0200, Kristina Hanicova wrote:
> I think this patch improves readability of the function by
> removing unnecessary 'else' branches after 'return' and reworking
> the code a bit.
>
> Signed-off-by: Kristina Hanicova
> ---
> src/qemu/qemu_block.c | 33
On Tue, Oct 26, 2021 at 04:49:55PM +0200, Michal Prívozník wrote:
> On 10/26/21 4:39 PM, Daniel P. Berrangé wrote:
> > On Tue, Oct 26, 2021 at 12:17:06PM +0200, Michal Privoznik wrote:
> >> In some cases the worker func running inside the pool may rely on
> >> virIdentity. While worker func could
On Tue, Oct 26, 2021 at 11:37:19AM +0200, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> >> By convention, names starting with "x-" are experimental. The parts
> >> of external interfaces so named may be withdrawn or changed
> >>
I think this patch improves readability of the function by
removing unnecessary 'else' branches after 'return' and reworking
the code a bit.
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_block.c | 33 +
1 file changed, 13 insertions(+), 20 deletions(-)
diff
On 10/26/21 4:39 PM, Daniel P. Berrangé wrote:
> On Tue, Oct 26, 2021 at 12:17:06PM +0200, Michal Privoznik wrote:
>> In some cases the worker func running inside the pool may rely on
>> virIdentity. While worker func could check for identity and set
>> one it is not optimal - it may not have
On 10/26/21 4:31 PM, Daniel P. Berrangé wrote:
> On Tue, Oct 26, 2021 at 12:17:07PM +0200, Michal Privoznik wrote:
>> It may happen that qemuProcessStop() is called from "qemu-event"
>> thread. But this thread doesn't have any virIdentity set
>> (virIdentity being thread local) and therefore it
On Tue, Oct 26, 2021 at 12:17:06PM +0200, Michal Privoznik wrote:
> In some cases the worker func running inside the pool may rely on
> virIdentity. While worker func could check for identity and set
> one it is not optimal - it may not have access to the identity of
> the thread creating the pool
On Tue, Oct 26, 2021 at 12:17:07PM +0200, Michal Privoznik wrote:
> It may happen that qemuProcessStop() is called from "qemu-event"
> thread. But this thread doesn't have any virIdentity set
> (virIdentity being thread local) and therefore it may be unable
> to open connection to secondary
On a Tuesday in 2021, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
NEWS.rst| 2 +-
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_command.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 5a7570d0db..5f1cf19940 100644
---
Found by "codespell", see proposed script at
https://listman.redhat.com/archives/libvir-list/2021-October/msg00015.html
Cheers,
Tim
Tim Wiederhake (1):
Fix some typos
NEWS.rst| 2 +-
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_command.c | 4 ++--
3 files changed, 4
Signed-off-by: Tim Wiederhake
---
NEWS.rst| 2 +-
src/conf/domain_conf.c | 2 +-
src/qemu/qemu_command.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 5a7570d0db..5f1cf19940 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -64,7 +64,7
Am 26.10.2021 um 11:37 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> >> By convention, names starting with "x-" are experimental. The parts
> >> of external interfaces so named may be withdrawn or changed
> >>
On 10/26/21 11:46, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> On 10/25/21 07:25, Markus Armbruster wrote:
>>> The code to check policy for handling deprecated input is triplicated.
>>> Factor it out into compat_policy_input_ok() before I mess with it in
>>> the next commit.
Stefan Hajnoczi writes:
> On Thu, Oct 14, 2021 at 06:22:32PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> 12.10.2021 14:49, Markus Armbruster wrote:
>> > Vladimir Sementsov-Ogievskiy writes:
[...]
>> Another possible way is to update QAPI code generator to insert a personal
>> trace point
One problem with qemuProcessStop() is that it may run from
"qemu-event" thread. This thread processes events from all
guests, meaning there's just one thread that serves all running
guests. But as such has no virIdentity set, which looks correct
on the first glance - there's no identity to
It may happen that qemuProcessStop() is called from "qemu-event"
thread. But this thread doesn't have any virIdentity set
(virIdentity being thread local) and therefore it may be unable
to open connection to secondary drivers. It is unable to do so
in split daemon scenario, because in there
In some cases the worker func running inside the pool may rely on
virIdentity. While worker func could check for identity and set
one it is not optimal - it may not have access to the identity of
the thread creating the pool and thus would have to call
virIdentityGetSystem(). Allow passing
I propose to merge only the first two patches. The third one is just an
alternative to the first two, but honestly, I view it as a terrible
hack. Nevertheless, a hack worth discussion.
Michal Prívozník (3):
virthreadpool: Allow setting identity for workers
qemu: Set "qemu-event" thread
Philippe Mathieu-Daudé writes:
> On 10/25/21 07:25, Markus Armbruster wrote:
>> The code to check policy for handling deprecated input is triplicated.
>> Factor it out into compat_policy_input_ok() before I mess with it in
>> the next commit.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>>
John Snow writes:
> On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster wrote:
>
>> The code to check enumeration value policy can see special feature
>> flag 'deprecated' in QEnumLookup member flags[value]. I want to make
>> feature flag 'unstable' visible there as well, so I can add policy for
Philippe Mathieu-Daudé writes:
> On 10/25/21 07:25, Markus Armbruster wrote:
>> The code to check command policy can see special feature flag
>> 'deprecated' as command flag QCO_DEPRECATED. I want to make feature
>> flag 'unstable' visible there as well, so I can add policy for it.
>>
>> To
Kevin Wolf writes:
> Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
>> By convention, names starting with "x-" are experimental. The parts
>> of external interfaces so named may be withdrawn or changed
>> incompatibly in future releases.
>>
>> Drawback: promoting something from
On Tue, Oct 26, 2021 at 10:22:15AM +0100, Dr. David Alan Gilbert wrote:
> * Kevin Wolf (kw...@redhat.com) wrote:
> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> > > By convention, names starting with "x-" are experimental. The parts
> > > of external interfaces so named may be
* Kevin Wolf (kw...@redhat.com) wrote:
> Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> > By convention, names starting with "x-" are experimental. The parts
> > of external interfaces so named may be withdrawn or changed
> > incompatibly in future releases.
> >
> > Drawback:
John Snow writes:
> On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
>
>> The generated visitor functions call visit_deprecated_accept() and
>> visit_deprecated() when visiting a struct member with special feature
>> flag 'deprecated'. This makes the feature flag visible to the actual
I have just tagged v7.9.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
John Snow writes:
> On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
>
>> New enum QapiSpecialFeature enumerates the special feature flags.
>>
>> New helper gen_special_features() returns code to represent a
>> collection of special feature flags as a bitset.
>>
>> The next few commits
On Tue, Oct 26, 2021 at 09:37:29AM +0200, Kevin Wolf wrote:
> Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
[...]
> > This commit updates documentation and prepares tests. The next commit
> > updates the QAPI schema. The remaining patches update the QAPI
> > generator and wire up
On Mon, Oct 25, 2021 at 15:25:42 +0200, Michal Privoznik wrote:
> *** BLURB HERE ***
>
> Michal Prívozník (2):
> qemu_monitor: Make domainMemoryDeviceSizeChange cb return void
> qemuProcessHandleMemoryDeviceSizeChange: Use qemuProcessEventSubmit()
Reviewed-by: Peter Krempa
On Tue, Oct 26, 2021 at 09:15:30AM +0200, Markus Armbruster wrote:
> Kashyap Chamarthy writes:
>
> > On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
[...]
> > Looks like there's another stable property with an "x-" prefix:
> > "x-remote-object", part of QOM type
John Snow writes:
> On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
>
>> Add special feature 'unstable' everywhere the name starts with 'x-',
>> except for InputBarrierProperties member x-origin and
>> MemoryBackendProperties member x-use-canonical-path-for-ramblock-id,
>> because
John Snow writes:
> On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
>
>> Signed-off-by: Markus Armbruster
>> ---
>> include/qapi/qmp/dispatch.h | 1 -
>> monitor/misc.c | 3 +--
>> scripts/qapi/commands.py| 5 +
>> 3 files changed, 2 insertions(+), 7 deletions(-)
On Tue, Oct 26, 2021 at 15:13:22 +0800, Han Han wrote:
> Hi, developers
> I has a question about the event VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED. When
> will it occur? Detach device from an active VM? Or an inactive VM? Or both?
> I get a code comment from the callback of this event
>
On Mon, Oct 25, 2021 at 17:32:05 +0200, Jiri Denemark wrote:
> It's only used once and open coding it is at least as clear as using the
> macro.
>
> Signed-off-by: Jiri Denemark
> ---
> src/internal.h | 2 --
> src/util/virutil.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
> By convention, names starting with "x-" are experimental. The parts
> of external interfaces so named may be withdrawn or changed
> incompatibly in future releases.
>
> Drawback: promoting something from experimental to stable involves
Hi Yalan,
1) For inbound, we can use `ovs-vsctl list qos` and `ovs-vsctl list
queue` to check them from the openvswitch side. Values can be found in
other_config. Inbound is in kbyte when set qos with `virshdomiftune …`,
well it is in bit in ovs, Therefore, when inbound.average is
On Mon, Oct 25, 2021 at 05:32:43PM +0200, Jiri Denemark wrote:
> While the QCOW2 cluster size is represented in only 4 bits in the QCOW2
> header and thus 1 << cluster_size cannot overflow int,
> qcow2GetClusterSize is supposed to return unsigned long long so we can
> just compute the result as
Kashyap Chamarthy writes:
> On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
>> By convention, names starting with "x-" are experimental. The parts
>> of external interfaces so named may be withdrawn or changed
>> incompatibly in future releases.
>>
>> Drawback: promoting
Hi, developers
I has a question about the event VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED. When
will it occur? Detach device from an active VM? Or an inactive VM? Or both?
I get a code comment from the callback of this event
63 matches
Mail list logo