On Thu, Nov 04, 2021 at 09:58:11AM +0100, Markus Armbruster wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Modern way is using blockdev-add + blockdev-backup, which provides a
> lot more control on how target is opened.
>
> As example of drive-backup problems consider the following:
>
> User
On 11/5/21 16:53, Willian Rampazzo wrote:
> This introduces a new `make` target, `check-avocado`, and adds a
> deprecation message about the `check-acceptance` target. This is
> a preparation for renaming the `tests/acceptance` folder to
> `tests/avocado`.
>
> The plan is to remove the call to
On Tue, 2 Nov 2021 at 16:48, Gerd Hoffmann wrote:
>
> Allows edk2 detect virtio-mmio devices and pcie ecam.
> See comment in hw/i386/microvm-dt.c for more details.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Sergio Lopez
> Message-Id: <20211014193617.2475578-1-kra...@redhat.com>
Hi;
On Fri, Nov 5, 2021 at 11:31 AM Philippe Mathieu-Daudé
wrote:
>
> Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image")
> removed the content of the "Related binaries" section but forgot
> to remove the section title. Since it is now empty, remove it too.
>
> Signed-off-by: Philippe
In the discussion about renaming the `tests/acceptance` [1], the
conclusion was that the folders inside `tests` are related to the
framework running the tests and not directly related to the type of
the tests.
This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the
CI related
In the discussion about renaming the `tests/acceptance` [1], the
conclusion was that the folders inside `tests` are related to the
framework running the tests and not directly related to the type of
the tests.
This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the
CI related
This introduces a new `make` target, `check-avocado`, and adds a
deprecation message about the `check-acceptance` target. This is
a preparation for renaming the `tests/acceptance` folder to
`tests/avocado`.
The plan is to remove the call to the `check-avocado` target one
or two months after the
On Fri, 2021-11-05 at 16:30 +0100, Michal Prívozník wrote:
> On 11/4/21 5:27 PM, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > src/cpu/cpu_x86.c | 69
> > +++
> > 1 file changed, 69 insertions(+)
> >
> > diff --git
On Fri, 2021-11-05 at 16:30 +0100, Michal Prívozník wrote:
> On 11/4/21 5:27 PM, Tim Wiederhake wrote:
> > ... by using virXMLProp*() helpers. These only require a xmlNodePtr
> > and
> > do not need a xmlXPathContextPtr. Reflect that in the function
> > signature.
> >
> > Signed-off-by: Tim
On 11/4/21 5:27 PM, Tim Wiederhake wrote:
> Many things can affect the availability of cpu features (e.g. software
> upgrades, kernel versions, kernel command line, etc.) and invalidate the
> cached capabilities without notice. Add CPUID information to the
> capabilities cache.
>
> Fixes
On 11/4/21 5:27 PM, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu/cpu_x86.c | 69 +++
> 1 file changed, 69 insertions(+)
>
> diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> index a08ac225ef..5ce193e693 100644
> ---
On 11/4/21 5:27 PM, Tim Wiederhake wrote:
> ... by using virXMLProp*() helpers. These only require a xmlNodePtr and
> do not need a xmlXPathContextPtr. Reflect that in the function signature.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu/cpu_x86.c | 43
On 11/5/21 2:02 PM, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> NEWS.rst | 7 +++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Michal Privoznik
Michal
Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image")
removed the content of the "Related binaries" section but forgot
to remove the section title. Since it is now empty, remove it too.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/about/deprecated.rst | 3 ---
1 file changed, 3
On a Friday in 2021, Michal Privoznik wrote:
If there is no tcp_min_ssf value set in daemon config we still
compare it against the default (56 which corresponds to DES) and
if the value is below our expected minimum (112 which corresponds
to 3DES) an error is reported and the daemon refuses to
If there is no tcp_min_ssf value set in daemon config we still
compare it against the default (56 which corresponds to DES) and
if the value is below our expected minimum (112 which corresponds
to 3DES) an error is reported and the daemon refuses to start.
This is not what we want. What we want is
Signed-off-by: Ján Tomko
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 983153a631..fc47c63bd2 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -24,6 +24,13 @@ v7.10.0 (unreleased)
Libvirt is now able to report interface information from the guest's
On a Friday in 2021, zhanglei wrote:
zhanglei (5):
domain: add interface information to 'virDomainGetGuestInfo'
virsh: add interface information to guestinfo command
qemu: refactor 'qemuAgentGetInterfaces'
qemu: add guest interface information in 'qemuDomainGetGuestInfo'
NEWS: add guest
On a Friday in 2021, zhanglei wrote:
Support return guest interface information from guest agent
Signed-off-by: zhanglei
---
src/qemu/qemu_driver.c | 88 +-
1 file changed, 87 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
On a Friday in 2021, zhanglei wrote:
The new parameter group returns information about network interfaces
Signed-off-by: zhanglei
---
docs/manpages/virsh.rst | 12 ++--
src/libvirt-domain.c| 2 +-
tools/virsh-domain.c| 6 ++
3 files changed, 17 insertions(+), 3 deletions(-)
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 26 +
src/conf/domain_conf.h| 4 ++
src/conf/domain_validate.c| 32
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/formatdomain.rst | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index eb8c973cf1fc..b477aec65f5c 100644
--- a/docs/formatdomain.rst
+++
From: Marc-André Lureau
The USB device redirection works in a similar way as Spice. The
underlying 'dbus' channel is set to "org.qemu.usbredir" by default for
the client to identify the channel purpose (as specified in -display
dbus documentation).
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
This feature requires to setup a "-chardev qemu-vdagent,clipboard=on".
"qemu-vdagent" is not a typical chardev that you can connect to another
end, so it doesn't map to a or . Set it up along with
"-display dbus" code instead.
Signed-off-by: Marc-André Lureau
---
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
docs/schemas/domaincommon.rng | 29 +
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c| 16 +++
src/conf/domain_conf.h| 2 +
From: Marc-André Lureau
Without any extra option, libvirt will start and tell QEMU to connect to
the private VM bus.
Instead, a D-Bus "address" to connect to can be specified. Or the p2p
mode enabled.
D-Bus display best works with GL & a rendernode, which can be specified
with child element.
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.x86_64.replies | 10 +-
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml | 1 +
From: Marc-André Lureau
The daemon is started on daemon in external devices and hotplug code.
Add a mechanism to start it before qemu, if qemu itself needs it. (it is
already stopped in qemuProcessStop)
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.h | 1 +
From: Marc-André Lureau
Hi,
This series implements supports for the upcoming QEMU "-display dbus" support.
Development is still in progress, but I hope to land the QEMU support early in
6.3 (last version posted:
https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lur...@redhat.com/).
On 11/5/21 10:35 AM, Michal Privoznik wrote:
> It may come handy to be able to tweak TCG options, in this
> specific case the size of translation block cache size (tb-size).
> Since we can expect more knobs to tweak let's put them under
> common element, like this:
>
>
>
>
>
Alright, here's the deal: to enable tb-cache one has to use
'-accel tcg,tb-size=' which then conflicts with '-machine
accel=tcg'. But sure, we can use the old -accel in this specific
case. But because of how the tb-size argument is defined in QEMU
there's no way for us to have a capability check.
It may come handy to be able to tweak TCG options, in this
specific case the size of translation block cache size (tb-size).
Since we can expect more knobs to tweak let's put them under
common element, like this:
128
Signed-off-by: Michal Privoznik
We currently use -machine accel=XXX which is just a syntax sugar
for -accel XXX. The former doesn't allow specifying arguments for
accelerator, because all arguments passed to -machine are
treated as arguments of machine itself.
The -accel argument was introduced in QEMU commit
v2.9.0-rc0~70^2~19
v2 of:
https://listman.redhat.com/archives/libvir-list/2021-November/msg00143.html
diff to v1:
- Patches 1/4 and 2/4 are new, per Dan's suggestion
- Patch 4/4 was reworked, since after 2/4 we are using -accel
unconditionally
Please note that patch 2/4 was trimmed in order to fit the list
The domain accelerator was validated in qemuValidateDomainDef()
which calls virQEMUCapsIsVirtTypeSupported() which reports proper
error if QEMU is not capable of KVM/TCG. There is no point in
doing the validation again when building command line.
Signed-off-by: Michal Privoznik
---
On a Friday in 2021, Peter Krempa wrote:
When I was cleaning up the regex after we removed most of our custom
autofree helpers I've forgot to delete one closing brace, thus the regex
was not matching anything.
Fixes: 65f702020e8
Oh no, how did that get past review? O:-)
Signed-off-by: Peter
On Fri, Nov 05, 2021 at 09:28:16AM +0100, Michal Prívozník wrote:
> On 11/4/21 6:25 PM, Daniel P. Berrangé wrote:
> > On Thu, Nov 04, 2021 at 01:22:53PM +0100, Michal Privoznik wrote:
> >> Alright, here's the deal: to enable tb-cache one has to use
> >> '-accel tcg,tb-size=' which then conflicts
When I was cleaning up the regex after we removed most of our custom
autofree helpers I've forgot to delete one closing brace, thus the regex
was not matching anything.
Fixes: 65f702020e8
Signed-off-by: Peter Krempa
---
build-aux/syntax-check.mk | 2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: Ján Tomko
---
Untested, as I obviously do not have access to the COVERITY_SCAN_TOKEN.
.gitlab-ci.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index d486faca58..3e06d16fb1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -116,6
On Thu, Nov 04, 2021 at 07:09:07PM +0100, Kashyap Chamarthy wrote:
> On Thu, Nov 04, 2021 at 01:22:52PM +0100, Michal Privoznik wrote:
> > It may come handy to be able to tweak TCG options, in this
> > specific case the size of translation block cache size (tb-size).
> > Since we can expect more
1) 'activePcrBanksStr' is not initialized:
../../../libvirt/src/qemu/qemu_tpm.c: In function ‘qemuExtTPMStart’:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘activePcrBanksStr’
may be used uninitialized in this function [-Werror=maybe-uninitialized]
28 | g_free (*pp);
|
On 11/4/21 6:25 PM, Daniel P. Berrangé wrote:
> On Thu, Nov 04, 2021 at 01:22:53PM +0100, Michal Privoznik wrote:
>> Alright, here's the deal: to enable tb-cache one has to use
>> '-accel tcg,tb-size=' which then conflicts with '-machine
>> accel=tcg'. But sure, we can use the old -accel in this
On 11/4/21 6:51 PM, Kashyap Chamarthy wrote:
> On Thu, Nov 04, 2021 at 01:22:53PM +0100, Michal Privoznik wrote:
>> Alright, here's the deal: to enable tb-cache one has to use
>> '-accel tcg,tb-size=' which then conflicts with '-machine
>> accel=tcg'. But sure, we can use the old -accel in this
On 11/3/21 6:04 PM, Stefan Berger wrote:
> Extend the TPM backend XML with a node 'active_pcr_banks' that allows a
> user to specify the PCR banks to activate before starting a VM. Valid
> choices for PCR banks are sha1, sha256, sha384 and sha512. When the XML
> node is provided, the set of active
On 11/3/21 6:04 PM, Stefan Berger wrote:
> Move the code that adds encryption options for the swtpm_setup command
> line into its own function.
>
> Signed-off-by: Stefan Berger
> ---
> src/qemu/qemu_tpm.c | 54 +++--
> 1 file changed, 37 insertions(+), 17
On 11/4/21 7:54 PM, Jiri Denemark wrote:
> The return value was not properly checked in the code for input type
> evdev.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_command.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
Reviewed-by: Michal Privoznik
Michal
On 11/4/21 7:53 PM, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/util/virnetdevopenvswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Michal Privoznik
Michal
On Thu, Nov 04, 2021 at 06:16:19PM +, Daniel P. Berrangé wrote:
> On Thu, Nov 04, 2021 at 07:08:53PM +0100, Kashyap Chamarthy wrote:
> > On Thu, Nov 04, 2021 at 01:22:52PM +0100, Michal Privoznik wrote:
> > > It may come handy to be able to tweak TCG options, in this
> > > specific case the
On 11/4/21 7:54 PM, Jiri Denemark wrote:
> It won't cause any harm as cpus is NULL when we pass a negative ncpus,
> but doing so when the function expects unsigned value is not right.
>
> Signed-off-by: Jiri Denemark
> ---
> src/conf/capabilities.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
50 matches
Mail list logo
