Re: [libvirt PATCH] qemu: support multiqueue for vdpa net device

On 3/2/22 3:30 AM, Martin Kletzander wrote: On Tue, Mar 01, 2022 at 05:21:37PM -0600, Jonathon Jongsma wrote: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024406 Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c    | 11 ++ src/qemu/qemu_domain.c  

Re: [PATCH] deprecation: x86 default machine types

On 3/2/22 18:42, Daniel P. Berrangé wrote: Overall I'm just not seeing enough benefit to justify the disruption we'll cause by making this change to existing system emulator binaries. I agree. Paolo

ANNOUNCE: virt-manager 4.0.0 released

I'm happy to announce the release of virt-manager 4.0.0! The release can be downloaded from: http://virt-manager.org/download/ Some notable defaults changes: * virt-install: missing --os-variant/--osinfo is now a hard error in most cases. If you weren't specifying a value, or getting one from

Re: [PATCH] deprecation: x86 default machine types

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Mar 01, 2022 at 07:54:32PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Declare the intent to require a machine type to be specified on x86 > > system emulation. > > > > Signed-off-by: Dr. David

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 05:22:07PM +0100, Erik Skultety wrote: > > that can be used by the local sysadmin to define such a policy. > > true, but I suppose from upstream's perspective it can already be handled > using > gitlab tags only, so it feels redundant to handle the same on multiple places.

Re: [PATCH] deprecation: x86 default machine types

On Tue, Mar 01, 2022 at 07:54:32PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Declare the intent to require a machine type to be specified on x86 > system emulation. > > Signed-off-by: Dr. David Alan Gilbert > --- > docs/about/deprecated.rst | 8 >

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 05:18:26PM +0100, Erik Skultety wrote: > On Wed, Mar 02, 2022 at 04:42:21PM +0100, Jiri Denemark wrote: > > On Wed, Mar 02, 2022 at 09:43:24 +, Daniel P. Berrangé wrote: > > > On Wed, Mar 02, 2022 at 08:42:30AM +0100, Erik Skultety wrote: > > > > ... > > > Ultimately

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

... > > > I could easily see the instance of libvirt-gitlab-executor running on > > > hardware owned and operated by Red Hat returning a failure if a job > > > submitted to it comes with DISTRO=debian-11. > > > > libvirt-gitlab-executor is supposed to be system owner agnostic, I'd even > > like

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 04:42:21PM +0100, Jiri Denemark wrote: > On Wed, Mar 02, 2022 at 09:43:24 +, Daniel P. Berrangé wrote: > > On Wed, Mar 02, 2022 at 08:42:30AM +0100, Erik Skultety wrote: > > > ... > > Ultimately when we switch to using merge requests, the integration tests > > should be

Re: [PATCH] libxl: Turn on user aliases

On 3/2/22 3:29 AM, Peter Krempa wrote: On Tue, Mar 01, 2022 at 09:40:30 -0700, Jim Fehlig wrote: On 2/17/22 04:56, Michal Privoznik wrote: When I implemented user aliases I've invented this virDomainDefFeatures flag so that individual drivers can signal support for user provided aliases. The

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 03:52:49PM +0100, Erik Skultety wrote: > On Wed, Mar 02, 2022 at 06:27:04AM -0800, Andrea Bolognani wrote: > > I don't think we can expect integration tests to be merged at the > > same time as a feature when new APIs are involved. If tests are > > written in Python, then

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 09:43:24 +, Daniel P. Berrangé wrote: > On Wed, Mar 02, 2022 at 08:42:30AM +0100, Erik Skultety wrote: > > ... > Ultimately when we switch to using merge requests, the integration tests > should be run as a gating job, triggered from the merge train when the > code gets

Re: [PATCH 00/23] virsh: various small cleanups

On a Wednesday in 2022, Peter Krempa wrote: A collection of mostly small patches [...] Peter Krempa (23): virsh: cmdBlockcopy: Use virXMLFormatElement virsh: cmdStart: Rewrite ternary operator use to standard if conditions virsh: doSave: Use if-else instead of ternary operator virsh:

Re: [PATCH 13/23] virshGetOneDisplay: Automaticaly free extracted data

On a Wednesday in 2022, Peter Krempa wrote: Use automatic memory freeing for the temporary variables hodling the *holding data extracted from the XML. The code in this function was originally extracted from a loop so we can also drop pre-clearing of the pointers. Signed-off-by: Peter

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 06:27:04AM -0800, Andrea Bolognani wrote: > On Wed, Mar 02, 2022 at 01:11:04PM +0100, Erik Skultety wrote: > > > > I gave this more thought. What you suggest is viable, but the following > > > > is worth > > > > considering if we go with your proposal: > > > > > > > > -

Re: [PATCH 09/23] virsh: Move 'cmdEvent' and all of it's machinery to virsh-domain-event.c

*its On a Wednesday in 2022, Peter Krempa wrote: 'cmdEvent' along with all the helper functions it needs is ~950 LOC. Move it out from virsh-domain.c to virsh-domain-event.c along with the completer function so that the new module doesn't have to expose any new types. Semantically this creates

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 01:11:04PM +0100, Erik Skultety wrote: > > > I gave this more thought. What you suggest is viable, but the following > > > is worth > > > considering if we go with your proposal: > > > > > > - libvirt-perl jobs build upstream libvirt first in order to build the > > >

[PATCH 04/23] virsh: cmdRestore: Use if-else instead of ternary operator

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 607eb973ac..732690ec44 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5313,6 +5313,7 @@

[PATCH 06/23] virsh: Use NULLSTR_EMPTY instead of ternary operator

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 73f05ce7f9..25097627ac 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7601,7 +7601,7 @@

[PATCH 21/23] virsh: cmdDesc: Remove unneeded 'cleanup'

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 4d9722f400..7b4f8638a9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8336,7

[PATCH 23/23] virsh: cmdDesc: Fix logic when '-edit' is used along with 'desc' argument

Historically the use of the '-desc' multiple argument parameter was not forbidden toghether with '-edit', but use of both together has some unexpected behaviour. Specifically the editor is filled with the contents passed via '-desc' but if the user doesn't change the text in any way virsh will

[PATCH 20/23] virsh: cmdDesc: Automatically free memory

Decrease scope of variables and use automatic freeing. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dcf0f712f6..4d9722f400 100644 --- a/tools/virsh-domain.c +++

[PATCH 22/23] virsh: domain: Don't use ternaries inside vshPrint/vshError functions

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 50 ++-- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 7b4f8638a9..89ad45dbf0 100644 --- a/tools/virsh-domain.c +++

[PATCH 18/23] vsh: Add helper for auto-removing temporary file

The vsh helpers for user-editing of contents use temporary files. Introduce 'vshTempFile' type which automatically removes the file. Signed-off-by: Peter Krempa --- tools/vsh.c | 25 +++-- tools/vsh.h | 3 +++ 2 files changed, 22 insertions(+), 6 deletions(-) diff --git

[PATCH 17/23] virsh: cmdDesc: Use separate flags variable for getters

The getters have a different set of flags. Add a variable for the getter to avoid having to construct flags when calling the getter. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c

[PATCH 19/23] virsh: cmdDesc: Use 'vshTempFile' type to simplify cleanup

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index cac50dba51..dcf0f712f6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8335,7 +8335,6 @@

[PATCH 15/23] virshGetOneDisplay: Refactor formatting of URI params

Unconditionally format the start of the query ('?') and make delimiters ('&') part of the arguments. At the end we can trim off 1 char from the end of the buffer unconditionally. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 17 +++-- 1 file changed, 7 insertions(+), 10

[PATCH 16/23] virsh: cmdSchedinfo: Add separate variable for holding flags used for query

Instead of having two ad-hoc places which decide whether the original flags can be used add another variable specifically for flags used for query. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[PATCH 14/23] virshGetOneDisplay: Don't reuse 'xpath' variable

Add autofreed per-xpath variables to simplify the code. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 74 +++- 1 file changed, 25 insertions(+), 49 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[PATCH 13/23] virshGetOneDisplay: Automaticaly free extracted data

Use automatic memory freeing for the temporary variables hodling the data extracted from the XML. The code in this function was originally extracted from a loop so we can also drop pre-clearing of the pointers. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 49

[PATCH 12/23] virsh: cmdDomDisplay: Remove unneeded 'cleanup' label

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f82aa49745..7c06c3f80d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11864,17 +11864,17 @@

[PATCH 11/23] virsh: cmdDomDisplay: Extract loop body fetching display URIs into 'virshGetOneDisplay'

Separate the code so that the function is not as massive. Note that this is a minimal extraction which does not clean up the code meant for looping. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 352 ++- 1 file changed, 183 insertions(+), 169

[PATCH 07/23] virshEventPrint: Use automatic memory clearing

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 25097627ac..33984618eb 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -13166,13 +13166,13 @@ static

[PATCH 05/23] virsh: virshVcpuinfoPrintAffinity: Use if-else instead of ternary operator

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 732690ec44..73f05ce7f9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6721,8 +6721,12 @@

[PATCH 02/23] virsh: cmdStart: Rewrite ternary operator use to standard if conditions

Rewrite the invocation of the virDomainCreate(WithFiles/Flags) APIs based on the arguments into if-else instead of (nested) ternary operators. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git

[PATCH 10/23] virsh: cmdEvent: Rewrite questionable event registration

The code registering the event handlers in 'cmdEvent' had too many blocks of code conditional on whether just one event is being listened to or all events. The code can be greatly simplified by uniting the code paths and having only one branch when filling the list of events we want to listen

[PATCH 01/23] virsh: cmdBlockcopy: Use virXMLFormatElement

Rewrite the formatting of the block copy target xml using virXMLFormatElement. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 9b1b14cdc2..6f0c063438

[PATCH 09/23] virsh: Move 'cmdEvent' and all of it's machinery to virsh-domain-event.c

'cmdEvent' along with all the helper functions it needs is ~950 LOC. Move it out from virsh-domain.c to virsh-domain-event.c along with the completer function so that the new module doesn't have to expose any new types. Semantically this creates a new category in 'virsh help' but all other

[PATCH 08/23] virsh: Move 'virshDomainBlockJobToString' to virsh-util

The helper function is used in virshBlockJobInfo and also in the callbacks of cmdEvent. Upcoming patch is going to move out the event code into a helper so this needs to be in a shared place. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 19 --- tools/virsh-util.c |

[PATCH 00/23] virsh: various small cleanups

A collection of mostly small patches caused by the geopolitically induced attention span shortening. Peter Krempa (23): virsh: cmdBlockcopy: Use virXMLFormatElement virsh: cmdStart: Rewrite ternary operator use to standard if conditions virsh: doSave: Use if-else instead of ternary

[PATCH 03/23] virsh: doSave: Use if-else instead of ternary operator

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 4c90f40f86..607eb973ac 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -4213,6 +4213,7 @@

Re: [PATCH] qemu: segmentation fault in virtqemud executing qemuDomainUndefineFlags

On Wed, Mar 02, 2022 at 09:49:35 +0100, Michal Prívozník wrote: > On 3/2/22 00:21, Jim Fehlig wrote: > > On 3/1/22 10:47, Boris Fiuczynski wrote: > >> Commit 5adfb3472342741c443ac91dee0abb18b5a3d038 causes a segmentation > >> fault. > > Pushed now. I believe, this warrants maintenance release.

[PATCH] qemu: domainjob: Allow free if cb is not set in qemuDomainObjClearJob

We should allow resetting and freeing qemuDomainJobObj even if 'cb' attribute is not set. This is theoretical for now, but the attribute must not be always set in the future, so early return would create memory leaks. It is sufficient to check if 'cb' exists before dereferencing it in

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 09:43:24AM +, Daniel P. Berrangé wrote: ... > > > > > > No, I got that part. My question was whether > > > > > > other-project-pipeline: > > > trigger: > > > project: other-project > > > strategy: depend > > > > > > our-job: > > > needs: > >

Re: [PATCH v5 0/8] Implement detach device related APIs for test driver

On Mon, 2022-02-07 at 15:38 +0800, Luke Yue wrote: > diff to v4: > - Rebase to current master > > diff to v3: > - Add virDomainDeviceDefOperationsCallbacks to xmlopt for de- > duplicating purpose > - Add virDomainDeviceTypeFlags for de-duplicating purpose > - Remove the memballoon helper function

Re: [PATCH 01/17] ci: Drop Ubuntu 1804

On Wed, Mar 02, 2022 at 09:12:55AM +0100, Peter Krempa wrote: > On Tue, Mar 01, 2022 at 17:46:44 +0100, Erik Skultety wrote: > > On Tue, Feb 15, 2022 at 02:47:44PM +0100, Peter Krempa wrote: > > > As of April 23 2022, Ubuntu 20.04 will be out for two years, which per > > > our platform support

Re: [libvirt PATCH 4/4] gitlab-ci: Introduce a new test 'integration' pipeline stage

On Wed, Mar 02, 2022 at 08:42:30AM +0100, Erik Skultety wrote: > ... > > > > > > +libvirt-perl-bindings: > > > > > + stage: bindings > > > > > + trigger: > > > > > +project: eskultety/libvirt-perl > > > > > +branch: multi-project-ci > > > > > +strategy: depend > > > > > + > > > > >

Re: [libvirt PATCH] qemu: support multiqueue for vdpa net device

On Tue, Mar 01, 2022 at 05:21:37PM -0600, Jonathon Jongsma wrote: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024406 Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c| 11 ++ src/qemu/qemu_domain.c| 3 +-

Re: [PATCH] qemu: segmentation fault in virtqemud executing qemuDomainUndefineFlags

On 3/2/22 00:21, Jim Fehlig wrote: > On 3/1/22 10:47, Boris Fiuczynski wrote: >> Commit 5adfb3472342741c443ac91dee0abb18b5a3d038 causes a segmentation >> fault. >> >> Stack trace of thread 664419: >>   #0  0x03ff62ec553c in qemuDomainUndefineFlags >> (dom=0x3ff6c002810, flags=) at >>

Re: [PATCH] cmdQemuMonitorCommandQMPWrap: Reset ignored errors from JSON parsing

On Tue, Mar 01, 2022 at 02:33:28PM +0100, Peter Krempa wrote: 'cmdQemuMonitorCommandQMPWrap' is checking whether the user provided string is not valid JSON to avoid wrapping it. In cases where it's not JSON we ignore the error and add the wrapper. If the caller then reports a different

Re: [PATCH] libxl: Turn on user aliases

On Tue, Mar 01, 2022 at 09:40:30 -0700, Jim Fehlig wrote: > On 2/17/22 04:56, Michal Privoznik wrote: > > When I implemented user aliases I've invented this > > virDomainDefFeatures flag so that individual drivers can signal > > support for user provided aliases. The reasoning was that a > >

[libvirt PATCH][merged][trivial] Fix typo in NEWS

Signed-off-by: Tim Wiederhake --- NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 14c4aaf185..a5b6106bc2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -77,7 +77,7 @@ v8.1.0 (2022-03-01) * Remove unix sockets from filesystem when disabling a

Re: [PATCH 01/17] ci: Drop Ubuntu 1804

On Tue, Mar 01, 2022 at 17:46:44 +0100, Erik Skultety wrote: > On Tue, Feb 15, 2022 at 02:47:44PM +0100, Peter Krempa wrote: > > As of April 23 2022, Ubuntu 20.04 will be out for two years, which per > > our platform support policy means we no longer have to support > > Ubuntu 18.04. > > Would