When is the only usage of the qemu namespace the entire
section is mistakenly removed. Add check for use count.
Signed-off-by: Justin Gatzen
---
src/qemu/qemu_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Hi,
On Wed, Apr 20, 2022 at 09:07:49PM +0200, Victor Toso wrote:
> Gitlab run of this series (fails with codestyle of do-not-commit
> script).
Actually, I fixed before sending.
> https://gitlab.com/victortoso/libvirt/-/pipelines/520901763
Cheers,
Victor
signature.asc
Description: PGP
Removed the TODO as we can rely to the serialize_typedef() the job to
report missing comments.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 19e897b1ba..ddc2fff7af
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain-checkpoint.h | 34 +-
include/libvirt/libvirt-domain-snapshot.h | 40 +-
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
A throw away script to validate that the generated XML has the
correct versions. It checks if $keyword is present in $git_tag and
also in the $next_git_tag but not in the $previous_git_tag.
Takes almost a minute to run, in my computer.
| python3 ./scripts/version-quest.py -i ./include/ -d
This patch adds 'version' parameter to generated XML API for functions
and functypes.
The 'version' metadata has been added with e0e0bf6628 by parsing .syms
files. This commit does not override that but it will warn if there is
not 'Since' metadata with new additions.
There is not clear benefit
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 3 ++
src/admin/libvirt-admin.c | 93 +
2 files
scripts/apibuild.py did not consider exporting external variable's
comments into the XML API. This commits fixes that.
Noe that the way that CParser is designed, it is currently possible to
lose a parsed comment when parsing other fields as self.comment in
several places. I've added a comment to
So we can use for comments that are being hold in helper variables.
Signed-off-by: Victor Toso
---
scripts/apibuild.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index ec10931151..151eba37e6 100755
---
This patch adds 'version' parameter to the generated XML API for
macros
It'll require, for new additions, to add a comment with the version
that the macro was added. An example bellow of code diff and
the change in the generated XML.
Note that the Since tag is removed from the comment as there
This patch adds 'version' parameter to the generated XML API for
typedefs
It'll require, for new additions, to add a comment with the version
that the typedef value was added. An example bellow of code diff and
the change in the generated XML.
Note that the Since tag is removed from the comment
This patch adds 'version' parameter to the generated XML API for
enums.
It'll require, for new additions, to add a comment with the version
that the enum value was added.
Note that the Since tag is removed from the comment as there is a
proper field for it in the XML.
Signed-off-by: Victor Toso
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
src/libvirt-lxc.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 24
1 file changed, 24 insertions(+)
diff --git
Similarly to previous commits but with the targeting libvirt-common
in a batch.
Either create or append to existing docstring, the version (git tag)
that a given typedef, enum value, macro or function was introduced
in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-storage.h | 49 +++
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git
This commit is similar to "docs: Fix generated documentation of
virConnectListAllNodeDeviceFlags", check it out for more info.
Using git diff --word-diff to show the fixed output xml (redacted).
-]
{+type='virStorageVolInfoFlags' version='3.0.0' info='Return the physical
size in
Either create or append to existing docstring, the version (git tag)
that a given typedef was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 18 ++
1 file changed, 18 insertions(+)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given function was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 3 +++
src/libvirt-qemu.c | 18 ++
2 files changed, 21
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 60 +
1 file changed, 60 insertions(+)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-admin.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Either create or append to existing docstring, the version (git tag)
that a given macro was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-domain.h | 663 +-
include/libvirt/libvirt-host.h| 123 ++
Either create or append to existing docstring, the version (git tag)
that a given enum value was introduced in the format:
Since: v1.2.3
Signed-off-by: Victor Toso
---
include/libvirt/libvirt-qemu.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
virConnectAuthPtrDefault is the only variable that we export and
with the documentation being at the C file, it makes harder to find
it.
With this patch, the documentation of this variable can be found by
those who look at the header file for guidance plus, it will also be
included in the XML
scripts/apibuild.py does not handle well enum's with comments
between values. The outcome depends on whether the enum value has
its own docstring or not and if there is spaces between the enum
values or not.
Either way, virConnectListAllNodeDeviceFlags documentation is
explicit that this enum is
It doesn't need to fail the test if a reentrant function is found in
a comment.
Fixes:
| ...
| prohibit_nonreentrant
| libvirt/ci/helper:33:default=os.getlogin(), # exempt from
syntax-check
| libvirt/include/libvirt/libvirt-storage.h:223:
VIR_STORAGE_VOL_WIPE_ALG_PFITZNER7 =
We should allow strings (not the functions) in the format of
"virDomainFree" and friends.
This fixes an error in latter commit "scripts: apibuild: parse
'Since' for functions" as it uses this function names as keys
in a dictionary.
Fixes:
| ...
| prohibit_virXXXFree
|
Hi,
Here it comes, version 3.
v1: https://listman.redhat.com/archives/libvir-list/2022-April/229881.html
v2: https://listman.redhat.com/archives/libvir-list/2022-April/230097.html
In this version, I have:
- dropped the changes to .sym files (Peter, Daniel)
- improved commit log:
binj1uIU4i9EZ.bin
Description: Binary data
On 4/14/22 16:44, Michal Privoznik wrote:
> The point of qemu_processpriv.h file is to allow a small subset
> of functions to be called from test suite but not elsewhere. This
> is implemented by requiring everybody that includes the file to
> define a macro. If not done so, an error is printed at
On Wed, Apr 20, 2022 at 02:24:39PM +0200, Claudio Fontana wrote:
> Hi,
>
> I noticed that in the virThread API return values from threads are explicitly
> excluded from the API.
>
> The "virThreadHelper" sits in the middle between the caller of
> virThreadCreate and pthread, making it
On 4/20/22 14:24, Claudio Fontana wrote:
> Hi,
>
> I noticed that in the virThread API return values from threads are explicitly
> excluded from the API.
>
> The "virThreadHelper" sits in the middle between the caller of
> virThreadCreate and pthread, making it impossible to return a value
On Wed, Apr 20, 2022 at 02:33:19PM +0200, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 14:24:39 +0200, Claudio Fontana wrote:
> > Hi,
> >
> > I noticed that in the virThread API return values from threads are
> > explicitly excluded from the API.
> >
> > The "virThreadHelper" sits in the
On Fri, Apr 08, 2022 at 10:48:44 -0700, Rohit Kumar wrote:
> Currently, libvirt allows only local filepaths to specify
> a NVRAM disk. Since, VMs can migrate across hosts, so making
Note that this is not strictly needed for migration to work. In fact
qemu migratest he contents of the nvram inside
On Wed, 20 Apr 2022 14:13:00 +0200
Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 14:00:52 +0200, Igor Mammedov wrote:
> > On Wed, 20 Apr 2022 12:21:03 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > > > On Wed, 20 Apr 2022
On Wed, Apr 20, 2022 at 14:24:39 +0200, Claudio Fontana wrote:
> Hi,
>
> I noticed that in the virThread API return values from threads are explicitly
> excluded from the API.
>
> The "virThreadHelper" sits in the middle between the caller of
> virThreadCreate and pthread, making it impossible
Hi,
I noticed that in the virThread API return values from threads are explicitly
excluded from the API.
The "virThreadHelper" sits in the middle between the caller of virThreadCreate
and pthread, making it impossible to return a value from the thread,
to check after joining the thread.
I'd
On Wed, Apr 20, 2022 at 02:00:52PM +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 12:21:03 +0100
> Daniel P. Berrangé wrote:
>
> > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > > On Wed, 20 Apr 2022 13:02:12 +0200
> > > Peter Krempa wrote:
> > >
> > > > Few minor
On Wed, Apr 20, 2022 at 14:00:52 +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 12:21:03 +0100
> Daniel P. Berrangé wrote:
>
> > On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > > On Wed, 20 Apr 2022 13:02:12 +0200
> > > Peter Krempa wrote:
> > >
> > > > Few minor
On Wed, 20 Apr 2022 12:21:03 +0100
Daniel P. Berrangé wrote:
> On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> > On Wed, 20 Apr 2022 13:02:12 +0200
> > Peter Krempa wrote:
> >
> > > Few minor changes in qemu since the last update:
> > > - PIIX4_PM gained
On Wed, Apr 20, 2022 at 16:52:14 +0530, Ani Sinha wrote:
> On Wed, Apr 20, 2022 at 4:46 PM Igor Mammedov wrote:
> >
> > On Wed, 20 Apr 2022 13:02:12 +0200
> > Peter Krempa wrote:
> >
> > > Few minor changes in qemu since the last update:
> > > - PIIX4_PM gained 'x-not-migrate-acpi-index'
On Wed, Apr 20, 2022 at 13:15:43 +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa wrote:
>
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>
> do you do this for just for every new property?
>
On Wed, Apr 20, 2022 at 09:52:34 +0100, Richard W.M. Jones wrote:
> On Wed, Apr 20, 2022 at 09:36:29AM +0200, Peter Krempa wrote:
> > I'll post patches to address that, but the question is whether we want
> > to bother with actually supporting the password authentication or not,
> > because the
On Wed, Apr 20, 2022 at 4:46 PM Igor Mammedov wrote:
>
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa wrote:
>
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>
> do you do this for just for every new property?
> (nothing
On Wed, Apr 20, 2022 at 01:15:43PM +0200, Igor Mammedov wrote:
> On Wed, 20 Apr 2022 13:02:12 +0200
> Peter Krempa wrote:
>
> > Few minor changes in qemu since the last update:
> > - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>
> do you do this for just for every new property?
>
On Wed, 20 Apr 2022 13:02:12 +0200
Peter Krempa wrote:
> Few minor changes in qemu since the last update:
> - PIIX4_PM gained 'x-not-migrate-acpi-index' property
do you do this for just for every new property?
(nothing outside of QEMU needs to know about x-not-migrate-acpi-index,
unless one
Few minor changes in qemu since the last update:
- PIIX4_PM gained 'x-not-migrate-acpi-index' property
- 'cocoa' display and corresponding props (not present in this build)
Changes in build:
- dbus display driver re-enabled
- gtk display support re-disabled
- xen support
On Tue, Apr 19, 2022 at 7:28 PM Lena Voytek wrote:
Hi Lena,
the code is fine - I can confirm that this works well in Ubuntu 22.04 already.
But we should add a non-empty commit message here.
Just outline that this is needed when swtpm itself runs under a
profile called "swtpm".
And maybe
On Thu, Apr 14, 2022 at 02:46:38PM -0400, Tyler Fanelli wrote:
> On 4/11/22 10:57 AM, Cole Robinson wrote:
> > On 3/23/22 3:36 PM, Tyler Fanelli wrote:
> > > This an RFC discussing a new API, virDomainGetSevAttestationReport (along
> > > with a
> > > virsh command "domgetsevreport"), with initial
On Tue, Apr 19, 2022 at 03:26:45PM +0200, Peter Krempa wrote:
> On Thu, Apr 14, 2022 at 22:47:43 +0200, Victor Toso wrote:
> > Discover this mismatch with the docstring work.
> > scripts/apibuild.py complained.
> >
> > Signed-off-by: Victor Toso
> > ---
> > src/admin/libvirt_admin_public.syms |
On Wed, Apr 20, 2022 at 09:36:29AM +0200, Peter Krempa wrote:
> I'll post patches to address that, but the question is whether we want
> to bother with actually supporting the password authentication or not,
> because the simpler approach to fixing the bug is to simply allow it.
Did you mean:
On Tue, Apr 19, 2022 at 15:00:58 -0500, Jonathon Jongsma wrote:
> On 4/19/22 12:31 PM, Richard W.M. Jones wrote:
> > On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote:
> > > Well, As far as I can tell, there is no valid XML for exercising
> > > http auth. The schema for http(s)
On Tue, Apr 19, 2022 at 22:30:51 +0100, Richard W.M. Jones wrote:
> On Tue, Apr 19, 2022 at 03:00:58PM -0500, Jonathon Jongsma wrote:
> > On 4/19/22 12:31 PM, Richard W.M. Jones wrote:
[..]
> > >Now actual support for protocol='ssh' (as in, the main drive, not only
> > >in the backing chain),
56 matches
Mail list logo
