On 4/26/22 08:13, Daniel P. Berrangé wrote:
The following changes since commit a1755db71e34df016ffc10aa0727360aae2c6036:
Merge tag 'pull-block-2022-04-25' of https://gitlab.com/hreitz/qemu into
staging (2022-04-25 13:35:41 -0700)
are available in the Git repository at:
On Tue, 26 Apr 2022 13:42:17 -0300
Jason Gunthorpe wrote:
> On Tue, Apr 26, 2022 at 10:21:59AM -0600, Alex Williamson wrote:
> > We also need to be able to advise libvirt as to how each iommufd object
> > or user of that object factors into the VM locked memory requirement.
> > When used by
On 4/26/22 6:47 PM, Claudio Fontana wrote:
> This is the multifd save prototype in its first semi-functional state,
> now with both save and restore minimally functional.
>
> Still as mentioned before, likely there are quite a few rough edges,
>
> let me know what you think about this possible
On 4/26/22 6:47 PM, Claudio Fontana wrote:
> For the save direction, this helper listens on a unix socket
> which QEMU connects to for multifd migration to files.
>
> For the restore direction, this helper connects to a unix socket
> QEMU listens at for multifd migration from files.
>
> The file
add arguments to runio to allow read/write from/to arbitrary
file descriptors, as opposed to just stdin and stdout.
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 2 +-
src/util/runio.c| 10 +-
src/util/runio.h| 17 -
3 files changed, 22 insertions(+),
use multifd to restore parallel saves.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_driver.c| 10 -
src/qemu/qemu_migration.c | 2 +-
src/qemu/qemu_migration.h | 6 +++
src/qemu/qemu_saveimage.c | 94 ++-
src/qemu/qemu_saveimage.h | 9 +++-
5
where it can be reused by other helpers.
No changes other than the move.
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 178 +--
src/util/meson.build | 2 +
src/util/runio.c | 214 +++
src/util/runio.h
Signed-off-by: Claudio Fontana
---
docs/manpages/virsh.rst | 11 +-
tools/virsh-domain.c| 47 ++---
2 files changed, 49 insertions(+), 9 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 2bce701057..21bfc8b16b
The distinction on whether to wait for the migration completion
or not was made on the async job type,
but with the future addition of multifd migration from files,
we need a way to avoid waiting, so we can prepare multifd
migration parameters before starting the transfers.
Adapt all callers.
use zstd which is the only really interesting one.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_capabilities.c | 4 +++
src/qemu/qemu_capabilities.h | 3 ++
src/qemu/qemu_migration.c| 6
src/qemu/qemu_migration_params.c | 49
For the save direction, this helper listens on a unix socket
which QEMU connects to for multifd migration to files.
For the restore direction, this helper connects to a unix socket
QEMU listens at for multifd migration from files.
The file descriptors are passed as command line parameters.
add new API in order to be able to extend parameters to the domain
restore operation. We will use it to fit the existing arguments of
VirDomainRestoreFlags, and then add parallel restore functionality.
Signed-off-by: Claudio Fontana
---
include/libvirt/libvirt-domain.h | 4 +++
This is the multifd save prototype in its first semi-functional state,
now with both save and restore minimally functional.
Still as mentioned before, likely there are quite a few rough edges,
let me know what you think about this possible option.
changes from v2 are many, mainly:
* added
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 131 +---
1 file changed, 75 insertions(+), 56 deletions(-)
diff --git a/src/util/iohelper.c b/src/util/iohelper.c
index c13746a547..1584321839 100644
--- a/src/util/iohelper.c
+++
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_driver.c | 53 --
1 file changed, 46 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c702376a4a..9f5ae687e8 100644
--- a/src/qemu/qemu_driver.c
+++
implement a function similar to qemuMigrationSrcToFile
that migrates to multiple files using QEMU multifd.
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_capabilities.c | 1 +
src/qemu/qemu_migration.c| 129 ---
src/qemu/qemu_migration.h| 7
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_saveimage.c | 130 --
src/qemu/qemu_saveimage.h | 11
2 files changed, 137 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index 6af256aabe..fbeb355272
add new API in order to be able to extend parameters to the domain
save operation. We will use it to fit the existing arguments of
VirDomainSaveFlags, and then add parallel saves functionality.
Signed-off-by: Claudio Fontana
---
include/libvirt/libvirt-domain.h | 9 ++
Signed-off-by: Claudio Fontana
---
docs/manpages/virsh.rst | 23 ++-
tools/virsh-domain.c| 49 +
2 files changed, 57 insertions(+), 15 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index
Signed-off-by: Claudio Fontana
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 17 -
src/remote_protocol-structs | 9 +
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index
use this data type to encapsulate the pathname,
file descriptor, wrapper, and need to unlink.
Adapt qemuSaveImageCreate and qemuSaveImageOpen to use a
virQEMUSaveFd instead of a plain file descriptor.
This makes management of wrapper, need_unlink etc
much easier.
Signed-off-by: Claudio Fontana
Signed-off-by: Claudio Fontana
---
src/qemu/qemu_driver.c| 66 ---
src/qemu/qemu_saveimage.c | 2 ++
src/qemu/qemu_saveimage.h | 1 +
src/qemu/qemu_snapshot.c | 2 +-
4 files changed, 66 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Claudio Fontana
---
src/remote/remote_driver.c | 1 +
src/remote/remote_protocol.x | 14 +-
src/remote_protocol-structs | 8
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index
this is in preparation for a minor refactoring of the copy
function itself out of runIO().
Signed-off-by: Claudio Fontana
---
src/util/iohelper.c | 95 +
1 file changed, 53 insertions(+), 42 deletions(-)
diff --git a/src/util/iohelper.c
Hi,
On Tue, Apr 26, 2022 at 04:06:08PM +, Andrea Bolognani wrote:
> On Fri, Apr 22, 2022 at 09:23:25PM +0200, Victor Toso wrote:
> > - For exported version of functions, the syms file are the source of
> > truth apart from 4 functions (Peter)
> >
On Tue, 26 Apr 2022 08:37:41 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Monday, April 25, 2022 10:38 PM
> >
> > On Mon, 25 Apr 2022 11:10:14 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Fri, Apr 22, 2022 at 04:09:43PM -0600, Alex Williamson wrote:
> > > > [Cc
On Fri, Apr 22, 2022 at 09:23:25PM +0200, Victor Toso wrote:
> - For exported version of functions, the syms file are the source of
> truth apart from 4 functions (Peter)
> https://listman.redhat.com/archives/libvir-list/2022-April/230236.html
>
> - Variable's comments are now properly
It belongs to the comment for VIR_DOMAIN_AFFECT_CONFIG, not to
the unrelated one immediately after it.
Fixes: 807cdbf75976f88e8a23b26951f263029cc9e5f4
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
include/libvirt/libvirt-domain.h | 4 ++--
1 file changed, 2 insertions(+), 2
On Fri, Apr 22, 2022 at 09:23:44PM +0200, Victor Toso wrote:
> +def cleanup_code_comment(self, comment: str, type_name="") -> str:
> if not isinstance(comment, str) or comment == "":
> return ""
>
> lines = comment.splitlines(True)
> +
> +# If type_name
On Fri, Apr 22, 2022 at 09:23:42PM +0200, Victor Toso wrote:
> +# The version in the .sym file might differnt from
> +# the real version that the function was introduced.
> +# This dict's value is the correct version, as it should
> +# be in the docstrings.
Typo "differnt". I'll fix it before
On Fri, Apr 22, 2022 at 09:23:38PM +0200, Victor Toso wrote:
> This patch adds 'version' parameter to the generated XML API for
> enums.
>
> It'll require, for new additions, to add a comment with the version
> that the enum value was added.
>
> Note that the Since tag is removed from the comment
The 'absolute' clock offset type has a 'start' attribute which is an
unix epoch timestamp to which the hardware clock is always set at start
of the VM.
This is useful if some VM needs to be kept set to an arbitrary time for
e.g. testing or working around broken software.
Signed-off-by: Peter
Add support for the mode and add the corresponding qemuxml2argv test
case.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 10 +-
.../clock-absolute.x86_64-latest.args | 36 +++
tests/qemuxml2argvtest.c | 1 +
3
Based on
https://listman.redhat.com/archives/libvirt-users/2022-April/013537.html
Looked as a very simple addition.
Peter Krempa (2):
conf: Introduce 'absolute' clock offset
qemu: Implement 'absolute' clock offset mode
docs/formatdomain.rst | 4 ++
The previous commit updated the repo lockdown config to the new
format:
commit 9b89cdb2a5064a87b8a7172fa1748d46aa37a9df
Author: Alex Bennée
Date: Mon Oct 4 16:43:08 2021 +0100
.github: move repo lockdown to the v2 configuration
Unfortunately the config key names used were wrong,
There was an off-by-1 in the qcode conversion array bounds
check.
Fixes: e709a61a8fe1076a487376fd657544418a38ba06
Reported-by: Peter Maydell
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
hw/char/escc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The following changes since commit a1755db71e34df016ffc10aa0727360aae2c6036:
Merge tag 'pull-block-2022-04-25' of https://gitlab.com/hreitz/qemu into
staging (2022-04-25 13:35:41 -0700)
are available in the Git repository at:
https://gitlab.com/berrange/qemu tags/misc-next-pull-request
Users requiring FIPS support must build QEMU with either the libgcrypt
or gnutls libraries as the crytography backend.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
docs/about/deprecated.rst | 12
docs/about/removed-features.rst | 11 +++
A leak of the GSource was introduced in
commit 87a43a907f0ad4897a28ad7c216bc70f37270b93
Author: Michal Prívozník
Date: Fri Jan 28 18:42:45 2022 +0100
lib: Use g_clear_pointer() more
As it mistakenly replaced the g_vir_source_unref call with a second
call to g_source_destroy.
On Tue, Apr 26, 2022 at 16:17:42 +0530, Rohit Kumar wrote:
>
> On 21/04/22 8:39 pm, Peter Krempa wrote:
> > On Fri, Apr 08, 2022 at 10:48:50 -0700, Rohit Kumar wrote:
> > > This patch adds unit test for network backed NVRAM
> > >
> > > Example:
> > >
> > >
> > >
> > >
> > >
> > >
On Tue, Apr 26, 2022 at 16:15:45 +0530, Rohit Kumar wrote:
>
> On 21/04/22 8:35 pm, Peter Krempa wrote:
> > On Fri, Apr 08, 2022 at 10:48:49 -0700, Rohit Kumar wrote:
> > > Updating the doc as now NVRAM can be remote as well.
> > >
> > > Signed-off-by: Prerna Saxena
> > > Signed-off-by: Florian
On Tue, Apr 26, 2022 at 12:07:40PM +, Andrea Bolognani wrote:
> On Tue, Apr 26, 2022 at 10:12:17AM +0100, Daniel P. Berrangé wrote:
> > We don't have access to the 'testlog.txt' file, so we need meson to
> > print the failures for any broken tests directly.
> >
> > Signed-off-by: Daniel P.
On Tue, Apr 26, 2022 at 16:17:05 +0530, Rohit Kumar wrote:
>
> On 21/04/22 8:31 pm, Peter Krempa wrote:
> > On Fri, Apr 08, 2022 at 10:48:48 -0700, Rohit Kumar wrote:
> > > This patch updates NVRAM element schema to support
> > > network backed NVRAM. It introduces 'type' attribute
> > > to NVRAM
On Tue, Apr 26, 2022 at 16:15:06 +0530, Rohit Kumar wrote:
>
> On 21/04/22 8:29 pm, Peter Krempa wrote:
> > On Fri, Apr 08, 2022 at 10:48:47 -0700, Rohit Kumar wrote:
> > > Moving diskSourceNetwork and diskSourceFile's Source definition
> > > under 'define' element, so that it will be easier to
On Tue, Apr 26, 2022 at 10:12:17AM +0100, Daniel P. Berrangé wrote:
> We don't have access to the 'testlog.txt' file, so we need meson to
> print the failures for any broken tests directly.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> ci/cirrus/build.yml | 2 +-
> 1 file changed, 1
On Tue, Apr 26, 2022 at 16:16:11 +0530, Rohit Kumar wrote:
>
> On 21/04/22 8:36 pm, Peter Krempa wrote:
> > On Thu, Apr 21, 2022 at 16:52:54 +0200, Peter Krempa wrote:
> > > On Fri, Apr 08, 2022 at 10:48:46 -0700, Rohit Kumar wrote:
> > > > Remote store NVRAM feature is being enabled only
> > > >
On 21/04/22 8:39 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:50 -0700, Rohit Kumar wrote:
This patch adds unit test for network backed NVRAM
Example:
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
---
On 21/04/22 8:31 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:48 -0700, Rohit Kumar wrote:
This patch updates NVRAM element schema to support
network backed NVRAM. It introduces 'type' attribute
to NVRAM element.
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
On 21/04/22 8:36 pm, Peter Krempa wrote:
On Thu, Apr 21, 2022 at 16:52:54 +0200, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:46 -0700, Rohit Kumar wrote:
Remote store NVRAM feature is being enabled only
if it supports 'blockdev' capability.
Signed-off-by: Prerna Saxena
Signed-off-by:
Thanks for reviewing the patches !
On 20/04/22 6:18 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:44 -0700, Rohit Kumar wrote:
Currently, libvirt allows only local filepaths to specify
a NVRAM disk. Since, VMs can migrate across hosts, so making
Note that this is not strictly needed
On 21/04/22 8:35 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:49 -0700, Rohit Kumar wrote:
Updating the doc as now NVRAM can be remote as well.
Signed-off-by: Prerna Saxena
Signed-off-by: Florian Schmidt
Signed-off-by: Rohit Kumar
---
docs/formatdomain.rst | 43
On 21/04/22 8:29 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:47 -0700, Rohit Kumar wrote:
Moving diskSourceNetwork and diskSourceFile's Source definition
under 'define' element, so that it will be easier to reuse it
at multiple places.
Signed-off-by: Prerna Saxena
Signed-off-by:
On 21/04/22 8:20 pm, Peter Krempa wrote:
On Fri, Apr 08, 2022 at 10:48:45 -0700, Rohit Kumar wrote:
This patch introduces the logic to support remote NVRAM and
adds 'type' attribute to nvram element.
Sample XML with new annotation:
or
[1]
Signed-off-by: Prerna
apibuild.py mistakes these as being a continuation of the
previous comment.
Signed-off-by: Andrea Bolognani
---
Pushed as trivial-ish and necessary to unblock Victor's work.
include/libvirt/libvirt-domain-snapshot.h | 2 --
include/libvirt/libvirt-domain.h | 2 --
2 files changed, 4
Signed-off-by: Andrea Bolognani
---
Pushed as trivial
include/libvirt/libvirt-domain.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 0fa4509b73..3dfcd14b9c 100644
---
On Fri, Apr 22, 2022 at 09:23:25PM +0200, Victor Toso wrote:
> - I have set the virAdm exported types to be minimum = v2.0.0. This is
> for all related types of libvirt-admin:
> * 08/19 for enums;
> * 09/19 for macros;
> * 10/19 for typedefs;
> * 12/19 for functions;
I have now pushed
On Fri, Apr 22, 2022 at 09:23:32PM +0200, Victor Toso wrote:
> VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS = (1 << 0), /* List all descendants,
> not just children,
> when
> listing a
On Fri, Apr 22, 2022 at 09:23:25PM +0200, Victor Toso wrote:
> - The first 4 patches are related to wrong versions introduced in
> https://gitlab.com/libvirt/libvirt/-/commit/034432e47b
> Each commit log points out the error I did in v3 and fixes it. If you
> rather squash them, feel free.
We don't have access to the 'testlog.txt' file, so we need meson to
print the failures for any broken tests directly.
Signed-off-by: Daniel P. Berrangé
---
The CI pipeline for macOS started failing a few days ago. It was not
triggered by any commit, as the pipeline immediately preceeding the
From: 王鹏钧10288409 <10288409@zte.in...@lin-184c297bae7.zte.com.cn>
Virsh shutdown is executed firstly, virsh destroy is executed later,
and VM is recreated again. In this process, due to will delet Domain
object about the new VM in processMonitorEOFEvent(), which
virDomainObjListRemove is called
On Mon, Apr 25, 2022 at 10:21:44AM +0200, Martin Kletzander wrote:
> One thing I am not sure about is whether to keep the aliases of ac97 and
> es1370 in the qdev_alias_table.
>
> Signed-off-by: Martin Kletzander
> ---
> docs/about/deprecated.rst | 9 -
>
On Mon, Apr 25, 2022 at 10:21:43AM +0200, Martin Kletzander wrote:
> I wanted to deal with https://bugzilla.redhat.com/2043498 and I got a
> suggesstion that removing deprecated features could actually make it
> easier to propagate the error. In the end (last patch) it turns out the
> error is
> From: Alex Williamson
> Sent: Monday, April 25, 2022 10:38 PM
>
> On Mon, 25 Apr 2022 11:10:14 +0100
> Daniel P. Berrangé wrote:
>
> > On Fri, Apr 22, 2022 at 04:09:43PM -0600, Alex Williamson wrote:
> > > [Cc +libvirt folks]
> > >
> > > On Thu, 14 Apr 2022 03:46:52 -0700
> > > Yi Liu
Hi Alex,
On 4/23/22 12:09 AM, Alex Williamson wrote:
> [Cc +libvirt folks]
>
> On Thu, 14 Apr 2022 03:46:52 -0700
> Yi Liu wrote:
>
>> With the introduction of iommufd[1], the linux kernel provides a generic
>> interface for userspace drivers to propagate their DMA mappings to kernel
>> for
I have just tagged v8.3.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
65 matches
Mail list logo
