...
512
...
Signed-off-by: Lin Yang
---
docs/formatdomain.rst | 9 +++-
src/conf/domain_conf.c| 6 +++
src/conf/domain_conf.h| 1 +
src/conf/domain_validate.c| 16 ++
From: Haibin Huang
Extend hypervisor capabilities to include sgx feature. When available,
the hypervisor supports launching an VM with SGX on Intel platfrom.
The SGX feature tag privides additional details like section size and
sgx1 or sgx2.
Signed-off-by: Haibin Huang
---
From: Haibin Huang
the QMP capabilities:
{"return":
{
"sgx": true,
"section-size": 1024,
"flc": true
}
}
the domain capabilities:
yes
1
Signed-off-by: Haibin Huang
---
src/conf/domain_capabilities.c | 10 +++
src/conf/domain_capabilities.h | 5
According to the result parsing from xml, add the argument of
SGX EPC memory backend into QEMU command line:
#qemu-system-x86_64 \
.. \
-object memory-backend-epc,id=memepc0,size=64M,prealloc=on \
-object memory-backend-epc,id=memepc1,size=28M \
-machine
This patch series provides support for enabling Intel's Software
Guard Extensions (SGX) feature in guest VM.
Giving the SGX support in QEMU had been merged. Intel SGX is a
set of instructions that increases the security of application code
and data, giving them more protection from disclosure or
From: Haibin Huang
Signed-off-by: Haibin Huang
---
.../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_7.1.0.x86_64.xml| 1 +
.../caps_6.2.0.x86_64.replies | 22 +++
From: Haibin Huang
Generate the QMP command for query-sgx-capabilities and the command
return sgx capabilities from QMP.
{"execute":"query-sgx-capabilities"}
the right reply:
{"return":
{
"sgx": true,
"section-size": 197132288,
"flc": true
}
}
the error reply:
On 5/12/22 04:52, Andrea Bolognani wrote:
On Thu, May 05, 2022 at 05:26:14PM -0300, Daniel Henrique Barboza wrote:
+++ b/tests/qemuxml2argvtest.c
@@ -2209,6 +2209,17 @@ mymain(void)
QEMU_CAPS_DEVICE_SPAPR_VTY);
qemuTestSetHostCPU(, driver.hostarch, NULL);
+
On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> Ping.
>
> Hi Peter,
> can you please take a look on this v3 patchset ?
Yes, don't worry and please be patient. There are some intricacies that
are not properly handled by your series and rather than me using you as
a email operated
On a Tuesday in 2022, Peter Krempa wrote:
This series simplifies some aspects of close callbacks in preparation of
further refactors.
Peter Krempa (10):
virclosecallbacks.h: Reformat header to contemporary style
virObjectLockGuard: Require that returned value is used
qemuMigrationSrcBegin:
On a Tuesday in 2022, Peter Krempa wrote:
Originally the intention was to have one set of helpers but it turned
out to be too much hassle and too obscure semantics.
This series adds a new helper qemuFDPassDirect and simplifies the
internals greatly by using a distinct set of APIs.
Peter Krempa
On a Monday in 2022, Peter Krempa wrote:
Inside of the qemu driver source tree we had 3 text files describing
internals. We can promote them to kbase articles to make them more
accessible.
You can browse the converted files at:
On 17/05/2022 13.19, Markus Armbruster wrote:
Paolo Bonzini writes:
On 5/17/22 10:34, Thomas Huth wrote:
This remains, and that's fine. One step at time.
Not sure how we want to proceed with that in the long run, though
... IIRC clearly, Paolo once said that it doesn't really belong into
Remove the argument from the function prototypes and the callback
handler.
Signed-off-by: Peter Krempa
---
src/bhyve/bhyve_driver.c | 2 +-
src/bhyve/bhyve_process.c | 3 +--
src/hypervisor/virclosecallbacks.c | 5 ++---
src/hypervisor/virclosecallbacks.h | 6 ++
Similarly to the qemu driver if we store the immutable driver pointer in
the VM private data struct we don't have to questionably pass it through
opaque pointers to callbacks.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_domain.c | 4 +++-
src/lxc/lxc_domain.h | 1 +
2 files changed, 4
Access the 'driver' struct from the private data rather than the passed
opaque pointer in preparation to remove the opaque pointer.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_process.c
Access the 'driver' struct from the private data rather than the passed
opaque pointer in preparation to remove the opaque pointer.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_migration.c
Access the 'driver' struct from the private data rather than the passed
opaque pointer in preparation to remove the opaque pointer.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/lxc/lxc_process.c
Similarly to the qemu driver if we store the immutable driver pointer in
the VM private data struct we don't have to questionably pass it through
opaque pointers to callbacks.
Signed-off-by: Peter Krempa
---
src/bhyve/bhyve_domain.c | 8 ++--
src/bhyve/bhyve_domain.h | 2 ++
2 files
Access the 'driver' struct from the private data rather than the passed
opaque pointer in preparation to remove the opaque pointer.
Signed-off-by: Peter Krempa
---
src/bhyve/bhyve_process.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/bhyve/bhyve_process.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 25af291dc6..6b3815ac58 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@
The returned value is used to unlock the object, so all callers must
necessarily make use of the returned value.
Signed-off-by: Peter Krempa
---
src/util/virobject.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virobject.h b/src/util/virobject.h
index
Signed-off-by: Peter Krempa
---
src/hypervisor/virclosecallbacks.h | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/src/hypervisor/virclosecallbacks.h
b/src/hypervisor/virclosecallbacks.h
index 97be25b781..138e0eb689 100644
---
This series simplifies some aspects of close callbacks in preparation of
further refactors.
Peter Krempa (10):
virclosecallbacks.h: Reformat header to contemporary style
virObjectLockGuard: Require that returned value is used
qemuMigrationSrcBegin: Automatically free 'xml' variable on error
On Tue, May 17, 2022 at 11:07:18 +0200, Peter Krempa wrote:
> Originally I envisioned a common set of APIs for both FD passing
> approaches but it turns out they are not really compatible enough for it
> to make sense to use one set of APIs.
>
> As of such introduce a distinct set of APIs for the
On Tue, May 17, 2022 at 12:19:07PM +0200, Jiri Denemark wrote:
> On Tue, May 17, 2022 at 10:46:21 +0100, Daniel P. Berrangé wrote:
> > On Tue, May 17, 2022 at 02:34:00AM -0700, Andrea Bolognani wrote:
> > > On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote:
> > > > Hmm, so is this
On Tue, May 17, 2022 at 10:49:47AM +0100, Daniel P. Berrangé wrote:
> On Tue, May 17, 2022 at 02:23:45AM -0700, Andrea Bolognani wrote:
> > On Tue, May 17, 2022 at 11:12:47AM +0200, Peter Krempa wrote:
> > > On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
> > > > +# Before 0.60,
Paolo Bonzini writes:
> On 5/17/22 10:34, Thomas Huth wrote:
>>> This remains, and that's fine. One step at time.
>> Not sure how we want to proceed with that in the long run, though
>> ... IIRC clearly, Paolo once said that it doesn't really belong into
>> "-display" anyway and should be
On Tue, May 17, 2022 at 10:46:21 +0100, Daniel P. Berrangé wrote:
> On Tue, May 17, 2022 at 02:34:00AM -0700, Andrea Bolognani wrote:
> > On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote:
> > > On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote:
> > > > These managed to
On Tue, May 17, 2022 at 02:23:45AM -0700, Andrea Bolognani wrote:
> On Tue, May 17, 2022 at 11:12:47AM +0200, Peter Krempa wrote:
> > On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
> > > +# Before 0.60, meson would sometimes pass options to xgettext in the
> > > +# wrong order,
On 5/17/22 10:34, Thomas Huth wrote:
This remains, and that's fine. One step at time.
Not sure how we want to proceed with that in the long run, though ...
IIRC clearly, Paolo once said that it doesn't really belong into
"-display" anyway and should be handled with the separate "-vnc"
On Tue, May 17, 2022 at 02:34:00AM -0700, Andrea Bolognani wrote:
> On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote:
> > On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote:
> > > These managed to sneak in as part of ec02f5719a87, when the
> > > potfile was last refreshed,
On Tue, May 17, 2022 at 11:11:00AM +0200, Peter Krempa wrote:
> On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote:
> > These managed to sneak in as part of ec02f5719a87, when the
> > potfile was last refreshed, but are not supposed to be there.
> >
> > Signed-off-by: Andrea Bolognani
On Tue, May 17, 2022 at 11:12:47AM +0200, Peter Krempa wrote:
> On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
> > +# Before 0.60, meson would sometimes pass options to xgettext in the
> > +# wrong order, resulting in unwanted comments showing up in the
> > +# potfile after it was
On Tue, May 17, 2022 at 10:32:12 +0200, Andrea Bolognani wrote:
> We don't want comments to be present in the potfile, unless
> they're specifically aimed at translators.
>
> To achieve this, we pass the --add-comments=TRANSLATORS: option
> to xgettext. However, we also use the 'glib' preset,
On Tue, May 17, 2022 at 10:32:11 +0200, Andrea Bolognani wrote:
> These managed to sneak in as part of ec02f5719a87, when the
> potfile was last refreshed, but are not supposed to be there.
>
> Signed-off-by: Andrea Bolognani
> ---
> po/libvirt.pot | 216
On Tue, May 17, 2022 at 11:59:42 +0800, Fangge Jin wrote:
> Hi
>
> I'm testing this patch series, but it has conflict with latest code.
> Could you please rebase to latest code and provide a V2?
> Thanks.
You can fetch the original version including the proper base from
Jirka's gitlab. In the
Thomas Huth writes:
> On 12/05/2022 14.16, Markus Armbruster wrote:
[...]
>>> This introduces the new "DisplaySDL" QAPI struct that is used to hold
>>> the parameters that are unique to the SDL display. The only specific
>>> parameter is currently "grab-mod" which is modeled as a string, so
Originally I envisioned a common set of APIs for both FD passing
approaches but it turns out they are not really compatible enough for it
to make sense to use one set of APIs.
As of such introduce a distinct set of APIs for the 'direct' mode, which
will later be used to convert all places that
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 7 ---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 2 +-
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_slirp.c | 4 +---
5 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_command.c
When dealing with fdsets only we don't need to pass the FD first as we
now generate fdset name directly. Also there are no more caveats in
passing multiple FDs.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_fd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 +++-
src/qemu/qemu_domain.c| 2 +-
src/qemu/qemu_domain.h| 2 +-
src/qemu/qemu_hotplug.c | 4 ++--
src/qemu/qemu_interface.c | 8 ++--
tests/qemuxml2argvmock.c | 10 +++---
6 files changed, 12
This finishes the separation of the fdset and direct helpers. Remove
'qemuFDPassNewDirect' and all internals which were applicable only in
direct mode.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_fd.c | 116 -
1 file changed, 19 insertions(+), 97
The callers adding the FDs are validating them regardless so this check
was redundant.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_fd.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c
index 442f92df2f..fc9fecbb0e 100644
---
Now that the 'direct' mode was separated and thus we don't have any
possible error case we can stop returning any values and simplify
callers.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 18 +-
src/qemu/qemu_fd.c | 6 ++
src/qemu/qemu_fd.h | 2 +-
3
Originally the intention was to have one set of helpers but it turned
out to be too much hassle and too obscure semantics.
This series adds a new helper qemuFDPassDirect and simplifies the
internals greatly by using a distinct set of APIs.
Peter Krempa (9):
qemu: fd: Add a distinct set of APIs
Unix socket chardevs with FD passing need to use the direct mode so we
need to convert it to use qemuFDPassDirect.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 15 +--
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_hotplug.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 15 +--
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 2 +-
src/qemu/qemu_hotplug.c | 4 ++--
4 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
On 12/05/2022 14.16, Markus Armbruster wrote:
[...]> if (strstart(p, "sdl", )) {
+/*
+ * sdl DisplayType needs hand-crafted parser instead of
+ * parse_display_qapi() due to some options not in
+ * DisplayOptions, specifically:
+
Signed-off-by: Andrea Bolognani
---
po/LINGUAS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/po/LINGUAS b/po/LINGUAS
index 889ef80aba..35acd33a87 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -28,17 +28,17 @@ nl
or
pa
pl
-pt_BR
pt
+pt_BR
ru
-sr@latin
+si
sr
Make sure LINGUAS remains sorted correctly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index e7aa2444bf..e8aea29d64 100644
--- a/build-aux/syntax-check.mk
+++
Now that we have dropped prefixes from the file, it no longer
needs to go through configure_file() and we can use it directly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk| 6 +++---
po/{POTFILES.in => POTFILES} | 0
po/meson.build | 13 +
3
These managed to sneak in as part of ec02f5719a87, when the
potfile was last refreshed, but are not supposed to be there.
Signed-off-by: Andrea Bolognani
---
po/libvirt.pot | 216 -
1 file changed, 216 deletions(-)
diff --git a/po/libvirt.pot
Commit 8beb7fdd0e23 changed the handling of POTFILES so that it
could cope with files being located in either the source or build
directory: it did so by adding @SRCDIR@ and @BUILDDIR@
respectively at the beginning of each line, and then converting
them back to the actual values when generating
This is something that certainly made sense in the context of
gnulib, but we don't have a use for it.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
We don't want comments to be present in the potfile, unless
they're specifically aimed at translators.
To achieve this, we pass the --add-comments=TRANSLATORS: option
to xgettext. However, we also use the 'glib' preset, which
contains the --add-comments option.
This should work fine, as later
msgid ""
"*** BLURB HERE ***"
msgstr ""
Andrea Bolognani (7):
po: Drop unwanted comments from potfile
syntax-check: Introduce sc_pot_comments
po: Drop prefixes from POTFILES.in
po: Don't generate POTFILES
syntax-check: Don't exclude src/false.c from sc_po_check
po: Sort LINGUAS
Hi Peter,
I add error case like below. Is this error case same to you said. Thank you
very much!
diff --git a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies
b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.replies
index 8444825cb7..c52b7917e2 100644
---
58 matches
Mail list logo
