On Thu, May 26, 2022 at 04:23:44PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> > +++ b/ci/manifest.yml
> > @@ -157,7 +157,6 @@ targets:
> >- arch: x86_64
> >
> >- arch: mingw32
> > -allow-failure: true
>
> There must be
On Thu, May 26, 2022 at 04:01:45PM +0200, Andrea Bolognani wrote:
> Test pipeline:
>
> https://gitlab.com/abologna/libvirt/-/pipelines/548848259
>
> Only patches 1-5 should be pushed until the issues outlined in
Go ahead and push 1-5 ;).
Erik
On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> It's a stable distro, so we expect all jobs to succeed.
>
> Signed-off-by: Andrea Bolognani
> ---
> ci/gitlab/containers.yml | 2 +-
> ci/manifest.yml | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff
On Thu, May 26, 2022 at 04:01:49PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
On Thu, May 26, 2022 at 04:01:48PM +0200, Andrea Bolognani wrote:
> The target is intentionally not added to the integration tests
> at this time, because the corresponding VM template is not yet
> available on the runner. A later patch will take care of that.
>
> Signed-off-by: Andrea Bolognani
On Thu, May 26, 2022 at 03:07:52PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> > On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > > Please don't push this yet, because the integration tests would fail (as
> > > you
> > >
This requires publishing the RPMs as artifacts from the regular
build job.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/builds.yml | 4
ci/integration.yml | 16
ci/manifest.yml | 4
3 files changed, 24 insertions(+)
diff --git a/ci/gitlab/builds.yml
Signed-off-by: Andrea Bolognani
---
...gw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} | 2 +-
...gw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} | 2 +-
ci/gitlab/builds.yml | 6 +++---
ci/gitlab/containers.yml
Signed-off-by: Andrea Bolognani
---
ci/integration.yml | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ci/integration.yml b/ci/integration.yml
index 5b60b41e85..43f22813c9 100644
--- a/ci/integration.yml
+++ b/ci/integration.yml
@@ -49,24 +49,24 @@
Signed-off-by: Andrea Bolognani
Reviewed-by: Erik Skultety
---
ci/containers/fedora-34.Dockerfile | 109 -
ci/gitlab.yml | 20 --
ci/integration.yml | 16 -
ci/manifest.yml| 8 ---
4 files changed,
It's a stable distro, so we expect all jobs to succeed.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/containers.yml | 2 +-
ci/manifest.yml | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml
index
Notable changes:
* 'lcitool manifest' now generates GitLab CI rules spread
across a bunch of files;
* container images are built less frequently for the main
repository.
Signed-off-by: Andrea Bolognani
Reviewed-by: Erik Skultety
---
ci/gitlab.yml | 747
The target is intentionally not added to the integration tests
at this time, because the corresponding VM template is not yet
available on the runner. A later patch will take care of that.
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-36.Dockerfile | 108 +
Test pipeline:
https://gitlab.com/abologna/libvirt/-/pipelines/548848259
Only patches 1-5 should be pushed until the issues outlined in
https://listman.redhat.com/archives/libvir-list/2022-May/231851.html
have been addressed.
Changes from [v1]
* handle integration tests separately;
*
On Thu, 2022-05-26 at 14:01 +0200, Dario Faggioli wrote:
> Thoughts?
>
Oh, and there are even a couple of other (potential) use case, for
having an (even more!) fine grained control of core-scheduling.
So, right now, giving a virtual topology to a VM, pretty much only
makes sense if the VM has
There are some formatting problems with virDomainInputDefValidate().
Reformat it to our standards. Use this opportunity to move error
messages onto a single line.
Signed-off-by: Michal Privoznik
---
src/conf/domain_validate.c | 65 ++
1 file changed, 30
If input device has one of virtio* models set then it has to go
onto virtio bus. Introduce such check into the validator.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2081981
Signed-off-by: Michal Privoznik
---
src/conf/domain_validate.c | 21 +
1 file changed, 21
*** BLURB HERE ***
Michal Prívozník (2):
virDomainInputDefValidate: Reformat
virDomainInputDefValidate: Validate model
src/conf/domain_validate.c | 84 +++---
1 file changed, 50 insertions(+), 34 deletions(-)
--
2.35.1
On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > > Test pipeline:
> > >
> > > https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> >
On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > > Test pipeline:
> > >
> > > https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> >
On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > Test pipeline:
> >
> > https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> >
> > Matching libvirt-perl MR, needed because the integration tests
> >
On Mon, 2022-05-23 at 17:13 +0100, Daniel P. Berrangé wrote:
> On Mon, May 09, 2022 at 05:02:07PM +0200, Michal Privoznik wrote:
> In terms of defaults I'd very much like us to default to enabling
> core scheduling, so that we have a secure deployment out of the box.
> The only caveat is that this
The virDomainObj struct has @pid member where the domain's
hypervisor PID is stored (e.g. QEMU/bhyve/libvirt_lxc/... PID).
However, we are not consistent when it comes to shutoff state.
Initially, because virDomainObjNew() uses g_new0() the @pid is
initialized to 0. But when domain is shut off,
On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> Test pipeline:
>
> https://gitlab.com/abologna/libvirt/-/pipelines/548549670
>
> Matching libvirt-perl MR, needed because the integration tests
> download artifacts from there:
>
>
On Thu, May 26, 2022 at 11:05:34AM +0200, Andrea Bolognani wrote:
...
> diff --git a/ci/integration.yml b/ci/integration.yml
> index 5b60b41e85..baf25e9aae 100644
> --- a/ci/integration.yml
> +++ b/ci/integration.yml
> @@ -49,24 +49,24 @@ fedora-35-tests:
>tags:
> -
On a Thursday in 2022, Scott Davis wrote:
On 5/26/22, 4:20 AM, Ján Tomko wrote:
The author (in the From field in the email) has your gmail address
while the sign-off has your starlab address.
If you're okay with me changing the author to match the signoff address,
I can push it after the
Signed-off-by: Andrea Bolognani
---
...erfile => fedora-36-cross-mingw32.Dockerfile} | 2 +-
...erfile => fedora-36-cross-mingw64.Dockerfile} | 2 +-
ci/gitlab/builds.yml | 14 +++---
ci/gitlab/containers.yml | 8
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-36.Dockerfile | 108 +
ci/gitlab/builds.yml | 10 +++
ci/gitlab/containers.yml | 7 ++
ci/integration.yml | 16 +
ci/manifest.yml| 2 +
5
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-34.Dockerfile | 109 -
ci/gitlab.yml | 20 --
ci/integration.yml | 16 -
ci/manifest.yml| 8 ---
4 files changed, 153 deletions(-)
delete
Test pipeline:
https://gitlab.com/abologna/libvirt/-/pipelines/548549670
Matching libvirt-perl MR, needed because the integration tests
download artifacts from there:
https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63
Andrea Bolognani (4):
ci: Drop Fedora 34
ci: Refresh
Notable changes:
* 'lcitool manifest' now generates GitLab CI rules spread
across a bunch of files;
* container images are built less frequently for the main
repository.
Signed-off-by: Andrea Bolognani
---
ci/gitlab.yml | 747 +-
On a Wednesday in 2022, Scott Davis wrote:
Each of the following tripped the -Wformat-overflow warning in GCC 11. The
fixes all seemed pretty obvious based on the context.
Apologies for any formatting or other mistakes, this is my first time
submitting libvirt patches and using git publish.
Detected by gcc 11 -Wformat-overflow:
../../src/util/vircgroupv1.c: In function ‘virCgroupV1ValidatePlacement’:
../../src/util/virerror.h:176:5: warning: ‘%s’ directive argument is null
[-Wformat-overflow=]
176 | virReportErrorHelper(VIR_FROM_THIS, code, __FILE__, \
|
Each of the following tripped the -Wformat-overflow warning in GCC 11. The
fixes all seemed pretty obvious based on the context.
Apologies for any formatting or other mistakes, this is my first time
submitting libvirt patches and using git publish.
Scott Davis (3):
qemu: fix null string
Detected by gcc 11 -Wformat-overflow:
../../src/qemu/qemu_driver.c: In function ‘qemuDomainBlockJobAbort’:
../../src/util/virerror.h:176:5: warning: ‘%s’ directive argument is null
[-Wformat-overflow=]
176 | virReportErrorHelper(VIR_FROM_THIS, code, __FILE__, \
|
Detected by gcc 11 -Wformat-overflow:
../src/remote/remote_sockets.c: In function
‘remoteProbeSessionDriverFromBinary’:
../src/util/virlog.h:79:5: error: ‘%s’ directive argument is null
[-Werror=format-overflow=]
79 | virLogMessage(src, VIR_LOG_DEBUG, filename, linenr, funcname, NULL,
36 matches
Mail list logo
