Re: [PATCH] lib: Be consistent about vm->pid

2022-05-31 Thread Jonathon Jongsma
Reviewed-by: Jonathon Jongsma On 5/26/22 5:42 AM, Michal Privoznik wrote: The virDomainObj struct has @pid member where the domain's hypervisor PID is stored (e.g. QEMU/bhyve/libvirt_lxc/... PID). However, we are not consistent when it comes to shutoff state. Initially, because

[PATCH v2 5/5] network: firewalld: add support for routed networks

2022-05-31 Thread Eric Garver
Signed-off-by: Eric Garver --- src/network/bridge_driver_linux.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 98d2a33a1da0..c96d8f624b4d 100644 --- a/src/network/bridge_driver_linux.c

[PATCH v2 2/5] util: add virFirewallDPolicyExists()

2022-05-31 Thread Eric Garver
Signed-off-by: Eric Garver --- src/libvirt_private.syms | 1 + src/util/virfirewalld.c | 31 +++ src/util/virfirewalld.h | 1 + 3 files changed, 33 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 64d932e929eb..9ea3062f75e9

[PATCH v2 1/5] util: add virFirewallDGetPolicies()

2022-05-31 Thread Eric Garver
Signed-off-by: Eric Garver --- src/libvirt_private.syms | 1 + src/util/virfirewalld.c | 41 src/util/virfirewalld.h | 1 + 3 files changed, 43 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[PATCH v2 0/5] network: firewalld: fix routed network

2022-05-31 Thread Eric Garver
This series fixes routed networks when a newer firewalld (>= 1.0.0) is present [1]. Firewalld 1.0.0 included a change that disallows implicit forwarding between zones [2]. libvirt was relying on this behavior to allow routed networks to function. Firewalld policies are added. Policies have been

[PATCH v2 3/5] network: firewalld: add zone for routed networks

2022-05-31 Thread Eric Garver
This zone will be used for the routed network by default. Note that this zone definition omits "forward" aka intra-zone forwarding, because it requires firewalld >= 0.9.0. Signed-off-by: Eric Garver --- src/network/libvirt-routed.zone | 10 ++ src/network/meson.build | 5 +

[PATCH v2 4/5] network: firewalld: add policies for routed networks

2022-05-31 Thread Eric Garver
Signed-off-by: Eric Garver --- src/network/libvirt-routed-in.policy | 11 +++ src/network/libvirt-routed-out.policy | 12 src/network/libvirt-to-host.policy| 20 src/network/meson.build | 15 +++ 4 files changed, 58

Re: [PATCH 00/67] docs: Fix and clean up anchor links

2022-05-31 Thread Peter Krempa
On Tue, May 31, 2022 at 17:26:34 +0200, Ján Tomko wrote: > On a Tuesday in 2022, Peter Krempa wrote: > > First 50 patches remove the use of raw HTML passthrough in > > formatdomain.rst, which is the only outstanding place which still does. > > > > Is cleaning those up worth breaking links from

Re: [PATCH 00/67] docs: Fix and clean up anchor links

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: First 50 patches remove the use of raw HTML passthrough in formatdomain.rst, which is the only outstanding place which still does. Is cleaning those up worth breaking links from external sites which use the old anchors? I thought that was the only

Re: [PATCH 66/67] docs: formatstorageencryption: Use correct anchor into formatsecret page

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: The link was most likely broken when 'formatsecret' was converted to RST. Signed-off-by: Peter Krempa --- docs/formatstorageencryption.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 65/67] uri: Fix link to qemu KVM example config

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Link into the examples of the qemu driver. Signed-off-by: Peter Krempa --- docs/uri.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 64/67] docs: remote: Fix anchor names in links to uri.html

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: When uri.html was converted to RST the 'URI remote' anchor was not fixed in remote.rst. Signed-off-by: Peter Krempa --- docs/remote.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 63/67] docs: kbase/tlscerts: Fix links

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Most of the links were broken by moving the article into kbase, but in this case we need to also fix the anchor names. Signed-off-by: Peter Krempa --- docs/kbase/tlscerts.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by:

Re: [PATCH 62/67] docs: kbase/kvm-realtime: Fix few links

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Certain links were missing the '../' prefix to reach files in the parent directory from the time the page was introduced. Signed-off-by: Peter Krempa --- docs/kbase/kvm-realtime.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 61/67] docs: Fix links in kbase/internals

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: The links were broken when the documentation was moved into the 'internals' subdirectory. Signed-off-by: Peter Krempa --- docs/kbase/internals/eventloop.rst | 2 +- docs/kbase/internals/migration.rst | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH 60/67] docs: Remove extra leading slash in 'api' and 'formatdomaincaps' pages

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: While the links work they'd trip up the link validator script which will be added later. Signed-off-by: Peter Krempa --- docs/api.rst | 2 +- docs/formatdomaincaps.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by:

Re: [PATCH 59/67] docs: Fix link to 'tlscerts' article

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: The link was not fixed when the page was moved into 'kbase/' Signed-off-by: Peter Krempa --- docs/docs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 58/67] scripts: hvsupport: Remove link into the 'html' directory

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Linking to a list of files is not helpful. Signed-off-by: Peter Krempa --- scripts/hvsupport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 56/67] docs: rpc: Fix broken headings

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Remove what seems like links from some headings. This error predates the conversion to RST where an ' --- docs/kbase/internals/rpc.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 55/67] docs: domainstatecapture: Fix broken links

2022-05-31 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: Some links didn't exit the 'kbase/' directory and 'virDomainBackupEnd' API never existed. Signed-off-by: Peter Krempa --- docs/kbase/domainstatecapture.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Ján Tomko

[PATCH 57/67] docs: formatcaps: Fix anchors of links into formatdomain.rst

2022-05-31 Thread Peter Krempa
The links were broken on the initial conversion of formatdomain.html to RST which didn't faithfully forward port some of the manually added anchors. Fix it by pointing to the closest possible heading. Signed-off-by: Peter Krempa --- docs/formatcaps.rst | 10 +- 1 file changed, 5

[PATCH 61/67] docs: Fix links in kbase/internals

2022-05-31 Thread Peter Krempa
The links were broken when the documentation was moved into the 'internals' subdirectory. Signed-off-by: Peter Krempa --- docs/kbase/internals/eventloop.rst | 2 +- docs/kbase/internals/migration.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 55/67] docs: domainstatecapture: Fix broken links

2022-05-31 Thread Peter Krempa
Some links didn't exit the 'kbase/' directory and 'virDomainBackupEnd' API never existed. Signed-off-by: Peter Krempa --- docs/kbase/domainstatecapture.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/kbase/domainstatecapture.rst

[PATCH 64/67] docs: remote: Fix anchor names in links to uri.html

2022-05-31 Thread Peter Krempa
When uri.html was converted to RST the 'URI remote' anchor was not fixed in remote.rst. Signed-off-by: Peter Krempa --- docs/remote.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/remote.rst b/docs/remote.rst index bcc394e083..ab11405d56 100644 ---

[PATCH 53/67] syntax-check: Add check prohibiting remote reference to local file

2022-05-31 Thread Peter Krempa
Within a file we should use the internal reference syntax. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index e8f9a91cee..649eb91acb 100644 ---

[PATCH 42/67] docs: formatdomain: Remove 'elementsAudio' anchor

2022-05-31 Thread Peter Krempa
Local references were reworded to match. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d63543db0b..a6e54246b8 100644 --- a/docs/formatdomain.rst +++

[PATCH 67/67] docs: Add HTML reference checker

2022-05-31 Thread Peter Krempa
In many cases we move around or rename internal anchors which may break links leading to the content. docutils handle the case of links inside a document, but we are lacking the same form of checking between documents. Introduce a script which cross-checks all the anchors and links in HTML

[PATCH 63/67] docs: kbase/tlscerts: Fix links

2022-05-31 Thread Peter Krempa
Most of the links were broken by moving the article into kbase, but in this case we need to also fix the anchor names. Signed-off-by: Peter Krempa --- docs/kbase/tlscerts.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/kbase/tlscerts.rst

[PATCH 43/67] docs: formatdomain: Remove 'elementsTpm' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/formatsecret.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index a6e54246b8..efe20e9654 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@

[PATCH 66/67] docs: formatstorageencryption: Use correct anchor into formatsecret page

2022-05-31 Thread Peter Krempa
The link was most likely broken when 'formatsecret' was converted to RST. Signed-off-by: Peter Krempa --- docs/formatstorageencryption.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatstorageencryption.rst b/docs/formatstorageencryption.rst index

[PATCH 38/67] docs: formatdomain: Remove 'elementCharSerial' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 5f15c14093..3b9c18f6b4 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -274,8 +274,8 @@ them in

[PATCH 23/67] docs: formatdomain: Remove 'elementsVirtioTransitional' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 91517b069f..13d6e35ca8 100644 --- a/docs/formatdomain.rst +++

[PATCH 48/67] docs: formatdomain: Remove 'keywrap' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cffdab6eb7..97c23f6aa6 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8142,7 +8142,6 @@ an output-only element

[PATCH 05/67] docs: formatdomain: Remove 'elementsOSContainer' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/drvlxc.rst | 2 +- docs/formatdomain.rst | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/drvlxc.rst b/docs/drvlxc.rst index 24501cae11..8a346907fb 100644 --- a/docs/drvlxc.rst +++ b/docs/drvlxc.rst @@ -37,7 +37,7 @@ In order to

[PATCH 65/67] uri: Fix link to qemu KVM example config

2022-05-31 Thread Peter Krempa
Link into the examples of the qemu driver. Signed-off-by: Peter Krempa --- docs/uri.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/uri.rst b/docs/uri.rst index bfc9542260..1d2c68f5b8 100644 --- a/docs/uri.rst +++ b/docs/uri.rst @@ -121,7 +121,7 @@ So to connect to

[PATCH 50/67] docs: formatdomain: Remove the 'anchor' role

2022-05-31 Thread Peter Krempa
The role was used to pass through raw HTML to define custom anchor names. Since all of the document was now converted to use the anchors generated from headers we can remove it. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 62/67] docs: kbase/kvm-realtime: Fix few links

2022-05-31 Thread Peter Krempa
Certain links were missing the '../' prefix to reach files in the parent directory from the time the page was introduced. Signed-off-by: Peter Krempa --- docs/kbase/kvm-realtime.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/kbase/kvm-realtime.rst

[PATCH 46/67] docs: formatdomain: Remove 'vsock' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cd3dcca1cb..8e0f254236 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8024,7 +8024,6 @@ Example: mapping larger

[PATCH 56/67] docs: rpc: Fix broken headings

2022-05-31 Thread Peter Krempa
Remove what seems like links from some headings. This error predates the conversion to RST where an ' --- docs/kbase/internals/rpc.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/kbase/internals/rpc.rst b/docs/kbase/internals/rpc.rst index

[PATCH 60/67] docs: Remove extra leading slash in 'api' and 'formatdomaincaps' pages

2022-05-31 Thread Peter Krempa
While the links work they'd trip up the link validator script which will be added later. Signed-off-by: Peter Krempa --- docs/api.rst | 2 +- docs/formatdomaincaps.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/api.rst b/docs/api.rst index

[PATCH 59/67] docs: Fix link to 'tlscerts' article

2022-05-31 Thread Peter Krempa
The link was not fixed when the page was moved into 'kbase/' Signed-off-by: Peter Krempa --- docs/docs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs.rst b/docs/docs.rst index 0a698913be..9fd8b7c37e 100644 --- a/docs/docs.rst +++ b/docs/docs.rst @@ -26,7 +26,7

[PATCH 51/67] docs: formatdomain: Use local reference directly

2022-05-31 Thread Peter Krempa
Once we are already using the new anchor format we can create the link via a local reference. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d27a295329..1c446da9ca

[PATCH 54/67] docs: page.xsl: Fix link to 'mailing-lists' section

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/page.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/page.xsl b/docs/page.xsl index 0a0b017482..1414d90b89 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -172,7 +172,7 @@ Contact -

[PATCH 52/67] docs: uri: Fix link to libvirtd configuration section

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/uri.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/uri.rst b/docs/uri.rst index 3ca3fb12c3..bfc9542260 100644 --- a/docs/uri.rst +++ b/docs/uri.rst @@ -291,7 +291,7 @@ Supported extra parameters: If set to a non-zero value,

[PATCH 47/67] docs: formatdomain: Remove 'seclabel' anchor

2022-05-31 Thread Peter Krempa
One local reference required rewording of a whole paragraph to make sense. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 10 +- docs/formatsnapshot.rst | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[PATCH 58/67] scripts: hvsupport: Remove link into the 'html' directory

2022-05-31 Thread Peter Krempa
Linking to a list of files is not helpful. Signed-off-by: Peter Krempa --- scripts/hvsupport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/hvsupport.py b/scripts/hvsupport.py index 50ba25c78f..89fd0d1d94 100755 --- a/scripts/hvsupport.py +++

[PATCH 41/67] docs: formatdomain: Remove 'elementsCharHost' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d8004d4ad0..d63543db0b 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -6716,7 +6716,6 @@ NB special case if , then the

[PATCH 45/67] docs: formatdomain: Remove 'elementsIommu' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 2dec27b0b1..cd3dcca1cb 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3572,7 +3572,7 @@ QEMU's

[PATCH 28/67] docs: formatdomain: Remove 'elementsNICSTargetOverride' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index bbf26edeba..d9d262d959 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -4513,8 +4513,7 @@ can be

[PATCH 39/67] docs: formatdomain: Remove 'elementCharSerialAndConsole' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 3b9c18f6b4..1e279ad72e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -6400,8 +6400,8 @@

[PATCH 44/67] docs: formatdomain: Remove 'elementsMemory' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst| 1 - docs/kbase/memorydevices.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index efe20e9654..2dec27b0b1 100644 --- a/docs/formatdomain.rst +++

[PATCH 40/67] docs: formatdomain: Remove 'elementsCharHostInterface' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 1e279ad72e..d8004d4ad0 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -6624,7 +6624,6 @@ types

[PATCH 27/67] docs: formatdomain: Remove 'elementsNICSDirect' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/formatnetwork.rst | 4 ++-- docs/formatnetworkport.rst | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 3618b1212a..bbf26edeba 100644 ---

[PATCH 35/67] docs: formatdomain: Remove 'elementsGraphics' anchor

2022-05-31 Thread Peter Krempa
Local references needed rewording. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 4f09df9d48..73151c35f0 100644 --- a/docs/formatdomain.rst +++

[PATCH 36/67] docs: formatdomain: Remove 'elementsVideo' anchor

2022-05-31 Thread Peter Krempa
The surrounding paragraph around the only fixed use was rewrapped. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 73151c35f0..b3d254520e 100644 ---

[PATCH 30/67] docs: formatdomain: Remove 'elementVlanTag' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 5264d5fbf3..10503edab6 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5460,7 +5460,6 @@ outgoing traffic can be shaped

[PATCH 49/67] docs: formatdomain: Remove 'launchSecurity' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/formatdomaincaps.rst | 4 ++-- docs/kbase/launch_security_sev.rst | 2 +- docs/kbase/s390_protected_virt.rst | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.rst

[PATCH 26/67] docs: formatdomain: Remove 'elementsNICS' anchor

2022-05-31 Thread Peter Krempa
The one local link addition prompted rewrapping of the whole paragraph. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 11 +-- docs/formatnetwork.rst | 4 ++-- docs/formatnetworkport.rst | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git

[PATCH 37/67] docs: formatdomain: Remove 'elementsConsole' anchor

2022-05-31 Thread Peter Krempa
Some rewording and rewraping was needed to accomodate the new local references. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[PATCH 33/67] docs: formatdomain: Remove 'coalesce' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 584cea36af..f7d29e7403 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5584,7 +5584,6 @@ This element provides means of

[PATCH 13/67] docs: formatdomain: Remove 'elementsNUMATuning' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 5cf31d9e06..6637ab409b 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1008,7 +1008,7 @@ influence

[PATCH 34/67] docs: formatdomain: Remove 'elementVhostuser' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f7d29e7403..4f09df9d48 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5236,8 +5236,8 @@ following

[PATCH 12/67] docs: formatdomain: Remove 'elementsMemoryTuning' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index fbebff8650..5cf31d9e06 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1025,7 +1025,7 @@ influence

[PATCH 25/67] docs: formatdomain: Remove 'elementsHostDev' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- docs/formatnode.rst | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 403a03edfb..65197d6e3d 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@

[PATCH 22/67] docs: formatdomain: Remove 'elementsVirtio' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 9d3960e7ad..91517b069f 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@

[PATCH 17/67] docs: formatdomain: Remove 'elementsEvents' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/kbase/locking-sanlock.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 2851f28251..acff214cc8 100644 --- a/docs/formatdomain.rst +++

[PATCH 18/67] docs: formatdomain: Remove 'elementsFeatures' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- docs/formatdomaincaps.rst | 2 +- docs/kbase/kvm-realtime.rst | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index acff214cc8..0247132d2b 100644 ---

[PATCH 15/67] docs: formatdomain: Remove 'elementsCPU' anchor

2022-05-31 Thread Peter Krempa
Reworded documentation around the local link. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- docs/formatdomaincaps.rst | 2 +- docs/kbase/kvm-realtime.rst | 2 +- docs/manpages/virsh.rst | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH 14/67] docs: formatdomain: Remove 'elementsBlockTuning' anchor

2022-05-31 Thread Peter Krempa
Reworded documentation around the local link. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 6637ab409b..45f94e5fa2 100644 --- a/docs/formatdomain.rst +++

[PATCH 16/67] docs: formatdomain: Remove 'hmat' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index e8431f972f..2851f28251 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1630,7 +1630,6 @@ QEMU. If no ``distances`` are

[PATCH 24/67] docs: formatdomain: Remove 'elementsControllers' anchor

2022-05-31 Thread Peter Krempa
Local references were reworded. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 13d6e35ca8..403a03edfb 100644 --- a/docs/formatdomain.rst +++

[PATCH 31/67] docs: formatdomain: Remove 'elementPort' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 10503edab6..00d05adfb8 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5515,7 +5515,6 @@ done with the optional

[PATCH 07/67] docs: formatdomain: Remove 'elementsCPUAllocation' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/kbase/kvm-realtime.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index f0bc9f6995..564ebbfd69 100644 --- a/docs/formatdomain.rst +++

[PATCH 29/67] docs: formatdomain: Remove 'elementQoS' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d9d262d959..5264d5fbf3 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5436,7 +5436,6 @@ domains (so data will not go

[PATCH 11/67] docs: formatdomain: Remove 'elementsMemoryBacking' anchor

2022-05-31 Thread Peter Krempa
Reworded documentation around one of the local links. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 16 +++- docs/kbase/kvm-realtime.rst | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[PATCH 10/67] docs: formatdomain: Remove 'elementsMemoryAllocation' anchor

2022-05-31 Thread Peter Krempa
Reworded documentation around local links. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 27e1e496e9..8e18151796 100644 --- a/docs/formatdomain.rst +++

[PATCH 20/67] docs: formatdomain: Remove 'elementsDisks' anchor

2022-05-31 Thread Peter Krempa
Two paragraphs containing local links were reformulated and rewrapped. Signed-off-by: Peter Krempa --- docs/formatbackup.rst | 6 +++--- docs/formatcheckpoint.rst | 2 +- docs/formatdomain.rst | 21 +++-- docs/formatsecret.rst | 10 +-

[PATCH 32/67] docs: formatdomain: Remove 'mtu' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 00d05adfb8..584cea36af 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5564,7 +5564,6 @@ specified as the value, the

[PATCH 19/67] docs: formatdomain: Remove 'elementsDevices' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/manpages/virsh.rst | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 0247132d2b..4f85366c9d 100644 --- a/docs/formatdomain.rst +++

[PATCH 06/67] docs: formatdomain: Remove 'elementsSysinfo' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 1346c1ce01..f0bc9f6995 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -53,7 +53,7 @@ General

[PATCH 09/67] docs: formatdomain: Remove 'elementsCPUTuning' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/kbase/kvm-realtime.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 835dff3596..27e1e496e9 100644 --- a/docs/formatdomain.rst +++

[PATCH 21/67] docs: formatdomain: Remove 'elementsAddress' anchor

2022-05-31 Thread Peter Krempa
All local links were reformulated to make sense with local references. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[PATCH 08/67] docs: formatdomain: Remove 'elementsIOThreadsAllocation' anchor

2022-05-31 Thread Peter Krempa
Reworded documentation around local links. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 18 -- docs/formatdomaincaps.rst | 2 +- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index

[PATCH 04/67] docs: formatdomain: Remove 'elementsOSBIOS' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 21 ++--- docs/formatdomaincaps.rst | 6 +++--- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 381d17370e..3936a31155 100644 ---

[PATCH 01/67] docs: formatdomain: Remove 'elements' anchor

2022-05-31 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 1 - docs/formatdomaincaps.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 089a99b4b5..a0e8d69b87 100644 --- a/docs/formatdomain.rst +++

[PATCH 03/67] docs: formatdomain: Remove 'elementsOS' anchor

2022-05-31 Thread Peter Krempa
Reworded the paragraph around the local link. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index a8d3e559c9..381d17370e 100644 --- a/docs/formatdomain.rst +++

[PATCH 02/67] docs: formatdomain: Remove 'elementsMetadata' anchor

2022-05-31 Thread Peter Krempa
Reworded the local link so that it retains the sense. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index a0e8d69b87..a8d3e559c9 100644 --- a/docs/formatdomain.rst +++

[PATCH 00/67] docs: Fix and clean up anchor links

2022-05-31 Thread Peter Krempa
First 50 patches remove the use of raw HTML passthrough in formatdomain.rst, which is the only outstanding place which still does. Most of the work was done by a ad-hoc bash script, but manual tweaks were needed. Since this series also contains a test script which validates linking I'm not going

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-05-31 Thread Michal Prívozník
On 5/30/22 15:09, Michal Prívozník wrote: > On 5/18/22 09:59, Haibin Huang wrote: >> > > Overall, these patches work. I've raised couple of points and for your > convenience you can find reworked patches here: > > https://gitlab.com/MichalPrivoznik/libvirt/-/commits/sgx_fixups/ > > Please see

Re: [libvirt PATCH 0/4] ci: reduce number of jobs in the pipeline

2022-05-31 Thread Andrea Bolognani
On Fri, May 27, 2022 at 10:06:16AM -0400, Daniel P. Berrangé wrote: > Come June 1st (aka very very soon) GitLab will reduce the > CI minutes quota available from 2000 to 400 for public > projects. > > The wallclock minutes for CI are the quota divided by > a cost factor currently 0.008. IOW, after

Re: [PATCH v2 0/2] 2 release notes for v8.4.0

2022-05-31 Thread Michal Prívozník
On 5/31/22 03:48, Han Han wrote: > v1: https://listman.redhat.com/archives/libvir-list/2022-May/231901.html > diff from v1: rebase to latest and resolve conflicts > > Han Han (2): > news: Add qemu-vdagent > news: Add APIs virDomainSaveParams virDomainRestoreParams > > NEWS.rst | 12

Re: [PATCH RFC 00/10] qemu: Enable SCHED_CORE for domains and helper processes

2022-05-31 Thread Michal Prívozník
On 5/26/22 16:00, Dario Faggioli wrote: > On Thu, 2022-05-26 at 14:01 +0200, Dario Faggioli wrote: >> Thoughts? >> > Oh, and there are even a couple of other (potential) use case, for > having an (even more!) fine grained control of core-scheduling. > > So, right now, giving a virtual topology to

Re: [PATCH RFC 00/10] qemu: Enable SCHED_CORE for domains and helper processes

2022-05-31 Thread Michal Prívozník
On 5/26/22 14:01, Dario Faggioli wrote: > On Mon, 2022-05-23 at 17:13 +0100, Daniel P. Berrangé wrote: >> On Mon, May 09, 2022 at 05:02:07PM +0200, Michal Privoznik wrote: >> In terms of defaults I'd very much like us to default to enabling >> core scheduling, so that we have a secure deployment

Re: [PATCH] qemu_capspriv: Drop needless declarations

2022-05-31 Thread Boris Fiuczynski
On 5/30/22 3:07 PM, Michal Privoznik wrote: here are two functions declared in qemu_capspriv.h: 1) virQEMUCapsInitHostCPUModel() which is not used anywhere but qemu_capabilities.c, 2) virQEMUCapsSetSEVCapabilities() which is my personal favorite but despite that it's never implemented