Re: Some questions regarding firmware handling in the qemu driver

On Wed, Jun 08, 2022 at 11:46:43AM -0600, Jim Fehlig wrote: > On 6/8/22 10:28, Daniel P. Berrangé wrote: > > On Wed, Jun 08, 2022 at 12:20:20PM -0400, Andrea Bolognani wrote: > > > On Tue, Jun 07, 2022 at 02:57:17PM -0600, Jim Fehlig wrote: > > > > Hi All, > > > > > > > > I received a bug report

Re: Some questions regarding firmware handling in the qemu driver

On Wed, Jun 08, 2022 at 12:20:20PM -0400, Andrea Bolognani wrote: > On Tue, Jun 07, 2022 at 02:57:17PM -0600, Jim Fehlig wrote: > > Hi All, > > > > I received a bug report (private, sorry) about inability to "deploy uefi > > virtual machine with secureboot enabled on aarch64 kvm host". Indeed the

Re: Some questions regarding firmware handling in the qemu driver

On Tue, Jun 07, 2022 at 02:57:17PM -0600, Jim Fehlig wrote: > Hi All, > > I received a bug report (private, sorry) about inability to "deploy uefi > virtual machine with secureboot enabled on aarch64 kvm host". Indeed the > qemu driver has some checks that would prohibit using secure boot with >

[PATCH v3 13/15] conf: Introduce

As of v7.0.0-877-g70ac26b9e5 QEMU exposes its default event loop for devices with no IOThread assigned as an QMP object. In the very next commit (v7.0.0-878-g71ad4713cc) it was extended for thread-pool-min and thread-pool-max attributes. Expose them under new element. Signed-off-by: Michal

[PATCH v3 09/15] qemu: Generate command line for IOThread pool size

Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 10 - ...othreads-ids-pool-sizes.x86_64-latest.args | 44 +++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 53 insertions(+), 2 deletions(-)

[PATCH v3 14/15] qemu_validate: Check if QEMU's capable of setting pool size

Since the main-loop and iothread classes are derived from the same class (EventLoopBaseClass) we don't need new capability and can use QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX directly to check whether QEMU's capable of setting defaultiothread pool size. Signed-off-by: Michal Privoznik Reviewed-by:

[PATCH v3 11/15] qemu: Wire up new virDomainSetIOThreadParams parameters

Introduced in previous commit, QEMU driver needs to be taught how to set VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX parameters on given IOThread. Fortunately, this is fairly trivial to do and since these two parameters are exposed in domain XML too the update of

[PATCH v3 02/15] virDomainDefParseIOThreads: Use g_autoptr() for @iothrid

Using g_autoptr() for @iothrid variable inside virDomainDefParseIOThreads() allows us to drop explicit call to virDomainIOThreadIDDefFree() in one case. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v3 10/15] include: Introduce typed params for virDomainSetIOThreadParams wrt pool size

Our public API offers virDomainSetIOThreadParams() function which allows users to set various aspects of IOThreads. Introduce two new typed parameters: VIR_DOMAIN_IOTHREAD_THREAD_POOL_MIN and VIR_DOMAIN_IOTHREAD_THREAD_POOL_MAX which will allow users to modify the thread-pool-min and

[PATCH v3 12/15] virsh: Wire up new virDomainSetIOThreadParams parameters

Since virsh implements a wrapper over virDomainSetIOThreadParams() (command iothreadset) let's wire up new typed parameters there too. Signed-off-by: Michal Privoznik --- docs/manpages/virsh.rst | 13 - tools/virsh-domain.c| 24 +++- 2 files changed, 35

Re: [PATCH v2 08/15] qemu_validate: Check if QEMU's capable of setting iothread pool size

On 6/7/22 16:59, Peter Krempa wrote: > On Tue, Jun 07, 2022 at 14:52:52 +0200, Michal Privoznik wrote: >> Now that we have a capability that reflects whether QEMU is >> capable of setting iothread pool size, let's introduce a >> validator check to make sure users are not trying to use this >>

Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

Reviewed-by: Claudio Fontana On 6/8/22 15:25, Michal Privoznik wrote: > Virsh has iothreadset command which allows setting various > attributes of IOThreads. However, when the command is called > without any arguments (besides domain and IOThread IDs), then > @params stays NULL and is passed to

Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

On Wed, Jun 08, 2022 at 15:25:13 +0200, Michal Privoznik wrote: > Virsh has iothreadset command which allows setting various > attributes of IOThreads. However, when the command is called > without any arguments (besides domain and IOThread IDs), then > @params stays NULL and is passed to

[PATCH v3 08/15] qemu_validate: Check if QEMU's capable of setting iothread pool size

Now that we have a capability that reflects whether QEMU is capable of setting iothread pool size, let's introduce a validator check to make sure users are not trying to use this feature with QEMU that doesn't support it. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa ---

[PATCH v3 05/15] conf: Introduce allocator for virDomainIOThreadIDDef

So far, iothread configuration structure (virDomainIOThreadIDDef) is allocated by plain g_new0(). This is perfectly okay because all members of the struct default to value 0 anyway. But soon this is going to change. Therefore, replace those g_new0() with a function so that the default value can be

Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

On 6/8/22 15:27, Peter Krempa wrote: > On Wed, Jun 08, 2022 at 15:25:13 +0200, Michal Privoznik wrote: >> Virsh has iothreadset command which allows setting various >> attributes of IOThreads. However, when the command is called >> without any arguments (besides domain and IOThread IDs), then >>

[PATCH v3 01/15] virml: Introduce VIR_XML_PROP_NONNEGATIVE flag

For easier attribute parsing we have virXMLProp*() family of functions. These accept flags through which a caller can pose some conditions onto the attribute value, for instance: VIR_XML_PROP_NONZERO when the attribute may not be zero, etc. What we are missing is VIR_XML_PROP_NONNEGATIVE when the

[PATCH v3 15/15] qemu: Generate command line for pool size

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2059511 Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 16 +--- .../iothreads-ids-pool-sizes.x86_64-latest.args | 1 + 2 files changed, 14 insertions(+), 3

[PATCH v3 04/15] conf: Move iothread formatter into a separate function

Formatting iothreads is currently open coded inside of virDomainDefFormatInternalSetRootName(). While this works, it makes the function needlessly long, especially if the formatting code will expand in near future. Therefore, move it into a separate function. At the same time, make

[PATCH v3 06/15] conf: Introduce thread_pool_min and thread_pool_max attributes to IOThread

At least in case of QEMU an IOThread is actually a pool of threads (see iothread_set_aio_context_params() in QEMU's code base). As such, it can have minimal and maximal number of worker threads. Allow setting them in domain XML. Signed-off-by: Michal Privoznik --- docs/formatdomain.rst

[PATCH v3 03/15] virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid

In virDomainIOThreadIDDefArrayInit() the variable @iothrid is used only inside a loop but is declared for whole function. Bring the variable into the loop so that it's obvious that the variable is not used elsewhere. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa ---

[PATCH v3 07/15] qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX

This capability reflects whether QEMU allows setting thread-pool-min and thread-pool-max attributes on iothread object. Since both attributes were introduced in the same commit (v7.0.0-878-g71ad4713cc) and can't exist independently of each other we can stick with one capability covering both of

[PATCH v3 00/15] qemu: Allow setting EventLoopBaseProperties

v3 of: https://listman.redhat.com/archives/libvir-list/2022-June/232288.html diff to v2: - More validation checks (e.g. max != 0, min <= max), - Disallow -1 for virDomainSetIOThreadParams on a live VM, - Extended docs, - Reworded some commit messages. Michal Prívozník (15): virml: Introduce

[PATCH] virsh: Check whether enough arguments was passed to iothreadset

Virsh has iothreadset command which allows setting various attributes of IOThreads. However, when the command is called without any arguments (besides domain and IOThread IDs), then @params stays NULL and is passed to virDomainSetIOThreadParams() which produces rather user unfriendly error

[PATCH v3 16/26] remote: Remove unused includes

Signed-off-by: Peng Liang --- src/remote/remote_daemon.c | 3 --- src/remote/remote_daemon.h | 1 - src/remote/remote_daemon_config.c | 1 - src/remote/remote_daemon_dispatch.c | 5 - src/remote/remote_daemon_dispatch.h | 1 - src/remote/remote_daemon_stream.c | 1 -

[PATCH v3 19/26] util: Remove unused includes

Signed-off-by: Peng Liang --- src/util/iohelper.c | 3 --- src/util/virarptable.c| 2 -- src/util/virauth.c| 1 - src/util/virauthconfig.c | 1 - src/util/virbpf.c | 1 - src/util/virbuffer.c | 2 -- src/util/vircgroup.c | 3 ---

[PATCH v3 15/26] qemu: Remove unused includes

Signed-off-by: Peng Liang --- src/qemu/qemu_agent.c| 2 -- src/qemu/qemu_alias.c| 1 - src/qemu/qemu_alias.h| 2 -- src/qemu/qemu_backup.c | 5 - src/qemu/qemu_block.c| 1 - src/qemu/qemu_block.h| 1 -

[PATCH v3 10/26] locking: Remove unused includes

Signed-off-by: Peng Liang --- src/locking/domain_lock.c | 3 --- src/locking/domain_lock.h | 1 - src/locking/lock_daemon.c | 2 -- src/locking/lock_daemon_config.c | 4 src/locking/lock_daemon_dispatch.c | 1 - src/locking/lock_driver_lockd.c| 1 -

[PATCH v3 03/26] ch: Remove unused includes

Signed-off-by: Peng Liang --- src/ch/ch_conf.c| 1 - src/ch/ch_domain.c | 1 - src/ch/ch_driver.c | 7 --- src/ch/ch_monitor.c | 2 -- src/ch/ch_process.c | 2 -- 5 files changed, 13 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index bae245adf3..775596e9f5 100644 ---

[PATCH v3 17/26] rpc: Remove unused includes

Signed-off-by: Peng Liang --- src/rpc/virkeepalive.c| 3 --- src/rpc/virnetclient.c| 1 - src/rpc/virnetclient.h| 1 - src/rpc/virnetclientprogram.h | 1 - src/rpc/virnetclientstream.c | 1 - src/rpc/virnetclientstream.h | 1 - src/rpc/virnetdaemon.c| 2 --

[PATCH v3 24/26] tools: Remove unused includes

Signed-off-by: Peng Liang --- tools/virsh-checkpoint.c | 2 -- tools/virsh-completer-checkpoint.c | 2 -- tools/virsh-completer-domain.c | 1 - tools/virsh-completer-host.c | 1 - tools/virsh-completer-interface.c | 2 -- tools/virsh-completer-network.c| 1 -

[PATCH v3 11/26] logging: Remove unused includes

Signed-off-by: Peng Liang --- src/logging/log_daemon.c | 5 - src/logging/log_daemon_config.c | 4 src/logging/log_daemon_dispatch.c | 1 - src/logging/log_handler.c | 1 - src/logging/log_manager.c | 1 - 5 files changed, 12 deletions(-) diff --git

[PATCH v3 07/26] hyperv: Remove unused includes

Signed-off-by: Peng Liang --- src/hyperv/hyperv_private.h | 2 -- src/hyperv/hyperv_util.c| 3 --- 2 files changed, 5 deletions(-) diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h index da37a8fd20..fb82cef046 100644 --- a/src/hyperv/hyperv_private.h +++

[PATCH v3 05/26] cpu: Remove unused includes

Signed-off-by: Peng Liang --- src/cpu/cpu.c | 3 --- src/cpu/cpu.h | 1 - src/cpu/cpu_arm.c | 1 - src/cpu/cpu_map.c | 2 -- src/cpu/cpu_ppc64.c | 1 - src/cpu/cpu_s390.c | 2 -- src/cpu/cpu_x86.c | 1 - 7 files changed, 11 deletions(-) diff --git a/src/cpu/cpu.c

[PATCH v3 06/26] esx: Remove unused includes

Signed-off-by: Peng Liang --- src/esx/esx_driver.c| 1 - src/esx/esx_interface_driver.c | 6 -- src/esx/esx_network_driver.c| 2 -- src/esx/esx_private.h | 2 -- src/esx/esx_storage_backend_iscsi.c | 2 -- src/esx/esx_storage_backend_vmfs.c | 2 --

[PATCH v3 22/26] vmx: Remove unused includes

Signed-off-by: Peng Liang --- src/vmx/vmx.c | 1 - src/vmx/vmx.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index c391caa910..6581173187 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -24,7 +24,6 @@ #include "internal.h" #include "virerror.h"

[PATCH v3 20/26] vbox: Remove unused includes

Signed-off-by: Peng Liang --- src/vbox/vbox_XPCOMCGlue.c | 3 --- src/vbox/vbox_driver.c | 2 -- src/vbox/vbox_network.c| 2 -- src/vbox/vbox_storage.c| 3 --- src/vbox/vbox_tmpl.c | 1 - 5 files changed, 11 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c

[PATCH v3 04/26] conf: Remove unused includes

Signed-off-by: Peng Liang --- src/conf/backup_conf.c| 3 --- src/conf/capabilities.c | 1 - src/conf/capabilities.h | 2 -- src/conf/checkpoint_conf.c| 4 src/conf/cpu_conf.c | 2 -- src/conf/cpu_conf.h

[PATCH v3 00/26] Remove some unused includes

This series are the v3 of: https://listman.redhat.com/archives/libvir-list/2022-May/231132.html. And this version passes the pipeline in GitLab :) (https://gitlab.com/tcx4c70/libvirt/-/pipelines/558476177). v2 -> v3: 1. Stop removing "internal.h"; [Ján Tomko] 2. Remove Patch 09, 15, 20, 21, and

[PATCH v3 02/26] admin: Remove unused includes

Signed-off-by: Peng Liang --- src/admin/admin_server.c | 4 src/admin/admin_server.h | 1 - src/admin/admin_server_dispatch.c | 3 --- src/admin/libvirt-admin.c | 2 -- 4 files changed, 10 deletions(-) diff --git a/src/admin/admin_server.c

[PATCH v3 14/26] openvz: Remove unused includes

Signed-off-by: Peng Liang --- src/openvz/openvz_conf.c | 1 - src/openvz/openvz_util.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 79ab786355..c94f9b8577 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@

[PATCH v3 18/26] storage: Remove unused includes

Signed-off-by: Peng Liang --- src/storage/parthelper.c | 1 - src/storage/storage_backend.c | 3 --- src/storage/storage_backend_fs.c | 1 - src/storage/storage_backend_gluster.c | 1 - src/storage/storage_backend_iscsi.c| 4

[PATCH v3 13/26] node_device: Remove unused includes

Signed-off-by: Peng Liang --- src/node_device/node_device_driver.c | 3 --- src/node_device/node_device_udev.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 4b31cd5695..0178ae8b66 100644 ---

[PATCH v3 26/26] lxc: Remove unused includes

Signed-off-by: Peng Liang --- src/lxc/lxc_cgroup.c | 3 --- src/lxc/lxc_cgroup.h | 1 - src/lxc/lxc_conf.c | 1 - src/lxc/lxc_conf.h | 4 src/lxc/lxc_container.c | 2 -- src/lxc/lxc_container.h | 1 - src/lxc/lxc_controller.c | 4 src/lxc/lxc_domain.c | 2 --

[PATCH v3 25/26] tests: Remove unused includes

Signed-off-by: Peng Liang --- tests/commandtest.c | 2 -- tests/cputest.c | 2 -- tests/domainconftest.c | 2 -- tests/esxutilstest.c| 1 - tests/eventtest.c | 2 -- tests/fchosttest.c

[PATCH v3 12/26] network: Remove unused includes

Signed-off-by: Peng Liang --- src/network/bridge_driver.c | 5 - src/network/bridge_driver.h | 2 -- src/network/bridge_driver_linux.c | 1 - src/network/leaseshelper.c| 3 --- 4 files changed, 11 deletions(-) diff --git a/src/network/bridge_driver.c

[PATCH v3 08/26] hypvervisor: Remove unused includes

Signed-off-by: Peng Liang --- src/hypervisor/domain_driver.h | 1 - src/hypervisor/virhostdev.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/src/hypervisor/domain_driver.h b/src/hypervisor/domain_driver.h index 7b0fbae2fd..4241c86932 100644 --- a/src/hypervisor/domain_driver.h +++

[PATCH v3 01/26] access: Remove unused includes

Signed-off-by: Peng Liang --- src/access/viraccessdriver.h | 1 - src/access/viraccessdriverpolkit.c | 4 src/access/viraccessdriverstack.c | 1 - src/access/viraccessmanager.h | 1 - 4 files changed, 7 deletions(-) diff --git a/src/access/viraccessdriver.h

[PATCH v3 21/26] vmware: Remove unused includes

Signed-off-by: Peng Liang --- src/vmware/vmware_conf.c | 1 - src/vmware/vmware_driver.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index ebba435cc4..80a85f4d0f 100644 --- a/src/vmware/vmware_conf.c +++ b/src/vmware/vmware_conf.c @@

[PATCH v3 23/26] test_driver: Remove unused includes

Signed-off-by: Peng Liang --- src/test/test_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a824ef0186..24ff6e8967 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -31,7 +31,6 @@ #include "virerror.h"

[PATCH v3 09/26] libxl: Remove unused includes

Signed-off-by: Peng Liang --- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 3 --- src/libxl/libxl_conf.h | 2 -- src/libxl/libxl_domain.c | 1 - src/libxl/libxl_domain.h | 2 -- src/libxl/libxl_driver.c |

Re: [Questions] non-shared disk migration: jobs abort and bandwidth

On Wed, Jun 08, 2022 at 17:32:57 +0800, Han Han wrote: > Hi developers, > Recently, I am researching migration with non-share disk(flags > VIR_MIGRATE_NON_SHARED_DISK and VIR_MIGRATE_NON_SHARED_INC). > As we know, the non-shared disk migration could have block jobs to copy the > disk image from

Re: [PATCH v2 01/30] access: Remove unused includes

On 6/7/2022 10:15 PM, Ján Tomko wrote: > On a Saturday in 2022, Peng Liang wrote: >> Signed-off-by: Peng Liang >> --- >> src/access/viraccessdriver.h   | 1 - >> src/access/viraccessdriverpolkit.c | 4 >> src/access/viraccessdriverstack.c  | 1 - >> src/access/viraccessmanager.h  | 1

[Questions] non-shared disk migration: jobs abort and bandwidth

Hi developers, Recently, I am researching migration with non-share disk(flags VIR_MIGRATE_NON_SHARED_DISK and VIR_MIGRATE_NON_SHARED_INC). As we know, the non-shared disk migration could have block jobs to copy the disk image from the src host to the dst host. So here are my questions for

[PATCH] storage: zfs: split pool and volume names properly

Before, the volume name was determined as the last token after any / character. This does not work with zvols below the top level of the pool: /dev/zvols/pool/images/vm1 is truncated to /dev/zvols/pool/vm1. This patch removes the pool name only, so when using the pool "pool", the volume path

Re: [libvirt PATCH] qemu: Improve error messages using qemuMigrationJobName

On Wed, Jun 08, 2022 at 10:12:08AM +0200, Jiri Denemark wrote: They were constructed from two separate strings using "%s: %s", which is ugly and does not work well with translations. Signed-off-by: Jiri Denemark Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

[libvirt PATCH] qemu: Improve error messages using qemuMigrationJobName

They were constructed from two separate strings using "%s: %s", which is ugly and does not work well with translations. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 52 ++- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git

Re: [libvirt PATCH 2/2] ci: integration: Set 'safe.directory' when installing QEMU from git

On Wed, Jun 08, 2022 at 07:59:37AM +0200, Erik Skultety wrote: > Since a fix for CVE-2022-24765 was released every git command is now > checked against the context repo in which it's supposed to run > resulting in a fatal error if the repo is owned by other user than the > one running the git