[PATCH] libxl: Fix domain startup failure error reporting

2022-06-17 Thread Cole Robinson
When domain startup fails, domain cleanup calls libxlNetworkUnwindDevices, which calls virGetConnectNetwork, which is a top level API entry point, which resets the initial saved error, leading to clients seeing: error: An error occurred, but the cause is unknown This preserves the error from

Re: [libvirt PATCH 0/2] tools: add integrated support for XPath in virsh

2022-06-17 Thread Michal Prívozník
On 6/17/22 10:00, Daniel P. Berrangé wrote: > On Fri, Jun 17, 2022 at 09:09:09AM +0200, Michal Prívozník wrote: >> On 6/16/22 17:36, Daniel P. Berrangé wrote: >>> See commit 2 for the example usage >>> >>> Daniel P. Berrangé (2): >>> tools: add helper method for printing an XML document >>>

Re: [PATCH] po/LINGUAS: Fix sorting

2022-06-17 Thread Daniel P . Berrangé
On Fri, Jun 17, 2022 at 05:09:38AM -0700, Andrea Bolognani wrote: > On Tue, Jun 14, 2022 at 01:52:28PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote: > > > Pushed as a build fix. Whether that syntax check is a sensible use of > > > CPU cycles is

Re: [PATCH] po/LINGUAS: Fix sorting

2022-06-17 Thread Andrea Bolognani
On Tue, Jun 14, 2022 at 01:52:28PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 14, 2022 at 02:39:46PM +0200, Peter Krempa wrote: > > Pushed as a build fix. Whether that syntax check is a sensible use of > > CPU cycles is for another discussion. > > po/LINGUAS is created by weblate automatically

Re: [libvirt PATCH 0/2] tools: add integrated support for XPath in virsh

2022-06-17 Thread Daniel P . Berrangé
On Fri, Jun 17, 2022 at 09:09:09AM +0200, Michal Prívozník wrote: > On 6/16/22 17:36, Daniel P. Berrangé wrote: > > See commit 2 for the example usage > > > > Daniel P. Berrangé (2): > > tools: add helper method for printing an XML document > > tools: add '--xpath EXPRESSION --wrap' args to

Re: [libvirt PATCH 0/2] tools: add integrated support for XPath in virsh

2022-06-17 Thread Michal Prívozník
On 6/16/22 17:36, Daniel P. Berrangé wrote: > See commit 2 for the example usage > > Daniel P. Berrangé (2): > tools: add helper method for printing an XML document > tools: add '--xpath EXPRESSION --wrap' args to all dumpxml commands > > docs/manpages/virsh.rst | 138