On a Thursday in 2022, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé
---
mingw-libvirt.spec.in | 4
1 file changed, 4 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2022, Martin Kletzander wrote:
Descriptions in second and third patch ought to be enough.
for everyone.
Martin Kletzander (3):
vmx: Fix indentation
conf, docs: Add support for dummy network interface
vmx: Add support for dummy network interface
docs/formatdomain.rst
On a Tuesday in 2022, Peter Krempa wrote:
Starting with libvirt-8.7.0 we'll support qemu-4.2 as minimum and thus
we'll only use -blockdev now. Remove the old cruft.
This series applies on top of the patches bumping minimum qemu version
to qemu-4.2 I've posted earlier.
The whole branch can be
On a Tuesday in 2022, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 2 +-
src/qemu/qemu_checkpoint.c | 2 +-
src/qemu/qemu_domain.c | 10 +++---
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_driver.c | 6 +++---
src/qemu/qemu_snapshot.c | 13
On a Tuesday in 2022, Peter Krempa wrote:
This function and it's callees were a bit more entangled so remove the
s/it's/its/
pre-blockdev code separately.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 80 +++---
1 file changed, 12
On a Tuesday in 2022, Peter Krempa wrote:
With blockdev we are generating the nodenames ourselves so all of this
infrastructrure became obsolete. Remove it.
*infrastructure
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 274 ---
src/qemu/qemu_block.h
On a Tuesday in 2022, Peter Krempa wrote:
The cleanup of the code to always assume support for QEMU_CAPS_BLOCKDEV
will not be simple, so for now we hardcode the support and the code will
be cleaned up gradually.
We also disallow users to clear the flags via the namespace property or
qemu.conf
On a Friday in 2022, Peter Krempa wrote:
In August Debian 10 officially reaches EOL, thus we can bump minimum
qemu version to 4.2 which is being limited by Ubuntu and RHEL/Centos 8.
QEMU-4.2 allows us to remove a big bunch of old code though. Few
examples which this series (and the next
On a Friday in 2022, Peter Krempa wrote:
Minimum qemu version is going to be bumped to qemu-4.2. Upgrading the
version of these tests don't make sense as the host cpu in the real
*doesn't
capabilities doesn't support the features the tests are attempting to
test.
Signed-off-by: Peter Krempa
On a Friday in 2022, Peter Krempa wrote:
Upcoming patches will bump minimum supported qemu version to 4.2 which
will use '-blockdev' with qemu so we can drop all the old test cases for
pre-blockdev configs.
Signed-off-by: Peter Krempa
---
.../blkdeviotune-group-num.x86_64-4.1.0.args | 37
On a Friday in 2022, Peter Krempa wrote:
Upcoming patches will bump minimum qemu version to 4.2. In this case we
the 'latest' case is suffuicient as with qemu-4.2 we already behave as
*sufficient
upstream ('qemu64' cpu is used instead of 'qemu32').
Signed-off-by: Peter Krempa
---
On a Friday in 2022, Peter Krempa wrote:
Alpine-314 was dropped by lcitool recently.
Debian-10 will reach EOL in August, so patches 2-3/3 should
be pushed only after the upcoming release.
Pipeline: https://gitlab.com/pipo.sk/libvirt/-/pipelines/594315458
Peter Krempa (3):
ci: Move builds
On Thu, 4 Aug 2022 15:11:07 -0400
Laine Stump wrote:
> On 8/4/22 2:36 PM, Jason Gunthorpe wrote:
> > On Thu, Aug 04, 2022 at 12:18:26PM -0600, Alex Williamson wrote:
> >> On Thu, 4 Aug 2022 13:51:20 -0300
> >> Jason Gunthorpe wrote:
> >>
> >>> On Mon, Aug 01, 2022 at 09:49:28AM -0600, Alex
On 8/4/22 2:36 PM, Jason Gunthorpe wrote:
On Thu, Aug 04, 2022 at 12:18:26PM -0600, Alex Williamson wrote:
On Thu, 4 Aug 2022 13:51:20 -0300
Jason Gunthorpe wrote:
On Mon, Aug 01, 2022 at 09:49:28AM -0600, Alex Williamson wrote:
Fortunately these new vendor/device-specific drivers can be
On Thu, 4 Aug 2022 13:51:20 -0300
Jason Gunthorpe wrote:
> On Mon, Aug 01, 2022 at 09:49:28AM -0600, Alex Williamson wrote:
>
> > > > > > Fortunately these new vendor/device-specific drivers can be easily
> > > > > > identified as being "vfio-pci + extra stuff" - all that's needed is
> > > > >
On Tue, Jul 26, 2022 at 04:37:15PM +0200, Peter Krempa wrote:
> The only instance in this file can be simplified to avoid checking the
> capability.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_alias.c | 10 --
> src/qemu/qemu_alias.h | 5 ++---
> src/qemu/qemu_hotplug.c |
On Tue, Jul 26, 2022 at 04:37:14PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_blockjob.c | 30 +++---
> 1 file changed, 3 insertions(+), 27 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Tue, Jul 26, 2022 at 04:37:13PM +0200, Peter Krempa wrote:
> With blockdev we are generating the nodenames ourselves so all of this
> infrastructrure became obsolete. Remove it.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c | 274 ---
>
On Tue, Jul 26, 2022 at 04:37:12PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_driver.c | 12
> 1 file changed, 12 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Tue, Jul 26, 2022 at 04:37:11PM +0200, Peter Krempa wrote:
> We no longer need it as we use the more modern job events.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_monitor.c | 14 --
> src/qemu/qemu_monitor.h | 12 -
> src/qemu/qemu_monitor_json.c | 90
On Tue, Jul 26, 2022 at 04:37:10PM +0200, Peter Krempa wrote:
> Previous patches removed the job submission for the handler so now even
> the handler itself can be removed.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_domain.c | 1 -
> src/qemu/qemu_domain.h | 1 -
>
On Tue, Jul 26, 2022 at 04:37:09PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_blockjob.c | 136 +--
> 1 file changed, 1 insertion(+), 135 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Tue, Jul 26, 2022 at 04:37:08PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_process.c | 182 +---
> 1 file changed, 2 insertions(+), 180 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Tue, Jul 26, 2022 at 04:37:07PM +0200, Peter Krempa wrote:
> All supported qemu versions now work with blockdev.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_validate.c | 14 --
> 1 file changed, 14 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description:
On Tue, Jul 26, 2022 at 04:37:06PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration_cookie.c | 19 ++-
> 1 file changed, 6 insertions(+), 13 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Tue, Jul 26, 2022 at 04:37:05PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_backup.c| 2 +-
> src/qemu/qemu_block.c | 10 +-
> src/qemu/qemu_block.h | 1 -
> src/qemu/qemu_migration.c | 2 +-
> 4 files changed, 3 insertions(+), 12
On Tue, Jul 26, 2022 at 04:37:04PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c| 20
> src/qemu/qemu_block.h| 6 --
> src/qemu/qemu_monitor.c | 12
> src/qemu/qemu_monitor.h | 6 --
>
On Tue, Jul 26, 2022 at 04:37:03PM +0200, Peter Krempa wrote:
> Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
> when it's not.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_snapshot.c | 116 +--
> 1 file changed, 15
Signed-off-by: Daniel P. Berrangé
---
mingw-libvirt.spec.in | 4
1 file changed, 4 insertions(+)
diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in
index dbcb6d4b8f..5a04ff7223 100644
--- a/mingw-libvirt.spec.in
+++ b/mingw-libvirt.spec.in
@@ -202,6 +202,7 @@ rm -rf
On Tue, Jul 26, 2022 at 04:37:02PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h | 2 +-
> tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
>
On Tue, Jul 26, 2022 at 04:37:01PM +0200, Peter Krempa wrote:
> The migration code was using few blockdev bits before blockdev was
> fully integrated to allow TLS with NBD.
>
> Since we now always use blockdev we can remove the check.
>
> Signed-off-by: Peter Krempa
> ---
>
On Tue, Jul 26, 2022 at 04:37:00PM +0200, Peter Krempa wrote:
> We no longer need the arguments which were conditionally filled based on
> presence of the QEMU_CAPS_BLOCKDEV feature.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 16
> 1 file changed, 8
On Thu, Aug 04, 2022 at 12:52:43PM +0200, Michal Privoznik wrote:
After QEMU is killed in qemuProcessStop() its mount namespace
doesn't exist anymore, because it was the only process running
there. Thus we should clear our internal flag that the domain has
namespace enabled so that seclabel
Signed-off-by: Martin Kletzander
---
src/vmx/vmx.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index f7261f5d2d96..318696fd56d5 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
@@ -3925,7 +3925,7 @@
Also map it to an ethernet without connectionType and networkName.
https://bugzilla.redhat.com/show_bug.cgi?id=1988211
Signed-off-by: Martin Kletzander
---
src/vmx/vmx.c | 21 ++---
.../vmx2xmldata/ethernet-unmanaged-nodev.vmx | 7 ++
Signed-off-by: Martin Kletzander
---
docs/formatdomain.rst | 24
src/ch/ch_monitor.c | 1 +
src/conf/domain_conf.c| 10 ++
src/conf/domain_conf.h| 1 +
src/conf/netdev_bandwidth_conf.c | 1 +
Descriptions in second and third patch ought to be enough.
Martin Kletzander (3):
vmx: Fix indentation
conf, docs: Add support for dummy network interface
vmx: Add support for dummy network interface
docs/formatdomain.rst | 24 ++
src/ch/ch_monitor.c
On Thu, Aug 04, 2022 at 12:16:42PM +0200, Andrea Bolognani wrote:
> In most cases, disabling the secure-boot or the enrolled-keys
> firmware feature will achieve the same result: allowing an
> unsigned operating system to run.
>
> Right now we're only documenting the latter configuration. Add
>
On Thu, Aug 04, 2022 at 12:16:41PM +0200, Andrea Bolognani wrote:
> It should be enough to enable or disable the enrolled-keys feature
> to control whether Secure Boot is enforced, but there's a slight
> complication: many distro packages for edk2 include, in addition
> to general purpose firmware
After QEMU is killed in qemuProcessStop() its mount namespace
doesn't exist anymore, because it was the only process running
there. Thus we should clear our internal flag that the domain has
namespace enabled so that seclabel restore code does not try to
enter it. We do the same in
The non-Linux version of virHostCPUGetPhysAddrSize() is lacking
G_GNUC_UNUSED attribute to its @size argument which triggers an
error on all non-Linux builds. And while at it, make the function
actually signal error (ENOSYS) since it does not set the
argument.
Signed-off-by: Michal Privoznik
---
In most cases, disabling the secure-boot or the enrolled-keys
firmware feature will achieve the same result: allowing an
unsigned operating system to run.
Right now we're only documenting the latter configuration. Add
the former as well, and explain the difference between the two.
Signed-off-by:
Changes from [v1]:
* document configuration where Secure Boot support is completely
absent, not just inactive;
* explain in more detail how the various firmware features interact
with one another.
[v1] https://listman.redhat.com/archives/libvir-list/2022-August/233449.html
Andrea
It should be enough to enable or disable the enrolled-keys feature
to control whether Secure Boot is enforced, but there's a slight
complication: many distro packages for edk2 include, in addition
to general purpose firmware images, builds that are targeting the
Confidential Computing use case.
On Thu, Aug 04, 2022 at 10:29:12AM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 04, 2022 at 03:32:32AM -0500, Andrea Bolognani wrote:
> > On Wed, Aug 03, 2022 at 05:29:15PM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andrea Bolognani wrote:
> > > >
> > >
On Thu, Aug 04, 2022 at 03:32:32AM -0500, Andrea Bolognani wrote:
> On Wed, Aug 03, 2022 at 05:29:15PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andrea Bolognani wrote:
> > >
> > >
> > > +
> > >
> > >
> > >
> >
> > If we want
On Wed, Aug 03, 2022 at 05:29:15PM +0100, Daniel P. Berrangé wrote:
> On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andrea Bolognani wrote:
> >
> >
> > +
> >
> >
> >
>
> If we want secureboot disabled, this looks wrong. It just enables
> secureboot, but without any
On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> Signed-off-by: Han Han
> ---
> README.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.rst b/README.rst
> index eacbbf2..ee20e85 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -13,7 +13,7 @@ API
On Thu, Aug 4, 2022 at 3:35 PM Erik Skultety wrote:
> On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> > Signed-off-by: Han Han
> > ---
> > README.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index eacbbf2..ee20e85
On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> Signed-off-by: Han Han
> ---
> README.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.rst b/README.rst
> index eacbbf2..ee20e85 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -13,7 +13,7 @@ API
50 matches
Mail list logo
