Re: [PATCH] util: basic support for vendor-specific vfio drivers

On 8/5/22 2:20 PM, Jason Gunthorpe wrote: On Fri, Aug 05, 2022 at 11:24:08AM -0600, Alex Williamson wrote: On Thu, 4 Aug 2022 21:11:07 -0300 Jason Gunthorpe wrote: On Thu, Aug 04, 2022 at 01:36:24PM -0600, Alex Williamson wrote: That is reasonable, but I'd say those three kernels only have

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On 8/5/22 2:56 PM, Alex Williamson wrote: On Fri, 5 Aug 2022 15:20:24 -0300 Jason Gunthorpe wrote: On Fri, Aug 05, 2022 at 11:24:08AM -0600, Alex Williamson wrote: On Thu, 4 Aug 2022 21:11:07 -0300 Jason Gunthorpe wrote: On Thu, Aug 04, 2022 at 01:36:24PM -0600, Alex Williamson wrote:

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Fri, 5 Aug 2022 15:20:24 -0300 Jason Gunthorpe wrote: > On Fri, Aug 05, 2022 at 11:24:08AM -0600, Alex Williamson wrote: > > On Thu, 4 Aug 2022 21:11:07 -0300 > > Jason Gunthorpe wrote: > > > > > On Thu, Aug 04, 2022 at 01:36:24PM -0600, Alex Williamson wrote: > > > > > > > > > That is

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Thu, 4 Aug 2022 21:11:07 -0300 Jason Gunthorpe wrote: > On Thu, Aug 04, 2022 at 01:36:24PM -0600, Alex Williamson wrote: > > > > > That is reasonable, but I'd say those three kernels only have two > > > > drivers and they both have vfio as a substring in their name - so the > > > > simple

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Fri, Aug 05, 2022 at 11:46:17AM -0400, Laine Stump wrote: > On 8/5/22 5:40 AM, Daniel P. Berrangé wrote: > > On Mon, Aug 01, 2022 at 09:30:38AM -0400, Laine Stump wrote: > > > On 8/1/22 7:58 AM, Erik Skultety wrote: > > > > > > > > Instead of calling an external program and then grepping its

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On 8/5/22 5:40 AM, Daniel P. Berrangé wrote: On Mon, Aug 01, 2022 at 09:30:38AM -0400, Laine Stump wrote: On 8/1/22 7:58 AM, Erik Skultety wrote: Instead of calling an external program and then grepping its output which technically could change in the future, wouldn't it be better if we read

[PULL 0/6] Misc next patches

The following changes since commit 09ed077d7fae5f825e18ff9a2004dcdd1b165edb: Merge tag 'trivial-branch-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-04 17:21:13 -0700) are available in the Git repository at: https://gitlab.com/berrange/qemu

[PULL 6/6] util/qemu-sockets: Replace the call to close a socket with closesocket()

From: Bin Meng close() is a *nix function. It works on any file descriptor, and sockets in *nix are an example of a file descriptor. closesocket() is a Windows-specific function, which works only specifically with sockets. Sockets on Windows do not use *nix-style file descriptors, and socket()

[PULL 5/6] target/arm: display deprecation status in '-cpu help'

When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Reviewed-by: Cornelia Huck Signed-off-by: Daniel P. Berrangé --- target/arm/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PULL 4/6] target/s390x: display deprecation status in '-cpu help'

When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Reviewed-by: Cornelia Huck Signed-off-by: Daniel P. Berrangé --- target/s390x/cpu_models.c | 23 ++- 1 file changed, 18 insertions(+), 5

[PULL 3/6] target/i386: display deprecation status in '-cpu help'

When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Reviewed-by: Cornelia Huck Signed-off-by: Daniel P. Berrangé --- target/i386/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PULL 2/6] QIOChannelSocket: Add support for MSG_ZEROCOPY + IPV6

From: Leonardo Bras For using MSG_ZEROCOPY, there are two steps: 1 - io_writev() the packet, which enqueues the packet for sending, and 2 - io_flush(), which gets confirmation that all packets got correctly sent Currently, if MSG_ZEROCOPY is used to send packets over IPV6, no error will be

[PULL 1/6] docs: build-platforms: Clarify stance on minor releases and backports

From: Andrea Bolognani These changes match those made in the following libvirt commits: 2ac78307af docs: Clarify our stance on backported packages 78cffd450a docs: Spell out our policy concerning minor releases Since QEMU's platform support policy is based on libvirt's, it makes sense to

Re: [PATCH] RFC: char: deprecate usage of bidirectional pipe

On Fri, Aug 05, 2022 at 01:55:41PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jul 26, 2022 at 12:44 PM Daniel P. Berrangé > wrote: > > > > On Tue, Jul 26, 2022 at 12:32:32PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > As Ed Swierk explained back in

Re: [PATCH] RFC: char: deprecate usage of bidirectional pipe

Hi On Tue, Jul 26, 2022 at 12:44 PM Daniel P. Berrangé wrote: > > On Tue, Jul 26, 2022 at 12:32:32PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > As Ed Swierk explained back in 2006: > > https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html > >

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Mon, Aug 01, 2022 at 09:30:38AM -0400, Laine Stump wrote: > On 8/1/22 7:58 AM, Erik Skultety wrote: > > > > Instead of calling an external program and then grepping its output which > > technically could change in the future, wouldn't it be better if we read > > /lib/modules/`uname

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Thu, Aug 04, 2022 at 01:51:20PM -0300, Jason Gunthorpe wrote: > On Mon, Aug 01, 2022 at 09:49:28AM -0600, Alex Williamson wrote: > > > > > > > Fortunately these new vendor/device-specific drivers can be easily > > > > > > identified as being "vfio-pci + extra stuff" - all that's needed is > >

Re: [PATCH] util: basic support for vendor-specific vfio drivers

On Thu, Aug 04, 2022 at 03:11:07PM -0400, Laine Stump wrote: > On 8/4/22 2:36 PM, Jason Gunthorpe wrote: > > On Thu, Aug 04, 2022 at 12:18:26PM -0600, Alex Williamson wrote: > > > On Thu, 4 Aug 2022 13:51:20 -0300 > > > Jason Gunthorpe wrote: > > > > > > > On Mon, Aug 01, 2022 at 09:49:28AM

Re: [PATCH 80/80] qemuDomainDetermineDiskChain: Remove 'report_broken' argument

On Tue, Jul 26, 2022 at 04:37:58PM +0200, Peter Krempa wrote: > All callers pass 'true'. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 36 +++- > src/qemu/qemu_domain.h | 3 +-- > src/qemu/qemu_driver.c | 2 +- > src/qemu/qemu_hotplug.c |

Re: [PATCH 79/80] qemu: Assume and retire QEMU_CAPS_BLOCKDEV_BACKUP

On Tue, Jul 26, 2022 at 04:37:57PM +0200, Peter Krempa wrote: > The blockdev-backup QMP command was introduced in qemu-2.3. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_backup.c| 6 -- > src/qemu/qemu_capabilities.c | 6 ++ >

Re: [PATCH 78/80] qemu: Assume support and retire QEMU_CAPS_BLOCK_WRITE_THRESHOLD

On Tue, Jul 26, 2022 at 04:37:56PM +0200, Peter Krempa wrote: > The event was introduced in qemu-2.3 > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_capabilities.c | 3 +-- > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_driver.c

Re: [PATCH 77/80] qemu: capabilities: Retire QEMU_CAPS_QUERY_NAMED_BLOCK_NODES

On Tue, Jul 26, 2022 at 04:37:55PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_capabilities.c | 3 +-- > src/qemu/qemu_capabilities.h | 2 +- > tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 - >

Re: [PATCH 76/80] qemu: Setup disk throttling for SD cards via monitor

On Tue, Jul 26, 2022 at 04:37:54PM +0200, Peter Krempa wrote: > Set it same way we set throttling for other disks in > qemuProcessSetupDiskThrottling. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 42 - > src/qemu/qemu_process.c | 20

Re: [PATCH 75/80] qemu: Retire QEMU_CAPS_BLOCKDEV

On Tue, Jul 26, 2022 at 04:37:53PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_capabilities.c | 13 + > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_process.c | 10

Re: [PATCH 74/80] qemuDomainDetermineDiskChain: Assume QEMU_CAPS_BLOCKDEV

On Tue, Jul 26, 2022 at 04:37:52PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 73/80] qemuDomainValidateStorageSource: Remove 'maskBlockdev' argument

On Tue, Jul 26, 2022 at 04:37:51PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 10 -- > src/qemu/qemu_domain.h | 3 +-- > src/qemu/qemu_validate.c | 6 ++ > tests/qemublocktest.c| 4 ++-- > 4 files changed, 9 insertions(+), 14

Re: [PATCH 72/80] qemuDomainValidateStorageSource: Remove QEMU_CAPS_BLOCKDEV validation

On Tue, Jul 26, 2022 at 04:37:50PM +0200, Peter Krempa wrote: > While we assume that -blockdev is supported the validator had also some > corner cases for -drive. Since we use '-drive' exclusively for the > extremely rarely used SD cards it makes no sense to have the validation. > >

Re: [PATCH 71/80] qemuDomainDiskGetBackendAlias: Assume QEMU_CAPS_BLOCKDEV is supported

On Tue, Jul 26, 2022 at 04:37:49PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_domain.c | 11 --- > src/qemu/qemu_domain.h | 4 +--- > src/qemu/qemu_hotplug.c | 2 +- > 4 files changed, 7 insertions(+), 12

Re: [PATCH 70/80] qemuDomainDiskBlockJobIsSupported: Assume QEMU_CAPS_BLOCKDEV is supported

On Tue, Jul 26, 2022 at 04:37:48PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_backup.c | 2 +- > src/qemu/qemu_checkpoint.c | 2 +- > src/qemu/qemu_domain.c | 10 +++--- > src/qemu/qemu_domain.h | 3 +-- > src/qemu/qemu_driver.c | 6

Re: [PATCH 69/80] qemuDomainSecretStorageSourcePrepare: Remove cabapbility check when preparing cookies

On Tue, Jul 26, 2022 at 04:37:47PM +0200, Peter Krempa wrote: > The capability is checked when we validate the source in the first > place. Also it won't make sense any more. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by:

Re: [PATCH 68/80] qemu: domain: Assume QEMU_CAPS_BLOCKDEV for the domain private code

On Tue, Jul 26, 2022 at 04:37:46PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c| 20 --- > .../blockjob-mirror-in.xml| 1 + > .../migration-in-params-in.xml| 1 + >

Re: [PATCH 67/80] qemu: command: Remove unused qemuGetDriveSourceString

On Tue, Jul 26, 2022 at 04:37:45PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 208 > src/qemu/qemu_command.h | 4 - > 2 files changed, 212 deletions(-) Reviewed-by: Pavel Hrdina signature.asc

Re: [PATCH 66/80] qemu: command: Generate -drive for SD cards via JSON props

On Tue, Jul 26, 2022 at 04:37:44PM +0200, Peter Krempa wrote: > Since we know we have a modern qemu at hand which can interpret the > dotted syntax, we can format the -drive needed for SD cards via the > common infrastructure we have for all blockdev stuff. > > Signed-off-by: Peter Krempa > ---

Re: [PATCH 65/80] qemu: command: Delegate qemuBuildDriveStr to SD cards only

On Tue, Jul 26, 2022 at 04:37:43PM +0200, Peter Krempa wrote: > Remove the generic frontend-less -drive code from qemuBuildDriveStr by > assuming that we support only blockdev-enabled qemus. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 15 ++- > 1 file changed,

Re: [PATCH 64/80] qemu: monitor: Remove unused qemuMonitorAddDrive/qemuMonitorDriveDel

On Tue, Jul 26, 2022 at 04:37:42PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 33 --- > src/qemu/qemu_monitor.h | 6 --- > src/qemu/qemu_monitor_text.c | 82 > src/qemu/qemu_monitor_text.h

Re: [PATCH 63/80] qemu: block: Remove support for legacy disk hotplug/unplug

On Tue, Jul 26, 2022 at 04:37:41PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 14 -- > src/qemu/qemu_block.h | 2 -- > src/qemu/qemu_command.c | 3 +-- > 3 files changed, 1 insertion(+), 18 deletions(-) Reviewed-by: Pavel Hrdina

Re: [PATCH 62/80] qemu: Remove 'driveAlias' argument of qemuBlockStorageSourceDetachPrepare

On Tue, Jul 26, 2022 at 04:37:40PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c| 33 + > src/qemu/qemu_block.h| 3 +-- > src/qemu/qemu_blockjob.c | 4 ++-- > src/qemu/qemu_hotplug.c | 2 +- > 4 files changed,

Re: [PATCH 61/80] qemu: block: Remove unused qemuBlockStorageSourceChainDetachPrepareLegacy

On Tue, Jul 26, 2022 at 04:37:39PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 26 -- > src/qemu/qemu_block.h | 3 --- > 2 files changed, 29 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 60/80] qemu: hotplug: Remove pre-blockdev code paths

On Tue, Jul 26, 2022 at 04:37:38PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_hotplug.c | 20 +++- > 1 file changed, 3 insertions(+), 17 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 59/80] qemuDomainRemoveDiskDevice: Remove special casing for disks on 'sd' bus

On Tue, Jul 26, 2022 at 04:37:37PM +0200, Peter Krempa wrote: > SD card disks can't be detached, so it makes no sense to special case > them in the unplug code. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [PATCH 58/80] qemuhotplugtest: Switch to -blockdev mode

On Tue, Jul 26, 2022 at 04:37:36PM +0200, Peter Krempa wrote: > Enable blockdev mode and convert the expected commands to the modern > equivalents in preparation for removing the old-style hotplug code > paths. > > Signed-off-by: Peter Krempa > --- > tests/qemuhotplugtest.c

Re: [PATCH 57/80] qemu: monitor: Remove unused qemuMonitor(Eject|Change)Media

On Tue, Jul 26, 2022 at 04:37:35PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 27 - > src/qemu/qemu_monitor.h | 9 -- > src/qemu/qemu_monitor_json.c | 57 >

Re: [PATCH 56/80] qemu: hotplug: Remove pre-blockdev code path from qemuDomainChangeEjectableMedia

On Tue, Jul 26, 2022 at 04:37:34PM +0200, Peter Krempa wrote: > All media are changed in blockdev-instantiated cdroms now, remove the > old code. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_hotplug.c | 88 + > 1 file changed, 1 insertion(+), 87

Re: [PATCH 55/80] qemu: driver: Remove remaining QEMU_CAPS_BLOCKDEV capability checks

On Tue, Jul 26, 2022 at 04:37:33PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 54/80] qemu: monitor: Remove unused qemuMonitorBlockStatsUpdateCapacity

On Tue, Jul 26, 2022 at 04:37:32PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 11 --- > src/qemu/qemu_monitor.h | 4 --- > src/qemu/qemu_monitor_json.c | 59 > src/qemu/qemu_monitor_json.h | 3 --

Re: [PATCH 53/80] qemuDomainBlocksStatsGather: Remove pre-blockdev code paths

On Tue, Jul 26, 2022 at 04:37:31PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 31 --- > 1 file changed, 12 insertions(+), 19 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 52/80] qemuDomainBlockResize: Always refuse resize of empty/readonly disks

On Tue, Jul 26, 2022 at 04:37:30PM +0200, Peter Krempa wrote: > The operation makes no sense regardless of the way how we specify disks. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Pavel

Re: [PATCH 51/80] qemu: Remove pre-blockdev PFLASH setup

On Tue, Jul 26, 2022 at 04:37:29PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 60 +++-- > src/qemu/qemu_domain.c | 5 +--- > 2 files changed, 10 insertions(+), 55 deletions(-) Reviewed-by: Pavel Hrdina

Re: [PATCH 50/80] qemu: command: Remove pre-blockdev floppy setup

On Tue, Jul 26, 2022 at 04:37:28PM +0200, Peter Krempa wrote: > With new qemu versions we setup floppies via -device. > > Some legacy output tests were not modernized yet so the expected output > needs to be adjusted. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_command.c | 50

Re: [PATCH 49/80] qemu: monitor: Remove unused qemuMonitorDrivePivot

On Tue, Jul 26, 2022 at 04:37:27PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 13 - > src/qemu/qemu_monitor.h | 3 --- > src/qemu/qemu_monitor_json.c | 23 --- > src/qemu/qemu_monitor_json.h | 5 - >

Re: [PATCH 48/80] qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockPivot

On Tue, Jul 26, 2022 at 04:37:26PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 50 +++--- > 1 file changed, 22 insertions(+), 28 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 47/80] qemu: monitor: Remove unused qemuMonitorDiskNameLookup

On Tue, Jul 26, 2022 at 04:37:25PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 14 --- > src/qemu/qemu_monitor.h | 5 --- > src/qemu/qemu_monitor_json.c | 77 > src/qemu/qemu_monitor_json.h | 8

Re: [PATCH 46/80] qemu: monitor: Remove unused arguments of qemuMonitorBlockStream

On Tue, Jul 26, 2022 at 04:37:24PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 2 -- > src/qemu/qemu_monitor.c | 15 +++ > src/qemu/qemu_monitor.h | 2 -- > src/qemu/qemu_monitor_json.c | 12 ++-- >

Re: [PATCH 45/80] qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockPullCommon

On Tue, Jul 26, 2022 at 04:37:23PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 41 ++--- > 1 file changed, 14 insertions(+), 27 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 44/80] qemu: monitor: Remove unused arguments of qemuMonitorBlockCommit

On Tue, Jul 26, 2022 at 04:37:22PM +0200, Peter Krempa wrote: > The 'persistjob' is always true and 'top' and 'base' are always NULL. > Adjust the functions to drop the arguments. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 3 --- > src/qemu/qemu_monitor.c | 15

Re: [PATCH 43/80] qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockCommit

On Tue, Jul 26, 2022 at 04:37:21PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 60 +- > 1 file changed, 13 insertions(+), 47 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 42/80] qemu: monitor: Remove unused qemuMonitorDriveMirror

On Tue, Jul 26, 2022 at 04:37:20PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor.c | 21 -- > src/qemu/qemu_monitor.h | 10 - > src/qemu/qemu_monitor_json.c | 41 >

Re: [PATCH 41/80] qemu: driver: Remove pre-blockdev code paths from qemuDomainBlockCopyCommon

On Tue, Jul 26, 2022 at 04:37:19PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 171 - > 1 file changed, 66 insertions(+), 105 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [PATCH 40/80] qemu: monitor: Remove unused qemuMonitorQueryNamedBlockNodes and clean up

On Tue, Jul 26, 2022 at 04:37:18PM +0200, Peter Krempa wrote: > The top level API is unused so it can be removed but internally the JSON > version is called by other monitor commands which extract information > from the reply. > > Thus qemuMonitorJSONQueryNamedBlockNodes is unexported and moved >

Re: [PATCH 39/80] qemu: block: Remove unused qemuBlockGetNodeData

On Tue, Jul 26, 2022 at 04:37:17PM +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 40 > src/qemu/qemu_block.h | 3 --- > 2 files changed, 43 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description:

Re: [PATCH 38/80] qemuDomainGetStatsBlock: Remove pre-blockdev code paths

On Tue, Jul 26, 2022 at 04:37:16PM +0200, Peter Krempa wrote: > This function and it's callees were a bit more entangled so remove the > pre-blockdev code separately. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 80 +++--- > 1 file