On Tue, Aug 09, 2022 at 06:22:12PM +0200, Tim Wiederhake wrote:
> The output of "virsh capabilities" was not conformant to the
> capability.rng schema. Add the missing element to the schema.
The RNG files are applied against every XML file under tests/,
so if we have an unnoticed gap in an RNG
The output of "virsh capabilities" was not conformant to the
capability.rng schema. Add the missing element to the schema.
Fixes: c647bf29afb9890c792172ecf7db2c9c27babbb6
Signed-off-by: Tim Wiederhake
---
src/conf/schemas/cputypes.rng | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Tue, Jul 19, 2022 at 04:17:45PM +0200, Andrea Bolognani wrote:
> Right now we're setting the prefix to a custom path, which
> results in paths like
>
> /builds/libvirt/libvirt/vroot/etc/libvirt/virtqemud.conf
>
> ending up in the generated HTML. In order to avoid that,
> set the prefix and
On Tue, Jul 19, 2022 at 04:17:44PM +0200, Andrea Bolognani wrote:
> meson already supports $DESTDIR natively, but in this case
> we're using a custom script and so we have to do some extra
> work ourselves.
>
> Signed-off-by: Andrea Bolognani
> ---
> scripts/meson-install-web.py | 13
On a Tuesday in 2022, Michal Privoznik wrote:
See 5/5 for explanation.
Michal Prívozník (5):
bridge_driver: Set @dnsmasqStarted only after successful dnsmasq spawn
bridge_driver: Use g_autoptr() for virMacMap
virNetworkObjSetMacMap: take double pointer of @macmap
bridge_driver: Introduce a
The virNetworkObjSetMacMap() API effectively steals passed
@macmap argument. However, the argument is a plain, first order
pointer. This requires every caller to set the argument to NULL
after the function was called. Let's make the function take
double pointer instead to make it obvious that the
Currently, whenever virNetworkObjSetMacMap() is called the same
pattern is used:
1) call virMacMapFileName() to generate a filename,
2) pass this filename to virMacMapNew(), and finally
3) pass retval from previous step to virNetworkObjSetMacMap().
Move this code into a helper
Let's annotate virMacMap variables in bridge_driver.c with
g_autoptr() so that they are automatically freed upon error. This
may look like a needless commit, since there's no memory leak
currently, but it simplifies the next commit.
Signed-off-by: Michal Privoznik
---
The networkStartNetworkVirtual() function handles starting of
networks of different forward types (none, nat, route, open).
And as a part of startup process dnsmasq might be spawned but
doesn't have to be (depending on the network configuration). The
@dnsmasqStarted variable is supposed to track
The virMacMap module is used only for libvirt_guests NSS module
as it records list of MAC addresses used by certain guest. But
the module itself is usable if and only if the network assigns IP
addresses (i.e. has dnsmasq running). If it's some other
authority that assigns IP addresses then we do
See 5/5 for explanation.
Michal Prívozník (5):
bridge_driver: Set @dnsmasqStarted only after successful dnsmasq spawn
bridge_driver: Use g_autoptr() for virMacMap
virNetworkObjSetMacMap: take double pointer of @macmap
bridge_driver: Introduce a helper for virNetworkObjSetMacMap()
On Tue, Aug 09, 2022 at 02:05:10PM +0200, Pavel Hrdina wrote:
> On Tue, Aug 09, 2022 at 12:59:36PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 09, 2022 at 01:56:43PM +0200, Pavel Hrdina wrote:
> > > On Tue, Aug 09, 2022 at 12:54:09PM +0100, Daniel P. Berrangé wrote:
> > > > On Tue, Aug 09,
On Tue, Aug 09, 2022 at 02:03:03PM +0200, Peter Krempa wrote:
> On Wed, Aug 03, 2022 at 17:45:07 +0200, Pavel Hrdina wrote:
> > On Tue, Jul 26, 2022 at 04:36:59PM +0200, Peter Krempa wrote:
> > > Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
> > > when it's not.
> > >
> >
On Tue, Aug 09, 2022 at 12:59:36PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 09, 2022 at 01:56:43PM +0200, Pavel Hrdina wrote:
> > On Tue, Aug 09, 2022 at 12:54:09PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 09, 2022 at 01:52:33PM +0200, Pavel Hrdina wrote:
> > > > On Mon, Aug 08,
On Wed, Aug 03, 2022 at 17:45:07 +0200, Pavel Hrdina wrote:
> On Tue, Jul 26, 2022 at 04:36:59PM +0200, Peter Krempa wrote:
> > Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
> > when it's not.
> >
> > Signed-off-by: Peter Krempa
> > ---
> > src/qemu/qemu_migration.c |
On Tue, Aug 09, 2022 at 01:56:43PM +0200, Pavel Hrdina wrote:
> On Tue, Aug 09, 2022 at 12:54:09PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Aug 09, 2022 at 01:52:33PM +0200, Pavel Hrdina wrote:
> > > On Mon, Aug 08, 2022 at 01:22:17PM -0400, Daniel P. Berrangé wrote:
> > > > One specfile
On Tue, Aug 09, 2022 at 12:54:09PM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 09, 2022 at 01:52:33PM +0200, Pavel Hrdina wrote:
> > On Mon, Aug 08, 2022 at 01:22:17PM -0400, Daniel P. Berrangé wrote:
> > > One specfile containing both native and mingw builds is the
> > > new best practice for
On Tue, Aug 09, 2022 at 01:52:33PM +0200, Pavel Hrdina wrote:
> On Mon, Aug 08, 2022 at 01:22:17PM -0400, Daniel P. Berrangé wrote:
> > One specfile containing both native and mingw builds is the
> > new best practice for Fedora. This reduces the maint burden
> > and ensures the mingw packages
On Mon, Aug 08, 2022 at 01:22:17PM -0400, Daniel P. Berrangé wrote:
> One specfile containing both native and mingw builds is the
> new best practice for Fedora. This reduces the maint burden
> and ensures the mingw packages don't fall behind.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
> On 9 Aug 2022, at 11:50, Andrea Bolognani wrote:
>
> On Tue, Aug 09, 2022 at 11:34:20AM +0200, Christophe de Dinechin wrote:
>> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote:
>>> Yeah, this seems to help and the change makes sense to me.
>>>
>>> I wonder why we didn't run into this much
On Tue, Aug 09, 2022 at 11:34:20AM +0200, Christophe de Dinechin wrote:
> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote:
> > Yeah, this seems to help and the change makes sense to me.
> >
> > I wonder why we didn't run into this much earlier though? As I
> > mentioned, the test runs
> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote:
>
> On Mon, Aug 08, 2022 at 08:19:28PM +0200, Christophe de Dinechin wrote:
>> Hi Andrea,
>>
>> I saw your call to Sergio and Marc-André on IRC, and I thought I would
>> spend a few minutes inviestigating.
>
> Thanks, I appreciate that!
>
On Mon, Aug 08, 2022 at 08:19:28PM +0200, Christophe de Dinechin wrote:
> Hi Andrea,
>
> I saw your call to Sergio and Marc-André on IRC, and I thought I would
> spend a few minutes inviestigating.
Thanks, I appreciate that!
> >> I'm trying to enable CI coverage for macOS 12, but I'm running
23 matches
Mail list logo
