[PATCH] libxl: adjust 'ich6' sound card name

2022-12-15 Thread Marek Marczykowski-Górecki
Xen 4.17 has strict parsing of 'soundhw' option that allows only specific values (instead of passing through any value directly to qemu's -soundhw option, it uses -device now). For 'intel-hda' audio device, it requires "hda" string. "hda" works with older libxl too. Other supported models are the

Re: [PATCH V2 9/9] kbase: Update rpm-deployment.rst with new subpackages

2022-12-15 Thread Daniel P . Berrangé
On Thu, Dec 15, 2022 at 07:50:43AM -0800, Andrea Bolognani wrote: > On Wed, Dec 14, 2022 at 02:55:30PM -0700, Jim Fehlig wrote: > > On 12/14/22 11:08, Andrea Bolognani wrote: > > > On Tue, Dec 13, 2022 at 05:31:02PM -0700, Jim Fehlig wrote: > > > > +* libvirt-daemon-plugin-lockd > > > > + This

Re: [PATCH V2 9/9] kbase: Update rpm-deployment.rst with new subpackages

2022-12-15 Thread Andrea Bolognani
On Wed, Dec 14, 2022 at 02:55:30PM -0700, Jim Fehlig wrote: > On 12/14/22 11:08, Andrea Bolognani wrote: > > On Tue, Dec 13, 2022 at 05:31:02PM -0700, Jim Fehlig wrote: > > > +* libvirt-daemon-plugin-lockd > > > + This package provides the lockd.so module, a daemon plugin for > > > communicating

Re: [PATCH V2 1/9] spec: Move virtlockd to a new subpackage libvirt-daemon-lock

2022-12-15 Thread Andrea Bolognani
On Thu, Dec 15, 2022 at 09:22:34AM +, Daniel P. Berrangé wrote: > On Wed, Dec 14, 2022 at 09:50:47AM -0800, Andrea Bolognani wrote: > > Actually, adding the libvirt-daemon-lock dependency to the sanlock > > package should happen in this patch instead of in 5/9. > > No we shouldn't, sanlock has

[libvirt PATCH 2/4] conf: Add job parameter to virDomainObjIsFailedPostcopy

2022-12-15 Thread Jiri Denemark
Unused for now, but this will change soon. Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c| 8 +--- src/conf/domain_conf.h| 6 -- src/qemu/qemu_driver.c| 4 ++-- src/qemu/qemu_migration.c | 22 +++--- src/qemu/qemu_process.c | 8 5

[libvirt PATCH 4/4] virDomainObjGetState: Promote VIR_DOMAIN_PAUSED_POSTCOPY_FAILED

2022-12-15 Thread Jiri Denemark
In case a domain is in failed post-copy migration but paused for a different reason, report VIR_DOMAIN_PAUSED_POSTCOPY_FAILED instead to make it more visible. --- Notes: This commit is intentionally missing Signed-off-by: Jiri Denemark because I can find reasons for

[libvirt PATCH 3/4] qemu: Remember failed post-copy migration in job

2022-12-15 Thread Jiri Denemark
When post-copy migration fails, the domain stays running on the destination with a VIR_DOMAIN_RUNNING_POSTCOPY_FAILED reason. Both the state and the reason can later be rewritten in case the domain gets paused for other reasons (such as an I/O error). Thus we need a separate place to remember the

[libvirt PATCH 0/4] qemu: Fix post-copy recovery after dest domain gets paused

2022-12-15 Thread Jiri Denemark
See 3/4 for details. Jiri Denemark (4): conf: Drop virDomainJobOperation parameter from virDomainObjIsPostcopy conf: Add job parameter to virDomainObjIsFailedPostcopy qemu: Remember failed post-copy migration in job virDomainObjGetState: Promote VIR_DOMAIN_PAUSED_POSTCOPY_FAILED

[libvirt PATCH 1/4] conf: Drop virDomainJobOperation parameter from virDomainObjIsPostcopy

2022-12-15 Thread Jiri Denemark
The parameter was only used to select which states correspond to an active or failed post-copy migration. But these states are either applicable to both operations or the check would just paper over a code bug in case of an impossible combination of state and operation. By dropping the check we

[libvirt PATCHv2 2/2] qemu: add tests for external swtpm

2022-12-15 Thread Ján Tomko
Signed-off-by: Ján Tomko --- .../tpm-external.x86_64-latest.args | 36 +++ tests/qemuxml2argvtest.c | 1 + 2 files changed, 37 insertions(+) create mode 100644 tests/qemuxml2argvdata/tpm-external.x86_64-latest.args diff --git

[libvirt PATCHv2 1/2] qemu: add external backend for tpm

2022-12-15 Thread Ján Tomko
Introduce a new backend type 'external' for connecting to a swtpm daemon not managed by libvirtd. Mostly in one commit, thanks to -Wswitch and the way we generate capabilities. https://bugzilla.redhat.com/show_bug.cgi?id=2063723 Signed-off-by: Ján Tomko --- src/conf/domain_audit.c

[libvirt PATCHv2 0/2] add external backend for tpm

2022-12-15 Thread Ján Tomko
v2: add more chardev-like attributes to the source https://bugzilla.redhat.com/show_bug.cgi?id=2063723 Ján Tomko (2): qemu: add external backend for tpm qemu: add tests for external swtpm src/conf/domain_audit.c | 11 + src/conf/domain_conf.c

[libvirt PATCH] qemu: tpm: fix spacing

2022-12-15 Thread Ján Tomko
Signed-off-by: Ján Tomko --- Pushed as trivial src/qemu/qemu_tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 0939f64e4e..36d5beb202 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -213,7 +213,7 @@

Re: [PATCH V2 8/9] spec: Remove libvirt-daemon dependency from hypervisor subpackages

2022-12-15 Thread Daniel P . Berrangé
On Tue, Dec 13, 2022 at 05:31:01PM -0700, Jim Fehlig wrote: > Remove the libvirt-daemon dependency from the various > libvirt-daemon- subpackages, replacing it with a set of the > new sub subpackages providing the same functionality. > > Signed-off-by: Jim Fehlig > --- > libvirt.spec.in | 21

Re: [PATCH V2 7/9] spec: Remove libvirt-daemon dependency from drivers

2022-12-15 Thread Daniel P . Berrangé
On Tue, Dec 13, 2022 at 05:31:00PM -0700, Jim Fehlig wrote: > To avoid needlessly installing the monolithic daemon, replace the > libvirt-daemon dependency with libvirt-daemon-common. The common > subpackage contains all the utilities (e.g. virt-admin) and files > used by other daemons. > >

Re: [PATCH V2 6/9] spec: Move common files to a new subpackage libvirt-daemon-common

2022-12-15 Thread Daniel P . Berrangé
On Wed, Dec 14, 2022 at 09:56:28AM -0800, Andrea Bolognani wrote: > On Tue, Dec 13, 2022 at 05:30:59PM -0700, Jim Fehlig wrote: > > @@ -450,7 +446,6 @@ Requires: module-init-tools > > Requires: iproute > > # for /sbin/tc > > Requires: iproute-tc > > -Requires: polkit >= 0.112 > > %if

Re: [PATCH V2 4/9] spec: Move lockd plugin to a new subpackage

2022-12-15 Thread Daniel P . Berrangé
On Tue, Dec 13, 2022 at 05:30:57PM -0700, Jim Fehlig wrote: > Introduce the libvirt-daemon-plugin-lockd subpackage to provide the > client-side lockd plugin for virtlockd. > > The sanlock plugin also needs the directory %{_libdir}/libvirt/lock-driver, > which it currently gets via the

Re: [PATCH V2 1/9] spec: Move virtlockd to a new subpackage libvirt-daemon-lock

2022-12-15 Thread Daniel P . Berrangé
On Wed, Dec 14, 2022 at 09:50:47AM -0800, Andrea Bolognani wrote: > On Wed, Dec 14, 2022 at 09:31:31AM -0800, Andrea Bolognani wrote: > > On Tue, Dec 13, 2022 at 05:30:54PM -0700, Jim Fehlig wrote: > > > Signed-off-by: Jim Fehlig > > > Reviewed-by: Daniel P. Berrangé > > > --- > > >

Re: [PATCH V2 5/9] spec: Rename the libvirt-lock-sanlock subpackage

2022-12-15 Thread Daniel P . Berrangé
On Tue, Dec 13, 2022 at 05:30:58PM -0700, Jim Fehlig wrote: > The new name "libvirt-daemon-plugin-sanlock" provides consistency with the > newly introduced "libvirt-daemon-plugin-lockd" subpackage. > > Signed-off-by: Jim Fehlig > --- > libvirt.spec.in | 9 ++--- > 1 file changed, 6