[PATCH] qemu_namespace: Umount the original /dev before replacing it with tmpfs

2022-12-16 Thread Michal Privoznik
Our code relies on mount events propagating into the namespace we create for a domain. However, there's one caveat. In v8.8.0-rc1~8 I've tried to make us detect differences in mount tables between the namespace in which libvirtd runs and the domain namespace. This is crucial for any mounts that

Re: [PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE

2022-12-16 Thread Fabiano Rosas
Daniel P. Berrangé writes: > This has been replaced by the 'password-secret' option, > which references a 'secret' object instance. > > Reviewed-by: Markus Armbruster > Signed-off-by: Daniel P. Berrangé Reviewed-by: Fabiano Rosas Just a small detail below. > --- >

Re: [PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

2022-12-16 Thread Fabiano Rosas
Daniel P. Berrangé writes: > Support for referencing secret objects was added in > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > Author: Daniel P. Berrangé > Date: Thu Jan 21 14:19:21 2016 + > > iscsi: add support for getting CHAP password via QCryptoSecret API > > The

Re: [PATCH v2 1/3] block: mention 'password-secret' option for -iscsi

2022-12-16 Thread Fabiano Rosas
Daniel P. Berrangé writes: > The 'password-secret' option was added > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > Author: Daniel P. Berrangé > Date: Thu Jan 21 14:19:21 2016 + > > iscsi: add support for getting CHAP password via QCryptoSecret API > > but was not

[PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

2022-12-16 Thread Daniel P . Berrangé
Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is overdue for

[PATCH v2 1/3] block: mention 'password-secret' option for -iscsi

2022-12-16 Thread Daniel P . Berrangé
The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Reviewed-by:

[PATCH v2 0/3] More work on deprecation/removal of clear text passwords

2022-12-16 Thread Daniel P . Berrangé
This deprecates the -iscsi clear text 'password' option and deletes the previously deprecated -spice 'password' option. Changed in v2: * Fixed section placement for iscsi deprecation docs * Fixed missing brackets in -iscsi help * Write in past tense for -spice password removal docs Daniel P.

[PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE

2022-12-16 Thread Daniel P . Berrangé
This has been replaced by the 'password-secret' option, which references a 'secret' object instance. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 8 docs/about/removed-features.rst | 7 +++ qemu-options.hx

Re: [PATCH 1/3] block: mention 'password-secret' option for -iscsi

2022-12-16 Thread Daniel P . Berrangé
On Thu, Dec 01, 2022 at 09:58:12AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > The 'password-secret' option was added > > > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > > Author: Daniel P. Berrangé > > Date: Thu Jan 21 14:19:21 2016 + > > > > iscsi: add

Re: [libvirt PATCHv2 0/2] add external backend for tpm

2022-12-16 Thread Michal Prívozník
On 12/15/22 14:56, Ján Tomko wrote: > v2: add more chardev-like attributes to the source > > https://bugzilla.redhat.com/show_bug.cgi?id=2063723 > > Ján Tomko (2): > qemu: add external backend for tpm > qemu: add tests for external swtpm > > 63 files changed, 236 insertions(+), 2

Re: [libvirt PATCHv2 1/2] qemu: add external backend for tpm

2022-12-16 Thread Michal Prívozník
On 12/15/22 14:56, Ján Tomko wrote: > Introduce a new backend type 'external' for connecting to a swtpm daemon > not managed by libvirtd. > > Mostly in one commit, thanks to -Wswitch This is true. > and the way we generate capabilities. > But I'm failing to see why capabilities had to be in