Re: [PATCH 1/4] conf: add loader type 'none'

2023-03-28 Thread Daniel Henrique Barboza
On 3/22/23 13:37, Andrea Bolognani wrote: On Wed, Mar 22, 2023 at 10:36:20AM -0300, Daniel Henrique Barboza wrote: I'm not sure if the OS overwrites the firmware when running bare metal. Usually they provide different OS images for QEMU/libvirt and bare metal systems, probably to account

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Michal Prívozník
On 3/28/23 14:54, Andrea Bolognani wrote: > On Tue, Mar 28, 2023 at 02:29:10PM +0200, Michal Prívozník wrote: >> On 3/28/23 12:58, Andrea Bolognani wrote: >>> It looks like virgdbusmock is used by >>> >>> networkxml2firewalltest >>> virfirewalltest >>> virsystemdtest >>> virpolkittest >>>

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

2023-03-28 Thread Peter Krempa
On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > The data is based on the generic variant of the 7.2.0 data on x86_64. > > > > Only modification to the '.replies' file is that KVM is reported as > >

Re: [PATCH 09/24] tests: Add support for multiple variants of data for the same qemu version+architecture

2023-03-28 Thread Peter Krempa
On Tue, Mar 21, 2023 at 15:39:21 +0100, Martin Kletzander wrote: > On Thu, Mar 16, 2023 at 05:11:38PM +0100, Peter Krempa wrote: > > 'qemucapabilitiestest' and other users of the capability data can > > benefit from adding a discriminator string to have multiple instances > > for the same

Re: [PATCH] qemu: Add vhost-user-blk unix socket to support server mode

2023-03-28 Thread Peter Krempa
On Tue, Mar 21, 2023 at 09:46:44 +0800, Zhenguo Yao wrote: > Peter Krempa 于2023年3月16日周四 21:51写道: > > > > On Thu, Mar 09, 2023 at 16:58:07 +0800, Zhenguo Yao wrote: > > > qemu support server mode when using vhost-user-blk disk. > > > Let libvirt to support this. > > > > Could you please elaborate

[libvirt PATCH] cpu-data.py: Filter out apic current logical processor

2023-03-28 Thread Tim Wiederhake
Commit 10b5e789c5 attempts to filter out the logical processor id in the generated data to remove noise and irrelevant changes in the output. cpuid-leaf 0x0B may have more than two sub-leaves though. Filter out logical processor id from all sub-leaves of 0x0B and 0x1F (superset of the information

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Andrea Bolognani
On Tue, Mar 28, 2023 at 02:29:10PM +0200, Michal Prívozník wrote: > On 3/28/23 12:58, Andrea Bolognani wrote: > > It looks like virgdbusmock is used by > > > > networkxml2firewalltest > > virfirewalltest > > virsystemdtest > > virpolkittest > > > > The first three are Linux-only; the last

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Michal Prívozník
On 3/28/23 12:58, Andrea Bolognani wrote: > On Tue, Mar 28, 2023 at 12:27:12PM +0200, Michal Prívozník wrote: >> On 3/28/23 10:33, Andrea Bolognani wrote: >>> Unfortunately, I also don't really have a better alternative to >>> suggest, so I guess it is what it is :) >> >> Maybe don't build mocks

[PATCH v1 0/3] Make virtio-mem and virtio-pmem address stable

2023-03-28 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (3): conf: Introduce for virtio-mem and virtio-pmem qemu: Fill virtio-mem/virtio-pmem .memaddr at runtime qemu_command: Generate .memaddr for virtio-mem and virtio-pmem docs/formatdomain.rst | 7 ++ src/conf/domain_conf.c

[PATCH v1 2/3] qemu: Fill virtio-mem/virtio-pmem .memaddr at runtime

2023-03-28 Thread Michal Privoznik
After a QEMU domain is started, among other thing we query memory device information. And while memory address is returned by QEMU for all models, we store it only for DIMMs and NVDIMMs. Do store it for VIRTIO_MEM and VIRTIO_PMEM too. This effectively reports the address the

[PATCH v1 3/3] qemu_command: Generate .memaddr for virtio-mem and virtio-pmem

2023-03-28 Thread Michal Privoznik
This is fairly trivial. Just set .memaddr attribute if a value was set in the XML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2180679 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 1 +

[PATCH v1 1/3] conf: Introduce for virtio-mem and virtio-pmem

2023-03-28 Thread Michal Privoznik
Both virtio-mem and virtio-pmem devices have '.memaddr' attribute which controls the address where they are mapped in the guest memory. Ideally, users do not need to specify this as QEMU does the right thing and computes addresses automatically on startup. But soon, we will need to record this

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Andrea Bolognani
On Tue, Mar 28, 2023 at 12:27:12PM +0200, Michal Prívozník wrote: > On 3/28/23 10:33, Andrea Bolognani wrote: > > Unfortunately, I also don't really have a better alternative to > > suggest, so I guess it is what it is :) > > Maybe don't build mocks on mingw? Do they even work, or better: can

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Michal Prívozník
On 3/28/23 10:33, Andrea Bolognani wrote: > On Mon, Mar 27, 2023 at 02:47:40PM +0200, Michal Privoznik wrote: >> There are couple of g_dbus_*() functions we provide an >> alternative implementation for in our virgdbusmock.c. However, >> these functions are declared in gio/gdbusconnection.h as: >>

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Andrea Bolognani
On Mon, Mar 27, 2023 at 02:47:40PM +0200, Michal Privoznik wrote: > There are couple of g_dbus_*() functions we provide an > alternative implementation for in our virgdbusmock.c. However, > these functions are declared in gio/gdbusconnection.h as: > > GIO_AVAILABLE_IN_ALL > GDBusConnection

Re: [libvirt PATCH 3/3] qemu: Default to raw firmware for existing domains

2023-03-28 Thread Andrea Bolognani
On Tue, Mar 28, 2023 at 09:13:01AM +0200, Martin Kletzander wrote: > On Mon, Mar 27, 2023 at 10:12:35PM +0200, Andrea Bolognani wrote: > > The changes to the output files are the exact opposite of > > those from commit 22207713cf8e: this is proof that the fix is > > working as intended, and that

Re: [libvirt PATCH 2/3] tests: Add firmware-auto-efi-abi-update-aarch64 test case

2023-03-28 Thread Martin Kletzander
On Mon, Mar 27, 2023 at 10:12:34PM +0200, Andrea Bolognani wrote: The input is identical to that of the existing firmware-auto-efi-aarch64 test, but in this case we want to cover the scenario in which that input is used to define a new domain rather than loading the definition of an existing

Re: [libvirt PATCH 1/3] tests: Introduce DO_TEST_CAPS_ARCH_LATEST_ABI_UPDATE()

2023-03-28 Thread Martin Kletzander
On Mon, Mar 27, 2023 at 10:12:33PM +0200, Andrea Bolognani wrote: Signed-off-by: Andrea Bolognani Reviewed-by: Martin Kletzander --- tests/qemuxml2argvtest.c | 5 + tests/qemuxml2xmltest.c | 5 + 2 files changed, 10 insertions(+) diff --git a/tests/qemuxml2argvtest.c

Re: [libvirt PATCH 3/3] qemu: Default to raw firmware for existing domains

2023-03-28 Thread Martin Kletzander
On Mon, Mar 27, 2023 at 10:12:35PM +0200, Andrea Bolognani wrote: The changes to the output files are the exact opposite of those from commit 22207713cf8e: this is proof that the fix is working as intended, and that existing domains will keep using raw firmware images regardless of whether or

Re: [PATCH] virauth: Report error on empty auth result

2023-03-28 Thread Martin Kletzander
On Mon, Mar 27, 2023 at 01:21:51PM +0200, Michal Privoznik wrote: When opening a connection, it may be necessary to provide user credentials, or some additional info (e.g. whether to trust an ssh key). We have a special API for that: virConnectOpenAuth() where and additional callback can be

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

2023-03-28 Thread Martin Kletzander
On Mon, Mar 27, 2023 at 02:47:40PM +0200, Michal Privoznik wrote: There are couple of g_dbus_*() functions we provide an alternative implementation for in our virgdbusmock.c. However, these functions are declared in gio/gdbusconnection.h as: GIO_AVAILABLE_IN_ALL GDBusConnection