On 6/22/23 11:08, Jim Fehlig wrote:
On 6/22/23 08:50, Andrea Bolognani wrote:
On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote:
On 6/8/23 08:11, Andrea Bolognani wrote:
Note that the Debian package has included this patch[1] for many
years, and while it partially overlaps with what
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8 +++
qapi/migration.json | 102 --
migration/options.c | 13 +
3 files changed, 86 insertions(+), 37 deletions(-)
diff --git a/docs/about/deprecated.rst
We broke it with dirtyrate limit patches.
Signed-off-by: Juan Quintela
---
qapi/migration.json | 67 ++---
1 file changed, 33 insertions(+), 34 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 6ff39157ba..ad8cc57071 100644
---
Set the 'block' migration capability to 'true' instead.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 10 +++---
migration/migration.c | 5 +
3 files changed, 19 insertions(+), 3 deletions(-)
diff --git
Set the 'block_incremental' migration parameter to 'true' instead.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
qapi/migration.json | 12 ++--
migration/migration.c | 6 ++
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 10 ++
qapi/migration.json | 30 +-
On this v2:
- dropped -incoming deprecation
Paolo came with a better solution using keyvalues.
- skipped field is already ready for next pull request, so dropped.
- dropped the RFC bits, nermal PATCH.
- Assessed all the review comments.
- Added indentation of migration.json.
- Used the
Peter Xu wrote:
> On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote:
>> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri
>> has been specified on the command line?
>
> Yeah, actually already in a pull (even though the pr may need a new one..):
>
>
Peter Xu wrote:
> On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote:
>> Peter Xu wrote:
>> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote:
>> >> Only "defer" is recommended. After setting all migation parameters,
>> >> start incoming migration with "migrate-incoming
Daniel P. Berrangé wrote:
> On Mon, Jun 12, 2023 at 09:33:44PM +0200, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 8
>> qapi/migration.json | 92 ---
>> migration/options.c | 13 ++
>> 3
Thomas Huth wrote:
> On 12/06/2023 21.33, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 8
>> qapi/migration.json | 92 ---
>> migration/options.c | 13 ++
>> 3 files changed, 79
On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote:
> > I can try to move the todo even higher. Trying to list the initial goals
> > here:
> >
> > - One extra phase of handshake between src/dst (maybe the time to boost
>
Stefan Hajnoczi wrote:
> On Mon, Jun 12, 2023 at 09:33:43PM +0200, Juan Quintela wrote:
>> It is obsolete. It is better to use driver_mirror+NBD instead.
>>
>> CC: Kevin Wolf
>> CC: Eric Blake
>> CC: Stefan Hajnoczi
>> CC: Hanna Czenczek
>>
>> Signed-off-by: Juan Quintela
>>
>> ---
>>
Juan Quintela wrote:
> Only "defer" is recommended. After setting all migation parameters,
> start incoming migration with "migrate-incoming uri" command.
>
> Signed-off-by: Juan Quintela
Nack myself.
Dropped on next submissiong. keyfile properties suggested by paolo is a
much better
Daniel P. Berrangé wrote:
> On Mon, Jun 12, 2023 at 09:33:41PM +0200, Juan Quintela wrote:
>> Use 'migrate_set_capability block true' instead.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 7 +++
>> qapi/migration.json | 11 +++
>>
Daniel P. Berrangé wrote:
> On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote:
>> Use 'migrate_set_parameter block_incremental true' instead.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 7 +++
>> qapi/migration.json | 11 +--
>>
Daniel P. Berrangé wrote:
> On Mon, Jun 12, 2023 at 09:33:39PM +0200, Juan Quintela wrote:
>> Has return zero for more than 10 years. Just mark it deprecated.
>
> Specifically we introduced the field in 1.5.0
>
> commit f1c72795af573b24a7da5eb52375c9aba8a37972
> Author: Peter Lieven
> Date:
On 6/22/23 08:50, Andrea Bolognani wrote:
On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote:
On 6/8/23 08:11, Andrea Bolognani wrote:
Note that the Debian package has included this patch[1] for many
years, and while it partially overlaps with what you've added here, I
see that local
On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote:
> I can try to move the todo even higher. Trying to list the initial goals
> here:
>
> - One extra phase of handshake between src/dst (maybe the time to boost
> QEMU_VM_FILE_VERSION) before anything else happens.
>
> - Dest shouldn't
On Thu, Jun 22, 2023 at 5:26 PM Peter Xu wrote:
> PS: we may want to postpone this to be later than migration_object_init(),
> when/if there's a real patch.
Yes, that's true.
> > > The only incompatibility is for people who are using "," in an URI,
> > > which is rare and only an issue for the
On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote:
> > Paolo Bonzini wrote:
> > > On 6/12/23 22:51, Juan Quintela wrote:
> > >>> Shall we just leave it there? Or is deprecating it helps us in any
> > >>> form?
> >
On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote:
> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri
> has been specified on the command line?
Yeah, actually already in a pull (even though the pr may need a new one..):
On Thu, Jun 22, 2023 at 12:01:55PM +0200, Juan Quintela wrote:
> Paolo Bonzini wrote:
> > On 6/22/23 10:52, Juan Quintela wrote:
> >> User friendliness.
> >> The problem is that if you use more than two channels with multifd, on
> >> the incoming side, you need to do:
> >
> > You're sacrificing
On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote:
> On 6/8/23 08:11, Andrea Bolognani wrote:
> > Note that the Debian package has included this patch[1] for many
> > years, and while it partially overlaps with what you've added here, I
> > see that local overrides for abstractions are
On Thu, Jun 22, 2023 at 04:00:50PM +0200, Peter Krempa wrote:
> On Wed, Jun 21, 2023 at 14:32:25 +0100, Daniel P. Berrangé wrote:
> > The unit files both have After=network.target, and this in turn implies
> > After=network-pre.target. Both iptables.service & ip6tables.service have
> >
On Thu, Jun 22, 2023 at 09:49:41AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 22, 2023 at 10:23:57AM +0200, Peter Krempa wrote:
> > On Wed, Jun 21, 2023 at 14:32:30 +0100, Daniel P. Berrangé wrote:
> > > +/*
> > > + * Want to use logind if:
> > > + * - logind is already running
>
On Wed, Jun 21, 2023 at 14:32:25 +0100, Daniel P. Berrangé wrote:
> The unit files both have After=network.target, and this in turn implies
> After=network-pre.target. Both iptables.service & ip6tables.service have
> Before=network-pre.target since Fedora >= 35 and RHEL >= 8.4.
Is this also true
First patch reworks memory specification to use the explicit 'size'
parameter (since qemu v2.0.0-179-g6e1d3c1c85), the reset modifies memory
hotplug related checks to properly handle non-DIMM devices which don't
require DIMM slots.
Peter Krempa (4):
qemu_command: Always use modern syntax of
Add a config where both DIMM and non-DIMM devices are used so
that it validates that only DIMMs require memory slots.
Signed-off-by: Peter Krempa
---
...memory-hotplug-multiple.x86_64-latest.args | 46 ++
.../memory-hotplug-multiple.xml | 89 ++
Memory slots are required only for DIMM-like devices, while other
devices defined via such as virtio-mem may use the PCI bus and
thus do not require/consume a memory slot.
Fix the validation code to calculate the required count of memory
devices only for DIMMs and NVDIMMs.
Signed-off-by: Peter
Memory slots are required only for DIMM-like devices, but the maximum
memory address space is relevant also for other non-DIMM memory devices
such as virtio-mem. Allow configurations where no slots are added.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c |
On Thu, Jun 08, 2023 at 08:53:17AM +0200, Martin Kletzander wrote:
> On Mon, Jun 05, 2023 at 12:10:03PM +0200, Michal Prívozník wrote:
> > On 5/23/23 19:31, Cole Robinson wrote:
> > > +%if 0%{?fedora} >= 39
> > > +# numad is retired in fedora 39+, upstream is dead
> > > +%define with_numad
On 6/22/23 10:52, Juan Quintela wrote:
User friendliness.
The problem is that if you use more than two channels with multifd, on
the incoming side, you need to do:
You're sacrificing user-friendliness for the 99.99% that don't use
multifd, for an error (i.e. it's not even fixing the issue)
Paolo Bonzini wrote:
> On 6/22/23 10:52, Juan Quintela wrote:
>> User friendliness.
>> The problem is that if you use more than two channels with multifd, on
>> the incoming side, you need to do:
>
> You're sacrificing user-friendliness for the 99.99% that don't use
> multifd, for an error (i.e.
On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote:
> Paolo Bonzini wrote:
> > On 6/12/23 22:51, Juan Quintela wrote:
> >>> Shall we just leave it there? Or is deprecating it helps us in any form?
> >> See the patches two weeks ago when people complained that lisen(.., num)
> >> was
On 22/06/2023 10.52, Juan Quintela wrote:
Paolo Bonzini wrote:
On 6/12/23 22:51, Juan Quintela wrote:
Shall we just leave it there? Or is deprecating it helps us in any form?
See the patches two weeks ago when people complained that lisen(.., num)
was too low. And there are other
On Thu, Jun 22, 2023 at 10:27:15AM +0200, Peter Krempa wrote:
> On Wed, Jun 21, 2023 at 14:32:32 +0100, Daniel P. Berrangé wrote:
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > src/util/virnodesuspend.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git
Paolo Bonzini wrote:
> On 6/12/23 22:51, Juan Quintela wrote:
>>> Shall we just leave it there? Or is deprecating it helps us in any form?
>> See the patches two weeks ago when people complained that lisen(.., num)
>> was too low. And there are other parameters that work the same way
>> (that I
On Thu, Jun 22, 2023 at 11:10:25AM +0200, Michal Privoznik wrote:
> On Wed, Jun 21, 2023 at 5:30 PM Daniel P. Berrangé
> wrote:
> >
> > On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote:
> > > This should not be needed, but here's what's happening:
> > > virStrToLong_*() family of
On Wed, Jun 21, 2023 at 5:30 PM Daniel P. Berrangé wrote:
>
> On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote:
> > This should not be needed, but here's what's happening:
> > virStrToLong_*() family of functions was switched from strtol*()
> > to g_ascii_strtol*() in order to
On Wed, Jun 21, 2023 at 14:32:32 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/util/virnodesuspend.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c
> index 01f387d6fa..91a7f10eb9 100644
> ---
On Wed, Jun 21, 2023 at 14:32:28 +0100, Daniel P. Berrangé wrote:
> None of our daemons use select(), so it is safe to raise the max file
> limit to its maximum on startup.
>
> https://gitlab.com/libvirt/libvirt/-/issues/489
> Signed-off-by: Daniel P. Berrangé
> ---
> src/rpc/virnetdaemon.c | 3
On Thu, Jun 22, 2023 at 10:23:57AM +0200, Peter Krempa wrote:
> On Wed, Jun 21, 2023 at 14:32:30 +0100, Daniel P. Berrangé wrote:
> > Historically we wanted to check if logind was actually running, not
> > merely activatable, because on systems where systemd is installed,
> > but the OS is booted
On 6/21/23 09:08, Thomas Huth wrote:
if (strcmp(incoming, "defer") != 0) {
+ warn_report("-incoming %s is deprecated, use -incoming
defer and "
+ " set the uri with migrate-incoming.",
incoming);
qmp_migrate_incoming(incoming, _err);
On 6/12/23 22:51, Juan Quintela wrote:
Shall we just leave it there? Or is deprecating it helps us in any form?
See the patches two weeks ago when people complained that lisen(.., num)
was too low. And there are other parameters that work the same way
(that I convenientely had forgotten). So
On Wed, Jun 21, 2023 at 14:32:31 +0100, Daniel P. Berrangé wrote:
> After the previous commit we no longer require that logind is actually
> running, it merely has to be activatable.
>
> https://gitlab.com/libvirt/libvirt/-/issues/489
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Thu, Jun 22, 2023 at 09:27:48AM +0200, Peter Krempa wrote:
> On Wed, Jun 21, 2023 at 14:32:24 +0100, Daniel P. Berrangé wrote:
> > All services are ordered after local-fs.target unless they have set
> > DefaultDependencies=no, which we do not do.
> >
> >
On Wed, Jun 21, 2023 at 14:32:29 +0100, Daniel P. Berrangé wrote:
> Since systemd 240, all services get an open file hard limit of
> 500k, and a soft limit of 1024. This limit means apps are safe
> to use select() by default which is limited to 1024 FDs. Apps
> which don't use select() are
On Wed, Jun 21, 2023 at 14:32:27 +0100, Daniel P. Berrangé wrote:
> Historically the max files limit for processes has always been 1024,
> because going beyond this is incompatible with the select() function.
> None the less most apps these days will use poll() so should not be
> limited in this
On Wed, Jun 21, 2023 at 14:32:30 +0100, Daniel P. Berrangé wrote:
> Historically we wanted to check if logind was actually running, not
> merely activatable, because on systems where systemd is installed,
> but the OS is booted into non-systemd init, we want to fallback to
> pm-utils.
>
>
On Wed, Jun 21, 2023 at 14:32:24 +0100, Daniel P. Berrangé wrote:
> All services are ordered after local-fs.target unless they have set
> DefaultDependencies=no, which we do not do.
>
> https://gitlab.com/libvirt/libvirt/-/issues/489
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Wed, Jun 21, 2023 at 14:32:26 +0100, Daniel P. Berrangé wrote:
> These wrappers added no semantic difference over calling the system
> function directly.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/util/virprocess.c | 22 ++
> 1 file changed, 2 insertions(+), 20
52 matches
Mail list logo
