Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 04:10:53 + "Tian, Kevin" <kevin.t...@intel.com> wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Wednesday, September 21, 2016 12:23 AM > > > > > > On 9/20/2016 8:13 PM, Alex Williamson wrote: > &

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Wed, 21 Sep 2016 03:56:21 + "Tian, Kevin" wrote: > > From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > > Sent: Tuesday, September 20, 2016 10:22 PM > > >> > > >> 'max_instance': > > >> Read-Only file. Mandatory. > > >> Returns integer. Returns maximum

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 21:53:16 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/20/2016 8:13 PM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 19:51:58 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 9/20/2016 3:06 AM, Ale

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 20:05:01 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/20/2016 3:55 AM, Alex Williamson wrote: > > On Mon, 19 Sep 2016 23:50:56 +0200 > > Paolo Bonzini <pbonz...@redhat.com> wrote: > > > >> On 19/09/2016 23:36, Alex Wil

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-20 Thread Alex Williamson
On Tue, 20 Sep 2016 19:51:58 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/20/2016 3:06 AM, Alex Williamson wrote: > > On Tue, 20 Sep 2016 02:05:52 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> Hi libvirt experts, > &g

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-19 Thread Alex Williamson
On Mon, 19 Sep 2016 23:50:56 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote: > On 19/09/2016 23:36, Alex Williamson wrote: > > On Tue, 20 Sep 2016 02:05:52 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > >> 'fb_length': > >> Read-

Re: [libvirt] [RFC v2] libvirt vGPU QEMU integration

2016-09-19 Thread Alex Williamson
On Tue, 20 Sep 2016 02:05:52 +0530 Kirti Wankhede wrote: > Hi libvirt experts, > > Thanks for valuable input on v1 version of RFC. > > Quick brief, VFIO based mediated device framework provides a way to > virtualize their devices without SR-IOV, like NVIDIA vGPU, Intel

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-08 Thread Alex Williamson
On Fri, 9 Sep 2016 00:18:10 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/8/2016 3:43 AM, Alex Williamson wrote: > > On Wed, 7 Sep 2016 23:36:28 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 9/7/2016 10:14 PM, Alex Wi

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Alex Williamson
On Wed, 7 Sep 2016 23:36:28 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/7/2016 10:14 PM, Alex Williamson wrote: > > On Wed, 7 Sep 2016 21:45:31 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 9/7/2016 2:58 AM, Alex Wi

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Alex Williamson
On Wed, 7 Sep 2016 21:45:31 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/7/2016 2:58 AM, Alex Williamson wrote: > > On Wed, 7 Sep 2016 01:05:11 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 9/6/2016 11:10 PM, Alex Wi

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-07 Thread Alex Williamson
On Wed, 7 Sep 2016 08:22:05 + "Tian, Kevin" <kevin.t...@intel.com> wrote: > > From: Alex Williamson > > Sent: Wednesday, September 07, 2016 5:29 AM > > > > On Wed, 7 Sep 2016 01:05:11 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-06 Thread Alex Williamson
On Wed, 7 Sep 2016 01:05:11 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > On 9/6/2016 11:10 PM, Alex Williamson wrote: > > On Sat, 3 Sep 2016 22:04:56 +0530 > > Kirti Wankhede <kwankh...@nvidia.com> wrote: > > > >> On 9/3/2016 3:18 AM, Paolo B

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-06 Thread Alex Williamson
On Sat, 3 Sep 2016 22:01:13 +0530 Kirti Wankhede wrote: > On 9/3/2016 1:59 AM, John Ferlan wrote: > > > > > > On 09/02/2016 02:33 PM, Kirti Wankhede wrote: > >> > >> On 9/2/2016 10:55 PM, Paolo Bonzini wrote: > >>> > >>> > >>> On 02/09/2016 19:15, Kirti Wankhede

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-06 Thread Alex Williamson
On Sat, 3 Sep 2016 22:04:56 +0530 Kirti Wankhede wrote: > On 9/3/2016 3:18 AM, Paolo Bonzini wrote: > > > > > > On 02/09/2016 20:33, Kirti Wankhede wrote: > >> We could even do: > > echo $UUID1:$GROUPA > create > > where $GROUPA is the group ID of

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Alex Williamson
On Mon, 5 Sep 2016 11:36:55 +0200 Paolo Bonzini wrote: > On 05/09/2016 11:23, Markus Armbruster wrote: > >> > > >> > On the other hand, it is clearly documented that the DEVICE_DELETED > >> > event is sent as soon as guest acknowledges completion of device > >> > removal. So

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-02 Thread Alex Williamson
On Fri, 2 Sep 2016 13:55:19 -0400 Laine Stump <la...@laine.org> wrote: > On 09/01/2016 12:59 PM, Alex Williamson wrote: > > On Thu, 1 Sep 2016 18:47:06 +0200 > > Michal Privoznik <mpriv...@redhat.com> wrote: > > > >> On 31.08.2016 08:12, Tian, K

[libvirt] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-01 Thread Alex Williamson
Hey, I'm out of my QOM depth, so I'll just beg for help in advance. I noticed in testing vfio-pci hotunplug that the host seems to be trying to reclaim the device before QEMU is actually done with it, there's a very short race where libvirt has seen the DEVICE_DELETED event and tries to unbind

Re: [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Alex Williamson
On Thu, 1 Sep 2016 23:52:02 +0530 Kirti Wankhede <kwankh...@nvidia.com> wrote: > Alex, > Thanks for summarizing the discussion. > > On 8/31/2016 9:18 PM, Alex Williamson wrote: > > On Wed, 31 Aug 2016 15:04:13 +0800 > > Jike Song <jike.s...@intel.com> wrote

Re: [libvirt] [Qemu-devel] [PATCH v7 0/4] Add Mediated device support

2016-09-01 Thread Alex Williamson
On Thu, 1 Sep 2016 18:47:06 +0200 Michal Privoznik <mpriv...@redhat.com> wrote: > On 31.08.2016 08:12, Tian, Kevin wrote: > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Wednesday, August 31, 2016 12:17 AM > >> > >> Hi folks

Re: [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-08-31 Thread Alex Williamson
On Wed, 31 Aug 2016 15:04:13 +0800 Jike Song <jike.s...@intel.com> wrote: > On 08/31/2016 02:12 PM, Tian, Kevin wrote: > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Wednesday, August 31, 2016 12:17 AM > >> > >> Hi folks

Re: [libvirt] [PATCH v7 0/4] Add Mediated device support

2016-08-30 Thread Alex Williamson
Hi folks, At KVM Forum we had a BoF session primarily around the mediated device sysfs interface. I'd like to share what I think we agreed on and the "problem areas" that still need some work so we can get the thoughts and ideas from those who weren't able to attend. DanPB expressed some

Re: [libvirt] question about PCI new_id sysfs interface

2016-06-29 Thread Alex Williamson
On Wed, 29 Jun 2016 09:47:55 +0100 "Daniel P. Berrange" wrote: > On Tue, Jun 28, 2016 at 02:30:47PM -0400, Bandan Das wrote: > > "Daniel P. Berrange" writes: > > > > > Adding Alex & Bandan, since they signed off the kernel patch which > > > I'm

Re: [libvirt] question about PCI new_id sysfs interface

2016-06-28 Thread Alex Williamson
On Tue, 28 Jun 2016 14:39:22 -0400 Laine Stump wrote: > On 06/28/2016 01:39 PM, Jim Fehlig wrote: > > After updating the dom0 kernel on one of my Xen test hosts, I noticed > > problems with PCI hostdev management. E.g > > > > # virsh nodedev-detach pci__07_10_1 > > error:

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-22 Thread Alex Williamson
On Tue, 22 Mar 2016 19:04:31 +0100 Andrea Bolognani <abolo...@redhat.com> wrote: > On Tue, 2016-03-22 at 09:04 -0600, Alex Williamson wrote: > > > Could this be controlled by a kernel parameter? So you > > > can just add something like > > >  > > >

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-22 Thread Alex Williamson
On Tue, 22 Mar 2016 12:54:12 +0100 Andrea Bolognani <abolo...@redhat.com> wrote: > On Fri, 2016-03-18 at 11:03 -0600, Alex Williamson wrote: > > > Anyway, after reading your explanation I'm wondering if we > > > shouldn't always recommend a setup where devices that are

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-19 Thread Alex Williamson
Sorry, apparently missed this reply previously On Wed, 16 Mar 2016 11:19:38 +0100 Andrea Bolognani <abolo...@redhat.com> wrote: > On Tue, 2016-03-15 at 13:31 -0600, Alex Williamson wrote: > > So we have all sorts of driver issues that are sure to come and go over > > time

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-19 Thread Alex Williamson
On Thu, 17 Mar 2016 17:59:53 + "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Thu, Mar 17, 2016 at 11:52:14AM -0600, Alex Williamson wrote: > > On Thu, 17 Mar 2016 17:32:08 + > > "Daniel P. Berrange" <berra...@redhat.com> wrote:

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-19 Thread Alex Williamson
On Thu, 17 Mar 2016 17:32:08 + "Daniel P. Berrange" <berra...@redhat.com> wrote: > On Tue, Mar 15, 2016 at 02:21:35PM -0400, Laine Stump wrote: > > On 03/15/2016 01:00 PM, Daniel P. Berrange wrote: > > >On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stum

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

2016-03-15 Thread Alex Williamson
On Tue, 15 Mar 2016 14:21:35 -0400 Laine Stump <la...@laine.org> wrote: > On 03/15/2016 01:00 PM, Daniel P. Berrange wrote: > > On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stump wrote: > >> Suggested by Alex Williamson. > >> > >> If you

Re: [libvirt] About the vfio error when using SR-IOV

2016-02-22 Thread Alex Williamson
> > > > > > > > > > But the error output when I boot one vm: > > > > [root@host3 VTS2.1-demo]# virsh create vtc.demo.xml > > error: Failed to create domain from vtc.demo.xml > > error: internal error: early end of file from mon

Re: [libvirt] [PATCH 00/10] VFIO fixes for PCI devices

2015-12-13 Thread Alex Williamson
On Wed, 2015-12-09 at 13:51 +0100, Andrea Bolognani wrote: > On Wed, 2015-12-02 at 18:17 +0100, Andrea Bolognani wrote: > > This series is my attempt at fixing > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1272300 > > > [...] > > > > The problem being solved is that, when using VFIO,

Re: [libvirt] [PATCH 00/10] VFIO fixes for PCI devices

2015-12-13 Thread Alex Williamson
On Thu, 2015-12-10 at 09:06 +0100, Andrea Bolognani wrote: > On Wed, 2015-12-09 at 08:09 -0700, Alex Williamson wrote: > > > I was under the impression that what the current series > > > does, eg. sharing devices in the same IOMMU group between > > > the host drive

Re: [libvirt] [PATCH v4 04/10] Wait for vfio-pci device cleanups before reassinging the device to host driver

2015-11-20 Thread Alex Williamson
On Fri, 2015-11-20 at 12:26 +0530, Shivaprasad bhat wrote: > On Fri, Nov 20, 2015 at 4:54 AM, Alex Williamson > <alex.william...@redhat.com> wrote: > > On Sat, 2015-11-14 at 14:06 +0530, Shivaprasad G Bhat wrote: > >> Before unbind from stub driver libvi

Re: [libvirt] [PATCH v4 05/10] Split reprobe action from the virPCIUnbindFromStub into a new function

2015-11-20 Thread Alex Williamson
On Fri, 2015-11-20 at 11:33 -0500, Laine Stump wrote: > On 11/14/2015 03:36 AM, Shivaprasad G Bhat wrote: > > The reprobe needs to be called multiple times for vfio devices for each > > device in the iommu group in future patch. So split the reprobe into a > > new function. No functional change. >

Re: [libvirt] [PATCH v4 05/10] Split reprobe action from the virPCIUnbindFromStub into a new function

2015-11-20 Thread Alex Williamson
On Fri, 2015-11-20 at 12:24 -0500, Laine Stump wrote: > On 11/20/2015 11:58 AM, Andrea Bolognani wrote: > > On Fri, 2015-11-20 at 11:33 -0500, Laine Stump wrote: > >> Seems safe, but is this really what we want to do? I haven't > >> read/understood the remaining patches yet, but this makes it

Re: [libvirt] [PATCH v4 04/10] Wait for vfio-pci device cleanups before reassinging the device to host driver

2015-11-19 Thread Alex Williamson
On Sat, 2015-11-14 at 14:06 +0530, Shivaprasad G Bhat wrote: > Before unbind from stub driver libvirt should be sure the guest is not using > the device anymore. The libvirt today waits for pci-stub driver alone in > /proc/iommu. > The same wait is needed for vfio devices too. > > Signed-off-by:

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-10 Thread Alex Williamson
On Fri, 2015-11-06 at 08:30 +0100, Peter Krempa wrote: > On Thu, Nov 05, 2015 at 08:41:46 -0700, Alex Williamson wrote: > > On Thu, 2015-11-05 at 16:27 +0100, Peter Krempa wrote: > > > On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote: > > [...] > &

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-05 Thread Alex Williamson
On Thu, 2015-11-05 at 16:27 +0100, Peter Krempa wrote: > On Wed, Nov 04, 2015 at 17:16:53 -0700, Alex Williamson wrote: > > On Wed, 2015-11-04 at 16:54 +0100, Peter Krempa wrote: > > > On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote: > > > > On Wed, 20

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-04 Thread Alex Williamson
On Wed, 2015-11-04 at 16:54 +0100, Peter Krempa wrote: > On Wed, Nov 04, 2015 at 08:43:34 -0700, Alex Williamson wrote: > > On Wed, 2015-11-04 at 16:14 +0100, Peter Krempa wrote: > > > For VFIO passthrough the guest memory including the device memory to be > > > reside

Re: [libvirt] [PATCH] qemu: process: Fix automatic setting of locked memory limit for VFIO

2015-11-04 Thread Alex Williamson
if (mlock) { > -unsigned long long memKB; > - > -/* VFIO requires all of the guest's memory to be > - * locked resident, plus some amount for IO > - * space. Alex Williamson suggested adding 1GiB for IO > - * space just to be

Re: [libvirt] [PATCH 4/4] virt-host-validate: check for intel_iommu=on cmdline flag

2015-10-07 Thread Alex Williamson
On Wed, 2015-10-07 at 17:50 +0100, Daniel P. Berrange wrote: > This looks for existance of /sys/firmware/acpi/tables/DMAR > as a reasonable hint that the BIOS support an Intel IOMMU. > > This file is only present if enabled in the BIOS, so the > check only does something if the BIOS is enabled

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Alex Williamson
On Tue, 2015-08-11 at 19:26 -0400, Laine Stump wrote: (Alex - I cc'ed you because I addressed a question or two your way down towards the bottom). On 08/11/2015 02:52 AM, Pavel Fedin wrote: Hello! The original patches to support pcie-root severely restricted what could plug into what

Re: [libvirt] [PATCH] libvirt/hooks: Static and dynamic hugepage hooks

2015-06-29 Thread Alex Williamson
On Wed, 2015-06-24 at 12:57 -0600, Alex Williamson wrote: This patch provides scripts for hugepage allocation, as well as a bit of infrastructure and common hook config file that I hope may some day be enabled by default in libvirt. For now, we place the files in /usr/share and ask users

[libvirt] [PATCH] libvirt/hooks: Static and dynamic hugepage hooks

2015-06-24 Thread Alex Williamson
and guests that use hugepage sizes and quantities are are likely to be dynamically allocated as the VM is started. In addition to the documentation provided within each script, a README file is provided with overal instructions and summaries of the individual scripts. Signed-off-by: Alex Williamson

Re: [libvirt] [PATCH 13/13] qemu: support new pci controller model pcie-switch-downstream-port

2015-06-23 Thread Alex Williamson
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote: This is backed by the qemu device xio3130-downstream. It can only be connected to a pcie-switch-upstream-port (x3130-upstream) on the upstream side. --- src/qemu/qemu_command.c | 15 +++

Re: [libvirt] [PATCH 07/13] qemu: support new pci controller model pcie-root-port

2015-06-23 Thread Alex Williamson
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote: This is backed by the qemu device ioh3420. --- src/qemu/qemu_command.c | 20 .../qemuxml2argv-pcie-root-port.args | 10 ++ tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH 09/13] conf: new pci controller model pcie-switch-upstream-port

2015-06-23 Thread Alex Williamson
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote: This controller can be connected to any PCIe port, but not to a standard PCI port, which is the reason for the new connect type VIR_PCI_CONNECT_TYPE_PCIE_ONLY. pcie-switch provides 31 ports (slot=1 to slot=31), which can only have pci

Re: [libvirt] [PATCH 09/13] conf: new pci controller model pcie-switch-upstream-port

2015-06-23 Thread Alex Williamson
On Tue, 2015-06-23 at 13:47 -0400, Laine Stump wrote: On 06/23/2015 11:23 AM, Alex Williamson wrote: On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote: diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 4b5e81e..59da745 100644 --- a/src/conf/domain_addr.c +++ b/src

[libvirt] [RFC] libvirt hugepage hooks

2015-06-16 Thread Alex Williamson
Hi, This is very rough and early, but I wanted to get some feedback, possibly advice, and see if there's some interest in at least creating infrastructure for user contributed libvirt hooks, if not some default ones that are no-ops unless configured. The impetus for this is that I started trying

[libvirt] [PATCH v2] Add new 'kvm' domain feature and ability to hide KVM signature

2014-08-21 Thread Alex Williamson
is as follows: domain type='kvm ... features ... kvm hidden state='on'/ /kvm /features ... Signed-off-by: Alex Williamson alex.william...@redhat.com --- Hearing no further comments, here's v2: - white space fix in docs/formatdomain.html.in - s/virBufferAsprintf

Re: [libvirt] [PATCH] Add new 'kvm' domain feature and ability to hide KVM signature

2014-08-19 Thread Alex Williamson
On Tue, 2014-08-19 at 12:40 -0400, Cole Robinson wrote: On 08/15/2014 12:32 PM, Alex Williamson wrote: QEMU 2.1 added support for the kvm=off option to the -cpu command, allowing the KVM hypervisor signature to be hidden from the guest. This enables disabling of some paravirualization

Re: [libvirt] Support for kvm=off cpu option

2014-08-15 Thread Alex Williamson
On Fri, 2014-08-15 at 10:38 -0400, Cole Robinson wrote: On 08/11/2014 05:54 PM, Alex Williamson wrote: As of QEMU 2.1 we now have a new -cpu option, kvm=on|off which controls whether we expose KVM as the hypervisor via the MSR hypervisor nodes. The default is on. The off state is meant

[libvirt] [PATCH] Add new 'kvm' domain feature and ability to hide KVM signature

2014-08-15 Thread Alex Williamson
is as follows: domain type='kvm ... features ... kvm hidden state='on'/ /kvm /features ... Signed-off-by: Alex Williamson alex.william...@redhat.com --- If it's not obvious, this patch is derived from copying and modifying the similar hyperv feature support. Hopefully

[libvirt] Support for kvm=off cpu option

2014-08-11 Thread Alex Williamson
As of QEMU 2.1 we now have a new -cpu option, kvm=on|off which controls whether we expose KVM as the hypervisor via the MSR hypervisor nodes. The default is on. The off state is meant to hide kvm from standard detection routines. This allows us to disable paravirtualization detection in the

[libvirt] [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-20 Thread Alex Williamson
to any driver (override driver = none) or perhaps have it automatically bind to vfio-pci. With driver_override it's a simple matter for this field to be set internally when the device is first discovered to prevent driver matches. Signed-off-by: Alex Williamson alex.william...@redhat.com Cc: Greg

[libvirt] [PATCH v2] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-09 Thread Alex Williamson
to any driver (override driver = none) or perhaps have it automatically bind to vfio-pci. With driver_override it's a simple matter for this field to be set internally when the device is first discovered to prevent driver matches. Signed-off-by: Alex Williamson alex.william...@redhat.com Cc: Greg

Re: [libvirt] [PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-06 Thread Alex Williamson
Hi Greg, I think Bjorn is waiting for an ack from you on this. Do you approve of this approach from a driver-core perspective? Thanks, Alex On Fri, 2014-04-04 at 14:19 -0600, Alex Williamson wrote: The driver_override field allows us to specify the driver for a device rather than relying

[libvirt] [PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-04 Thread Alex Williamson
to any driver (preferred driver = none) or perhaps have it automatically bind to vfio-pci. With driver_override it's a simple matter for this field to be set internally when the device is first discovered to prevent driver matches. Signed-off-by: Alex Williamson alex.william...@redhat.com

Re: [libvirt] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-24 Thread Alex Williamson
On Sun, 2013-07-14 at 15:59 -0600, Alex Williamson wrote: On Fri, 2013-07-12 at 14:38 -0600, Alex Williamson wrote: The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans

Re: [libvirt] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-14 Thread Alex Williamson
On Fri, 2013-07-12 at 14:38 -0600, Alex Williamson wrote: The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located

[libvirt] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-12 Thread Alex Williamson
The Call for Proposals for the 2013 Linux Plumbers Virtualization Microconference is now open. This uconf is being held as part of Linux Plumbers Conference in New Orleans, Louisiana, USA September 18-20th and is co-located with LinuxCon North America. For more information see:

Re: [libvirt] [PATCH 1/3] qemu: Move memory limit computation to a reusable function

2013-07-02 Thread Alex Williamson
the number of attached devices If that would be the amount of memory reserved for BARs (PCI memory mapped regions), 1 GB should be enough. Let's just ask Alex Williamson. Yes, the extra is for the MMIO space of devices that gets mapped into the IOMMU and pinned in the host. 1G is sufficient

Re: [libvirt] VFIO device groups and libvirt

2013-05-30 Thread Alex Williamson
On Thu, 2013-05-30 at 12:29 -0400, Laine Stump wrote: VFIO device assignment has a concept of device groups; each group is a set of devices that must all be assigned to the same guest (alternately, unassigned devices can be attached to the vfio stub driver). This is to prevent cross-guest (or

Re: [libvirt] VFIO device groups and libvirt

2013-05-30 Thread Alex Williamson
On Thu, 2013-05-30 at 13:48 -0400, Laine Stump wrote: On 05/30/2013 01:18 PM, Alex Williamson wrote: nit, vfio is not a stub driver, it's an actual driver. vfio also whitelists some host drivers. The two so far are pci-stub and pcieport. libvirt should not disconnect root ports from

[libvirt] 2013 Linux Plumbers Virtualization Microconference proposal call for participation

2013-05-16 Thread Alex Williamson
Hey folks, We'd like to hold another virtualization microconference as part of this year's Linux Plumbers Conference. To do so, we need to show that there's enough interest, materials, and people willing to attend. Anthony and Amit have already started a wiki page for the microconference:

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-15 Thread Alex Williamson
On Fri, 2013-04-12 at 11:46 -0400, Laine Stump wrote: On 04/11/2013 07:23 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 07:03:56AM -0400, Laine Stump wrote: On 04/10/2013 05:26 AM, Daniel P. Berrange wrote: On Tue, Apr 09, 2013 at 04:06:06PM -0400, Laine Stump wrote: On 04/09/2013

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-08 Thread Alex Williamson
On Mon, 2013-04-08 at 12:37 -0400, Laine Stump wrote: On 04/05/2013 03:26 PM, Alex Williamson wrote: On Fri, 2013-04-05 at 14:42 -0400, Laine Stump wrote: On 04/05/2013 01:38 PM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 12:32:04PM -0400, Laine Stump wrote: On 04/03/2013 11:50 AM

Re: [libvirt] new libvirt pci controller type and pcie/q35 (was Re: [PATCH 4/7] add pci-bridge controller type)

2013-04-05 Thread Alex Williamson
On Fri, 2013-04-05 at 14:42 -0400, Laine Stump wrote: On 04/05/2013 01:38 PM, Daniel P. Berrange wrote: On Fri, Apr 05, 2013 at 12:32:04PM -0400, Laine Stump wrote: On 04/03/2013 11:50 AM, Ján Tomko wrote: From: liguang lig.f...@cn.fujitsu.com add a new controller type, then one can

Re: [libvirt] RFC: vfio pci passthrough support

2013-03-12 Thread Alex Williamson
On Tue, 2013-03-12 at 13:20 -0400, Laine Stump wrote: On 03/11/2013 02:06 PM, Alex Williamson wrote: On Mon, 2013-03-11 at 13:23 -0400, Laine Stump wrote: VFIO is a new method of doing PCI device assignment (PCI passthrough aka hostdev) available in newish kernels (3.6?; it's in Fedora 18

Re: [libvirt] RFC: vfio pci passthrough support

2013-03-11 Thread Alex Williamson
On Mon, 2013-03-11 at 13:23 -0400, Laine Stump wrote: VFIO is a new method of doing PCI device assignment (PCI passthrough aka hostdev) available in newish kernels (3.6?; it's in Fedora 18 at any rate) and via the vfio-pci device in qemu-1.4+. In contrast to the traditional KVM PCI device

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-27 Thread Alex Williamson
On Wed, 2013-02-27 at 13:20 -0500, Laine Stump wrote: On 02/06/2013 02:13 PM, Laine Stump wrote: Now that qemu is getting the q35 machine type, libvirt needs to support it. In an attempt to make sure that libvirt actually does something useful with qemu's new machine type, I'm revisiting

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-07 Thread Alex Williamson
On Thu, 2013-02-07 at 17:31 +, Daniel P. Berrange wrote: On Wed, Feb 06, 2013 at 01:15:05PM -0700, Alex Williamson wrote: On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote: 2) Are there other issues aside from implicit controller devices I need to consider for q35? For example

Re: [libvirt] [Qemu-devel] q35 machine type and libvirt.

2013-02-06 Thread Alex Williamson
On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote: Now that qemu is getting the q35 machine type, libvirt needs to support it. As far as I understand, from libvirt's point of view, q35 is just another x86_64 system, but with a different set of implicit devices, and possibly some extra

Re: [libvirt] Changing device owner

2011-07-30 Thread Alex Williamson
On Sat, 2011-07-30 at 12:12 +0300, Shahar Havivi wrote: Alex, Regarding vdsm changing a device owner, Last time I asked in #virt for using usb device in vdsm hook in /dev/bus/usb/addr I was told that vdsm should change the owner to qemu:kvm. So for the sr-iov device

Re: [libvirt] Changing device owner

2011-07-30 Thread Alex Williamson
On Sat, 2011-07-30 at 17:19 +0300, Shahar Havivi wrote: On 30.07.11 07:20, Alex Williamson wrote: On Sat, 2011-07-30 at 12:12 +0300, Shahar Havivi wrote: Alex, Regarding vdsm changing a device owner, Last time I asked in #virt for using usb device in vdsm hook in /dev/bus/usb

Re: [libvirt] [PATCH] Add PCI sysfs reset access

2011-03-18 Thread Alex Williamson
On Fri, 2011-03-18 at 10:18 +, Daniel P. Berrange wrote: On Thu, Mar 17, 2011 at 02:26:36PM -0600, Alex Williamson wrote: I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset devices on VM reset. We need to add it to libvirt's list of files that get ownership for device

[libvirt] [PATCH] Add PCI sysfs reset access

2011-03-17 Thread Alex Williamson
I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset devices on VM reset. We need to add it to libvirt's list of files that get ownership for device assignment. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/util/pci.c |6 -- 1 files changed, 4 insertions

Re: [libvirt] [PATCH] Add PCI sysfs reset access

2011-03-17 Thread Alex Williamson
On Thu, 2011-03-17 at 14:34 -0600, Eric Blake wrote: On 03/17/2011 02:26 PM, Alex Williamson wrote: I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset devices on VM reset. We need to add it to libvirt's list of files that get ownership for device assignment. Signed-off

Re: [libvirt] [PATCH] device-assignment: Reset device on system reset

2011-03-17 Thread Alex Williamson
On Thu, 2011-03-17 at 14:12 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: static void reset_assigned_device(DeviceState *dev) { -PCIDevice *d = DO_UPCAST(PCIDevice, qdev, dev); +PCIDevice *pci_dev = DO_UPCAST(PCIDevice, qdev, dev

[libvirt] [PATCH 0/2] Device assignment hotplug fixes

2010-05-24 Thread Alex Williamson
These add a couple fixes for device assignment hotplug --- Alex Williamson (2): qemu: Release bus address on PCI host device remove qemu: avoid corrupting guest info struct on host device PCI hot add src/qemu/qemu_driver.c | 23 +++ 1 files changed, 15

[libvirt] [PATCH 1/2] qemu: avoid corrupting guest info struct on host device PCI hot add

2010-05-24 Thread Alex Williamson
The device path doesn't make use of guestAddr, so the memcpy corrupts the guest info struct. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b

[libvirt] [RFC PATCH v3] qemu: Add suport for pci-assign.configfd option

2010-05-24 Thread Alex Williamson
This allows libvirt to open the PCI device sysfs config file prior to dropping privileges so qemu can access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- Note

[libvirt] [PATCH 2/2] qemu: Release bus address on PCI host device remove

2010-05-24 Thread Alex Williamson
Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_driver.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 32ce835..afdc718 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

Re: [libvirt] [RFC PATCH] qemu: Add suport for pci-assign.configfd option

2010-05-20 Thread Alex Williamson
On Wed, 2010-05-19 at 22:34 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: @@ -1378,6 +1420,9 @@ int qemudExtractVersionInfo(const char *qemu, version, is_kvm, kvm_version) == -1) goto cleanup2; +if (flags

[libvirt] [RFC PATCH v2] qemu: Add suport for pci-assign.configfd option

2010-05-20 Thread Alex Williamson
This allows libvirt to open the PCI device sysfs config file prior to dropping privileges so qemu can access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- v2: - fix

[libvirt] [PATCH] qemu: Genericize tapfds/ntapfds

2010-05-19 Thread Alex Williamson
There doesn't seem to be anything specific to tap devices for this array of file descriptors which need to stay open of the guest to use. Rename then for others to make use of. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_conf.c | 28

[libvirt] [RFC PATCH] qemu: Add suport for pci-assign.configfd option

2010-05-19 Thread Alex Williamson
access the full config space. Without this, a de-privileged qemu can only access the first 64 bytes of config space. Signed-off-by: Alex Williamson alex.william...@redhat.com --- src/qemu/qemu_conf.c | 85 +++- src/qemu/qemu_conf.h |8

<    1   2   3