[libvirt PATCH 6/8] apparmor: Improve virt-aa-helper include

2023-06-29 Thread Andrea Bolognani
For AppArmor 3.x we can use 'include if exists', which frees us from having to create a dummy override. For AppArmor 2.x we keep things as they are to avoid introducing regressions. Signed-off-by: Andrea Bolognani --- src/security/apparmor/meson.build | 15

[libvirt PATCH 4/8] apparmor: Only support passt on 3.x

2023-06-29 Thread Andrea Bolognani
The subprofile can only work by including the abstraction shipped in the passt package, which we can't assume is present, and 'include if exists' doesn't work well on 2.x. No distro that's stuck on AppArmor 2.x is likely to be shipping passt anyway. Signed-off-by: Andrea Bolognani --- src

[libvirt PATCH 1/8] meson: Detect AppArmor 3.x

2023-06-29 Thread Andrea Bolognani
We will soon need to base some decisions on whether AppArmor 3.x or 2.x is present on the system. Signed-off-by: Andrea Bolognani --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index aa391e7178..060eafc344 100644 --- a/meson.build +++ b

[libvirt PATCH 5/8] apparmor: Make abstractions extensible

2023-06-29 Thread Andrea Bolognani
Implement the standard AppArmor 3.x abstraction extension approach. Signed-off-by: Andrea Bolognani --- src/security/apparmor/libvirt-lxc.in | 4 src/security/apparmor/libvirt-qemu.in | 4 2 files changed, 8 insertions(+) diff --git a/src/security/apparmor/libvirt-lxc.in b/src

[libvirt PATCH 2/8] apparmor: Allow version-specific bits in profiles

2023-06-29 Thread Andrea Bolognani
Perform an additional preprocessing step before the existing variable substitution. This is the same approach that we already use to customize systemd unit files based on whether the service supports TCP connections. Signed-off-by: Andrea Bolognani --- src/security/apparmor/meson.build | 34

[libvirt PATCH 3/8] apparmor: Allow version-specific bits in abstractions too

2023-06-29 Thread Andrea Bolognani
Compared to profiles, we only need a single preprocessing step here, as there is no variable substitution happening. Signed-off-by: Andrea Bolognani --- .../apparmor/{libvirt-lxc => libvirt-lxc.in} | 0 .../{libvirt-qemu => libvirt-qemu.in} | 0 src/security/apparmor/meson

[libvirt PATCH 0/8] apparmor: Improve overrides, fix 2.x compatibility

2023-06-29 Thread Andrea Bolognani
An alternative to Jim's attempt[1]. See [2] for the discussion leading up to these changes. [1] https://listman.redhat.com/archives/libvir-list/2023-June/240531.html [2] https://listman.redhat.com/archives/libvir-list/2023-June/240251.html Andrea Bolognani (8): meson: Detect AppArmor 3.x

Re: [PATCH] Revert "apparmor: Add support for local profile customizations"

2023-06-28 Thread Andrea Bolognani
xend.in | 3 --- > src/security/apparmor/usr.sbin.virtxend.local | 1 - > 7 files changed, 5 insertions(+), 19 deletions(-) Thanks! Reviewed-by: Andrea Bolognani and safe for freeze. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-27 Thread Andrea Bolognani
On Mon, Jun 26, 2023 at 10:46:40PM +0200, Christian Boltz wrote: > Am Montag, 26. Juni 2023, 18:29:11 CEST schrieb Andrea Bolognani: > > On Mon, Jun 26, 2023 at 09:42:32AM -0600, Jim Fehlig wrote: > > > Specifying which copy to use via a build time option is also an > >

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-27 Thread Andrea Bolognani
On Mon, Jun 26, 2023 at 04:16:33PM -0600, Jim Fehlig wrote: > On 6/26/23 10:06, Andrea Bolognani wrote: > > The current logic in all packages' %post scriptlet basically > > translates to: if installing the package from scratch, apply the > > systemd presets; if upgrading, le

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-26 Thread Andrea Bolognani
On Mon, Jun 26, 2023 at 09:42:32AM -0600, Jim Fehlig wrote: > On 6/26/23 03:52, Andrea Bolognani wrote: > > On Fri, Jun 23, 2023 at 11:31:04AM -0600, Jim Fehlig wrote: > > > On 6/23/23 07:11, Andrea Bolognani wrote: > > > > However, not only you've added a few

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-26 Thread Andrea Bolognani
On Fri, Jun 16, 2023 at 03:57:37PM -0600, Jim Fehlig wrote: > On 6/16/23 02:12, Martin Kletzander wrote: > > On Wed, Jun 14, 2023 at 04:45:06PM -0600, Jim Fehlig wrote: > > > On 6/9/23 03:05, Andrea Bolognani wrote: > > > > Can we somehow enforce that libvirt-dae

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-26 Thread Andrea Bolognani
On Fri, Jun 23, 2023 at 11:31:04AM -0600, Jim Fehlig wrote: > On 6/23/23 07:11, Andrea Bolognani wrote: > > However, not only you've added a few such statements in your recent > > commit 9b743ee19053, but I myself have done the same a couple months > > back with commit

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-23 Thread Andrea Bolognani
On Thu, Jun 22, 2023 at 03:03:56PM -0600, Jim Fehlig wrote: > On 6/22/23 11:08, Jim Fehlig wrote: > > On 6/22/23 08:50, Andrea Bolognani wrote: > > > On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote: > > > > I assumed users would make VM customi

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-22 Thread Andrea Bolognani
On Thu, Jun 08, 2023 at 10:37:43AM -0600, Jim Fehlig wrote: > On 6/8/23 08:11, Andrea Bolognani wrote: > > Note that the Debian package has included this patch[1] for many > > years, and while it partially overlaps with what you've added here, I > > see that local overr

Re: [libvirt PATCH 7/9] util: relax requirement for logind to be running

2023-06-22 Thread Andrea Bolognani
Bus" string "org.freedesktop.login1" string ":1.4" string ":1.0" string ":1.1" ] Now the interesting question is whether we will (and should) run any of the code in the virsystemd module on such a machine... -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] spec: Drop numad usage on fedora 39+

2023-06-22 Thread Andrea Bolognani
awhide > > > > So maybe we will need to revert this? Or we may pretend that we never > > saw that and just carry on. I doubt numad had any users (I mean, from > > libvirt users group). Luckily this was never pushed so we don't need to take any action, but just in case I'll leave an explicit NACK here. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-09 Thread Andrea Bolognani
On Thu, Jun 08, 2023 at 12:35:45PM -0600, Jim Fehlig wrote: > On 6/8/23 08:52, Andrea Bolognani wrote: > > On Wed, Jun 07, 2023 at 04:31:36PM +0200, Martin Kletzander wrote: > > > +# Since this was split into a different package, a transparent update > > > for the >

Re: [PATCH] spec: Do not disable some systemd units of newly split package

2023-06-08 Thread Andrea Bolognani
hank you for getting the ball rolling; unfortunately, I don't think what you have come up with will help in the scenario I've just described. Basically we need to detect if we're installing the libvirt-daemon-proxy package as part of an upgrade and *not touch anything* if that's the case. I'm n

Re: [PATCH] apparmor: Add support for local profile customizations

2023-06-08 Thread Andrea Bolognani
on why you skipped them? Or should we add those too? [1] https://salsa.debian.org/libvirt-team/libvirt/-/blob/debian/latest/debian/patches/debian/apparmor_profiles_local_include.patch -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v2] ci: refresh with latest lcitool manifest

2023-06-01 Thread Andrea Bolognani
317.sh} (99%) > rename ci/containers/{alpine-315.Dockerfile => alpine-317.Dockerfile} (97%) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH for 9.4.0] include: Fix 'Since' for new VIR_MIGRATE_PARAM_COMPRESSION_* macros

2023-05-31 Thread Andrea Bolognani
s is because the patch > was sent in that release time frame). Change the version to the > current release. > > Signed-off-by: Michal Privoznik > --- > include/libvirt/libvirt-domain.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Andrea Bolognani

Re: [libvirt PATCH] ci: refresh with latest lcitool manifest

2023-05-31 Thread Andrea Bolognani
On Wed, May 31, 2023 at 11:37:01AM +0200, Erik Skultety wrote: > Adds Alpine 3.17 and 3.18 targets. I only see Alpine 3.17 being added, and Alpine 3.15 being removed. If that was the intention, then the commit message needs to express that more clearly... -- Andrea Bolognani / Red

Re: [PATCH 1/4] conf: add loader type 'none'

2023-05-23 Thread Andrea Bolognani
On Tue, May 23, 2023 at 06:32:07PM +0300, David Abdurachmanov wrote: > On Tue, May 23, 2023 at 6:12 PM Andrea Bolognani wrote: > > Put it another way: do you have any objections to loading > > qemu-riscv64_smode/u-boot.bin via -kernel as the default boot > > strategy for ris

Re: [PATCH 1/4] conf: add loader type 'none'

2023-05-23 Thread Andrea Bolognani
On Tue, May 23, 2023 at 04:05:04PM +0300, David Abdurachmanov wrote: > On Tue, May 23, 2023 at 3:18 PM Andrea Bolognani wrote: > > On Tue, May 23, 2023 at 11:59:41AM +0100, Richard W.M. Jones wrote: > > > I just came across this thread while trying to update the libvirt

Re: [PATCH 1/4] conf: add loader type 'none'

2023-05-23 Thread Andrea Bolognani
th/to/u-boot-spl.bin -device > loader,file=/path/to/u-boot.itb,addr=0x8020 ' Based on the information above, using --boot kernel=/path/to/u-boot.bin should work... > 'Course you have to disable SELinux ... ... without requiring this :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v2] rpm: Explain BuildRequires on qemu-img

2023-05-22 Thread Andrea Bolognani
On Wed, May 10, 2023 at 03:08:37PM +0200, Andrea Bolognani wrote: > It's not used as part of the build process or searched for at > build time, and the QEMU driver detects its path at runtime, > so one could think that the BuildRequires is unnecessary. But > we actually need it t

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-22 Thread Andrea Bolognani
On Mon, May 22, 2023 at 11:55:15AM +0200, Cornelia Huck wrote: > On Wed, May 17 2023, Andrea Bolognani wrote: > > Migration is of course the most obvious failure scenario, but one of > > the critical features offered by libvirt is guest ABI compatibility. > > >

[libvirt PATCH 4/4] Revert "conf: Introduce MTE domain feature"

2023-05-22 Thread Andrea Bolognani
The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: 720e8f13ff71377580cd37b118cee8a1f982d1d8 Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst

[libvirt PATCH 3/4] Revert "qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability"

2023-05-22 Thread Andrea Bolognani
The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: 1347a19f75a23b4d92e6a7b549fcde52b23f0258 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c

[libvirt PATCH 2/4] Revert "qemu: Validate MTE feature"

2023-05-22 Thread Andrea Bolognani
The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: c6c9b5d251de215ed378aa0bc31daa2e1170409e Signed-off-by: Andrea Bolognani --- src/qemu/qemu_validate.c | 25

[libvirt PATCH 0/4] Revert MTE support

2023-05-22 Thread Andrea Bolognani
See the subthread starting at [1] for the rationale. The QEMU commit that (temporarily) reverted KVM support is at [2]. [1] https://listman.redhat.com/archives/libvir-list/2023-May/239911.html [2] https://gitlab.com/qemu-project/qemu/-/commit/d009607d08d22f91ca399b72828c6693855e7325 Andrea

[libvirt PATCH 1/4] Revert "qemu: Generate command line for MTE feature"

2023-05-22 Thread Andrea Bolognani
The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: b10bc8f7ab6f9986ccc54ba04fc5b3bad7576be6 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c

Re: [libvirt PATCH] NEWS: Mention support for compressing parallel migration

2023-05-19 Thread Andrea Bolognani
On Thu, May 18, 2023 at 03:58:35PM +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > NEWS.rst | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 2/2] docs: make isa-debugcon example more useful / directly applicable

2023-05-18 Thread Andrea Bolognani
not how a firmware log is typically viewed or saved. Replace > type='pty' with type='file', and also provide an example element > (with the pathname of the logfile), similarly to how the example > just above provides a element too. > > Cc: "

Re: [PATCH 1/2] docs: fix typo in isa-debugcon example

2023-05-18 Thread Andrea Bolognani
onsoles", is > used for emulated (not paravirt) consoles, and it's the type that's > suitable for early debug output (such as from firmware). Thus, change > to . > > Cc: "Daniel P. Berrangé" > Cc: Andrea Bolognani > Fixes: 654968381df0256c047d2ecd4542ccc90dc57ad0 >

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-17 Thread Andrea Bolognani
think there is any readily available hardware supporting > MTE yet; I have been testing my code on the simulator...] Agreed on not enabling it by default, especially considering the current hardware support situation. The feature remains disabled by default after the patches that have been merged. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-17 Thread Andrea Bolognani
On Wed, May 17, 2023 at 09:14:02AM +0200, Michal Prívozník wrote: > On 5/16/23 18:32, Andrea Bolognani wrote: > > Last but not least, the way detection has been implemented is not > > accurate: as of today, QEMU does *not* support enabling MTE with KVM. > > Patches adding t

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-16 Thread Andrea Bolognani
t she can point out any mistakes I might have made above :) [1] https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05452.html -- Andrea Bolognani / Red Hat / Virtualization

[libvirt PATCH 0/3] qemu: Find dbus-daemon at runtime

2023-05-10 Thread Andrea Bolognani
Same as the changes made recently for QEMU helpers, except even more straightforward. Andrea Bolognani (3): qemu: Find dbus-daemon at runtime meson: Stop looking for dbus-daemon qemu: Update documentation for dbus_daemon qemu.conf key meson.build| 12

[libvirt PATCH 3/3] qemu: Update documentation for dbus_daemon qemu.conf key

2023-05-10 Thread Andrea Bolognani
Reflect the new default value, and explain that a runtime lookup will be performed if the value is not an absolute path. Signed-off-by: Andrea Bolognani --- src/qemu/qemu.conf.in | 4 +++- src/qemu/test_libvirtd_qemu.aug.in | 2 +- 2 files changed, 4 insertions(+), 2 deletions

[libvirt PATCH 1/3] qemu: Find dbus-daemon at runtime

2023-05-10 Thread Andrea Bolognani
Don't bother looking at /usr/libexec, since every distro ships dbus-daemon in $PATH. Note that it's still possible for the administrator to prevent this lookup and use an arbitrary binary by setting the appropriate key in qemu.conf. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_dbus.c | 14

[libvirt PATCH 2/3] meson: Stop looking for dbus-daemon

2023-05-10 Thread Andrea Bolognani
Now that we're performing the lookup at runtime, doing it at build time is no longer necessary. Signed-off-by: Andrea Bolognani --- meson.build | 12 src/qemu/qemu_conf.c | 1 + 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/meson.build b/meson.build index

[libvirt PATCH v2] rpm: Explain BuildRequires on qemu-img

2023-05-10 Thread Andrea Bolognani
It's not used as part of the build process or searched for at build time, and the QEMU driver detects its path at runtime, so one could think that the BuildRequires is unnecessary. But we actually need it to be present at build time in order to run the full test suite. Signed-off-by: Andrea

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Andrea Bolognani
On Wed, May 10, 2023 at 02:40:38PM +0200, Peter Krempa wrote: > On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote: > > Peter, is there a reason why we're still calling 'qemu-img create' > > for those specific images? Or could we replace those calls with > > prefor

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Andrea Bolognani
On Wed, May 10, 2023 at 12:01:03PM +0200, Martin Kletzander wrote: > On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote: > > It's not used as part of the build process or even searched for > > at build time. The QEMU driver detects its path at runtime. > >

Re: [libvirt PATCH] .gitlab-ci.yml: Fix Leap 15.4 codestyle job

2023-05-05 Thread Andrea Bolognani
ed-off-by: Erik Skultety > --- > .gitlab-ci.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

[libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-05 Thread Andrea Bolognani
It's not used as part of the build process or even searched for at build time. The QEMU driver detects its path at runtime. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c542ec3b2b..69cafc8b91

[libvirt PATCH 2/5] util: Introduce virFileFindInPathFull()

2023-05-05 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- src/libvirt_private.syms | 1 + src/util/virfile.c | 33 + src/util/virfile.h | 3 +++ 3 files changed, 37 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 62c296bf5f

[libvirt PATCH 4/5] meson: Stop looking for QEMU helpers

2023-05-05 Thread Andrea Bolognani
Now that we're performing the lookup at runtime, doing it at build time is no longer necessary. Signed-off-by: Andrea Bolognani --- meson.build | 24 src/qemu/qemu_conf.c | 4 2 files changed, 4 insertions(+), 24 deletions(-) diff --git a/meson.build b

[libvirt PATCH 5/5] qemu: Update documentation for qemu.conf keys

2023-05-05 Thread Andrea Bolognani
Reflect the new default value, and explain that a runtime lookup will be performed if the value is not an absolute path. Signed-off-by: Andrea Bolognani --- src/qemu/qemu.conf.in | 8 ++-- src/qemu/test_libvirtd_qemu.aug.in | 4 ++-- 2 files changed, 8 insertions(+), 4

[libvirt PATCH 3/5] qemu: Find helpers at runtime

2023-05-05 Thread Andrea Bolognani
removes the need to perform the lookup at build time, and thus to have the helpers installed in the build environment. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_interface.c | 15 +-- src/qemu/qemu_process.c | 17 + 2 files changed, 26 insertions(+), 6

[libvirt PATCH 1/5] util: Small refactor

2023-05-05 Thread Andrea Bolognani
Prepare for further changes. Signed-off-by: Andrea Bolognani --- src/util/virfile.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 228482e8f8..8e94d19e45 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c

[libvirt PATCH 0/5] qemu: Find helpers at runtime

2023-05-05 Thread Andrea Bolognani
fallback paths happen to match those used on those distributions: everywhere else, the choice is to either ensure that the additional packages are installed in the build environment or to produce a build of libvirt that can't use the corresponding features out of the box. Andrea Bolognani (5): util

Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38

2023-05-05 Thread Andrea Bolognani
variables: > IMAGE: registry.opensuse.org/opensuse/leap:15.4 > -NAME: opensuse-leap-154 > +NAME: opensuse-leap-15 > > Please let me know if your RB still stands or whether I need to respin with > that change. That should have happened as part of a3cc0e9ceb3e. Good catch. Please post it as a separate patch though. -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 5/5] meson: Improve initconfdir defaults

2023-05-05 Thread Andrea Bolognani
On Fri, May 05, 2023 at 01:37:59PM +0200, Martin Kletzander wrote: > On Tue, May 02, 2023 at 07:15:52PM +0200, Andrea Bolognani wrote: > > initconfdir = get_option('initconfdir') > > if initconfdir == '' > > - initconfdir = sysconfdir / 'sysconfig' > > + if (

Re: [libvirt PATCH 2/5] meson: Use initconfdir

2023-05-05 Thread Andrea Bolognani
On Fri, May 05, 2023 at 01:34:50PM +0200, Martin Kletzander wrote: > On Tue, May 02, 2023 at 07:15:49PM +0200, Andrea Bolognani wrote: > > -if [ -r "$SYSCONFDIR"/sysconfig/iptables ] > > +if [ -r "$INITCONFDIR"/iptables ] > > then > > -

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-05 Thread Andrea Bolognani
On Thu, May 04, 2023 at 02:21:57PM -0400, Laine Stump wrote: > On 5/4/23 4:33 AM, Andrea Bolognani wrote: > > I don't think we need the BuildRequires, or the build time detection, > > at all. Just > > > >#define NFT "nft" > > > > in th

[libvirt PATCH] util: Improve comment for workaround

2023-05-04 Thread Andrea Bolognani
Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani --- src/util/virfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] qemu: Fix error message

2023-05-04 Thread Andrea Bolognani
The spelling is slightly different from another otherwise identical error message in the same file. Signed-off-by: Andrea Bolognani --- Pushed as trivial. src/qemu/qemu_dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index

Re: [PATCH v2 1/1] cpu_riscv64.c: add update() implementation

2023-05-04 Thread Andrea Bolognani
Arm CPU driver as a base sounds reasonable, as they currently have the same level (read: pretty low) of sophistication. I've tested this against both the current version of QEMU and the upcoming one which implements query-cpu-definitions, and it works as expected. Reviewed-by: Andrea Bolognani and pushed. -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

2023-05-04 Thread Andrea Bolognani
iptables today, at least in Fedora. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 1/1] cpu_riscv64.c: add update() implementation

2023-05-03 Thread Andrea Bolognani
On Fri, Apr 28, 2023 at 02:15:04PM -0300, Daniel Henrique Barboza wrote: > On 4/28/23 12:40, Andrea Bolognani wrote: > > On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote: > > > At this moment it is not possible to launch a 'riscv64' domain of type >

Re: [libvirt PATCH 0/4] ci: Update to latest lcitool, drop Fedora 36 & add Fedora 38

2023-05-03 Thread Andrea Bolognani
t; > Once those are in, I'll provide a link to a fresh libvirt proof pipeline. > > Erik Skultety (4): > ci: Add Fedora 38 target > ci: Drop Fedora 36 target > ci: Flip mingw jobs from Fedora 37 to Fedora 38 > ci: integration: Flip QEMU upstream integration tests to Fedora 38 Review

Re: [libvirt PATCH 3/4] ci: Flip mingw jobs from Fedora 37 to Fedora 38

2023-05-03 Thread Andrea Bolognani
-38: > jobs: >- arch: x86_64 > @@ -137,6 +132,12 @@ targets: >paths: > - libvirt-rpms > > + - arch: mingw32 > +builds: false > + > + - arch: mingw64 > + > + >fedora-rawhide: > jobs: >

[libvirt PATCH 2/5] meson: Use initconfdir

2023-05-02 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/manpages/libvirt-guests.rst| 2 +- docs/manpages/meson.build | 1 + src/ch/virtchd.service.in | 2 +- src/interface/virtinterfaced.service.in | 2 +- src/libxl/virtxend.service.in | 2 +- src/locking

[libvirt PATCH 3/5] rpm: Set initconfdir explicitly

2023-05-02 Thread Andrea Bolognani
The default would already work fine for Fedora and RHEL, but it's better to be explicit. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index dae9c87aa4..c542ec3b2b 100644 --- a/libvirt.spec.in +++ b

[libvirt PATCH 5/5] meson: Improve initconfdir defaults

2023-05-02 Thread Andrea Bolognani
Keep /etc/sysconfig as the fallback, but pick more suitable values for various Linux distros. Signed-off-by: Andrea Bolognani --- meson.build | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8848e58995..f04703b810 100644

[libvirt PATCH 1/5] meson: Introduce initconfdir option

2023-05-02 Thread Andrea Bolognani
integration. This new option will provide a convenient way to override the default location at build time that is usable by distro packagers and people building from source alike. Signed-off-by: Andrea Bolognani --- meson.build | 5 + meson_options.txt | 1 + 2 files changed, 6

[libvirt PATCH 4/5] meson: Move definition of os_release

2023-05-02 Thread Andrea Bolognani
We're about to introduce another user of the value in a different scope. Signed-off-by: Andrea Bolognani --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8da987b1cb..8848e58995 100644 --- a/meson.build +++ b/meson.build

[libvirt PATCH 0/5] meson: Introduce initconfdir option

2023-05-02 Thread Andrea Bolognani
Makes things nicer for those using distros that are not derived from RHEL or SUSE. Andrea Bolognani (5): meson: Introduce initconfdir option meson: Use initconfdir rpm: Set initconfdir explicitly meson: Move definition of os_release meson: Improve initconfdir defaults docs/manpages

[libvirt PATCH] meson: Fix qemu_{user,group} defaults for Arch

2023-05-02 Thread Andrea Bolognani
The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani --- Proof that I'm not making this up: https://github.com/archlinux/svntogit-community/blob

Re: [PATCH v1] use libexecdir as location for qemu-bridge-helper

2023-05-02 Thread Andrea Bolognani
rtion(+), 1 deletion(-) I have patches for turning these build time lookups into runtime lookups almost ready. Please give me a few more days :) -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 1/1] cpu_riscv64.c: add update() implementation

2023-04-28 Thread Andrea Bolognani
/dev/urandom -- Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 03:23:29PM +0200, Michal Prívozník wrote: > On 4/27/23 15:12, Andrea Bolognani wrote: > > Do you think it's okay for me to push this now, so that it gets > > included in 9.3.0, or should I rather wait until after the release? > > It's a bug fix and as

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 02:57:54PM +0200, Michal Prívozník wrote: > On 4/27/23 14:22, Andrea Bolognani wrote: > > This fixes cross-building in some scenarios. > > > > Specifically, when building for armv7l on x86_64, has_header() > > will see the x86_64 versio

[libvirt PATCH v2 0/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/850846324 Changes from [v1]: * replace all uses of has_header() with check_header(). [v1] https://listman.redhat.com/archives/libvir-list/2023-April/239672.html Andrea Bolognani (1): meson: Check header usability meson.build

[libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
, but while testing this change on fairly old and underpowered hardware I haven't been able to measure any meaningful slowdown. https://bugs.debian.org/1024504 Suggested-by: Helmut Grohne Signed-off-by: Andrea Bolognani --- meson.build | 16 1 file changed, 8 insertions(+), 8

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 11:28:36AM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 27, 2023 at 12:00:59PM +0200, Andrea Bolognani wrote: > > On Thu, Apr 27, 2023 at 11:50:05AM +0200, Michal Prívozník wrote: > > > But leaving meson aside, shouldn't we just use check_header() for

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 11:50:05AM +0200, Michal Prívozník wrote: > On 4/27/23 11:41, Andrea Bolognani wrote: > > +# headers for which we need to check actual usability. in most > > +# cases, checking for presence is enough (and it's way faster) > > +check_headers =

[libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
the header's availability status. Checking for its actual usability, as opposed to mere presence, is enough to make things work correctly in all cases. https://bugs.debian.org/1024504 Suggested-by: Helmut Grohne Signed-off-by: Andrea Bolognani --- meson.build | 13 - 1 file changed, 12

Re: [libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 09:12:22AM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 27, 2023 at 09:56:06AM +0200, Peter Krempa wrote: > > On Thu, Apr 27, 2023 at 09:51:21 +0200, Andrea Bolognani wrote: > > > That's the new canonical location for information on

[libvirt PATCH 1/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
All the information from docs/java.rst have been transferred to the subproject's own website. Signed-off-by: Andrea Bolognani --- docs/bindings.rst | 3 ++- docs/docs.rst | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/bindings.rst b/docs/bindings.rst index

[libvirt PATCH 2/2] docs: Drop java.rst

2023-04-27 Thread Andrea Bolognani
We no longer link to it from anywhere. Signed-off-by: Andrea Bolognani --- docs/java.rst| 127 --- docs/meson.build | 1 - 2 files changed, 128 deletions(-) delete mode 100644 docs/java.rst diff --git a/docs/java.rst b/docs/java.rst deleted

[libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
That's the new canonical location for information on libvirt-java. A server-side redirect will have to be created in order to keep existing external links working. Andrea Bolognani (2): docs: Link to java.libvirt.org docs: Drop java.rst docs/bindings.rst | 3 +- docs/docs.rst | 2

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
On Tue, Apr 18, 2023 at 03:43:41PM +0200, Ján Tomko wrote: > On a Tuesday in 2023, Andrea Bolognani wrote: > > On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: > > > On a Tuesday in 2023, Andrea Bolognani wrote: > > > > That's already the case

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: > On a Tuesday in 2023, Andrea Bolognani wrote: > > That's already the case in practice, but it's a better > > experience for the user if we reject this configuration > > outright instead of silently ignoring part of i

[libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
That's already the case in practice, but it's a better experience for the user if we reject this configuration outright instead of silently ignoring part of it. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c| 9 + ...t-user-slirp-portforward.x86_64

Re: [PATCH V2 0/3] Change default machine type for ARM and RISC-V

2023-04-18 Thread Andrea Bolognani
fore pushing. Everything else looks excellent. Thanks a lot for looking into this! Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH V2 3/3] NEWS: Mention change of default machine type for ARM and RISC-V

2023-04-18 Thread Andrea Bolognani
arly unusable and had to be overridden in > most > +cases. Indentation is off. Please fix it before pushing. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 0/3] Change default machine type for aarch64 and riscv64

2023-04-17 Thread Andrea Bolognani
able to make host-model work across both TCG and KVM. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 3/3] NEWS: Mention change of default machine type for aarch64 and riscv64

2023-04-17 Thread Andrea Bolognani
efaults were nearly unusable and had to be overridden in most cases. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 2/3] qemu: Change default machine type for riscv64

2023-04-17 Thread Andrea Bolognani
n to limit this change to riscv64 when riscv32 would benefit from it just the same. Please change the default machine type for both architectures. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 1/3] qemu: Change default machine type for aarch64

2023-04-17 Thread Andrea Bolognani
a great way to overcome them. So, please change the default machine type to virt for armv7l and armv7b too. Note that I'm leaving armv6l out of the discussion here because it already behaves slightly differently from other Arm architectures, and also at this point there's probably no use fo

Re: [PATCH 1/4] conf: add loader type 'none'

2023-04-14 Thread Andrea Bolognani
On Mon, Apr 10, 2023 at 07:50:36PM -0300, Daniel Henrique Barboza wrote: > On 4/7/23 15:12, Andrea Bolognani wrote: > > On Tue, Mar 28, 2023 at 04:46:45PM -0300, Daniel Henrique Barboza wrote: > So, I talked with Canonical a few months back about this package. I'm using a > F37

Re: [PATCH 1/4] conf: add loader type 'none'

2023-04-14 Thread Andrea Bolognani
it looks like it can't find the root filesystem. But eventually I get dropped into a rescue shell, and /sys/firmware/efi/ contains some data. Note that I'm not using edk2 in this case, just the same u-boot.bin file that I've used to boot other images. -- Andrea Bolognani / Red Hat / Virtualization

Re: Improve default machine type selection

2023-04-14 Thread Andrea Bolognani
On Fri, Apr 14, 2023 at 03:33:21PM +0200, Peter Krempa wrote: > On Fri, Apr 14, 2023 at 06:26:02 -0700, Andrea Bolognani wrote: > > I don't think we rely on default machine types anywhere in the test > > suite, and even if we were only minor touch-ups would probably be > > ne

Re: Improve default machine type selection

2023-04-14 Thread Andrea Bolognani
On Thu, Apr 13, 2023 at 08:23:25AM -0600, Jim Fehlig wrote: > On 4/6/23 08:27, Andrea Bolognani wrote: > > On Thu, Apr 06, 2023 at 06:10:11AM -0700, Andrea Bolognani wrote: > > > In conclusion, there currently doesn't seem to exist a way to define > > > a useful integ

[PATCH] qemu: Fix incorrect command name in error messages

2023-04-14 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- Pushed as trivial. src/qemu/qemu_monitor_json.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3b42b28fa1..b2c0b20a11 100644 --- a/src/qemu/qemu_monitor_json.c +++ b

Re: [PATCH 1/3] util: Introduce virAcpi module

2023-04-12 Thread Andrea Bolognani
On Wed, Apr 12, 2023 at 12:37:39PM +0200, Jiri Denemark wrote: > On Thu, Apr 06, 2023 at 02:20:31 -0700, Andrea Bolognani wrote: > > On Thu, Apr 06, 2023 at 10:20:46AM +0200, Michal Prívozník wrote: > > > On 4/5/23 19:21, Andrea Bolognani wrote: > > > > On Wed, Ap

<    1   2   3   4   5   6   7   8   9   10   >