On 12/6/14, 2:51 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-12-06 2:37 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
In Open Contrail (www.opencontrail.org), we use this feature where tap
interface is created first, so that we know the name of the tap device a
priori, before
On 12/8/14, 2:10 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Fri, Dec 05, 2014 at 11:37:05PM +, Anirban Chakraborty wrote:
On 12/5/14, 10:43 AM, Laine Stump la...@laine.org wrote:
On 12/05/2014 06:12 AM, Michal Privoznik wrote:
@@ -7374,7 +7399,8
On 12/5/14, 10:43 AM, Laine Stump la...@laine.org wrote:
On 12/05/2014 06:12 AM, Michal Privoznik wrote:
@@ -7374,7 +7399,8 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd,
}
if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
-actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)
On 11/20/14, 5:43 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-20 7:58 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
Your original error message was that qemu couldn¹t find a tap device.
So,
I am not sure how the above error relates to your original error.
Can you write your
On 11/19/14, 7:15 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-19 2:55 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
Ethernet interfaces in libvirt currently do not support bandwidth
setting.
For example, following xml file for an interface will not apply these
settings
On 11/19/14, 9:23 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-19 20:17 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
The Œethernet¹ interface type assumes that you have an existing tap
device. Did you check if the tap device that it is complaining against
actually exists
On 11/19/14, 2:05 PM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-19 20:54 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
The patch didn¹t do anything to add/delete tap devices. Please see the
following links where similar issue has been discussed.
http://wiki.libvirt.org/page
On 11/18/14, 2:40 AM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-13 2:07 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
From 7db513698bfcc30d2d0b020c3fcf9e0337c66ff4 Mon Sep 17 00:00:00 2001
From: Anirban Chakraborty abc...@juniper.net
Date: Wed, 12 Nov 2014 14:24:43 -0800
On 11/18/14, 2:25 PM, Vasiliy Tolstov v.tols...@selfip.ru wrote:
2014-11-18 21:03 GMT+03:00 Anirban Chakraborty abc...@juniper.net:
I was wondering as well if this patch looks fine and ready for merge.
Michal, Laine, any thoughts ?
Also its not compiled with 1.2.9.1 =(
/tmp/buildd/libvirt
=/
target dev=tap361d182a-e4/
bandwidth
inbound average=984 peak=1024 burst=64/
outbound average=2000 peak=2048 burst=128/
/bandwidth
/interface
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/netdev_bandwidth_conf.c | 14 ++-
src/conf
On 11/12/14, 2:53 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 11.11.2014 23:45, Anirban Chakraborty wrote:
On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote:
On 11/10/2014 03:41 PM, Anirban Chakraborty wrote:
BTW: it would be nice if you can version you patches. I mean
From 7db513698bfcc30d2d0b020c3fcf9e0337c66ff4 Mon Sep 17 00:00:00 2001
From: Anirban Chakraborty abc...@juniper.net
Date: Wed, 12 Nov 2014 14:24:43 -0800
Subject: [PATCH] network: Add network bandwidth support to ethernet interfaces
Ethernet interfaces in libvirt currently do not support
On 11/10/14, 3:13 PM, Eric Blake ebl...@redhat.com wrote:
On 11/10/2014 03:41 PM, Anirban Chakraborty wrote:
BTW: it would be nice if you can version you patches. I mean, this is
what, 4th or 5th version? Say that in subject explicitly please. You
know, in the prefix: [PATCH v5] network
On 11/3/14, 2:58 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 30.10.2014 00:56, Anirban Chakraborty wrote:
snip
+static inline bool virNetDevSupportBandwidth(virDomainNetType type)
+{
+switch (type) {
+case VIR_DOMAIN_NET_TYPE_BRIDGE:
+case VIR_DOMAIN_NET_TYPE_NETWORK
Ping ?
On 10/29/14, 4:56 PM, Anirban Chakraborty abc...@juniper.net wrote:
Ethernet interfaces in libvirt currently do not support bandwidth setting.
For example, following xml file for an interface will not apply these
settings to corresponding qdiscs.
interface type=ethernet
mac
=/
target dev=tap361d182a-e4/
bandwidth
inbound average=984 peak=1024 burst=64/
outbound average=2000 peak=2048 burst=128/
/bandwidth
/interface
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/domain_conf.h | 21 +
src/lxc
On 10/10/14, 3:23 PM, Anirban Chakraborty abc...@juniper.net wrote:
v4:
Changed function virNetDevSupportBandwidth to use switch statement.
Fixed syntax issues
Fold the two patches into one as the second patch was a one liner
v3:
Addressed issues pointed out in V2
Split into two patches
v2
On 10/10/14, 3:23 PM, Anirban Chakraborty abc...@juniper.net wrote:
v4:
Changed function virNetDevSupportBandwidth to use switch statement.
Fixed syntax issues
Fold the two patches into one as the second patch was a one liner
v3:
Addressed issues pointed out in V2
Split into two patches
v2
On 10/10/14, 5:27 AM, Eric Blake ebl...@redhat.com wrote:
On 10/09/2014 12:21 AM, Anirban Chakraborty wrote:
Alas, using a default case means the compiler can no longer tell you
about missed cases. I wrote my example to intentionally spell out ALL
cases without a default, in order
On 10/10/14, 11:13 AM, Eric Blake ebl...@redhat.com wrote:
On 10/10/2014 10:59 AM, Anirban Chakraborty wrote:
The list is really very long to put all in here. If we have to do what
you
suggested, then we¹d be changing all such usage of switch statements,
which is not trivial, I believe
On 10/10/14, 11:42 AM, Anirban Chakraborty abc...@juniper.net wrote:
On 10/10/14, 11:13 AM, Eric Blake ebl...@redhat.com wrote:
On 10/10/2014 10:59 AM, Anirban Chakraborty wrote:
The list is really very long to put all in here. If we have to do what
you
suggested, then we¹d be changing
=ethernet
mac address=02:36:1d:18:2a:e4/
model type=virtio/
script path=/
target dev=tap361d182a-e4/
bandwidth
inbound average=984 peak=1024 burst=64/
outbound average=2000 peak=2048 burst=128/
/bandwidth
/interface
Signed-off-by: Anirban
On 10/8/14, 8:39 PM, Eric Blake ebl...@redhat.com wrote:
On 10/08/2014 04:10 PM, Anirban Chakraborty wrote:
Needs rework after my comments on 1/2. I also wonder if this should
just be folded in to that patch, and/or made into a switch statement
where the compiler forces us to think about
bandwidth setting.
For example, following xml file for an interface will not apply these
settings to corresponding qdiscs.
Signed-off-by: Anirban Chakraborty abc...@juniper.net
Anirban Chakraborty (2):
network: Refactor code to add bandwidth support for ethernet interfaces
network: Add code
Modified code to set and clear bandwidth cleanly.
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/domain_conf.h | 7 +++
src/lxc/lxc_driver.c| 3 +++
src/lxc/lxc_process.c | 18 +-
src/qemu/qemu_command.c | 25
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/domain_conf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index f03599e..91da1ec 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
On 10/8/14, 2:39 PM, Eric Blake ebl...@redhat.com wrote:
On 10/08/2014 01:59 PM, Anirban Chakraborty wrote:
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/domain_conf.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.h b
On 10/6/14, 3:43 AM, Michal Privoznik mpriv...@redhat.com wrote:
On 18.09.2014 01:33, Anirban Chakraborty wrote:
V2:
Consolidate calls to virNetDevBandwidthSet
Clear bandwidth settings when the interface is detached or domain
destroyed
V1:
Ethernet interfaces in libvirt currently do
On 10/5/14, 11:07 PM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote:
V2:
Addressed comments raised in review of V1.
Consolidate calls to virNetDevBandwidthSet.
Clear bandwidth settings when the interface is detached or domain
On 10/6/14, 11:16 AM, Laine Stump la...@laine.org wrote:
On 10/06/2014 02:07 AM, Martin Kletzander wrote:
On Fri, Sep 26, 2014 at 10:52:57AM -0700, Anirban Chakraborty wrote:
V2:
Addressed comments raised in review of V1.
Consolidate calls to virNetDevBandwidthSet.
Clear bandwidth settings
Should I recreate this patch on the top of the latest tree and resubmit?
Or, is there anything that I missed out? Any feedback will be highly
appreciated. Thanks.
Anirban
On 9/26/14, 10:52 AM, Anirban Chakraborty abc...@juniper.net wrote:
V2:
Addressed comments raised in review of V1
=2048 burst=128/
/bandwidth
/interface
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/lxc/lxc_process.c | 26 +-
src/network/bridge_driver.c| 7 ---
src/qemu/qemu_command.c| 9 -
src/qemu/qemu_driver.c | 22
On 9/17/14, 4:33 PM, Anirban Chakraborty abc...@juniper.net wrote:
V2:
Consolidate calls to virNetDevBandwidthSet
Clear bandwidth settings when the interface is detached or domain
destroyed
V1:
Ethernet interfaces in libvirt currently do not support bandwidth setting.
For example, following xml
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/conf/domain_conf.h | 7 +++
src/lxc/lxc_process.c | 27 ++-
src/qemu/qemu_command.c | 9 -
src/qemu/qemu_driver.c | 21 +
src/qemu/qemu_hotplug.c | 13
On 9/7/14, 2:01 AM, Martin Kletzander mklet...@redhat.com wrote:
On Fri, Sep 05, 2014 at 11:42:58PM +, Anirban Chakraborty wrote:
On 9/5/14, 1:31 AM, Martin Kletzander mklet...@redhat.com wrote:
On Thu, Sep 04, 2014 at 03:02:54PM -0700, Anirban Chakraborty wrote:
snip
It doesn't
On 9/5/14, 8:52 AM, Laine Stump la...@laine.org wrote:
On 09/05/2014 04:31 AM, Martin Kletzander wrote:
On Thu, Sep 04, 2014 at 03:02:54PM -0700, Anirban Chakraborty wrote:
ethernet interfaces in libvirt currently do not support bandwidth
setting.
For example, following xml file
On 9/5/14, 1:31 AM, Martin Kletzander mklet...@redhat.com wrote:
On Thu, Sep 04, 2014 at 03:02:54PM -0700, Anirban Chakraborty wrote:
ethernet interfaces in libvirt currently do not support bandwidth
setting.
For example, following xml file for an interface will not apply these
settings
=/
target dev=tap361d182a-e4/
bandwidth
inbound average=984 peak=1024 burst=64/
outbound average=2000 peak=2048 burst=128/
/bandwidth
/interface
-
This patch fixes the behavior. Please review it and if it appears ok,
please apply.
thanks,
Anirban Chakraborty
Please apply.
thanks,
Anirban Chakraborty
Signed-off-by: Anirban Chakraborty abc...@juniper.net
---
src/qemu/qemu_command.c | 5 +
src/qemu/qemu_hotplug.c | 3 +++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 2184caa
39 matches
Mail list logo
