[libvirt] [PATCH v4.1 2/2] news: add change of hot unplug redirdev

2018-01-05 Thread Chen Hanxiao
From: Chen Hanxiao Reviewed-by: John Ferlan Signed-off-by: Chen Hanxiao --- v4: remove part v3: move it into 'Improvements' section docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index bb611b7ba..838dd5b39 100644 --- a/doc

[libvirt] [PATCH v4.1 0/2] qemu: Add support for hot unplugging redirdev

2018-01-05 Thread Chen Hanxiao
v4.1: call qemuDomainRemoveRedirdevDevice in qemuDomainRemoveDevice v4: update commit messages and news v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use

[libvirt] [PATCH v4.1 1/2] qemu: Add support for hot unplugging redirdev device which can use the detach-device --live

2018-01-05 Thread Chen Hanxiao
From: Chen Hanxiao Commit id '162efa1a' added support hotplug a redirdev, but did not add the hot unplug. This patch will add that support to allow usage of the detach-device --live on the device. Reviewed-by: John Ferlan Signed-off-by: Chen Hanxiao --- v4

[libvirt] [PATCH v2 0/2] qemu_hotplug: introduce VIR_ERR_DEVICE_MISSING for failing to find the desired device

2018-01-05 Thread Chen Hanxiao
We used VIR_ERR_OPERATION_INVALID for failing to find the desired device. But this error code is widely used. This brings troubles to the project(i.e nova) powered by libvirt, they had to analyze error messages to find out what had happened. Chen Hanxiao (2): qemu_hotplug: more proper error

[libvirt] [PATCH v2 1/2] qemu_hotplug: more proper error messages when target detaching device is not found

2018-01-05 Thread Chen Hanxiao
From: Chen Hanxiao More proper/detail error messages updated. Signed-off-by: Chen Hanxiao --- src/libvirt_private.syms | 2 ++ src/qemu/qemu_hotplug.c | 42 +- 2 files changed, 31 insertions(+), 13 deletions(-) diff --git a/src/libvirt_private.syms b

[libvirt] [PATCH v2 2/2] qemu_hotplug: introduce VIR_ERR_DEVICE_MISSING for failing to find desired device

2018-01-05 Thread Chen Hanxiao
From: Chen Hanxiao We used VIR_ERR_OPERATION_FAILED when target detaching device is not found. That error code VIR_ERR_OPERATION_FAILED is widely used, so the tools powered by libvirt, such as nova, can't catch the exact errors from libvirt. This patch introduce VIR_ERR_DEVICE_MISSING for

[libvirt] [PATCH v4 0/2] qemu: Add support for hot unplugging redirdev

2018-01-04 Thread Chen Hanxiao
v4: update commit messages and news v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev

[libvirt] [PATCH v4 1/2] qemu: Add support for hot unplugging redirdev device which can use the detach-device --live

2018-01-04 Thread Chen Hanxiao
From: Chen Hanxiao Commit id '162efa1a' added support hotplug a redirdev, but did not add the hot unplug. This patch will add that support to allow usage of the detach-device --live on the device. Reviewed-by: John Ferlan Signed-off-by: Chen Hanxiao --- v4: commit message chang

[libvirt] [PATCH v4 2/2] news: add change of hot unplug redirdev

2018-01-04 Thread Chen Hanxiao
From: Chen Hanxiao Reviewed-by: John Ferlan Signed-off-by: Chen Hanxiao --- v4: remove part v3: move it into 'Improvements' section docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index bb611b7ba..838dd5b39 100644 --- a/doc

[libvirt] [PATCH] util: fix another wrong description

2018-01-03 Thread Chen Hanxiao
From: Chen Hanxiao commit 9026d1152c236ac7a7ab25845220a8e14d6bc630 forgot to change the referenced @result variable. This patch completed this. Signed-off-by: Chen Hanxiao --- src/util/virstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src

Re: [libvirt] [PATCH] util: fix a wrong description

2018-01-03 Thread Chen Hanxiao
At 2018-01-03 17:46:02, "Ján Tomko" wrote: >On Sat, Dec 23, 2017 at 05:49:08PM +0800, Chen Hanxiao wrote: >>From: Chen Hanxiao >> >>We don't have @result. Use the right one: @matches >> >>Signed-off-by: Chen Hanxiao >>--- >> src/

[libvirt] [PATCH] domain_conf: skip boot order check of CD-ROM or floppy device

2017-12-25 Thread Chen Hanxiao
From: Chen Hanxiao If we insert or eject a CD-ROM/floppy device with a boot order, we may get: unsupported configuration: boot order 2 is already used by another device This check should be skipped in this case. Signed-off-by: Chen Hanxiao --- src/conf/domain_conf.c | 16

[libvirt] [PATCH] util: fix a wrong description

2017-12-23 Thread Chen Hanxiao
From: Chen Hanxiao We don't have @result. Use the right one: @matches Signed-off-by: Chen Hanxiao --- src/util/virstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virstring.c b/src/util/virstring.c index b2ebce27f..0cb06bdc9 100644 --- a/src

[libvirt] [PATCH v3 0/2] qemu: Add support for hot unplugging

2017-12-22 Thread Chen Hanxiao
v3: use helper qemuDomainDelChardevTLSObjects and address some comments v2: rebased on master Chen Hanxiao (2): qemu: Add support for hot unplugging redirdev device which can use the detach-device --live news: add change of hot unplug redirdev docs/news.xml | 11

[libvirt] [PATCH v3 2/2] news: add change of hot unplug redirdev

2017-12-22 Thread Chen Hanxiao
From: Chen Hanxiao Add hot unplug redirdev in news 'Improvements' section Signed-off-by: Chen Hanxiao --- v3: move it into 'Improvements' section docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index bb611b7

[libvirt] [PATCH v3 1/2] qemu: Add support for hot unplugging redirdev device which can use the detach-device --live

2017-12-22 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- v3: use helper qemuDomainDelChardevTLSObjects address John's comments v2: rebase on master src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v2/1] qemu: Move TCP and haveTLS checks into qemuDomainDelChardevTLSObjects

2017-12-20 Thread Chen Hanxiao
t; the morning" I realized I could/should have taken the next step to check > the chardev source for TCP and haveTLS being set similar to how the Add > code does things. So that's what this patch does. > Ahh, more helpful helper. Reviewed-by: Chen Hanxiao Regards, - Chen --

[libvirt] [PATCH] qemu_hotplug: use VIR_ERR_NO_DEVICE when target detaching device is not found

2017-12-20 Thread Chen Hanxiao
From: Chen Hanxiao We used VIR_ERR_OPERATION_FAILED when target detaching device is not found. That error code VIR_ERR_OPERATION_FAILED is widely used, so the tools powered by libvirt, such as nova, can't catch the exact errors from libvirt. This patch uses VIR_ERR_NO_DEVICE instead. Signe

Re: [libvirt] [PATCH] qemu: hotplug: unify "not found" logs when detaching device

2017-12-20 Thread Chen Hanxiao
At 2017-12-18 21:57:11, "John Ferlan" wrote: > > >On 12/15/2017 09:50 PM, Chen Hanxiao wrote: >> >> >> At 2017-12-16 09:26:32, "John Ferlan" wrote: >>> >>> >>> On 12/14/2017 06:16 AM, Chen Hanxiao wrote: >>>&g

Re: [libvirt] [PATCH] qemu: Introduce qemuDomainDelChardevTLSObjects

2017-12-19 Thread Chen Hanxiao
ining the copy and pasted code. > >Signed-off-by: John Ferlan >--- > > An offshoot of the redirdev hot unplug patches from Chen Hanxiao. > Let's create a helper that can remove the TLS chardev objects for > the specific devices that may have used them. > Reviewed-by: Chen Ha

[libvirt] [PATCH] deamon: TLS: use default value if ca_file, cert_file or key_file not set

2017-12-17 Thread Chen Hanxiao
From: Chen Hanxiao As the description of daemon/libvirtd.conf, setting key_file, cert_file or key_file will override the default value. But if we set any one of them, we need to set all the rest of them. This patch set default value to them as daemon/libvirtd.conf described. Signed-off-by

Re: [libvirt] [PATCH] qemu: hotplug: unify "not found" logs when detaching device

2017-12-15 Thread Chen Hanxiao
At 2017-12-16 09:26:32, "John Ferlan" wrote: > > >On 12/14/2017 06:16 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Some services, such as Nova, check whether device was not found >> by errror messages "not found&

[libvirt] [PATCH] qemu: hotplug: unify "not found" logs when detaching device

2017-12-14 Thread Chen Hanxiao
From: Chen Hanxiao Some services, such as Nova, check whether device was not found by errror messages "not found". [1] This patch unify logs of qemuDomainDetachDeviceLive, which will be helpful. [1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L406 Sig

Re: [libvirt] [PATCH v2.1 0/2] Add support for hot unplug redirdev

2017-12-12 Thread Chen Hanxiao
At 2017-12-07 18:42:37, "Chen Hanxiao" wrote: >v2.1: >split original patch into a patchset, put News in a seperate patch > >Chen Hanxiao (2): > qemu: Add support for hot unplug redirdev device > news: add change of hot unplug redirdev > > docs/news.x

[libvirt] [PATCH v2.1 2/2] news: add change of hot unplug redirdev

2017-12-07 Thread Chen Hanxiao
From: Chen Hanxiao Add hot unplug redirdev in news 'New features' section Signed-off-by: Chen Hanxiao --- v2.1: put news part into a seperate patch docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 0ec9857e2..ec32dc

[libvirt] [PATCH v2.1 1/2] qemu: Add support for hot unplug redirdev device

2017-12-07 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- v2.1: rebase on master src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 111

[libvirt] [PATCH v2.1 0/2] Add support for hot unplug redirdev

2017-12-07 Thread Chen Hanxiao
v2.1: split original patch into a patchset, put News in a seperate patch Chen Hanxiao (2): qemu: Add support for hot unplug redirdev device news: add change of hot unplug redirdev docs/news.xml | 9 src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 111

Re: [libvirt] [PATCH v2] qemu: Add support for hot unplug redirdev device

2017-12-07 Thread Chen Hanxiao
At 2017-12-07 17:35:42, "Peter Krempa" wrote: >On Thu, Dec 07, 2017 at 09:26:12 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> We lacked of hot unplugging redirdev device. >> This patch add support for it. >> We could use detach-de

Re: [libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED

2017-12-07 Thread Chen Hanxiao
At 2017-12-07 17:30:15, "Michal Privoznik" wrote: >On 12/07/2017 02:59 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Since commit 5e5019bf, we've no longer use >> VIR_ERR_AGENT_UNSYNCED anymore. >> Mark it as DEPRECATED. >> >

[libvirt] [PATCH] virerror: mark VIR_ERR_AGENT_UNSYNCED as DEPRECATED

2017-12-06 Thread Chen Hanxiao
From: Chen Hanxiao Since commit 5e5019bf, we've no longer use VIR_ERR_AGENT_UNSYNCED anymore. Mark it as DEPRECATED. Signed-off-by: Chen Hanxiao --- include/libvirt/virterror.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/virterror.h b/include/li

[libvirt] [PATCH v2] qemu: Add support for hot unplug redirdev device

2017-12-06 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- v2: add news section docs/news.xml | 9 src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 111

[libvirt] [RESEND PATCH] qemu: Add support for hot unplug redirdev device

2017-12-04 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch add support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- rebase on 3.10 src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 111

Re: [libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-30 Thread Chen Hanxiao
At 2017-11-30 14:11:36, "Nikolay Shirokovskiy" wrote: > > >On 30.11.2017 06:08, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Commit 5e5019bf removed this kind of error. >> >> But we've already protected race condition by qemuDomainOb

[libvirt] [PATCH] qemu_agent: report VIR_ERR_AGENT_UNSYNCED if guest_sync failed.

2017-11-29 Thread Chen Hanxiao
From: Chen Hanxiao Commit 5e5019bf removed this kind of error. But we've already protected race condition by qemuDomainObjEnterAgent, it was very unlikely to revieve a sync from other calls. For call from virDomain*, it's better to show this error if we really got a mismatch sync.

Re: [libvirt] [PATCH] qemu: Add support for hot unplug redirdev device

2017-11-26 Thread Chen Hanxiao
At 2017-11-20 11:08:54, "Chen Hanxiao" wrote: > >At 2017-11-10 16:35:59, "Chen Hanxiao" wrote: >>From: Chen Hanxiao >> >> We lacked of hot unplugging redirdev device. >> This patch adds support for it. >> We could use detach-devi

Re: [libvirt] [PATCH] qemu: Add support for hot unplug redirdev device

2017-11-19 Thread Chen Hanxiao
At 2017-11-10 16:35:59, "Chen Hanxiao" wrote: >From: Chen Hanxiao > > We lacked of hot unplugging redirdev device. > This patch adds support for it. > We could use detach-device --live now. > >Signed-off-by: Chen Hanxiao ping Regards, - Chen -- libvi

[libvirt] [PATCH] hooks: Fix a wrong description

2017-11-14 Thread Chen Hanxiao
From: Chen Hanxiao In the definition of virHookQemuOpType and virHookNetworkOpType, we should use 'stopped' rather than 'shutdown'. Signed-off-by: Chen Hanxiao --- docs/hooks.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/hooks.html.in

[libvirt] [PATCH] qemu: Add support for hot unplug redirdev device

2017-11-10 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of hot unplugging redirdev device. This patch adds support for it. We could use detach-device --live now. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 111 src

[libvirt] [PATCH] virsh: domifaddr: clarify description of --full option

2017-10-16 Thread Chen Hanxiao
From: Chen Hanxiao Option --full will always display the name and MAC address of the interface. Both virsh help and virsh man page didn't mention that. Signed-off-by: Chen Hanxiao --- tools/virsh-domain-monitor.c | 2 +- tools/virsh.pod | 6 +++--- 2 files chang

Re: [libvirt] [PATCH] domain: add limit description of parameter 'size' for blockPeek and memoryPeek

2017-09-12 Thread Chen Hanxiao
At 2017-09-05 22:01:56, "Chen Hanxiao" wrote: >From: Chen Hanxiao > > We had 'size' limits for virDomainMemoryPeek > and virDomainBlockPeek by macro > REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and > REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX. > > The descr

[libvirt] [PATCH] domain: add limit description of parameter 'size' for blockPeek and memoryPeek

2017-09-05 Thread Chen Hanxiao
From: Chen Hanxiao We had 'size' limits for virDomainMemoryPeek and virDomainBlockPeek by macro REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX. The descriptions of the two functions only emphasized RPC buffer size. Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH] hostdev: display leading zeros of USB vendor/product id's in error messages

2017-08-07 Thread Chen Hanxiao
At 2017-08-03 08:40:48, "John Ferlan" wrote: > > >On 07/28/2017 04:33 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Many vendor id's and product id's have leading zeros. >> Show them in error messages. >> >>

Re: [libvirt] [PATCH] hostdev: display leading zeros of USB vendor/product id's in error messages

2017-08-02 Thread Chen Hanxiao
At 2017-07-28 16:33:17, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >Many vendor id's and product id's have leading zeros. >Show them in error messages. > >Signed-off-by: Chen Hanxiao >--- ping Regards, - Chen -- libvir-list mailing list libv

[libvirt] [PATCH] hostdev: display leading zeros of USB vendor/product id's in error messages

2017-07-28 Thread Chen Hanxiao
From: Chen Hanxiao Many vendor id's and product id's have leading zeros. Show them in error messages. Signed-off-by: Chen Hanxiao --- src/util/virhostdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostd

[libvirt] [PATCH] nodedev: fix an improper comment

2017-07-20 Thread Chen Hanxiao
From: Chen Hanxiao Actually we use virConnectNodeDeviceEventGenericCallback. Signed-off-by: Chen Hanxiao --- include/libvirt/libvirt-nodedev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-nodedev.h b/include/libvirt/libvirt-nodedev.h index

[libvirt] [PATCH] LXC: set the right var to NULL

2017-07-19 Thread Chen Hanxiao
From: Chen Hanxiao For attaching hosdev, we should set dev->data.hostdev rather than dev->data.disk Signed-off-by: Chen Hanxiao --- src/lxc/lxc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 652e9cb..6

Re: [libvirt] [PATCH] tools: make setvcpus --maximum imply --config

2017-05-28 Thread Chen Hanxiao
Hi, Should we remove this restriction(--maximum MUST be used with --config)? Regards, -Chen 在2017年05月29日 13:32,Peter Krempa 写道: On Sat, May 27, 2017 at 15:14:11 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > Currently --maximum was possible if and only if > --config w

Re: [libvirt] [PATCH] tools: make setvcpus --maximum imply --config

2017-05-28 Thread Chen Hanxiao
Hi, Should we remove this restriction(--maximum MUST be used with --config)? Regards, -Chen 在2017年05月29日 13:32,Peter Krempa 写道: On Sat, May 27, 2017 at 15:14:11 +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > Currently --maximum was possible if and only if > --config w

[libvirt] [PATCH] tools: make setvcpus --maximum imply --config

2017-05-27 Thread Chen Hanxiao
From: Chen Hanxiao Currently --maximum was possible if and only if --config was specified. This patch makes setvcpus --maximum imply --config. Signed-off-by: Chen Hanxiao --- tools/virsh-domain.c | 7 --- tools/virsh.pod | 9 + 2 files changed, 9 insertions(+), 7

Re: [libvirt] [PATCH] usb: keep leading zeros of vendor/product id in USB device

2017-05-23 Thread Chen Hanxiao
At 2017-05-19 15:17:32, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >Some vendor id or product id may have leading zeros. >We should show them. > >Signed-off-by: Chen Hanxiao ping Regards, - Chen -- libvir-list mailing list libvir-list@redhat.com https://www

[libvirt] [PATCH] usb: keep leading zeros of vendor/product id in USB device

2017-05-19 Thread Chen Hanxiao
From: Chen Hanxiao Some vendor id or product id may have leading zeros. We should show them. Signed-off-by: Chen Hanxiao --- src/util/virusb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virusb.c b/src/util/virusb.c index 8cd2f57..6359235 100644 --- a

Re: [libvirt] [ROC] migration: set cpu throttle value by workload

2017-04-26 Thread Chen Hanxiao
At 2017-04-26 19:26:53, "Chao Fan" wrote: >Hi all, > >When migrating a guest which consumes too much CPU & memory, dirty >pages amount will increase significantly, so does the migration >time, migration can not even complete, at worst. > >So I made an RFC patch in QEMU to set cpu throttle value

[libvirt] [PATCH v2] cleanup: qemu_capabilities: remove redundant error messages

2017-03-21 Thread Chen Hanxiao
From: Chen Hanxiao We reported error in caller virQEMUCapsCacheLookupByArch. So the same error messages in qemuConnectGetDomainCapabilities is useless. Signed-off-by: Chen Hanxiao --- v2: remove extra error message in qemuConnectGetDomainCapabilities instead of

Re: [libvirt] [PATCH] cleanup: qemu_capabilities: remove redundant error messages

2017-03-21 Thread Chen Hanxiao
At 2017-03-21 17:09:22, "Jiri Denemark" wrote: >On Wed, Mar 08, 2017 at 12:14:17 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> We reported error in caller qemuConnectGetDomainCapabilities. >> So the same error messages in virQEMUCapsCacheLookupByA

Re: [libvirt] [PATCH v3 0/2] Allow saving VM state to pipe

2017-03-20 Thread Chen Hanxiao
At 2017-03-14 14:26:24, "Chen Hanxiao" wrote: > >At 2017-03-09 12:22:21, "Chen Hanxiao" wrote: >>This series introduce flag VIR_DOMAIN_SAVE_DIRECT >>to enable command 'save' to write to PIPE. >>This will write QEMU_SAVE_MAGIC directly. &g

Re: [libvirt] [PATCH v3 0/2] Allow saving VM state to pipe

2017-03-13 Thread Chen Hanxiao
At 2017-03-09 12:22:21, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. >This will write QEMU_SAVE_MAGIC directly. > >Base upon patches from Roy Keene >with some fixes. > >Chang

Re: [libvirt] [PATCH] cleanup: qemu_capabilities: remove redundant error messages

2017-03-13 Thread Chen Hanxiao
At 2017-03-08 12:14:17, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >We reported error in caller qemuConnectGetDomainCapabilities. >So the same error messages in virQEMUCapsCacheLookupByArch >are useless. > >Signed-off-by: Chen Hanxiao >--- > src/qemu/

[libvirt] [PATCH v3 0/2] Allow saving VM state to pipe

2017-03-08 Thread Chen Hanxiao
3) Add doc for virsh command v3: add doc/news.xml rebase on upstream v2-resend: rebase on upstream v2: rename VIR_DOMAIN_SAVE_PIPE to VIR_DOMAIN_SAVE_DIRECT remove S_ISFIFO check Chen Hanxiao (2): qemu: Allow qemuDomainSaveMemory saving VM state to a pipe virsh: introduce flage --

[libvirt] [PATCH v3 1/2] qemu: Allow qemuDomainSaveMemory saving VM state to a pipe

2017-03-08 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this is not possible, attempting to re-open the

[libvirt] [PATCH v3 2/2] virsh: introduce flage --direct for save command

2017-03-08 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: fifo="$(mktemp -u)"; mkfi

[libvirt] [PATCH] cleanup: qemu_capabilities: remove redundant error messages

2017-03-07 Thread Chen Hanxiao
From: Chen Hanxiao We reported error in caller qemuConnectGetDomainCapabilities. So the same error messages in virQEMUCapsCacheLookupByArch are useless. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_capabilities.c | 4 1 file changed, 4 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v2.1] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-03-06 Thread Chen Hanxiao
From: Chen Hanxiao This patch introduces QEMU_CAPS_SD_CARD for probing whether qemu support SD card by: {"execute": "device-list-properties", "arguments":{"typename":"sd-card"}} It will be helpful for apps which used cmd 'virsh domca

[libvirt] [PATCH v2] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-02-23 Thread Chen Hanxiao
From: Chen Hanxiao This patch introduces QEMU_CAPS_SD_CARD for probing whether qemu support SD card by: {"execute": "device-list-properties", "arguments":{"typename":"sd-card"}} It will be helpful for apps which used cmd 'virsh domca

[libvirt] [PATCH resend v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2017-02-23 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this is not possible, attempting to re-open the

[libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-02-23 Thread Chen Hanxiao
rebase on upstream v2: rename VIR_DOMAIN_SAVE_PIPE to VIR_DOMAIN_SAVE_DIRECT remove S_ISFIFO check Chen Hanxiao (2): qemu: Allow saving QEMU libvirt state to a pipe virsh: introduce flage --direct for save command include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c

[libvirt] [PATCH resend v2 2/2] virsh: introduce flage --direct for save command

2017-02-23 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: fifo="$(mktemp -u)"; mkfi

Re: [libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-02-16 Thread Chen Hanxiao
At 2017-02-03 16:23:52, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether the spec

Re: [libvirt] [PATCH] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-02-16 Thread Chen Hanxiao
At 2017-02-13 09:53:44, "Chen Hanxiao" wrote: >At 2017-02-07 16:31:20, "Chen Hanxiao" wrote: >>From: Chen Hanxiao >> >>This patch introduces QEMU_CAPS_SD_CARD for probing >>whether qemu support SD card by: >> >>{"execute&qu

Re: [libvirt] [PATCH] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-02-12 Thread Chen Hanxiao
At 2017-02-07 16:31:20, "Chen Hanxiao" wrote: >From: Chen Hanxiao > >This patch introduces QEMU_CAPS_SD_CARD for probing >whether qemu support SD card by: > >{"execute": "device-list-properties", >"arguments":{"typename&

[libvirt] [PATCH] qemu_capabilities: introduce QEMU_CAPS_SD_CARD to probe sd-card drivers

2017-02-07 Thread Chen Hanxiao
From: Chen Hanxiao This patch introduces QEMU_CAPS_SD_CARD for probing whether qemu support SD card by: {"execute": "device-list-properties", "arguments":{"typename":"sd-card"}} It will be helpful for apps which used cmd 'virsh domca

[libvirt] [PATCH resend v2 2/2] virsh: introduce flage --direct for save command

2017-02-03 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: fifo="$(mktemp -u)"; mkfi

[libvirt] [PATCH resend v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2017-02-03 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this is not possible, attempting to re-open the

[libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-02-03 Thread Chen Hanxiao
rebase on upstream v2: rename VIR_DOMAIN_SAVE_PIPE to VIR_DOMAIN_SAVE_DIRECT remove S_ISFIFO check Chen Hanxiao (2): qemu: Allow saving QEMU libvirt state to a pipe virsh: introduce flage --direct for save command include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c

[libvirt] [PATCH] THREADS.txt: fix typos

2017-01-24 Thread Chen Hanxiao
From: Chen Hanxiao s/wakup/wakeup Signed-off-by: Chen Hanxiao --- daemon/THREADS.txt | 2 +- src/util/vireventpoll.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/THREADS.txt b/daemon/THREADS.txt index 762ca25..ae4e9ba 100644 --- a/daemon/THREADS.txt +++ b

Re: [libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-01-21 Thread Chen Hanxiao
At 2017-01-18 09:05:12, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether

[libvirt] [PATCH v2] qemu_domain: add timestamp in tainting of guests log

2017-01-20 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of timestamp in tainting of guests log, which bring troubles for finding guest issues: such as whether a guest powerdown caused by qemu-monitor-command or others issues inside guests. If we had timestamp in tainting of guests log, it would be helpful when checking

[libvirt] Mirror on Github failed to sync from libvirt.org

2017-01-19 Thread Chen Hanxiao
Dear list,     Mirror on Github:     https://github.com/libvirt/libvirt     did not sync from libvirt.org for almost a month. Regards, - Chen   -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH resend v2 2/2] virsh: introduce flage --direct for save command

2017-01-17 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: fifo="$(mktemp -u)"; mkfi

[libvirt] [PATCH resend v2 0/2] Allow saving QEMU libvirt state to a pipe

2017-01-17 Thread Chen Hanxiao
rebase on upstream v2: rename VIR_DOMAIN_SAVE_PIPE to VIR_DOMAIN_SAVE_DIRECT remove S_ISFIFO check Chen Hanxiao (2): qemu: Allow saving QEMU libvirt state to a pipe virsh: introduce flage --direct for save command include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c

[libvirt] [PATCH resend v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2017-01-17 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this is not possible, attempting to re-open the

[libvirt] [PATCH] qemu_domain: add timestamp in tainting of guests log

2017-01-16 Thread Chen Hanxiao
From: Chen Hanxiao We lacked of timestamp in tainting of guests log, which bring troubles for finding guest issues: such as whether a guest powerdown caused by qemu-monitor-command or others issues inside guests. If we had timestamp in tainting of guests log, it would be helpful when checking

Re: [libvirt] [PATCH] storage_backend_rbd: always call rados_conf_read_file when connect a rbd pool

2017-01-10 Thread Chen Hanxiao
At 2017-01-11 02:23:54, "John Ferlan" wrote: > > >On 12/30/2016 03:39 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This patch fix a dead lock when try to read a rbd image >> >> When trying to connect a rbd server >> (ceph-0.94.7

[libvirt] [PATCH] virsh: fix a typo

2017-01-07 Thread Chen Hanxiao
From: Chen Hanxiao s/rather then/rather than Signed-off-by: Chen Hanxiao --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ef91223..e5c94e7 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1673,7 +1673,7

[libvirt] [PATCH v2 0/3] virsh: pool-list: introduce option --name and --uuid

2017-01-06 Thread Chen Hanxiao
list` Chen Hanxiao (3): virsh: pool-list: introduce --uuid for printing pool's UUID only virsh: pool-list: introduce --name for printing pool's name only virsh: pool-list: allow both --uuid and --name in one cmd tools/virsh-pool.c | 48

[libvirt] [PATCH v2 3/3] virsh: pool-list: allow both --uuid and --name in one cmd

2017-01-06 Thread Chen Hanxiao
From: Chen Hanxiao This patch will allow --uuid and --name in one cmd. The pool's UUID and name will be printed side by side. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 8 +++- tools/virsh.pod| 5 - 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/

[libvirt] [PATCH v2 2/3] virsh: pool-list: introduce --name for printing pool's name only

2017-01-06 Thread Chen Hanxiao
From: Chen Hanxiao This patch will introduce option --name. If specified, only name of pools will be printed out. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 22 -- tools/virsh.pod| 4 +++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/tools

[libvirt] [PATCH v2 1/3] virsh: pool-list: introduce --uuid for printing pool's UUID only

2017-01-06 Thread Chen Hanxiao
From: Chen Hanxiao This patch will introduce option --uuid. If specified, only UUID of pools will be printed out. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 20 tools/virsh.pod| 4 ++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/tools

Re: [libvirt] [PATCH] virsh: pool-list: introduce --uuid

2017-01-05 Thread Chen Hanxiao
At 2017-01-05 17:18:14, "Erik Skultety" wrote: >On Thu, Jan 05, 2017 at 11:56:21AM +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This patch will introduce option [--uuid]. >> If specified, UUID of pools will be printed out. &g

[libvirt] [PATCH] virsh: pool-list: introduce --uuid

2017-01-04 Thread Chen Hanxiao
From: Chen Hanxiao This patch will introduce option [--uuid]. If specified, UUID of pools will be printed out. virsh # pool-list --all Name State Autostart --- default active yes root active yes

[libvirt] [PATCH] virsh: pool-info: introduce option --bytes

2017-01-03 Thread Chen Hanxiao
From: Chen Hanxiao By default, pool-info will convert sizes to human friendly units. This patch will introduce option [--bytes]. If specified, the raw sizes will be in the output. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 25 +++-- tools/virsh.pod| 5

[libvirt] [PATCH] storage_backend_rbd: always call rados_conf_read_file when connect a rbd pool

2016-12-30 Thread Chen Hanxiao
From: Chen Hanxiao This patch fix a dead lock when try to read a rbd image When trying to connect a rbd server (ceph-0.94.7-1.el7.centos.x86_64), rbd_list/rbd_open enter a dead lock state. Backtrace: Thread 30 (Thread 0x7fdb342d0700 (LWP 12105)): #0 0x7fdb40b16705 in pthread_cond_wait

Re: [libvirt] [PATCH v2 0/2] Allow saving QEMU libvirt state to a pipe

2016-12-20 Thread Chen Hanxiao
At 2016-12-15 11:15:13, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_DIRECT >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether

Re: [libvirt] About libvirt on Windows-64bit

2016-12-16 Thread Chen Hanxiao
At 2016-12-16 15:28:34, "孙长鹏(外网)" wrote: Hi,   I wanted to use libvirt to connect to KVM in Windows-64bit,but I was failed。In fact,when I tryed that in Windows-32bit,it can be right。   Please teach me,how can I make it right in Windows-64bit?After all, the Windows-32bit is outdated。   T

[libvirt] [PATCH v2 2/2] virsh: introduce flage --direct for save command

2016-12-14 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: fifo="$(mktemp -u)"; mkfi

[libvirt] [PATCH v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2016-12-14 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this is not possible, attempting to re-open the

[libvirt] [PATCH v2 0/2] Allow saving QEMU libvirt state to a pipe

2016-12-14 Thread Chen Hanxiao
: rename VIR_DOMAIN_SAVE_PIPE to VIR_DOMAIN_SAVE_DIRECT remove S_ISFIFO check Chen Hanxiao (2): qemu: Allow saving QEMU libvirt state to a pipe virsh: introduce flage --direct for save command include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2016-12-08 Thread Chen Hanxiao
At 2016-12-08 20:08:11, "Peter Krempa" wrote: >On Sat, Dec 03, 2016 at 17:45:47 +0800, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Base upon patches from Roy Keene >> >> Currently qemuDomainSaveMemory can save vm's config >> an

Re: [libvirt] [PATCH 0/2] Allow saving QEMU libvirt state to a pipe

2016-12-08 Thread Chen Hanxiao
At 2016-12-03 17:45:46, "Chen Hanxiao" wrote: >This series introduce flag VIR_DOMAIN_SAVE_PIPE >to enable command 'save' to write to PIPE. > >Base upon patches from Roy Keene >with some fixes. > >Change from original patch: >1) Check whether the spec

[libvirt] [PATCH 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2016-12-03 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It writes a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC after a success write. For pipes this is not pos

[libvirt] [PATCH 2/2] virsh: introduce flage --pipe for save command

2016-12-03 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --pipe flag for save command. We could saving a VM state directly to Ceph RBD images without having an intermediate file. How to test: # fifo="$(mktemp -u)"; mkfifo "${fifo}" && virsh

<    1   2   3   4   5   6   >