Re: [libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13

On Thu, Apr 21, 2016 at 07:26:07AM -0400, Neal Gompa wrote: > Actually, I just realized that you need to also correct src/config.m4 > as well, since that one still says the minimum version is 1.2.8. Ah thanks, I grepped for 1.2.9 to see if I missed any version elsewhere, did not think there could

Re: [libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13

On Thu, Apr 21, 2016 at 02:38:16PM +0300, Vasiliy Tolstov wrote: > Why not add ifdef? I'm OK with this,but may be good think to not break > build because of small changes like this. I don't have a 1.2.9 installation handy, so that's the best I can do quickly ;) Christophe signature.asc

Re: [libvirt] [libvirt-glib/libvirt-gconfig 10/17] gconfig: Add GVirCofigDomainGraphicsRemote class

On Tue, Mar 22, 2016 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > Seems that GVirConfigDomainGraphics* were built with a strong focus on > writing/setting configs, but not reading those. > > For instance, considering virt-viewer's case, where the app is just > consuming an already built xml,

Re: [libvirt] [libvirt-glib/libvirt-gconfig 17/17] gconfig, graphics: Avoid crash when gvir_config_object_new_from_xml() returns NULL

This issues is more widespread than that, it would be better to fix it everywhere in one go (maybe through a gvir_config_object_check_type() or something like this?) Christophe On Tue, Mar 22, 2016 at 11:04:53AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio

Re: [libvirt] [libvirt-glib/libvirt-gconfig 16/17] gconfig: Adapt GVirConfigDomainGraphicsDesktop to GVirConfigDomainGraphicsLocal

Acked-by: Christophe Fergeau <cferg...@redhat.com> Looks good to me. Christophe On Tue, Mar 22, 2016 at 11:04:52AM +0100, Fabiano Fidêncio wrote: > This patch adapts GVirConfigDomainGraphicsDesktop to the new > GVirConfigDomainGraphicsLocal, inheriting from it and using its helper

Re: [libvirt] [libvirt-glib/libvirt-gconfig 14/17] gconfig: Add GVirCofigDomainGraphicsLocal class

On Tue, Mar 22, 2016 at 11:04:50AM +0100, Fabiano Fidêncio wrote: > Adding this class more fore completness to the > GVirConfigDomainGraphicsRemote than for any other reason. > > This patch introduces a new hierarchy in the project, where, instead of > having GVirConfigDomainGraphics{Desktop,Sdl}

Re: [libvirt] [libvirt-glib/libvirt-gconfig 11/17] gconfig: Adapt GVirConfigDomainGraphicsSpice to GVirConfigDomainGraphicsRemote

On Thu, Apr 21, 2016 at 12:51:48PM +0200, Christophe Fergeau wrote: > On Tue, Mar 22, 2016 at 11:04:47AM +0100, Fabiano Fidêncio wrote: > > This patch adapts GVirConfigDomainGraphicsSpice to the new > > GVirConfigDomainGraphicsRemote, inheriting from it and using its helpe

Re: [libvirt] [libvirt-glib/libvirt-gconfig 13/17] gconfig: Adapt GVirConfigDomainGraphicsVnc to GVirConfigDomainGraphicsRemote

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Tue, Mar 22, 2016 at 11:04:49AM +0100, Fabiano Fidêncio wrote: > This patch adapts GVirConfigDomainGraphicsVnc to the new > GVirConfigDomainGraphicsRemote, inheriting from it and using its helper > functions for getting

Re: [libvirt] [libvirt-glib/libvirt-gconfig 11/17] gconfig: Adapt GVirConfigDomainGraphicsSpice to GVirConfigDomainGraphicsRemote

igDomainGraphicsSpice. Acked-by: Christophe Fergeau <cferg...@redhat.com> > > Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 11 --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-sp

Re: [libvirt] [libvirt-glib/libvirt-gconfig 12/17] gconfig: Adapt GVirConfigDomainGraphicsRdp to GVirConfigDomainGraphicsRemote

GraphicsRdp now inherits from > GVirConfigDomainGraphicsRemote, this patch also introduces an ABI > breakage. Acked-by: Christophe Fergeau <cferg...@redhat.com> This can be squashed into the SPICE one imo (and same for the other classes). Christophe > > Signed-off-by: Fabi

Re: [libvirt] [libvirt-glib/libvirt-gconfig 10/17] gconfig: Add GVirCofigDomainGraphicsRemote class

Hey, 'GVirCofigDomainGraphicsRemote' typo in the subject On Tue, Mar 22, 2016 at 11:04:46AM +0100, Fabiano Fidêncio wrote: > Seems that GVirConfigDomainGraphics* were built with a strong focus on > writing/setting configs, but not reading those. > > For instance, considering virt-viewer's case,

Re: [libvirt] [libvirt-glib/libvirt-gconfig 07/17] gconfig: Implement gvir_config_domain_graphics_spice_{get, set}_host()

On Tue, Mar 22, 2016 at 11:04:43AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .../libvirt-gconfig-domain-graphics-spice.c| 18 > ++ > .../libvirt-gconfig-domain-graphics-spice.h| 4 >

[libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13

libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 ---

Re: [libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

For patches up to this one: Acked-by: Christophe Fergeau <cferg...@redhat.com> You could have added a few more tests like this: diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index be55ef9..d78292c 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -466,6 +

Re: [libvirt] Release of libvirt-php-0.5.2

On Wed, Apr 20, 2016 at 02:17:51PM -0400, Neal Gompa wrote: > On Wed, Apr 20, 2016 at 12:27 PM, Michal Privoznik > wrote: > > After 5 months of development I'm more than proud to announce that > > libvirt-php-0.5.2 is out!It can be downloaded from > > > >

Re: [libvirt] [libvirt-php][PATCH 2/3] Fix some leaks related to get_string_from_xpath

On Tue, Apr 19, 2016 at 04:59:58PM +0200, Michal Privoznik wrote: > On 19.04.2016 16:09, Christophe Fergeau wrote: > > On Tue, Apr 19, 2016 at 03:46:41PM +0200, Michal Privoznik wrote: > >> This function not only did not free return value of > >> xmlNodeListGetString(

Re: [libvirt] [libvirt-php][PATCH 2/3] Fix some leaks related to get_string_from_xpath

On Tue, Apr 19, 2016 at 03:46:41PM +0200, Michal Privoznik wrote: > This function not only did not free return value of > xmlNodeListGetString() it strdup()-ed its return value. Therefore > plenty of memory has been lost definitely upon return from this > function. > > Signed-off-by: Michal

[libvirt] [libvirt-glib v2] spec: Add verification of the tarball GPG signature

This at least allows to make sure that all tarballs are signed with the same GPG key, and that the tarball was not corrupted between the time it was uploaded upstream, and the time the RPM is built. danpb-BE86EBB415104FDF.gpg is generated with: gpg2 -v --armor --export 15104FDF | gpg2

Re: [libvirt] [libvirt-glib] spec: Add verification of the tarball GPG signature

Hi, On Thu, Apr 14, 2016 at 10:01:27AM -0400, Cole Robinson wrote: > On 04/14/2016 05:12 AM, Christophe Fergeau wrote: > > This at least allows to make sure that all tarballs are signed with the > > same GPG key, and that the tarball was not corrupted between the time it > >

[libvirt] [libvirt-glib] spec: Add verification of the tarball GPG signature

This at least allows to make sure that all tarballs are signed with the same GPG key, and that the tarball was not corrupted between the time it was uploaded upstream, and the time the RPM is built. danpb-BE86EBB415104FDF.gpg is generated with: gpg2 -v --armor --export 15104FDF | gpg2

Re: [libvirt] [PATCH] storage/rbd: Use correct printf-modifier for uint64

Ping? On Mon, Mar 14, 2016 at 11:41:05AM +0100, Christophe Fergeau wrote: > %zu is for size_t variables, not uint64 ones. This causes a warning when > building on > a 32 bit linux. > --- > src/storage/storage_backend_rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [libvirt] [PATCH v3 2/2] qemu: Add support to QXL's max_outputs parameter

,max_outputs=7,\ > +bus=pci.0,addr=0x5 \ > +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 > diff --git a/tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml > b/tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml > new file mode 100644 > index 000

[libvirt] [PATCH] test: Fix typo in testutils.h header guard

This changes __VIT_TEST_UTILS_H__ to __VIR_TEST_UTILS_H__ --- tests/testutils.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/testutils.h b/tests/testutils.h index 752fa52..058be55 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -20,8 +20,8 @@ * Karel

Re: [libvirt] [PATCH 1/2] qemu: Support SPICE listen over unix socket

Hey, On Tue, Mar 22, 2016 at 09:13:44AM +0100, Pavel Hrdina wrote: > On Mon, Mar 21, 2016 at 07:30:44PM -0400, Cole Robinson wrote: > > Add support for SPICE listen over unix socket. This has been in qemu > > since v2.3. The XML is: > > > > > > > > Which matches support for VNC listen over

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

On Fri, Mar 18, 2016 at 11:09:25AM +0100, Christophe Fergeau wrote: > On Fri, Mar 18, 2016 at 10:25:58AM +0100, Ján Tomko wrote: > > This breaks make syntax-check: > > > > Curly brackets around single-line body: > > src/qemu/qemu_command.c:7559-7561: > > i

[libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

The end goal is to avoid adding -spice port=0,addr=127.0.0.1 to QEMU command line when no SPICE port is specified in libvirt XML. Currently, the code relies on port=xx to always be present, so subsequent args can be unconditionally appended with a leading ','. Since port=0 will no longer be added

[libvirt] [PATCH v2 2/3] qemu: Omit SPICE address if no port is specified

Currently -spice addr=127.0.0.1 is generated, but spice-server is going to ignore this as no port is specified. --- src/qemu/qemu_command.c| 60 +++--- .../qemuxml2argv-controller-order.args | 2 +- 2 files changed, 32 insertions(+), 30

[libvirt] [PATCH v2 0/3] Cosmetic changes to SPICE QEMU commandline

Hey, This is a v2 of the series I previously sent. Changes since v1: - much nicer cmdline generation in patch 1/3 - improved commit log in 1/3 - moved part of patch 1/3 to 3/3 - added test case in 3/3 Christophe -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v2 3/3] qemu: Don't add -spice port=0 when no port is specified

If a has no port nor tlsPort set, the generated QEMU command line will contain -spice port=0. This is later going to be ignored by spice-server, but it's better not to add it at all in this situation. As an empty -spice is not allowed, we still need to append port=0 if we did not add any other

Re: [libvirt] [PATCH v2 3/3] qemu: Don't add -spice port=0 when no port is specified

On Fri, Mar 18, 2016 at 10:28:10AM +0100, Ján Tomko wrote: > > @@ -7234,7 +7234,14 @@ > > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > > virBufferTrim(, ",", -1); > > > > virCommandAddArg(cmd, "-spice"); > > -virCommandAddArgBuffer(cmd, ); > > +/* If we did

Re: [libvirt] [PATCH] rpc: wait longer for session daemon to start up

On Tue, Mar 15, 2016 at 05:10:48PM -0400, Cole Robinson wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1271183 > > We only wait .5 seconds for the session daemon to start up and present If this is not pushed already, I think 0.5 seconds would be easier to read and not confuse with the "5

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

On Fri, Mar 18, 2016 at 10:25:58AM +0100, Ján Tomko wrote: > > -if (graphics->data.spice.playback) > > -virBufferAsprintf(, ",playback-compression=%s", > > +} > > +if (graphics->data.spice.playback) { > > +virBufferAsprintf(, "playback-compression=%s,", > >

Re: [libvirt] [PATCH 1/3] qemu: Make all SPICE command-line args optional

Hey, On Tue, Mar 15, 2016 at 12:16:10PM +0100, Ján Tomko wrote: > On Tue, Mar 15, 2016 at 10:20:48AM +0100, Christophe Fergeau wrote: > > The goal is to not add -spice port=0,addr=127.0.0.1 to QEMU command line > > when no SPICE port is specified in libvirt XML. > > M

[libvirt] [PATCH 1/3] qemu: Make all SPICE command-line args optional

The goal is to not add -spice port=0,addr=127.0.0.1 to QEMU command line when no SPICE port is specified in libvirt XML. Before this change, we could rely on port or tlsPort to always be present, so subsequent args could be unconditionally appended with a leading ','. Now that it's no longer the

[libvirt] [PATCH 3/3] qemu: Don't add -spice port=0 when no port is specified

If a has no port nor tlsPort set, the generated QEMU command line will contain -spice port=0. This is later going to be ignored by spice-server, but it's better not to add it at all in this situation. --- src/qemu/qemu_command.c| 2 +-

[libvirt] [PATCH 0/3] Cosmetic changes to SPICE QEMU commandline

Hey, I've been trying out the recently adding virgl support, which does not need any TCP port/address to be set (it's directly opening a local unix fd). While looking at QEMU command line in configs such as , I've noticed that the QEMU command line gets some 'useless' arguments such as -spice

[libvirt] [PATCH 2/3] qemu: Omit SPICE address if no port is specified

Currently -spice addr=127.0.0.1 is generated, but spice-server is going to ignore this as no port is specified. --- This one is more readable with git show -w, it's just if (port > 0 || tlsPort > 0) { } Christophe src/qemu/qemu_command.c| 65

Re: [libvirt] [PATCH 0/2] qemu: Support for QXL heads

On Thu, Mar 10, 2016 at 03:52:54PM +0100, Martin Kletzander wrote: > I'm not sure how to handle this, but I was under the impression that > this can be changed on the fly. If libvirt doesn't support that, then > we should enable it. From the spice side, this seems to be changeable on the fly.

[libvirt] [PATCH] storage/rbd: Use correct printf-modifier for uint64

%zu is for size_t variables, not uint64 ones. This causes a warning when building on a 32 bit linux. --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index

Re: [libvirt] [PATCH] qemuBuildVideoCommandLine: Don't access def->videos without check

> > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > > --- > > src/qemu/qemu_command.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > ACK Ah, thanks, I was hitting that while doing unrelated stuff :) Fwiw, Tested-by: Christophe Fergeau <cferg..

Re: [libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

On Fri, Mar 11, 2016 at 03:03:03PM +, Zeeshan Ali (Khattak) wrote: > On Fri, Mar 11, 2016 at 9:21 AM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > On Thu, Mar 10, 2016 at 05:08:33PM +, Zeeshan Ali (Khattak) wrote: > >> Hi, > >> > >>

[libvirt] [libvirt-glib v3 5/5] Add test for GVirConfigDomainHostdevPci API

From: "Zeeshan Ali (Khattak)" --- tests/test-gconfig.c| 42 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 53 insertions(+) create mode 100644

[libvirt] [libvirt-glib v3 4/5] gconfig: Add GVirConfigDomainAddressPci getters

They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++ libvirt-gconfig/libvirt-gconfig.sym| 6 +++ 3 files

[libvirt] [libvirt-glib v3 3/5] Add GVirConfigDomainHostdevPci

* Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + *

[libvirt] [libvirt-glib v3 2/5] Add GVirConfigDomainHostdev

OSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + *

[libvirt] [libvirt-glib v3 1/5] gconfig: Add gvir_config_object_has_child

--- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-private.h index

Re: [libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

On Thu, Mar 10, 2016 at 05:08:33PM +, Zeeshan Ali (Khattak) wrote: > Hi, > > I'm a bit confused, this patch doesn't seem to add anything to mine. > Did you forget to commit? As indicated in the cover letter « This series contains this new code. The changes I made to Zeeshan's initial

Re: [libvirt] [PATCH 0/2] qemu: Support for QXL heads

Hey, On Thu, Mar 10, 2016 at 03:20:59PM +0100, Martin Kletzander wrote: > So this is an old, tiny series that was posted some time ago; actually > a lot of time ago. I complained because of two things. First one > being that there are no tests, so this series has them in. The second > one was

Re: [libvirt] [libvirt-glib] gconfig: Fix next API version number

On Fri, Mar 04, 2016 at 02:54:20PM +0100, Fabiano Fidêncio wrote: > Commit 01e01f2 introduced a wrong next API version number in > libvirt-gconfig.sym libvirt-glib 0.2.3 was released in december, I believe we try to align API versioning with tarball versions, in which case 0.2.4 is correct here.

[libvirt] Wiki account

Hey, I thought I already had a wiki account, but after a few failures to login or retrieve a password, it seems I don't, so I would like to get one for username 'teuf' Thanks, Christophe signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics

Hey, On Mon, Feb 29, 2016 at 11:51:26PM +0100, Fabiano Fidêncio wrote: > Howdy! > > I've been trying to use libvirt-gobject and libvirt-gconfig, on > virt-viewer, for accessing VMs and looking at their config, instead of > using libvrit and parsing XML directly and turns out, that >

Re: [libvirt] [PATCH libvirt-glib 5/5] config: add accel3d setter

On Fri, Feb 26, 2016 at 12:37:12PM +0100, Marc-André Lureau wrote: > Learn to set the accel3d attribute on video model. > > Signed-off-by: Marc-André Lureau > --- > examples/config-demo.py| 1 + > diff --git a/examples/config-demo.py

Re: [libvirt] [libvirt-glib 1/3] Add GVirConfigDomainHostdev

On Mon, Feb 08, 2016 at 04:22:47PM +, Zeeshan Ali (Khattak) wrote: > Hi, > > On Fri, Jan 29, 2016 at 5:18 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Hey, > > > > A gconfig: prefix in the commit shortlog would be nice > > Hmm..

Re: [libvirt] [libvirt-glib 2/3] Add GVirConfigDomainHostdevPci

On Mon, Feb 08, 2016 at 04:58:34PM +, Zeeshan Ali (Khattak) wrote: > Hi, > > >> + */ > >> +GVirConfigDomainHostdevPci *gvir_config_domain_hostdev_pci_new(void) > >> +{ > >> +GVirConfigObject *object; > >> + > >> +object = gvir_config_object_new(GVIR_CONFIG_TYPE_DOMAIN_HOSTDEV_PCI, >

[libvirt] [libvirt-glib v2 2/9] Add GVirConfigDomainHostdev

OSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + *

[libvirt] [libvirt-glib v2 4/9] Add GVirConfigDomainHostdevPci

* Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + *

[libvirt] [libvirt-glib v2 1/9] gconfig: Add gvir_config_object_has_child

--- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-private.h index

Re: [libvirt] [libvirt-glib 2/3] Add GVirConfigDomainHostdevPci

ense for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library. If not, see > + * <http://www.gnu.org/licenses/>. > + * > + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> > + *

[libvirt] [libvirt-glib v2 7/9] gconfig: Add GVirConfigDomainAddressPci getters

They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++ libvirt-gconfig/libvirt-gconfig.sym| 6 +++ 3 files

Re: [libvirt] [libvirt-glib 1/3] Add GVirConfigDomainHostdev

received a copy of the GNU Lesser General Public > + * License along with this library. If not, see > + * <http://www.gnu.org/licenses/>. > + * > + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> > + * Christophe Fergeau <cferg...@redhat.com> &g

[libvirt] [libvirt-glib v2 0/9] gconfig: Add hostdev support

Hey, While reviewing Zeeshan's libvirt-gconfig hostdev series, I fixed up a few things, and added a few additional helpers/getters in order to simplify the code/make the test case more complete. This series contains this new code. The changes I made to Zeeshan's initial patches are in separate

[libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

From: "Zeeshan Ali (Khattak)" --- tests/test-gconfig.c| 30 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 + 2 files changed, 41 insertions(+) create mode 100644

[libvirt] [libvirt-glib v2 3/9] fixup! Add GVirConfigDomainHostdev

--- libvirt-gconfig/libvirt-gconfig-domain-hostdev.c | 62 ++-- 1 file changed, 14 insertions(+), 48 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-hostdev.c b/libvirt-gconfig/libvirt-gconfig-domain-hostdev.c index 42eb184..d115dbb 100644 ---

[libvirt] [libvirt-glib v2 9/9] fixup! Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index c3711f1..a2f294f 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -714,13 +714,17 @@ static void test_domain_device_pci_hostdev(void)

[libvirt] [libvirt-glib v2 5/9] fixup! Add GVirConfigDomainHostdevPci

--- libvirt-gconfig/libvirt-gconfig-domain-hostdev-pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-hostdev-pci.c b/libvirt-gconfig/libvirt-gconfig-domain-hostdev-pci.c index ed1d146..ce31056 100644 ---

Re: [libvirt] [libvirt-glib 3/3] Add test for GVirConfigDomainHostdevPci API

ACK, though I have some additions to this test to exercise the getters as well. Christophe On Thu, Jan 28, 2016 at 04:32:14PM +0100, Zeeshan Ali (Khattak) wrote: > --- > tests/test-gconfig.c| 30 > + >

[libvirt] [libvirt-glib v2 6/9] fixup! Add GVirConfigDomainHostdevPci

--- .../libvirt-gconfig-domain-hostdev-pci.c | 44 ++ 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-hostdev-pci.c b/libvirt-gconfig/libvirt-gconfig-domain-hostdev-pci.c index ce31056..29ba263 100644 ---

[libvirt] [libvirt-glib] events: Mark 'eventlock' as static

It's not used outside of the libvirt-glib-event.c file, so there is no good reason for not having it static. As it was not listed in libvirt-glib.sym, this will make no change to the publicly exported symbols (ie this is not an ABI change). --- libvirt-glib/libvirt-glib-event.c | 2 +- 1 file

Re: [libvirt] [libvirt-glib][PATCH] libvirt-glib-1.0.pc.in: Correctly mark variable

Hey, On Sun, Jan 03, 2016 at 12:49:30PM +0100, Martin Kletzander wrote: > On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote: > >In the pkg-config file for libvirt-glib we have a typo: > > > > Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@ > > > >Noticed the missing '@' after

Re: [libvirt] [libvirt-glib][PATCH] gobject: Drop some unused variables

On Sat, Dec 05, 2015 at 10:10:47AM +0100, Michal Privoznik wrote: > After abe983ddf8a569 there are some variables, that are unused: > > CC libvirt_gobject_1_0_la-libvirt-gobject-domain-disk.lo > CC libvirt_gobject_1_0_la-libvirt-gobject-domain-interface.lo > CC

Re: [libvirt] [libvirt-glib][PATCH] Drop unused finalize function

Thanks for the follow-up, ACK. Christophe On Mon, Dec 07, 2015 at 12:48:13PM +0100, Michal Privoznik wrote: > After 1225a160ac3b4 where I'm dropping some unused variables, the > functions I was touching became sort of redundant too. > Specifically, gvir_domain_disk_finalize() and >

Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

Hey, Still a couple of comments :( On Wed, Nov 25, 2015 at 09:46:58PM +, Zeeshan Ali (Khattak) wrote: > diff --git a/libvirt-gobject/libvirt-gobject-input-stream.c > b/libvirt-gobject/libvirt-gobject-input-stream.c > index ff1a70c..8ef60d6 100644 > ---

Re: [libvirt] [libvirt-glib v4] gobject: Port to GTask API

Hey, On Tue, Nov 24, 2015 at 04:23:12PM +, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- > libvirt-gobject/libvirt-gobject-domain.c| 290 > +--- > libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ >

Re: [libvirt] [libvirt-glib v3] gobject: Port to GTask API

On Mon, Nov 23, 2015 at 10:50:48PM +, Zeeshan Ali (Khattak) wrote: > On Mon, Nov 23, 2015 at 10:45 PM, Zeeshan Ali (Khattak) > wrote: > > Drop usage of deprecated GSimpleAsyncResult API. > > --- > > Sorry, forgot to pass --annotate option to git-send-email. > > v3 just

Re: [libvirt] [libvirt-glib 3/3] gobject: Port to GTask API

On Fri, Nov 20, 2015 at 03:57:08PM -0500, Zeeshan Ali (Khattak) wrote: > >> diff --git a/libvirt-gobject/libvirt-gobject-stream.c > >> b/libvirt-gobject/libvirt-gobject-stream.c > >> index 46dbd9a..f8a1a8c 100644 > >> --- a/libvirt-gobject/libvirt-gobject-stream.c > >> +++

Re: [libvirt] [libvirt-glib v2 1/3] gobject: Drop redundant glib compatibility code

ACK. On Fri, Nov 20, 2015 at 09:06:28PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib older than that. > --- > libvirt-gobject/libvirt-gobject-compat.c | 87 >

Re: [libvirt] [v3] gobject: Add wrapper virDomainSetTime()

On Fri, Nov 20, 2015 at 03:27:22PM +, Zeeshan Ali (Khattak) wrote: > --- > libvirt-gobject/libvirt-gobject-domain.c | 134 > +++ > libvirt-gobject/libvirt-gobject-domain.h | 15 +++- > libvirt-gobject/libvirt-gobject.sym | 9 +++ > 3 files changed, 157

Re: [libvirt] [libvirt-glib 2/3] gconfig: Drop redundant glib compatibility code

I don't know why this one is 2/3, I would squash it with the other similar gobject patch. ACK. Christophe On Fri, Nov 20, 2015 at 09:05:23PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib

Re: [libvirt] [libvirt-glib v2 3/3] gobject: Port to GTask API

On Fri, Nov 20, 2015 at 09:06:30PM +, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- A Changes since v1 section would be nice as this patch is a bit big. > > +typedef struct { > +guint flags; > +} DomainWakeupData; > + > +static void

Re: [libvirt] [PATCH v2] gobject: Add wrapper virDomainSetTime()

On Fri, Nov 13, 2015 at 02:13:35PM -0500, Zeeshan Ali (Khattak) wrote: > Hi, > > >> +guint settime_flags; > >> + > >> +g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE); > >> +g_return_val_if_fail(err == NULL || *err == NULL, FALSE); > > > > I'd keep a g_return_val_if_fail(flags == 0,

Re: [libvirt] [PATCH v2] gobject: Add wrapper virDomainSetTime()

Some minor comments below, ACK. Christophe On Thu, Oct 29, 2015 at 08:44:17PM +, Zeeshan Ali (Khattak) wrote: > --- > > This version: > > * Replaces the seconds and nseconds arguments by a GDateTime. > * Drops the use of flags argument, since caller can specify the only flag > currently

Re: [libvirt] [libvirt-glib 2/3] gconfig: Drop redundant glib compatibility code

On Thu, Oct 29, 2015 at 08:39:07PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib oler than that. Same 'older' typo, ACK. Christophe > --- > libvirt-gconfig/libvirt-gconfig-compat.h |

Re: [libvirt] [libvirt-glib 1/3] gobject: Drop redundant glib compatibility code

On Thu, Oct 29, 2015 at 08:39:06PM +, Zeeshan Ali (Khattak) wrote: > We already require and use glib >= 2.36 so there is no reason to keep > around code to ensure compatibility with glib oler than that. 'older'. Nice catch/cleanup, thanks! Christophe signature.asc Description: PGP

Re: [libvirt] [libvirt-glib 3/3] gobject: Port to GTask API

On Thu, Oct 29, 2015 at 08:39:08PM +, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- > libvirt-gobject/libvirt-gobject-domain.c| 270 ++- > libvirt-gobject/libvirt-gobject-input-stream.c | 76 +++ >

Re: [libvirt] [libvirt-glib] gobject: Add wrapper virDomainSetTime()

Hey, On Tue, Oct 27, 2015 at 06:17:58PM +, Zeeshan Ali (Khattak) wrote: > --- > libvirt-gobject/libvirt-gobject-domain.c | 126 > +++ > libvirt-gobject/libvirt-gobject-domain.h | 25 ++ > libvirt-gobject/libvirt-gobject.sym | 9 +++ > 3 files changed,

Re: [libvirt] [libvirt-glib] gobject: Add wrapper virDomainSetTime()

On Wed, Oct 28, 2015 at 01:25:42PM +, Zeeshan Ali (Khattak) wrote: > > > > (flags & GVIR_DOMAIN_TIME_SYNC) != 0 to be consistent with the 'flags == > > 0' before. However, shouldn't it be flags & GVIR_DOMAIN_TIME_SYNC == > > GVIR_DOMAIN_TIME_SYNC to be sure we were not passed unknown flags? >

[libvirt] [libvirt-glib] events: Mark 'eventlock' as static

It's not used outside of the libvirt-glib-event.c file, so there is no good reason for not having it static. As it was not listed in libvirt-glib.sym, this will make no change to the publicly exported symbols (ie this is not an ABI change). --- libvirt-glib/libvirt-glib-event.c | 2 +- 1 file

Re: [libvirt] [PATCH glib 1/2] README: formally document intended platform support targets

On Fri, Jul 24, 2015 at 10:57:49AM +0100, Daniel P. Berrange wrote: On Thu, Jul 23, 2015 at 09:57:59AM +0200, Christophe Fergeau wrote: On Wed, Jul 22, 2015 at 03:14:22PM +0100, Daniel P. Berrange wrote: +As an example, as of July 1st 2015, this policy would aim to pick the +min versions

Re: [libvirt] [PATCH glib 2/2] configure.ac: update min required versions

On Wed, Jul 22, 2015 at 03:14:23PM +0100, Daniel P. Berrange wrote: Based on the distro target policy we have the following min versions in various distros libvirt glib2gobject-introspection RHEL 7.0: 1.1.12.36.3 1.36.0 Fedora 21: 1.2.9

Re: [libvirt] [PATCH glib 1/2] README: formally document intended platform support targets

Hey, On Wed, Jul 22, 2015 at 03:14:22PM +0100, Daniel P. Berrange wrote: Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is appropriate to increase the minimum required versions of external dependancies.

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

Hey, On Fri, Jul 17, 2015 at 09:01:46AM +0200, Christophe Fergeau wrote: On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau wrote: Hey, This patch series makes tests/test-gconfig valgrind-clean, and refactors two setters in GVirConfigDomainVideo to make them use the helpers

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

On Wed, Jul 22, 2015 at 01:27:45PM +0100, Zeeshan Ali (Khattak) wrote: On Wed, Jul 22, 2015 at 11:41 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Fri, Jul 17, 2015 at 09:01:46AM +0200, Christophe Fergeau wrote: On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau

[libvirt] [libvirt-glib] examples: Don't leak mainloop in conn-test.c

The program exits right after this, so it's no big deal, but this gives us a clean valgrind --leak-check=full output. --- examples/conn-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/conn-test.c b/examples/conn-test.c index adc6434..ac5880a 100644 ---

Re: [libvirt] [libvirt-glib] examples: Don't leak mainloop in conn-test.c

On Wed, Jul 22, 2015 at 02:56:53PM +0200, Christophe Fergeau wrote: The program exits right after this, so it's no big deal, but this gives us a clean valgrind --leak-check=full output. Ah, messed up my push of the 4 patches which were ACK'ed earlier, and pushed that one too :( Christophe

Re: [libvirt] [PATCH glib] Remove dep on libvirt 1.2.6

On Tue, Jul 21, 2015 at 03:20:02PM +0100, Daniel P. Berrange wrote: Going back on what I said a few hours ago On closer inspection, I re-discovered that we have already taken the approach of conditionally compiling code in libvirt-gobject to avoid increasing the min libvirt. So given

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

Hi, On Tue, Jul 21, 2015 at 03:20:03PM +0100, Daniel P. Berrange wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than requiring

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

Hi, On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: In the meantime, is the only thing this does limiting the maximum? Is it there just to save some memory or why? Because otherwise I can't see the use-case in that. I'm not saying there isn't one, just that I can't find

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally managed to make this work and found out the guest I used for it is not ready to have multiple monitors. Anyway, looking at everything

Re: [libvirt] [PATCH] qxl: Fix new function name for spice-server library

On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote: The new spice-server function to limit the number of monitors (0.12.6) changed while development from spice_qxl_set_monitors_config_limit to spice_qxl_max_monitors (accepted upstream). By mistake I post patch with former name.

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Mon, Jul 20, 2015 at 05:24:30PM +0100, Zeeshan Ali (Khattak) wrote: And all that data is completely irrelevant for the reason I mentioned again and again. Now that we have the data, and that it goes your way, yes you can say it's irrelevant ;) What if instead, it turned out only f22 was

<    1   2   3   4   5   6   7   8   9   10   >