ACK series and pushed.
Christophe
On Thu, Jul 09, 2015 at 03:13:46PM +0530, T A Mahadevan wrote:
This is needed to be able to add UNIX channels
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-chardev-source-unix.c | 84
++
On Fri, Jul 17, 2015 at 10:31:11AM +0200, Martin Kletzander wrote:
On Fri, Jul 17, 2015 at 10:12:44AM +0200, Christophe Fergeau wrote:
Currently, when trying to virsh pool-define/virsh pool-build a new
'dir' pool, if the target directory already exists, virsh
pool-build/virStoragePoolBuild
Currently, when trying to virsh pool-define/virsh pool-build a new
'dir' pool, if the target directory already exists, virsh
pool-build/virStoragePoolBuild will error out. This is a change of
behaviour compared to eg libvirt 1.2.13
This is caused by the wrong type being used for the
On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau wrote:
Hey,
This patch series makes tests/test-gconfig valgrind-clean, and refactors two
setters in GVirConfigDomainVideo to make them use the helpers provided by
GVirConfigObject.
Ping?
Christophe
pgpcnLMuTzo94.pgp
Description
On Fri, Jul 17, 2015 at 03:42:36PM +0200, Martin Kletzander wrote:
On Fri, Jul 17, 2015 at 12:11:55PM +0200, Peter Krempa wrote:
On Fri, Jul 17, 2015 at 09:29:44 +0100, Frediano Ziglio wrote:
Allows to specify maximum number of head to QXL driver.
Actually can be a compatiblity problem as
On Mon, Jul 13, 2015 at 02:45:21PM +0100, Zeeshan Ali (Khattak) wrote:
On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Patches of yours broke the build, you have a strong opinion on the right way
to fix it, in such situations I usually go the extra mile
On Thu, Jul 16, 2015 at 02:02:39PM +0800, tzheng wrote:
Hi,Cole
After this patch is included in libvirt on rhel7.2,virt-manager can not
create dir pool with existing directory.
There is no default pool created in a fresh rhel7.2 system,so if I try to
create default pool,the below error
On Fri, Jul 10, 2015 at 04:43:15PM +0100, Zeeshan Ali (Khattak) wrote:
I really don't see the point of evaluating possible but unlinkely[1]
impact on any distro. As I said, we give distros enough time and that
should be more than enough upstream could do. i-e these exact details
are
On Thu, Jul 09, 2015 at 02:41:45PM +0100, Zeeshan Ali (Khattak) wrote:
The answer was that magnitude of ugliness is irrelevant. Surely you
know that this is not anything objective. To me a single #ifdef is
ugly enough but seems it's not for you so how do you expect either of
us to convince
Hey,
This patch series makes tests/test-gconfig valgrind-clean, and refactors two
setters in GVirConfigDomainVideo to make them use the helpers provided by
GVirConfigObject.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
tests/test-gconfig.c | 2 ++
tests/xml/gconfig-domain-device-video.xml | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index de09c24..aca8f02 100644
--- a/tests/test-gconfig.c
+++ b/tests/test-gconfig.c
@@
The object returned by gvir_config_object_replace_child() must be
unref'ed when no longer needed.
---
libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c
On Wed, Jul 08, 2015 at 07:00:36PM +0100, Zeeshan Ali (Khattak) wrote:
On Wed, Jul 8, 2015 at 3:42 PM, Christophe Fergeau cferg...@redhat.com
wrote:
but you haven't brought
anything forward to support that ugly hack statement in this specific
case,
#ifdef based solution is going
Running test-gconfig under valgrind reports a few leaks that this commit
fixes.
---
tests/test-gconfig.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index 0eec53e..de09c24 100644
--- a/tests/test-gconfig.c
+++ b/tests/test-gconfig.c
@@
GVirConfigDomainVideo is using raw libxml calls to set the 'heads' and
'vram' XML attributes rather than the helpers provided by
GVirConfigObject. This commit changes that, making the code a bit
simpler.
---
libvirt-gconfig/libvirt-gconfig-domain-video.c | 38 +++---
1 file
On Thu, Jul 09, 2015 at 12:42:23PM +0100, Zeeshan Ali (Khattak) wrote:
Honestly, this is a very weird attitude, rather than trying to
come with hard facts, you prefer having some kind of poll and make an
arbitary uninformed decision.
I regret having to resort to some sort of poll as well
On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak) wrote:
Hi all,
Christophe pointed out that this and the previous patch binds API that
was added an year ago:
commit: 03e0e79e07622496522609741734c2fdcacb5bf2
Author: Nehal J Wani nehaljw.k...@gmail.com
Date: Tue Jun 24
On Wed, Jul 08, 2015 at 07:56:23AM +0200, Cédric Bosdonnat wrote:
Hi all,
Here is a version fixing two bugs I introduced.
ACK to both.
Christophe
pgppU3IRgXMhI.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Jul 08, 2015 at 01:13:09PM +0100, Zeeshan Ali (Khattak) wrote:
On Wed, Jul 8, 2015 at 11:11 AM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak) wrote:
Hi all,
Christophe pointed out that this and the previous patch
On Wed, Jul 08, 2015 at 03:37:43PM +0100, Zeeshan Ali (Khattak) wrote:
Also keeping in mind that it makes very little
sense to upgrade libvirt-glib and not libvirt since libvirt doesn't
break any ABI/API.
Generally speaking, there could be security issues, critical bugs in
Boxes which
On Wed, Jul 01, 2015 at 09:40:45PM +0100, Zeeshan Ali (Khattak) wrote:
@@ -901,77 +801,31 @@ gboolean
gvir_connection_fetch_storage_pools(GVirConnection *conn,
if (g_cancellable_set_error_if_cancelled(cancellable, err))
goto cleanup;
-active = fetch_list(vconn,
-
On Wed, Jul 01, 2015 at 09:40:49PM +0100, Zeeshan Ali (Khattak) wrote:
Add API to query networks from a connection.
---
libvirt-gobject/libvirt-gobject-connection.c | 257
+++
libvirt-gobject/libvirt-gobject-connection.h | 13 +-
libvirt-gobject/libvirt-gobject.sym
On Wed, Jul 01, 2015 at 09:40:47PM +0100, Zeeshan Ali (Khattak) wrote:
GSimpleAsyncResult has been deprecated in favour of GTask and with
latest glib headers, we get tons of warnings about use of deprecated
API. This patch ports the GVirConnection class to GTask.
---
On Tue, Jul 07, 2015 at 06:24:38PM +0200, Cedric Bosdonnat wrote:
On Tue, 2015-07-07 at 17:31 +0200, Christophe Fergeau wrote:
This is unintuitive, but after looking at the code and a quick test, I
think _add_child() will create the node if it does not exist, and
return
the existing node
Hey,
On Tue, Jul 07, 2015 at 04:26:02PM +0200, Cédric Bosdonnat wrote:
When setting filesystem driver format first and type, only the type
remained and vice-versa.
---
libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 8 ++--
tests/test-gconfig.c | 2 +-
On Tue, Jul 07, 2015 at 04:49:16PM +0200, Cédric Bosdonnat wrote:
Tests can't succeed from the distribution tarball: the new
gconfig-domain-device-filesys.xml file wasn't included.
---
tests/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile.am
On Wed, Jul 01, 2015 at 09:40:48PM +0100, Zeeshan Ali (Khattak) wrote:
Add API to query network interfaces from a connection.
---
libvirt-gobject/libvirt-gobject-connection.c | 265
+++
libvirt-gobject/libvirt-gobject-connection.h | 13 +-
On Tue, Jul 07, 2015 at 03:17:37PM +0100, Zeeshan Ali (Khattak) wrote:
---
libvirt-gobject/libvirt-gobject-network.c | 55
+++
libvirt-gobject/libvirt-gobject-network.h | 4 +++
libvirt-gobject/libvirt-gobject.sym | 2 ++
3 files changed, 61
Hey,
A 'changes since v4' section would have been nice
ACK series.
Christophe
On Tue, Jul 07, 2015 at 03:17:31PM +0100, Zeeshan Ali (Khattak) wrote:
Make use of virConnectListAll* functions to avoid making 4 calls and
hence avoid race conditions and complicated code.
---
On Wed, Jul 01, 2015 at 09:40:51PM +0100, Zeeshan Ali (Khattak) wrote:
---
libvirt-gobject/libvirt-gobject-network.c | 54
+++
libvirt-gobject/libvirt-gobject-network.h | 4 +++
libvirt-gobject/libvirt-gobject.sym | 2 ++
3 files changed, 60
On Wed, Jul 01, 2015 at 09:40:45PM +0100, Zeeshan Ali (Khattak) wrote:
Make use of virConnectListAll* functions to avoid making 4 calls and
hence avoid race conditions and complicated code.
Fwiw, I would have split this in 2, one for domains, and one for pools,
but fine this way too, ACK.
Please be a bit more verbose in the commit log as to what the leak is.
(a virConnect reference is leaked in error cases, the unref is moved
after the label we jump to on errors to avoid the leak)
Looks good otherwise,
Christophe
On Wed, Jul 01, 2015 at 09:40:46PM +0100, Zeeshan Ali (Khattak)
On Wed, Jul 01, 2015 at 09:40:50PM +0100, Zeeshan Ali (Khattak) wrote:
diff --git a/libvirt-gobject/libvirt-gobject.sym
b/libvirt-gobject/libvirt-gobject.sym
index 88ca271..d345813 100644
--- a/libvirt-gobject/libvirt-gobject.sym
+++ b/libvirt-gobject/libvirt-gobject.sym
@@ -287,6 +287,19
Hey,
Looks good to me, I'd name the type GVirNetworkDhcpLease rather than
GVirNetworkDHCPLease, this is consistent with
GVirConfigCapabilitiesCpuModel (and not CPUModel).
Maybe more descriptive doc for some of the fields (client id, iaid, ...)
could be useful? Or are they just obvious for
On Mon, Jun 29, 2015 at 03:08:55PM +0100, Zeeshan Ali (Khattak) wrote:
---
libvirt-gobject/libvirt-gobject-network.c | 53
+++
libvirt-gobject/libvirt-gobject-network.h | 4 +++
libvirt-gobject/libvirt-gobject.sym | 3 ++
3 files changed, 60
On Tue, Jun 30, 2015 at 01:28:19PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 30, 2015 at 01:25:28PM +0100, Zeeshan Ali (Khattak) wrote:
On Tue, Jun 30, 2015 at 12:41 PM, Christophe Fergeau
cferg...@redhat.com wrote:
Hey,
Looks good to me, I'd name the type GVirNetworkDhcpLease
On Tue, Jun 30, 2015 at 01:22:18PM +0100, Zeeshan Ali (Khattak) wrote:
diff --git a/libvirt-gobject/libvirt-gobject.sym
b/libvirt-gobject/libvirt-gobject.sym
index 29c4349..b7ce1d5 100644
--- a/libvirt-gobject/libvirt-gobject.sym
+++ b/libvirt-gobject/libvirt-gobject.sym
@@ -273,6
On Tue, Jun 30, 2015 at 01:25:28PM +0100, Zeeshan Ali (Khattak) wrote:
On Tue, Jun 30, 2015 at 12:41 PM, Christophe Fergeau
cferg...@redhat.com wrote:
Hey,
Looks good to me, I'd name the type GVirNetworkDhcpLease rather than
GVirNetworkDHCPLease, this is consistent
On Tue, Jun 30, 2015 at 01:48:41PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 30, 2015 at 02:38:24PM +0200, Christophe Fergeau wrote:
On Tue, Jun 30, 2015 at 01:28:19PM +0100, Daniel P. Berrange wrote:
On Tue, Jun 30, 2015 at 01:25:28PM +0100, Zeeshan Ali (Khattak) wrote:
On Tue, Jun
ACK.
On Mon, Jun 29, 2015 at 03:08:51PM +0100, Zeeshan Ali (Khattak) wrote:
Add a wrapper for virInterfaceGetMACString().
---
libvirt-gobject/libvirt-gobject-interface.c | 13 +
libvirt-gobject/libvirt-gobject-interface.h | 1 +
libvirt-gobject/libvirt-gobject.sym | 5
On Mon, Jun 29, 2015 at 03:08:52PM +0100, Zeeshan Ali (Khattak) wrote:
Add API to query network interfaces from a connection.
---
libvirt-gobject/libvirt-gobject-connection.c | 226
+++
libvirt-gobject/libvirt-gobject-connection.h | 6 +-
Hey,
Exactly the same comments/questions as 2/5 apply here, I forgot to ask
for API doc for gvir_connection_find_network_by_name and
gvir_connection_get_network in the previous commit.
Christophe
pgpOlBJQDpglq.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
Ping?
On Mon, Apr 13, 2015 at 11:09:31AM +0200, Christophe Fergeau wrote:
The object returned by gvir_config_domain_disk_get_driver() must be
unref'ed when no longer used.
---
libvirt-gconfig/tests/test-domain-create.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt-gconfig
On Tue, Jun 16, 2015 at 10:58:13AM +0200, Cédric Bosdonnat wrote:
---
libvirt-gconfig/libvirt-gconfig-domain-filesys.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.h
b/libvirt-gconfig/libvirt-gconfig-domain-filesys.h
index
Hey,
Thanks for adding the test!
ACK to patches 1, 3 and 4, one comment in 2.
Christophe
On Tue, Jun 16, 2015 at 10:58:10AM +0200, Cédric Bosdonnat wrote:
Hi all,
Here is the previous patch split into a series. The difference with v1 are:
* it adds test-gconfig test for file systems
*
On Mon, Jun 15, 2015 at 05:36:49PM +0200, Cedric Bosdonnat wrote:
On Mon, 2015-06-15 at 17:12 +0200, Christophe Fergeau wrote:
I haven't looked if there are other similar situations in
libvirt-gconfig, but silently overwriting a preexisting type attribute
with something different when
Hey,
On Mon, Jun 15, 2015 at 03:37:12PM +0200, Cédric Bosdonnat wrote:
Add the gvir_config_domain_filesys_set_driver_format function to allow
setting nbd driver type + image format for containers filesystems.
---
libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 30
Hey,
On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote:
Allow to specify maximum number of head to QXL driver.
I've tested this with an older qemu without qxl-vga.max_outputs, and
with a newer one with support for it, and in both cases this is doing
the right thing.
On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote:
Actually can be a compatiblity problem as heads in the XML configuration
was set by default to '1'.
Yes, this bit is worrying, the old behaviour could be considered as
buggy as the XML contained '1' but the number of heads was
Looks good, ACK.
Christophe
On Wed, Jun 03, 2015 at 09:46:35PM +0100, Zeeshan Ali (Khattak) wrote:
Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart.
---
libvirt-gobject/libvirt-gobject-storage-pool.c | 51
++
On Fri, May 29, 2015 at 06:49:43PM +0100, Zeeshan Ali (Khattak) wrote:
+}
+
+/**
+ * gvir_storage_pool_set_autostart:
+ * @pool: the storage pool
+ * @autostart: New value for autostart flag
for the autostart flag ?
Yeah, I couldn't think of better way to put it than libvirt
gvir_config_domain_set_memory() is a void function, so using
g_return_val_if_fail() is not correct. This causes a warning/compilation
failure on CentOS CI framework:
https://ci.centos.org/view/libvirt-project/job/libvirt-glib-build/systems=libvirt-fedora-20/144/console
---
Pushed under the build
It's currently possible to trigger a crash by passing eg NULL to these
functions. Better to return a prominent warning to the caller without
crashing.
---
libvirt-gconfig/libvirt-gconfig-domain.c | 28
1 file changed, 28 insertions(+)
diff --git
On Mon, May 18, 2015 at 03:11:07PM +0100, Zeeshan Ali (Khattak) wrote:
Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart.
---
libvirt-gobject/libvirt-gobject-storage-pool.c | 52
++
libvirt-gobject/libvirt-gobject-storage-pool.h | 5 +++
Hey,
On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote:
+VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST,
+ hvm,
+ xen,
+ linux,
+ exe,
+ uml,
+ aix)
+
This is preexisting before your patch, but
Hey,
On Fri, Apr 10, 2015 at 05:01:55AM +, William Adams wrote:
I have started a luajit language binding for libvirt. It can be found here:
I don't know how well https://github.com/pavouk/lgi/ works, but one
alternative to writing lua bindings for libvirt would be to try to use
The object returned by gvir_config_domain_disk_get_driver() must be
unref'ed when no longer used.
---
libvirt-gconfig/tests/test-domain-create.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index
Hey Richa,
On Sun, Apr 12, 2015 at 03:11:41PM -0700, Richa Sehgal wrote:
This change adds support for setting of compat XML node in libvirt
gconfig storage volumes target
Looks good to me, I've now pushed it with a slightly reworked commit
message:
autogen.sh is currently checking for the libtool binary, but
it's libtoolize which is needed by autoreconf, not libtool.
These binaries are packaged separately on Debian/Ubuntu so this can
cause actual issues on some systems.
Bug reported by Frederic Peters
---
autogen.sh | 2 +-
1 file
On Tue, Mar 24, 2015 at 02:22:13PM +0100, Michal Privoznik wrote:
On 24.03.2015 13:51, Christophe Fergeau wrote:
autogen.sh is currently checking for the libtool binary, but
it's libtoolize which is needed by autoreconf, not libtool.
These binaries are packaged separately on Debian
On Wed, Mar 04, 2015 at 10:32:34AM +0100, Michal Privoznik wrote:
On 03.03.2015 12:11, Christophe Fergeau wrote:
Hey,
After seeing the libvirt-designer GSoC idea, I remembered about a bunch of
libvirt-designer patches I had never sent :) Here they are, a few leak
fixes/build cleanups
One GVirConfigCapabilitiesGuestArch instance was created for each loop
iteration, but it was never unref'ed, causing a memory leak.
---
libvirt-designer/libvirt-designer-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-designer/libvirt-designer-domain.c
When the list of devices is empty (osinfo_list_get_length(devices) ==
0), the 'devices' object would be leaked.
---
libvirt-designer/libvirt-designer-domain.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
On Wed, Mar 04, 2015 at 10:50:57AM +0100, Michal Privoznik wrote:
This test is meant for adding CDROM, floppy and disk to a domain.
For now, each method has _file and _device variant, which are
tested for now.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Funny, when reviewing
On Wed, Mar 04, 2015 at 01:50:51PM +0100, Michal Privoznik wrote:
On 04.03.2015 13:26, Christophe Fergeau wrote:
When the list of devices is empty (osinfo_list_get_length(devices) ==
0), the 'devices' object would be leaked.
---
libvirt-designer/libvirt-designer-domain.c | 6 --
1
Hey,
On Wed, Mar 04, 2015 at 02:05:07PM +0100, Michal Privoznik wrote:
Currently, since we were using check_PROGRAMS in the Makefile
template, the test program build was postponed until 'make check'
was run. That's not optimal. Lets build (not run!) test program
in the 'make all' phase.
These cover 2 additional types of libvirt interfaces: usermode/SLIRP
networking and bridge.
---
libvirt-designer/libvirt-designer-domain.c | 70 +-
libvirt-designer/libvirt-designer-domain.h | 5 +++
libvirt-designer/libvirt-designer.sym | 2 +
3 files changed,
---
libvirt-designer/libvirt-designer-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 7387ab1..0321180 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++
Hey,
After seeing the libvirt-designer GSoC idea, I remembered about a bunch of
libvirt-designer patches I had never sent :) Here they are, a few leak
fixes/build cleanups, and addition of 2 new methods for completeness.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
A GVirConfigDomainDiskDriver is created in
gvir_designer_domain_add_disk_full but it's never unref'ed. This commit
fixes that, including when an error occurs.
---
libvirt-designer/libvirt-designer-domain.c | 4
1 file changed, 4 insertions(+)
diff --git
The latter is deprecated in favour of the former.
---
examples/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/Makefile.am b/examples/Makefile.am
index 1d8947f..65a5afe 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -1,4 +1,4 @@
-INCLUDES
This fixes gcc warning about -Wmudflap on fedora 21
---
m4/manywarnings.m4 | 213 ++---
1 file changed, 137 insertions(+), 76 deletions(-)
diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
index fd0e372..3e6dd21 100644
--- a/m4/manywarnings.m4
When an unknown NIC type is passed to
gvir_designer_domain_add_interface_full(), 'ret' would be returned
uninitialized to the caller.
---
libvirt-designer/libvirt-designer-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
The caller of gvir_designer_domain_add_interface_network() owns a reference
on the returned GVirConfigDomainInterface instance, so it needs to be
released when no longer needed.
---
examples/virt-designer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/virt-designer.c
Use 'they' instead of 'he'.
---
docs/hacking.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 32ebd8e..a73b1e0 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -65,7 +65,7 @@
review your patch
On Wed, Nov 26, 2014 at 01:13:57PM +, Zeeshan Ali (Khattak) wrote:
Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is
not available, it means we are dealing with older libvirt so we create
the socket pair ourselves if that is the case.
---
configure.ac
Hey,
On Fri, Nov 21, 2014 at 03:11:36PM +, Zeeshan Ali (Khattak) wrote:
Add binding for virDomainOpenGraphicsFD. If virDomainOpenGraphicsFD is
not available, it means we are dealing with older libvirt so we create
the socket pair ourselves if that is the case.
---
configure.ac
On Wed, Nov 19, 2014 at 01:19:31AM +, Zeeshan Ali (Khattak) wrote:
Add binding for virDomainOpenGraphicsFD.
---
libvirt-gobject/libvirt-gobject-domain.c | 36
libvirt-gobject/libvirt-gobject-domain.h | 4
libvirt-gobject/libvirt-gobject.sym |
On Wed, Nov 19, 2014 at 12:08:21PM +, Zeeshan Ali (Khattak) wrote:
On Wed, Nov 19, 2014 at 11:00 AM, Christophe Fergeau
cferg...@redhat.com wrote:
Could/should this take a GVirConfigDomainGraphics * instead and infer
the index from it?
I know gvir_domain-open_graphics() uses 'idx
On Wed, Nov 19, 2014 at 02:10:11PM +, Zeeshan Ali (Khattak) wrote:
However, there is still the issue of this API not being convenient for
app if it takes a GVirConfigDomainGraphics *. They'll have to get the
GVirConfigDomain pointer and get list of devices and and find the
graphics device
On Tue, Nov 04, 2014 at 03:40:37PM +0100, Michal Privoznik wrote:
The macros under the m4 directory are outdated a bit. When trying
to compile with newer gcc I see some errors:
ACK. The update to m4/warnings.m4 is not really needed, but it does
not hurt :)
make[2]: Entering directory
On Wed, Oct 22, 2014 at 04:16:14PM +0200, Fabiano Fidêncio wrote:
As the short-id can be used to set the os/platform in the example
program, let's expose them to the user.
Why not, ACK.
Christophe
pgpW0QEpc8TbY.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
Hi Yves,
On Wed, Oct 01, 2014 at 06:59:52AM +, Yves Vinter wrote:
No answer ?
If you split the patch in several smaller chunks as Eric requested and
send them to the mailing list for review, the next steps will be that
people on this list will review pour patch, potentially make comments
ACK
Christophe
On Mon, Sep 29, 2014 at 07:01:31PM +0100, Zeeshan Ali (Khattak) wrote:
Add missing enum type for keyboard input device.
---
libvirt-gconfig/libvirt-gconfig-domain-input.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Hey,
On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote:
I have tagged the release candidate 1 for libvirt-1.2.9 in git,
and pushed signed tarballs and rpms to the usual place:
ftp://libvirt.org/libvirt/
This seems to work fine with my limited testing, but more people
On Mon, Sep 29, 2014 at 04:34:50PM +0200, Ján Tomko wrote:
On 09/29/2014 12:01 PM, Christophe Fergeau wrote:
Hey,
On Thu, Sep 25, 2014 at 02:03:18PM +0200, Daniel Veillard wrote:
I have tagged the release candidate 1 for libvirt-1.2.9 in git,
and pushed signed tarballs and rpms
Hey,
On Fri, Sep 19, 2014 at 04:47:37AM +, ban...@openmailbox.org wrote:
I was trying different video devices to correct the problem of having
1024x768 as the maximum resolution for Debian guests. I found out that
adding VMVGA gives the wide variety of choice of resolutions I was looking
Hi,
On Fri, Aug 29, 2014 at 10:22:33AM -0600, Eric Blake wrote:
Sometimes, when a patch is that invasive, I'll do it in two parts - the
change with wrong indentation, followed by another patch that is
indentation-only. Much easier to review.
Ah right, I remember seeing that in the past, I
Since 1b807f92, connecting with virsh to an already running session
libvirtd fails with:
$ virsh list --all
error: failed to connect to the hypervisor
error: no valid connection
error: Failed to connect socket to
'/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already
connected
This
Hey,
On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote:
Although my git was a bit confused by the diff included in the commit
message. I'd suggest just saying that most of the commit is a
whitespace change; people can see that using '-w' themselves. That
toggle should even
Since 1b807f92, connecting with virsh to an already running session
libvirtd fails with:
$ virsh list --all
error: failed to connect to the hypervisor
error: no valid connection
error: Failed to connect socket to
'/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already
connected
This
Since 1b807f92, connecting with virsh to an already running session
libvirtd fails with:
$ virsh list --all
error: failed to connect to the hypervisor
error: no valid connection
error: Failed to connect socket to
'/run/user/1000/libvirt/libvirt-sock': Transport endpoint is already
connected
This
Hey,
I just noticed that clicking on FAQ in the left sidebar on libvirt.org
main page highlights the Wiki cell instead of highlighting FAQ.
I have no idea how the website works, so I'm just reporting it here.
Cheers,
Christophe
pgpLbXH1JyIl6.pgp
Description: PGP signature
--
libvir-list
On Tue, Aug 19, 2014 at 06:06:22PM +0200, Timm Bäder wrote:
---
libvirt-gobject/libvirt-gobject-domain-snapshot.c | 59
+++
libvirt-gobject/libvirt-gobject-domain-snapshot.h | 11 +
libvirt-gobject/libvirt-gobject.sym | 2 +
3 files changed, 72
Few nits, will fix before pushing.
On Tue, Aug 19, 2014 at 06:06:23PM +0200, Timm Bäder wrote:
---
libvirt-gobject/libvirt-gobject-domain.c | 74
libvirt-gobject/libvirt-gobject-domain.h | 12 ++
libvirt-gobject/libvirt-gobject.sym | 2 +
3 files
Hey,
On Fri, Aug 15, 2014 at 12:05:44PM +0200, Timm Bäder wrote:
Fixes some warnings from g-ir-scanner.
---
libvirt-gobject/libvirt-gobject-domain.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c
On Fri, Aug 15, 2014 at 12:05:45PM +0200, Timm Bäder wrote:
---
libvirt-gobject/libvirt-gobject-domain-snapshot.c | 56
+++
libvirt-gobject/libvirt-gobject-domain-snapshot.h | 10
libvirt-gobject/libvirt-gobject.sym | 2 +
3 files changed, 68
On Fri, Aug 15, 2014 at 12:05:46PM +0200, Timm Bäder wrote:
---
libvirt-gobject/libvirt-gobject-domain.c | 67
libvirt-gobject/libvirt-gobject-domain.h | 11 ++
libvirt-gobject/libvirt-gobject.sym | 2 +
3 files changed, 80 insertions(+)
diff
On Fri, Aug 15, 2014 at 12:05:47PM +0200, Timm Bäder wrote:
---
libvirt-gobject/libvirt-gobject-domain-snapshot.c | 56
+++
libvirt-gobject/libvirt-gobject-domain-snapshot.h | 9
libvirt-gobject/libvirt-gobject.sym | 2 +
3 files changed, 67
On Fri, Aug 08, 2014 at 05:07:32PM +0200, Timm Bäder wrote:
... which uses virDomainHasCurrentSnapshot to determine if the given
domain has a current snapshot or not.
---
libvirt-gobject/libvirt-gobject-domain.c | 34
201 - 300 of 1510 matches
Mail list logo
