Hey,
On Thu, Aug 15, 2013 at 01:41:44PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The fetch_list helper cleanup code iterates over the
elements in 'lst' array free'ing each one. This is dead
code, however, since the only way to get there is from
are introduced using the old spelling (with 2 'L').
Signed-off-by: Christophe Fergeau cferg...@redhat.com
---
include/libvirt/libvirt.h.in | 10 +-
include/libvirt/virterror.h | 10 +-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include
On Mon, Aug 19, 2013 at 10:53:28AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 19, 2013 at 11:44:39AM +0200, Christophe Fergeau wrote:
Most constant names in libvirt public API are using the 'CANCELED'
spelling, except for VIR_DOMAIN_JOB_CANCELLED and
VIR_ERR_AUTH_CANCELLED
On Fri, Jun 28, 2013 at 03:49:21PM +0100, Daniel P. Berrange wrote:
diff --git a/libvirt-gconfig/libvirt-gconfig.sym
b/libvirt-gconfig/libvirt-gconfig.sym
index ccddd88..f8c7cdd 100644
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -66,7 +66,7 @@
On Tue, Jun 18, 2013 at 07:34:01AM -0400, Cole Robinson wrote:
On 06/18/2013 04:20 AM, Osier Yang wrote:
On 18/06/13 00:23, Cole Robinson wrote:
F20/rawhide has will support this.
s/has//,
From: Peter Robinson pbrobin...@gmail.com
---
libvirt.spec.in | 6 +-
1 file
On Thu, Jun 06, 2013 at 09:07:22AM +0200, Michal Privoznik wrote:
You've addressed all my concerns. ACK series.
Thanks, pushed.
Christophe
pgpnVIWpV9UJ9.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Jun 04, 2013 at 08:03:51PM +0200, Michal Privoznik wrote:
On 04.06.2013 18:50, Christophe Fergeau wrote:
This will be useful when implementing gvir_domain_snapshot_get_parent()
as the child node 'parent' is not always present in the XML.
---
libvirt-gconfig/libvirt-gconfig
On Tue, Jun 04, 2013 at 08:03:53PM +0200, Michal Privoznik wrote:
On 04.06.2013 18:50, Christophe Fergeau wrote:
---
libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20
libvirt-gconfig/libvirt-gconfig.sym | 2 ++
2 files changed, 22 insertions(+)
diff
On Tue, Jun 04, 2013 at 07:11:23PM +0200, Michal Privoznik wrote:
+static gboolean
+gvir_designer_domain_has_spice_channel(GVirDesignerDomain *design)
+{
+GList *devices;
+GList *it;
+gboolean has_spice = FALSE;
+
+devices =
On Tue, Jun 04, 2013 at 07:10:57PM +0200, Michal Privoznik wrote:
On 04.06.2013 16:33, Christophe Fergeau wrote:
This makes use of the new gvir_designer_domain_get_supported_devices()
method.
---
libvirt-designer/libvirt-designer-domain.c | 42
+++---
1 file
On Tue, Jun 04, 2013 at 07:11:05PM +0200, Michal Privoznik wrote:
diff --git a/examples/virtxml.c b/examples/virtxml.c
index 46fb551..bd3bfb3 100644
--- a/examples/virtxml.c
+++ b/examples/virtxml.c
@@ -566,6 +566,7 @@ main(int argc, char *argv[])
static char *resources_str =
of the GNU Lesser General Public
@@ -20,6 +20,7 @@
* Authors:
* Daniel P. Berrange berra...@redhat.com
* Michal Privoznik mpriv...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
--
1.8.2.1
--
libvir-list mailing list
libvir-list@redhat.com
https
Hey,
Here is a new version of that series with the issues raised by Michal addressed.
Changes since v3:
- don't automatically add USB/smartcard/graphics devices, but add options
to virtxml to explicitly request those
- return an error when gvir_designer_domain_add_graphics() fails to
This makes use of the new gvir_designer_domain_get_supported_devices()
method.
---
libvirt-designer/libvirt-designer-domain.c | 49 --
1 file changed, 46 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
This setups smartcard redirection to the guest.
I'm not yet fully sure what users could want to tweak there
(there are various ways of setting up the smartcard redirection),
so this code may need to be made more flexible.
The current code is also not checking whether the hypervisor
supports this
When the user sets up the graphical framebuffer to use SPICE,
we now add automatically the SPICE agent channel if it's not present
already.
---
libvirt-designer/libvirt-designer-domain.c | 85 ++
1 file changed, 85 insertions(+)
diff --git
This will add an USB redirection channel to the VM. This can
be called multiple times to redirect several USB devices at once.
This will also add the needed controllers if they are not already
present in the VM.
The current code has 2 shortcomings:
- USB redirection is only supported with SPICE,
This takes into account the devices specified by the deployment, if
this fails, consider the intersection of devices supported by
the OS and by the platform, and if this still fails, falls back
to a hardcoded hypervisor type - video model mapping.
---
examples/virtxml.c |
This allows to choose between SPICE, VNC or a local display, which
will go through SDL or 'desktop' depending on the hypervisor.
---
configure.ac | 2 +-
examples/virtxml.c | 25 +++
libvirt-designer/libvirt-designer-domain.c | 111
Add various devices/configuration to libvirt XML config when
creating the VM. This configuration is generic enough that it
should be useful on all created VMs, that's why no public API is
added to set them up. However, they are split in several helpers
that can easily be exported if needed.
What
---
examples/virtxml.c | 3 +
libvirt-designer/libvirt-designer-domain.c | 133 +
libvirt-designer/libvirt-designer-domain.h | 2 +
libvirt-designer/libvirt-designer.sym | 1 +
4 files changed, 139 insertions(+)
diff --git
This makes use of the new gvir_designer_domain_get_supported_devices()
method.
---
libvirt-designer/libvirt-designer-domain.c | 42 +++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
This takes into account the devices specified by the deployment, if
this fails, consider the intersection of devices supported by
the OS and by the platform, and if this still fails, falls back
to a hardcoded hypervisor type - video model mapping.
---
examples/virtxml.c |
This allows to choose between SPICE, VNC or a local display, which
will go through SDL or 'desktop' depending on the hypervisor.
---
configure.ac | 2 +-
examples/virtxml.c | 4 ++
libvirt-designer/libvirt-designer-domain.c | 111
This setups smartcard redirection to the guest.
I'm not yet fully sure what users could want to tweak there
(there are various ways of setting up the smartcard redirection),
so this code may need to be made more flexible.
The current code is also not checking whether the hypervisor
supports this
Hi,
Resending once more, only change since v2 is a small fix in 1/9 to
avoid calling g_str_has_suffix on a NULL string when no short_id is
available.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
When the user sets up the graphical framebuffer to use SPICE,
we now add automatically the SPICE agent channel if it's not present
already.
---
libvirt-designer/libvirt-designer-domain.c | 85 ++
1 file changed, 85 insertions(+)
diff --git
This will add an USB redirection channel to the VM. This can
be called multiple times to redirect several USB devices at once.
This will also adds the needed controllers if they are not already
present in the VM.
The current code has 2 shortcomings:
- USB redirection is only supported with SPICE,
Add various devices/configuration to libvirt XML config when
creating the VM. This configuration is generic enough that it
should be useful on all created VMs, that's why no public API is
added to set them up. However, they are split in several helpers
that can easily be exported if needed.
What
---
examples/virtxml.c | 3 +
libvirt-designer/libvirt-designer-domain.c | 131 +
libvirt-designer/libvirt-designer-domain.h | 2 +
libvirt-designer/libvirt-designer.sym | 1 +
4 files changed, 137 insertions(+)
diff --git
of the GNU Lesser General Public
@@ -20,6 +20,7 @@
* Authors:
* Daniel P. Berrange berra...@redhat.com
* Michal Privoznik mpriv...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
--
1.8.2.1
--
libvir-list mailing list
libvir-list@redhat.com
https
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
for this attribute, we can't use the same name as in the XML. However,
This will be useful when implementing gvir_domain_snapshot_get_parent()
as the child node 'parent' is not always present in the XML.
---
libvirt-gconfig/libvirt-gconfig-object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
@@
* http://www.gnu.org/licenses/.
*
* Author: Daniel P. Berrange berra...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
#define
.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * http://www.gnu.org/licenses/.
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt
---
libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20
libvirt-gconfig/libvirt-gconfig.sym | 2 ++
2 files changed, 22 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h
b/libvirt-gconfig/libvirt-gconfig-domain-disk.h
index 7363d31..e80a2fc
Hi,
This is a resend of this patch series, the only changes since v2 is the rename
of
gvir_config_domain_disk_[gs]et_driver_type_enum to
gvir_config_domain_disk_[gs]et_driver_format and the rename of
gvir_config_domain_snapshot_disk_set_driver_type to
---
.../libvirt-gconfig-domain-snapshot-disk.c | 85 ++
.../libvirt-gconfig-domain-snapshot-disk.h | 16
libvirt-gconfig/libvirt-gconfig.sym| 9 +++
3 files changed, 110 insertions(+)
diff --git
On Tue, May 14, 2013 at 04:38:34PM -0600, Eric Blake wrote:
On 05/14/2013 03:02 AM, Christophe Fergeau wrote:
I can send a patch removing that bit from configure.ac and adding a GPLv2
COPYING file, however
- this is the first time I hear about such a requirement for LGPLv2
licensed
On Thu, Apr 18, 2013 at 06:12:24PM +0200, Christophe Fergeau wrote:
This goes on top of v2 of the Improve disk bus type generation series.
Diff with the previous version is that it's rebased against latest master,
and I've reworked Implement gvir_designer_domain_add_sound() patch to
address
On Mon, May 13, 2013 at 09:34:59AM +0100, Daniel P. Berrange wrote:
Rather than using an _enum suffix, how about just giving it a
different name. The word 'type' is really bogus in our XML
schema - it should have been 'format'. eg
gvir_config_domain_disk_[sg]et_driver_format
I'll change
On Tue, May 07, 2013 at 10:48:25AM -0600, Eric Blake wrote:
Hmm. I just noticed that our COPYING file is the older copy of
COPYING.LIB (LGPL); but LGPL requires that we distribute a copy of the
GPL (since the LGPL refers by reference to terms from the GPL). Looks
like we still have some more
Hey,
On Wed, May 08, 2013 at 01:22:47PM +0800, Guannan Ren wrote:
-vnc :5900,share=allow-exclusive
allows clients to ask for exclusive access which is
implemented by dropping other connections Connecting
multiple clients in parallel requires all clients asking
for a shared session
qemu-img resize will fail with The new size must be a multiple of 512
if libvirt doesn't round it first.
This fixes rhbz#951495
Signed-off-by: Christophe Fergeau cferg...@redhat.com
---
src/storage/storage_backend_fs.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/storage
On Tue, May 14, 2013 at 09:56:44PM +0800, Osier Yang wrote:
On 14/05/13 21:50, Christophe Fergeau wrote:
qemu-img resize will fail with The new size must be a multiple of 512
if libvirt doesn't round it first.
This fixes rhbz#951495
Signed-off-by: Christophe Fergeau cferg...@redhat.com
qemu-img resize will fail with The new size must be a multiple of 512
if libvirt doesn't round it first.
This fixes rhbz#951495
Signed-off-by: Christophe Fergeau cferg...@redhat.com
---
Changes since v1:
- move rounding code to a new VIR_ROUND_UP() macro
- add a note in virStorageVolResize
Hey,
This v2 has 3 more patches than the initial series, they were needed to address
various issues with the initial series. 3/6 is not strictly needed, I'm still
undecided
as to whether it makes things nicer or not, so it's open for discussion (the
deprecation
it introduces would be triggered
This is used to tell the compiler about printf-like format strings
used by some functions. Without this marking, gcc 4.8 is outputs
warnings to recommend using it.
---
libvirt-glib/libvirt-glib-error.c | 3 +++
libvirt-glib/libvirt-glib-error.h | 12 ++--
2 files changed, 9
.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * http://www.gnu.org/licenses/.
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
for this attribute, the alternate versions have an _enum suffix.
I did
This will be useful when implementing gvir_domain_snapshot_get_parent()
as the child node 'parent' is not always present in the XML.
---
libvirt-gconfig/libvirt-gconfig-object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
@@
* http://www.gnu.org/licenses/.
*
* Author: Daniel P. Berrange berra...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
#define
automake outputs a warning about AM_CPPFLAGS being the recommended
name to use for INCLUDES
---
libvirt-gconfig/tests/Makefile.am | 2 +-
python/Makefile.am| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt-gconfig/tests/Makefile.am
---
libvirt-gconfig/libvirt-gconfig-domain-disk.h | 20
libvirt-gconfig/libvirt-gconfig.sym | 2 ++
2 files changed, 22 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-disk.h
b/libvirt-gconfig/libvirt-gconfig-domain-disk.h
index 7363d31..e80a2fc
---
.../libvirt-gconfig-domain-snapshot-disk.c | 85 ++
.../libvirt-gconfig-domain-snapshot-disk.h | 16
libvirt-gconfig/libvirt-gconfig.sym| 9 +++
3 files changed, 110 insertions(+)
diff --git
It was renamed to gvir_config_object_to_xml() a long while ago.
---
examples/conn-test.js | 2 +-
examples/conn-test.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/conn-test.js b/examples/conn-test.js
index 0225a95..7f9784b 100755
--- a/examples/conn-test.js
On Mon, May 13, 2013 at 09:34:59AM +0100, Daniel P. Berrange wrote:
Rather than using an _enum suffix, how about just giving it a
different name. The word 'type' is really bogus in our XML
schema - it should have been 'format'. eg
gvir_config_domain_disk_[sg]et_driver_format
Oh sure, I'm
libvirt commit
http://libvirt.org/git/?p=libvirt.git;a=commit;h=e2c41e486018ee74f6a75c1f717622
strongly hints that driver type for a disk domain should be an
enum rather than a raw string. Since we already have setters/getters
for this attribute, we can't use the same name as in the XML. However,
On Fri, May 03, 2013 at 07:01:11PM +0200, Christophe Fergeau wrote:
On Thu, May 02, 2013 at 06:33:44PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+
+
+const char
*gvir_config_domain_snapshot_get_parent
On Thu, May 02, 2013 at 06:33:44PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+
+/*
+const char
*gvir_config_domain_snapshot_get_memory(GVirConfigDomainSnapshot *snapshot)
Why commented-out? AFAICT from
On Tue, Apr 30, 2013 at 11:29:03AM -0400, Laine Stump wrote:
On 04/30/2013 11:14 AM, Eric Blake wrote:
On 04/30/2013 08:49 AM, george john wrote:
I have written a Java client (64 bit JVM) that uses libvirt APIs on a
remote KVM for KVM management. Since the JVM is 64 bit, the client needs
Hey,
This patch series adds the needed setters/getters to libvirt-gconfig
to be able to generate the libvirt XML described at
http://libvirt.org/formatsnapshot.html
One thing of note is gvir_config_domain_snapshot_get_creation_time()
which returns a GDateTime, which was only added in glib 2.26
---
.../libvirt-gconfig-domain-snapshot-disk.c | 81 ++
.../libvirt-gconfig-domain-snapshot-disk.h | 16 +
libvirt-gconfig/libvirt-gconfig.sym| 9 +++
3 files changed, 106 insertions(+)
diff --git
@@
* http://www.gnu.org/licenses/.
*
* Author: Daniel P. Berrange berra...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
#define
.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * http://www.gnu.org/licenses/.
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt
On Thu, May 02, 2013 at 03:29:47PM +0200, Matthias Bolte wrote:
The last time (like a year ago) I tried the Fedora MinGW build of
libvirt it just crashed on me and I was unable to figure out what the
problem was.
I think I'll have to give it another try :)
Ah, all I know is that it's there,
On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+
+
+const char
*gvir_config_domain_snapshot_disk_get_driver_type(GVirConfigDomainSnapshotDisk
*disk)
Shouldn't 'driver_type
On Thu, May 02, 2013 at 11:40:56PM +0300, Zeeshan Ali (Khattak) wrote:
On Thu, May 2, 2013 at 6:36 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com
Commit cc6d19f3 added text containing codesnapshotcode to
formatsnapshot.html.in. The closing tag is missing '/' which causes
the documentation to misrender.
---
Pushed under the trivial rule.
docs/formatsnapshot.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
It does not handle the recently added
GVirConfigDomainGraphicsRdp and GVirConfigDomainGraphicsDesktop
classes.
---
libvirt-gconfig/libvirt-gconfig-domain-graphics.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c
Through copy and paste from libvirt-gobject-connection.c, we end
up with an instance variable named 'conn' in most of our classes
even if we are not manipulating a connection object. This commit
renames it all 'conn' occurrences in libvirt-gobject and
libvirt-gconfig with a name more consistent
On Tue, Apr 23, 2013 at 03:46:09PM +0200, Peter Krempa wrote:
Decrease size of qemuBuildGraphicsCommandLine() by splitting out
spice-related code into qemuBuildGraphicsVNCCommandLine().
I guess you mean VNC-related code here.
Christophe
This patch also fixes 2 possible memory leaks on
The previous description was a bit confusing.
---
docs/formatsnapshot.html.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/formatsnapshot.html.in b/docs/formatsnapshot.html.in
index 8fcc04c..b1e259f 100644
--- a/docs/formatsnapshot.html.in
+++
Hey,
I've just pushed these 2 patches under the trivial/doc rule.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README b/README
index ed39b9d..b7ca356 100644
--- a/README
+++ b/README
@@ -24,7 +24,7 @@ Or to install into a private user specific location
make
make install
-The following mandatory dependancies are required
Minimum libvirt-gobject, libvirt-gconfig and libosinfo versions
are set in configure.ac, it's better not to duplicate them in
libvirt-designer.spec.in, it's too easy to get them out of sync.
---
configure.ac | 2 +-
libvirt-designer.spec.in | 8
2 files changed, 5
Minimum libvirt-gconfig and libosinfo versions appear in both
README and configure.ac, which means they easily get out of sync.
This commit renames README to README.in so that we can substitute
the configure.ac version in the README file. This way they are always
in sync.
---
Makefile.am
On Fri, Apr 19, 2013 at 11:46:22AM +0200, Michal Privoznik wrote:
--- a/configure.ac
+++ b/configure.ac
@@ -10,7 +10,7 @@ AC_CANONICAL_HOST
AM_SILENT_RULES([yes])
-LIBOSINFO_REQUIRED=0.2.3
+LIBOSINFO_REQUIRED=0.2.6
LIBVIRT_GCONFIG_REQUIRED=0.0.9
On Fri, Apr 19, 2013 at 11:46:21AM +0200, Michal Privoznik wrote:
On 18.04.2013 18:08, Christophe Fergeau wrote:
+static OsinfoDevice *
+gvir_designer_domain_get_fallback_disk_controller(GVirDesignerDomain
*design,
+ GError **error
On Thu, Apr 18, 2013 at 06:12:33PM +0200, Christophe Fergeau wrote:
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 7aec002..73dbc8d 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++ b/libvirt-designer/libvirt-designer
This fixes make distcheck
---
I've pushed this under the trivial rule.
Christophe
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 9ef319a..726d475 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,8 @@ EXTRA_DIST = \
On Thu, Apr 18, 2013 at 05:18:55PM +0100, Daniel P. Berrange wrote:
On Thu, Apr 18, 2013 at 06:12:25PM +0200, Christophe Fergeau wrote:
Add various devices/configuration to libvirt XML config when
creating the VM. This configuration is generic enough that it
should be useful on all created
ACK
On Fri, Apr 19, 2013 at 11:24:31AM +0200, Michal Privoznik wrote:
---
libvirt-designer/libvirt-designer-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-main.c
b/libvirt-designer/libvirt-designer-main.c
index
ACK
Christophe
On Fri, Apr 19, 2013 at 11:24:30AM +0200, Michal Privoznik wrote:
The bindtextdomain syntax-check macro is doing some dumb
checking: each file containing '\main *(' must call
bindtextdomain. Even if it's mentioned inside a comment block,
which we do as of e71ad8e13e7.
---
On Fri, Apr 19, 2013 at 10:56:05AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The current way libtool versioning is calculated has a timebomb
when the package version number changes to 1.0.0, which will
cause the library soname to change. Adapt to the
ACK, I was delaying handling that until a release appears on the radar, but
it's indeed better to do it before we forget ;)
Christophe
On Fri, Apr 19, 2013 at 10:56:15AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The ABI of some methods was explicitly
On Fri, Apr 19, 2013 at 11:09:07AM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The current way libtool versioning is calculated has a timebomb
when the package version number changes to 1.0.0, which will
cause the library soname to change. Adapt to the
On Fri, Apr 19, 2013 at 12:49:23PM +0200, Michal Privoznik wrote:
This test is meant for adding CDROM, floppy and disk to a domain.
For now, each method has _file and _device variant, which are
tested for now.
Oh, thanks for writing that testcase!
ACK
Christophe
---
On Thu, Apr 18, 2013 at 03:17:05PM +0200, Michal Privoznik wrote:
On 03.04.2013 13:35, Christophe Fergeau wrote:
This mirrors disk_file/disk_device API so that it's possible to
add CDROMs and floppies to a GVirDesignerDomain.
This also adds the corresponding -C/-F options to virtxml
This method gathers the list of devices supported by the hypervisor,
and intersects this list with the list of devices supported
by the OS, natively or using a driver (added with
gvir_designer_domain_add_driver()). The lists can be filtered if
needed.
This commit changes
They are useful to tell libvirt-designer about which drivers
are install/will be installed in the OS associated with the domain.
This in turns allows libvirt-designer code to use these devices
when it's making some guesses about what to enable/not enable
in the VM being created.
---
The current handling of bus types has some issues:
- it assumes that if the design uses a disk controller hanging off
a PCI bus, then it can use virtio, which is not true for
Windows for example unless an additional driver is installed
- it checks for ide, sata, virtio bus names, but they are
This setups smartcard redirection to the guest.
I'm not yet fully sure what users could want to tweak there
(there are various ways of setting up the smartcard redirection),
so this code may need to be made more flexible.
The current code is also not checking whether the hypervisor
supports this
Here is a new version of this series rebased against master.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
examples/virtxml.c | 3 +
libvirt-designer/libvirt-designer-domain.c | 131 +
libvirt-designer/libvirt-designer-domain.h | 2 +
libvirt-designer/libvirt-designer.sym | 1 +
4 files changed, 137 insertions(+)
diff --git
of the GNU Lesser General Public
@@ -20,6 +20,7 @@
* Authors:
* Daniel P. Berrange berra...@redhat.com
* Michal Privoznik mpriv...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
--
1.8.1.4
--
libvir-list mailing list
libvir-list@redhat.com
https
This will add an USB redirection channel to the VM. This can
be called multiple times to redirect several USB devices at once.
This will also adds the needed controllers if they are not already
present in the VM.
The current code has 2 shortcomings:
- USB redirection is only supported with SPICE,
Add various devices/configuration to libvirt XML config when
creating the VM. This configuration is generic enough that it
should be useful on all created VMs, that's why no public API is
added to set them up. However, they are split in several helpers
that can easily be exported if needed.
What
This makes use of the new gvir_designer_domain_get_supported_devices()
method.
---
libvirt-designer/libvirt-designer-domain.c | 42 +++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
When the user sets up the graphical framebuffer to use SPICE,
we now add automatically the SPICE agent channel if it's not present
already.
---
libvirt-designer/libvirt-designer-domain.c | 85 ++
1 file changed, 85 insertions(+)
diff --git
501 - 600 of 1510 matches
Mail list logo
