On Thu, Apr 18, 2013 at 04:16:30PM +0200, Michal Privoznik wrote:
Well, for some reason, after applying that patch I cannot apply even the
first one (which I could before). It seems like there's a context
mismatch in the syms file libvirt-designer/libvirt-designer.sym.
If you could repost
On Thu, Apr 18, 2013 at 04:17:17PM +0200, Michal Privoznik wrote:
On 17.04.2013 10:37, Christophe Fergeau wrote:
Apart from danpb's comment in patch #3 which I've fixed locally, any
more feedback/review on this series?
Christophe
Same applies here. I am unable to apply the patchset
This allows to choose between SPICE, VNC or a local display, which
will go through SDL or 'desktop' depending on the hypervisor.
---
configure.ac | 2 +-
examples/virtxml.c | 4 ++
libvirt-designer/libvirt-designer-domain.c | 111
This goes on top of v2 of the Improve disk bus type generation series.
Diff with the previous version is that it's rebased against latest master,
and I've reworked Implement gvir_designer_domain_add_sound() patch to
address danpb's comments (gvir_designer_domain_add_sound() is now a public
method
This takes into account the devices specified by the deployment, if
this fails, consider the intersection of devices supported by
the OS and by the platform, and if this still fails, falls back
to a hardcoded hypervisor type - video model mapping.
---
examples/virtxml.c |
On Wed, Apr 17, 2013 at 07:40:56PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Achieve the same through GIR annotations, just like we already do for
libvirt-glib.
---
libvirt-gobject/libvirt-gobject-main.c | 8 ++--
We switched from 2012 to 2013!!
---
I've pushed this under the trivial rule.
Christophe
NEWS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index b5f0c84..b1f4a80 100644
--- a/NEWS
+++ b/NEWS
@@ -1,7 +1,7 @@
libvirt-glib News
This makes the parameter to be passed unowned in Vala. This was
previously done using a vala metadata file, but it's better to do
it directly through a gtk-doc annotation, as this means the gir
file will know about this, and thus any gir-based binding can
make use of this info.
This also makes
Apart from danpb's comment in patch #3 which I've fixed locally, any
more feedback/review on this series?
Christophe
On Wed, Apr 03, 2013 at 11:37:59AM +0200, Christophe Fergeau wrote:
This series builds on the previous one (the one adding
gvir_designer_domain_get_supported_devices()). It adds
---
Pushed under the trivial rule.
Christophe
examples/virtxml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/virtxml.c b/examples/virtxml.c
index 49a7b4e..20aa621 100644
--- a/examples/virtxml.c
+++ b/examples/virtxml.c
@@ -547,7 +547,7 @@ main(int argc, char
Hi,
On Thu, Apr 11, 2013 at 01:33:50PM +0200, Michal Privoznik wrote:
For some reason this patch cannot be applied cleanly:
Applying: Rework disk bus type handling
error: patch failed: libvirt-designer/libvirt-designer-domain.c:992
error: libvirt-designer/libvirt-designer-domain.c: patch
On Thu, Apr 11, 2013 at 04:32:30PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This is mostly (modified) copypaste from libvirt-glib.
---
v3: Added .metadata file to correct init functions vapi.
Makefile.am | 2 +-
Hey,
On Mon, Apr 08, 2013 at 01:54:21PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gitignore | 7 +
Makefile.am | 2 +-
Hey Jaime,
On Mon, Apr 08, 2013 at 05:35:06PM +0200, Jaime Loureiro Acuña wrote:
My name is Jaime Loureiro and I work in the Network Applications area in
University of Vigo. I am writing to you hoping you can help me with some
libvirt graphics issues.
I was analysing the source code of the
On Mon, Apr 08, 2013 at 01:54:20PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To allow the compiler to check args add G_GNUC_PRINTF and
G_GNUC_NULL_TERMINATED to libvirt-gconfig-helpers-private.h
ACK
Christophe
pgpWa4waUk5wn.pgp
Description: PGP
On Sat, Apr 06, 2013 at 03:28:04AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
I don't see any need for this and it actually breaks the build here:
ACK, this is probably there through CP.
Christophe
GEN LibvirtDesigner-1.0.gir
Package
The current handling of bus types has some issues:
- it assumes that if the design uses a disk controller hanging off
a PCI bus, then it can use virtio, which is not true for
Windows for example unless an additional driver is installed
- it checks for ide, sata, virtio bus names, but they are
This is mostly an excuse to add a _get_supported_devices() method
used in fallback cases (when the deployment does not specify
a disk driver to be used) as this will be useful later.
The list of supported devices is generated with
- devices supported both by the OS and the platform (hypervisor)
-
This method gathers the list of devices supported by the hypervisor,
and intersects this list with the list of devices supported
by the OS, natively or using a driver (added with
gvir_designer_domain_add_driver()). The lists can be filtered if
needed.
This commit changes
They are useful to tell libvirt-designer about which drivers
are install/will be installed in the OS associated with the domain.
This in turns allows libvirt-designer code to use these devices
when it's making some guesses about what to enable/not enable
in the VM being created.
---
---
libvirt-designer/libvirt-designer-domain.c | 120 +
1 file changed, 120 insertions(+)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index c0b0e19..7b1cb33 100644
---
of the GNU Lesser General Public
@@ -20,6 +20,7 @@
* Authors:
* Daniel P. Berrange berra...@redhat.com
* Michal Privoznik mpriv...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
*/
#include config.h
--
1.8.1.4
--
libvir-list mailing list
libvir-list@redhat.com
https
This will add an USB redirection channel to the VM. This can
be called multiple times to redirect several USB devices at once.
This will also adds the needed controllers if they are not already
present in the VM.
The current code has 2 shortcomings:
- USB redirection is only supported with SPICE,
This takes into account the devices specified by the deployment, if
this fails, consider the intersection of devices supported by
the OS and by the platform, and if this still fails, falls back
to a hardcoded hypervisor type - video model mapping.
---
examples/virtxml.c |
This series builds on the previous one (the one adding
gvir_designer_domain_get_supported_devices()). It adds methods
to add more devices disks/network interfaces to GVirDesignDomain.
Some parts like 'Automatically add SPICE channel with SPICE graphics'
may not be what we want, but I've tried to
When the user sets up the graphical framebuffer to use SPICE,
we now add automatically the SPICE agent channel if it's not present
already.
---
libvirt-designer/libvirt-designer-domain.c | 85 ++
1 file changed, 85 insertions(+)
diff --git
Add various devices/configuration to libvirt XML config when
creating the VM. This configuration is generic enough that it
should be useful on all created VMs, that's why no public API is
added to set them up. However, they are split in several helpers
that can easily be exported if needed.
What
This setups smartcard redirection to the guest.
I'm not yet fully sure what users could want to tweak there
(there are various ways of setting up the smartcard redirection),
so this code may need to be made more flexible.
The current code is also not checking whether the hypervisor
supports this
This allows to choose between SPICE, VNC or a local display, which
will go through SDL or 'desktop' depending on the hypervisor.
---
configure.ac | 2 +-
examples/virtxml.c | 4 ++
libvirt-designer/libvirt-designer-domain.c | 111
This makes use of the new gvir_designer_domain_get_supported_devices()
method.
---
libvirt-designer/libvirt-designer-domain.c | 42 +++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
This mirrors disk_file/disk_device API so that it's possible to
add CDROMs and floppies to a GVirDesignerDomain.
This also adds the corresponding -C/-F options to virtxml
---
Here is a reworked version of my patch to add support for CDROMs which
does not override the 'format' parameter this time.
On Tue, Apr 02, 2013 at 11:12:29AM +0100, Daniel P. Berrange wrote:
I don't think it is a good idea to overload 'format' for this purpose.
It is perfectly acceptable to back a CDROM device by a qcow2 files.
I think we should just have a gvir_designer_domain_add_cdrom() method
or some other
We need this to be able to mark the device we are creating as a
CDROM.
---
examples/virtxml.c | 2 +-
libvirt-designer/libvirt-designer-domain.c | 8
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/examples/virtxml.c b/examples/virtxml.c
index
Hey, here are a few small patches for libvirt-designer to fix a few
leaks/polish minor things.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
examples/virtxml.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/examples/virtxml.c b/examples/virtxml.c
index 9a36142..1e9f78a 100644
--- a/examples/virtxml.c
+++ b/examples/virtxml.c
@@ -178,6 +178,7 @@ add_disk(gpointer data,
gpointer user_data)
---
libvirt-designer/libvirt-designer-domain.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 4805102..0d47d3c 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++
Sorry, sent twice to the list by mistake, both versions are identical.
Christophe
On Thu, Mar 28, 2013 at 05:41:54PM +0100, Christophe Fergeau wrote:
---
libvirt-gconfig/libvirt-gconfig-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c
From: Stefano Facchini stefano.facch...@gmail.com
Fix the build for newer automake
---
AUTHORS | 1 +
configure.ac | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 6cec5d7..db05f64 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -17,5 +17,6 @@ Patches have
On Fri, Mar 29, 2013 at 09:34:51AM +0100, Christophe Fergeau wrote:
From: Stefano Facchini stefano.facch...@gmail.com
diff --git a/configure.ac b/configure.ac
index 96dbf5a..2bf9c1b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
AC_INIT(libvirt-glib, 0.1.7)
AC_CONFIG_SRCDIR
On Fri, Mar 29, 2013 at 10:51:01AM +0100, Michal Privoznik wrote:
On 28.03.2013 12:16, Christophe Fergeau wrote:
---
examples/virtxml.c | 3 +++
libvirt-designer/libvirt-designer-domain.c | 2 ++
2 files changed, 5 insertions(+)
ACK series.
Thanks
---
Usually I'd push this under the trivial rule, but I don't know if this is a
valid thing to do during freezes, hence I'm posting it for review first.
Christophe
docs/formatdomain.html.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in
On Fri, Mar 29, 2013 at 10:41:36AM +0100, Christophe Fergeau wrote:
On Fri, Mar 29, 2013 at 09:34:51AM +0100, Christophe Fergeau wrote:
From: Stefano Facchini stefano.facch...@gmail.com
diff --git a/configure.ac b/configure.ac
index 96dbf5a..2bf9c1b 100644
--- a/configure.ac
+++ b
On Fri, Mar 29, 2013 at 08:33:29AM -0600, Eric Blake wrote:
On 03/29/2013 06:55 AM, Christophe Fergeau wrote:
---
Usually I'd push this under the trivial rule, but I don't know if this is a
valid thing to do during freezes, hence I'm posting it for review first.
Trivial doc fixes
Hey,
This series adds various missing setters/getters to the GVirConfigDomainGraphics
API. It also adds classes for the 'desktop' and 'rdp' graphics elements.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.c | 12
libvirt-gconfig/libvirt-gconfig-domain-graphics-sdl.h | 2 ++
libvirt-gconfig/libvirt-gconfig.sym | 5 +
3 files changed, 19 insertions(+)
diff --git
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-graphics-desktop.c | 98 ++
.../libvirt-gconfig-domain-graphics-desktop.h | 71
libvirt-gconfig/libvirt-gconfig.h | 1 +
---
libvirt-gconfig/Makefile.am| 2 +
.../libvirt-gconfig-domain-graphics-rdp.c | 130 +
.../libvirt-gconfig-domain-graphics-rdp.h | 79 +
libvirt-gconfig/libvirt-gconfig.h | 1 +
---
libvirt-gconfig/libvirt-gconfig-domain-channel.c | 18 ++
libvirt-gconfig/libvirt-gconfig-domain-channel.h | 3 +++
libvirt-gconfig/libvirt-gconfig.sym | 3 +++
3 files changed, 24 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-channel.c
---
libvirt-designer/libvirt-designer-domain.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 49e8068..c3a5ce3 100644
---
---
examples/virtxml.c | 3 +++
libvirt-designer/libvirt-designer-domain.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/examples/virtxml.c b/examples/virtxml.c
index c5a5e24..d4a5fe2 100644
--- a/examples/virtxml.c
+++ b/examples/virtxml.c
@@ -126,6 +126,7 @@
---
libvirt-gconfig/libvirt-gconfig-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c
b/libvirt-gconfig/libvirt-gconfig-domain.c
index be572ab..7ef0be8 100644
--- a/libvirt-gconfig/libvirt-gconfig-domain.c
+++
---
libvirt-designer/libvirt-designer-domain.c | 8
1 file changed, 8 insertions(+)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 9dc1d7d..b1aa838 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++
---
libvirt-gconfig/libvirt-gconfig-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c
b/libvirt-gconfig/libvirt-gconfig-domain.c
index be572ab..7ef0be8 100644
--- a/libvirt-gconfig/libvirt-gconfig-domain.c
+++
On Thu, Mar 21, 2013 at 09:43:02PM -0600, Eric Blake wrote:
Expanding everything means re-implementing what the shell does.
wordexp() would be ideal for this, except that wordexp() is not portable
enough.
Maybe wordexp() could be used on platform which support it, and on
platforms that do not
virtxml was doing its own loading of the libosinfo database,
and gvir_designer_init() was loading it a second time.
By adding a GVirDesignerDomain::osinfo_db property, applications
can share the same OsinfoDb as libvirt-designer. The association
is made per libvirt-designer domain for more
On Fri, Mar 22, 2013 at 11:22:20AM +0100, Michal Privoznik wrote:
On 22.03.2013 11:11, Christophe Fergeau wrote:
virtxml was doing its own loading of the libosinfo database,
and gvir_designer_init() was loading it a second time.
By adding a GVirDesignerDomain::osinfo_db property
virtxml was doing its own loading of the libosinfo database,
and gvir_designer_init() was loading it a second time.
By adding a GVirDesignerDomain::osinfo_db property, applications
can share the same OsinfoDb as libvirt-designer. The association
is made per libvirt-designer domain for more
The code was building an id starting with kvm- while libosinfo qemu
description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is
no separate qemu-kvm tarball.
guess_platform_from_connect is starting to be a bit magic, it may
be better to add a machine attribute to libosinfo platform
virtxml was doing its own loading of the libosinfo database,
and gvir_designer_init() was loading it a second time.
By adding a gvir_designer_get_osinfo_db() method, virtxml can use
the same libosinfo database as the rest of libvirt-designer.
---
examples/virtxml.c | 51
Setting GVirConfigDomain::virt_type is required for a working
domain configuration, using it in the test programs will be helpful
if people are using this as a base when starting to use libvirt-gconfig
---
examples/config-demo.py| 1 +
---
libvirt-gconfig/libvirt-gconfig-storage-pool.c | 143 +
libvirt-gconfig/libvirt-gconfig-storage-pool.h | 8 ++
libvirt-gconfig/libvirt-gconfig.sym| 12 +++
3 files changed, 163 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-storage-pool.c
---
.../libvirt-gconfig-storage-pool-source.c | 132 +
.../libvirt-gconfig-storage-pool-source.h | 8 ++
libvirt-gconfig/libvirt-gconfig.sym| 9 ++
libvirt-gconfig/tests/test-domain-create.c | 3 +
4 files changed, 152
---
.../libvirt-gconfig-storage-pool-target.c | 39 ++
.../libvirt-gconfig-storage-pool-target.h | 2 ++
libvirt-gconfig/libvirt-gconfig.sym| 3 ++
libvirt-gconfig/tests/test-domain-create.c | 4 +++
4 files changed, 48
---
.../libvirt-gconfig-storage-permissions.c | 63 ++
.../libvirt-gconfig-storage-permissions.h | 4 ++
libvirt-gconfig/libvirt-gconfig.sym| 5 ++
libvirt-gconfig/tests/test-domain-create.c | 6 +++
4 files changed, 78
Because of a wrong copy and paste, the documentation was saying that
'path' is the path to a block device node while it's a path to a
directory.
---
Pushed under the trivial rule
docs/formatstorage.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
There was a 2 word sentence 'remote server' which is a left-over
from copy and paste.
---
Pushed under the trivial rule.
docs/formatstorage.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index 49ae818..9b68738
On Tue, Mar 19, 2013 at 03:24:22PM +, Daniel P. Berrange wrote:
On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote:
The code was building an id starting with kvm- while libosinfo qemu
description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is
no separate qemu
On Tue, Mar 19, 2013 at 03:58:18PM +, Daniel P. Berrange wrote:
Perhaps we should be following the approach we use for detecting
ISOs, and match against actual product release strings. Libvirt
doesn't expose such info, but we could add an API to expose the
full product string and/or
Ping?
On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote:
The text version
of LGPLv2.1 available at
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly
different from COPYING.LIB:
- several paragraphs were rewrapped
- the FSF address has changed, so the license
ping?
On Thu, Feb 21, 2013 at 04:49:53PM +0100, Christophe Fergeau wrote:
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
revision as QEMU sometimes
On Fri, Mar 15, 2013 at 09:26:08AM +, Daniel P. Berrange wrote:
On Fri, Mar 15, 2013 at 10:08:37AM +0100, Christophe Fergeau wrote:
Ping?
On Mon, Mar 11, 2013 at 12:43:13PM +0100, Christophe Fergeau wrote:
The text version
of LGPLv2.1 available at
http://www.gnu.org/licenses
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
- * Author: Christophe Fergeau cferg...@gmail.com
+ * Authors: Christophe Fergeau cferg...@gmail.com
+ * Zeeshan Ali (Khattak) zeesha...@gnome.org
*/
#include config.h
+#include string.h
I don't think
ACK
On Thu, Mar 14, 2013 at 03:53:46PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Internal libvirt-gconfig helper to replace enum XML attributes.
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 5 +
-spice.c
@@ -17,7 +17,8 @@
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
- * Author: Christophe Fergeau cferg...@gmail.com
+ * Authors: Christophe Fergeau cferg...@gmail.com
On Tue, Mar 12, 2013 at 09:30:17PM +0200, Zeeshan Ali (Khattak) wrote:
Ah ok, makes sense. I was under the impression that we always followed
'one node' = 'one class' rule.
Not really, it's more 'one node with more than 2 'parameters'' = 'one
class' or 'one node that is similar to another one'
On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This patch adds API to set/get image compression options on
domain/graphics[@type='spice'] nodes.
Also included are simple tests for this API.
Do we really need a
On Tue, Mar 12, 2013 at 06:28:36PM +0200, Zeeshan Ali (Khattak) wrote:
On Tue, Mar 12, 2013 at 3:16 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This patch adds
A few files were using the old address.
---
libvirt-designer/libvirt-designer-domain.c | 2 +-
libvirt-designer/libvirt-designer-domain.h | 2 +-
libvirt-designer/test-designer-domain.c| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
The text version
of LGPLv2.1 available at
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is slightly
different from COPYING.LIB:
- several paragraphs were rewrapped
- the FSF address has changed, so the license has been changed to
indicate the newer address
I've checked that there are no
On Mon, Mar 11, 2013 at 07:47:34PM +0800, Osier Yang wrote:
Given that the address can be changed unpreditabl, better to change
it as what GNU recommends. Just like libvirt does:
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not,
It was wrong after the FSF moved, and this is not how the
licensing boilerplate is written in other source files.
---
libvirt-designer/libvirt-designer-domain.c | 4 ++--
libvirt-designer/libvirt-designer-domain.h | 4 ++--
libvirt-designer/test-designer-domain.c| 4 ++--
3 files changed, 6
Self NACK, I just sent a v2 removing the FSF address from these files,
and pointing at the fsf website instead as suggested by Laine in
my libvirt-glib patch.
Christophe
On Mon, Mar 11, 2013 at 12:36:16PM +0100, Christophe Fergeau wrote:
A few files were using the old address.
---
libvirt
On Mon, Mar 11, 2013 at 02:16:32PM +0100, Michal Privoznik wrote:
On 11.03.2013 14:07, Christophe Fergeau wrote:
It was wrong after the FSF moved, and this is not how the
licensing boilerplate is written in other source files.
---
libvirt-designer/libvirt-designer-domain.c | 4
On Sat, Mar 02, 2013 at 04:54:34PM -0500, Laine Stump wrote:
As the author of the patch that uncovered/caused the breakage, I'll
second the ACK on the first hunk and NACK on the second.
I've now pushed this first hunk to master with a slightly improved commit
log. Thanks Doug and Laine for the
know at all and I've only lightly tested it. This issue is a 1.0.3
blocker as far as Boxes is concerned.
Thanks,
Christophe
From 6474eb9dc04dcaa29450116ddfb76aefdaffd4f6 Mon Sep 17 00:00:00 2001
From: Christophe Fergeau cferg...@redhat.com
Date: Sat, 2 Mar 2013 15:19:47 +0100
Subject: [PATCH
On Sat, Mar 02, 2013 at 12:30:10PM -0600, Doug Goldstein wrote:
On Sat, Mar 2, 2013 at 8:30 AM, Christophe Fergeau cferg...@redhat.com
wrote:
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index f3b09cf..3ef3499 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
On Thu, Feb 21, 2013 at 01:07:27PM -0700, Eric Blake wrote:
On 02/21/2013 08:49 AM, Christophe Fergeau wrote:
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
---
src/conf/domain_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions
Hey Kashyap,
I've started reading this to learn about libvirt snapshot implementation,
and noticed a few typos (I think Eric already pointed out some of these),
On Tue, Oct 23, 2012 at 03:28:06PM +0530, Kashyap Chamarthy wrote:
---
docs/snapshots-blockcommit-blockpull.rst | 646
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
---
src/conf/domain_conf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 10f361c..258ee93 100644
---
It's only freed on normal returns from virDomainVideoDefParseXML,
but not when erroring out.
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 258ee93..0c75838 100644
--- a/src/conf/domain_conf.c
+++
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
revision as QEMU sometimes support newer QXL revisions than what
it defaults to.
---
docs/formatdomain.html.in
Ping?
On Mon, Feb 04, 2013 at 04:16:36PM +0100, Christophe Fergeau wrote:
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
revision as QEMU sometimes
In addition to rejecting domains containing '/', this series also filter
out domains starting with a '.'.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Similarly to 790f912b4 which rejects snapshots names containing,
this commit changes virDomainSaveXML to reject domains with a '/'
in their name. The domain name is used as a filename, so this
leads to unexpected results when used in combination with '..'
---
src/conf/domain_conf.c | 7 +++
1
The domain name is used as a filename, so this leads to unexpected results,
either because hidden files are created, or because the file is created
somewhere else in the directory tree when '/' is used as well.
---
src/conf/domain_conf.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
Similarly to 790f912b4 which rejects snapshots names containing,
this commit changes virDomainSaveXML to reject domains with a '/'
in their name. The domain name is used as a filename, so this
leads to unexpected results when used in combination with '..'
---
If someone is using domains with '/'
QXL devices have an associated 'revision' which is raised when
new features have been introduced which would break migration
to older versions. This commit makes it possible to set this
revision as QEMU sometimes support newer QXL revisions than what
it defaults to.
---
docs/formatdomain.html.in
On Wed, Jan 23, 2013 at 03:41:56PM +0100, Martin Kletzander wrote:
On 12/14/2012 05:03 PM, Christophe Fergeau wrote:
This guarantees that the string will be nul-terminated. Coverity
warned about this issue.
---
libvirt-gobject/libvirt-gobject-connection.c | 2 +-
1 file changed, 1
On Tue, Jan 22, 2013 at 08:05:37PM +0100, Michal Privoznik wrote:
ACK if you squash this in:
Pushed series with this squashed in, thanks!
Christophe
pgp9c3ylgIKxY.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Dec 19, 2012 at 01:59:42PM +0100, Christophe Fergeau wrote:
Ping?
Time for another ping ;)
On Fri, Dec 14, 2012 at 05:03:37PM +0100, Christophe Fergeau wrote:
This guarantees that the string will be nul-terminated. Coverity
warned about this issue.
---
libvirt-gobject/libvirt
601 - 700 of 1510 matches
Mail list logo
