On Fri, May 11, 2012 at 01:32:34PM +0100, Daniel P. Berrange wrote:
If I look at the docs for GTK, I see GTK-DOC is including details of
the annotations:
eg
http://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-get-default-icon-list
Returns: copy of default icon list.
On Fri, May 11, 2012 at 04:23:05PM +0300, Zeeshan Ali (Khattak) wrote:
I don't exactly disagree with your assertions here but what you are
proposing is a local work-around. If this really is a big issue, we
have a major issue in all our gtk-doc/gir-using libraries.
This is what GTK+ is doing
Explain how the return value of the (transfer full) methods should
be freed. I also made some cosmetic changes in the API doc of some
of the files as I was modifying them.
---
libvirt-gconfig/libvirt-gconfig-domain-os.c| 11 ++-
libvirt-gconfig/libvirt-gconfig-domain.c | 28
On Wed, May 09, 2012 at 11:00:51PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 9, 2012 at 7:10 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+const gchar *
+gvir_config_capabilities_cpu_feature_get_name(GVirConfigCapabilitiesCpuFeature
*caps)
s/caps/feature
I
On Wed, May 09, 2012 at 11:44:24PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 9, 2012 at 5:54 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete
On Sat, May 05, 2012 at 02:46:31AM +0200, Marc-André Lureau wrote:
Allow to specify preallocation mode for QCOW2 images.
If not specified or not available, it's ignored.
This change only modify the schema, doc, parsing and tests.
---
docs/formatstorage.html.in |6 ++
On Wed, May 09, 2012 at 02:01:14PM +0200, Marc-André Lureau wrote:
Allow to specify preallocation mode for QCOW2 images.
If not specified or not available, it's ignored.
This change only modify the schema, doc, parsing and tests.
---
docs/formatstorage.html.in |6 ++
On Sat, May 05, 2012 at 02:46:32AM +0200, Marc-André Lureau wrote:
Use preallocation mode specified in volume XML format when running
qemu-img.
---
src/storage/storage_backend.c | 63
++---
1 file changed, 53 insertions(+), 10 deletions(-)
diff
On Thu, May 10, 2012 at 02:05:11PM +0100, Daniel P. Berrange wrote:
While I don't much fancy adding support for automatic
assignment with the companion controllers,
Fwiw, this would be useful to libvirt-glib too.
Christophe
pgpQmLYDyZFYk.pgp
Description: PGP signature
--
libvir-list
On Wed, May 09, 2012 at 11:00:51PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 9, 2012 at 7:10 PM, Christophe Fergeau cferg...@redhat.com
wrote:
This doesn't belong in this patch, feel free to sneak it in a patch
modifying -object.c
Marc-Andre would disagree but sure.
Ah, it's
On Wed, May 09, 2012 at 03:54:35AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
- gvir_config_object_add_child_with_type()
- gvir_config_object_get_child()
- gvir_config_object_get_child_with_type()
---
ACK
On Wed, May 09, 2012 at 03:54:36AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 18 ++
libvirt-gconfig/libvirt-gconfig-domain.h |1 +
libvirt-gconfig/libvirt-gconfig.sym |
On Wed, May 09, 2012 at 03:54:38AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-os.c | 45
+++
libvirt-gconfig/libvirt-gconfig-domain-os.h |1 +
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This changes gvir_config_object_attach_replace to accept a NULL
child object. Since we need to be able to find the node to remove
when this happens, gvir_config_object_attach_replace gets a third
argument with the name of the node to add/remove.
---
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This changes gvir_config_object_set_node_content to accept a NULL
content and to remove the corresponding node when this happens
---
libvirt-gconfig/libvirt-gconfig-domain-os.c| 20
in an action of contract,
+ * tort or otherwise, arising from, out of or in connection with the
+ * software or the use or other dealings in the Software.
+ *
+ * Authors: Zeeshan Ali zee...@redhat.com
+ * Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include
Hey,
I've split this patch in 2 to make it more digestable. First one is
unchanged and only contains the gvir_config_object_set_node_content
changes
The 2nd one only has the gvir_config_object_attach_replace changes,
and it has some changes: I reordered the parameter to _attach_replace to
make
On Thu, May 10, 2012 at 11:49:43PM +0300, Zeeshan Ali (Khattak) wrote:
On Thu, May 10, 2012 at 9:58 PM, Christophe Fergeau cferg...@redhat.com
wrote:
The 2nd one only has the gvir_config_object_attach_replace changes,
and it has some changes: I reordered the parameter to _attach_replace
On Sat, May 05, 2012 at 02:46:31AM +0200, Marc-André Lureau wrote:
Allow to specify preallocation mode for QCOW2 images.
If not specified or not available, it's ignored.
This change only modify the schema, doc, parsing and tests.
---
docs/formatstorage.html.in |6 ++
On Sat, May 05, 2012 at 02:46:32AM +0200, Marc-André Lureau wrote:
+if (vol-target.format != VIR_STORAGE_FILE_QCOW2 with_preallocation) {
+virStorageReportError(VIR_ERR_INTERNAL_ERROR,
+ _(Preallocation is only available with
qcow2));
+
On Wed, May 09, 2012 at 01:25:20PM +0200, Marc-André Lureau wrote:
On Wed, May 9, 2012 at 12:55 PM, Christophe Fergeau cferg...@redhat.com
wrote:
). I think it would be nicer to be consistent
with that for preallocation and not return an error either in this case.
I am not convinced
This does not seem to apply on top of master + PATCH 1/4 :-/
Christophe
On Wed, May 09, 2012 at 04:16:14AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am|
On Wed, May 09, 2012 at 04:16:13AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-capabilities.c |4 -
libvirt-gobject/libvirt-gobject-connection.c | 104
On Wed, May 09, 2012 at 04:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 9, 2012 at 4:17 PM, Christophe Fergeau cferg...@redhat.com
wrote:
This does not seem to apply on top of master + PATCH 1/4 :-/
Sorry, I forgot to mention this capabilities series is on top the
other changes
On Wed, May 09, 2012 at 04:16:15AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am|8 +
.../libvirt-gconfig-capabilities-guest-arch.c | 122
Hi,
There's still one bit I'm missing, here is my understanding so far:
On Thu, May 03, 2012 at 12:53:10PM +0100, Daniel P. Berrange wrote:
On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote:
Guest features (capabilities XML) - these are really just capabilities
Sorry, I messed up the quoting while reviewing this, hope it's fine with my
comments inline in the patch (looking for lines not starting with + should
show all my comments), sorry for the inconvenience.
diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am
index fd32c3d..54899a3
On Wed, May 09, 2012 at 05:01:25PM +0100, Daniel P. Berrange wrote:
Opps, no I was meaning /domain/cpu/feature here, which is the
same schem as /capabilities/host/cpu/feature.
Ah thanks, that clears things up.
I forgot there was also a /domain/features which corresponds
to
ACK
On Wed, May 09, 2012 at 03:54:34AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This function should set 'path' as attribute of 'source' node rather
than as child node.
---
.../libvirt-gconfig-domain-chardev-source-pty.c| 11 ---
1
On Fri, May 04, 2012 at 05:02:37AM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
+
+ gvir_config_xml_foreach_child(node, add_feature, data
I thought we had agreed to avoid the invasive patch complicating the common
path, and to just go with a new gvir_config_object_add_child_with_type?
This should probably even be get_child_with_type since when the needed node
is not present, we don't want to create a new empty node but we want to
On Fri, May 04, 2012 at 03:07:43AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 18 ++
libvirt-gconfig/libvirt-gconfig-domain.h |1 +
libvirt-gconfig/libvirt-gconfig.sym |5
On Fri, May 04, 2012 at 03:07:45AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-os.c | 44
+++
libvirt-gconfig/libvirt-gconfig-domain-os.h |1 +
On Fri, May 04, 2012 at 03:07:44AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Passing a 'NULL' value now deletes the corresponding node/tree.
---
.../libvirt-gconfig-domain-chardev-source-pty.c|6 ++
.../libvirt-gconfig-domain-controller.c
Hey,
On Wed, May 02, 2012 at 01:49:42PM -0400, William Jon McCann wrote:
Hi,
On Wed, May 2, 2012 at 6:26 AM, Christophe Fergeau cferg...@redhat.com
wrote:
Hey,
On Mon, Apr 30, 2012 at 02:55:06PM -0400, William Jon McCann wrote:
This has a number of advantages for us
On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau cferg...@redhat.com
wrote:
What would be these getters apart from the already existing _get_name?
The features under 'guest' can have boolean attributes, 'default
Hey,
On Mon, Apr 30, 2012 at 02:55:06PM -0400, William Jon McCann wrote:
This has a number of advantages for us:
It allows sharing a home directory between different machines, or
sessions (eg. using NFS)
Supports performing smart or selective migration of settings
between different
What happens when some parameters are not listed/when some blank lines are
missing? Does it output a warning, or abort?
Also, one oddity below,
Christophe
On Tue, May 01, 2012 at 08:30:27PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
ACK on this one, dunno if we'll want an async variant of this.
Christophe
On Tue, May 01, 2012 at 08:30:38PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-capabilities.c |4 ---
On Wed, May 02, 2012 at 05:17:19PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau cferg...@redhat.com
wrote:
I'm a bit surprised that here you add a @err annotation, but further down
the patch you rename some @err to @error. Was the renaming
On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am| 11 ++-
...virt-gconfig-capabilities-cpu-feature-private.h | 39
A few quick comments, I'll review it more deeply later,
On Tue, May 01, 2012 at 08:30:40PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Not quite complete but its a good start.
---
libvirt-gconfig/Makefile.am| 11 ++-
On Mon, Apr 30, 2012 at 12:56:05PM -0600, Eric Blake wrote:
On 04/30/2012 12:43 PM, Jason Helfman wrote:
Ok, but having the same download path is just as confusing, as it looks
like
an update to 0.9.11, when it is a different release.
But for all intents and purposes, it IS an update to
On Wed, May 02, 2012 at 06:35:07PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Having a per-feature GVirConfigObject seems overkill since it will
only be a string wrapper, and a GVirConfigObject wrapping just a string
Ping?
Christophe
On Fri, Apr 13, 2012 at 05:20:14PM +0200, Christophe Fergeau wrote:
Specialized timer classes will inherit from it
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 22 +-
libvirt-gconfig/libvirt-gconfig-domain-timer.h |4
libvirt-gconfig
---
.../libvirt-gconfig-domain-controller-usb.c| 119 +++-
1 file changed, 118 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c
b/libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c
index 8ab3e25..1fd248c 100644
---
It was missing most classes in the GVirConfig namespace.
---
docs/libvirt-gconfig/Libvirt-gconfig-docs.xml | 67 ++---
1 file changed, 60 insertions(+), 7 deletions(-)
diff --git a/docs/libvirt-gconfig/Libvirt-gconfig-docs.xml
, Christophe Fergeau cferg...@redhat.com
wrote:
It was missing most classes in the GVirConfig namespace.
---
docs/libvirt-gconfig/Libvirt-gconfig-docs.xml | 67
++---
1 file changed, 60 insertions(+), 7 deletions(-)
diff --git a/docs/libvirt-gconfig/Libvirt-gconfig
On Thu, Apr 19, 2012 at 03:12:01AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 74
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
On Thu, Apr 19, 2012 at 04:24:35PM +0300, Zeeshan Ali (Khattak) wrote:
On Thu, Apr 19, 2012 at 11:52 AM, Christophe Fergeau
cferg...@redhat.com wrote:
On Thu, Apr 19, 2012 at 03:12:01AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
+static void
On Thu, Apr 19, 2012 at 04:45:29PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 74
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
ACK
Christophe
On Thu, Apr 19, 2012 at 05:17:04PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-domain.c | 80
++
libvirt-gobject/libvirt-gobject-domain.h |7 +++
Update gvir_config_domain_device_new_from_tree to handle
GVirConfigDomainController nodes
---
.../libvirt-gconfig-domain-controller.c| 37
.../libvirt-gconfig-domain-device-private.h|3 ++
libvirt-gconfig/libvirt-gconfig-domain-device.c|2 +-
Update gvir_config_domain_device_new_from_tree to handle
GVirConfigDomainRedirdev nodes
---
libvirt-gconfig/libvirt-gconfig-domain-device.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-device.c
Hey,
I've just pushed these 2 documentation patches under the trivial rule.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
docs/formatdomain.html.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bb67cd1..e08a3d2 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -359,7 +359,7 @@
0.8.5/span, the
'omitted' was mispelt 'commited' twice. One of the sentences with
the typo was also missing an 'is' ('each VCPU *is* pinned to all...')
which I added in this commit while I was at it.
---
docs/formatdomain.html.in |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On Thu, Apr 12, 2012 at 12:08:42PM +0200, Guido Günther wrote:
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
On Thu, Apr 12, 2012 at 11:50:30PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
libvirt-gconfig/libvirt-gconfig-domain-disk.h |9
On Fri, Apr 13, 2012 at 04:41:32PM +0300, Zeeshan Ali (Khattak) wrote:
On Fri, Apr 13, 2012 at 2:26 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Apr 12, 2012 at 11:50:30PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 26
libvirt-gconfig/libvirt-gconfig-domain-timer.h |9
libvirt-gconfig/libvirt-gconfig.sym|3 +++
3 files changed, 38 insertions(+)
diff --git
---
libvirt-gconfig/libvirt-gconfig-domain-clock.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-clock.h |4
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-clock.c
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_TIMER_RTC_GET_PRIVATE
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
Specialized timer classes will inherit from it
---
libvirt-gconfig/libvirt-gconfig-domain-timer.c | 22 +-
libvirt-gconfig/libvirt-gconfig-domain-timer.h |4
libvirt-gconfig/libvirt-gconfig.sym|2 --
3 files changed, 1 insertion(+), 27 deletions(-)
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
With respect to hypervisors, since the function has a GVirConfigDomain
parameter, we could use it
On Wed, Apr 11, 2012 at 06:51:48PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 6:19 PM, Daniel P. Berrange berra...@redhat.com
wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
This is a
Hey,
On Thu, Apr 12, 2012 at 05:54:25AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain-disk.c | 26
+
libvirt-gconfig/libvirt-gconfig-domain-disk.h |9
On Thu, Apr 12, 2012 at 12:06:52PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 03:48:09PM +0200, Christophe Fergeau wrote:
[..snip..]
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -69,6 +69,8 @@ LIBVIRT_GCONFIG_0.0.4
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
---
If this looks correct I'll have a look at libvirt-glib and
libvirt-gobject
On Wed, Apr 11, 2012 at 10:24:42AM +0100, Daniel P. Berrange wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered
On Fri, Apr 06, 2012 at 02:51:35PM +0200, Christophe Fergeau wrote:
Hey,
This patch series adds the needed classes for apps to be able to
use USB redirection. I've followed
http://hansdegoede.livejournal.com/11084.html and added all the API needed
to be able to get the same XML. However
Hey,
Here is the second version of the patch series implementing USB controller
support in libvirt-gconfig. There's a bug fixed in
GVirConfigDomainAddressUsb creation (type=usb was missing) as well as a
few small bug fixes/changes in the test program. I also added an additional
patch implementing
to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_CONTROLLER_GET_PRIVATE(obj
---
libvirt-gconfig/libvirt-gconfig-domain-controller-usb.c | 13 +
libvirt-gconfig/libvirt-gconfig-domain-controller-usb.h | 15 +++
libvirt-gconfig/libvirt-gconfig.sym |2 ++
3 files changed, 30 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 21
.../libvirt-gconfig-domain-controller-usb.h|3 +++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 25 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller.c| 29
.../libvirt-gconfig-domain-controller.h|4 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 35 insertions(+)
diff --git
---
libvirt-gconfig/libvirt-gconfig-domain-redirdev.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-redirdev.h |2 ++
libvirt-gconfig/libvirt-gconfig.sym |1 +
3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-redirdev.c
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_USB_GET_PRIVATE(obj
---
libvirt-gconfig/tests/test-domain-create.c | 46 +++-
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index cdee883..b6d8813 100644
---
---
libvirt-gconfig/tests/test-domain-create.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 4ee33aa..7be9fc2 100644
--- a/libvirt-gconfig/tests/test-domain-create.c
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_GET_PRIVATE(obj
---
libvirt-gconfig/tests/test-domain-create.c | 54 +++-
1 file changed, 38 insertions(+), 16 deletions(-)
diff --git a/libvirt-gconfig/tests/test-domain-create.c
b/libvirt-gconfig/tests/test-domain-create.c
index 7be9fc2..cdee883 100644
---
---
libvirt-gconfig/libvirt-gconfig-domain-controller.c | 10 ++
libvirt-gconfig/libvirt-gconfig-domain-controller.h |2 ++
libvirt-gconfig/libvirt-gconfig.sym |1 +
3 files changed, 13 insertions(+)
diff --git
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
This function is a helper function which adds all the needed devices
for working USB support in the guest. This can be done manually, but
is a bit tedious, hence this helper.
---
libvirt-gconfig/libvirt-gconfig-domain.c | 41
On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau cferg...@redhat.com
wrote:
What would _USB2 do? Add an _EHCI controller, plus either
_PIIX3_UHCI or _PIIX4_UHCI?
From what I remember Hans told me, all the 4 ehci + uhci
On Wed, Apr 11, 2012 at 05:19:33PM +0100, Daniel P. Berrange wrote:
The concept of 'default usb controllers' seems very policy based
to me different hypervisors will have different views of this.
So IMHO we should not add this API
I'm fine with dropping the patch. My feeling was that this
On Wed, Apr 11, 2012 at 04:29:28PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 3:48 PM, Christophe Fergeau cferg...@redhat.com
wrote:
+void gvir_config_domain_setup_default_usb_controllers(GVirConfigDomain
*domain)
I suggest it takes an enum
Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define
---
.../libvirt-gconfig-domain-controller.c| 10 ++
.../libvirt-gconfig-domain-controller.h|2 ++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-controller.c
Hey,
This patch series adds the needed classes for apps to be able to
use USB redirection. I've followed
http://hansdegoede.livejournal.com/11084.html and added all the API needed
to be able to get the same XML. However, I'm not 100% sure all these
attributes are required, in particular the
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_CONTROLLER_GET_PRIVATE(obj
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_GET_PRIVATE(obj
---
.../libvirt-gconfig-domain-controller.c| 29
.../libvirt-gconfig-domain-controller.h|4 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 35 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 21
.../libvirt-gconfig-domain-controller-usb.h|3 +++
libvirt-gconfig/libvirt-gconfig.sym|1 +
3 files changed, 25 insertions(+)
diff --git
---
.../libvirt-gconfig-domain-controller-usb.c| 13 +
.../libvirt-gconfig-domain-controller-usb.h| 15 +++
libvirt-gconfig/libvirt-gconfig.sym|2 ++
3 files changed, 30 insertions(+)
diff --git
, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Christophe Fergeau cferg...@redhat.com
+ */
+
+#include config.h
+
+#include libvirt-gconfig/libvirt-gconfig.h
+#include libvirt-gconfig/libvirt-gconfig-private.h
+
+#define GVIR_CONFIG_DOMAIN_ADDRESS_USB_GET_PRIVATE(obj
901 - 1000 of 1510 matches
Mail list logo
