Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-22 Thread Cornelia Huck
On Wed, May 17 2023, Andrea Bolognani wrote: > On Wed, May 17, 2023 at 11:19:17AM +0200, Cornelia Huck wrote: >> This has been through some iterations... we (as in people working on >> this in QEMU) need to decide on where to go with cpu features, cpu >> models, etc. on A

Re: [libvirt PATCH 0/4] Revert MTE support

2023-05-22 Thread Cornelia Huck
data/aarch64-gic-v3.args| 2 +- > tests/qemuxml2argvdata/aarch64-gic-v3.xml | 1 - > .../aarch64-gic-v3.aarch64-latest.xml | 1 - > 16 files changed, 10 insertions(+), 53 deletions(-) FWIW, Reviewed-by: Cornelia Huck

Re: [PATCH 0/4] Introduce ARM MTE feature

2023-05-17 Thread Cornelia Huck
On Wed, May 17 2023, Michal Prívozník wrote: > On 5/16/23 18:32, Andrea Bolognani wrote: >> On Tue, May 16, 2023 at 12:54:12PM +0200, Michal Privoznik wrote: >>> Michal Prívozník (4): >>> conf: Introduce MTE domain feature >>> qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability >>>

Re: [PATCH] virttools-planet: update location of Cornelia's blog

2021-11-02 Thread Cornelia Huck
On Tue, Nov 02 2021, Daniel P. Berrangé wrote: > On Tue, Nov 02, 2021 at 12:10:42PM +0100, Cornelia Huck wrote: >> Signed-off-by: Cornelia Huck >> --- >> virt-tools/config.ini | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --g

[PATCH] virttools-planet: update location of Cornelia's blog

2021-11-02 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- virt-tools/config.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt-tools/config.ini b/virt-tools/config.ini index f56495a26fd8..89b4e5ae6f91 100644 --- a/virt-tools/config.ini +++ b/virt-tools/config.ini @@ -162,7 +162,7 @@ name

Re: [PATCH 2/2] docs/about: Unify the subject format

2021-08-20 Thread Cornelia Huck
> 2 files changed, 42 insertions(+), 42 deletions(-) Unrelated to your patch, line 143 in removed-features.rst reads ``-vnc ...,tls=...``, ``-vnc ...,x509=...`` & ``-vnc ...,x509verify=...`` and is missing the release it was removed in (presumably 3.1?) Anyway, Reviewed-by: Cornelia Huck

Re: [libvirt PATCH v3 00/21] Add support for persistent mediated devices

2021-02-05 Thread Cornelia Huck
On Tue, 2 Feb 2021 08:28:52 +0100 Erik Skultety wrote: > On Mon, Feb 01, 2021 at 04:38:56PM -0700, Alex Williamson wrote: > > On Mon, 1 Feb 2021 16:57:44 -0600 > > Jonathon Jongsma wrote: > > > > > On Mon, 1 Feb 2021 11:33:08 +0100 > > > Erik Skultety wrote: > > > > > > > On Mon, Feb 01,

Re: [PATCH v2] docs: Clarify the documentation of the elements

2021-01-29 Thread Cornelia Huck
>cssid >The channel subsystem identifier. >ssid >The subchannel-set identifier. >devno > - The device number. > + The subchannel number. > capability > > This optional element can occur multiple times. If it Reviewed-by: Cornelia Huck

Re: [PATCH] docs: Clarify the documentation of the elements

2021-01-29 Thread Cornelia Huck
On Fri, 29 Jan 2021 11:04:44 +0100 Thomas Huth wrote: > The channel subsystem elements describe a channel in the I/O subsystem > of a s390x machine, and not a normal device (like a disk or network card). > Reword the documentation here to make it this a little bit clearer. > > Buglink:

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-04 Thread Cornelia Huck
On Fri, 4 Dec 2020 16:31:56 +0100 Boris Fiuczynski wrote: > On 12/4/20 11:24 AM, Erik Skultety wrote: > > On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja > > wrote: > >> Add support for AP card devices, AP queues and AP matrix devices in > >> libvirt node device driver.

Re: [PATCH v1 05/26] qemu_domain_address: Reformat qemuDomainAssignS390Addresses()

2020-11-30 Thread Cornelia Huck
On Mon, 30 Nov 2020 11:18:20 +0100 Michal Privoznik wrote: > On 11/30/20 10:38 AM, Thomas Huth wrote: > > On 27/11/2020 16.02, Michal Privoznik wrote: > >> Signed-off-by: Michal Privoznik > >> --- > >> src/qemu/qemu_domain_address.c | 10 -- > >> 1 file changed, 4 insertions(+), 6

Re: [PATCH 3/3] domain_conf: Allow to look up scsi disks when controller uses a CCW address

2020-11-27 Thread Cornelia Huck
On Wed, 25 Nov 2020 12:06:48 +0100 Thomas Huth wrote: > On s390x, devices are attached to the channel IO subsytem by default, s/attached to the channel IO subsystem/accessed via the channel subsystem/ > so we need to look up scsi controllers via their CCW address there > instead of using PCI.

Re: [PATCH 2/3] domain_conf: Allow to look up virtio-block devices by their CCW address

2020-11-27 Thread Cornelia Huck
files changed, 16 insertions(+), 4 deletions(-) Keeping my limited libvirt knowledge in mind: Reviewed-by: Cornelia Huck

Re: [PATCH 1/3] qemu: agent: Store CCW address in qemuAgentDiskInfo if provided by the guest

2020-11-27 Thread Cornelia Huck
On Wed, 25 Nov 2020 12:06:46 +0100 Thomas Huth wrote: > Newer versions of the QEMU guest agent will provide the CCW address > of devices on s390x. Store this information in the qemuAgentDiskInfo > so that we can use this later. > > We also map the CSSID 0 from the guest to the value 0xfe on the

Availability of physical devices and migration (was: Re: [RFC PATCH 2/2] vfio-ccw: Connect the device request notifier)

2020-11-20 Thread Cornelia Huck
On Fri, 20 Nov 2020 03:51:07 +0100 Halil Pasic wrote: > On Tue, 17 Nov 2020 04:26:05 +0100 > Eric Farman wrote: > > > Now that the vfio-ccw code has a notifier interface to request that > > a device be unplugged, let's wire that together. > > I'm aware of the fact that performing an unplug

Re: [PATCH] news: Mention nodedev support for CSS on S390

2020-10-27 Thread Cornelia Huck
diated devices with > +``virNodeDeviceCreateXML()``. > + >* qemu: Implement memory failure event > > New event is implemented that is emitted whenever a guest encounters a Reviewed-by: Cornelia Huck

[PATCH] virDomainNetFindIdx: add support for CCW addresses

2020-09-24 Thread Cornelia Huck
Allow to match with CCW addresses in addition to PCI addresses (and MAC addresses). Signed-off-by: Cornelia Huck --- src/conf/device_conf.c | 12 src/conf/device_conf.h | 3 +++ src/conf/domain_conf.c | 23 ++- src/libvirt_private.syms | 1 + 4 files

Re: [PATCH v2] cphp: remove deprecated cpu-add command(s)

2020-09-14 Thread Cornelia Huck
rtio-ccw.c | 12 - > qapi/machine.json | 24 - > tests/qtest/cpu-plug-test.c | 100 > tests/qtest/test-hmp.c | 1 - > 13 files changed, 21 insertions(+), 211 deletions(-) Acked-by: Cornelia Huck

Re: device compatibility interface for live migration with assigned devices

2020-09-11 Thread Cornelia Huck
On Fri, 11 Sep 2020 08:56:00 +0800 Yan Zhao wrote: > On Thu, Sep 10, 2020 at 12:02:44PM -0600, Alex Williamson wrote: > > On Thu, 10 Sep 2020 13:50:11 +0100 > > Sean Mooney wrote: > > > > > On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote: > > &

Re: device compatibility interface for live migration with assigned devices

2020-09-10 Thread Cornelia Huck
On Wed, 9 Sep 2020 10:13:09 +0800 Yan Zhao wrote: > > > still, I'd like to put it more explicitly to make ensure it's not missed: > > > the reason we want to specify compatible_type as a trait and check > > > whether target compatible_type is the superset of source > > > compatible_type is for

Re: [PATCH 5/5] node_device: mdev vfio-ccw support

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 14:40:33 +0200 Erik Skultety wrote: > On Wed, Sep 09, 2020 at 08:23:39AM +0200, Bjoern Walk wrote: > > Erik Skultety [2020-09-08, 06:01PM +0200]: > > > On Mon, Aug 24, 2020 at 01:59:15PM +0200, Bjoern Walk wrote: > > > > From: Boris Fiuczynski > > > > +case

Re: [PATCH 2/5] node_device: detect CSS devices

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 14:46:00 +0200 Erik Skultety wrote: > > > > Are ^these attributes documented a little more somewhere? I didn't find > > > > those > > > > in [1]. I suppose it is available in the z/Architecture: Principles of > > > > [BTW: what are [1] and [2] referring to?] > >

Re: [PATCH 2/5] node_device: detect CSS devices

2020-09-09 Thread Cornelia Huck
On Wed, 9 Sep 2020 08:18:08 +0200 Bjoern Walk wrote: > Erik Skultety [2020-09-08, 05:46PM +0200]: > > On Mon, Aug 24, 2020 at 01:59:12PM +0200, Bjoern Walk wrote: > > > From: Boris Fiuczynski > > > > > > Make channel subsystem (CSS) devices available in the node_device > > > driver.o > >

Re: device compatibility interface for live migration with assigned devices

2020-09-08 Thread Cornelia Huck
On Mon, 31 Aug 2020 12:43:44 +0800 Yan Zhao wrote: > On Fri, Aug 28, 2020 at 03:04:12PM +0100, Sean Mooney wrote: > > On Fri, 2020-08-28 at 15:47 +0200, Cornelia Huck wrote: > > > On Wed, 26 Aug 2020 14:41:17 +0800 > > > Yan Zhao wrote: > > > > >

Re: device compatibility interface for live migration with assigned devices

2020-08-28 Thread Cornelia Huck
On Wed, 26 Aug 2020 14:41:17 +0800 Yan Zhao wrote: > previously, we want to regard the two mdevs created with dsa-1dwq x 30 and > dsa-2dwq x 15 as compatible, because the two mdevs consist equal resources. > > But, as it's a burden to upper layer, we agree that if this condition > happens, we

Re: device compatibility interface for live migration with assigned devices

2020-08-25 Thread Cornelia Huck
On Thu, 20 Aug 2020 11:16:21 +0800 Yan Zhao wrote: > On Wed, Aug 19, 2020 at 09:22:34PM -0600, Alex Williamson wrote: > > On Thu, 20 Aug 2020 08:39:22 +0800 > > Yan Zhao wrote: > > > > > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote: > &

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-21 Thread Cornelia Huck
On Fri, 21 Aug 2020 11:14:41 +0800 Jason Wang wrote: > On 2020/8/20 下午8:27, Cornelia Huck wrote: > > On Wed, 19 Aug 2020 17:28:38 +0800 > > Jason Wang wrote: > > > >> On 2020/8/19 下午4:13, Yan Zhao wrote: > >>> On Wed, Aug 19, 2020 at 03:39:50PM +080

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-20 Thread Cornelia Huck
On Wed, 19 Aug 2020 17:28:38 +0800 Jason Wang wrote: > On 2020/8/19 下午4:13, Yan Zhao wrote: > > On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: > >> On 2020/8/19 下午2:59, Yan Zhao wrote: > >>> On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: > On 2020/8/19

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:24:33 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:06:17AM +0200, Cornelia Huck wrote: > > On Tue, 18 Aug 2020 09:55:27 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 10:16:28 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: > >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: > > > > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > > > On 2020/8/14 下午1:16, Yan Zhao wrote: >

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 09:55:27 +0100 Daniel P. Berrangé wrote: > On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote: > > Another point, as we discussed in another thread, it's really hard to make > > sure the above API work for all types of devices and frameworks. So having a > > vendor

Re: device compatibility interface for live migration with assigned devices

2020-08-17 Thread Cornelia Huck
On Thu, 13 Aug 2020 15:02:53 -0400 Eric Farman wrote: > On 8/13/20 11:33 AM, Cornelia Huck wrote: > > On Fri, 7 Aug 2020 13:59:42 +0200 > > Cornelia Huck wrote: > > > >> On Wed, 05 Aug 2020 12:35:01 +0100 > >> Sean Mooney wrote: > >> >

Re: device compatibility interface for live migration with assigned devices

2020-08-13 Thread Cornelia Huck
On Fri, 7 Aug 2020 13:59:42 +0200 Cornelia Huck wrote: > On Wed, 05 Aug 2020 12:35:01 +0100 > Sean Mooney wrote: > > > On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote: > > > Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote: > > (...)

Re: device compatibility interface for live migration with assigned devices

2020-08-07 Thread Cornelia Huck
On Wed, 05 Aug 2020 12:35:01 +0100 Sean Mooney wrote: > On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote: > > Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote: (...) > > >software_version: device driver's version. > > > in .[.bugfix] scheme, where there

Re: device compatibility interface for live migration with assigned devices

2020-08-04 Thread Cornelia Huck
[sorry about not chiming in earlier] On Wed, 29 Jul 2020 16:05:03 +0800 Yan Zhao wrote: > On Mon, Jul 27, 2020 at 04:23:21PM -0600, Alex Williamson wrote: (...) > > Based on the feedback we've received, the previously proposed interface > > is not viable. I think there's agreement that the

Re: [PATCH v2 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
12 insertions(+), 10 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 13:29:43 +0200 Boris Fiuczynski wrote: > On 4/17/20 11:02 AM, Cornelia Huck wrote: > > On Fri, 17 Apr 2020 10:50:02 +0200 > > Boris Fiuczynski wrote: > > > >> On 4/16/20 6:14 PM, Cornelia Huck wrote: > >>> On Thu, 16 Apr 2020 17

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 05:52:02 -0400 Yan Zhao wrote: > On Fri, Apr 17, 2020 at 04:44:50PM +0800, Cornelia Huck wrote: > > On Mon, 13 Apr 2020 01:52:01 -0400 > > Yan Zhao wrote: > > > > > This patchset introduces a migration_version attribute under sysfs

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2020 10:50:02 +0200 Boris Fiuczynski wrote: > On 4/16/20 6:14 PM, Cornelia Huck wrote: > > On Thu, 16 Apr 2020 17:56:18 +0200 > > Boris Fiuczynski wrote: > > > >> Improving the zPCI example by choosing more distinct values and > >> addin

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-17 Thread Cornelia Huck
On Mon, 13 Apr 2020 01:52:01 -0400 Yan Zhao wrote: > This patchset introduces a migration_version attribute under sysfs of VFIO > Mediated devices. > > This migration_version attribute is used to check migration compatibility > between two mdev devices. > > Currently, it has two locations: >

Re: [PATCH 2/2] docs: Improve zPCI section in pci-addresses.rst

2020-04-16 Thread Cornelia Huck
On Thu, 16 Apr 2020 17:56:18 +0200 Boris Fiuczynski wrote: > Improving the zPCI example by choosing more distinct values and > adding explanation for fid. > > Signed-off-by: Boris Fiuczynski > --- > docs/pci-addresses.rst | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-)

Re: [PATCH 1/2] docs: Update introduction in pci-addresses.rst

2020-04-16 Thread Cornelia Huck
hat each PCI device would show up in the guest OS with > +a PCI address that matches the one present in the corresponding > + element of the domain XML, but that's not guaranteed > +to happen and will in fact not be the case in all but the simplest > +scenarios. > > > Simpl

Re: [libvirt PATCH 4/4] docs: Remove one example from pci-addresses.rst

2020-04-16 Thread Cornelia Huck
On Thu, 16 Apr 2020 09:28:58 +0200 Andrea Bolognani wrote: > On Wed, 2020-04-15 at 19:47 +0200, Cornelia Huck wrote: > > On Wed, 15 Apr 2020 19:31:36 +0200 > > Andrea Bolognani wrote: > > > -Therefore, replacing the virtio-net device definition with the following

Re: [libvirt PATCH 4/4] docs: Remove one example from pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:36 +0200 Andrea Bolognani wrote: > The idea behind this document is to show, with actual examples, > that users should not expect PCI addresses in the domain XML and > in the guest OS to match. > > The first zPCI example already serves this purpose perfectly, so > in

Re: [libvirt PATCH 3/4] docs: Remove MAC addresses from pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 19:31:35 +0200 Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/pci-addresses.rst | 2 -- > 1 file changed, 2 deletions(-) Yeah, not that useful. Reviewed-by: Cornelia Huck

Re: [libvirt PATCH 1/4] docs: Use consistent style in pci-addresses.rst

2020-04-15 Thread Cornelia Huck
> --- > docs/pci-addresses.rst | 60 ++ > 1 file changed, 32 insertions(+), 28 deletions(-) Reviewed-by: Cornelia Huck

Re: [libvirt PATCH 2/4] docs: Move sections around in pci-addresses.rst

2020-04-15 Thread Cornelia Huck
ni > --- > docs/pci-addresses.rst | 57 +- > 1 file changed, 28 insertions(+), 29 deletions(-) Not including a 'wonky cases' category is fine with me :) Reviewed-by: Cornelia Huck

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 18:38:06 +0200 Andrea Bolognani wrote: > On Wed, 2020-04-15 at 16:45 +0200, Cornelia Huck wrote: > > On Wed, 15 Apr 2020 16:23:46 +0200 > > Boris Fiuczynski wrote: > > > Once I understand you confusion above I will provide a patch... > &

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Wed, 15 Apr 2020 16:23:46 +0200 Boris Fiuczynski wrote: > On 4/15/20 3:42 PM, Cornelia Huck wrote: > > On Tue, 14 Apr 2020 23:06:47 +0200 > > Boris Fiuczynski wrote: > > > >> On 4/15/20 12:51 PM, Cornelia Huck wrote: > >>> +In th

Re: [PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Tue, 14 Apr 2020 23:06:47 +0200 Boris Fiuczynski wrote: > On 4/15/20 12:51 PM, Cornelia Huck wrote: > > +zPCI addresses > > +== > > + > > +For s390x machines, PCI addresses are handled yet differently. No > > +topology information is rela

[PATCH] docs: add zpci information to pci-addresses.rst

2020-04-15 Thread Cornelia Huck
Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck --- docs/pci-addresses.rst | 63 ++ 1 file changed, 63 insertions(+) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 923783a151b0..9e241a24fcfb 100644

Re: [libvirt PATCH] docs: Add pci-addresses.rst

2020-04-15 Thread Cornelia Huck
On Tue, 14 Apr 2020 19:53:05 +0200 Andrea Bolognani wrote: > This document describes the relationship between PCI addresses as > seen in the domain XML and by the guest OS, which is a topic that > people get confused by time and time again. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] libvirt mdev migration, mdevctl integration

2019-12-10 Thread Cornelia Huck
On Tue, 10 Dec 2019 10:36:36 + Daniel P. Berrangé wrote: > On Tue, Dec 10, 2019 at 11:24:44AM +0100, Cornelia Huck wrote: > > On Tue, 10 Dec 2019 10:09:34 + > > Daniel P. Berrangé wrote: > > > > > On Mon, Dec 09, 2019 at 02:23:38PM -0600, Jonathon Jo

Re: [libvirt] libvirt mdev migration, mdevctl integration

2019-12-10 Thread Cornelia Huck
On Tue, 10 Dec 2019 10:09:34 + Daniel P. Berrangé wrote: > On Mon, Dec 09, 2019 at 02:23:38PM -0600, Jonathon Jongsma wrote: > > mdevctl also supports assigning arbitrary sysfs attributes to a device. > > These attributes have an explicit ordering and are written to sysfs in > > the

Re: [libvirt] libvirt mdev migration, mdevctl integration

2019-11-26 Thread Cornelia Huck
On Tue, 26 Nov 2019 10:54:59 +0100 Boris Fiuczynski wrote: > On 11/25/19 6:14 PM, Cornelia Huck wrote: > > Also, I'm wondering if we need special care for vfio-ap, although I'm > > not sure if it is feasible to add migration support for it all. We > > currently have a matri

Re: [libvirt] libvirt mdev migration, mdevctl integration

2019-11-26 Thread Cornelia Huck
On Mon, 25 Nov 2019 17:47:26 + Daniel P. Berrangé wrote: > On Mon, Nov 25, 2019 at 06:14:33PM +0100, Cornelia Huck wrote: > > On Mon, 18 Nov 2019 19:00:25 + > > Daniel P. Berrangé wrote: > > > > > On Mon, Nov 18, 2019 at 10:06:34AM -0700, Alex William

Re: [libvirt] libvirt mdev migration, mdevctl integration

2019-11-25 Thread Cornelia Huck
On Mon, 18 Nov 2019 19:00:25 + Daniel P. Berrangé wrote: > On Mon, Nov 18, 2019 at 10:06:34AM -0700, Alex Williamson wrote: > > Hey folks, > > > > We had some discussions at KVM Forum around mdev live migration and > > what that might mean for libvirt handling of mdev devices and > >

Re: [libvirt] [PATCH 0/6] VFIO mdev aggregated resources handling

2019-11-07 Thread Cornelia Huck
On Wed, 6 Nov 2019 11:44:40 -0700 Alex Williamson wrote: > On Wed, 6 Nov 2019 12:20:31 +0800 > Zhenyu Wang wrote: > > > On 2019.11.05 14:10:42 -0700, Alex Williamson wrote: > > > On Thu, 24 Oct 2019 13:08:23 +0800 > > > Zhenyu Wang wrote: > > > > > > > Hi, > > > > > > > > This is a

Re: [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-18 Thread Cornelia Huck
On Tue, 17 Sep 2019 14:02:59 +0100 Stefan Hajnoczi wrote: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, and

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-07-01 Thread Cornelia Huck
On Mon, 1 Jul 2019 08:40:51 -0600 Alex Williamson wrote: > On Mon, 1 Jul 2019 10:20:43 +0200 > Cornelia Huck wrote: > > > On Fri, 28 Jun 2019 11:05:46 -0600 > > Alex Williamson wrote: > > > > > On Fri, 28 Jun 2019 11:06:48 +0200 > > > Corneli

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-07-01 Thread Cornelia Huck
On Fri, 28 Jun 2019 11:05:46 -0600 Alex Williamson wrote: > On Fri, 28 Jun 2019 11:06:48 +0200 > Cornelia Huck wrote: > > What do you think of a way to specify JSON for the attributes directly > > on the command line? Or would it be better to just edit the config

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-28 Thread Cornelia Huck
On Thu, 27 Jun 2019 19:57:04 -0600 Alex Williamson wrote: > On Thu, 27 Jun 2019 15:15:02 -0600 > Alex Williamson wrote: > > > On Thu, 27 Jun 2019 09:38:32 -0600 > > Alex Williamson wrote: > > > > On 6/27/19 8:26 AM, Cornelia Huck wrote: > > &

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-27 Thread Cornelia Huck
On Wed, 26 Jun 2019 19:53:50 -0600 Alex Williamson wrote: > On Wed, 26 Jun 2019 08:37:20 -0600 > Alex Williamson wrote: > > > On Wed, 26 Jun 2019 11:58:06 +0200 > > Cornelia Huck wrote: > > > > > On Tue, 25 Jun 2019 16:52:51 -0600 > > >

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-26 Thread Cornelia Huck
On Tue, 25 Jun 2019 16:52:51 -0600 Alex Williamson wrote: > Hi, > > Based on the discussions we've had, I've rewritten the bulk of > mdevctl. I think it largely does everything we want now, modulo > devices that will need some sort of 1:N values per key for > configuration in the config file

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-19 Thread Cornelia Huck
On Wed, 19 Jun 2019 11:04:15 +0200 Sylvain Bauza wrote: > On Wed, Jun 19, 2019 at 12:27 AM Alex Williamson > wrote: > > > On Tue, 18 Jun 2019 14:48:11 +0200 > > Sylvain Bauza wrote: > > > > > On Tue, Jun 18, 2019 at 1:01 PM Cornelia Huck wrote: > &

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-19 Thread Cornelia Huck
On Wed, 19 Jun 2019 08:28:02 +0100 Daniel P. Berrangé wrote: > On Tue, Jun 18, 2019 at 04:12:10PM -0600, Alex Williamson wrote: > > On Tue, 18 Jun 2019 14:48:11 +0200 > > Sylvain Bauza wrote: > > > > > On Tue, Jun 18, 2019 at 1:01 PM Cornelia Huck wrote: &g

Re: [libvirt] [PATCH RFC 1/1] allow to specify additional config data

2019-06-18 Thread Cornelia Huck
On Thu, 6 Jun 2019 10:15:52 -0600 Alex Williamson wrote: > On Thu, 6 Jun 2019 09:32:24 -0600 > Alex Williamson wrote: > > > On Thu, 6 Jun 2019 16:44:17 +0200 > > Cornelia Huck wrote: > > > > > Add a rough implementation for vfio-ap. >

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-18 Thread Cornelia Huck
On Mon, 17 Jun 2019 11:05:17 -0600 Alex Williamson wrote: > On Mon, 17 Jun 2019 16:10:30 +0100 > Daniel P. Berrangé wrote: > > > On Mon, Jun 17, 2019 at 08:54:38AM -0600, Alex Williamson wrote: > > > On Mon, 17 Jun 2019 15:00:00 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-17 Thread Cornelia Huck
On Fri, 14 Jun 2019 10:04:18 -0600 Alex Williamson wrote: > On Fri, 14 Jun 2019 17:06:15 +0200 > Christophe de Dinechin wrote: > > > > On 14 Jun 2019, at 16:23, Alex Williamson > > > wrote: > > > > > > On Fri, 14 Jun 2019 11:54:42 +0200 > > > Christophe de Dinechin wrote: > > > Where is

Re: [libvirt] [PATCH RFC 1/1] allow to specify additional config data

2019-06-13 Thread Cornelia Huck
9:32:24 -0600 > >>> Alex Williamson wrote: > >>> > >>>> On Thu, 6 Jun 2019 16:44:17 +0200 > >>>> Cornelia Huck wrote: > >>>> > >>>>> Add a rough implementation for vfio-ap. > >>&g

Re: [libvirt] [PATCH RFC 0/1] mdevctl: further config for vfio-ap

2019-06-13 Thread Cornelia Huck
On Fri, 7 Jun 2019 14:30:48 -0400 Tony Krowiak wrote: > On 6/7/19 10:56 AM, Cornelia Huck wrote: > > On Thu, 6 Jun 2019 12:45:29 -0400 > > Matthew Rosato wrote: > > > >> On 6/6/19 10:44 AM, Cornelia Huck wrote: > >>> This patch adds a very roug

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-13 Thread Cornelia Huck
On Wed, 12 Jun 2019 17:54:34 +0200 Halil Pasic wrote: > On Wed, 12 Jun 2019 09:14:39 +0200 > Cornelia Huck wrote: > > Ok, looked at driverctl. Extending this one for non-PCI seems like a > > reasonable path. However, we would also need to extend any non-PCI > > device

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-12 Thread Cornelia Huck
On Tue, 11 Jun 2019 14:28:22 -0600 Alex Williamson wrote: > On Tue, 11 Jun 2019 21:45:08 +0200 > Cornelia Huck wrote: > > > On Fri, 7 Jun 2019 18:06:30 +0200 > > Halil Pasic wrote: > > > I guess for vfio-ccw one needs to make sure that the ccw device is boun

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-11 Thread Cornelia Huck
On Fri, 7 Jun 2019 18:06:30 +0200 Halil Pasic wrote: > On Fri, 24 May 2019 12:11:06 +0200 > Cornelia Huck wrote: > > > On Thu, 23 May 2019 17:20:01 -0600 > > Alex Williamson wrote: > > > > > Hi, > > > > > [..] > > > &g

Re: [libvirt] [PATCH RFC 0/1] mdevctl: further config for vfio-ap

2019-06-07 Thread Cornelia Huck
On Thu, 6 Jun 2019 12:45:29 -0400 Matthew Rosato wrote: > On 6/6/19 10:44 AM, Cornelia Huck wrote: > > This patch adds a very rough implementation of additional config data > > for mdev devices. The idea is to make it possible to specify some > > type-specific key=value pai

[libvirt] [PATCH RFC 1/1] allow to specify additional config data

2019-06-06 Thread Cornelia Huck
Add a rough implementation for vfio-ap. Signed-off-by: Cornelia Huck --- mdevctl.libexec | 25 ++ mdevctl.sbin| 56 - 2 files changed, 80 insertions(+), 1 deletion(-) diff --git a/mdevctl.libexec b/mdevctl.libexec index

[libvirt] [PATCH RFC 0/1] mdevctl: further config for vfio-ap

2019-06-06 Thread Cornelia Huck
://github.com/cohuck/mdevctl conf-data Cornelia Huck (1): allow to specify additional config data mdevctl.libexec | 25 ++ mdevctl.sbin| 56 - 2 files changed, 80 insertions(+), 1 deletion(-) -- 2.20.1 -- libvir-list

Re: [PATCH v3 2/2] drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU

2019-05-28 Thread Cornelia Huck
xpose migration_version > attribute, live migration is regarded as not supported for those vGPUs. > > Cc: Alex Williamson > Cc: Erik Skultety > Cc: "Dr. David Alan Gilbert" > Cc: Cornelia Huck > Cc: "Tian, Kevin" > Cc: Zhenyu Wang > Cc: "

Re: [libvirt] [PATCH v3 1/2] vfio/mdev: add migration_version attribute for mdev device

2019-05-28 Thread Cornelia Huck
; | migration_version | | migration_version |-->check migration > - - compatibility > mdev device A mdev device B > > Cc: Alex Williamson > Cc: Erik Skultety > Cc: "Dr. David Alan Gilbert" > Cc: Cornelia Huck > Cc: "Tian

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-05-24 Thread Cornelia Huck
On Thu, 23 May 2019 17:20:01 -0600 Alex Williamson wrote: > Hi, > > Currently mediated device management, much like SR-IOV VF management, > is largely left as an exercise for the user. This is an attempt to > provide something and see where it goes. I doubt we'll solve > everyone's needs on

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 12:01:45 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 14 May 2019 03:47:36 -0400 > > Yan Zhao wrote: > > > hi Cornelia and Dave, > > > do you also agree on: > > > 1. "

Re: [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 03:47:36 -0400 Yan Zhao wrote: > On Tue, May 14, 2019 at 03:43:44PM +0800, Erik Skultety wrote: > > On Tue, May 14, 2019 at 03:32:19AM -0400, Yan Zhao wrote: > > > On Tue, May 14, 2019 at 03:20:40PM +0800, Erik Skultety wrote: > > > > That said, from libvirt POV as a

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 02:12:35 -0400 Yan Zhao wrote: > On Mon, May 13, 2019 at 09:28:04PM +0800, Erik Skultety wrote: > > In case of libvirt checking the compatibility, it won't matter how good the > > error message in the kernel log is and regardless of how many error states > > you > > want to

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Cornelia Huck
On Fri, 10 May 2019 10:36:09 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Thu, 9 May 2019 17:48:26 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Cornelia Huck (coh...@redhat.com)

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-10 Thread Cornelia Huck
On Thu, 9 May 2019 17:48:26 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Thu, 9 May 2019 16:48:57 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Cornelia Huck (coh...@redhat.com)

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Thu, 9 May 2019 16:48:57 +0100 "Dr. David Alan Gilbert" wrote: > * Cornelia Huck (coh...@redhat.com) wrote: > > On Tue, 7 May 2019 15:18:26 -0600 > > Alex Williamson wrote: > > > > > On Sun, 5 May 2019 21:49:04 -0400 > > > Yan Zhao wrote

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Tue, 7 May 2019 15:18:26 -0600 Alex Williamson wrote: > On Sun, 5 May 2019 21:49:04 -0400 > Yan Zhao wrote: > > + Errno: > > + If vendor driver wants to claim a mdev device incompatible to all other > > mdev > > + devices, it should not register version attribute for this mdev device.

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-09 Thread Cornelia Huck
On Wed, 8 May 2019 07:57:05 -0400 Yan Zhao wrote: > On Tue, May 07, 2019 at 05:19:54PM +0800, Cornelia Huck wrote: > > On Sun, 5 May 2019 21:49:04 -0400 > > Yan Zhao wrote: > > > > > version attribute is used to check two mdev devices' compatibili

Re: [libvirt] [PATCH v2 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-05-07 Thread Cornelia Huck
: > 1. removed 32 common part of version string > (Alex Williamson) > 2. do not register version attribute for GVT not supporting live > migration.(Cornelia Huck) > 3. for platforms out of gen8, gen9, return -EINVAL --> -ENODEV for > incompatible. (Cornelia Huck) Should go below '-

Re: [libvirt] [PATCH v2 1/2] vfio/mdev: add version attribute for mdev device

2019-05-07 Thread Cornelia Huck
ser space actually starts live migration, it can first check > whether two mdev devices are compatible. > > v2: > 1. added detailed intent and usage > 2. made definition of version string completely private to vendor driver > (Alex Williamson) > 3. abandoned changes to sample

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-05-07 Thread Cornelia Huck
On Tue, 7 May 2019 01:39:13 -0400 Yan Zhao wrote: > On Tue, Apr 30, 2019 at 11:29:08PM +0800, Cornelia Huck wrote: > > If I followed the discussion correctly, I think you plan to drop this > > format, don't you? I'd be happy if a vendor driver can use a simple > > number

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-30 Thread Cornelia Huck
On Wed, 24 Apr 2019 04:15:58 -0400 Yan Zhao wrote: > On Wed, Apr 24, 2019 at 03:56:24PM +0800, Cornelia Huck wrote: > > On Tue, 23 Apr 2019 23:10:37 -0400 > > Yan Zhao wrote: > > > > > On Tue, Apr 23, 2019 at 05:59:32PM +0800, Cornelia Huck wrote: > > &g

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-24 Thread Cornelia Huck
On Tue, 23 Apr 2019 23:10:37 -0400 Yan Zhao wrote: > On Tue, Apr 23, 2019 at 05:59:32PM +0800, Cornelia Huck wrote: > > On Fri, 19 Apr 2019 04:35:04 -0400 > > Yan Zhao wrote: > > > > > device version attribute in mdev sysfs is used by user space software > &

Re: [libvirt] [PATCH 2/2] drm/i915/gvt: export mdev device version to sysfs for Intel vGPU

2019-04-23 Thread Cornelia Huck
to identify Intel vGPU well for live > migration purpose. > > Cc: Alex Williamson > Cc: Erik Skultety > Cc: "Dr. David Alan Gilbert" > Cc: Cornelia Huck > Cc: "Tian, Kevin" > Cc: Zhenyu Wang > Cc: "Wang, Zhi A" > c: Neo Jia > Cc: Ki

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-23 Thread Cornelia Huck
uot; > -bash: echo: write error: Invalid argument > > 3. if two mdev devices are compatible, user space software can start > live migration, and vice versa. > > Note: if a mdev device does not support live migration, it either does > not provide a version attribute, or always

Re: [libvirt] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-23 Thread Cornelia Huck
On Tue, 23 Apr 2019 01:41:57 -0400 Yan Zhao wrote: > On Tue, Apr 23, 2019 at 09:21:00AM +0800, Alex Williamson wrote: > > On Mon, 22 Apr 2019 21:01:52 -0400 > > Yan Zhao wrote: > > > > > On Mon, Apr 22, 2019 at 10:39:50PM +0800, Alex Williamson wrote: > > > > On Fri, 19 Apr 2019 04:35:04

Re: [libvirt] [PATCH for-4.0 v3 2/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-27 Thread Cornelia Huck
* Removed *-0.9 devices. Nobody will want to use them, if > transitional devices work with legacy drivers > (Gerd Hoffmann, Michael S. Tsirkin) > * Drop virtio version from name: rename -1.0-transitional to > -transitional (Michael S. Tsirkin) > * Renamed -1.0 to -non-transiti

Re: [libvirt] [PATCH for-4.0 v3 1/2] virtio: Helper for registering virtio device types

2018-11-27 Thread Cornelia Huck
/* Same as TypeInfo fields: */ > +size_t instance_size; > +void (*instance_init)(Object *obj); > +void (*class_init)(ObjectClass *klass, void *data); > +} VirtioPCIDeviceTypeInfo; That's a bit of boilerplate, but the end result seems to be more greppable. > + > +/* Registe

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 22:44:54 -0200 Eduardo Habkost wrote: > On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > > On Thu, 15 Nov 2018 10:05:59 + > > Daniel P. Berrangé wrote: > > > If libvirt did this compatibility approach, can you > > > con

Re: [libvirt] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2018 19:32:32 -0200 Eduardo Habkost wrote: > However, I wish this kind of usability magic didn't automatically > imposed us the burden of keeping guest ABI compatibility too. > Keeping ABI compatibility on the machine-friendly device types and > interfaces is already hard enough.

  1   2   >