Re: [libvirt]: Not able to login to container when cgroup is enabled

2009-10-07 Thread Dan Smith
or with your config) to prevent that and then go from there. -- Dan Smith IBM Linux Technology Center email: da...@us.ibm.com -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] lxc: Add lxcGetHostname()

2009-04-14 Thread Dan Smith
This patch adds the getHostname method to the lxc driver structure (using the qemu driver's generic code). Apparently virsh started using that method during console attachment recently. Without this implementation, the virsh refused to attach to lxc consoles. Signed-off-by: Dan Smith da

Re: [libvirt] [PATCH 0 of 2] Cgroup and LXC fixes

2008-10-21 Thread Dan Smith
driver is made to allow major type 136 DS as a result. Were there any comments on this set? I think it would be nice to get it into the tree sooner than later so we at least have resource controls on containers :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED

Re: [libvirt] [PATCH 0 of 2] Cgroup and LXC fixes

2008-10-21 Thread Dan Smith
DV sorry for the delay, please push ! Done. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Question about supporting other hypervisor

2008-10-17 Thread Dan Smith
into the libvirt API semantics, IMHO :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] PATCH: 4/5: Locking in the LXC driver

2008-10-17 Thread Dan Smith
} It looks to me like you're taking the driver lock and not releasing it on exit. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-16 Thread Dan Smith
set the capabilities of DB containers to either mask out CAP_SYS_ADMIN from libvirtd's set, DB or construct an explicit capability whitelist Yeah, I guess so. I'll start looking into this :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] -- Libvir-list

[libvirt] [PATCH 2 of 2] [LXC] Create and enter the cgroup before starting container process

2008-10-16 Thread Dan Smith
Without this, our container child doesn't actually end up in the cgroup, and thus runs unrestricted. Note that this does not address the container's ability to mount cgroup and move itself into the parent namespace. While making this change, it became clear that we need to allow access to the

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-16 Thread Dan Smith
arbitrary items to devices.allow and gain access from a subgroup. So, I think we're going to need to restrict CAP_SYS_ADMIN if we really want isolation, but I'm not sure what else that is likely to break. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED

Re: [libvirt] [PATCH] Add generic parameter=value support for virsh's schedinfo command

2008-10-08 Thread Dan Smith
DV a is not part of C89, that's an extension to the standard if i believe DV the linux man page. I would rather avoid a portability problem here Oh, right, I always forget about that. I'll send a replacement. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email

[libvirt] [PATCH] Add generic parameter=value support for virsh's schedinfo command

2008-10-08 Thread Dan Smith
This patch maintains the two Xen-specific --weight and --cap options, but adds support for setting arbitrary parameters by specifying them in param=value syntax. Changes to the virsh manual are included. Changes: - Replace use of 'a' conversion modifier with pre-alloc diff -r 51fd150edd42 -r

[libvirt] [PATCH 2 of 3] Add scheduling parameter support for LXC domains

2008-10-07 Thread Dan Smith
diff -r 6fb284fa200a -r ebecbe5caa03 src/lxc_driver.c --- a/src/lxc_driver.c Tue Oct 07 08:21:49 2008 -0700 +++ b/src/lxc_driver.c Tue Oct 07 08:21:50 2008 -0700 @@ -35,6 +35,7 @@ #include unistd.h #include wait.h +#include internal.h #include lxc_conf.h #include lxc_container.h #include

[libvirt] [PATCH 1 of 3] Add get/set of cpu.shares to cgroup implementation

2008-10-07 Thread Dan Smith
This brings get/set of U64 out of the #if 0, which looks messier than it is. diff -r 64f19f607bc6 -r 6fb284fa200a src/cgroup.c --- a/src/cgroup.c Fri Oct 03 17:58:02 2008 + +++ b/src/cgroup.c Tue Oct 07 08:21:49 2008 -0700 @@ -224,26 +224,6 @@ return rc; } -#if 0 -/* This is

[libvirt] [PATCH 0 of 3] Add cpu.shares support to LXC driver

2008-10-07 Thread Dan Smith
This set adds {Get,Set}SchedulerParameters support to the LXC driver. A single parameter of cpu_shares is added, which gets/sets the cpu.shares key in the domain's cgroup. I also added bits to virsh schedinfo to support this. -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo

2008-10-07 Thread Dan Smith
diff -r ebecbe5caa03 -r b07cd92a30e9 src/virsh.c --- a/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 +++ b/src/virsh.c Tue Oct 07 08:21:50 2008 -0700 @@ -1114,6 +1114,7 @@ {domain, VSH_OT_DATA, VSH_OFLAG_REQ, gettext_noop(domain name, id or uuid)}, {weight, VSH_OT_INT,

Re: [libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo

2008-10-07 Thread Dan Smith
' to DB see what are available. I can do that, but since the CIM providers don't depend on virsh for this, can we move forward with the first two patches before we get this fixed up? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpj9vULP1wNJ.pgp Description

Re: [libvirt] [PATCH 2 of 3] Add scheduling parameter support for LXC domains

2008-10-07 Thread Dan Smith
parameter. Okay, sounds good. I'll change it. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpzbvUbw2YkC.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Add generic parameter=value support for virsh's schedinfo command

2008-10-07 Thread Dan Smith
This patch maintains the two Xen-specific --weight and --cap options, but adds support for setting arbitrary parameters by specifying them in param=value syntax. Changes to the virsh manual are included. diff -r 51fd150edd42 -r aae58f42bd4a docs/virsh.pod --- a/docs/virsh.podTue Oct 07

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-03 Thread Dan Smith
that code in the future ;-) Okay, I suppose that if the QEMU driver ends up doing something similar, the constants would be reused. Should they go in cgroup.h since they're expected to be used with that interface? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL

[libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-03 Thread Dan Smith
Oct 03 08:06:52 2008 -0700 @@ -0,0 +1,762 @@ +/* + * cgroup.c: Tools for managing cgroups + * + * Copyright IBM Corp. 2008 + * + * See COPYING.LIB for the License of this software + * + * Authors: + * Dan Smith [EMAIL PROTECTED] + */ +#include config.h + +#include stdio.h +#include stdint.h

[libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-03 Thread Dan Smith
This patch adds code to the controller to set up a cgroup named after the domain name, set the memory limit, and restrict devices. It also adds bits to lxc_driver to properly clean up the cgroup on domain death. If virCgroupHaveSupport() says that no support is available, then we just allow the

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-03 Thread Dan Smith
be somewhere other than cgroup.h? If not, I think it might be appropriate to make that change in a separate patch, since populating /dev isn't really cgroup-related. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpck5elXVqx7.pgp Description: PGP signature

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-03 Thread Dan Smith
/stat.h lead to better readability, personally. Octal permissions are used elsewhere int the code pretty extensively, so I'm comfortable with this as it is. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpPFzo8qY9qz.pgp Description: PGP signature

[libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
Oct 01 13:16:03 2008 -0700 @@ -0,0 +1,705 @@ +/* + * cgroup.c: Tools for managing cgroups + * + * Copyright IBM Corp. 2008 + * + * See COPYING.LIB for the License of this software + * + * Authors: + * Dan Smith [EMAIL PROTECTED] + */ +#include config.h + +#include stdio.h +#include stdint.h

[libvirt] [PATCH 0 of 2] Add cgroup manipulation and LXC driver support

2008-10-01 Thread Dan Smith
This is my updated set for cgroup manipulation. I think I have addressed all of the concerns and comments so far. There are no major caveats I'm aware of with this round. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-01 Thread Dan Smith
This patch adds code to the controller to set up a cgroup named after the domain name, set the memory limit, and restrict devices. It also adds bits to lxc_driver to properly clean up the cgroup on domain death. If virCgroupHaveSupport() says that no support is available, then we just allow the

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-01 Thread Dan Smith
to cleanup DB a partially constructed cgroup ? Yep, I'll fix that too. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpCrdzpJFR1t.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
not sure I follow. It seems like the virt type offers more uniqueness than driver name. Either way, I have no problem making this change :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgp7icmruQasl.pgp Description: PGP signature -- Libvir-list mailing list

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
DB Both, Xen and QEMU drivers support a virt type of 'hvm'. Ah, gotcha. I didn't realize that just looking at the enum. I've changed it locally. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpewM4wFGN22.pgp Description: PGP signature -- Libvir

Re: [libvirt] [PATCH 0 of 2] [RFC] Add cgroup manipulation and LXC driver support

2008-09-30 Thread Dan Smith
(as mentioned above) would solve both of these issues as well. Does anyone have an opinion on taking that approach? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgp0QYRgfhr7u.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-09-30 Thread Dan Smith
of the existing APIs could be made static since they'd be DB needed anyway, but some could be re-design to be tailored to DB the semantics we want. Okay, I'll reswizzle it and re-post. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpuWmRzxXCG3.pgp

[libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-09-29 Thread Dan Smith
+ * + * Copyright IBM Corp. 2008 + * + * See COPYING.LIB for the License of this software + * + * Authors: + * Dan Smith [EMAIL PROTECTED] + */ +#include config.h + +#include stdio.h +#include stdint.h +#include inttypes.h +#include mntent.h +#include fcntl.h +#include string.h +#include errno.h

[libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-09-29 Thread Dan Smith
This patch adds code to the controller to set up a cgroup called libvirt/lxc/$name, set the memory limit, and restrict devices. It also adds bits to lxc_driver to properly clean up the cgroup on domain death. If virCgroupHaveSupport() says that no support is available, then we just allow the

Re: [libvirt] Live migration sanity checks

2008-09-02 Thread Dan Smith
you mentioned the need for the user to specify a list of allowable checks, perhaps ask the hypervisor too could be one of those. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpSwMH7W9SYM.pgp Description: PGP signature -- Libvir-list mailing list Libvir

Re: [libvirt] [PATCH] Delete veth devices during lxcVMCleanup

2008-08-22 Thread Dan Smith
DB All my patches for LXC with exception of the pivot_root stuff are DB now commited, so this is good to commit. Done. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpg7jtngAkLp.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list

[libvirt] [PATCH] Delete veth devices during lxcVMCleanup

2008-08-14 Thread Dan Smith
This makes sure to delete veth devices after we've killed the container. In the case of a destroy or crash, this ensures the system is cleaned up properly. To be applied atop Daniel Berrange's current LXC patch stack. diff -r b18ae864eb98 -r cd0bd9a6288a src/lxc_driver.c --- a/src/lxc_driver.c

Re: [libvirt] PATCH: 3/4: Introduce libvirt_lxc binary

2008-08-13 Thread Dan Smith
on the fake 'lo' interface for the container. However, I get that some of the time in the original code as well, so I don't see any reason holding this stuff up any further, and I will see about tracking that down. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email

Re: [libvirt] PATCH: 4/4: Add pivot_root support to container

2008-08-13 Thread Dan Smith
be in an lxcContainerDoMounts() function or something, just like the lxcContainerSetStdio() function that gets called a bit later. The added functionality is excellent, by the way :) Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpyWwDTVjCrt.pgp

[libvirt] [PATCH] The logic in veth.c that searches for free interface names takes into account

2008-08-06 Thread Dan Smith
only current devices, but not device names already planned for the other half of a container's device pair. Thus, the search can result in attempting to create a pair of devices such as veth1 and veth1, which obviously does not work. This patch augments the logic to be a little smarter in this

Re: [libvirt] PATCH: 0/7: Re-factor LXC driver

2008-08-05 Thread Dan Smith
was seeing with the previous set of patches, and was unable to figure out why file descriptor 6 was getting prematurely closed. I'll get started on debugging it again tomorrow, but it might be good if you can reproduce it as well :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team

Re: [libvirt] PATCH: 3/5: Introduce a container controller process

2008-07-16 Thread Dan Smith
procedure that result in a silent failure. Almost all of them leave libvirtd thinking that the container/controller is running, but in fact, it _exit(1)'d long ago. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpasW3PY8v6U.pgp Description: PGP signature

Re: [libvirt] PATCH: Refactor LXC to remove some state from lxc_vm_t

2008-07-14 Thread Dan Smith
the TTYs and control socket are handled to DB prepare for the switchover. I haven't tested it yet (I can do that tomorrow), but this looks fine to me :) Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpUqhiabo8Tf.pgp Description: PGP signature

[libvirt] [PATCH] [LXC] Remove unused variable and fix uninitialized variable

2008-06-27 Thread Dan Smith
Also remove a stale comment in the area. This makes libvirt compile when passed --with-lxc and --enable-compiler-warnings=error diff -r bd08a3f22fb2 -r fa048279476d src/veth.c --- a/src/veth.cThu Jun 26 16:09:48 2008 + +++ b/src/veth.cFri Jun 27 06:48:10 2008 -0700 @@ -192,14

Re: [libvirt] [PATCH] fix compilation for MinGW (with LXC)

2008-06-27 Thread Dan Smith
AS May I commit this patch for MinGW compilation? veth.c is not AS necessary for MinGW. Yep, looks okay to me :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpzuL9xSI6Jh.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list

Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-25 Thread Dan Smith
Concerning iproute2, I think this is the work of the installer to DL check the dependencies, eg. the libvirt rpm depends on DL iproute2-x.y.z version rpm. Agreed, and I'm sure it will. Note DV's second comment here: https://www.redhat.com/archives/libvir-list/2008-June/msg00232.html Thanks! -- Dan

Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-25 Thread Dan Smith
of doing that. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpmeZLY1dUi4.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-25 Thread Dan Smith
command. You're still scraping the output, just pushing the burden for doing so onto grep. But, fair enough :) DL Anyway, catching a specific return code for an unknown subcommand DL makes sense for this check. Okay, cool. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email

Re: [libvirt] [PATCH 4 of 4] [LXC] Add setup/cleanup of container network interfaces

2008-06-25 Thread Dan Smith
DL Is it called when the last process of the container dies ? Yes, it (lxcVMCleanup()) is called from lxcSigHandler() which gets run if the container dies unexpectedly. It's also called from lxcDomainDestroy() which covers the 'shutdown' and 'destroy' cases as well. -- Dan Smith IBM Linux

Re: [libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-25 Thread Dan Smith
not be present in a subsequent revision. DL But again, you can ignore that, if you prefer to use the 'ip' DL command. When it really comes down to it, it doesn't matter if the kernel support is present if the user doesn't have an updated 'ip' binary. -- Dan Smith IBM Linux Technology Center Open Hypervisor

[libvirt] [PATCH 0 of 4] [LXC] RFC: Network interface support

2008-06-24 Thread Dan Smith
I think I have addressed all of the comments. Changes detailed per patch. I converted to using a dynamic detection routine for determining NETNS support, which I think is much better. That is pulled out into a separate patch for easier distinction. Thanks! -- Libvir-list mailing list

[libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-24 Thread Dan Smith
Allow check for containers support to be done without CLONE_NEWNET, and then determine support on the fly by checking for iproute2 support and a successful clone(CLONE_NEWNET). This lets us set a flag for later, as well as not completely disable LXC support on a system without NETNS support.

[libvirt] [PATCH 2 of 4] [LXC] Add functions to manage veth device pairs

2008-06-24 Thread Dan Smith
This gives us the ability to create a veth pair so that we can move one into the network namespace of an LXC container. Changes from last time: - Fixed use of sprintf() - Fixed up 'ip link...' argument synthesis - Fixed license headers - Fixed while() {...} to do {...} while() - Fixed

[libvirt] [PATCH 4 of 4] [LXC] Add setup/cleanup of container network interfaces

2008-06-24 Thread Dan Smith
Changes: - Remove extraneous i variables from various functions - Only bring up lo if we have other interfaces (and thus NETNS) - Fail setup of interfaces if NETNS support is not present - Only add CLONE_NEWNET to start flags if domain has interfaces defined - Make lxc_vm_t parameters const

Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs

2008-06-23 Thread Dan Smith
other examples of all-literal argv[] lists like this. I'm inclined to leave the const and the cast, but if you have a better suggestion, I'll be glad to make the change. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpBGD38giQUJ.pgp Description

Re: [libvirt] [PATCH 3 of 3] [LXC] Add setup/cleanup of container network interfaces

2008-06-20 Thread Dan Smith
or add a comment saying why it's ok to ignore failure, in which JM case don't clobber the previous value. I think the comment above that code is supposed justify it :) I'll just fix up the checking instead and remove the comment. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor

Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs

2008-06-20 Thread Dan Smith
if so. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpP69YKohLy3.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 0 of 3] LXC network interface support

2008-06-19 Thread Dan Smith
This set is actually authored by Dave Leskovec. He is moving on to some other work and I will be working this into the tree. I have made a few changes to this, mostly to allow this code to compile out if the proper kernel and userspace support is not present. I am submitting it as an RFC

[libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs

2008-06-19 Thread Dan Smith
# HG changeset patch # User Dave Leskovec [EMAIL PROTECTED] # Date 1213891164 25200 # Node ID 386c067de8995028dd11f70602081c31682dd293 # Parent 8d2afc533c91c4796512e1e71c8283e86eafd18a [LXC] Add functions to manage veth device pairs This gives us the ability to create a veth pair so that we can

[libvirt] [PATCH 2 of 3] [LXC] Add XML parsing of container network interfaces

2008-06-19 Thread Dan Smith
# HG changeset patch # User Dave Leskovec [EMAIL PROTECTED] # Date 1213891177 25200 # Node ID acf369a2543ad52b235ae8541c8ad05670e255bd # Parent 386c067de8995028dd11f70602081c31682dd293 [LXC] Add XML parsing of container network interfaces. diff -r 386c067de899 -r acf369a2543a src/lxc_conf.c ---

[libvirt] [PATCH 3 of 3] [LXC] Add setup/cleanup of container network interfaces

2008-06-19 Thread Dan Smith
# HG changeset patch # User Dan Smith [EMAIL PROTECTED] # Date 1213891185 25200 # Node ID cb780a7b3ad591f1a9392d6528218b3aa2c3483d # Parent acf369a2543ad52b235ae8541c8ad05670e255bd [LXC] Add setup/cleanup of container network interfaces diff -r acf369a2543a -r cb780a7b3ad5 src/lxc_conf.h

Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs

2008-06-19 Thread Dan Smith
files. DV COPYING.LIB is of course LGPL 2.1 Okay, I'll change it. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpS5wIMskw77.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs

2008-06-19 Thread Dan Smith
the --plain when I sent it out... -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpQ4fsElwxWG.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Fix qemudParseVMDeviceDef() to check for proper network device tag name

2008-06-13 Thread Dan Smith
(or handle) not supported properly, but XML not well-formed is a more fatal error, indicating a problem with the providers. The fewer this-is-kvm-so-only-cdroms-are-dynamic special cases we have, the better :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED

Re: [libvirt] [RFC] Network interface XML for containers

2008-05-09 Thread Dan Smith
in the XML. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpaYc3gTt3XL.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] [RFC] 4 of 4 Linux Container support - start container

2008-03-21 Thread Dan Smith
in the daemon would allow the console forwarding to happen there instead of being duplicated in every container. I don't really like the idea of having a forwarding process in every container as the parent of the container init. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL

Re: [Libvir] [PATCH] Fix Xen-3.2 hypercalls

2008-02-28 Thread Dan Smith
DV this patches fixes it by checking the newer sysctl versions when DV initializing the driver. This fixes my problem on Xen 3.2. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpwgkvoaW3dr.pgp Description: PGP signature -- Libvir-list mailing

Re: [Libvir] Snapshots in Libvirt

2008-02-28 Thread Dan Smith
of QEMU machines. This is something that we definitely would like to be able to support in the CIM providers when it's available in libvirt. There is already a DMTF model around providing this sort of functionality. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL

Re: [Libvir] default hypervisor selection

2008-02-21 Thread Dan Smith
reason not to also allow setting the default URI in an environment variable to solve the dual-hypervisor problem? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpjVT7Wc4yqR.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dan Smith
DL That makes sense to me. I guess I'd lean towards leaving init DL in the container block since a container isn't really starting a DL new os image. Perhaps Dan Smith has some comments on this... Oh I *always* have some comments... :) From the above example, init would be the only member

Re: [Libvir] [RFC] 0/3 Add Linux Container support to libvirt

2008-02-21 Thread Dan Smith
, at least to me, it seems less suited there. But from libvirt's perspective, it's still a virtual machine(-like) entity, regardless of what is really running inside. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpTx2iQ1VEmI.pgp Description: PGP signature

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-12 Thread Dan Smith
on this other existing var over here. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpqnd0jVy5m7.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-12 Thread Dan Smith
to associate the path provided for a mount to a storage pool. [*] provisioning in the containers case would be a recursive directory copy of a template overlay directory, which is what Dan was saying he didn't want to do -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-12 Thread Dan Smith
Perhaps simply the ability to 'clone' an existing directory DB (populated from source external soure, or off NFS) would be DB sufficient for populating containers ? Sounds reasonable to me. :) Maybe Dave L. can chime in here with any thoughts he may have? -- Dan Smith IBM Linux Technology Center

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-12 Thread Dan Smith
in the infrastructure you're adding would prevent such an implementation down the road, but I just thought I'd bring it up. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpZ1cdsdDSyQ.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-16 Thread Dan Smith
would be interested in having an init-like process structure within their containers. Thus, I would vote for using init over boot or application. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpydcMD77cAA.pgp Description: PGP signature -- Libvir-list

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-16 Thread Dan Smith
. The placement of the network block also seems to imply that this bit of network config, and specifically this IP address, is a characteristic property of the container itself. That seems strange to me. Should this be under devices so we can represent more than one interface? -- Dan Smith IBM Linux

Re: [Libvir] [PATCH 1/2] virDomainMigrate implementation (Xen only, no remote, no qemu, no virsh)

2007-07-16 Thread Dan Smith
of Xen-specific behavior? How would you handle someone wanting to use tcp:// or ssh:// with qemu? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpsRaQZEZG6G.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https

Re: [Libvir] Re: Next features and target for development

2007-07-11 Thread Dan Smith
*/ virDomainMigrate(dom, tcp://host); /* qemu case */ virDomainMigrate(dom, lvm://foo); /* qemu error case */ /* Checkpoint does not undefine the host */ virDomainCheckpoint(dom, foo); /* Xen unimplemented case */ virDomainCheckpoint(dom, lvm://foo); /* qemu case */ Is that not sane? -- Dan

Re: [Libvir] Re: Next features and target for development

2007-07-11 Thread Dan Smith
the libvirt daemon running and accessible on the remote machine, is that right? If so, why should this be necessary? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpHNODyXfNX6.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list

Re: [Libvir] Re: Next features and target for development

2007-07-11 Thread Dan Smith
with that... :) -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgp1RvoZymgb0.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [Libvir] Next features and target for development

2007-07-10 Thread Dan Smith
to remove the shell domain from the source machine. What will be the expected behavior here? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpm2cJYHlQjr.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com

Re: [Libvir] Next features and target for development

2007-07-10 Thread Dan Smith
across Xen and qemu, if that domain is fully-virtualized. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpYTdJSvuPmw.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] Re: Next features and target for development

2007-07-10 Thread Dan Smith
it is implemented. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpRoct0qCpyW.pgp Description: PGP signature -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] Re: Next features and target for development

2007-07-10 Thread Dan Smith
not compatible, I think it's worth having. Perhaps the test could return more granular information and the yes/no (or several levels of such) could be macros? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpagH2JYWZga.pgp Description: PGP signature -- Libvir