-by: Daniel Henrique Barboza
examples/c/domain/dommigrate.c | 6 +-
src/conf/domain_conf.c | 70 +---
src/conf/netdev_vport_profile_conf.c | 33 +-
src/conf/storage_conf.c | 12 ++--
src/conf/storage_source_conf.c | 15 ++---
src/conf
On 10/21/21 16:31, Vineeth Pillai wrote:
From: Praveen K Paladugu
Signed-off-by: Vineeth Pillai
---
src/ch/ch_driver.c | 154 +
1 file changed, 154 insertions(+)
diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
index
On 10/21/21 16:31, Vineeth Pillai wrote:
From: Praveen K Paladugu
using virCHProcessSetupPid
Signed-off-by: Praveen K Paladugu
Signed-off-by: Vineeth Pillai
---
src/ch/ch_monitor.c | 60 ++
src/ch/ch_monitor.h | 2 ++
src/ch/ch_process.c | 78
On 10/21/21 16:31, Vineeth Pillai wrote:
Signed-off-by: Vineeth Pillai
Signed-off-by: Praveen K Paladugu
---
po/POTFILES.in | 1 +
src/ch/ch_cgroup.c | 457
src/ch/ch_cgroup.h | 45 +
src/ch/ch_conf.c| 2 +
On 10/21/21 16:31, Vineeth Pillai wrote:
Add domainGetVcpuPinInfo and nodeGetCPUMap callbacks to ch driver
Signed-off-by: Vineeth Pillai
Signed-off-by: Praveen K Paladugu
---
src/ch/ch_domain.h | 12 +--
src/ch/ch_driver.c | 54 ++
2
On 10/21/21 16:31, Vineeth Pillai wrote:
Signed-off-by: Vineeth Pillai
Signed-off-by: Praveen K Paladugu
---
src/ch/ch_domain.c | 25
src/ch/ch_domain.h | 4 ++
src/ch/ch_driver.c | 138 +
3 files changed, 167 insertions(+)
diff
On 10/21/21 16:31, Vineeth Pillai wrote:
These helper methods are used to capture vcpu information
in ch driver.
Signed-off-by: Vineeth Pillai
Signed-off-by: Praveen K Paladugu
---
src/util/virprocess.c | 136 ++
src/util/virprocess.h | 5 ++
2
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index a71b84c363..9e990ff93a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -30,6 +30,11 @@ v7.10.0 (unreleased)
Libvirt is now able to report interface information from
On 11/12/21 09:13, Michal Prívozník wrote:
On 11/1/21 1:27 AM, Daniel Henrique Barboza wrote:
Hi,
This small series adds support to a new QMP event called
DEVICE_UNPLUG_GUEST_SUPPORT introduced recently in upstream QEMU.
This event is emitted when a device removal error is detected
:40.817+: 140520: error :
virPCIVPDParseVPDLargeResourceFields:588 : internal error: VPD-W does not
contain the mandatory RW field
With this series the warnings are now gone.
All patches:
Tested-by: Daniel Henrique Barboza
Invalid field values are now skipped instead of halting further
ife
easier to abort the pending removal operation.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 9 +
src/qemu/qemu_monitor_json.c | 19 ++
src/qemu/qemu_process.c
haven't add any documentation because I didn't find a good place to
document this change, and I'm not sure if this is necessary either since
this doesn't change user ABI. If this requires a doc change please let
me know.
Daniel Henrique Barboza (2):
tests: update QEMU and domain ppc64
couldn't just overwrite the default
mask if it's configured, but that would just shift the problem somewhere else.
This fix seems adequate.
Reviewed-by: Daniel Henrique Barboza
src/util/virresctrl.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/util
device). Therefore, regardless of memfd being
requested, we have to stick with memory-backend-file.
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_command.c | 3 ++-
.../memfd-memory-numa.x86_64-latest.args
to not report or return an error when the specified lockspace
already exists.
Signed-off-by: Jim Fehlig
---
Reviewed-by: Daniel Henrique Barboza
In response to my earlier query about this problem
https://listman.redhat.com/archives/libvir-list/2021-May/msg00872.html
src/locking
or a dash) even if the current
character we are processing is not in the set of allowed
characters (and thus skipped over).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1948433
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
src/hypervisor/domain_driver.c | 8
On 6/22/21 10:10 AM, Boris Fiuczynski wrote:
Change launch security policy of type SEV from required to
optional and add a test to ensure the required launch security
policy remains required when launch security type is SEV.
Signed-off-by: Boris Fiuczynski
---
Reviewed-by: Daniel Henrique
On 6/22/21 10:10 AM, Boris Fiuczynski wrote:
Adding virDomainSecDef for general launch security data
and moving virDomainSEVDef as an element for SEV data.
Signed-off-by: Boris Fiuczynski
---
Reviewed-by: Daniel Henrique Barboza
src/conf/domain_conf.c | 127
On 6/22/21 10:10 AM, Boris Fiuczynski wrote:
Make use of virDomainLaunchSecurity enum and automatic memory freeing.
Signed-off-by: Boris Fiuczynski
---
Reviewed-by: Daniel Henrique Barboza
src/conf/domain_conf.c | 123 +
src/conf/domain_conf.h
On 6/17/21 5:55 AM, Jano Tomko wrote:
On 6/17/21 9:03 AM, Peter Krempa wrote:
On Wed, Jun 16, 2021 at 18:30:08 -0300, Daniel Henrique Barboza wrote:
Commit 56dcdec1ac81 ("conf: reject duplicate virtiofs tags") added
validation code to reject duplicated virtiofs tags. But th
re's no need to
pass VIR_FILE_OPEN_FORCE_MODE because the file will be created
with the proper mode.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1969347
Fixes: bcdaa91a27b5b2d103535270a6a287efe6cd8bfb
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
ode=0 but
received code=1
FAILED
The '' tag is not mandatory, so let's consider that fs->dst
being NULL is a feasible scenario an adapt virDomainDefFSValidate()
accordingly.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
On 6/9/21 4:38 PM, Manish Mishra wrote:
Hi Everyone,
We want to add extra options to device xml to skip reattach of pci passthrough
devices. Following is xml format for pci passthrough devices added to domain as
of now.
When we pass managed=’yes’ flag through xml,
On 6/11/21 9:40 AM, Huangzhichao wrote:
Hi Everyone,
We find migration capabilities is not reset after restarting libvirtd, it would
cause problem in the following scene:
Version: libvirt release 7.4.0
Step 1. create a VM and query migration capabilities, mark the return content
as “Cap
This capability will be used in the papr-pef launch security type.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests/qemucapabilitiesdata/caps_6.1.0.ppc64.xml | 1 +
3 files changed, 4
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.rst | 4
1 file changed, 4 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index ab1307910d..4102327aa8 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -8067,6 +8067,10 @@ IBM Secure
Signed-off-by: Daniel Henrique Barboza
---
.../launch-security-papr-pef.xml | 22 ++
tests/genericxml2xmltest.c| 1 +
...y-papr-pef-ignore-policy.ppc64-latest.args | 30 +++
...launch-security-papr-pef-ignore-policy.xml | 19
This patch adds the 'papr-pef' launch security type for the QEMU
driver.
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 3 +++
src/conf/domain_conf.h| 1 +
src/qemu/qemu_command.c | 26
-May/msg00570.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg08491.html
[3] https://gitlab.com/dgibson/qemu/-/tree/ppc-for-6.1
Daniel Henrique Barboza (5):
tests: Add QEMU and domain ppc64 capapbilities for qemu 6.1
qemu: add 'pef-guest' capability
conf, qemu: add 'papr-pef
o run in protected virtualization secure mode, also known as
IBM Secure Execution. (...)"
Other than that,
Reviewed-by: Daniel Henrique Barboza
+`Protected Virtualization on s390 `__
+:since:`Since 7.4.0`
+
+
The contents of the element is used to provide
the guest owners input used fo
o run in protected virtualization secure mode, also known as
IBM Secure Execution. (...)"
Other than that,
Reviewed-by: Daniel Henrique Barboza
+`Protected Virtualization on s390 `__
+:since:`Since 7.4.0`
+
+
The contents of the element is used to provide
the guest owners input used fo
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add launch security type 's390-pv' as well as some tests.
Signed-off-by: Boris Fiuczynski
---
Reviewed-by: Daniel Henrique Barboza
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 8
On 5/20/21 12:10 PM, Boris Fiuczynski wrote:
On 5/20/21 2:08 PM, Daniel Henrique Barboza wrote:
On 5/20/21 4:05 AM, Boris Fiuczynski wrote:
On 5/19/21 9:34 PM, Daniel Henrique Barboza wrote:
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add launch security type 's390-pv' as well as some
On 5/20/21 4:05 AM, Boris Fiuczynski wrote:
On 5/19/21 9:34 PM, Daniel Henrique Barboza wrote:
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add launch security type 's390-pv' as well as some tests.
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 1
On 5/19/21 4:34 PM, Daniel Henrique Barboza wrote:
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add launch security type 's390-pv' as well as some tests.
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add launch security type 's390-pv' as well as some tests.
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 8 +
src/conf/domain_conf.h
On 5/19/21 2:40 PM, Boris Fiuczynski wrote:
Add s390-pv-guest capability.
Signed-off-by: Boris Fiuczynski
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests
policy remains required when launch security type
is SEV.
I think you missed a breakline up there.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 12 +-
src/conf/domain_conf.c| 156
the domU and assign NUMA memory and
vcpu affinities on its own. Later libvirt will adjust the affinity,
which may move the vcpus away from the assigned NUMA node.
Signed-off-by: Olaf Hering
---
Reviewed-by: Daniel Henrique Barboza
src/libxl/libxl_conf.c | 53
fails on platforms such as macOS.
This commit is similar to ace6528ae19, which made the same change to the
VMware driver.
Signed-off-by: Charlie Sharpsteen
---
Looks reasonable to me.
Reviewed-by: Daniel Henrique Barboza
src/vbox/vbox_common.c | 2 +-
1 file changed, 1 insertion(+), 1
when one of those
devices is present. This patch modifies that code to also increase the
limit if there are any vDPA devices present.
Resolves: https://bugzilla.redhat.com/1939776
Signed-off-by: Laine Stump
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_domain.c | 4 ++--
1 file
does not support mdev. I agree that there is no harm in
considering that this might change in the future though. One less piece
of code to change is always welcome.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 9 ++---
1 file changed, 2
Stump
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_domain.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 5f0c7f0531..5238a52095 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu
On 3/23/21 3:50 PM, Laine Stump wrote:
This function returns true if the domain has any interfaces that are
type='vdpa'.
Signed-off-by: Laine Stump
---
Reviewed-by: Daniel Henrique Barboza
src/conf/domain_conf.c | 14 ++
src/conf/domain_conf.h | 3 +++
src
On 3/23/21 7:03 AM, Ján Tomko wrote:
On a Monday in 2021, Daniel Henrique Barboza wrote:
Commit ac87d3520ad5 consolidated common cgroup code between the QEMU and
lxc drivers in domain_cgroup.c. In this process, in
virDomainCgroupSetupDomainBlkioParameters(), a call to
virCgroupGetBlkioWeight
: 5493217b940ee9ea72b581270adb3ab9ba245148
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941407
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_cgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/hypervisor/domain_cgroup.c b/src/hypervisor/domain_cgroup.c
index eb4fa20a9e
(_info.u.hvm.acpi, true);
}
$
If the maintainer is willing to amend it before pushing it:
Reviewed-by: Daniel Henrique Barboza
tests/libxlxml2domconfigtest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
index
gen
Reviewed-by: Hogan Wang
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d1a3659774..a5dfea94cb 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_drive
v1 and you fixed it in v2, so I'll
take that this code, albeit unusual to me, works. If it doesn't, it's a
rather trivial amend that the maintainer can do before pushing.
Reviewed-by: Daniel Henrique Barboza
+return 0;
+}
static int
qemuGetSchedInfo(unsigned long long *cpuW
On 2/25/21 10:23 AM, Tim Wiederhake wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=1840770
Signed-off-by: Tim Wiederhake
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_process.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/qemu
On 2/26/21 4:11 PM, Chris Mayo wrote:
Allow the directory to be chosen at installation time, to support local
conventions e.g. versioning.
Signed-off-by: Chris Mayo
---
Reviewed-by: Daniel Henrique Barboza
meson.build | 6 +-
meson_options.txt | 1 +
2 files changed, 6
On 3/2/21 7:40 AM, Thanos Makatos wrote:
-Original Message-
From: Daniel Henrique Barboza
Sent: 01 March 2021 18:07
To: Peter Krempa ; Thanos Makatos
Cc: libvir-list@redhat.com
Subject: Re: using libvirt 4.5 with upstream qemu
On 3/1/21 12:47 PM, Peter Krempa wrote:
On Mon
On 3/1/21 12:47 PM, Peter Krempa wrote:
On Mon, Mar 01, 2021 at 15:30:58 +, Thanos Makatos wrote:
I'm trying to use QEMU master with libvirt 4.5 and QEMU seems to be hanging
when I try to start a guest.
My environment is a modified CentOS 7.9 installation using libvirt 4.5.0. When
I use
On 2/22/21 1:12 AM, Laine Stump wrote:
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
virHostdevReAttachPCIDevices() is called when we want to re-attach
a list of hostdevs back to the host, either on the shutdown path or
via a 'virsh detach-device' call. This function always count
On 2/18/21 9:52 AM, John Ferlan wrote:
On 2/18/21 7:33 AM, Daniel Henrique Barboza wrote:
Commit 76f47889326c4 made qemuNodeDeviceDetachFlags() unusable due to an
'if then else if' chain that will always results in a 'return -1',
regardless of 'driverName' input. This slipped through
.
LUckily John Ferlan caught this up with his Coverity scan and spared us
from an unneeded headache later on.
Fixes: 76f47889326c45d2732711bc6dd5751aaf6e5194
Reported-by: John Ferlan
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 26 +++---
1 file changed
On 2/18/21 8:30 AM, John Ferlan wrote:
On 2/2/21 8:06 PM, Daniel Henrique Barboza wrote:
The validation of 'driverName' does not depend on any other state and can be
done right on the start of the function. We can fail earlier while avoiding
a cleanup jump.
Reviewed-by: Ján Tomko
Signed
On 2/17/21 1:41 PM, Ján Tomko wrote:
On a Tuesday in 2021, Daniel Henrique Barboza wrote:
This script works under two specific conditions. For each opened file,
search for all functions that has ACL calls and store them, and see
if there is a vir*DriverPtr struct declared in it. For each
Ping for reviews (patches 1-4 and 7-8 already pushed).
On 1/18/21 4:53 PM, Daniel Henrique Barboza wrote:
This is the rebased version of
https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html
with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
fixes
On 2/15/21 2:21 PM, Pavel Hrdina wrote:
Fixes: 184245f53b94fc84f727eb6e8a2aa52df02d69c0
Signed-off-by: Pavel Hrdina
---
Reviewed-by: Daniel Henrique Barboza
src/util/vircgroup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/vircgroup.c b/src/util
,
the pointer to new bandwidth can't be NULL while in the other it
can leading to a crash.
Fixes: d53b09235398c1320ed2f1b45b640823171467ed
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1919619
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
src/qemu
place VIR_FREE with g_free in all *Dispose() functions
datatypes: replace VIR_FREE with g_free in all *Dispose() functions
Series LGTM, just be careful with what I mentioned in patch 10.
All patches:
Reviewed-by: Daniel Henrique Barboza
src/access/viraccessmanager.c | 2
This patch does not apply cleanly. The reason:
On 2/4/21 1:38 AM, Laine Stump wrote:
Signed-off-by: Laine Stump
---
src/rpc/virnetclient.c| 4 ++--
src/rpc/virnetdaemon.c| 6 +++---
src/rpc/virnetlibsshsession.c | 18 +-
src/rpc/virnetsaslcontext.c |
napshot.c | 6 +-
tools/virsh-volume.c| 4 +-
tools/vsh-table.c | 10 +--
tools/vsh.c | 6 +-
110 files changed, 557 insertions(+), 557 deletions(-)
All patches:
Reviewed-by: Daniel Henrique Barboza
On 2/4/21 12:57 AM, Laine Stump wrote:
These functions all cooperate to free memory pointed to by a single
object that contains (doesn't *point to*, but acutally contains)
s/acutally/actually
several sub-objects. They were written to send copies of these
sub-objects to subordinate
Wiederhake
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_validate.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index a060bd98ba..c58d221cf8 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu
---
Reviewed-by: Daniel Henrique Barboza
docs/uri.html.in | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/uri.html.in b/docs/uri.html.in
index f96c2970a5..61917e77b4 100644
--- a/docs/uri.html.in
+++ b/docs/uri.html.in
@@ -421,6 +421,23 @@ Note that parameter
hese cases and unconditionally release the
address in the jump.
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_hotplug.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 882e5d2384..e07dba3c5e 100644
---
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index 0c86fd714f..82e5587a50
other
files to use them to recognize a stub situation. In case the current file
being analyzed is domain_driver.c itself, we'll do a manual check using
aclFuncHelpers to verify that these functions indeed have ACL checks.
Signed-off-by: Daniel Henrique Barboza
---
scripts/check-aclrules.py | 25
at this moment, but we'll fix check-aclrules.py to
verify all the helpers that calls ACL functions in domain_driver.c shortly.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 60 ++
src/hypervisor/domain_driver.h | 4
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index 6ee74d6dff..c08b7d46c5
The validation of 'driverName' does not depend on any other state and can be
done right on the start of the function. We can fail earlier while avoiding
a cleanup jump.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 41
The validation of 'driverName' does not depend on any other state and can be
done right on the start of the function. We can fail earlier while avoiding
a cleanup jump.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/libxl/libxl_driver.c | 14 +++---
1 file
Next patch will use g_autoptr() with virNodeDevicePtr for cleanups.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/datatypes.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/datatypes.h b/src/datatypes.h
index ade3779e43..7a88aba0df 100644
--- a/src
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index c559f94348..ea4c3c9466
Daniel Henrique Barboza (10):
qemu, libxl, hypervisor: use virDomainDriverNodeDeviceReset() helper
datatypes.h: register AUTOPTR_CLEANUP_FUNC for virNodeDevicePtr
domain_driver.c: use g_auto* in virDomainDriverNodeDeviceReset()
qemu, libxl, hypervisor: use virDomainDriverNodeDeviceReAttach
libxlNodeDeviceReset() and qemuNodeDeviceReset() are mostly equal,
differing only how the virHostdevManager pointer is retrieved.
Put the common code into virDomainDriverNodeDeviceReset() to reduce
code duplication.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src
libxlNodeDeviceReAttach() and qemuNodeDeviceReAttach() are mostly equal,
differing only how the virHostdevManager pointer is retrieved.
Put the common code into virDomainDriverNodeDeviceReAttach() to reduce
code duplication.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
On 2/2/21 1:35 PM, Daniel P. Berrangé wrote:
The check-aclrules.py script has some logic which looks to see if
the method contains a function call that resolves to another
public API entrypoint, as a special case.
So basically we'll need to process the hypervisor_driver.c file to
extract a
On 2/2/21 1:35 PM, Daniel P. Berrangé wrote:
On Tue, Feb 02, 2021 at 05:32:14PM +0100, Ján Tomko wrote:
On a Tuesday in 2021, Daniel P. Berrangé wrote:
On Tue, Feb 02, 2021 at 05:18:51PM +0100, Ján Tomko wrote:
On a Monday in 2021, Daniel Henrique Barboza wrote:
libxlNodeDeviceDetachFlags
This patch won't compile in my env:
domain_conf.c.o -c ../src/conf/domain_conf.c
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:32,
from /usr/include/glib-2.0/glib/galloca.h:32,
from
This patch is making the 'check-remote-protocol' test error out in
my env:
Ok: 305
Expected Fail: 0
Fail: 1
Unexpected Pass:0
Skipped:4
Timeout:0
The output from the failed tests:
12/310 libvirt / check-remote_protocol
it standalone.
Thanks,
DHB
On 1/18/21 4:53 PM, Daniel Henrique Barboza wrote:
This is the rebased version of
https://www.redhat.com/archives/libvir-list/2021-January/msg00028.html
with master at 57b1ddcaaa5b5. No changes made aside from trivial conflicts
fixes.
I also removed the military jargon
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index 6ee74d6dff..c08b7d46c5 100644
--- a/src/hypervisor
Hi,
This series reduces code duplication between qemu_driver.c and
libxl_driver.c by adding common code, related to NodeDevicePtr
driver functions, into helper functions in domain_driver.c.
No functional change was made.
Daniel Henrique Barboza (9):
qemu, libxl, hypervisor: use
The validation of 'driverName' does not depend on any other state and can be
done right on the start of the function. We can fail earlier while avoiding
a cleanup jump.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 41 -
1 file
() helper to reduce
code duplication between them. 'driverName' is checked inside the helper
to set the appropriate stub driver.
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 60 ++
src/hypervisor/domain_driver.h | 4 +++
src
libxlNodeDeviceReAttach() and qemuNodeDeviceReAttach() are mostly equal,
differing only how the virHostdevManager pointer is retrieved.
Put the common code into virDomainDriverNodeDeviceReAttach() to reduce
code duplication.
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor
libxlNodeDeviceReset() and qemuNodeDeviceReset() are mostly equal,
differing only how the virHostdevManager pointer is retrieved.
Put the common code into virDomainDriverNodeDeviceReset() to reduce
code duplication.
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 58
The validation of 'driverName' does not depend on any other state and can be
done right on the start of the function. We can fail earlier while avoiding
a cleanup jump.
Signed-off-by: Daniel Henrique Barboza
---
src/libxl/libxl_driver.c | 14 +++---
1 file changed, 7 insertions(+), 7
Next patch will use g_autoptr() with virNodeDevicePtr for cleanups.
Signed-off-by: Daniel Henrique Barboza
---
src/datatypes.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/datatypes.h b/src/datatypes.h
index ade3779e43..7a88aba0df 100644
--- a/src/datatypes.h
+++ b/src/datatypes.h
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index c559f94348..ea4c3c9466 100644
--- a/src
Signed-off-by: Daniel Henrique Barboza
---
src/hypervisor/domain_driver.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c
index 0c86fd714f..82e5587a50 100644
--- a/src
.
I suggest adding in the end of the commit message something in the lines
of "No user visible changes were made", making it clear that you didn't
change the behavior of setmem and setmaxmem flags.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Michal Privoznik
---
t
On 1/29/21 10:04 AM, Michal Privoznik wrote:
On 1/29/21 1:30 PM, Daniel Henrique Barboza wrote:
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
builds libvirt
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
builds libvirt is fast enough to run every test under 30 seconds
(each test binary has its own timeout, but still).
-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
---
src/conf/domain_validate.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index dd4c6e0fb3..a2f236c299 100644
--- a/src/conf/domain_validate.c
On 1/22/21 6:19 PM, David Hildenbrand wrote:
Out of curiosity: are you aware of anyone working in enabling virtio-mem
for pseries/ppc64? I'm wondering if there's some kind of architecture
limitation in Power or if it's just a lack of interest.
I remember there is interest, however:
-
On 1/22/21 4:54 PM, David Hildenbrand wrote:
Am 22.01.2021 um 19:53 schrieb Daniel Henrique Barboza :
On 1/22/21 9:50 AM, Michal Privoznik wrote:
Technically, this is another version of:
https://www.redhat.com/archives/libvir-list/2020-December/msg00199.html
But since virtio-pmem part
201 - 300 of 1918 matches
Mail list logo
