Re: [libvirt] [RFC PATCH 06/10] qemu: implement state driver shutdown function

2018-01-10 Thread Daniel P. Berrange
On Wed, Jan 10, 2018 at 12:23:31PM -0500, John Ferlan wrote: > From: Nikolay Shirokovskiy > > Shutdown function should help API calls to finish when > event loop is not running anymore. For this reason let's > close agent and qemu monitors. These function will

Re: [libvirt] [PATCH 00/17] CPU models and features for Spectre, CVE-2017-5715

2018-01-10 Thread Daniel P. Berrange
On Tue, Jan 09, 2018 at 11:45:13PM +0100, Jiri Denemark wrote: > This is the libvirt's part of the changes related to CVE-2017-5715. The > new models can be used to pass the protective CPU features to guests. > But remember, the host CPU microcode, host kernel, QEMU, and libvirt all > need to be

Re: [libvirt] [PATCH 0/5] Refresh QEMU caps when CPU microcode changes (Related CVE-2017-5715)

2018-01-10 Thread Daniel P. Berrange
No description so people might not have realized the implications of this patch series This patch series is a pre-requisite for the future patches that address the Spectre vulnerability. Those QEMU patches will introduce various new CPU models. When the Intel microcode update is installed, we

Re: [libvirt] RFC: Introduce a dlm-corosync for Lock manager plugin

2017-12-22 Thread Daniel P. Berrange
On Fri, Dec 22, 2017 at 12:59:24AM -0700, Lin Fu wrote: > > How are locks acquired by libdlm scoped ? The reason we have virtlockd is > > that the fcntl() locks need to be held by a running process, and we wanted > > them to persist across libvirtd restarts. This required holding them in a > >

Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

2017-12-22 Thread Daniel P. Berrange
On Fri, Dec 22, 2017 at 10:52:45AM +0300, Nikolay Shirokovskiy wrote: > > > On 21.12.2017 15:14, Erik Skultety wrote: > > On Thu, Dec 21, 2017 at 12:48:44PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 21.12.2017 11:49, Erik Skultety wrote: > >>> On Thu, Dec 21, 2017 at 09:39:16AM +0100,

Re: [libvirt] Executing gdb/gcore as an on_crash action

2017-12-21 Thread Daniel P. Berrange
On Thu, Dec 21, 2017 at 11:22:48AM +0100, Sergio Lopez wrote: > Hi, > > Right now, the actions coredump-[destroy|restart] for on_crash work in > a similar way as "virsh dump", requesting a dump of Guest's memory > contents to QEMU. > > I think it'd be nice to have the ability for executing

[libvirt] [PATCH 2/5] conf: expose APIs to let drivers load individual config / status files

2017-12-20 Thread Daniel P. Berrange
Currently drivers can only do a bulk load of config / status files for their guests. This exposes some helper methods to allow individual guests to be loaded. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/conf/virdomainobjlist.

[libvirt] [PATCH 0/5] Proof of concept for libvirt_qemu shim process

2017-12-20 Thread Daniel P. Berrange
lots of code rewiring for API execution. Daniel P. Berrange (5): conf: allow different resource registration modes conf: expose APIs to let drivers load individual config / status files qemu: add a public API to trigger QEMU driver to connect to running guest qemu: implement the

[libvirt] [PATCH 1/5] conf: allow different resource registration modes

2017-12-20 Thread Daniel P. Berrange
to. This change adds ability to configure the mechanism for registering resources between all these options explicitly. via Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/conf/domain_conf.c | 42 ++--- src/conf/domain_conf.h | 12

[libvirt] [PATCH 4/5] qemu: implement the new virDomainQemuReconnect method

2017-12-20 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/qemu/qemu_driver.c | 57 + src/qemu/qemu_process.c | 31 ++- src/qemu/qemu_process.h | 1 + 3 files changed, 79 insertions(+), 10 deletions(-) diff

[libvirt] [PATCH 5/5] qemu: implement the 'libvirt_qemu' shim for launching guests externally

2017-12-20 Thread Daniel P. Berrange
e we need to be able to ultimately restart the libvirt_qemu shim in order to apply software updates to running instance. We might wire up a special signal though to let you kill libvirt_qemu & take out QEMU at same time eg SIGQUIT or something like that perhaps. Signed-off-by:

[libvirt] [PATCH 3/5] qemu: add a public API to trigger QEMU driver to connect to running guest

2017-12-20 Thread Daniel P. Berrange
, and simply runs the normal reconnect logic that the QEMU driver would do at startup. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- include/libvirt/libvirt-qemu.h | 4 src/driver-hypervisor.h| 5 + src/libvirt-qemu.c

Re: [libvirt] RFC: Introduce a dlm-corosync for Lock manager plugin

2017-12-20 Thread Daniel P. Berrange
On Wed, Dec 20, 2017 at 03:11:48PM +0800, Fu.Lin wrote: > Hi, > > Currently the lock manager infrastructure has implementation of nop, sanlock > and lockd. The first do nothing, while sanlock and lockd all requires the > share > stroage, and lockd is not provided fence mechanism, sanlock would

Re: [libvirt] [PATCH] treat host models as case-insensitive strings

2017-12-20 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 02:24:47PM -0600, Scott Garfinkle wrote: > On Tue, 2017-12-19 at 20:05 +0100, Jiri Denemark wrote: > > On Tue, Dec 19, 2017 at 12:39:26 -0600, Scott Garfinkle wrote: > > > Qemu now allows case-insensitive specification of CPU models. This fixes > > > the > > > resulting

Re: [libvirt] [PATCH v3 2/6] libxl: do not enable nested HVM by mere presence of element

2017-12-20 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 08:44:48PM +0100, Marek Marczykowski-Górecki wrote: > On Tue, Dec 19, 2017 at 01:45:57PM +0000, Daniel P. Berrange wrote: > > On Tue, Dec 19, 2017 at 01:43:24PM +, Joao Martins wrote: > > > On 12/19/2017 01:13 PM, Daniel P. Berrange wrote: > >

Re: [libvirt] [PATCH v3 2/6] libxl: do not enable nested HVM by mere presence of element

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 01:43:24PM +, Joao Martins wrote: > On 12/19/2017 01:13 PM, Daniel P. Berrange wrote: > > On Tue, Dec 19, 2017 at 01:01:36PM +, Joao Martins wrote: > >> [Sorry for double posting, but I mistakenly forgot to include libvirt list) >

Re: [libvirt] [PATCH v3 2/6] libxl: do not enable nested HVM by mere presence of element

2017-12-19 Thread Daniel P. Berrange
On Tue, Dec 19, 2017 at 01:01:36PM +, Joao Martins wrote: > [Sorry for double posting, but I mistakenly forgot to include libvirt list) > > +WimT +Daniel > > On 12/10/2017 02:10 AM, Marek Marczykowski-Górecki wrote: > > element may be used to configure other > > features, like NUMA, or

[libvirt] [PATCH] rpc: fix race sending and encoding sasl data

2017-12-18 Thread Daniel P. Berrange
noticed at all. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetsocket.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index 23089afef4..2d41a716ba 100644 --- a/src/rpc/virnetso

Re: [libvirt] Qemu capability probes lifecycle should be tied to libvirtd

2017-12-18 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 03:22:57PM +0100, Christian Ehrhardt wrote: > Hi, > on libvirt 3.10 I see a set of qemu processes used for capability > probing [1] (in my case 8x x86_64 and 3xi386 which seems a lot, but > ok). > But when stopping the service those still stay around [2]. > > That is

Re: [libvirt] libvirt wiki account request

2017-12-18 Thread Daniel P. Berrange
On Mon, Dec 18, 2017 at 02:25:47PM +0100, Ján Tomko wrote: > Hello. > > On 5th anniversary of commit 9d92bf1 I would like to request > a libvirt wiki account. > > login:jtomko > e-mail: jto...@redhat.com > password: hunter2 Created, but I'll send you a different password that isn't

Re: [libvirt] [perl] Fix check of return value from virStreamRecv*

2017-12-18 Thread Daniel P. Berrange
.xs | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berra

Re: [libvirt] [PATCH 08/14] rpc: Refactor the condition whether a client needs authentication

2017-12-15 Thread Daniel P. Berrange
On Tue, Dec 12, 2017 at 12:36:30PM +0100, Marc Hartmayer wrote: > Add virNetServerClientAuthMethodImpliesAuthenticated() for deciding > whether a authentication method implies that a client is automatically > authenticated or not. Use this new function in > virNetServerClientNeedAuth(). > >

Re: [libvirt] [PATCH 05/14] rpc: Be more precise in which cases the authentication is needed

2017-12-15 Thread Daniel P. Berrange
On Tue, Dec 12, 2017 at 12:36:27PM +0100, Marc Hartmayer wrote: > Additionally, use a whitelist model to decide whether authentication > is needed or not. Is this actually fixing any real problem, if so please document what the problem is. AFAICT, this is mostly just a case of painting the

Re: [libvirt] [RFC] 5-level paging Support

2017-12-13 Thread Daniel P. Berrange
On Wed, Dec 13, 2017 at 08:43:38PM +0800, Feng, Shaohe wrote: > Hi all, > > Now both qemu and kvm support 5-level paging. > > We can start qemu with a "cpu,+la57" to set 57-bit vitrual address space. > > So VM can be aware that it need to enable 5-level paging. > > > We can also set another

Re: [libvirt] [PATCH v2] autogen.sh: tell user the correct make command

2017-12-13 Thread Daniel P. Berrange
On Wed, Dec 13, 2017 at 11:00:34AM +0100, Andrea Bolognani wrote: > On Tue, 2017-12-12 at 15:57 +0000, Daniel P. Berrange wrote: > > When autogen.sh finishes it helpfully prints > > > > "Now type 'make' to compile libvirt." > > > > which is fine if o

[libvirt] [PATCH] virsh: fix typo s/node filters/network filters/

2017-12-12 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed under trivial rule tools/virsh-nwfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index 0f64c446f3..40bc193ad5 100644 --- a/tools/virsh-nwfilter.c

[libvirt] [PATCH v2] autogen.sh: tell user the correct make command

2017-12-12 Thread Daniel P. Berrange
oo "GNU make is required to build libvirt" Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- autogen.sh | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index d5d836aa71..ea94528de6 100755 --- a/autogen.sh

Re: [libvirt] [PATCH 6/6] util: Don't report CPU frequency for ARM hosts

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 06:14:54PM +0100, Andrea Bolognani wrote: > On Mon, 2017-12-11 at 16:46 +0000, Daniel P. Berrange wrote: > > On Mon, Dec 11, 2017 at 05:40:36PM +0100, Andrea Bolognani wrote: > > > Some ARM platforms, such as the original Raspberry Pi, report the &

Re: [libvirt] [PATCH 6/6] util: Don't report CPU frequency for ARM hosts

2017-12-11 Thread Daniel P. Berrange
On Mon, Dec 11, 2017 at 05:40:36PM +0100, Andrea Bolognani wrote: > Some ARM platforms, such as the original Raspberry Pi, report the > CPU frequency in the BogoMIPS field of /proc/cpuinfo, so libvirt > parsed that field and returned it through its API. > > However, not only many more boards

Re: [libvirt] Add iSER support in libvirt

2017-12-07 Thread Daniel P. Berrange
On Thu, Dec 07, 2017 at 08:52:43PM +0800, Charles Kelimod wrote: > I want to add iSER support in libvirt project, how can I submit (if > possible) my modification to it? We welcome patches from anyone who is interested - there's some useful info in: https://libvirt.org/hacking.html#patches

[libvirt] [PATCH] docs: remove outdated link to Fedora mingw staging repo

2017-12-06 Thread Daniel P. Berrange
The Fedora mingw support is all merged in Fedora repos, so remove the outdated link. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/windows.html.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/windows.html.in b/docs/windows.html.in

[libvirt] [PATCH] docs: update entries in the apps page

2017-12-06 Thread Daniel P. Berrange
Change all links to https:// where the remote site supports it. Fix URLs for a few packages that moved, and delete entries which appear to be dead. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/apps.html.in | 70 ---

[libvirt] [PATCH] docs: update instructions for TLS cert generation

2017-12-06 Thread Daniel P. Berrange
hostnames and IP addresses. This will help users avoid the classic mistake and is important future proofing, since at least in browsers, TLS libraries no longer use the CN field for validation, mandating use of SAN info instead. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH] nwfilter: remove bogus 'protocolid' attribute on arp/rarp fields

2017-12-06 Thread Daniel P. Berrange
Various example XML documents for arp/rarp filtering have a protocolid XML attribute defined. This is never parsed or output by the libvirt XML handling code, so shouldn't be present in example XML files either Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH] rng: fix nwfilter rule contents

2017-12-06 Thread Daniel P. Berrange
The contents of a are a choice of exactly one union member. The RNG schema, however, was allowing an arbitrary number of instances of every union member at once. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/schemas/nwfilter.rn

Re: [libvirt] [sandbox 1/6] Pass debug and verbose values to init

2017-12-06 Thread Daniel P. Berrange
On Wed, Dec 06, 2017 at 01:56:23PM +0100, Cedric Bosdonnat wrote: > On Tue, 2017-12-05 at 16:52 +0000, Daniel P. Berrange wrote: > > On Tue, Dec 05, 2017 at 10:53:17AM +0100, Cédric Bosdonnat wrote: > > > libvirt-sandbox-init-common is expecting -d and -v parameters to >

Re: [libvirt] [sandbox 5/6] Convert to python3

2017-12-06 Thread Daniel P. Berrange
On Wed, Dec 06, 2017 at 01:50:56PM +0100, Cedric Bosdonnat wrote: > On Tue, 2017-12-05 at 16:57 +0000, Daniel P. Berrange wrote: > > On Tue, Dec 05, 2017 at 10:53:21AM +0100, Cédric Bosdonnat wrote: > > > Python2 is going to die soon, convert to python3. > > > > I

[libvirt] [PATCH jenkins-ci] Trigger rebuild of libvirt-go-xml when libvirt changes

2017-12-06 Thread Daniel P. Berrange
Although the core code in libvirt-go-xml doesn't depend on libvirt, the test suite pulls in libvirt.git to validate XML parsing against all XML files found under libvirt.git/tests. We should thus have a dependancy in jenkins to trigger rebuilds when libvirt changes. Signed-off-by: Daniel P

Re: [libvirt] [sandbox 6/6] Don't hardcode interpreter path

2017-12-05 Thread Daniel P. Berrange
| 2 +- > libvirt-sandbox/image/cli.py | 2 +- > libvirt-sandbox/image/sources/base.py| 1 - > libvirt-sandbox/image/sources/docker.py | 1 - > libvirt-sandbox/image/sources/virtbuilder.py | 1 - > 10 files changed, 7 insertions(+), 10 deletio

Re: [libvirt] [sandbox 5/6] Convert to python3

2017-12-05 Thread Daniel P. Berrange
On Tue, Dec 05, 2017 at 10:53:21AM +0100, Cédric Bosdonnat wrote: > Python2 is going to die soon, convert to python3. I'm unclear whether this change drops py2 support, or whether it makes it work with py2+3 in parallel. The commit message suggests py3 only, but then this: > @@ -418,6 +416,18

Re: [libvirt] [sandbox 4/6] service: fix bad ConfigMountHostImage constructor call

2017-12-05 Thread Daniel P. Berrange
on(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.in

Re: [libvirt] [sandbox 3/6] Add tests .log and .trs files to gitignore

2017-12-05 Thread Daniel P. Berrange
On Tue, Dec 05, 2017 at 10:53:19AM +0100, Cédric Bosdonnat wrote: > --- > .gitignore | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberra

Re: [libvirt] [sandbox 2/6] machine: use squash security mode for non-root virt-sandbox mounts

2017-12-05 Thread Daniel P. Berrange
sandbox/libvirt-sandbox-builder-machine.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [sandbox 1/6] Pass debug and verbose values to init

2017-12-05 Thread Daniel P. Berrange
| 3 ++ > libvirt-sandbox/libvirt-sandbox-config.c | 75 > +++ > libvirt-sandbox/libvirt-sandbox-config.h | 6 +++ > libvirt-sandbox/libvirt-sandbox-init-common.c | 3 ++ > libvirt-sandbox/libvirt-sandbox.sym | 4 ++ > 5 files change

[libvirt] [PATCH] nwfilter: don't crash listing filters in unprivileged daemon

2017-12-05 Thread Daniel P. Berrange
any places, just make sure driver->nwfilters is always initialized. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/nwfilter/nwfilter_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_dr

Re: [libvirt] [rust PATCH] README: update libvirt.org links

2017-12-05 Thread Daniel P. Berrange
. > --- > Although trivial, I did not push these since I'm not a maintainer. > > README.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > > diff --git a/README.md b/README.md > index 29d38a2..56

Re: [libvirt] [PATCH 3/3] travis: Don't try to install brew packages twice

2017-12-05 Thread Daniel P. Berrange
;$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && > brew install gnutls libgcrypt yajl gettext rpcgen; fi > + - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && > brew install rpcg

Re: [libvirt] [PATCH 2/3] travis: Upgrade brew packages

2017-12-05 Thread Daniel P. Berrange
sx" ]; then brew update && brew install > gnutls libgcrypt yajl gettext rpcgen; fi > + - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && > brew install gnutls libgcrypt yajl gettext rpcgen; fi > > before

Re: [libvirt] [PATCH 1/3] util: gettid() is Linux-specific

2017-12-05 Thread Daniel P. Berrange
read) > * the pthread_self() id on Linux. */ > unsigned long long virThreadSelfID(void) > { > -#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid) > +#if defined(HAVE_SYS_SYSCALL_H) && defined(SYS_gettid) && defined(__linux__) > pid_t tid = sy

Re: [libvirt] [PATCH for 3.11 0/2] qemuxml2argvdata: Drop useless prefix for test cases

2017-12-04 Thread Daniel P. Berrange
On Sat, Dec 02, 2017 at 08:11:48AM +0100, Michal Privoznik wrote: > The patches are trimmed out a lot to fit the size limit of our list. Anyway, > the interesting bits are kept and also you can find the patches at my github: > > https://github.com/zippy2/libvirt/commits/qemuxml2argvdata > > If

[libvirt] [PATCH jenkins-ci] Make args to 'go test' configurable

2017-11-30 Thread Daniel P. Berrange
Each module has its own set of tags it may wish to pass to 'go test', so set it based on an env variable Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- jobs/go.yaml | 2 +- projects/libvirt-go-xml.yaml | 2 ++ projects/libvirt-go.yaml | 2 ++ 3 files chan

Re: [libvirt] [PATCH] Remove non-existant 'wiremode' attribute

2017-11-30 Thread Daniel P. Berrange
On Wed, Nov 29, 2017 at 05:51:13PM -0700, Jim Fehlig wrote: > On 11/29/2017 11:01 AM, Daniel P. Berrange wrote: > > The 'wiremode' attribute exists in a couple of Xen XML files, but no code > > has > > ever parsed that value. It was later added to the RNG schema to

Re: [libvirt] PATCH add q35 support ide

2017-11-30 Thread Daniel P. Berrange
On Thu, Nov 30, 2017 at 09:50:01AM +0800, Paul Schlacter wrote: > hello everyone: > In q35 motherboard use ide, Currently, the qemu has supported q35 > Motherboard support ide bus IIRC, this is not quite correct - q35 has a built-in SATA controller, as opposed to IDE controller. You can

[libvirt] [PATCH] Remove non-existant 'wiremode' attribute

2017-11-29 Thread Daniel P. Berrange
The 'wiremode' attribute exists in a couple of Xen XML files, but no code has ever parsed that value. It was later added to the RNG schema too, again despite there not being any code which parses it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/schemas/domaincomm

[libvirt] [PATCH] Misc XML schema fixes for libxl

2017-11-29 Thread Daniel P. Berrange
The libxlxml2domconfigdata directory was not covered in the RNG schema tests. This hid a few bugs in both the libxl XML files and the RNG schema itself. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/schemas/domaincommon.rng | 3 ++- tests/libxlxml2domconf

Re: [libvirt] [libvirt-python][PATCH] Don't hardcode interpreter path

2017-11-29 Thread Daniel P. Berrange
ent-test.py | 2 +- > generator.py | 2 +- > sanitytest.py | 2 +- > setup.py | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https:

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-28 Thread Daniel P. Berrange
On Tue, Nov 28, 2017 at 10:22:21AM +, Daniel P. Berrange wrote: > On Tue, Nov 28, 2017 at 08:43:54AM +0100, Martin Kletzander wrote: > > Just a quick note on what I've found out after I dedicated half day to go > > through the tour of go and some other tutorials. The learn

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-28 Thread Daniel P. Berrange
On Tue, Nov 28, 2017 at 08:43:54AM +0100, Martin Kletzander wrote: > On Mon, Nov 20, 2017 at 04:57:56PM +0000, Daniel P. Berrange wrote: > > On Mon, Nov 20, 2017 at 05:36:24PM +0100, Martin Kletzander wrote: > > > On Mon, Nov 20, 2017 at 03:25:33PM +, Daniel

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 02:01:06PM +0100, Paolo Bonzini wrote: > On 27/11/2017 13:57, Daniel P. Berrange wrote: > >> Got it. My problem here is that ioctl permission might be too strict. > >> One use case for the helper is to bypass the ioctl permission, and only > &

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 01:49:41PM +0100, Paolo Bonzini wrote: > On 27/11/2017 13:18, Daniel P. Berrange wrote: > > On Mon, Nov 27, 2017 at 12:51:33PM +0100, Paolo Bonzini wrote: > >> On 27/11/2017 12:37, Daniel P. Berrange wrote: > >>> On Mon, Nov 27, 2017 at 12:13:2

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 12:51:33PM +0100, Paolo Bonzini wrote: > On 27/11/2017 12:37, Daniel P. Berrange wrote: > > On Mon, Nov 27, 2017 at 12:13:24PM +0100, Paolo Bonzini wrote: > >> Hm, I see what you mean now. But it would be "just" a qemu-pr-helper > >>

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 12:13:24PM +0100, Paolo Bonzini wrote: > On 27/11/2017 11:59, Daniel P. Berrange wrote: > > On Mon, Nov 27, 2017 at 11:57:56AM +0100, Paolo Bonzini wrote: > >> On 27/11/2017 10:40, Daniel P. Berrange wrote: > >>> > >>> If we h

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Mon, Nov 27, 2017 at 11:57:56AM +0100, Paolo Bonzini wrote: > On 27/11/2017 10:40, Daniel P. Berrange wrote: > > > > If we had one daemon per QEMU, then we would give the daemon the same > > MCS label as QEMU. The kernel will thus enforce this label matches the > >

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-27 Thread Daniel P. Berrange
On Fri, Nov 24, 2017 at 04:42:00PM +0100, Paolo Bonzini wrote: > On 24/11/2017 15:52, Daniel P. Berrange wrote: > >> So what has been suggested so far is: > >> > >> > >> > >> > >> > >> > > without

Re: [libvirt] New QEMU daemon for persistent reservations

2017-11-24 Thread Daniel P. Berrange
On Fri, Nov 24, 2017 at 03:38:54PM +0100, Michal Privoznik wrote: > On 08/22/2017 06:27 PM, Paolo Bonzini wrote: > > Hi all, > > > > Sorry for resurrecting old thread but seems like there was no agreement > reached. > > We don't want to expose any paths because the fact that PR helper is a >

Re: [libvirt] [PATCH] qemu: add support for setting OEM strings SMBIOS data fields

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 05:42:32PM +0100, Ján Tomko wrote: > On Fri, Nov 17, 2017 at 04:48:53PM +0000, Daniel P. Berrange wrote: > > The OEM strings table in SMBIOS allows the vendor to pass arbitrary strings > > into the guest OS. This can be used as a way to pass data to an applic

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 04:58:55PM +0100, Michal Privoznik wrote: > On 11/23/2017 11:42 AM, Daniel P. Berrange wrote: > > On Thu, Nov 23, 2017 at 11:32:19AM +0100, Michal Privoznik wrote: > >> On 11/14/2017 06:25 PM, Daniel P. Berrange wrote: > > The remoteDomainCreate()

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 11:32:26AM +0100, Michal Privoznik wrote: > On 11/14/2017 06:27 PM, Daniel P. Berrange wrote: > > > > This might be more tricky than one would initially think. What about > tests for instance? In our test suite we rely heavily on mocking. For > inst

Re: [libvirt] Redesigning Libvirt: Exploding the libvirtd architecture

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 11:32:14AM +0100, Michal Privoznik wrote: > On 11/14/2017 06:26 PM, Daniel P. Berrange wrote: > > The solution(s) > > === > > > > As noted above, we made some baby-steps towards a modular daemon > > architecture > > w

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 11:32:19AM +0100, Michal Privoznik wrote: > On 11/14/2017 06:25 PM, Daniel P. Berrange wrote: > > The problem(s) > > == > > > > > > > As mentioned earlier, if an application is only concerned with managing of > >

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

2017-11-23 Thread Daniel P. Berrange
On Thu, Nov 23, 2017 at 11:32:13AM +0100, Michal Privoznik wrote: > On 11/15/2017 06:57 PM, Richard W.M. Jones wrote: > > On Tue, Nov 14, 2017 at 05:25:03PM +0000, Daniel P. Berrange wrote: > >> I would anticipate a standalone process "libvirt-qemu" that an > >

Re: [libvirt] [PATCH 5/6] qemu: implement element for devices

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 10:52:48AM -0500, John Ferlan wrote: > > > On 11/21/2017 08:42 AM, Pavel Hrdina wrote: > > On Mon, Nov 20, 2017 at 07:44:25PM -0500, John Ferlan wrote: > >> > >> > >> On 11/14/2017 08:45 AM, Pavel Hrdina wrote: > >>> So far we were configuring the sound output based on

Re: [libvirt] [PATCH 4/6] conf: introduce element for devices

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 14, 2017 at 02:45:09PM +0100, Pavel Hrdina wrote: > So far it was not possible to specify how the audio output from guest > should be presented to host/users. Now it will be possible to do so > via element for device where you specify the output > "type". > > Signed-off-by: Pavel

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 01:21:26PM +0100, Pavel Hrdina wrote: > On Tue, Nov 21, 2017 at 12:09:54PM +0000, Daniel P. Berrange wrote: > > On Tue, Nov 21, 2017 at 01:02:05PM +0100, Peter Krempa wrote: > > > On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > >

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 01:02:05PM +0100, Peter Krempa wrote: > On Tue, Nov 21, 2017 at 11:48:20 +, Daniel Berrange wrote: > > On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > > > On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > > > > IOW, I don't think this

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 12:57:36PM +0100, Pavel Hrdina wrote: > On Tue, Nov 21, 2017 at 11:24:06AM +0000, Daniel P. Berrange wrote: > > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > > If there is no sound device configured for the guest we can disable the

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 21, 2017 at 12:44:44PM +0100, Peter Krempa wrote: > On Tue, Nov 21, 2017 at 11:24:06 +, Daniel Berrange wrote: > > On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > > > If there is no sound device configured for the guest we can disable the > > > audio output because

Re: [libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

2017-11-21 Thread Daniel P. Berrange
On Tue, Nov 14, 2017 at 02:45:08PM +0100, Pavel Hrdina wrote: > If there is no sound device configured for the guest we can disable the > audio output because hot-plugging sound devices isn't supported. Are you sure about that. While libvirt may not have wired up ability to hotplug sound devices,

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-20 Thread Daniel P. Berrange
On Mon, Nov 20, 2017 at 05:36:24PM +0100, Martin Kletzander wrote: > On Mon, Nov 20, 2017 at 03:25:33PM +0000, Daniel P. Berrange wrote: > > > > I shouldn't have used the word "allocation" in my paragraph above. As > > you say, both languages have similar needs ar

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

2017-11-20 Thread Daniel P. Berrange
On Sun, Nov 19, 2017 at 10:21:32PM +0100, Martin Kletzander wrote: > On Wed, Nov 15, 2017 at 06:19:38PM +0000, Daniel P. Berrange wrote: > > On Wed, Nov 15, 2017 at 05:57:45PM +, Richard W.M. Jones wrote: > > > On Tue, Nov 14, 2017 at 05:25:03PM +, Daniel P. Berrange wrot

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-20 Thread Daniel P. Berrange
On Mon, Nov 20, 2017 at 12:24:22AM +0100, Martin Kletzander wrote: > On Tue, Nov 14, 2017 at 05:27:01PM +0000, Daniel P. Berrange wrote: > > [...] > > > I don't have direct experiance in Rust, but it has the same kind of > > benefits over > > C as Go doe

[libvirt] [PATCH] qemu: add support for setting OEM strings SMBIOS data fields

2017-11-17 Thread Daniel P. Berrange
of a application specific prefix as illustrated above is recommended so that an app can reliably identify which of the many OEM strings are targetted at it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- NB, the QEMU side of this patch is queued but won't merge until 2.12 opens up for dev wo

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 10:04:35AM -0600, Chris Friesen wrote: > On 11/17/2017 06:37 AM, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 01:34:54PM +0100, Markus Armbruster wrote: > > > "Daniel P. Berrange" <berra...@redhat.com> writes: > > > &

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:53:13PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:47, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: > > Ah I see. I think this smells like a bug in the tests/Makefile.am &g

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:40, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 17.11.2017 16:24, Daniel P. Berrange

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:24, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: > >> If one of the libraries is compiled with tcmalloc then

Re: [libvirt] [PATCH 2/2] tests: fix typo

2017-11-17 Thread Daniel P. Berrange
++- > tests/commanddata/test7.log | 3 ++- > tests/commanddata/test9.log | 3 ++- > tests/commandtest.c | 2 +- > 15 files changed, 29 insertions(+), 15 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: > If one of the libraries is compiled with tcmalloc then > the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to > environment at startup and thus break commandtest. How are they getting those envs into our environment

Re: [libvirt] [PATCH v2] docs: add a page describing support guarantees for libvirt features

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 07:57:23AM -0500, John Ferlan wrote: > > > On 11/17/2017 06:36 AM, Daniel P. Berrange wrote: > > While we have collective knowledge about the support status of various > > parts of libvirt, this has never been formally documented, leaving o

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 01:34:54PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" <berra...@redhat.com> writes: > > [...] > > Goroutines are basically a union of the thread + coroutine concepts. The > > Go runtime will create N OS level threads, wher

[libvirt] [PATCH v2] docs: add a page describing support guarantees for libvirt features

2017-11-17 Thread Daniel P. Berrange
interface. THis accepts the reality that we can a) never change it without breaking compat with old libvirt.so, b) there are both rust + go impls that are written against the RPC protocol alrady. Reviewed-by: Jim Fehlig <jfeh...@suse.com> Signed-off-by: Daniel P. Berrange <berra...@r

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-17 Thread Daniel P. Berrange
On Thu, Nov 16, 2017 at 04:55:55PM -0500, John Ferlan wrote: > On 11/14/2017 12:27 PM, Daniel P. Berrange wrote: > > When libvirt was created, C was the only viable choice for anything aiming > > to be > > a core system library component. At that time 2005, aside from C

Re: [libvirt] [PATCH] virt-viewer.spec.in: fix build after spice-xpi-client removal

2017-11-16 Thread Daniel P. Berrange
ff-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > virt-viewer.spec.in | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/d

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Use {smp} in osinfo-db-master-build

2017-11-16 Thread Daniel P. Berrange
jects/osinfo-db.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://

Re: [libvirt] [jenkins-ci PATCH 1/2] jobs: Use $MAKE in autotools-mingw-job

2017-11-16 Thread Daniel P. Berrange
- > jobs/autotools.yaml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [jenkins-ci PATCH] projects: Port libvirt-cim to autotools-*-job

2017-11-16 Thread Daniel P. Berrange
./configure --prefix=$VIRT_PREFIX > -$MAKE -j{smp} > -$MAKE -j{smp} install > - - generic-rpm-job: > + - autotools-rpm-job: >parent_jobs: 'libvirt-cim-master-build' > - command: | > -{make_env} > -sed -i -e "s

Re: [libvirt] [cim PATCH 0/3] autogen.sh improvements

2017-11-16 Thread Daniel P. Berrange
: Support running out-of-tree > > autogen.sh | 48 +--- > 1 file changed, 37 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.fli

[libvirt] [PATCH] docs: add a page describing support guarantees for libvirt features

2017-11-16 Thread Daniel P. Berrange
While we have collective knowledge about the support status of various parts of libvirt, this has never been formally documented, leaving our users to guess. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/docs.html.in| 3 + docs/support.html.in

[libvirt] [PATCH] docs: don't use https in XML namespace URIs

2017-11-16 Thread Daniel P. Berrange
The XML namespace URI for the QEMU/LXC drivers must use http as the protocol otherwise it won't match the parser's expectations. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/drvlxc.html.in | 2 +- docs/drvqemu.html.in | 4 ++-- 2 files changed, 3 insertions(+), 3 del

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

2017-11-16 Thread Daniel P. Berrange
On Thu, Nov 16, 2017 at 02:58:33PM +0100, Peter Krempa wrote: > On Tue, Nov 14, 2017 at 17:27:01 +, Daniel Berrange wrote: > > The Problem(s) > > == > > Note at first: This is a personal opinion. I'm not discrediting any > advantages a different language might have in technical

<    1   2   3   4   5   6   7   8   9   10   >