Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 04:58:52PM +0100, Andrea Bolognani wrote: > On Wed, 2017-02-15 at 09:24 +0000, Daniel P. Berrange wrote: > [...] > > $ virsh start f22-arm32 > > error: Failed to start domain f22-arm32 > > error: internal error: qemu unexpectedly closed the monito

Re: [libvirt] [PATCH 5/5] qemu: add rendernode argument

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:13AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new attribute 'rendernode' to spice element. > > Give it to QEMU if qemu supports it (queued for 2.9). > > Signed-off-by: Marc-André Lureau > --- > docs/formatdomain.html.in

Re: [libvirt] [PATCH 4/5] nodedev: add drm capability

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:12AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new 'drm' capability for Direct Rendering Manager (DRM) devices, > providing device type information. > > Teach the udev backend to populate those devices. > > Signed-off-by: Marc-An

Re: [libvirt] [PATCH 3/5] nodedev: parse

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:11AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This should have been added with c4a4603de (or 0bdefd9b04). Technically the node dev parser only needs to parse enough to deal with NPIV device creation - everything else is output only. Bu

Re: [libvirt] [PATCH 2/5] nodedev: add paths

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:10AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add new top-level element, that list the associated > /dev files. Distinguish the main /dev name from symlinks with a 'type' > attribute of value 'dev' or 'symlink'. > > Update a test to

Re: [libvirt] [PATCH 1/5] nodedev: fix extra space in dump

2017-02-16 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 01:04:09AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is a cosmetic change, shouldn't change XML parsing, and doesn't > break any test. > > Signed-off-by: Marc-André Lureau > --- > src/conf/node_device_conf.c | 2 +- > 1 file changed, 1

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > have the following interface configuration: > > > > > > This resulted in -netdev tap,script=,.. Fortunately, qemu helped > us to get away with this as

Re: [libvirt] [PATCH] qemu_conf: Check for namespaces availability more wisely

2017-02-15 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 11:19:24AM +0100, Michal Privoznik wrote: > On 02/15/2017 10:43 AM, Daniel P. Berrange wrote: > > On Wed, Feb 15, 2017 at 10:20:27AM +0100, Michal Privoznik wrote: > >> The bare fact that mnt namespace is available is not enough for > >> us to a

Re: [libvirt] [PATCH go v2] domain.go: construct cpumaps correctly for CPU pinning verbs

2017-02-15 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 05:11:07PM -0500, Leonid Podolny wrote: > In PinEmulator() and PinIOThread() there is an identical code that > converts []bool into a bitmask. It calculates the location in the > bitmask and then sets it always to 1, instead of looking at the > actual bool value. > --- > do

Re: [libvirt] [PATCH] qemu_conf: Check for namespaces availability more wisely

2017-02-15 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 10:20:27AM +0100, Michal Privoznik wrote: > The bare fact that mnt namespace is available is not enough for > us to allow/enable qemu namespaces feature. There are other > requirements: we must copy all the ACL & SELinux labels otherwise > we might grant access that is admin

[libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

2017-02-15 Thread Daniel P. Berrange
$ cat arm.xml f22-arm32 a6bc14fb-585b-40b0-a15b-5e19f26079ba 1048576 1048576 1 hvm destroy restart restart /usr/bin/qemu-system-arm $ virsh define arm.xml Domain f22-arm32 defined from

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 05:47:27PM +0100, Andrea Bolognani wrote: > On Tue, 2017-02-14 at 16:20 +0000, Daniel P. Berrange wrote: > > > On the other hand, we really only care about having the ACL > > > APIs when we are isolating QEMU, which only happens of Linux > &

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 05:14:33PM +0100, Andrea Bolognani wrote: > On Tue, 2017-02-14 at 16:00 +0000, Daniel P. Berrange wrote: > > Your platform has libacl available so it is not difficult to fix that > > by building with libacl support. We print out the configure summary > &g

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 04:55:05PM +0100, Michal Privoznik wrote: > On 02/14/2017 04:40 PM, Daniel P. Berrange wrote: > > On Tue, Feb 14, 2017 at 04:33:09PM +0100, Andrea Bolognani wrote: > >> When we're building a private /dev for the isolated QEMU > >> process,

Re: [libvirt] [PATCH 2/4] configure: Make ACL mandatory when building the QEMU driver

2017-02-14 Thread Daniel P. Berrange
On Tue, Feb 14, 2017 at 04:33:09PM +0100, Andrea Bolognani wrote: > When we're building a private /dev for the isolated QEMU > process, we want to be able to replicate the contents of > the original /dev as closely as possible, including ACLs. > > To ensure that's always possible, make ACL support

Re: [libvirt] [PATCH] RFC: qemu: add spice/virgl rendernode

2017-02-13 Thread Daniel P. Berrange
On Mon, Feb 13, 2017 at 08:08:20AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Feb 13, 2017 at 07:19:04AM -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Mon, Feb 13, 2017 at 03:51:48PM +0400, marcandre.lur...@redh

Re: [libvirt] [PATCH] RFC: qemu: add spice/virgl rendernode

2017-02-13 Thread Daniel P. Berrange
On Mon, Feb 13, 2017 at 07:19:04AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Feb 13, 2017 at 03:51:48PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > I am working on a WIP series to add QEMU Spice/virgl rendernode opti

Re: [libvirt] [PATCH] RFC: qemu: add spice/virgl rendernode

2017-02-13 Thread Daniel P. Berrange
On Mon, Feb 13, 2017 at 03:51:48PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > I am working on a WIP series to add QEMU Spice/virgl rendernode option. > Since rendernodes are not stable across reboots, I propose that QEMU > accepts also a PCI address (other bus types m

Re: [libvirt] [RFC] Substitute poll by epoll in virEventPollRunOnce

2017-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2017 at 04:29:27PM +0300, Derbyshev Dmitriy wrote: > From: Derbyshev Dmitry > > This makes it possible to avoid allocations in > virEventPollMakePollFDs, as well as generally reduces time spent in > kernel if handles remain the same, which should generally be true. Yep, there's n

Re: [libvirt] [PATCH] qemu: Forbid slashes in shmem name

2017-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2017 at 09:07:36AM -0500, John Ferlan wrote: > > > On 02/02/2017 08:14 AM, Martin Kletzander wrote: > > With that users could access files outside /dev/shm. That itself > > isn't a security problem, but might cause some errors we want to > > avoid. So let's forbid slashes as we

Re: [libvirt] [PATCH 1/2] vz: fix handle leak in prlsdkHandleVmStateEvent

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 06:28:33PM +0300, Maxim Nestratov wrote: > Every successful call of PrlEvent_GetParamByName allocates a handle, > which has to be freed. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vz/vz_sdk.c b/

Re: [libvirt] [PATCH 2/2] vz: fix event handle leak in prlsdkHandlePerfEvent

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 06:28:34PM +0300, Maxim Nestratov wrote: > When we happen to lose a domain but still get a performance event > for it, we should also free the event handle. > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_sdk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(

Re: [libvirt] [PATCH] qemu: Allow /dev/dri/renderD128

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 11:28:33AM +0100, Michal Privoznik wrote: > On 02/08/2017 11:16 AM, Daniel P. Berrange wrote: > > On Wed, Feb 08, 2017 at 10:44:53AM +0100, Michal Privoznik wrote: > >> On 02/08/2017 10:31 AM, Daniel P. Berrange wrote: > >>> On Wed, Feb 08, 20

Re: [libvirt] [PATCH] qemu: Allow /dev/dri/renderD128

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 10:44:53AM +0100, Michal Privoznik wrote: > On 02/08/2017 10:31 AM, Daniel P. Berrange wrote: > > On Wed, Feb 08, 2017 at 10:26:26AM +0100, Michal Privoznik wrote: > >> This demand comes from qemu_egl_rendernode_open() in qemu source > >> code

Re: [libvirt] [PATCH] qemu: Allow /dev/dri/renderD128

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 10:26:26AM +0100, Michal Privoznik wrote: > This demand comes from qemu_egl_rendernode_open() in qemu source > code. It is needed for virgl to work with qemu:///system > connection. The session one works just fine. > > Signed-off-by: Michal Privoznik > --- > docs/drvqemu.

Re: [libvirt] [RFC PATCH 00/16] Introduce vGPU mdev framework to libvirt

2017-02-07 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 05:48:23PM +0100, Erik Skultety wrote: > On Mon, Feb 06, 2017 at 04:44:37PM +0000, Daniel P. Berrange wrote: > > On Mon, Feb 06, 2017 at 01:19:42PM +0100, Erik Skultety wrote: > > > Finally. It's here. This is the initial suggestion on how libvirt mig

Re: [libvirt] [PATCH] qemu: Check for maximum vcpus exceeding cpu topology

2017-02-07 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 07:56:29AM -0500, Kothapally Madhu Pavan wrote: > This patch will prevent guest to start when the maximum > vcpus are greater than cpu topology limit. Currently similar > checks do exist only during setvcpus. The patch adds the > missing check. The c9cb35c255222 reverted sim

Re: [libvirt] [resend v2 0/7] Support cache tune in libvirt

2017-02-07 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 02:43:13PM +0800, Eli Qiao wrote: > > 3) CDP / non-CDP convertion. > > > > In case the size determination has been performed with non-CDP, > > to emulate such allocation on a CDP host, > > it would be good to allow both code and data allocations to share > > the CBM space:

Re: [libvirt] [resend v2 4/7] Resctrl: Add private interface to set cachebanks

2017-02-07 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 02:43:04PM +0800, Eli Qiao wrote: > On Tuesday, 7 February 2017 at 12:17 AM, Daniel P. Berrange wrote: > > > On Mon, Feb 06, 2017 at 10:23:39AM +0800, Eli Qiao wrote: > > > virResCtrlSetCacheBanks: Set cache banks of a libvirt domain. It will >

Re: [libvirt] [resend v2 1/7] Resctrl: Add some utils functions

2017-02-07 Thread Daniel P. Berrange
On Tue, Feb 07, 2017 at 02:43:17PM +0800, Eli Qiao wrote: > On Tuesday, 7 February 2017 at 12:11 AM, Daniel P. Berrange wrote: > > > On Mon, Feb 06, 2017 at 10:23:36AM +0800, Eli Qiao wrote: > > > This patch adds some utils struct and functions to expose resc

Re: [libvirt] [RFC PATCH 00/16] Introduce vGPU mdev framework to libvirt

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 01:19:42PM +0100, Erik Skultety wrote: > Finally. It's here. This is the initial suggestion on how libvirt might > interract with the mdev framework, currently only focussing on the non-managed > devices, i.e. those pre-created by the user, since that will be revisited once

Re: [libvirt] [resend v2 4/7] Resctrl: Add private interface to set cachebanks

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 10:23:39AM +0800, Eli Qiao wrote: > virResCtrlSetCacheBanks: Set cache banks of a libvirt domain. It will > create new resource domain under `/sys/fs/resctrl` and fill the > schemata according the cache banks configration. > > virResCtrlUpdate: Update the schemata after lib

Re: [libvirt] [resend v2 1/7] Resctrl: Add some utils functions

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 10:23:36AM +0800, Eli Qiao wrote: > This patch adds some utils struct and functions to expose resctrl > information. > > virResCtrlAvailable: If resctrl interface exist on host > virResCtrlGet: get specify type resource contral information > virResCtrlInit: initialize resct

Re: [libvirt] [resend v2 2/7] Resctrl: expose cache information to capabilities

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 10:23:37AM +0800, Eli Qiao wrote: > This patch expose cache information to host's capabilites xml. > > For l3 cache allocation > > > > > > > > > > For l3 cache allocation supported cdp(seperate data/code): > > > > > > > >

Re: [libvirt] [Block Replication] Question about supporting COLO in libvirt

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 08:34:28PM +0800, Hailiang Zhang wrote: > Hi, > I'm trying to implement supporting COLO in libvirt, > But i found an annoying problem that libvirt does not > support the command line option argument syntax we used > for block replication in QEMU. > > That is libvirt does no

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-03 Thread Daniel P. Berrange
On Fri, Feb 03, 2017 at 05:34:07PM +0200, Michael S. Tsirkin wrote: > On Fri, Feb 03, 2017 at 03:11:10PM +0100, Maxime Coquelin wrote: > > Hi, > > > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > > Hi, > > > > > > Few months ago, Michael reported a problem about migrating VMs relying > > >

[libvirt] [PATCH] virtlockd: fix systemd unit file dependancies

2017-02-03 Thread Daniel P. Berrange
After deploying virtlogd by default we identified a number of mistakes in the systemd unit file. virtlockd's relationship to libvirtd is the same as virtlogd, so we must apply the same unit file fixes to virtlockd Signed-off-by: Daniel P. Berrange --- daemon/libvirtd.service.in | 1 +

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-03 Thread Daniel P. Berrange
On Fri, Feb 03, 2017 at 10:41:12AM +0100, Maxime Coquelin wrote: > > > On 02/03/2017 10:27 AM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: >

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-03 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 06:21:55PM +0000, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wro

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 05:29:08PM +0000, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wro

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 05:10:28PM +0000, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wro

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:09:24PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: > > On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > >

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 04:55:29PM +0100, Kashyap Chamarthy wrote: > On Thu, Feb 02, 2017 at 03:29:15PM +0000, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 04:21:39PM +0100, Michal Privoznik wrote: > > > On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > > > &

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 03:06:21PM +0000, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > > > > On 02/01/2017 12:41 PM, Daniel P.

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 04:21:39PM +0100, Michal Privoznik wrote: > On 02/02/2017 02:56 PM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > >> Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > >> h

Re: [libvirt] [PATCH 02/10] util: Introduce virFileReadLink

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 03:11:56PM +0100, Martin Kletzander wrote: > On Fri, Jan 20, 2017 at 10:42:42AM +0100, Michal Privoznik wrote: > > We will need to traverse the symlinks one step at the time. > > Therefore we need to see where a symlink is pointing to. > > > > Signed-off-by: Michal Privozni

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > It depends where / how in OVS it needs to be set. The only stuff libvirt > > does with OVS is to run 'add-port' and 'del-p

Re: [libvirt] [PATCH] qemu: Allow empty script path to

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 02:49:48PM +0100, Michal Privoznik wrote: > Before 9c17d665fdc5f (v1.3.2 - I know, right?) it was possible to > have the following interface configuration: > > > > > > This resulted in -netdev tap,script=,.. Fortunately, qemu helped > us to get away with this as

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 12:47:30PM +, Richard W.M. Jones wrote: > On Wed, Feb 01, 2017 at 04:54:01PM +0000, Daniel P. Berrange wrote: > > The virtlockd daemon has existed for years now, but we have never > > turned it on by default, requiring explicit user opt-in. This l

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 01:05:17PM +0100, Peter Krempa wrote: > On Thu, Feb 02, 2017 at 10:02:54 +, Daniel Berrange wrote: > > On Thu, Feb 02, 2017 at 10:58:50AM +0100, Peter Krempa wrote: > > > On Wed, Feb 01, 2017 at 18:11:28 +, Daniel Berrange wrote: > > > > On Wed, Feb 01, 2017 at 07:04

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-02 Thread Daniel P. Berrange
> > > > the same dependancies for virtlockd as we have for virtlogd > > > > now, since turning the latter on exposed some gaps. > > > > > > > > Signed-off-by: Daniel P. Berrange > > > > --- > > > > > > Unfortunately ... NACK, while I fix

Re: [libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-01 Thread Daniel P. Berrange
e various services files are updated to have > > the same dependancies for virtlockd as we have for virtlogd > > now, since turning the latter on exposed some gaps. > > > > Signed-off-by: Daniel P. Berrange > > --- > > Unfortunately ... NACK, while I fixed quite some bu

[libvirt] [PATCH] qemu: turn on virtlockd by default

2017-02-01 Thread Daniel P. Berrange
shared filesystems that support fcntl() (eg NFS). In turning it on the various services files are updated to have the same dependancies for virtlockd as we have for virtlogd now, since turning the latter on exposed some gaps. Signed-off-by: Daniel P. Berrange --- daemon/libvirtd.service.in

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 12:33:22PM +0100, Maxime Coquelin wrote: > > > On 02/01/2017 10:43 AM, Daniel P. Berrange wrote: > > On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: > > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > > > >

Re: [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 10:14:54AM +0100, Michal Privoznik wrote: > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > Solution 3: Libvirt queries OVS for vhost backend version string: *OK* > > == > > > > > > The idea is to hav

Re: [libvirt] char: Logging serial pty output when disconnected

2017-01-31 Thread Daniel P. Berrange
On Mon, Jan 30, 2017 at 08:58:25PM -0800, Ed Swierk wrote: > On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange > wrote: > > On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: > >> Currently qemu_chr_fe_write() calls qemu_chr_fe_write_log() only for > >>

Re: [libvirt] [PATCHv4 3/3] qemu: Add args generation for file memory backing

2017-01-30 Thread Daniel P. Berrange
On Sat, Jan 28, 2017 at 03:03:16PM +0100, Michal Privoznik wrote: > On 13.12.2016 13:12, Jaroslav Safka wrote: > > This patch add support for file memory backing on numa topology. > > > > The specified access mode in memoryBacking can be overriden > > by specifying token memAccess in numa cell. >

Re: [libvirt] [PATCHv4 0/3] Add support for file memorybacking

2017-01-30 Thread Daniel P. Berrange
On Sat, Jan 28, 2017 at 03:03:02PM +0100, Michal Privoznik wrote: > On 13.12.2016 13:12, Jaroslav Safka wrote: > > Hi, > > we would like to introduce 3 new elements source,access and allocation in > > memoryBacking element. > > For now it was made for numa topology. > > > > > > > > >

Re: [libvirt] char: Logging serial pty output when disconnected

2017-01-27 Thread Daniel P. Berrange
On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: > Interactive access to a guest serial console can be enabled by hooking > the serial device to a pty backend, e.g. -device > isa-serial,chardev=cs0 -chardev pty,id=cs0. With libvirt this can be > configured via port='0'/>. > > Output fro

[libvirt] [PATCH] Add libvirt-go-xml and libvirt-console-proxy to downloads

2017-01-26 Thread Daniel P. Berrange
Add recently created modules to the download page list. Signed-off-by: Daniel P. Berrange --- docs/downloads.html.in | 34 ++ 1 file changed, 34 insertions(+) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 25dc54d..99da7a6 100644 --- a/docs

Re: [libvirt] Refactoring of storage pool

2017-01-26 Thread Daniel P. Berrange
On Wed, Jan 25, 2017 at 08:02:30PM +0300, Olga Krishtal wrote: > Hi everyone! > Half a year ago we started discussion about filesystem pools: > https://www.redhat.com/archives/libvir-list/2016-April/msg01941.html > https://www.redhat.com/archives/libvir-list/2016-May/msg00208.html > https://www.red

Re: [libvirt] [PATCH python 0/7] Remove unused code from generator

2017-01-26 Thread Daniel P. Berrange
ping On Thu, Jan 19, 2017 at 03:31:20PM +, Daniel P. Berrange wrote: > All this functionality is inherited from libxml, but is not required > to generate libvirt python bindings. > > Daniel P. Berrange (7): > Removed unused 'reference_keepers' code from gen

Re: [libvirt] non-standard types in remote XDR definitions

2017-01-25 Thread Daniel P. Berrange
On Wed, Jan 25, 2017 at 11:12:33AM -0500, Matt Broadstone wrote: > On Wed, Jan 25, 2017 at 10:59 AM, Daniel P. Berrange > wrote: > > On Wed, Jan 25, 2017 at 10:55:37AM -0500, Matt Broadstone wrote: > >> Hello, > >> > >> I have been experimenting with the r

Re: [libvirt] non-standard types in remote XDR definitions

2017-01-25 Thread Daniel P. Berrange
On Wed, Jan 25, 2017 at 10:55:37AM -0500, Matt Broadstone wrote: > Hello, > > I have been experimenting with the remote protocol defined in the > `src/remote/remote_protocol.x` > (https://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=src/remote/remote_protocol.x;hb=HEAD), > and noticed that there

Re: [libvirt] OSX Homebrew support note ;)

2017-01-24 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 03:29:01PM +, Justin Clift wrote: > On 23 Jan 2017, at 11:38, Daniel P. Berrange wrote: > > On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > > > > > I'm looking at (what I hope is the correct) configuration file for t

Re: [libvirt] [PATCH go] Fix segfault in Connect.GetMemoryStats

2017-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 01:49:59AM +0300, Matvey Kruglov wrote: > --- > connect.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/connect.go b/connect.go > index 35eb7fd..6730171 100644 > --- a/connect.go > +++ b/connect.go > @@ -1688,7 +1688,7 @@ func (c *Connect) GetMe

Re: [libvirt] [PATCH] perf: introduce option --reset

2017-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 07:26:58PM +0530, Nitesh Konkar wrote: > Hi Daniel, > > > On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange > wrote: > > > On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > > > > > @@ -9570,16 +9570,17 @@ q

Re: [libvirt] OSX Homebrew support note ;)

2017-01-23 Thread Daniel P. Berrange
On Wed, Dec 21, 2016 at 09:55:53AM +, Justin Clift wrote: > Hi all, > > Compiling Libvirt directly from latest git master head is now supported on > OSX Homebrew. It's as simple as: > > $ brew install --HEAD libvirt > ... > $ virsh -v > 3.0.0 > > This should make development of Libv

Re: [libvirt] [PATCH] perf: introduce option --reset

2017-01-23 Thread Daniel P. Berrange
On Mon, Jan 23, 2017 at 04:03:21PM +0530, Nitesh Konkar wrote: > @@ -9570,16 +9570,17 @@ qemuDomainSetPerfEvents(virDomainPtr dom, > if (def) { > for (i = 0; i < nparams; i++) { > virTypedParameterPtr param = ¶ms[i]; > -enabled = param->value.b; > +

Re: [libvirt] Mirror on Github failed to sync from libvirt.org

2017-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2017 at 09:34:47AM +0800, Chen Hanxiao wrote: > > Dear list, > > >     Mirror on Github: >     https://github.com/libvirt/libvirt >     did not sync from libvirt.org for almost a month. The mirror script got totally confused again. I've thrown away the old mirror script and wri

Re: [libvirt] [PATCH 04/10] qemuSecurityRestoreAllLabel: Don't use transactions

2017-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2017 at 11:34:06AM +0100, Michal Privoznik wrote: > On 01/20/2017 11:18 AM, Daniel P. Berrange wrote: > > On Fri, Jan 20, 2017 at 10:42:44AM +0100, Michal Privoznik wrote: > >> Because of the nature of security driver transactions, it is > >> impossibl

Re: [libvirt] [PATCH 04/10] qemuSecurityRestoreAllLabel: Don't use transactions

2017-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2017 at 10:42:44AM +0100, Michal Privoznik wrote: > Because of the nature of security driver transactions, it is > impossible to use them properly. The thing is, transactions enter > the domain namespace and commit all the seclabel changes. > However, in RestoreAllLabel() this is im

Re: [libvirt] [Qemu-devel] [PATCH 0/9] i386: query-cpu-model-expansion test script

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 06:21:22PM +0100, David Hildenbrand wrote: > > >> Also think about "query-cpu-model-expansion model=host type=static", > >> which will primarily be used by libvirt on s390x. There is no way to > >> expand this into a static cpu model. Faking anything will just hide errors.

[libvirt] [PATCH python 6/7] Removed unused 'converter_type' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'converter_type' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 15 --- 1 file changed, 15 deletions(-) di

[libvirt] [PATCH python 2/7] Removed unused 'function_post' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'function_post' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 28 1 file changed, 28

[libvirt] [PATCH python 1/7] Removed unused 'reference_keepers' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'reference_keepers' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 24 1 file changed, 24

[libvirt] [PATCH python 7/7] Removed unused 'functions_list_exception_test' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'functions_list_exception_test' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 29 - 1 file

[libvirt] [PATCH python 4/7] Removed unused 'py_return_types' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'py_return_types' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 13 - 1 file changed, 13 deletions(-) di

[libvirt] [PATCH python 0/7] Remove unused code from generator

2017-01-19 Thread Daniel P. Berrange
All this functionality is inherited from libxml, but is not required to generate libvirt python bindings. Daniel P. Berrange (7): Removed unused 'reference_keepers' code from generator Removed unused 'function_post' code from generator Removed unused 'foreign

[libvirt] [PATCH python 3/7] Removed unused 'foreign_encoding_args' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'foreign_encoding_args' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 5 - 1 file changed, 5 deletions(-) di

[libvirt] [PATCH python 5/7] Removed unused 'classes_ancestor' code from generator

2017-01-19 Thread Daniel P. Berrange
The 'classes_ancestor' data structure and associated code in the generator is inherited from libxml. This has never been used in libvirt, so delete it to simplify the generator. Signed-off-by: Daniel P. Berrange --- generator.py | 56 ++---

[libvirt] [PATCH python] Protect against user accidentally calling constructors directly

2017-01-19 Thread Daniel P. Berrange
_obj)) Exception: Expected a wrapped C Object but got Signed-off-by: Daniel P. Berrange --- generator.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/generator.py b/generator.py index e9be8b1..6bcf80b 100755 --- a/generator.py +++ b/generator.py @@ -1532,6 +1532,8 @@ def buildWrappers(mod

Re: [libvirt] libvirt-python bug: custom event loop impl calls ff callback from *Remove(Handle|Timeout)Func

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 12:48:11PM +0100, Wojtek Porczyk wrote: > Hello libvirt-list, > > As of current libvirt-python.git, according to libvirt-override.c, if > implementing custom event loop in Python, ff callback is called from > libvirt_virEventRemoveHandleFunc, which is a C glue between > vir

Re: [libvirt] [PATCH for 3.0.x] Disable use of namespaces by default

2017-01-19 Thread Daniel P. Berrange
On Thu, Jan 19, 2017 at 11:55:20AM +0100, Guido Günther wrote: > On Wed, Jan 18, 2017 at 10:49:59AM +0000, Daniel P. Berrange wrote: > > When namespaces are enabled there is currently breakage when > > using disk hotplug and when using AppArmor > > > > Signed

[libvirt] [PATCH] storage: avoid use of undefined GLUSTER_CLI variable

2017-01-19 Thread Daniel P. Berrange
pass a bare "gluster" string to virFindFileInPath instead. Signed-off-by: Daniel P. Berrange --- Technically this is a build-break fix for FreeBSD, but I want to get a review to double-check before pushing this. configure.ac | 9 - src/storage/storage_util.c | 2 +-

Re: [libvirt] [PATCH] Fix segfault in GetIOThreadInfo

2017-01-19 Thread Daniel P. Berrange
On Wed, Jan 18, 2017 at 12:46:53PM -0500, Leonid Podolny wrote: > The pointers calculation included a typo which caused segfaults. > > Signed-off-by: Leonid Podolny > --- > domain.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already responded to your other posting, but thanks agai

Re: [libvirt] [PATCH go] Fix segfault in GetIOThreadInfo

2017-01-19 Thread Daniel P. Berrange
Thanks for your patch, I've applied it to git master Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o-http://search.cpan.org/~dan

[libvirt] [PATCH for 3.0.x] Disable use of namespaces by default

2017-01-18 Thread Daniel P. Berrange
When namespaces are enabled there is currently breakage when using disk hotplug and when using AppArmor Signed-off-by: Daniel P. Berrange --- I'm suggesting this for 3.0.x branch - we'll leave them enabled in master on the basis that we'll actually fix the real bugs th

Re: [libvirt] [PATCH 2/2] Resctrl: expose cache information to capabilities

2017-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2017 at 03:26:20PM +0800, Eli Qiao wrote: > This patch expose cache information to host's capabilites xml. > > > min='2816' scope='L3DATA'/> > min='2816' scope='L3DATA'/> > min='2816' scope='L3CODE'/> > min='2816' scope='L3CODE'/> > > > There are some nits di

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

2017-01-17 Thread Daniel P. Berrange
On Tue, Jan 17, 2017 at 04:41:57PM +0100, Michal Privoznik wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: > > On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik > > wrote: > >> [Dropping libvirt-announce] > >> > >> On 01/17/2017 02:51 PM, Boris Fiuczynski wrote: > >>> On 01/17/2017

[libvirt] [PATCH] qemu: catch failure of drive_add

2017-01-17 Thread Daniel P. Berrange
ng as an error condition. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_monitor_text.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index bc83218..76d7497 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

2017-01-17 Thread Daniel P. Berrange
On Tue, Jan 17, 2017 at 04:41:57PM +0100, Michal Privoznik wrote: > On 01/17/2017 04:28 PM, Marc Hartmayer wrote: > > On Tue, Jan 17, 2017 at 03:28 PM +0100, Michal Privoznik > > wrote: > >> [Dropping libvirt-announce] > >> > >> On 01/17/2017 02:51 PM, Boris Fiuczynski wrote: > >>> On 01/17/2017

Re: [libvirt] [PATCH for 3.0.0] Revert "perf: Add cache_l1d perf event support"

2017-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2017 at 12:07:39PM -0500, John Ferlan wrote: > > > On 01/16/2017 11:57 AM, Daniel P. Berrange wrote: > > This reverts commit ae16c95f1bb5591c27676c5de8d383e5612c3568. > > > > The data was calculated incorrectly and the event name needs > > to b

[libvirt] [PATCH for 3.0.0] Revert "perf: Add cache_l1d perf event support"

2017-01-16 Thread Daniel P. Berrange
This reverts commit ae16c95f1bb5591c27676c5de8d383e5612c3568. The data was calculated incorrectly and the event name needs to be changed. --- docs/formatdomain.html.in | 7 --- docs/schemas/domaincommon.rng | 1 - include/libvirt/libvirt-domain.h

Re: [libvirt] Availability of libvirt-3.0.0 release candidate 2

2017-01-16 Thread Daniel P. Berrange
On Sat, Jan 14, 2017 at 11:02:37PM +0100, Daniel Veillard wrote: > I missed the Friday deadline ot push it, so did it today. It's now tagged > in git, signed tarball and rpms are at the usual place: >ftp://libvirt.org/libvirt/ > > As a result I think GA should happen on Tuesday to give at l

Re: [libvirt] [PATCH 1/2] perf: Compute cache_l1d config value correctly

2017-01-16 Thread Daniel P. Berrange
On Sat, Jan 14, 2017 at 01:49:59PM +0530, Nitesh Konkar wrote: > This patch computes the .attrConfig value for > cache_l1d correctly and updates the documentation. > The cache_l1d perf event now is renamed as > cache_l1dra perf event for measuring read accesses > for level 1 data cache > > Signed-

Re: [libvirt] How to generate better API documentation?

2017-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2017 at 08:24:25AM +0100, Michal Privoznik wrote: > Dear list, > > now that we more or less agreed to use some new features (i.e. automatic > free() when a variable goes out of the scope [1]), and with our NEWS efforts, > do you think it is finally the right time to fix generatio

Re: [libvirt] [PATCH v2] Add support for Veritas HyperScale (VxHS) block device protocol

2017-01-16 Thread Daniel P. Berrange
On Sat, Jan 14, 2017 at 10:31:05AM -0500, John Ferlan wrote: > [...] > > >> diff --git > >> a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args > >> b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args > >> new file mode 100644 > >> index 000..f6e3e37 > >> --- /d

Re: [libvirt] [V4] RFC for support cache tune(CAT) in libvirt

2017-01-13 Thread Daniel P. Berrange
On Fri, Jan 13, 2017 at 09:38:44AM +0800, 乔立勇(Eli Qiao) wrote: > > virsh capabilities > > > > > > > <- level 3 cache is per socket, so group them by > socket id > > > >cpus="3,4,5,9,10,11"/> > > > > > > > >

Re: [libvirt] [PATCH go-xml] Added domain snapshot schema

2017-01-12 Thread Daniel P. Berrange
On Thu, Jan 12, 2017 at 10:44:08AM +0100, Alexey Slaykovsky wrote: > Signed-off-by: Alexey Slaykovsky > --- > domain.go | 11 ++- > domain_snapshot.go | 79 > domain_snapshot_test.go | 190 > > 3 files cha

<    6   7   8   9   10   11   12   13   14   15   >