Re: [libvirt] [PATCH go-xml] Add support for panic device

> domain_test.go | 28 +--- > 2 files changed, 63 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Thanks for your contribution, I'll push to git shortly. Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] PATCH go-xml : add virtualport support

On Wed, Nov 15, 2017 at 11:55:36AM +, Karol Czeryna wrote: > Hi guys! > > Working with terraform libvirt plugin I discovered lack of openvswitch > support - but in libvirt-go there is no support for virtualport entry.. this > patch adds virtualport support. Reviewed-by: Dan

Re: [libvirt] [PATCH go-xml] Support network backed serial interfaces

gt; domain.go | 26 +- > domain_test.go | 26 +++--- > 2 files changed, 40 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Will push to git shortly, thanks for your contribution. Regards, Daniel -- |: https://berrange.com -o-htt

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

On Wed, Nov 15, 2017 at 05:57:45PM +, Richard W.M. Jones wrote: > On Tue, Nov 14, 2017 at 05:25:03PM +0000, Daniel P. Berrange wrote: > > I would anticipate a standalone process "libvirt-qemu" that an > > application can spawn, providing a normal domain XML file

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

On Wed, Nov 15, 2017 at 12:28:30PM +0100, Bjoern Walk wrote: > Daniel P. Berrange <berra...@redhat.com> [2017-11-14, 05:27PM +]: > > The Problem(s) > > == > > > > When libvirt was created, C was the only viable choice for anything aiming &g

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

The Problem(s) == When libvirt was created, C was the only viable choice for anything aiming to be a core system library component. At that time 2005, aside from C there were common choices of Java, Python, Perl. Java was way too heavy for a low level system component, Python was

Re: [libvirt] Redesigning Libvirt: Exploding the libvirtd architecture

The problem(s) == The libvirtd architecture has evolved over time, initially as an expediant solution to the problem of managing virtual networks and QEMU processes, and over time came to control all the other resources too. It is only avoided in the case of the stateless hypervisor

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

The problem(s) == While a hypervisor agnostic API is useful for some users, it is completely irrelevant, and potentally even painful, for other users. We made some concessions to this when we introduced hypervisor specific XML namespaces and option for hypervisor specific add-on APIs.

[libvirt] Redesigning Libvirt: Adapting for the next 12 years

Hold tight, this is a long one... It is hard for me to believe it, but the libvirt project is now 12 years old (born on Nov 2, 2005), and I've been working on it since March 2006, making it easily the most significant project I've worked on. It started off life as an attempt to provide a stable

Re: [libvirt] [PATCH] virconf: properly set the end of content

/util/virconf.c | 13 ++ > tests/virconftest.c | 69 > + > 2 files changed, 71 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/

Re: [libvirt] [PATCH] qemu-ns: Detect /dev/* mount point duplicates even better

On Wed, Nov 08, 2017 at 04:09:57PM +0100, Michal Privoznik wrote: > In 4f1570720218302 I've tried to make duplicates detection for > nested /dev mount better. However, I've missed the obvious case > when there are two same mount points. For instance if: > > # mount --bind /dev/blah /dev/blah >

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Mon, Nov 06, 2017 at 06:43:12AM +0100, Prerna wrote: > Thanks for your reply Daniel. I am still on vacation all of this week so > have not been able to respond. > Few questions inline: > > On Thu, Oct 26, 2017 at 2:43 PM, Daniel P. Berrange <berra...@redhat.com> > wrot

Re: [libvirt] [PATCH go-xml] Add support for host paravirt bootloader, used by Xen and bhyve.

On Tue, Nov 07, 2017 at 02:17:41PM -0600, Brandon Bergren wrote: > --- > domain.go | 2 ++ > domain_test.go | 16 > 2 files changed, 18 insertions(+) THanks, pushed to git master Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH] virconf: properly set the end of content

On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: > There was a recent report of the xen-xl converter not handling > config files missing an ending newline > > https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html > > Commit 3cc2a9e0 fixed a similar problem when

Re: [libvirt] [PATCH v3 4/5] qemu: Use predictable file names for memory-backend-file

On Tue, Nov 07, 2017 at 04:51:03PM +0100, Michal Privoznik wrote: > In some cases management application needs to allocate memory for > qemu upfront and then just let qemu use that. Since we don't want > to expose path for memory-backend-file anywhere in the domain > XML, we can generate

Re: [libvirt] Should we switch to a different JSON library?

On Tue, Nov 07, 2017 at 02:05:25PM +0100, Martin Kletzander wrote: > Hi everyone, > > so we are using yajl for parsing JSON. However there are some reasons > why we might consider switching to another one: > > 1) It is basically dead upstream One could say that it is simply "feature complete"

Re: [libvirt] Interim fix for exposing VMware firmware=bios|efi in libvirt XML

On Tue, Nov 07, 2017 at 09:09:07AM +, Richard W.M. Jones wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1217444 > > VMware guests can use either BIOS or UEFI firmware. VMware itself > exposes this information in the VMX file and it's available to the ESX > driver in libvirt. virt-v2v

Re: [libvirt] [PATCH go-xml] Add support for host paravirt bootloader.

On Sat, Nov 04, 2017 at 03:25:25PM -0500, Brandon Bergren wrote: > --- > domain.go | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/domain.go b/domain.go > index 2b749b2..f4ef35c 100644 > --- a/domain.go > +++ b/domain.go > @@ -791,6 +791,8 @@ type Domain struct { > VCPU

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Mon, Nov 06, 2017 at 11:43:49AM -0200, Eduardo Habkost wrote: > On Mon, Nov 06, 2017 at 01:17:02PM +0000, Daniel P. Berrange wrote: > > On Mon, Nov 06, 2017 at 11:10:00AM -0200, Eduardo Habkost wrote: > > > On Thu, Sep 28, 2017 at 09:21:41AM +0100, Daniel P. Berrange wrote: &

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Mon, Nov 06, 2017 at 11:10:00AM -0200, Eduardo Habkost wrote: > On Thu, Sep 28, 2017 at 09:21:41AM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 21, 2017 at 01:14:04PM -0400, Laine Stump wrote: > > > On 09/19/2017 03:37 PM, Eduardo Habkost wrote: > > > > Cac

Re: [libvirt] [jenkins-ci PATCH 0/2] fix libosinfo rpm build

On Thu, Nov 02, 2017 at 04:49:38PM +0100, Pavel Hrdina wrote: > On Thu, Nov 02, 2017 at 04:32:12PM +0100, Andrea Bolognani wrote: > > Moreover, we should be able to convert libvirt-cim to use > > autotools-*-job by tweaking its autogen.sh script, which would leave > > osinfo-db as the only user of

Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: use job_env in all job templates

On Thu, Nov 02, 2017 at 04:54:38PM +0100, Pavel Hrdina wrote: > On Thu, Nov 02, 2017 at 03:42:56PM +0000, Daniel P. Berrange wrote: > > On Thu, Nov 02, 2017 at 01:45:51PM +0100, Pavel Hrdina wrote: > > > This fixes libosinfo RPM build, we need to set "OSINFO_SYSTEM_DIR"

Re: [libvirt] [jenkins-ci PATCH 2/2] jobs: use job_env in all job templates

On Thu, Nov 02, 2017 at 01:45:51PM +0100, Pavel Hrdina wrote: > This fixes libosinfo RPM build, we need to set "OSINFO_SYSTEM_DIR" for > RPM build as well since the spec file runs tests and they need valid > osinfo-db. Broken by <359b069f7e4700bee337588eab0a9d83cac94010>. I'm not suggesting you

Re: [libvirt] How to best handle the reoccurring of rom changes breaking cross version migrations?

On Thu, Nov 02, 2017 at 04:14:06PM +0100, Christian Ehrhardt wrote: > Ping - since there wasn't any reply so far - any best practices one could > share? > > Let me add a TL;DR: > - bump of ipxe rom versions change the size of virtio-net-pci.rom > - that breaks on migration "Length mismatch" > >

Re: [libvirt] networking problem

On Thu, Nov 02, 2017 at 09:24:22AM +, Stefan Hajnoczi wrote: > On Sun, Oct 29, 2017 at 04:07:09AM -0700, ms...@reynoldstocks.com wrote: > > I have performed following steps: > > > > $ virsh net-destroy default > > $ virsh net-undefine default > > > > Now I couldn't start guest with following

Re: [libvirt] [PATCH go-xml] Add support for CPUTune in Domain

On Wed, Oct 25, 2017 at 04:32:32PM +0100, Michal Rostecki wrote: > From: Michal Rostecki > > Signed-off-by: Victoria Efimova > Signed-off-by: Ivan Shvedunov > Signed-off-by: Miha Pleško >

Re: [libvirt] [PATCH go-xml] Add bootp option to NetworkDHCP

On Wed, Oct 25, 2017 at 11:33:09AM +0100, Michal Rostecki wrote: > From: Michal Rostecki > > Support specyfing concrete file and TFTP server > for PXE boot. > > Signed-off-by: Michal Rostecki > --- > network.go | 6 ++ >

Re: [libvirt] [PATCH go-xml] Add address support for memory device

On Mon, Oct 30, 2017 at 10:27:13AM +0100, Peter Krempa wrote: > On Mon, Oct 30, 2017 at 11:05:13 +0800, zhenwei.pi wrote: > > Add Base element for DomainAddress. > > Add address element for DomainMemorydev. > > Add test code for new DomainMemorydev. > > > > Signed-off-by: zhenwei.pi

Re: [libvirt] [jenkins-ci PATCH 4/7] jobs: projects: be explicit about python2 binary

On Wed, Nov 01, 2017 at 02:47:30PM +0100, Pavel Hrdina wrote: > On Wed, Nov 01, 2017 at 01:37:12PM +0000, Daniel P. Berrange wrote: > > On Wed, Nov 01, 2017 at 02:26:56PM +0100, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > > > ---

Re: [libvirt] [jenkins-ci PATCH 4/7] jobs: projects: be explicit about python2 binary

On Wed, Nov 01, 2017 at 02:26:56PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > jobs/python-distutils.yaml | 8 > projects/virt-manager.yaml | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/jobs/python-distutils.yaml

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Tue, Oct 31, 2017 at 07:04:35AM +0100, Michal Privoznik wrote: > On 10/30/2017 11:12 PM, Jim Fehlig wrote: > > On 10/30/2017 03:31 PM, Jim Fehlig wrote: > >> On 10/03/2017 07:53 AM, Daniel P. Berrange wrote: > >>> On Tue, Oct 03, 2017 at 02:11:44PM +0200, Martin K

[libvirt] [PATCH dbus v2] Run system instance as an unprivileged user account

some benefit. Security can be further improved if the admin uses the libvirt polkit file to restrict what libvirt-dbus is permitted to do. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure.ac | 5 data/Makef

Re: [libvirt] Using XML returned from domain hook script

On Sun, Oct 29, 2017 at 08:39:08PM -0600, Jim Fehlig wrote: > Hi All, > > It may be a foolish en devour, but I'm trying to make a qemu hook script > that provides the semantics of an old, custom xen block script. The script > parses info, does some setup based on that, and then rewrites part of

Re: [libvirt] [PATCH dbus] Run system instance as an unprivileged user account

On Fri, Oct 27, 2017 at 04:35:39PM +0200, Pino Toscano wrote: > On Friday, 27 October 2017 16:18:42 CEST Daniel P. Berrange wrote: > > There is no reason for the libvirt-dbus daemon to require root privileges. > > All > > it actually needs is ability to connect to libvirtd,

[libvirt] [PATCH dbus] Run system instance as an unprivileged user account

some benefit. Security can be further improved if the admin uses the libvirt polkit file to restrict what libvirt-dbus is permitted to do. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure.ac | 5 + data/Makefile.am

[libvirt] [PATCH dbus 4/5] Enable full RELRO mode

By passing the flags -z relro -z now to the linker, we can force it to resolve all library symbols at startup, instead of on-demand. This allows it to then make the global offset table (GOT) read-only, which makes some security attacks harder. Signed-off-by: Daniel P. Berrange <be

[libvirt] [PATCH dbus 0/5] Harden the build process

This hardens the build process by turning on all possible compiler flags and enabling features like relro and PIE. Daniel P. Berrange (5): util: don't inline virtDBusUtilVirDomainListFreep src: annotate parameters that are unused in functions build: turn on all practical compiler warning

[libvirt] [PATCH dbus 3/5] build: turn on all practical compiler warning flags

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .gitignore | 1 + Makefile.am | 2 + configure.ac| 3 + m4/manywarnings.m4 | 276 m4/virt-arg.m4

[libvirt] [PATCH dbus 5/5] Build all binaries with PIE

layout randomization to prevent attackers from knowing where existing executable code is during a security attack using exploits that rely on knowing the offset of the executable code in the binary, such as return-to-libc attacks. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- config

[libvirt] [PATCH dbus 2/5] src: annotate parameters that are unused in functions

Introduce a VIR_ATTR_UNUSED macro to annotate parameters that are unused in functions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/domain.c | 78 +-- src/events.c | 12 - src/main.c| 12

[libvirt] [PATCH dbus 1/5] util: don't inline virtDBusUtilVirDomainListFreep

(virtDBusUtilVirDomainListFreep) virDomainPtr *domains = NULL; ^~~ Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util.c | 14 ++ src/util.h | 15 ++- 2 files changed, 16 insertions(+), 13 deletions(-)

Re: [libvirt] [jenkins-ci PATCH v2 0/4] Expand test matrix, plus cleanups

| 16 +++ > projects/osinfo-db-tools.yaml | 4 > projects/osinfo-db.yaml | 3 +++ > projects/virt-manager.yaml| 4 > projects/virt-viewer.yaml | 4 > 18 files changed, 104 insertions(+), 50 deletions(-) > delete mode 100644 README

Re: [libvirt] 答复: [PATCH v2] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On Fri, Oct 27, 2017 at 10:25:23AM +0200, Michal Privoznik wrote: > On 10/27/2017 03:47 AM, Caoxinhua wrote: > > Yes,In qemuxml2argvtest case, mymain call qemuTestDriverInit to init qemu > > driver, qemuTestDriverInit call mkdtemp() to init stateDir, so stateDir is > > randomly. But '-monitor'

Re: [libvirt] [jenkins-ci PATCH 4/5] jobs: Define $OSINFO_SYSTEM_DIR in default make_env

On Fri, Oct 27, 2017 at 09:48:14AM +0200, Andrea Bolognani wrote: > Althought the environment variable is only used when building > libosinfo, there is no harm in having it set in the environment > at all times; moreover, hoisting it to the default make_env > allows us to remove duplicated code

Re: [libvirt] [jenkins-ci PATCH 3/5] jobs: Define $VIR_TEST_{DEBUG, EXPENSIVE} in default check_env

On Fri, Oct 27, 2017 at 09:48:13AM +0200, Andrea Bolognani wrote: > Althought the environment variables are only used when running > libvirt's test suite, there is no harm in having it set in the > environment at all times. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

On Thu, Oct 26, 2017 at 11:13:23AM -0600, Jim Fehlig wrote: > On 10/26/2017 12:48 AM, Daniel P. Berrange wrote: > > On Wed, Oct 25, 2017 at 03:30:46PM -0600, Jim Fehlig wrote: > > > On a cloud host it is possible to create 100's of unique instances > > > per day, eac

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Tue, Oct 24, 2017 at 10:34:53AM -0700, Prerna Saxena wrote: > > As noted in > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > libvirt-QEMU driver handles all async events from the main loop. > Each event handling needs the per-VM lock to make forward progress. In > the

Re: [libvirt] [PATCH] qemu: treat iso images as raw

On Thu, Oct 26, 2017 at 03:04:08PM +0300, Nikolay Shirokovskiy wrote: > if image format probing is on and image format of iso file > is not specified qemu fail to start a domain or change disk > media giving errors like [1]. The problem is format is being > detected as 'iso' and qemu expect format

Re: [libvirt] [PATCH] qemu: logrotate: drop minsize directive

100644 > --- a/daemon/libvirtd.qemu.logrotate.in > +++ b/daemon/libvirtd.qemu.logrotate.in > @@ -5,5 +5,4 @@ > compress > delaycompress > copytruncate > -minsize 100k > } Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Danie

Re: [libvirt] [PATCH v1 3/5] qemu.conf: Introduce memory_predictable_file_names

On Mon, Oct 23, 2017 at 07:10:04PM +0200, Michal Privoznik wrote: > On 10/23/2017 06:47 PM, Daniel P. Berrange wrote: > > On Mon, Oct 23, 2017 at 05:43:16PM +0200, Michal Privoznik wrote: > >> In some cases management application needs to allocate memory for > >> qem

Re: [libvirt] [PATCH v1 3/5] qemu.conf: Introduce memory_predictable_file_names

On Mon, Oct 23, 2017 at 05:43:16PM +0200, Michal Privoznik wrote: > In some cases management application needs to allocate memory for > qemu upfront and then just let qemu use that. Since we don't want > to expose path for memory-backend-file anywhere in the domain > XML, we can have a

Re: [libvirt] Build fails on Debian unstable: libssh's ssh_get_publickey() is deprecated

On Mon, Oct 23, 2017 at 05:28:36PM +0200, Andrea Bolognani wrote: > I ran into a failure trying to compile libvirt on Debian unstable > today: > > rpc/virnetlibsshsession.c: In function 'virLibsshServerKeyAsString': > rpc/virnetlibsshsession.c:220:5: error: 'ssh_get_publickey' is deprecated

Re: [libvirt] [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

On Mon, Oct 23, 2017 at 12:04:17PM +0200, Igor Mammedov wrote: > On Fri, 20 Oct 2017 10:07:27 +0100 > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote: > > > On Thu, Oct 19, 2017 at 04

Re: [libvirt] [perl PATCH 0/2] Add missing bindings

s/Virt/Domain.pm | 60 > ++ > 3 files changed, 86 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt

Re: [libvirt] [go PATCH 0/2] Add missing bindings

ain_compat.go | 12 > domain_compat.h | 47 +++ > 3 files changed, 98 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [libvirt] [RFC] Question regarding the validity of QEMU capabilities

On Fri, Oct 20, 2017 at 01:10:14PM +0200, Pavel Hrdina wrote: > On Fri, Oct 20, 2017 at 12:59:51PM +0200, Marc Hartmayer wrote: > > Hi all, > > > > the actual capabilities of QEMU are depending on the host. This > > includes dependencies like which kernel modules are loaded or which > > kernel

Re: [libvirt] [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote: > On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote: > > > - Original Message ----- > > > > From: "Danie

Re: [libvirt] [PATCH v1 09/14] virDomainDeviceInfoCheckABIStability: Check for alias too

On Thu, Oct 19, 2017 at 02:16:41PM +0200, Martin Kletzander wrote: > On Thu, Oct 19, 2017 at 10:11:04AM +0200, Michal Privoznik wrote: > > Since we'll be passing user's input onto qemu command line, we > > have to make sure aliases don't change during migration and all > > the other places where

Re: [libvirt] [libvirt-jenkins-ci PATCH v2 0/6] Unattended guest installation and more

On Thu, Oct 19, 2017 at 11:10:21AM +0200, Martin Kletzander wrote: > On Wed, Oct 18, 2017 at 07:11:45PM +0200, Andrea Bolognani wrote: > > Changes from [v1]: > > > > * guest changes > > - set root password to a user-provided value > > - only allow key-based SSH login for root > > - configure

Re: [libvirt] [PATCH 2/6] domain: Allow 'model' attribute for ide controller.

On Wed, Oct 18, 2017 at 12:23:24PM -0400, Dawid Zamirski wrote: > On Tue, 2017-10-17 at 15:46 -0400, John Ferlan wrote: > > > > On 10/09/2017 04:49 PM, Dawid Zamirski wrote: > > > From: Dawid Zamirski > > > > > > The optional values are 'piix3', 'piix4' or 'ich6'. Those

Re: [libvirt] [libvirt-jenkins-ci PATCH 3/5] ansible: Add unattended installation support

On Tue, Oct 17, 2017 at 06:24:47PM +0200, Andrea Bolognani wrote: > On Tue, 2017-10-17 at 17:57 +0200, Pavel Hrdina wrote: > > I wouldn't include Ubuntu related things. Yes, we use travis where they > > have Ubuntu nodes, but this is jenkins-ci repository where we don't use > > Ubuntu at all. >

Re: [libvirt] [libvirt-jenkins-ci PATCH 3/5] ansible: Add unattended installation support

On Tue, Oct 17, 2017 at 06:14:35PM +0200, Pavel Hrdina wrote: > On Tue, Oct 17, 2017 at 05:04:57PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote: > > > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote: > &g

Re: [libvirt] [libvirt-jenkins-ci PATCH 1/5] ansible: Remove bootstrap phase

On Tue, Oct 17, 2017 at 06:05:23PM +0200, Pavel Hrdina wrote: > On Mon, Oct 16, 2017 at 06:02:04PM +0200, Andrea Bolognani wrote: > > Having to bootstrap the guest as a separate phase is annoying and > > can be avoided by assuming the root password is well-known. > > I'm not sure about this. Yes

Re: [libvirt] [libvirt-jenkins-ci PATCH 3/5] ansible: Add unattended installation support

On Tue, Oct 17, 2017 at 05:57:30PM +0200, Pavel Hrdina wrote: > On Mon, Oct 16, 2017 at 06:02:06PM +0200, Andrea Bolognani wrote: > > The 'manage' tool can now be used to install most known guests > > without requiring user interaction. > > > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH] docs: remove duplicate https links

On Tue, Oct 17, 2017 at 09:32:43AM +0200, Ján Tomko wrote: > Commit e371b3b changed all the links to libvirt.org to use https. > Remove the leftover 'http' links from downloads page, since they > point to https anyway. > --- > Pushed as trivial. /me wonders why on earth I added both https & http

[libvirt] LSN-2017-0002 - TLS certificate verification disabled for clients

Libvirt Security Notice: LSN-2017-0002 == Summary: TLS certificate verification disabled for clients Reported on: 20171005 Published on: 20171016 Fixed on: 20171016 Reported by: Daniel P. Berrange <berra...@redhat.

[libvirt] [PATCH] qemu: ensure TLS clients always verify the server certificate

<ebl...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a off-list reviewed security fix. src/qemu/qemu_command.c | 2 +- tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args | 2 +- .../qem

Re: [libvirt] [PATCH go-xml] let disk source omitempty for ejecting cdrom/floppy

On Mon, Oct 16, 2017 at 05:36:54PM +0800, zhenwei.pi wrote: > Signed-off-by: zhenwei.pi > --- > domain.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/domain.go b/domain.go > index bacab11..f9d567d 100644 > --- a/domain.go > +++

[libvirt] [PATCH] Remove obsolete TODO file

We stopped autogenerating a TODO file from RFE bugs a long time ago. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- TODO | 22 -- 1 file changed, 22 deletions(-) delete mode 100644 TODO diff --git a/TODO b/TODO deleted file mode 100644 index 6843

[libvirt] [PATCH] Use https:// links for most sites

This adds a rule to require https links for the libvirt, qemu and kvm websites. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- cfg.mk| 20 + configure.ac | 2 +- daemon/libvirtd.conf | 2 +-

Re: [libvirt] [PATCH] Add CII best practices badge

On Fri, Oct 13, 2017 at 04:48:06PM +0200, Martin Kletzander wrote: > On Fri, Oct 13, 2017 at 02:32:03PM +0100, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > README.md | 1 + > > 1 file changed, 1 insertion(+)

[libvirt] [PATCH] Add CII best practices badge

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 5fed0fd874..1271843cb1 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ []

Re: [libvirt] [PATCH v5 1/4] numa: describe siblings distances within cells

lues are > possible depending on the physical topology of the system. > > When distances are not fully described, any missing sibling distance > values will default to 10 for local nodes and 20 for remote nodes. Nitpick, IIUC, if distance is given for A -> B, then we default B ->

Re: [libvirt] [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

On Fri, Oct 13, 2017 at 09:21:45AM +0200, Martin Kletzander wrote: > On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote: > > directory /var/lib alway is Persistence directory, but in redhat system, > > /var/run is memory directory. > > our running domain xml is saved at

Re: [libvirt] [PATCH] virt-host-validate: require fuse for LXC if compiled in

> +#if WITH_FUSE > +if (virHostValidateDeviceExists("LXC", "/sys/fs/fuse/connections", > +VIR_HOST_VALIDATE_FAIL, > +_("Load the 'fuse' module to enable > /proc/ overrides")) <

Re: [libvirt] [PATCH go-xml] Add support for memory device element

- > domain.go | 29 + > domain_test.go | 45 + > 2 files changed, 74 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> and pushed to git master. Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH v2] qemu: Don't crash when parsing command line lacking -M

mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nomachine-ppc64.args > create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nomachine-ppc64.xml > create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-nomachine-x86_64.args > create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-n

Re: [libvirt] [PATCH] qemu: Avoid crashes in qemuDomainMachineIs*()

On Tue, Oct 10, 2017 at 05:05:33PM +0200, Andrea Bolognani wrote: > On Tue, 2017-10-10 at 15:49 +0100, Daniel P. Berrange wrote: > > I think rather than trying to fix up the assumption about > > machine being non-NULL, we should restructure the ARGV > > parsing into we

Re: [libvirt] [PATCH] qemu: Avoid crashes in qemuDomainMachineIs*()

On Tue, Oct 10, 2017 at 04:21:02PM +0200, Andrea Bolognani wrote: > Make sure pointers are non-NULL before dereferencing them, and > add test suite coverage for the crashers doing so fixes. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1379218 Hmm, I don't think that is a good fix

Re: [libvirt] [RFC PATCH 2/4] util: Fix deadlock across fork()

On Mon, Oct 09, 2017 at 09:14:56PM +0200, Marc Hartmayer wrote: > This commit fixes the deadlock introduced by commit > 0980764dee687e8da86dc410c351759867163389. The call getgrouplist() of > the glibc library isn't safe to be called in between fork and > exec (see commit

[libvirt] [PATCH] maint: update to latest gnulib

This pulls in the fix for getopt tests on Fedora >= 28 / glibc > 2.26.0 Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 8d116e3f65..5e9abf8716 16 --- a/.gnulib +++ b/.

Re: [libvirt] [RFC PATCH 0/4] Deadlock fix and some minor fixes

On Mon, Oct 09, 2017 at 09:14:54PM +0200, Marc Hartmayer wrote: > The first patch is a preparatory patch for the deadlock fix (patch > 2). The cleanup path for 'virExecCommon' may now be superflous. > Patches 3-4 are only minor fixes. > > Important: there may still be a deadlock for LXC (see the

Re: [libvirt] [libvit-jenkins-ci PATCH v2 00/16] Ansible all the things!

On Mon, Oct 09, 2017 at 01:58:45PM +0200, Andrea Bolognani wrote: > On Mon, 2017-10-09 at 11:39 +0100, Daniel P. Berrange wrote: > > On Fri, Oct 06, 2017 at 02:48:36PM +0200, Andrea Bolognani wrote: > > > Changes from [v1]: > > > > > > * drop support for

Re: [libvirt] [PATCH] qemu: Changes in parsing qemu commandline memory section

On Mon, Oct 09, 2017 at 04:32:38PM +0530, Kothapally Madhu Pavan wrote: > Existing qemuParseCommandLineMem() will parse "-m 4G" format string. > This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" > format along with existing format. > > Signed-off-by: Kothapally Madhu

Re: [libvirt] [libvirt-jenkins-ci PATCH v2 16/16] ansible: Install and configure Jenkins agent

On Fri, Oct 06, 2017 at 02:48:52PM +0200, Andrea Bolognani wrote: > The agent is downloaded and configured to start at boot. The > secrets needed to prove the workers' identity to the Jenkins server > are stored inside Ansible vaults. > > Signed-off-by: Andrea Bolognani >

Re: [libvirt] [libvit-jenkins-ci PATCH v2 00/16] Ansible all the things!

On Fri, Oct 06, 2017 at 02:48:36PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * drop support for building projects; > * reduce redundancy by using mappings; > * add FreeBSD 10 support. > > [v1] https://www.redhat.com/archives/libvir-list/2017-October/msg00035.html > > Andrea

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Fri, Oct 06, 2017 at 07:59:13PM +0200, Bruno Haible wrote: > Daniel P. Berrange wrote: > > From my own F28 rawhide install with glibc-2.26.90-16.fc28.x86_64 > > > > > > > > 1) The output of > > > $ nm test-getopt-posix | grep getopt >

Re: [libvirt] [libvit-jenkins-ci PATCH v2 00/16] Ansible all the things!

On Fri, Oct 06, 2017 at 02:48:36PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * drop support for building projects; > * reduce redundancy by using mappings; > * add FreeBSD 10 support. > > [v1] https://www.redhat.com/archives/libvir-list/2017-October/msg00035.html BTW, what's

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Thu, Oct 05, 2017 at 01:31:02PM +0200, Michal Privoznik wrote: > On 10/05/2017 01:01 PM, Pavel Hrdina wrote: > > On Thu, Oct 05, 2017 at 10:40:01AM +0100, Daniel P. Berrange wrote: > >> On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote: > >>> On T

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

> > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote: > > > > > On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote: > > > > > > On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote: > > > > > > > On Tue, Oct 0

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Thu, Oct 05, 2017 at 11:28:35AM +0200, Michal Privoznik wrote: > On 10/05/2017 11:13 AM, Daniel P. Berrange wrote: > > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote: > >> On 10/05/2017 10:10 AM, Daniel P. Berrange wrote: > >>> On Wed, Oct 04, 20

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Thu, Oct 05, 2017 at 11:27:29AM +0200, Martin Kletzander wrote: > On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote: > > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote: > > > On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote: > > > &

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Thu, Oct 05, 2017 at 10:44:29AM +0200, Michal Privoznik wrote: > On 10/05/2017 10:10 AM, Daniel P. Berrange wrote: > > On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote: > >> On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote: > >>>

Re: [libvirt] [PATCH v2 3/3] conf: Allow users to define UUID for devices

On Wed, Oct 04, 2017 at 08:31:36AM +0200, Martin Kletzander wrote: > On Tue, Oct 03, 2017 at 03:10:48PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 03, 2017 at 04:03:20PM +0200, Martin Kletzander wrote: > > > On Tue, Oct 03, 2017 at 02:53:46PM +0100, Daniel P. Berrange wro

Re: [libvirt] [PATCH] tests: Do not ignore mode parameter in mocked open()

On Tue, Oct 03, 2017 at 02:07:18PM +0200, Jiri Denemark wrote: > From: Luyao Huang > > This is normally not an issue since the tests which use mocked open() do > not create files. But once coverage build is enabled, gcov_open will use > O_CREATE and real_open will read random

Re: [libvirt] New QEMU daemon for persistent reservations

On Tue, Oct 03, 2017 at 06:53:56PM +0200, Paolo Bonzini wrote: > On 03/10/2017 18:39, Daniel P. Berrange wrote: > > On Tue, Oct 03, 2017 at 06:35:03PM +0200, Paolo Bonzini wrote: > >> And later on we might have other ways to implement persistent > >> reservations in QE

Re: [libvirt] New QEMU daemon for persistent reservations

On Tue, Oct 03, 2017 at 06:35:03PM +0200, Paolo Bonzini wrote: > On 03/10/2017 18:17, Daniel P. Berrange wrote: > > On Tue, Oct 03, 2017 at 06:07:53PM +0200, Paolo Bonzini wrote: > >> Yes, but OTOH if libvirtd starts the daemon, nobody cares about the > >&

Re: [libvirt] New QEMU daemon for persistent reservations

On Tue, Oct 03, 2017 at 06:07:53PM +0200, Paolo Bonzini wrote: > On 03/10/2017 17:59, Michal Privoznik wrote: > > Ah, this breaks my design. I guess > > > > > > > > > > > > > > > > is pure madness, isn't it? > > Yes, but OTOH if libvirtd starts the daemon, nobody cares

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Tue, Oct 03, 2017 at 05:08:53PM +0200, Michal Privoznik wrote: > On 10/03/2017 04:19 PM, Daniel P. Berrange wrote: > > On Fri, Sep 29, 2017 at 09:06:01AM +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1434451 > >> > >> It co

Re: [libvirt] [PATCH alt] conf: Allow user define their own alias

On Fri, Sep 29, 2017 at 09:06:01AM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1434451 > > It comes handy for management application to be able to have a > per-device label so that it can uniquely identify devices it > cares about. The advantage of this approach

<    1   2   3   4   5   6   7   8   9   10   >