Re: [libvirt] [PATCH] maint: update to latest gnulib

On Wed, Jun 14, 2017 at 03:27:25PM +0200, Martin Kletzander wrote: > On Wed, Jun 14, 2017 at 11:20:44AM +0100, Daniel P. Berrange wrote: > > This fixes an incompatibility with glibc 2.25.90 > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > ---

[libvirt] [PATCH] maint: update to latest gnulib

This fixes an incompatibility with glibc 2.25.90 Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a broken build fix to get CI back online .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index da830b5..ce4ee4c

Re: [libvirt] [PATCH go-xml] 1,rename DomainInterfaceBoot to DomainDeviceBoot; 2,support disk boot order

On Tue, Jun 06, 2017 at 01:51:30PM +0800, zhenwei.pi wrote: > --- > domain.go | 5 +++-- > domain_test.go | 6 +- > 2 files changed, 8 insertions(+), 3 deletions(-) ACK and pushed with some changes to the commit message text. Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] libvirt binding for Rust

On Tue, Jun 06, 2017 at 10:31:33PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: > > Hello, > > > > I started a work on a libvirt binding for Rust [0]. Not all of the API > > is implemeted but I think

Re: [libvirt] Remotable Libvirt

On Wed, Jun 07, 2017 at 10:47:25AM +0200, Stef Walter wrote: > On 07.06.2017 07:49, Martin Pitt wrote: > > Hello Richard, > > > > Richard W.M. Jones [2017-05-31 18:00 +0100]: > >> I agree with others that as things stand you will need a REST or DBus > >> or similar API added to libvirt. > >> > >>

Re: [libvirt] More CI options

On Wed, Jun 07, 2017 at 10:55:21AM +0200, Martin Kletzander wrote: > On Tue, Jun 06, 2017 at 10:30:16PM +0100, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 10:09:00PM +0200, Martin Kletzander wrote: > > > Since the addition of Travis CI builds, there is some more prog

Re: [libvirt] libvirt binding for Rust

On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: > Hello, > > I started a work on a libvirt binding for Rust [0]. Not all of the API > is implemeted but I think it's now in a usable state. > > https://docs.rs/crate/virt > https://github.com/sahid/libvirt-rs > > The

Re: [libvirt] More CI options

On Tue, Jun 06, 2017 at 10:09:00PM +0200, Martin Kletzander wrote: > Since the addition of Travis CI builds, there is some more progress > towards more testing. I was just wondering if anyone was thinking about > (or is already working on) some settings for other CI environments as > well. For

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 01:25:08PM -0400, Stef Walter wrote: > On 06.06.2017 12:13, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 06:07:21PM +0200, Stef Walter wrote: > >> So to summarize what I'm hearing here: > >> > >> * There is no libvirt remotable

Re: [libvirt] [PATCH go-xml] add emulator supported

On Sat, Jun 03, 2017 at 09:30:00AM +0800, zhenwei.pi wrote: > --- > domain.go | 1 + > domain_test.go | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/domain.go b/domain.go > index dcb8f65..723e761 100644 > --- a/domain.go > +++ b/domain.go > @@ -307,6 +307,7 @@ type

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 06:07:21PM +0200, Stef Walter wrote: > On 06.06.2017 17:17, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: > >> On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > >>> On 05/26/2017 02:

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: > On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > > On 05/26/2017 02:11 AM, Martin Kletzander wrote: > > > On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: > > [...] > > > > If we standardize even the smallest part

Re: [libvirt] libvirt builds failing on fedora-rawhide

On Mon, Jun 05, 2017 at 04:22:41PM -0400, Yash Mankad wrote: > Hi, > > The libvirt-master-build on ci.c.o seems to be failing on > the fedora-rawhide slave since Friday. > > This seems to be the commit/build that is causing it to fail. Nope, it is a gnulib/glibc incompatibility

Re: [libvirt] [PATCH 1/2] util: share code between virExec and virCommandExec

On Thu, Jun 01, 2017 at 02:26:16PM +0200, Cédric Bosdonnat wrote: > virCommand is a version of virExec that doesn't fork, however it is > just calling execve and doesn't honors setting uid/gid and pwd. > > This commit moves those pieces from virExec to virCommandExec and > makes virExec use

Re: [libvirt] [PATCH 2/2] lxc: allow user to specify command working directory

On Thu, Jun 01, 2017 at 02:26:17PM +0200, Cédric Bosdonnat wrote: > Some containers may want the application to run in a special directory. > Add element in the domain configuration to handle this case > and use it in the lxc driver. > --- > docs/formatdomain.html.in| 5 + >

Re: [libvirt] [PATCH] lxc: allow defining environment variables

On Tue, May 30, 2017 at 09:32:43PM +0200, Cédric Bosdonnat wrote: > When running an application container, setting environment variables > could be important. > > The newly introduced tag in domain configuration will allow > setting environment variables to the init program. > --- >

Re: [libvirt] [ISSUE go-xml] go-xml does NOT support DomainDisk marshal

On Sat, Jun 03, 2017 at 11:27:19AM +0800, ZhenweiPi wrote: > Hi, > > > In the case of disk hot-plug, we need a xml like this : > > /// > // // > // // > // // > // // > /// > > > For now, go-xml does not support DomainDisk marshal. > > Any good idea ? All we needed todo was add XMLName

[libvirt] FYI build currently broken w/ glibc >= 2.25.90

FYI, there is currently a bug in gnulib that is breaking build for anything with glibc >= 2.25.90 (aka current Fedora 27 rawhide) http://lists.gnu.org/archive/html/bug-gnulib/2017-06/msg3.html Hopefully gnulib will accept my proposed fix soon... Regards, Daniel -- |: https://berrange.com

Re: [libvirt] [PATCH] Reset the whole stack in testutils

On Mon, Jun 05, 2017 at 10:01:10AM +0200, Martin Kletzander wrote: > The memset() was resetting only 30 bytes in the array (size of the > array), but it is array of pointers. Since it is a static array, > let's just reset it by its size. > > Found by gcc-7.1: > > testutils.c: In function

Re: [libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

On Wed, May 31, 2017 at 11:35:14AM -0400, Vladik Romanovsky wrote: > --- > node_device.go | 168 > > node_device_test.go | 128 +++ > 2 files changed, 296 insertions(+) > create mode 100644

Re: [libvirt] [PATCH go-xml] Add support for domain input address

On Thu, Jun 01, 2017 at 05:49:59PM +0800, zhenwei.pi wrote: > --- > domain.go | 5 +++-- > domain_test.go | 11 ++- > 2 files changed, 13 insertions(+), 3 deletions(-) Thanks, I've pushed this Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH v2] daemon: Don't initialize SASL context if not necessary

g->listen_tcp && config->auth_tcp == > REMOTE_AUTH_SASL)) { > saslCtxt = virNetSASLContextNewServer( > (const char *const*)config->sasl_allowed_username_list); > if (!saslCtxt) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, D

Re: [libvirt] [PATCH] daemon: Don't initialize SASL context if not necessary

On Fri, Jun 02, 2017 at 02:10:25PM +0200, Peter Krempa wrote: > SASL context would be initialized even if the corresponding TCP or TLS > sockets are not enabled. > > fe772f24a68 attempted to fix the symptom by commenting out the settings, > but that did not fix the root cause. 3c647ee4bbb later

Re: [libvirt] [PATCH v2 5/6] virsh: Report errors from stream callbacks

On Thu, Jun 01, 2017 at 03:43:06PM +0200, Michal Privoznik wrote: > On 06/01/2017 03:39 PM, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:02:13PM +0200, Michal Privoznik wrote: > >> There are couple of callbacks we pass to virStreamSendAll(), > >> virSt

Re: [libvirt] [PATCH v2 5/6] virsh: Report errors from stream callbacks

On Thu, Jun 01, 2017 at 02:02:13PM +0200, Michal Privoznik wrote: > There are couple of callbacks we pass to virStreamSendAll(), > virStreamRecvAll() or its sparse variants. However, none of these > callbacks reports error if one occurs and neither do the > virStream* functions leaving user with

Re: [libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

On Thu, Jun 01, 2017 at 02:23:30PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:10:45PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:02:14PM +0200, Michal Privoznik wrote: > > > We have couple of wrappers over our low level stream APIs: >

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

On Thu, Jun 01, 2017 at 03:20:50PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:29:45PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: > > > On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wro

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

On Thu, Jun 01, 2017 at 02:24:19PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: > > > Users need to remove their callbacks before call

Re: [libvirt] [PATCH 3/3] virStream: Remove callbacks on Abort/Finish

On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote: > Users need to remove their callbacks before calling virStreamAbort() > or virStreamFinish() even though that's not documented anywhere. > Since it makes no sense to keep those callbacks, we can remove them > when the stream is

Re: [libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

On Thu, Jun 01, 2017 at 02:02:14PM +0200, Michal Privoznik wrote: > We have couple of wrappers over our low level stream APIs: > virSreamRecvAll(), virStreamSendAll() and their sparse stream > variants. All of them take some callbacks and call them at > appropriate times. If a callback fails it

Re: [libvirt] [RFC] Version numbers outside of releases

On Thu, Jun 01, 2017 at 02:05:04PM +0200, Andrea Bolognani wrote: > On Thu, 2017-06-01 at 12:21 +0100, Daniel P. Berrange wrote: > > This is not that attractive from POV the language bindings. > >  > > eg in the Go code, I need to make usage of the new APIs > >

Re: [libvirt] [RFC] Version numbers outside of releases

On Thu, Jun 01, 2017 at 01:13:05PM +0200, Andrea Bolognani wrote: > Our current practice when it comes to bumping the version > number for libvirt is to do so immediately after a release, > eg. right after 3.4.0 is released later today someone will > push a commit that changes configure.ac to use

[libvirt] [PATCH] Fix closing XML element in news file

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a trivial build fix docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 6ff01ca..e95fe72 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -108,7

Re: [libvirt] [PATCH go-xml] Add support for device sound

On Thu, Jun 01, 2017 at 10:58:06AM +0800, zhenwei.pi wrote: > --- > domain.go | 11 +++ > domain_test.go | 20 > 2 files changed, 31 insertions(+) Thanks for your contribution, pushed to git Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH V2] CI: also run tests using updated distro(s)

On Wed, May 31, 2017 at 12:21:05PM -0300, claudioandre...@gmail.com wrote: > From: Claudio André > > It is possible to test libvirt using other distros in Travis via Docker; > including (but not limited to) Fedora and Ubuntu. > --- > See it in action at >

Re: [libvirt] Remotable Libvirt

On Wed, May 31, 2017 at 03:59:10PM +0100, Richard W.M. Jones wrote: > On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > > The majority of cockpit is implemented in > > javascript. > > How about using the gobject libvirt bindings? > > https://libvirt.org/git/?p=libvirt-glib.git;a=summary

Re: [libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

On Tue, May 30, 2017 at 10:36:22AM -0400, Vladik Romanovsky wrote: > Thanks for the review. > > On Tue, May 30, 2017 at 8:46 AM, Daniel P. Berrange <berra...@redhat.com> > wrote: > >> +type NodeDevice struct { > >> + Name string `xml:

Re: [libvirt] [PATCH go-xml] 1, add support for disk cache and io, and add test case. 2, add support for controller model, and add test case. 3, extend DomainAddress struct for PCI address and target

On Wed, May 31, 2017 at 09:26:01AM +0100, Daniel P. Berrange wrote: > On Wed, May 31, 2017 at 01:32:47PM +0800, ZhenweiPi wrote: > > --- > > > > domain.go | 13 +++-- > > domain_test.go | 56 > >

Re: [libvirt] [PATCH] udev: Fix build on older platforms

On Wed, May 31, 2017 at 12:22:01PM +0200, Erik Skultety wrote: > Caused by commit @d1eea6c1 due to the missing symbol on older platforms. > > Signed-off-by: Erik Skultety > --- > Despite falling under build-breaker category, I'd like to get a proper review, > since I'm not

Re: [libvirt] [PATCH go-xml] 1, add support for disk cache and io, and add test case. 2, add support for controller model, and add test case. 3, extend DomainAddress struct for PCI address and target

On Wed, May 31, 2017 at 01:32:47PM +0800, ZhenweiPi wrote: > --- > > domain.go | 13 +++-- > domain_test.go | 56 +--- > 2 files changed, 64 insertions(+), 5 deletions(-) > > diff --git a/domain.go b/domain.go > index

Re: [libvirt] [PATCH] maint: add sanitizers to the build process

On Tue, May 30, 2017 at 12:28:57PM -0300, claudioandre...@gmail.com wrote: > From: Claudio André > > Sanitizers are based on compile-time instrumentation. They are available in > gcc and clang for a range of supported operation systems and platforms. More > info at:

Re: [libvirt] [PATCH 4/9] util: Add magic_marker for all virObjects

On Tue, May 30, 2017 at 10:43:35AM -0400, John Ferlan wrote: > > > On 05/30/2017 09:00 AM, Daniel P. Berrange wrote: > > On Tue, May 30, 2017 at 07:38:16AM -0400, John Ferlan wrote: > >> The virObject logic "assumes" that whatever is passed to its API's >

Re: [libvirt] [PATCH 5/9] util: Introduce virObjectLockableRecursiveNew

On Tue, May 30, 2017 at 03:03:14PM +0200, Pavel Hrdina wrote: > On Tue, May 30, 2017 at 07:38:17AM -0400, John Ferlan wrote: > > Introduce a recursive option for the lockable object which calls > > virMutexInitRecursive instead of virMutexInit. > > We should avoid using recursive lock because

Re: [libvirt] [PATCH 09/18] Add virtio-related options to interfaces

On Tue, May 30, 2017 at 02:50:32PM +0200, Ján Tomko wrote: > > > > > Feels like we could just use 'iommu=on' as the name. Also, I'm unclear whether we actually need the 'ats' attribute. >From the description it sounds like if we have device_iotlb=on for the IOMMU device, then we

Re: [libvirt] [PATCH 4/9] util: Add magic_marker for all virObjects

On Tue, May 30, 2017 at 07:38:16AM -0400, John Ferlan wrote: > The virObject logic "assumes" that whatever is passed to its API's > would be some sort of virObjectPtr; however, if it is not then some > really bad things can happen. > > So far there's been only virObject{Ref|Unref},

Re: [libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

On Mon, May 29, 2017 at 03:58:52AM -0400, Vladik Romanovsky wrote: > --- > node_device.go | 277 > > node_device_test.go | 111 + > 2 files changed, 388 insertions(+) > create mode 100644 node_device.go > create mode

Re: [libvirt] [libvirt-sandbox PATCH] Drop library/ from template name and image path

On Sat, May 27, 2017 at 06:29:32PM +0200, Guido Günther wrote: > If one pastes from the output of virt-sansbox-image > > $ virt-sandbox-image list > docker:/library/ubuntu?tag=17.04 > docker:/library/debian?tag=latest > > verbatim > > $ virt-sandbox-image run -c qemu:///session >

Re: [libvirt] [PATCH v2] nodedev: Increase the netlink socket buffer size to the one used by udev

On Fri, May 19, 2017 at 03:16:26PM +0200, Erik Skultety wrote: > From: "ning.bo" > > When a number of SRIOV VFs (up to 128 on Intel XL710) is created: > for i in `seq 0 1`; do > echo 63 > /sys/class/net//device/sriov_numvfs > done > > libvirtd will then report

Re: [libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port

On Fri, May 26, 2017 at 07:11:53AM -0400, John Ferlan wrote: > > > On 05/26/2017 03:15 AM, Bjoern Walk wrote: > > Thanks a lot for your review John. > > > > If you don't mind, you can make the adjustments you mentioned and push, > > as I can only prepare a v2 on Monday and I wanted to get this

Re: [libvirt] [PATCH go-xml] add support for disk cache and io add support for controller model extend DomainAddress struct for PCI address and target

On Fri, May 26, 2017 at 06:50:58PM +0800, zhenwei.pi wrote: > --- > domain.go | 13 +++-- > domain_test.go | 31 --- > 2 files changed, 39 insertions(+), 5 deletions(-) > > diff --git a/domain.go b/domain.go > index 848835a..1382cd0 100644 > ---

Re: [libvirt] Double deference error in libvirt_virConnectDomainEventRegisterAny

On Fri, May 26, 2017 at 04:39:17PM +0800, fangying wrote: > Hi, > We'd like to report a double dereference error of 'pyobj_cbData' in > libvirt_virConnectDomainEventRegisterAny. > The bug can be triggered in the situation where 'domainEventRegisterAny' > (the python interface of

Re: [libvirt] [PATCH] rpc: Allow up to 256K records to be returned from virConnectGetAllDomainStats.

On Fri, May 26, 2017 at 01:29:20PM +0100, Richard W.M. Jones wrote: > In commit 89a706681cb3a4aa003d920db3163b809cfbc9ca, the returned > array of stats is limited to REMOTE_DOMAIN_LIST_MAX entries (4096). > > As well as being far too low -- this breaks if a single guest is added > with 320 disks

Re: [libvirt] Remotable Libvirt

On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > As far as I know libvirt doesn't currently have a remoteable API. It does > have a daemon that communicates with clients via a XDR RPC. > (https://libvirt.org/internals/rpc.html) However from what I'm hearing the > RPC is considered an

Re: [libvirt] [PATCH 1/1] CI: add code coverage analysis

On Thu, May 25, 2017 at 01:14:36AM -0300, claudioandre...@gmail.com wrote: > From: Claudio André > > It builds the code coverage report and uploads the coverage data to a web > service in order to allow to track libvirt's code coverage over time. > --- > .travis.yml

Re: [libvirt] [PATCH v2 3/3] virQEMUDriverDomainABIStability: Check for memoryBacking

On Wed, May 24, 2017 at 04:45:57PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1450349 > > Problem is, qemu fails to load guest memory image if these > attribute change on migration/restore from an image. [snip] > diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

On Wed, May 24, 2017 at 09:45:09AM -0400, John Ferlan wrote: > > > On 05/23/2017 04:13 AM, Bjoern Walk wrote: > > John Ferlan [2017-05-19, 09:08AM -0400]: > >> Move the whole file from src/node_device into src/conf and rename the > >> API's to have the "virNodeDevice"

[libvirt] [PATCH python] Fix error check for virDomainGetTime method

The virDomainGetTime returns either a dict or None, but the python glue layer for checking for '-1'. Thus it failed to raise an exception on error. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-override-virDomain.py | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [libvirt] [PATCH 2/2] qemu: don't relabel chardev source file if virtlogd is used

On Tue, May 23, 2017 at 05:53:46PM +0200, Pavel Hrdina wrote: > On Tue, May 23, 2017 at 04:24:13PM +0100, Daniel P. Berrange wrote: > > On Tue, May 23, 2017 at 04:25:01PM +0200, Martin Kletzander wrote: > > > On Mon, May 15, 2017 at 04:28:35PM +0200, Pavel Hrdina wrote: >

Re: [libvirt] [libvirt-perl][PATCH 0/7] Implement sparse streams

On Tue, May 23, 2017 at 05:05:34PM +0200, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Privoznik (7): > Fix send_all() callback helper > Introduce flags to Stream::recv() > Introduce Stream::recvHole() and Stream::sendHole() > Introduce Stream::sparse_recv_all() > Introduce

Re: [libvirt] [libvirt-perl][PATCH 5/7] Introduce Stream::sparse_send_all()

On Tue, May 23, 2017 at 05:05:39PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 124 > + > lib/Sys/Virt/Stream.pm | 19 >

Re: [libvirt] [libvirt-perl][PATCH 3/7] Introduce Stream::recvHole() and Stream::sendHole()

On Tue, May 23, 2017 at 05:05:37PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes| 1 + > Virt.xs| 28 > lib/Sys/Virt/Stream.pm | 17 + > 3 files changed, 46

Re: [libvirt] [PATCH 2/2] qemu: don't relabel chardev source file if virtlogd is used

On Tue, May 23, 2017 at 04:25:01PM +0200, Martin Kletzander wrote: > On Mon, May 15, 2017 at 04:28:35PM +0200, Pavel Hrdina wrote: > > If libvirt uses virtlogd instead of passing the file path directly > > to QEMU we shouldn't relabel the chardev source file, otherwise > > virtlogd will get a

Re: [libvirt] [RFC PATCH 2/2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Tue, May 23, 2017 at 10:51:47AM +0200, Martin Kletzander wrote: > On Tue, May 23, 2017 at 09:32:03AM +0100, Daniel P. Berrange wrote: > > On Mon, May 22, 2017 at 06:00:13PM +0200, Peter Krempa wrote: > > > Hint that the users should limit the number of VMs queried in the bu

Re: [libvirt] [RFC PATCH 2/2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Mon, May 22, 2017 at 06:00:13PM +0200, Peter Krempa wrote: > Hint that the users should limit the number of VMs queried in the bulk > stats API. > --- > src/libvirt-domain.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c > index

Re: [libvirt] [RFC PATCH 2/2] lib: Add note that bulk stats API queries may overrun RPC buffers

On Tue, May 23, 2017 at 10:12:06AM +0200, Martin Kletzander wrote: > On Mon, May 22, 2017 at 06:00:13PM +0200, Peter Krempa wrote: > > Hint that the users should limit the number of VMs queried in the bulk > > stats API. > > --- > > src/libvirt-domain.c | 7 +++ > > 1 file changed, 7

Re: [libvirt] [RFC] Fixing a regression caused by recent CPU driver changes

On Thu, May 18, 2017 at 10:22:59AM +0200, Jiri Denemark wrote: > The big question is how to fix the regression in a backward compatible > way and still keep the ability to properly check guest CPU ABI with new > enough libvirt and QEMU. Clearly, we need to keep both the original and > the updated

Re: [libvirt] [libvirt-perl][PATCH] Add LIST_CAP_MDEV & LIST_CAP_MDEV_TYPES constants

lib/Sys/Virt/NodeDevice.pm | 8 > 3 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

[libvirt] [PATCH v3] Provide a useful README file

The current README file contents has almost no useful info, and that which does exist is very outdated. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Makefile.am | 1 + README | 14 +-- README.md | 80 ++

Re: [libvirt] [PATCH v2] Provide a useful README file

On Mon, May 22, 2017 at 02:00:01PM +0200, Andrea Bolognani wrote: > On Tue, 2017-05-16 at 13:29 +0100, Daniel P. Berrange wrote: > > The current README file contents has almost no useful info, and that > > which does exist is very outdated. > >  > > Signed-off-by

Re: [libvirt] [PATCH] Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"

On Mon, May 22, 2017 at 03:30:48AM -0400, Laine Stump wrote: > This reverts commit 2841e675. > > It turns out that adding the host_mtu field to the PCI capabilities in > the guest bumps the length of PCI capabilities beyond the 32 byte > boundary, so the virtio-net device gets 64 bytes of ioport

Re: [libvirt] [PATCH v1 0/3] Loadparm support

On Fri, May 19, 2017 at 12:56:44PM -0400, Farhan Ali wrote: > This patch series introduces the support for new s390x 'loadparm' > feature. The 'loadparm' can be used to select the boot entry to > boot from, for a boot device. Why do we need / want any of this when we already have bootindex=NN

Re: [libvirt] [PATCH 1/3] virfile: Provide stub for virFileInData

On Fri, May 19, 2017 at 01:31:32PM +0200, Michal Privoznik wrote: > On 05/19/2017 12:28 PM, Peter Krempa wrote: > > On Thu, May 18, 2017 at 15:46:44 +0200, Michal Privoznik wrote: > >> Some older systems (such as RHEL6) lack SEEK_HOLE and SEEK_DATA > >> which virFileInData relies on. Provide a

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

On Tue, May 16, 2017 at 06:16:19PM -0400, Laine Stump wrote: > On 05/05/2017 10:22 AM, Julio Faracco wrote: > > This commit adds the support for 'downscript' feature: > > - For QEMU command line with the option: > > '-net downscript=/etc/qemu-ifdown,...'. > > > > - For Domains with a network

Re: [libvirt] [PATCH v2] qemu: Report shutdown event details

On Tue, May 16, 2017 at 12:10:23PM -0500, Eric Blake wrote: > On 05/16/2017 08:49 AM, Martin Kletzander wrote: > > QEMU will likely report the details of it shutting down, particularly > > whether the shutdown was initiated by the guest or host. We should > > forward that information along, at

[libvirt] [PATCH v2] Provide a useful README file

The current README file contents has almost no useful info, and that which does exist is very outdated. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- In v2: - Use markdown syntax - Use README.md file - Symlink README to README.md - Include travis build status README

Re: [libvirt] [PATCH] Provide a useful README file

On Tue, May 16, 2017 at 01:54:30PM +0200, Martin Kletzander wrote: > On Tue, May 16, 2017 at 11:50:27AM +0100, Daniel P. Berrange wrote: > > The current README file contents has almost no useful info, and that > > which does exist is very outdated. > > > > Signed-off-by

[libvirt] [PATCH] Provide a useful README file

The current README file contents has almost no useful info, and that which does exist is very outdated. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- README | 81 +- 1 file changed, 71 insertions(+), 10 del

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On Tue, May 16, 2017 at 10:28:27AM +0300, Vasiliy Tolstov wrote: > 2017-05-16 9:32 GMT+03:00 Peter Krempa : > > 3.3.2? We dropped micro versions some time ago. > > > > This is copy/paste from link element, sorry. > > >> + > >> + > >> MTU configuration > >> > > > >

Re: [libvirt] [libvirt-python PATCH v2] spec: Install egg-info with rpm package

On Mon, May 15, 2017 at 05:58:47PM +0200, Martin Kletzander wrote: > This was being done due to now deprecated policy and that file should > be installed so that pip can recognize that the packages is already > installed in the system. > > Signed-off-by: Martin Kletzander >

[libvirt] [PATCH] remove hack for debian etch limits.h

the above via some gnulib .h file maint.mk:843: recipe for target 'sc_prohibit_always-defined_macros' failed Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build break fix src/internal.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/internal.h b/src/inte

Re: [libvirt] [libvirt-python PATCH] spec: Install egg-info with rpm package

On Mon, May 15, 2017 at 05:26:39PM +0200, Martin Kletzander wrote: > This was being done due to now deprecated policy and that file should > be installed so that pip can recognize that the packages is already > installed in the system. > > Signed-off-by: Martin Kletzander >

Re: [libvirt] libvirt-python RPM installation not recognized by pip

On Mon, May 15, 2017 at 02:52:07PM +0200, Martin Kletzander wrote: > On Mon, May 15, 2017 at 07:35:30AM -0400, Cleber Rosa wrote: > > Hello, > > > > When using the standard "requirements.txt" files for installation > > package dependencies, I noticed that "libvirt-python" would attempt to > > be

Re: [libvirt] [PATCH v2] storage: use 0711 as the default perms for dirs

in v2: > - adapt commit wording to mention dropping group readable as well > > Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com> > --- > docs/formatstorage.html.in | 2 +- > src/storage/storage_util.h | 2 +- > 2 files changed, 2 insertions(+), 2 d

[libvirt] [PATCH] maint: update to latest gnulib

This pulls in the fixes for poll() on Win32 which finally makes the remote driver work again. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 94386a1..da830b5 16 --- a/.

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

On Mon, May 15, 2017 at 10:54:03AM +0200, Michal Privoznik wrote: > On 05/15/2017 10:25 AM, Daniel P. Berrange wrote: > > On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > >>> On Fri, May 05, 20

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

On Thu, May 11, 2017 at 06:36:22PM -0400, John Ferlan wrote: > > > On 05/11/2017 04:31 AM, Christian Ehrhardt wrote: > > From: Serge Hallyn > > > > There should be no need to make dir based pools world readable. > > So use 0711, not 0755, as the default perms for

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > > On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: > >> On 05/04/2017 11:29 PM, John Ferlan wrote: > >>> > >>> >

Re: [libvirt] [PATCH 1/2] spec: Support maintenance releases on mingw

here as well. > > This also switches the source URL from FTP to HTTP for > consistency with the main spec file. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> > --- > mingw-libvirt.spec.in | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Thu, May 11, 2017 at 04:24:41PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 02:35:12PM +0100, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote: > > > On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: &g

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 03:40:37PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 02:16:11PM +0100, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > > > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel

Re: [libvirt] [PATCH 1/1] Enable Travis CI build status icon

On Thu, May 11, 2017 at 03:30:00PM +0200, Martin Kletzander wrote: > On Tue, Apr 18, 2017 at 02:39:28PM -0300, Claudio André wrote: > > Using GitHub libvirt site, it is possible to show Travis's fancy icon of > > the current build status. It highlights the QA process. > > I like seeing the icon

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > > The Win32 platform can not do link time overrides in the same way > > that we can on POSIX / ELF based platforms, so we cannot build > >

[libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this file are already written to skip on Win32. Signed-off-by: Daniel P

[libvirt] [PATCH] remote: increase max storage pools, nwfilters & snapshots to 16384

Most other top level objects have already had their limits increased to 16384. Increase the storage pool, nwfilter & snapshot object limits to match. For snapshots at least, we have seen hosts which exceeded the current limit Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH] rpc: improve error message for bounds check

ich RPC call and field was exceeded. So this patch makes us report: $ virsh snapshot-list ostack1 error: too many remote undefineds: 1329 > 1024, in parameter 'names' for 'virDomainSnapshotListNames' Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/gendispatch.pl |

Re: [libvirt] CLI management tool

On Thu, May 11, 2017 at 09:17:39AM +0200, Michal Privoznik wrote: > Dear list, > > you might have seen a discussion about virsh, and adding some new > features to it [1]. While the feature was rejected, it got me thinking. > What options do we offer for sysadmins that: > > a) want to stay in

Re: [libvirt] [PATCH] docs: install html fonts and related

On Thu, May 11, 2017 at 12:01:27PM +0300, Nikolay Shirokovskiy wrote: > --- > docs/Makefile.am | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) ACK Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

[libvirt] [PATCH] Add missing deps on virfilewrapper.h

The test programs depend on virfilewrapper.h as well as the virfilewrapper.c. Adding the dep ensures that virfilewrapper.h gets included in the dist tarball. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix, since RPM build / distcheck is broken w

Re: [libvirt] [PATCH] nodedev_udev: Fix missing events when kernel report lots of udev events within a short time

On Wed, May 10, 2017 at 01:38:00PM +0200, Erik Skultety wrote: > On Tue, May 09, 2017 at 10:09:07AM +0800, ZhiPeng Lu wrote: > > From: "ning.bo" > > > > When create Virtual Function for Inter XL710 use below commands: > > for i in `seq 0 1`; do > > echo 63 > > >

Re: [libvirt] [PATCH] Don't inline virStringTrimOptionalNewline

On Wed, May 10, 2017 at 11:12:00AM +0200, Martin Kletzander wrote: > On Wed, May 10, 2017 at 09:26:18AM +0100, Daniel P. Berrange wrote: > > GCC complains that inlining virStringTrimOptionalNewline is not > > likely on some platforms: > > > > cc1: warnings being treat

<    2   3   4   5   6   7   8   9   10   11   >