[libvirt] [PATCH] Don't inline virStringTrimOptionalNewline

the string, not by the function call overhead. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a broken build fix src/libvirt_private.syms | 1 + src/util/virstring.c | 14 ++ src/util/virstring.h | 8 +--- 3 files changed, 16 insertions

Re: [libvirt] [RFC PATCH REBASE 00/10] introduce push backups

On Fri, May 05, 2017 at 09:22:21AM +0300, Nikolay Shirokovskiy wrote: > Push backup is a backup when hypervisor itself copy backup data to destination > in contrast to pull backup when hypervisor exports backup data thru some > interface and mgmt itself make a copy. > > This patch series

Re: [libvirt] [RFC PATCH REBASE 10/10] virsh: backup: add backup-create command

On Fri, May 05, 2017 at 09:22:31AM +0300, Nikolay Shirokovskiy wrote: > --- > po/POTFILES.in | 1 + > tools/Makefile.am| 1 + > tools/virsh-backup.c | 100 > +++ > tools/virsh-backup.h | 29 +++ > tools/virsh-util.c |

Re: [libvirt] [RFC PATCH REBASE 06/10] conf: backup: add backup xml definition

On Fri, May 05, 2017 at 09:22:27AM +0300, Nikolay Shirokovskiy wrote: > Backup xml description is like this: > > > backup name > > > > > > - element is optional. > > - disk @type attribute is optional, default to 'file'. Valid > values are 'file', 'block', 'dir', 'network',

Re: [libvirt] [PATCH] conf: Check CPU cache for ABI stability

| > +(src->cache && dst->cache && > + (src->cache->level != dst->cache->level || > + src->cache->mode != dst->cache->mode))) { > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > +

Re: [libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.

On Tue, May 09, 2017 at 07:51:00AM -0700, Gordon Messmer wrote: > On 05/09/2017 07:38 AM, Daniel P. Berrange wrote: > > I think you can use the --iothread flag to "virsh attach-disk" to set > > this parameter. virsh doesn't set it if not specified, since it tries &

Re: [libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.

On Tue, May 09, 2017 at 07:31:30AM -0700, Gordon Messmer wrote: > (Apparently I managed to screw up sending that, twice. Long weekend.) No problem. Your first posting got blocked into the moderator queue since you weren't a subscriber. One of the list admins then approved it, not realizing you

[libvirt] [PATCH v2] Detect VMDK version 3 files

The metadata libvirt cares about is identical for version 3 as for previous versions, so we merely need list the new version number. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/virstoragefile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] How about fuzz testing on oss-fuzz?

On Tue, May 09, 2017 at 11:12:24AM +0200, Michal Privoznik wrote: > On 05/09/2017 11:01 AM, Daniel P. Berrange wrote: > > On Fri, Mar 31, 2017 at 10:23:33AM +0200, Peter Krempa wrote: > >> On Fri, Mar 31, 2017 at 03:57:41 -0400, Dan wrote: > >>> Hi all, > >>

Re: [libvirt] How about fuzz testing on oss-fuzz?

On Fri, Mar 31, 2017 at 10:23:33AM +0200, Peter Krempa wrote: > On Fri, Mar 31, 2017 at 03:57:41 -0400, Dan wrote: > > Hi all, > > > > I have seen libxml2 has already been added as a project in oss-fuzz [1]. > > Any idea about libvirt? While we could do our own fuzzing of some form, do > > we

Re: [libvirt] 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

anshan District, Shenzhen, P.R.China, 518057 > T: +86 755 F:+86 755 > M: +86 xxx > E: lu.zhip...@zte.com.cn > www.zte.com.cn > > > > > > > 原始邮件 > > > > 发件人： ＜berra...@redhat.com＞ > 收件人： ＜la...@laine.org＞ >

Re: [libvirt] [PATCH 2/3] Add support for CPU cache specification

On Tue, Apr 25, 2017 at 08:48:44PM +0200, Jiri Denemark wrote: > This patch introduces > > > > > > sub element of /domain/cpu. Currently only a single element is > allowed. > > Signed-off-by: Jiri Denemark > --- > docs/formatdomain.html.in

[libvirt] [PATCH] configure: enforce presence of python for build

were included in EXTRA_DIST, but the keycodemapdb generated files are not, so we require python all the time now. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure.ac | 5 - mingw-libvirt.spec.in | 1 + 2 files changed, 5 insertions(+), 1 deletion(-)

Re: [libvirt] 答复: Re: 答复: Re: [PATCH v2] qemu: clean up network interfaces beforeqemuProcessKill is called in qemuProcessStop

On Mon, May 08, 2017 at 06:18:25PM +0800, lu.zhip...@zte.com.cn wrote: > I may not have described it clearly. > > i need to ensure the order of adding port to bridge and deleting from > bridge. > > i rename tap device to avoid the problem in my first patch.i think it can > solve the

[libvirt] [PATCH] Don't use ceph-devel on Fedora

Fixing this stops libvirt pulling Java into the build root in Fedora. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b249224..4c7b658 100644 --- a/libvirt.s

Re: [libvirt] 答复: Re: [PATCH v2] qemu: clean up network interfaces beforeqemuProcessKill is called in qemuProcessStop

On Mon, May 08, 2017 at 05:18:17PM +0800, lu.zhip...@zte.com.cn wrote: > ＞This fix won't work correctly either. You cannot assume that libvirt has > ＞control over when the QEMU process exits. It may exit itself *before* > ＞libvirt runs any of its cleanup code. > > I don't think there's a problem.

[libvirt] [PATCH] Detect VMDK version 3 files

The metadata libvirt cares about is identical for version 3 as for previous versions, so we merely need list the new version number. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/virstoragefile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sr

Re: [libvirt] [PATCH v2] qemu: clean up network interfaces before qemuProcessKill is called in qemuProcessStop

On Mon, May 08, 2017 at 03:03:30PM +0800, ZhiPeng Lu wrote: > In qemuProcessStop we explicitly remove the port from the openvswitch bridge > after > qemuProcessKill is called. But there is a certain interval of time between > deleting tap device and removing it from bridge. The problem occurs

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: > On 05/04/2017 11:29 PM, John Ferlan wrote: > > > > > > On 04/20/2017 06:01 AM, Michal Privoznik wrote: > >> This API can be used to tell the other side of the stream to skip > > > > s/can be/is (unless it can be used for

Re: [libvirt] [PATCH go-xml] remove superfluous state & omitempty entries

On Mon, Apr 24, 2017 at 12:09:15PM -0700, Ryan Goodfellow wrote: > This commit removes the superfluous state and omit entries from my last > commit. It factors the 'state' data member into a DomainFeatureState > struct and only uses that struct where necessary e.g. HyperV features > as well as a

Re: [libvirt] [PATCH go-xml] add support for domain features

mp; omitempty entries' that has been posted to the list. > > > > -- > > cheers > > ry > > > > On Mon, Apr 24, 2017 at 3:47 AM, Daniel P. Berrange <berra...@redhat.com> > > wrote: > > > >> On Sat, Apr 22, 2017 at 02:53:48PM -0700, Ryan Goodfel

Re: [libvirt] [PATCH] virPerfEventIsEnabled: Accept NULL @perf

On Thu, May 04, 2017 at 04:32:50PM +0200, Michal Privoznik wrote: > After bdcf6e481 there is a crasher in libvirt. The commit assumes > that priv->perf is always set. That is not true. For inactive > domains, the priv->perf is not allocated as it is set in > qemuProcessLaunch(). Now, usually we

Re: [libvirt] Raising limits for our RPC messages

On Thu, May 04, 2017 at 03:04:33PM +0300, Vasiliy Tolstov wrote: > 2017-05-04 15:01 GMT+03:00 Daniel P. Berrange <berra...@redhat.com>: > > That doesn't really help memory usage, as you still have todo the XDR > > encode step to create the data that you then feed to the co

Re: [libvirt] Raising limits for our RPC messages

On Thu, May 04, 2017 at 02:55:26PM +0300, Vasiliy Tolstov wrote: > 2017-05-04 14:49 GMT+03:00 Daniel P. Berrange <berra...@redhat.com>: > > > > So I think it is reasonable to simply increase the buffer size as > > we have done before. > > > > That said, we

Re: [libvirt] Raising limits for our RPC messages

On Thu, May 04, 2017 at 01:39:17PM +0200, Michal Privoznik wrote: > Dear list, > > maybe you've seen us raising limit for various parts of RPC messages > (for eaxmple: d15b29be, 66bfc7cc61ca0, e914dcfd, etc.). It usually > happens when we receive a report that current limits are not enough. >

Re: [libvirt] 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

On Thu, May 04, 2017 at 08:28:03AM +0800, lu.zhip...@zte.com.cn wrote: > I'm worried that the network packet loss rate will increase after > reversing the order. I don't see why that is relevant - we're killing the guest or unplugging the NIC, so there's no traffic being sent on this tap device.

Re: [libvirt] Libvirt CAT support plan

On Wed, May 03, 2017 at 08:30:31AM +0800, Eli Qiao wrote: > hi all, > > Thanks for helping reviewing for CAT support in the past days. > > I writing this email to ask for the plan in libvirt support. > > I think we’v discussed this early this year, and I’v proposed a patch set [1]. > But don’t

Re: [libvirt] Symptoms of main loop slowing down in libvirtd

On Tue, May 02, 2017 at 04:42:11PM +0530, Prerna wrote: > On Tue, May 2, 2017 at 4:27 PM, Peter Krempa wrote: > > > On Tue, May 02, 2017 at 16:16:39 +0530, Prerna wrote: > > > On Tue, May 2, 2017 at 4:07 PM, Peter Krempa wrote: > > > > > > > On Tue, May

[libvirt] [PATCH] Fix padding of encrypted data

Incorrect number of padding bytes (56) found on decrypted data Notice how the padding '56' corresponds to the ordinal value of the character '8'. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/vircrypto.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [libvirt] [PATCH 3/2] HACKING: Document developer tooling

On Tue, May 02, 2017 at 11:57:02AM +0200, Andrea Bolognani wrote: > On Tue, 2017-05-02 at 09:06 +0100, Daniel P. Berrange wrote: > > > Advertise some of the useful developer tooling libvirt > > > integrates with out of the box. > > > --- > > >  HACKING 

Re: [libvirt] [PATCH 3/2] HACKING: Document developer tooling

On Fri, Apr 28, 2017 at 06:33:49PM +0200, Andrea Bolognani wrote: > Advertise some of the useful developer tooling libvirt > integrates with out of the box. > --- > HACKING | 13 + > docs/hacking.html.in | 20 > 2 files changed, 33 insertions(+) ACK

Re: [libvirt] [PATCH] qemu: change the name of tap device for a tap and bridge network

On Fri, Apr 28, 2017 at 01:08:45PM -0400, Laine Stump wrote: > On 04/28/2017 05:33 AM, Daniel P. Berrange wrote: > > On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: > >> Creating tap device and adding the device to bridge are not atomic > >> operation.

Re: [libvirt] Making panic great again

On Fri, Apr 28, 2017 at 11:28:47AM -0700, Ed Swierk wrote: > On Fri, Apr 28, 2017 at 1:46 AM, Daniel P. Berrange <berra...@redhat.com> > wrote: > > With the watchdog we have a much wider set of actions that we can > > instruct QEMU to do: > > > > 'reset' —

Re: [libvirt] [PATCH 0/2] Add support for some useful vim plugins

On Fri, Apr 28, 2017 at 04:38:18PM +0200, Andrea Bolognani wrote: > On Fri, 2017-04-28 at 15:24 +0100, Daniel P. Berrange wrote: > > So presumably this requires users to have libclang installed > > on their system. Perhaps worth a note in the HACKING file > > about prerequisi

Re: [libvirt] [PATCH 0/2] Add support for some useful vim plugins

On Fri, Apr 28, 2017 at 04:20:48PM +0200, Andrea Bolognani wrote: > libclang can be integrated into vim in pretty useful > ways, notably to provide semantic syntax highlighting > and code completion. So presumably this requires users to have libclang installed on their system. Perhaps worth a

Re: [libvirt] [PATCH] qemu: change the name of tap device for a tap and bridge network

On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: > Creating tap device and adding the device to bridge are not atomic operation. > Similarly deleting tap device and removing it from bridge are not atomic > operation. > The Problem occurs when two vms start and shutdown. When one vm

Re: [libvirt] Making panic great again

On Fri, Apr 28, 2017 at 08:43:30AM +0200, Martin Kletzander wrote: > On Thu, Apr 27, 2017 at 05:34:21PM -0700, Ed Swierk wrote: > > The panic device is currently documented as a way for "libvirt to receive > > panic notification from a QEMU guest". > > > > This is true, but not the whole story.

Re: [libvirt] [PATCH v2 06/38] virfdstream: Use messages instead of pipe

On Thu, Apr 20, 2017 at 12:01:35PM +0200, Michal Privoznik wrote: > One big downside of using the pipe to transfer the data is that > we can really transfer just bare data. No metadata can be carried > through unless some formatted messages are introduced. That would > be quite painful to achieve

Re: [libvirt] [PATCH 14/14] qemu: command: Add support for HTTP cookies

On Thu, Apr 27, 2017 at 05:46:16PM +0200, Peter Krempa wrote: > On Thu, Apr 27, 2017 at 16:30:44 +0100, Daniel Berrange wrote: > > On Wed, Apr 26, 2017 at 07:52:44PM +0200, Peter Krempa wrote: > > > Format the string into the "curl" format so that it's accepted by qemu. > > > > > > Partially

Re: [libvirt] [PATCH 14/14] qemu: command: Add support for HTTP cookies

On Wed, Apr 26, 2017 at 07:52:44PM +0200, Peter Krempa wrote: > Format the string into the "curl" format so that it's accepted by qemu. > > Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140164 [snip] > diff --git

Re: [libvirt] [PATCH 4/4] cpu: Avoid c99 style of assembler

On Thu, Apr 27, 2017 at 09:22:04AM +0100, Daniel P. Berrange wrote: > On Thu, Apr 27, 2017 at 09:24:54AM +0200, Peter Krempa wrote: > > On Thu, Apr 27, 2017 at 09:02:00 +0200, Michal Privoznik wrote: > > > In c89 - the standard we claim to support - there is no asm() > >

Re: [libvirt] [PATCH 3/4] lib: Fix c99 style comments

On Thu, Apr 27, 2017 at 11:09:29AM +0200, Michal Privoznik wrote: > On 04/27/2017 10:19 AM, Daniel P. Berrange wrote: > > On Thu, Apr 27, 2017 at 09:01:59AM +0200, Michal Privoznik wrote: > >> We prefer c89 style of comments. > >> > >> Signed-off-by: M

Re: [libvirt] [PATCH 4/4] cpu: Avoid c99 style of assembler

On Thu, Apr 27, 2017 at 09:24:54AM +0200, Peter Krempa wrote: > On Thu, Apr 27, 2017 at 09:02:00 +0200, Michal Privoznik wrote: > > In c89 - the standard we claim to support - there is no asm() > > I'm not quite sure about the truth of this statement. Especially after > commits like: > >

Re: [libvirt] [PATCH 3/4] lib: Fix c99 style comments

On Thu, Apr 27, 2017 at 09:01:59AM +0200, Michal Privoznik wrote: > We prefer c89 style of comments. > > Signed-off-by: Michal Privoznik > --- > examples/openauth/openauth.c | 2 +- > src/lxc/lxc_controller.c | 2 +- > src/remote/remote_driver.c| 2 +- >

Re: [libvirt] [PATCH 2/4] vmwarevertest: drop VIR_FROM_THIS definition

On Thu, Apr 27, 2017 at 09:36:19AM +0200, Peter Krempa wrote: > On Thu, Apr 27, 2017 at 09:01:58 +0200, Michal Privoznik wrote: > > Firstly, this definition is in a c99 comment, secondly it is not > > needed as VIR_FROM_THIS is defined from vmware/vmware_conf.h. > > > > Signed-off-by: Michal

Re: [libvirt] [ROC] migration: set cpu throttle value by workload

On Wed, Apr 26, 2017 at 07:26:53PM +0800, Chao Fan wrote: > Hi all, > > When migrating a guest which consumes too much CPU & memory, dirty > pages amount will increase significantly, so does the migration > time, migration can not even complete, at worst. > > So I made an RFC patch in QEMU to

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 08:14:31AM -0400, John Ferlan wrote: > Still for the most part, I would "hope" that an S-o-B could come with > the implicit expectation that they've run "make check syntax-check". > Similarly a reviewer would I think for a majority of what they review, > apply the patches

[libvirt] [PATCH] Update keycodemapdb submodule for python2 compat fixes

There were a few bugs in keycodemap tool that broke it when run on python circa 2.7.5 or older, which affected RHEL builds. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a CI build fix for rhel6/7 src/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 11:06:54AM +0200, Kashyap Chamarthy wrote: > On Wed, Apr 26, 2017 at 09:35:47AM +0100, Daniel P. Berrange wrote: > > On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: > > [...] > > > > I realize that if it's not automate

Re: [libvirt] [RFC] Adopting 'Tested-by' tag (and probably other tags)?

On Wed, Apr 26, 2017 at 09:55:50AM +0200, Kashyap Chamarthy wrote: > Hi folks, > > I was wondering if the upstream would be receptive to adding a > 'Tested-by' tag for patches that had someone give tested feedback on the > list. > > Personally, what I consider a bar for giving a 'Tested-by' is,

Re: [libvirt] Unbounded client streams

On Wed, Apr 26, 2017 at 09:48:12AM +0200, Michal Privoznik wrote: > On 04/25/2017 04:06 PM, Daniel P. Berrange wrote: > > On Tue, Apr 25, 2017 at 09:22:51AM +0200, Michal Privoznik wrote: > >> Dear list, > >> > > > > I see three possible options (be

Re: [libvirt] [PATCH v3 1/2] util: switch over to use keycodemapdb GIT submodule

On Tue, Apr 25, 2017 at 07:26:05PM +0200, Andrea Bolognani wrote: > On Tue, 2017-04-25 at 14:51 +0100, Daniel P. Berrange wrote: > > @@ -1,3 +1,6 @@ > >  [submodule "gnulib"] > >   path = .gnulib > >   url = git://git.sv.gnu.org/gnulib.git > > +[submo

Re: [libvirt] Unbounded client streams

On Tue, Apr 25, 2017 at 09:22:51AM +0200, Michal Privoznik wrote: > Dear list, > > as you might have seen, I've been playing with our streams lately. One of > the things I wanted to try was how my sparse streams deal with vol-download > and slow writer (e.g. slow disk). Note to whomever wants to

[libvirt] [PATCH v3 0/2] Use the shared keycodemap database

& verify distcheck Changed in v2: - Fixed make syntax-check errors - Auto-generate man pages listing value key codes for use with the virDomainSendKey API / virsh send-key command Daniel P. Berrange (2): util: switch over to use keycodemapdb GIT submodule Add ability to generate man

[libvirt] [PATCH v3 2/2] Add ability to generate man page describing key code names & values

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 ++ src/Makefile.am | 41 +++-- tools/virsh.pod | 20 4 files changed, 62 insertions(+), 2 deletions(-)

[libvirt] [PATCH v3 1/2] util: switch over to use keycodemapdb GIT submodule

into a dedicated GIT repo for use as a submodule. This allows GTK-VNC, SPICE-GTK, QEMU and libvirt to share the same master database and tools and pushing updates merely requires a submodule commit update as with gnulib. The test suite is updated to cover some extra boundary conditions. Signed-off-by: Daniel P

Re: [libvirt] [PATCH v3 5/8] Add host cache information in capabilities

On Tue, Apr 25, 2017 at 01:10:29PM +0200, Martin Kletzander wrote: > We're only adding only info about L3 caches, we can add more > later (just by changing one line), but for now that's more than enough > without overwhelming anyone. > > XML snippet of how this should look like (also seen as part

Re: [libvirt] [PATCH v2] autogen.sh: Improve and generalize

On Thu, Apr 20, 2017 at 07:54:39PM +0200, Andrea Bolognani wrote: > The goal is twofold: firstly, we want to extend the script so > that it can deal with more than a single git submodule, and > secondly we'd like to reduce the amount of duplicated code. > Moreover, since we're making heavy changes

Re: [libvirt] [PATCH go-xml] add support for domain features

On Sat, Apr 22, 2017 at 02:53:48PM -0700, Ryan Goodfellow wrote: > This commit adds support for domain features. It does so by introducing > a new family of types DomainFeature*. The aggregate type > DomainFeatureList has been added to the Domain type to plumb in the new > type family. Testing has

Re: [libvirt] [PATCH go-xml] Support for filesystem devices

On Tue, Apr 18, 2017 at 03:01:18PM -0700, Ryan Goodfellow wrote: > This commit adds filesystem device support. A new family of types > DomainFilesystem* are introduced and plumbed into the DomainDeviceList > struct. > > Testing has also been included. > --- > domain.go | 40

Re: [libvirt] [PATCH] [PATCH] rpc: fix keep alive timer segfault

On Mon, Apr 24, 2017 at 11:15:31AM +0200, Michal Privoznik wrote: > On 04/24/2017 05:31 AM, wang.y...@zte.com.cn wrote: > > Hi Michal, > > > > > > > > Thanks for your review. The problem occured in a python applicatin using > > libvirt-python, which has no ref(). If we unref() first in > >

[libvirt] [PATCH] util: fix virNetDevSetCoalesce fallback on Win32/FreeBSD

-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix src/util/virnetdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 6ff1b48..27f1637 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -

[libvirt] [PATCH] docs: fix typo in closing HTML element

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as a build fix docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5469fc3..9bea3bc 100644 --- a/docs/formatdomain.h

Re: [libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

On Fri, Apr 21, 2017 at 11:43:52AM +0200, Christophe de Dinechin wrote: > > > BTW, if you really run 4K VMs on a single host, assigning one port per VM > for display will become a problem anyway. There are only 64K ports available, > so using 4K just for displays does not scale well, not even

Re: [libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

On Fri, Apr 21, 2017 at 10:26:09AM +0100, Daniel P. Berrange wrote: > On Fri, Apr 21, 2017 at 11:20:11AM +0200, Peter Krempa wrote: > > On Fri, Apr 21, 2017 at 11:02:36 +0200, Christophe de Dinechin wrote: > > > In order to avoid conflict with the default port (5900) for host

Re: [libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

On Fri, Apr 21, 2017 at 11:20:11AM +0200, Peter Krempa wrote: > On Fri, Apr 21, 2017 at 11:02:36 +0200, Christophe de Dinechin wrote: > > In order to avoid conflict with the default port (5900) for host VNC server > > (vino-server for example), or to conflict with X11 (starting at port 6000), > >

Re: [libvirt] How to get VM memory usage

On Fri, Apr 21, 2017 at 09:58:12AM +0800, wangyuf...@cloudguarding.com wrote: > Hi Daniel, > > In method 'GetInfo', we can only get memory and max memory. However I > need to get used memory for calculating memory usage. The virsh command > 'dommemstat' can obtain used memory, is there a method

Re: [libvirt] [PATCH go-xml] Support for filesystem devices

On Thu, Apr 20, 2017 at 09:56:59PM -0700, Ryan Goodfellow wrote: > Hi Folks, > > Any thoughts on this? This is my first time posting to this list, not sure > if I should direct the patch at someone in particular. Sorry for the delay, this is on my todo list to review... > > On Tue, Apr 18,

Re: [libvirt] [RFC] Add support for QEMU's l3-cache CPU property

On Thu, Apr 20, 2017 at 02:44:00PM +0200, Jiri Denemark wrote: > On Thu, Apr 20, 2017 at 11:07:27 +0100, Daniel P. Berrange wrote: > > On Thu, Apr 20, 2017 at 11:53:21AM +0200, Jiri Denemark wrote: > > > On Thu, Apr 20, 2017 at 10:02:38 +0100, Daniel P. Berrange wrote: > >

Re: [libvirt] [RFC] Add support for QEMU's l3-cache CPU property

On Thu, Apr 20, 2017 at 11:53:21AM +0200, Jiri Denemark wrote: > On Thu, Apr 20, 2017 at 10:02:38 +0100, Daniel P. Berrange wrote: > > On Tue, Apr 18, 2017 at 04:22:36PM +0200, Jiri Denemark wrote: > > > Hi, > > > > > > Apparently, reporting a level 3 cac

Re: [libvirt] [PATCH] virsh: report errors in virshInit()

On Wed, Apr 19, 2017 at 08:10:22PM -0400, John Ferlan wrote: > > > On 04/19/2017 06:43 AM, Daniel P. Berrange wrote: > > There are several functions in virshInit which can fail, especially > > when running win32 builds under WINE. Currently virsh just exits > > w

Re: [libvirt] [RFC] Add support for QEMU's l3-cache CPU property

On Tue, Apr 18, 2017 at 04:22:36PM +0200, Jiri Denemark wrote: > Hi, > > Apparently, reporting a level 3 cache on a virtual CPU can dramatically > increase performance in some use cases [1]. The interesting part is that > l3-cache=on does not provide the real CPU cache data, it's just making > it

Re: [libvirt] How to get VM memory usage

On Thu, Apr 20, 2017 at 09:33:12AM +0800, wangyuf...@cloudguarding.com wrote: > Hello everyone, > > Could you tell me how to get VM memory usage from libvirt-go? The virDomainGetInfo() method includes memory data. Thi is the 'GetInfo()' method on a Domain object in Go Regards, Daniel -- |:

Re: [libvirt] [PATCH] Increase default task limit for libvirtd

On Wed, Apr 19, 2017 at 01:29:01PM -0600, Jim Fehlig wrote: > libvirtd can spawn threads/tasks when creating new domains for > some hypervisors such as Xen's libxl driver, quickly reaching > the cgroups pids controller default TasksMax setting of 512. When > the limit is reached, attempting to

Re: [libvirt] increase daemon task limit

On Wed, Apr 19, 2017 at 01:11:41PM -0600, Jim Fehlig wrote: > On 04/19/2017 09:16 AM, Daniel P. Berrange wrote: > > On Wed, Apr 19, 2017 at 09:03:55AM -0600, Jim Fehlig wrote: > > > I recently received a report of a libvirt+Xen installation reaching the > > > pids >

Re: [libvirt] increase daemon task limit

On Wed, Apr 19, 2017 at 09:03:55AM -0600, Jim Fehlig wrote: > I recently received a report of a libvirt+Xen installation reaching the pids > cgroup controller TasksMax limit > > kernel: [71282.213347] cgroup: fork rejected by pids controller in > /system.slice/libvirtd.service > > The default

[libvirt] [PATCH] virt-storage-rbd: fix typo s/RDB/RBD/ in configure check

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed as trivial build fix. m4/virt-storage-rbd.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4 index 727bd71..17e2115 100644 --- a/m4/virt-storage-rbd.m4 ++

[libvirt] [PATCH] virsh: report errors in virshInit()

There are several functions in virshInit which can fail, especially when running win32 builds under WINE. Currently virsh just exits without reporting what error happened. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tools/virsh.c | 12 +--- 1 file changed, 9 inse

Re: [libvirt] [PATCH] spec: Avoid RPM verification errors on nwfilter XMLs

On Thu, Apr 13, 2017 at 02:41:42PM +0200, Jiri Denemark wrote: > On Thu, Apr 13, 2017 at 13:28:18 +0100, Daniel P. Berrange wrote: > > On Thu, Apr 13, 2017 at 02:23:08PM +0200, Jiri Denemark wrote: > > > /etc/libvirt/nwfilter/*.xml files are installed with no UUID, which &g

Re: [libvirt] [libvirt-perl][PATCH] Fix typo in NodeDevice.pm

On Wed, Apr 19, 2017 at 04:23:55PM +0800, Dan Zheng wrote: > In commit 24a7f8b41ed09e885120af5336de69d3d4c91980, node device events > were written with storage pool prefix by mistake. > > Signed-off-by: Dan Zheng > --- > lib/Sys/Virt/NodeDevice.pm | 4 ++-- > 1 file changed,

Re: [libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize

On Wed, Apr 19, 2017 at 09:02:50AM +0200, Andrea Bolognani wrote: > On Tue, 2017-04-18 at 16:41 +0100, Daniel P. Berrange wrote: > > What is it that makes out submodule handling so complicated. eg in gtk-vnc > > and spice-gtk, we have a trivial line in autogen.sh > >  >

[libvirt] [PATCH] Fix error reporting when poll returns POLLHUP/POLLERR

-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetclient.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 5174614..c959747 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1

Re: [libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize

On Tue, Apr 18, 2017 at 04:31:16PM +0200, Andrea Bolognani wrote: > This work was motivated by Dan's intention to introduce the > keycodemapdb module into libvirt[1]. As it is, we have a few > useful submodule-related features in our build system, but > they are limited in that they assume there

Re: [libvirt] Trouble with virsh on Windows

On Tue, Apr 18, 2017 at 01:55:17PM +0100, Daniel P. Berrange wrote: > On Tue, Apr 18, 2017 at 01:41:27PM +0100, Daniel P. Berrange wrote: > > On Tue, Apr 18, 2017 at 08:02:35AM -0400, Charles Bancroft wrote: > > > 2017-04-18 11:46:23.879+: 1: debug : virNetClientMarkClose:

Re: [libvirt] Trouble with virsh on Windows

On Tue, Apr 18, 2017 at 01:41:27PM +0100, Daniel P. Berrange wrote: > On Tue, Apr 18, 2017 at 08:02:35AM -0400, Charles Bancroft wrote: > > 2017-04-18 11:46:23.879+: 1: debug : virNetClientMarkClose:776 : > > client=00faa9a0, reason=1 > > We're marking the conn

Re: [libvirt] Trouble with virsh on Windows

On Tue, Apr 18, 2017 at 08:02:35AM -0400, Charles Bancroft wrote: > > > On 4/18/2017 4:48 AM, Daniel P. Berrange wrote: > > On Mon, Apr 17, 2017 at 09:49:01AM -0400, Charles Bancroft wrote: > >> Hi List, > >> > >> I have a question about some troubles

Re: [libvirt] [PATCH 06/38] virfdstream: Use messages instead of pipe

On Tue, Apr 18, 2017 at 02:00:09PM +0200, Michal Privoznik wrote: > On 04/13/2017 07:13 PM, Daniel P. Berrange wrote: > > On Thu, Apr 13, 2017 at 06:52:31PM +0200, Michal Privoznik wrote: > > > On 04/13/2017 03:55 PM, Daniel P. Berrange wrote: > > > > On Thu, Ap

Re: [libvirt] server side copy from one volume to another

On Tue, Apr 18, 2017 at 01:31:11PM +0200, Michal Privoznik wrote: > On 04/18/2017 01:03 PM, Vasiliy Tolstov wrote: > > 2017-04-18 8:39 GMT+03:00 Michal Privoznik : > > > s that right? Here I'm successfully cloning a volume across two storage > > > pools: > > > > > > Yes, it

Re: [libvirt] Add mdev reporting capability to the nodedev driver

On Tue, Apr 18, 2017 at 10:49:40AM +0200, Martin Polednik wrote: > On 12/04/17 16:19 -0600, Alex Williamson wrote: > > On Wed, 5 Apr 2017 09:21:17 +0100 > > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > > > On Wed, Apr 05, 2017 at 08:12:3

Re: [libvirt] Trouble with virsh on Windows

On Mon, Apr 17, 2017 at 09:49:01AM -0400, Charles Bancroft wrote: > Hi List, > > I have a question about some troubles I am having with virsh on Windows > x64. I am currently running a KVM server on a linux box and need to > allow Windows clients to access it. I have set up the server for

Re: [libvirt] [PATCH 06/38] virfdstream: Use messages instead of pipe

On Thu, Apr 13, 2017 at 06:52:31PM +0200, Michal Privoznik wrote: > On 04/13/2017 03:55 PM, Daniel P. Berrange wrote: > > On Thu, Apr 13, 2017 at 03:31:14PM +0200, Michal Privoznik wrote: > >> One big downside of using the pipe to transfer the data is that > >> we ca

Re: [libvirt] [RFC PATCH] Drop autobuild.sh

On Thu, Apr 13, 2017 at 05:06:56PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed to > be used with, hasn't seen any activity in ~6 years; libvirt's > own CI is running on Jenkins with a completely independent > setup that doesn't use the script at all. >

Re: [libvirt] [PATCH] Don't ship autogen.sh in release tarballs

On Thu, Apr 13, 2017 at 10:11:50AM -0500, Eric Blake wrote: > On 04/13/2017 10:06 AM, Andrea Bolognani wrote: > > autogen.sh is only useful for developers, not users, and we > > expect developers to have a git checkout handy, so there's > > no point in shipping the script in release tarballs. > >

Re: [libvirt] [PATCH 06/38] virfdstream: Use messages instead of pipe

On Thu, Apr 13, 2017 at 03:31:14PM +0200, Michal Privoznik wrote: > One big downside of using the pipe to transfer the data is that > we can really transfer just bare data. No metadata can be carried > through unless some formatted messages are introduced. That would > be quite painful to achieve

Re: [libvirt] [PATCH] spec: Avoid RPM verification errors on nwfilter XMLs

On Thu, Apr 13, 2017 at 02:23:08PM +0200, Jiri Denemark wrote: > /etc/libvirt/nwfilter/*.xml files are installed with no UUID, which > means libvirtd will automatically alter all of them once it starts. Thus > RPM verification will always fail on them. Let's use a trick similar to > the default

Re: [libvirt] [PATCH] util: add missing equal sign in initialization

On Thu, Apr 13, 2017 at 02:14:16PM +0200, Ján Tomko wrote: > Fix the build with clang: > util/virperf.c:86:27: error: use of GNU 'missing =' extension > in designator [-Werror,-Wgnu-designator] > [VIR_PERF_EVENT_MBML] { > ^ > = Fun, I'm

Re: [libvirt] question about virtlogd service restart

On Thu, Apr 13, 2017 at 02:50:52PM +0800, Wang King wrote: > Hi all, > > I found that virtlogd cannot write qemu log and serial log anymore after > restart it. It's because of the file descriptor which qemu connected to the > virtlogd is broken, and cannot be reconnect after virtlogd restarted. >

Re: [libvirt] [PATCH v2 1/2] perf: get rid of pointless virPerfGetEventAttr() method

On Wed, Apr 12, 2017 at 03:26:36PM +0200, Ján Tomko wrote: > On Wed, Apr 12, 2017 at 12:27:11PM +0100, Daniel P. Berrange wrote: > > The virPerfGetEventAttr method contains a totally pointless > > loop. Remove it, verify the array size statically, and then > > just use an

[libvirt] RFC: fixing struct name in public header

Take a look at this def from libvirt-domain.h: typedef struct _virDomainInterfaceIPAddress virDomainIPAddress; typedef virDomainIPAddress *virDomainIPAddressPtr; struct _virDomainInterfaceIPAddress { int type;/* virIPAddrType */ char *addr; /* IP address */

[libvirt] [PATCH v2 1/2] perf: get rid of pointless virPerfGetEventAttr() method

The virPerfGetEventAttr method contains a totally pointless loop. Remove it, verify the array size statically, and then just use an array index to access the perf event. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/virperf.c

<    3   4   5   6   7   8   9   10   11   12   >